Close the squad P1 gaps the audit listed for this batch #8

Merged
weichen merged 3 commits from feature/agent-stack-r2 into main 2026-10-03 13:22:55 +00:00
Owner

Why: parallel groups dropped a hold, HITL timeouts were unused, and the planner failed closed on any model error.
Evidence: GOWORK=off go test -count=1 -race ./squad/ ./squadintent/ ./store/ ./platform/ passed; head 1bb0c3a pins native 11d1a76 and intent 05e74d8.
Impact: a failed or held parallel sibling cancels the rest; the intent gate follows Registry.Reload.
Refs: Q6 Q10 Q11 Q12 Q13 Q17 Q18 Q19 I9

Why: parallel groups dropped a hold, HITL timeouts were unused, and the planner failed closed on any model error. Evidence: GOWORK=off go test -count=1 -race ./squad/ ./squadintent/ ./store/ ./platform/ passed; head 1bb0c3a pins native 11d1a76 and intent 05e74d8. Impact: a failed or held parallel sibling cancels the rest; the intent gate follows Registry.Reload. Refs: Q6 Q10 Q11 Q12 Q13 Q17 Q18 Q19 I9
weichen added 2 commits 2026-10-03 13:12:21 +00:00
Why: parallel groups dropped a hold, HITL timeouts were unused, the planner failed closed on any model error, and event sequence numbers restarted at 1.
Evidence: GOWORK=off go test -count=1 -race ./squad/ ./squadintent/ ./store/ ./platform/ passed, including TestR2ExpiredDecisionUsesCancel, TestR2IntentStepSkipsRoleRegistry, TestR2PlannerFallsBackAndCapsSteps, TestR2TaskFileUsesLatestBlackboard, TestR2FanoutCancelDoesNotPanic, TestR2EventSeqContinuesAfterRestart, TestR2JournalModeWAL, and TestR2GateReloadSeesNewIntent.
Impact: a failed or held parallel sibling cancels the rest; expired requests synthesize cancel or fail; the intent gate follows Registry.Reload.
Refs: Q6, Q10, Q11, Q12, Q13, Q17, Q18, Q19, I9
Co-authored-by: Cursor <cursoragent@cursor.com>
Pin agent-native and agent-intent to the R2 heads
ci / vet-and-test (pull_request) Failing after 14s
ci / docker-checkout-hostgateway (pull_request) Successful in 0s
1bb0c3a2ae
Why: squad must build against the native and intent commits that carry this batch.
Evidence: agent-intent 05e74d8 and agent-native 11d1a76 are the feature/agent-stack-r2 heads whose race tests passed.
Impact: nested gitlinks move; squad behavior otherwise stays on the preceding commit.
Refs: Q6, I9
Co-authored-by: Cursor <cursoragent@cursor.com>
weichen added 1 commit 2026-10-03 13:13:48 +00:00
Pin agent-native to the commit that records the text sum
ci / vet-and-test (pull_request) Successful in 48s
ci / docker-checkout-hostgateway (pull_request) Successful in 1s
31ee395895
Why: squad vet failed against native 11d1a76 because that module did not yet sum golang.org/x/text.
Evidence: GOWORK=off go vet ./squad/ ./squadintent/ ./platform/ ./cli/ passed on native 855fe41.
Impact: the native gitlink and this module's go.sum move. Squad behavior is unchanged.
Refs: I4
Co-authored-by: Cursor <cursoragent@cursor.com>
weichen merged commit 20a9eb8078 into main 2026-10-03 13:22:55 +00:00
Sign in to join this conversation.
No Reviewers
No labels
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: weichen/Agent-Squad#8