weichen/Agent-System-Backend
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Guard nil confirm card in surface action dispatcher #173

Merged
weichen merged 1 commits from fix/surface-action-nil-card into main 2026-10-12 04:08:58 +00:00
Conversation 0 Commits 1 Files Changed 1
+5 -1
weichen commented 2026-10-12 04:08:48 +00:00
Owner
Copy Link
Copy Source

Prevent nil deref on committed surface actions without confirm cards.

Prevent nil deref on committed surface actions without confirm cards.
weichen added 1 commit 2026-10-12 04:08:48 +00:00
Guard nil confirm card in surface action dispatcher
ci / vet-and-test (pull_request) Successful in 44s
Details
4352f368cb 
Why: Committed button actions with no HITL card panicked on
resp.Card.ID during prod acceptance (nil pointer).
Evidence: go test ./internal/app/ ./internal/surfacesvc/; prod panic stack
Impact: B-class help/intent and C-class submit return without crash.
Refs: GenUI prod deploy acceptance

Co-authored-by: Cursor <cursoragent@cursor.com>
weichen merged commit c7b30d2109 into main 2026-10-12 04:08:58 +00:00
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
weichen
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: weichen/Agent-System-Backend#173