Agent-System-Backend: review fixes for chat-process-split-r1 (symlink, live interleaving, artifact process) #21

2026-09-30T16:13:45Z

weichen commented

2026-09-30 16:13:45 +00:00

Review fixes for chat-process-split-r1: mark artifact_ref parts as process; merge main.

Why: 复审发现工具产生的工件引用部件未带 Process，终态折叠时残留在回复区；与同轮 tool_call/tool_result 不一致。
Evidence: llm.go 补 Process: true；新增 TestLLMRunnerArtifactPartIsProcess；合入 main（PR #18/#19）后 go test ./... 全 ok；make test 组合退出码 0。
Impact: 落库消息的工件引用随过程折叠。Refs: feature/chat-process-split-r1 复审（2026-09-30）。

Review fixes for chat-process-split-r1: mark artifact_ref parts as process; merge main. Why: 复审发现工具产生的工件引用部件未带 Process，终态折叠时残留在回复区；与同轮 tool_call/tool_result 不一致。 Evidence: llm.go 补 Process: true；新增 TestLLMRunnerArtifactPartIsProcess；合入 main（PR #18/#19）后 go test ./... 全 ok；make test 组合退出码 0。 Impact: 落库消息的工件引用随过程折叠。Refs: feature/chat-process-split-r1 复审（2026-09-30）。

weichen added 3 commits 2026-09-30 16:13:45 +00:00

Mark tool-turn reply text as process so only the final turn reads as the answer 0e76f599fc

Why: 中栏过程/回复分离（Cursor 式）需要数据基础：工具轮的解说文本与终轮回复在中栏混排，用户难以扫读最终答复。
Evidence: go test ./internal/runtime/ 新增 TestLLMRunnerToolTurnTextIsProcess / TestLLMRunnerPhaseEventsPerTurn（脚本流注入）；go test ./... 全绿。
Impact: 持久化助手消息中工具轮 text 部件带 process=true（终态折叠入过程区）；终轮文本不变；无契约类型变更。
Refs: 任务卡 feature/chat-process-split-r1；提案 cardflow-and-process-split（编制中）。

Mark artifact reference parts as process output ae8e5d0007

Why: tool-produced artifact_ref parts were appended without Process,
unlike the tool_call/tool_result parts of the same turn, so on final
reconcile the artifact chip stayed in the reply area instead of folding
into the process summary.

Evidence: llm.go now sets Process: true on PartArtifactRef next to its
tool parts; new TestLLMRunnerArtifactPartIsProcess drives a tool turn
that produces an artifact and asserts the part exists, is marked, and
carries the artifact ref. go test ./... all packages ok.

Impact: persisted assistant messages fold artifact references into the
collapsed process area, consistent with other tool-turn output.

Refs: code review of feature/chat-process-split-r1 (2026-09-30)

Merge main into feature/chat-process-split-r1 9e694c074a

weichen added 1 commit 2026-09-30 16:14:44 +00:00

Merge main into feature/chat-process-split-r1 76d64a1f75

weichen merged commit fa494c3715 into main

2026-09-30 16:15:19 +00:00

weichen referenced this pull request

2026-10-07 07:50:37 +00:00

Point the nested pins at the I1 router combination #75

weichen referenced this issue from a commit

2026-10-07 07:50:37 +00:00

Point the nested pins at the I1 router combination

weichen referenced this issue from a commit