Why: The Postgres CI job flaked on TestExplicitWorkReferenceRejectsOtherConversationBeforeWriting (Dev run 4471 attempt 1): the run did not turn terminal within the hardcoded 5s wait while the identical content passed on adjacent runs (#653 HEAD) and on rerun. The server e2e waits measure load, not behavior.
Changes:
Add one shared testRunTerminalTimeout = 30s constant in internal/server/e2e_test.go.
Use it for every run-terminal wait (waitRunTerminal / waitRunCompleted and the raw run-terminal polling deadlines) in internal/server/e2e_test.go and internal/server/workcard_test.go.
No production code, no assertion removed or loosened; healthy runs still return as soon as the run settles.
Evidence:
agent-exec unit be-server-e2e-terminal-wait (cursor, attempt 1, transport 58228c2); changed paths exactly internal/server/e2e_test.go + workcard_test.go.
Local SELF @58228c2: gofmt -l internal/server clean; go vet ./internal/server ok; go test ./internal/server -count=1 ok (31s).
Authority is CI on this PR HEAD.
Impact: Test-only wait windows in internal/server.
Refs: Dev CI run 4471 (test-pg flake); precedent #226 bounded CI test repair.
Why: The Postgres CI job flaked on `TestExplicitWorkReferenceRejectsOtherConversationBeforeWriting` (Dev run 4471 attempt 1): the run did not turn terminal within the hardcoded 5s wait while the identical content passed on adjacent runs (#653 HEAD) and on rerun. The server e2e waits measure load, not behavior.
Changes:
- Add one shared `testRunTerminalTimeout = 30s` constant in `internal/server/e2e_test.go`.
- Use it for every run-terminal wait (`waitRunTerminal` / `waitRunCompleted` and the raw run-terminal polling deadlines) in `internal/server/e2e_test.go` and `internal/server/workcard_test.go`.
- No production code, no assertion removed or loosened; healthy runs still return as soon as the run settles.
Evidence:
- agent-exec unit `be-server-e2e-terminal-wait` (cursor, attempt 1, transport 58228c2); changed paths exactly internal/server/e2e_test.go + workcard_test.go.
- Local SELF @58228c2: `gofmt -l internal/server` clean; `go vet ./internal/server` ok; `go test ./internal/server -count=1` ok (31s).
- Authority is CI on this PR HEAD.
Impact: Test-only wait windows in internal/server.
Refs: Dev CI run 4471 (test-pg flake); precedent #226 bounded CI test repair.
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Why: The Postgres CI job flaked on
TestExplicitWorkReferenceRejectsOtherConversationBeforeWriting(Dev run 4471 attempt 1): the run did not turn terminal within the hardcoded 5s wait while the identical content passed on adjacent runs (#653 HEAD) and on rerun. The server e2e waits measure load, not behavior.Changes:
testRunTerminalTimeout = 30sconstant ininternal/server/e2e_test.go.waitRunTerminal/waitRunCompletedand the raw run-terminal polling deadlines) ininternal/server/e2e_test.goandinternal/server/workcard_test.go.Evidence:
be-server-e2e-terminal-wait(cursor, attempt 1, transport58228c2); changed paths exactly internal/server/e2e_test.go + workcard_test.go.gofmt -l internal/serverclean;go vet ./internal/serverok;go test ./internal/server -count=1ok (31s).Impact: Test-only wait windows in internal/server.
Refs: Dev CI run 4471 (test-pg flake); precedent #226 bounded CI test repair.