Close the W6 review MINOR findings #242

Merged
weichen merged 1 commits from fix/w6-review-minors into main 2026-10-22 03:07:56 +00:00
Owner

Why: Close the 6 MINOR findings from the independent W6 review (docs/reviews/2026-10-20-w6-x1-recheck-review.md): documented fail-closed comparison contract and deterministic set comparison for Recheck, explicit negative test for same-ReferenceID/different-body, load-bearing comment on the final ctx.Err(), differentiated invalid-argument errors in the app entry, unit coverage for cross-project/cross-owner attempt reuse, and the strict-mode trust invariant documented on renderRefs.

Evidence: unit w6-review-minors (cursor, transport 4c2db4c8); SELF gofmt/build/vet ok; store 15.5s, runmgr 6.7s, app 5.5s tests all ok. GATE is CI on this PR HEAD.

Impact: internal/runmgr, internal/app, internal/store, internal/wfcompile, pkg/extension — comments, error differentiation and tests only.

Refs: PR #231; docs/reviews/2026-10-20-w6-x1-recheck-review.md.

Why: Close the 6 MINOR findings from the independent W6 review (docs/reviews/2026-10-20-w6-x1-recheck-review.md): documented fail-closed comparison contract and deterministic set comparison for Recheck, explicit negative test for same-ReferenceID/different-body, load-bearing comment on the final ctx.Err(), differentiated invalid-argument errors in the app entry, unit coverage for cross-project/cross-owner attempt reuse, and the strict-mode trust invariant documented on renderRefs. Evidence: unit w6-review-minors (cursor, transport 4c2db4c8); SELF gofmt/build/vet ok; store 15.5s, runmgr 6.7s, app 5.5s tests all ok. GATE is CI on this PR HEAD. Impact: internal/runmgr, internal/app, internal/store, internal/wfcompile, pkg/extension — comments, error differentiation and tests only. Refs: PR #231; docs/reviews/2026-10-20-w6-x1-recheck-review.md.
weichen added 1 commit 2026-10-22 03:05:46 +00:00
agent-exec transport baad876f1320016310be2522c373a71b/9d3ed5593bfb
governance / governance (pull_request) Successful in 17s
ci / vet-and-test (pull_request) Successful in 1m27s
4c2db4c89b
weichen merged commit 275b1e234d into main 2026-10-22 03:07:56 +00:00
Sign in to join this conversation.
No Reviewers
No labels
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: weichen/Agent-System-Backend#242