Land the agent stack audit batch-1 fixes on main #244

Merged
weichen merged 10 commits from fix/agent-stack-audit-b1 into main 2026-10-22 04:00:42 +00:00
Owner

Why: Dev main's batch-1 composition (U1-U7, U10) pins modules/backend at b6141800,
but Backend main never absorbed those commits. Later parallel pin advances (PR #682
f23f5bb0, repin 97f3c85b to f084d10) silently reverted the composition on Dev main
because the underlying Backend work was not on Backend main. Landing batch-1 here
removes that structural fragility; batch-2 (fix/agent-stack-audit-b2) is stacked
directly on this branch (f8e9e9f's parent is b614180).

Evidence:

  • Merge check: git merge-tree origin/main origin/fix/agent-stack-audit-b1 -> clean, no conflicts
  • Dev PR #685 merged this exact composition (modules/backend=b6141800) after full combo
    verification (make test) and independent review
    (Agent-System-Dev .task/reviews/2026-10-21-agent-stack-b1-independent-review.md)
  • All four nested dep pins are reachable on their component origins:
    agent-command fe7987d, agent-intent 765a7e7, agent-native ac91b84, agent-squad 0f1daa8
  • CI on this PR head gates the merge

Impact: 9 commits, 33 files (+2749/-177): squad routing resolved from run owner and
project, intent admission with full slot validity and schema-typed slots, honest
receipts when handlers err after side effects, server operation query endpoint,
admission test boundary, nested dep pin bumps.

Refs: Agent-System-Dev PR #685; Dev task card feature-agent-stack-audit-remediation-b1

Why: Dev main's batch-1 composition (U1-U7, U10) pins modules/backend at b6141800, but Backend main never absorbed those commits. Later parallel pin advances (PR #682 f23f5bb0, repin 97f3c85b to f084d10) silently reverted the composition on Dev main because the underlying Backend work was not on Backend main. Landing batch-1 here removes that structural fragility; batch-2 (fix/agent-stack-audit-b2) is stacked directly on this branch (f8e9e9f's parent is b614180). Evidence: - Merge check: git merge-tree origin/main origin/fix/agent-stack-audit-b1 -> clean, no conflicts - Dev PR #685 merged this exact composition (modules/backend=b6141800) after full combo verification (make test) and independent review (Agent-System-Dev .task/reviews/2026-10-21-agent-stack-b1-independent-review.md) - All four nested dep pins are reachable on their component origins: agent-command fe7987d, agent-intent 765a7e7, agent-native ac91b84, agent-squad 0f1daa8 - CI on this PR head gates the merge Impact: 9 commits, 33 files (+2749/-177): squad routing resolved from run owner and project, intent admission with full slot validity and schema-typed slots, honest receipts when handlers err after side effects, server operation query endpoint, admission test boundary, nested dep pin bumps. Refs: Agent-System-Dev PR #685; Dev task card feature-agent-stack-audit-remediation-b1
weichen added 9 commits 2026-10-22 03:54:50 +00:00
Why: F13 - the squad factory read the default account with an empty
project, pairing the run user's model name with another account's
endpoint and credentials; direct and squad paths disagreed on
reasoning split and route contract.
Evidence: app/runtime/squadadapter tests pass (verify-u10b.json);
run-scoped snapshot, project override, profile override and
fail-closed cases added with synthetic keys.
Impact: squad execution now uses the same effective-config rules as
the direct path; default setups unchanged.
Refs: feature/agent-stack-audit-remediation-b1 U10
Why: U6 needs the authoritative recognition result with full slot
validation and isolated snapshots landed by U5.
Evidence: pin only; library verified in deps/agent-intent (verify-u5).
Impact: nested gitlink pointer change.
Refs: feature/agent-stack-audit-remediation-b1
Why: F09 - invalid slot information was dropped at the gate, the router
saw only Start, and the command entrance passed untyped text, so
invalid-slot recognitions could still reach business execution paths.
Evidence: intentgate/route/server tests pass (verify-u6.json);
admission regression cases added.
Impact: invalid or missing slots never start executable actions;
clarification flows unchanged; cmdbus confirmation untouched.
Refs: feature/agent-stack-audit-remediation-b1 U6
Why: U7B needs unknown-with-trusted-operation-ID receipts and the
executed-vs-not result distinction landed by U7A.
Evidence: pin only; library verified in deps/agent-command (verify-u7a).
Impact: nested gitlink pointer change.
Refs: feature/agent-stack-audit-remediation-b1
Why: F10 - any handler error became a no-side-effect rejected receipt
and an audit-store failure dropped the generated operation ID, losing
the reconciliation handle and inviting unsafe retries.
Evidence: cmdbus tests pass (verify-u7b.json); post-execution-unknown,
audit-failure-keeps-ID and confirmation-idempotency cases added.
Impact: unknown receipts now carry the trusted operation ID via the
U7A constructor; rejected stays ID-free; no auto-replay anywhere.
Refs: feature/agent-stack-audit-remediation-b1 U7B
Why: the U6 admission test imported agent-intent directly from
internal/server, which lint-boundaries forbids (only intentgate,
intentsem and the squad intent adapter may import it).
Evidence: repair receipt success; server/intentgate/route tests pass
(verify-u6r.json); fixtures moved behind intentgate helpers.
Impact: test-only rework plus a small intentgate fixture helper.
Refs: feature/agent-stack-audit-remediation-b1 U6 repair
Why: composition consistency - Dev pins agent-native at the U3A tip
and agent-squad at the U3B/U4 tip; the backend container's nested
copies must match (check-pins).
Evidence: pin only; all libraries verified per-unit.
Impact: nested gitlink pointer changes.
Refs: feature/agent-stack-audit-remediation-b1
Why: composition consistency - the squad container advanced to the
U3B repair tip; backend's nested copy must match (check-pins).
Evidence: pin only; squad store tests pass (verify-u3br2).
Impact: nested gitlink pointer change.
Refs: feature/agent-stack-audit-remediation-b1
Merge commit '528e3a4c1ff9b59c4df998f4fffb39f0b52dbbcd' into fix/agent-stack-audit-b1
ci / vet-and-test (pull_request) Successful in 2m3s
governance / governance (pull_request) Successful in 14s
b6141800cc
weichen added 1 commit 2026-10-22 03:58:47 +00:00
Merge origin/main into fix/agent-stack-audit-b1
governance / governance (pull_request) Successful in 15s
ci / vet-and-test (pull_request) Successful in 1m20s
03f7f39a9b
weichen merged commit b4290c03bd into main 2026-10-22 04:00:42 +00:00
Sign in to join this conversation.
No Reviewers
No labels
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: weichen/Agent-System-Backend#244