Complete the B10 assembly: MCP config, subagent bridge, explicit roles, and skill-borne recipes #36

Merged
weichen merged 1 commits from feature/full-agent-b10-r2 into main 2026-10-01 06:19:44 +00:00
Owner

Why: three B10 sub-items from the full-agent plan remained open: MCP server injection, the Subagent factory bridge, explicit builtin-role declarations, and migrating the three Python deliverable recipes into the skills system.

Evidence: go vet ./... clean; go test ./... 21 packages ok (new: skills seeding, subagent bridge mapping, builtin-role assertions, MCP cache behavior).

Impact: internal/skills seeds docx/xlsx/pptx-author SKILL.md into /skills (idempotent, user-edit safe); base.deliverables now references skills; AgentNativeOptions(rc) injects SubagentFactory bridging SpawnSubagent and tools.mcp.servers with a config-keyed manager cache.

Refs: Dev task feature/full-agent-b10-r2.

Why: three B10 sub-items from the full-agent plan remained open: MCP server injection, the Subagent factory bridge, explicit builtin-role declarations, and migrating the three Python deliverable recipes into the skills system. Evidence: go vet ./... clean; go test ./... 21 packages ok (new: skills seeding, subagent bridge mapping, builtin-role assertions, MCP cache behavior). Impact: internal/skills seeds docx/xlsx/pptx-author SKILL.md into <data>/skills (idempotent, user-edit safe); base.deliverables now references skills; AgentNativeOptions(rc) injects SubagentFactory bridging SpawnSubagent and tools.mcp.servers with a config-keyed manager cache. Refs: Dev task feature/full-agent-b10-r2.
weichen added 1 commit 2026-10-01 06:19:41 +00:00
Why: the full-agent batch left three B10 sub-items open - the
composition root lacked MCP server injection and a Subagent factory,
builtin squad roles carried no explicit Tools/Skills/BashPermission
declarations, and the three Python deliverable recipes still lived
inline in the base.deliverables prompt instead of the skills system.

Evidence: go vet ./... clean; go test ./... 21 packages ok. New cases:
skills seeding idempotency with user-edit preservation and sorted
builtin names; the SubagentFactory bridge mapping delegation fields
into SpawnSubagent task briefs and status/errors back; builtin-role
assertions (all four explicit bash permissions, researcher
search+fetch, reviewer grep+glob, writer ask + 3 skills +
run_python/load_skill); MCP manager cache reuse/rebuild/disable
behavior including invalid JSON and config races.

Impact: internal/skills embeds docx/xlsx/pptx-author SKILL.md and
seeds <data>/skills at startup; base.deliverables references the
skills and keeps only import one-liners; squadadapter.AgentNativeOptions
now receives rc and gains SubagentFactory(rc); app.go adds
tools.mcp.servers loading with a config-keyed manager cache (old
manager closed on rebuild).

Refs: Dev task feature/full-agent-b10-r2 (verifier follow-ups).
weichen merged commit 36cf9f648d into main 2026-10-01 06:19:44 +00:00
Sign in to join this conversation.
No Reviewers
No labels
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: weichen/Agent-System-Backend#36