Review follow-up to EXT-5 (#67): a sparse styled cell beyond column 1024 (XFD region) wrongly fired the 200k-cell cap warning and dropped every remaining worksheet; malformed sheet XML was silently skipped; builtin:legacy-office was missing from the parser registry. Wide cells now skip per-sheet with an explicit warning, later sheets survive; bad sheet XML warns and healthy sheets still parse; registry gains doc/xls/ppt. Local GOWORK=off go test ./... 29 packages pass with new regressions (SELF on the Dev task card); PR CI is the GATE.
Review follow-up to EXT-5 (#67): a sparse styled cell beyond column 1024 (XFD region) wrongly fired the 200k-cell cap warning and dropped every remaining worksheet; malformed sheet XML was silently skipped; builtin:legacy-office was missing from the parser registry. Wide cells now skip per-sheet with an explicit warning, later sheets survive; bad sheet XML warns and healthy sheets still parse; registry gains doc/xls/ppt. Local GOWORK=off go test ./... 29 packages pass with new regressions (SELF on the Dev task card); PR CI is the GATE.
Why: review of EXT-5 found a column-cap cell (common styled XFD cells) wrongly reported the 200k-cell cap and aborted every remaining worksheet; malformed sheet XML was also dropped silently, contradicting the explicit-failure contract; the legacy-office parser id was missing from the registry.
Evidence: local GOWORK=off go test ./... 29 packages pass with new regressions (wide column keeps later sheets, bad sheet XML warns, registry maps doc/xls/ppt); go vet clean; recorded as SELF on the Dev task card.
Impact: xlsxSheetBlocks returns wide/badXML signals; wide cells skip with a per-sheet warning, cell-cap truncation unchanged; builtin:legacy-office added to ParsersDescription.
Refs: review of backend 727f370; documents proposal 2026-10-06-ext-5-host-parse-document sect.2.
weichen
merged commit 838f7a5e14 into main2026-10-06 15:39:43 +00:00
Blocking a user prevents them from interacting with repositories, such as opening or commenting on pull requests or issues. Learn more about blocking a user.
Review follow-up to EXT-5 (#67): a sparse styled cell beyond column 1024 (XFD region) wrongly fired the 200k-cell cap warning and dropped every remaining worksheet; malformed sheet XML was silently skipped; builtin:legacy-office was missing from the parser registry. Wide cells now skip per-sheet with an explicit warning, later sheets survive; bad sheet XML warns and healthy sheets still parse; registry gains doc/xls/ppt. Local GOWORK=off go test ./... 29 packages pass with new regressions (SELF on the Dev task card); PR CI is the GATE.