From c8dd169a1fdc1451fab3b475c14f9636a7f5bf6c Mon Sep 17 00:00:00 2001 From: weichen Date: Wed, 14 Oct 2026 03:42:28 +0000 Subject: [PATCH 01/41] Add scoped project command audit read slice Why: Project audit cannot use owner-wide logs or current conversation project state to establish trusted attribution. Evidence: RED cases were observed locally; go test ./pkg/extension ./internal/store ./internal/app -count=1 passed on this tree (SELF). Impact: Add optional X2 read and audit.read callback, immutable project/name snapshots, safe owner-only projection, and explicit unsupported coverage. Cross-member publication remains pending. Refs: Stage 5 W9; Stage 6 X2 public extension request --- .task/feature-rdm-two-trees-project-audit.md | 20 +++ internal/app/app.go | 2 +- internal/app/hostcaps.go | 13 +- internal/app/project_audit.go | 103 +++++++++++ internal/app/project_audit_test.go | 101 +++++++++++ internal/store/audit.go | 63 ++++++- internal/store/migrate.go | 9 + internal/store/migrate_compat.go | 1 + internal/store/project_audit_test.go | 174 +++++++++++++++++++ pkg/extension/extension.go | 4 +- pkg/extension/project_audit.go | 75 ++++++++ pkg/extension/surface.txt | 11 ++ 12 files changed, 565 insertions(+), 11 deletions(-) create mode 100644 .task/feature-rdm-two-trees-project-audit.md create mode 100644 internal/app/project_audit.go create mode 100644 internal/app/project_audit_test.go create mode 100644 internal/store/project_audit_test.go create mode 100644 pkg/extension/project_audit.go diff --git a/.task/feature-rdm-two-trees-project-audit.md b/.task/feature-rdm-two-trees-project-audit.md new file mode 100644 index 0000000..06329d8 --- /dev/null +++ b/.task/feature-rdm-two-trees-project-audit.md @@ -0,0 +1,20 @@ +# W9 Backend project audit read slice + +- Scope: TT-A01/A02/A04/U04, approved stage 5 W9. Stage 6 local implementation; human review, formal acceptance, PR, CI, tag, and deployment are pending. +- Branch/worktree: `feature/rdm-two-trees-project-audit` at `/home/weichen/projects/Agent-System-Backend-wt-feature-rdm-two-trees-project-audit`. +- R0: Backend authoritative `origin/main` `5d5fc9891c0eb8994545ccb8b740535d9b99fb0e`; main was clean and equal to the fetched remote before this worktree was created. Core gitlink in this worktree is `5773e74086791731059730bd3726dc8c9cd1381f`. +- Startup receipt: `/tmp/backend-w9-precheck-20261014-01.json` (SELF, exit 2, `SYNC_REQUIRED` for the separate Dev checkout `feature/rdm-increment-acceptance-note`, six commits behind Dev `origin/main`). This Backend task uses the independent-development path in Backend `AGENTS.md`; it does not write that Dev checkout or its task card. The receipt is preserved as a failure, not relabeled READY. + +## Implemented local slice + +- Optional `ProjectAuditHost` and domain `audit.read` registration. A different plugin, absent registration, or unbound actor cannot read. +- Store write snapshots the project from the owner-matched conversation; query requires the authenticated actor's owner and that immutable project. This deliberately excludes other members' private conversations and unbound historical rows, and does not move old receipts when a conversation changes projects. +- Command audit stores the current verified account display name at write time; old rows expose `not-recorded`. Public receipts omit raw payload and parameter digest. Cursor uses project-and-owner scoped source cutoff. +- Coverage explicitly marks cross-member published operations, legacy project attribution, run relations, model/background receipts, and resource bodies unsupported. This is not the full W9 or complete project audit. + +## Verification and remaining work + +- The session saw RED for the missing store and host interfaces, unscoped cutoff, cross-member private disclosure, and conversation-project reassignment before the respective fixes. These RED outputs were not captured by `make evidence`, so this card does not use them as formal evidence. +- SELF receipt `/tmp/backend-w9-go-test-20261014-01.json`: `go test ./...`, exit 0, run on the pre-commit worktree based on R0. +- SELF receipt `/tmp/backend-w9-build-20261014-01.json`: `CGO_ENABLED=0 go build ./cmd/agent-system`, exit 0, run on that pre-commit tree. Generated local binary removed after the build. +- Required next X2 contract: persist trusted operation/run/resource attribution and publication or visibility at source, with a per-object metadata/body disclosure callback and cursor binding to actor, authorization epoch, project, filter, and cutoff. Then test two members reading published project operations while private conversations, revoked objects, and bodies without current rights remain hidden. Current `command_audit` has owner, conversation, raw envelope, and new project/name snapshots, but no proof that an operation was published or that its resource may be disclosed. Add real model/tool/background receipts, delayed receipt reconciliation, history/export checks, and PostgreSQL/combined consumer verification before claiming W9 complete. diff --git a/internal/app/app.go b/internal/app/app.go index 33749b7..8ec4808 100644 --- a/internal/app/app.go +++ b/internal/app/app.go @@ -597,7 +597,7 @@ func Run(opt Options) error { // hostcaps：hostapi 闭包与进程内插件句柄共用的 owner 作用域能力（EXT-1 批注 1）。 authzSlot := &projectAuthz{} projectSlot := &projectLifecycleSlot{} - caps := hostcaps{projects: projectSlot, st: st, pipe: pipe, set: setSvc, authz: authzSlot, surfaces: surfaceSvc} + caps := hostcaps{projects: projectSlot, projectAudit: &projectAuditSlot{}, st: st, pipe: pipe, set: setSvc, authz: authzSlot, surfaces: surfaceSvc} // EXT-13：回合内检索（knowledge_search / @knowledge 注入）与 HTTP/Host 检索面 // 同一适配器授权；槽为共享指针，扩展在 applyCompiled 期间注册后即生效。 mgr.SetSharedKnowledgeAllow(func(owner string, projectID core.ID) bool { diff --git a/internal/app/hostcaps.go b/internal/app/hostcaps.go index 866a4f4..caf3e7a 100644 --- a/internal/app/hostcaps.go +++ b/internal/app/hostcaps.go @@ -21,12 +21,13 @@ import ( // 同一实现同时服务 hostapi.Server 的 Search/Complete 闭包与进程内 // inprocHost（EXT-1 批注 1：复用现有 owner 作用域函数，不新造句柄）。 type hostcaps struct { - projects *projectLifecycleSlot - st *store.Store - pipe *rag.Pipeline - set *settings.Service - authz *projectAuthz // EXT-8 适配器槽（共享指针；首个注册者生效） - surfaces *surfacesvc.Service // EXT-17 Surface 能力槽（nil = 未装配，明确拒绝） + projects *projectLifecycleSlot + projectAudit *projectAuditSlot + st *store.Store + pipe *rag.Pipeline + set *settings.Service + authz *projectAuthz // EXT-8 适配器槽（共享指针；首个注册者生效） + surfaces *surfacesvc.Service // EXT-17 Surface 能力槽（nil = 未装配，明确拒绝） } // projectAuthz EXT-8 资源授权适配器槽：进程内扩展注册，组合根装配进 Server。 diff --git a/internal/app/project_audit.go b/internal/app/project_audit.go new file mode 100644 index 0000000..07562fe --- /dev/null +++ b/internal/app/project_audit.go @@ -0,0 +1,103 @@ +package app + +import ( + "context" + "errors" + "sync" + + "agent-system-backend/pkg/extension" + core "agent-system-core" +) + +// projectAuditSlot binds the audit.read policy to its registering domain plugin. +// A different plugin cannot borrow that policy through its own Host handle. +type projectAuditSlot struct { + mu sync.RWMutex + holder string + check extension.ProjectAuditAuthorizer +} + +func (s *projectAuditSlot) register(pluginID string, check extension.ProjectAuditAuthorizer) error { + if pluginID == "" || check == nil { + return extension.ErrProjectAuditUnsupported + } + s.mu.Lock() + defer s.mu.Unlock() + if s.check != nil { + return errors.New("extension: project audit authorizer already registered") + } + s.holder, s.check = pluginID, check + return nil +} + +func (r compiledRegistry) RegisterProjectAuditAuthorizer(extension.ProjectAuditAuthorizer) error { + return errors.New("extension: declarative plugins cannot register project audit authorizers") +} + +func (r pluginRegistry) RegisterProjectAuditAuthorizer(check extension.ProjectAuditAuthorizer) error { + if r.caps.projectAudit == nil { + return extension.ErrProjectAuditUnsupported + } + return r.caps.projectAudit.register(r.pluginID, check) +} + +func (r recordRegistry) RegisterProjectAuditAuthorizer(check extension.ProjectAuditAuthorizer) error { + reg, ok := r.Registry.(extension.ProjectAuditRegistry) + if !ok { + return extension.ErrProjectAuditUnsupported + } + return reg.RegisterProjectAuditAuthorizer(check) +} + +var _ extension.ProjectAuditHost = inprocHost{} + +func (h inprocHost) QueryProjectAudit(ctx context.Context, q extension.ProjectAuditQuery) (extension.ProjectAuditPage, error) { + if err := ctx.Err(); err != nil { + return extension.ProjectAuditPage{}, err + } + if h.actor == "" || h.actor != h.owner || q.ProjectID == "" { + return extension.ProjectAuditPage{}, extension.ErrProjectAuditDenied + } + if h.caps.projectAudit == nil || h.caps.st == nil { + return extension.ProjectAuditPage{}, extension.ErrProjectAuditUnsupported + } + slot := h.caps.projectAudit + slot.mu.RLock() + holder, check := slot.holder, slot.check + slot.mu.RUnlock() + if holder != h.pluginID || check == nil { + return extension.ProjectAuditPage{}, extension.ErrProjectAuditUnsupported + } + ok, err := check(h.actor, core.ID(q.ProjectID)) + if err != nil || !ok { + return extension.ProjectAuditPage{}, extension.ErrProjectAuditDenied + } + if err := ctx.Err(); err != nil { + return extension.ProjectAuditPage{}, err + } + rows, cutoff, next, err := h.caps.st.ListProjectCommandAudits(h.owner, string(q.ProjectID), q.BeforeOffset, q.CutoffOffset, q.Limit) + if err != nil { + return extension.ProjectAuditPage{}, err + } + page := extension.ProjectAuditPage{ + Receipts: make([]extension.HostAuditReceipt, 0, len(rows)), + NextOffset: next, CutoffOffset: cutoff, + Coverage: extension.ProjectAuditCoverage{ + CommandAudit: "actor-owned-project-bound-only", CrossMember: "unsupported", LegacyProjectBinding: "not-recorded", RunRelations: "unsupported", ModelReceipts: "unsupported", + BackgroundReceipts: "unsupported", ResourceBodies: "unsupported", + }, + } + for _, row := range rows { + nameStatus := "not-recorded" + if row.ActorName != "" { + nameStatus = "recorded" + } + page.Receipts = append(page.Receipts, extension.HostAuditReceipt{ + SourceOffset: row.Offset, Time: row.Envelope.Time, ActorID: row.Envelope.Actor, + ActorName: row.ActorName, ActorNameStatus: nameStatus, + CommandID: row.Envelope.CommandID, State: string(row.Envelope.State), + OperationID: row.Envelope.OperationID, ConversationID: row.Envelope.ConversationID, + }) + } + return page, nil +} diff --git a/internal/app/project_audit_test.go b/internal/app/project_audit_test.go new file mode 100644 index 0000000..4157fa9 --- /dev/null +++ b/internal/app/project_audit_test.go @@ -0,0 +1,101 @@ +package app + +import ( + "context" + "encoding/json" + "errors" + "path/filepath" + "strings" + "testing" + "time" + + agentcommand "agent-command" + "agent-system-backend/internal/store" + "agent-system-backend/pkg/extension" + core "agent-system-core" +) + +func TestProjectAuditHostChecksDomainReadAndProjectsStoredReceipts(t *testing.T) { + st, err := store.OpenSQLite(filepath.Join(t.TempDir(), "audit.db")) + if err != nil { + t.Fatal(err) + } + defer st.Close() + for _, owner := range []string{"alice", "bob"} { + if err := st.EnsureUser(owner, strings.ToUpper(owner)); err != nil { + t.Fatal(err) + } + } + a, err := st.CreateProject("alice", "A") + if err != nil { + t.Fatal(err) + } + b, err := st.CreateProject("alice", "B") + if err != nil { + t.Fatal(err) + } + ac, err := st.CreateConversation("alice", string(a.ID), "A", "") + if err != nil { + t.Fatal(err) + } + bc, err := st.CreateConversation("alice", string(b.ID), "B", "") + if err != nil { + t.Fatal(err) + } + shared, err := st.CreateConversationInProject("bob", string(a.ID), "A shared", "") + if err != nil { + t.Fatal(err) + } + for _, item := range []struct{ owner, conversation, command string }{ + {"alice", string(ac.ID), "a.command"}, + {"alice", string(bc.ID), "b.command"}, + {"bob", string(shared.ID), "shared.command"}, + } { + if err := st.AppendAudit(item.owner, agentcommand.AuditEnvelope{Time: time.Now(), Actor: item.owner, CommandID: item.command, ConversationID: item.conversation, State: agentcommand.StateCommitted, ParamsDigest: "sensitive-digest"}); err != nil { + t.Fatal(err) + } + } + slot := &projectAuditSlot{} + caps := hostcaps{st: st, projectAudit: slot} + reg := pluginRegistry{pluginID: "rdm", caps: caps} + allowed := true + if err := reg.RegisterProjectAuditAuthorizer(func(actor string, projectID core.ID) (bool, error) { + return allowed && actor == "bob" && projectID == a.ID, nil + }); err != nil { + t.Fatal(err) + } + h := inprocHost{caps: caps, owner: "bob", actor: "bob", pluginID: "rdm"} + page, err := h.QueryProjectAudit(context.Background(), extension.ProjectAuditQuery{ProjectID: a.ID, Limit: 10}) + if err != nil { + t.Fatal(err) + } + if len(page.Receipts) != 1 || page.Receipts[0].CommandID != "shared.command" { + t.Fatalf("A page: %+v", page) + } + if page.Coverage.CommandAudit != "actor-owned-project-bound-only" || page.Coverage.CrossMember != "unsupported" || page.Coverage.LegacyProjectBinding != "not-recorded" || page.Coverage.RunRelations != "unsupported" || page.Coverage.ModelReceipts != "unsupported" { + t.Fatalf("coverage: %+v", page.Coverage) + } + if page.Receipts[0].ActorName != "BOB" { + t.Fatalf("actor names: %+v", page.Receipts) + } + raw, err := json.Marshal(page) + if err != nil { + t.Fatal(err) + } + if strings.Contains(string(raw), "sensitive-digest") || strings.Contains(string(raw), "paramsDigest") || strings.Contains(string(raw), "payload") { + t.Fatalf("raw audit payload leaked: %s", raw) + } + if _, err := h.QueryProjectAudit(context.Background(), extension.ProjectAuditQuery{ProjectID: b.ID}); !errors.Is(err, extension.ErrProjectAuditDenied) { + t.Fatalf("project B: %v", err) + } + if _, err := (inprocHost{caps: caps, owner: "bob", actor: "bob", pluginID: "other"}).QueryProjectAudit(context.Background(), extension.ProjectAuditQuery{ProjectID: a.ID}); !errors.Is(err, extension.ErrProjectAuditUnsupported) { + t.Fatalf("other plugin: %v", err) + } + if _, err := (inprocHost{caps: caps, owner: "bob", pluginID: "rdm"}).QueryProjectAudit(context.Background(), extension.ProjectAuditQuery{ProjectID: a.ID}); !errors.Is(err, extension.ErrProjectAuditDenied) { + t.Fatalf("unbound actor: %v", err) + } + allowed = false + if _, err := h.QueryProjectAudit(context.Background(), extension.ProjectAuditQuery{ProjectID: a.ID, BeforeOffset: page.NextOffset, CutoffOffset: page.CutoffOffset}); !errors.Is(err, extension.ErrProjectAuditDenied) { + t.Fatalf("revoked audit.read: %v", err) + } +} diff --git a/internal/store/audit.go b/internal/store/audit.go index b5479a8..d77301a 100644 --- a/internal/store/audit.go +++ b/internal/store/audit.go @@ -3,6 +3,7 @@ package store import ( "database/sql" "encoding/json" + "errors" "time" agentcommand "agent-command" @@ -16,13 +17,69 @@ func (s *Store) AppendAudit(owner string, env agentcommand.AuditEnvelope) error if err != nil { return err } - _, err = s.db.Exec(s.q(`INSERT INTO command_audit (time, command_id, source, entrance, state, operation_id, conversation_id, owner, payload) - VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?)`), + _, err = s.db.Exec(s.q(`INSERT INTO command_audit (time, command_id, source, entrance, state, operation_id, conversation_id, owner, payload, actor_name, project_id) + VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, COALESCE((SELECT name FROM users WHERE owner=?), ''), + COALESCE((SELECT project_id FROM conversations WHERE id=? AND owner=?), ''))`), env.Time.UTC().Format(time.RFC3339Nano), env.CommandID, string(env.Source), env.Entrance, string(env.State), - env.OperationID, env.ConversationID, owner, string(raw)) + env.OperationID, env.ConversationID, owner, string(raw), env.Actor, env.ConversationID, owner) return err } +// ProjectCommandAuditRow is an internal command receipt. Callers must project +// only approved fields; the envelope contains a digest and is not a public DTO. +type ProjectCommandAuditRow struct { + Offset int64 + ActorName string // empty on old rows or when no trusted account name was recorded + Envelope agentcommand.AuditEnvelope +} + +// ListProjectCommandAudits reads the project resolved from a trusted conversation +// at append time. Reassigning or deleting that conversation cannot rewrite the +// original project. Legacy rows without this snapshot are excluded: current +// project membership cannot establish their historical project attribution. +// Only the authenticated owner can read this first private slice. +func (s *Store) ListProjectCommandAudits(actorOwner, projectID string, before, cutoff int64, limit int) ([]ProjectCommandAuditRow, int64, int64, error) { + if actorOwner == "" || projectID == "" || before < 0 || cutoff < 0 || (before != 0 && cutoff == 0) { + return nil, 0, 0, errors.New("project audit: invalid scope or cursor") + } + if limit <= 0 || limit > 200 { + limit = 50 + } + if cutoff == 0 { + if err := s.db.QueryRow(s.q(`SELECT COALESCE(MAX(id),0) FROM command_audit + WHERE project_id=? AND owner=?`), projectID, actorOwner).Scan(&cutoff); err != nil { + return nil, 0, 0, err + } + } + rows, err := s.db.Query(s.q(`SELECT id, actor_name, payload FROM command_audit + WHERE project_id=? AND owner=? AND id<=? AND (?=0 OR id Date: Wed, 14 Oct 2026 04:05:10 +0000 Subject: [PATCH 02/41] Add verified project audit links and button actors Why: Owner-only command audit cannot prove shared business commits, and button dispatch omitted its authenticated actor. Evidence: Local go test ./... passed; isolated PostgreSQL cutoff, link, and SQLite-to-PostgreSQL migration receipts are recorded as SELF in the task card. Impact: Add an optional domain-verified metadata link, exact authorized cross-member read, idempotent storage, actor propagation, and honest PostgreSQL cutoff coverage. Broad audit pagination and other sources remain pending. Refs: Stage 5 W9; approved Stage 6 audit-link design adjustment r1 --- .task/feature-rdm-two-trees-project-audit.md | 11 +- cmd/storage-migrate/integration_test.go | 9 + cmd/storage-migrate/main.go | 4 +- cmd/storage-migrate/main_test.go | 6 +- internal/app/app.go | 12 +- internal/app/project_audit.go | 193 ++++++++++++++++++- internal/app/project_audit_link_test.go | 137 +++++++++++++ internal/app/project_audit_test.go | 2 +- internal/app/surface_audit_actor_test.go | 50 +++++ internal/app/surface_dispatch.go | 25 +++ internal/store/migrate.go | 9 + internal/store/migrate_compat.go | 1 + internal/store/project_audit_links.go | 143 ++++++++++++++ internal/store/project_audit_links_test.go | 84 ++++++++ internal/store/project_audit_test.go | 60 ++++++ pkg/extension/extension.go | 4 +- pkg/extension/project_audit.go | 78 +++++++- pkg/extension/surface.txt | 13 ++ 18 files changed, 812 insertions(+), 29 deletions(-) create mode 100644 internal/app/project_audit_link_test.go create mode 100644 internal/app/surface_audit_actor_test.go create mode 100644 internal/app/surface_dispatch.go create mode 100644 internal/store/project_audit_links.go create mode 100644 internal/store/project_audit_links_test.go diff --git a/.task/feature-rdm-two-trees-project-audit.md b/.task/feature-rdm-two-trees-project-audit.md index 06329d8..05a3595 100644 --- a/.task/feature-rdm-two-trees-project-audit.md +++ b/.task/feature-rdm-two-trees-project-audit.md @@ -1,20 +1,25 @@ -# W9 Backend project audit read slice +# W9 Backend project audit candidate - Scope: TT-A01/A02/A04/U04, approved stage 5 W9. Stage 6 local implementation; human review, formal acceptance, PR, CI, tag, and deployment are pending. - Branch/worktree: `feature/rdm-two-trees-project-audit` at `/home/weichen/projects/Agent-System-Backend-wt-feature-rdm-two-trees-project-audit`. - R0: Backend authoritative `origin/main` `5d5fc9891c0eb8994545ccb8b740535d9b99fb0e`; main was clean and equal to the fetched remote before this worktree was created. Core gitlink in this worktree is `5773e74086791731059730bd3726dc8c9cd1381f`. - Startup receipt: `/tmp/backend-w9-precheck-20261014-01.json` (SELF, exit 2, `SYNC_REQUIRED` for the separate Dev checkout `feature/rdm-increment-acceptance-note`, six commits behind Dev `origin/main`). This Backend task uses the independent-development path in Backend `AGENTS.md`; it does not write that Dev checkout or its task card. The receipt is preserved as a failure, not relabeled READY. +- Approved affected design: `rdm-two-trees-stage6-audit-link-design-adjustment-r1.md`, SHA256 `385d9d7570217ddcce9fe60a60c99dc58c9a4875ad790584a724d09a210a6e52`; user approval in the task session covers this local Backend increment, not tag publication or Stage 7 acceptance. ## Implemented local slice - Optional `ProjectAuditHost` and domain `audit.read` registration. A different plugin, absent registration, or unbound actor cannot read. - Store write snapshots the project from the owner-matched conversation; query requires the authenticated actor's owner and that immutable project. This deliberately excludes other members' private conversations and unbound historical rows, and does not move old receipts when a conversation changes projects. - Command audit stores the current verified account display name at write time; old rows expose `not-recorded`. Public receipts omit raw payload and parameter digest. Cursor uses project-and-owner scoped source cutoff. -- Coverage explicitly marks cross-member published operations, legacy project attribution, run relations, model/background receipts, and resource bodies unsupported. This is not the full W9 or complete project audit. +- Initial commit `c8dd169a1fdc1451fab3b475c14f9636a7f5bf6c` exposed only the actor-owned project slice. The next local increment fixes button actor propagation and adds a trusted domain-commit link publisher, verifier callback, exact linked metadata read, current `audit.read` and per-object metadata checks, and durable idempotency. Unlinked personal conversations remain private. +- Exact-source linked reads do not enumerate hidden links or reveal raw payload, private conversation ID, or content. Body disclosure and a broad project link list are not implemented; the public coverage reports the narrower capability. ## Verification and remaining work - The session saw RED for the missing store and host interfaces, unscoped cutoff, cross-member private disclosure, and conversation-project reassignment before the respective fixes. These RED outputs were not captured by `make evidence`, so this card does not use them as formal evidence. - SELF receipt `/tmp/backend-w9-go-test-20261014-01.json`: `go test ./...`, exit 0, run on the pre-commit worktree based on R0. - SELF receipt `/tmp/backend-w9-build-20261014-01.json`: `CGO_ENABLED=0 go build ./cmd/agent-system`, exit 0, run on that pre-commit tree. Generated local binary removed after the build. -- Required next X2 contract: persist trusted operation/run/resource attribution and publication or visibility at source, with a per-object metadata/body disclosure callback and cursor binding to actor, authorization epoch, project, filter, and cutoff. Then test two members reading published project operations while private conversations, revoked objects, and bodies without current rights remain hidden. Current `command_audit` has owner, conversation, raw envelope, and new project/name snapshots, but no proof that an operation was published or that its resource may be disclosed. Add real model/tool/background receipts, delayed receipt reconciliation, history/export checks, and PostgreSQL/combined consumer verification before claiming W9 complete. +- SELF PostgreSQL receipt `/tmp/backend-w9-pg-cutoff-20261014-01.json`: isolated PostgreSQL 18.6 instance on port 55442 reproduced a low-ID transaction committing after a higher visible ID. `/tmp/backend-w9-pg-link-20261014-02.json` verifies the new link table, retry/conflict behavior, and the cutoff counterexample against isolated schemas. Both exited 0. The current PG cutoff means only `offset-upper-bound-only`; it is **not** a fixed historical visibility snapshot or safe incremental cursor. +- SELF PostgreSQL receipt `/tmp/backend-w9-pg-migrate-20261014-01.json`: isolated SQLite→PostgreSQL migration preserved one linked receipt and advanced its target sequence; the same migration ID replayed idempotently. The temporary PG instance was stopped and removed after verification. +- Integration constraint: this branch uses schema v31 (audit attribution) and v32 (links), while the independent W6 Backend branch also has a local v31. Neither branch has consumed the other's unmerged work. After the first branch lands, the later branch owner must sync the new main, renumber its unpublished migrations without rewriting an already released version, and rerun fresh/old SQLite and PG migration plus combined regression on the actual merged source. These isolated tests do not prove W6+W9 compatibility. +- Required next W9 work: add a committed-order waterline or materialize the authorized ID set at the first read, then prove with PG low-ID late commits that history and cross-page incremental reads neither omit nor duplicate operations. The Backend project-event source, actual RDM committed-event verifier/outbox consumer, run ID propagation from command dispatch, model/tool/background receipts, body/detail disclosure, broad authorized list pagination, history/export, and combined product verification remain unfinished. The exact-link slice is not Stage 7 audit acceptance. diff --git a/cmd/storage-migrate/integration_test.go b/cmd/storage-migrate/integration_test.go index d4997c0..57cb9f0 100644 --- a/cmd/storage-migrate/integration_test.go +++ b/cmd/storage-migrate/integration_test.go @@ -85,6 +85,15 @@ func TestMigrateEndToEndAndIdempotent(t *testing.T) { if _, err := db.Exec(`INSERT INTO command_audit (time, command_id, source, entrance, state, operation_id, conversation_id, payload, owner) VALUES ('2026-10-11T03:00:00Z','cmd-2','http','chat','done','op-2','c1','{}','alice')`); err != nil { t.Fatalf("序列推进失败（复制后插入撞主键）：%v", err) } + var linkedResource string + if err := db.QueryRow(`SELECT resource_id FROM project_audit_links WHERE host_audit_offset=7 AND source_id='commit-1'`).Scan(&linkedResource); err != nil || linkedResource != "doc-1" { + t.Fatalf("审计链接迁移丢失: resource=%q err=%v", linkedResource, err) + } + var newLinkID int64 + if err := db.QueryRow(`INSERT INTO project_audit_links(host_audit_offset,project_id,owner,source_kind,source_id,operation_id,resource_kind,resource_id,run_id,disclosure_class,idempotency_key,created_at) + VALUES (7,'p1','alice','domain-commit','commit-2','op-1','document','doc-2','','metadata','outbox-2','2026-10-11T03:00:01Z') RETURNING id`).Scan(&newLinkID); err != nil || newLinkID <= 3 { + t.Fatalf("审计链接序列未推进: id=%d err=%v", newLinkID, err) + } // 报告不含秘密值。 var report string if err := db.QueryRow(`SELECT report FROM migration_control WHERE migration_id='mig-e2e'`).Scan(&report); err != nil || strings.Contains(report, "sk-secret-value") { diff --git a/cmd/storage-migrate/main.go b/cmd/storage-migrate/main.go index 7ee9cb2..884ca51 100644 --- a/cmd/storage-migrate/main.go +++ b/cmd/storage-migrate/main.go @@ -284,7 +284,7 @@ var copyOrder = []string{ "projects", "users", "profiles", "settings", "plugins", "conversations", "runs", "messages", "events", "artifacts", "hitl_cards", "plans", "todos", "knowledge", "knowledge_vectors", - "activity_cards", "project_event_shares", "command_audit", "prompt_modules", + "activity_cards", "project_event_shares", "command_audit", "project_audit_links", "prompt_modules", "sessions", "api_keys", "plugin_grants", "plugin_schema", "plugin_kv", "background_tasks", "memory_entries", "audit_events", "pending_confirms", "llm_usage_daily", @@ -784,7 +784,7 @@ func advanceSequences(db *sql.DB, table string) error { // checkOwners：业务行引用的 owner 必须存在于 users（单租户默认 ”/'local' // 除外）。未知 owner 阻塞迁移（U4/R7：不静默带过未知归属）。 func checkOwners(db *sql.DB, src *sql.DB) error { - ownerTables := []string{"projects", "conversations", "runs", "artifacts", "knowledge", "hitl_cards", "profiles", "activity_cards", "project_event_shares", "command_audit"} + ownerTables := []string{"projects", "conversations", "runs", "artifacts", "knowledge", "hitl_cards", "profiles", "activity_cards", "project_event_shares", "command_audit", "project_audit_links"} for _, t := range ownerTables { if !sqliteHasTable(src, t) { continue diff --git a/cmd/storage-migrate/main_test.go b/cmd/storage-migrate/main_test.go index 8731e0e..7071e34 100644 --- a/cmd/storage-migrate/main_test.go +++ b/cmd/storage-migrate/main_test.go @@ -70,8 +70,10 @@ func seedEdgeRows(t *testing.T, st *store.Store) { mustExec(t, st, `INSERT INTO activity_cards (id, project_id, conversation_id, ref, owner, payload, status, pinned, created_at, updated_at, version) VALUES ('ac1', 'p1', 'c1', '', 'alice', '{"title":"卡"}', 'active', 1, '2026-10-11T01:00:00Z', '2026-10-11T01:00:00Z', 2)`) // 命令审计（SERIAL 主键：显式 id 插入）。 - mustExec(t, st, `INSERT INTO command_audit (id, time, command_id, source, entrance, state, operation_id, conversation_id, payload, owner) VALUES - (7, '2026-10-11T01:00:00Z', 'cmd-1', 'http', 'chat', 'done', 'op-1', 'c1', '{"actor":"alice"}', 'alice')`) + mustExec(t, st, `INSERT INTO command_audit (id, time, command_id, source, entrance, state, operation_id, conversation_id, payload, owner, project_id, actor_name) VALUES + (7, '2026-10-11T01:00:00Z', 'cmd-1', 'http', 'chat', 'committed', 'op-1', 'c1', '{"actor":"alice","commandId":"cmd-1","operationId":"op-1","state":"committed","conversationId":"c1"}', 'alice', 'p1', '爱丽丝')`) + mustExec(t, st, `INSERT INTO project_audit_links (id,host_audit_offset,project_id,owner,source_kind,source_id,operation_id,resource_kind,resource_id,run_id,disclosure_class,idempotency_key,created_at) VALUES + (3,7,'p1','alice','domain-commit','commit-1','op-1','document','doc-1','','metadata','outbox-1','2026-10-11T01:00:01Z')`) // 设置（'' 默认租户 scope）。 mustExec(t, st, `INSERT INTO settings (owner, scope, "values") VALUES ('', 'runtime', '{"rateLimitPerMin":0}')`) // 秘密字段（值不外泄：迁移按行复制，报告无正文）。 diff --git a/internal/app/app.go b/internal/app/app.go index 8ec4808..57fbe00 100644 --- a/internal/app/app.go +++ b/internal/app/app.go @@ -557,17 +557,7 @@ func Run(opt Options) error { // U5：页面动作分发口——surfacesvc.SubmitAction 经命令总线四入口同源分发 //（审计信封、参数校验、DangerHigh 内联确认卡全复用；Confirmed 不透传）。 surfaceSvc.SetDispatcher(func(ctx context.Context, d surfacesvc.ActionDispatch) (surfacesvc.ActionOutcome, error) { - resp := bus.Dispatch(ctx, cmdbus.Request{ID: d.CommandID, Params: d.Params, - Entrance: "button", Owner: d.Owner, ConversationID: d.ConversationID}) - state := "committed" - if resp.Receipt.State != "" { - state = string(resp.Receipt.State) - } - cardID := "" - if resp.Card != nil { - cardID = string(resp.Card.ID) - } - return surfacesvc.ActionOutcome{State: state, CardID: cardID, Receipt: resp.Receipt, Payload: resp.Payload}, nil + return dispatchSurfaceAction(ctx, bus, d) }) // U3：generative-ui 工具注入闸——activation 台账关闭时命令不投影给该 owner // 的模型（禁用即不注入能力；执行端守卫仍在 surfacesvc）。 diff --git a/internal/app/project_audit.go b/internal/app/project_audit.go index 07562fe..53be92d 100644 --- a/internal/app/project_audit.go +++ b/internal/app/project_audit.go @@ -5,6 +5,7 @@ import ( "errors" "sync" + "agent-system-backend/internal/store" "agent-system-backend/pkg/extension" core "agent-system-core" ) @@ -12,9 +13,11 @@ import ( // projectAuditSlot binds the audit.read policy to its registering domain plugin. // A different plugin cannot borrow that policy through its own Host handle. type projectAuditSlot struct { - mu sync.RWMutex - holder string - check extension.ProjectAuditAuthorizer + mu sync.RWMutex + holder string + check extension.ProjectAuditAuthorizer + verifier extension.ProjectAuditLinkVerifier + disclose extension.ProjectAuditDisclosureAuthorizer } func (s *projectAuditSlot) register(pluginID string, check extension.ProjectAuditAuthorizer) error { @@ -23,13 +26,39 @@ func (s *projectAuditSlot) register(pluginID string, check extension.ProjectAudi } s.mu.Lock() defer s.mu.Unlock() - if s.check != nil { + if s.check != nil || (s.holder != "" && s.holder != pluginID) { return errors.New("extension: project audit authorizer already registered") } s.holder, s.check = pluginID, check return nil } +func (s *projectAuditSlot) registerVerifier(pluginID string, verify extension.ProjectAuditLinkVerifier) error { + if pluginID == "" || verify == nil { + return extension.ErrProjectAuditUnsupported + } + s.mu.Lock() + defer s.mu.Unlock() + if s.verifier != nil || (s.holder != "" && s.holder != pluginID) { + return errors.New("extension: project audit verifier already registered") + } + s.holder, s.verifier = pluginID, verify + return nil +} + +func (s *projectAuditSlot) registerDisclosure(pluginID string, disclose extension.ProjectAuditDisclosureAuthorizer) error { + if pluginID == "" || disclose == nil { + return extension.ErrProjectAuditUnsupported + } + s.mu.Lock() + defer s.mu.Unlock() + if s.disclose != nil || (s.holder != "" && s.holder != pluginID) { + return errors.New("extension: project audit disclosure authorizer already registered") + } + s.holder, s.disclose = pluginID, disclose + return nil +} + func (r compiledRegistry) RegisterProjectAuditAuthorizer(extension.ProjectAuditAuthorizer) error { return errors.New("extension: declarative plugins cannot register project audit authorizers") } @@ -49,7 +78,111 @@ func (r recordRegistry) RegisterProjectAuditAuthorizer(check extension.ProjectAu return reg.RegisterProjectAuditAuthorizer(check) } +func (r compiledRegistry) RegisterProjectAuditLinkVerifier(extension.ProjectAuditLinkVerifier) error { + return errors.New("extension: declarative plugins cannot register project audit link verifiers") +} +func (r compiledRegistry) RegisterProjectAuditDisclosureAuthorizer(extension.ProjectAuditDisclosureAuthorizer) error { + return errors.New("extension: declarative plugins cannot register project audit disclosure authorizers") +} +func (r pluginRegistry) RegisterProjectAuditLinkVerifier(verify extension.ProjectAuditLinkVerifier) error { + if r.caps.projectAudit == nil { + return extension.ErrProjectAuditUnsupported + } + return r.caps.projectAudit.registerVerifier(r.pluginID, verify) +} +func (r pluginRegistry) RegisterProjectAuditDisclosureAuthorizer(disclose extension.ProjectAuditDisclosureAuthorizer) error { + if r.caps.projectAudit == nil { + return extension.ErrProjectAuditUnsupported + } + return r.caps.projectAudit.registerDisclosure(r.pluginID, disclose) +} +func (r recordRegistry) RegisterProjectAuditLinkVerifier(verify extension.ProjectAuditLinkVerifier) error { + reg, ok := r.Registry.(extension.ProjectAuditLinkRegistry) + if !ok { + return extension.ErrProjectAuditUnsupported + } + return reg.RegisterProjectAuditLinkVerifier(verify) +} +func (r recordRegistry) RegisterProjectAuditDisclosureAuthorizer(disclose extension.ProjectAuditDisclosureAuthorizer) error { + reg, ok := r.Registry.(extension.ProjectAuditLinkRegistry) + if !ok { + return extension.ErrProjectAuditUnsupported + } + return reg.RegisterProjectAuditDisclosureAuthorizer(disclose) +} + var _ extension.ProjectAuditHost = inprocHost{} +var _ extension.ProjectAuditPublisher = inprocHost{} + +func (h inprocHost) PublishProjectAuditLink(ctx context.Context, req extension.ProjectAuditLinkRequest) (extension.ProjectAuditLinkReceipt, error) { + if err := ctx.Err(); err != nil { + return extension.ProjectAuditLinkReceipt{}, err + } + if h.caps.projectAudit == nil || h.caps.st == nil { + return extension.ProjectAuditLinkReceipt{}, extension.ErrProjectAuditUnsupported + } + slot := h.caps.projectAudit + slot.mu.RLock() + holder, verify := slot.holder, slot.verifier + slot.mu.RUnlock() + if holder != h.pluginID || verify == nil { + return extension.ProjectAuditLinkReceipt{}, extension.ErrProjectAuditUnsupported + } + if h.owner == "" || (h.actor != "" && h.actor != h.owner) || req.HostAuditOffset <= 0 || req.ProjectID == "" || req.SourceKind != "domain-commit" || req.SourceID == "" || req.OperationID == "" || req.ResourceKind == "" || req.ResourceID == "" || req.DisclosureClass != "metadata" || req.IdempotencyKey == "" { + return extension.ProjectAuditLinkReceipt{}, extension.ErrProjectAuditDenied + } + row, projectID, err := h.caps.st.CommandAuditForLink(h.owner, req.HostAuditOffset) + if errors.Is(err, store.ErrNotFound) { + return extension.ProjectAuditLinkReceipt{}, extension.ErrProjectAuditDenied + } + if err != nil { + return extension.ProjectAuditLinkReceipt{}, err + } + if projectID != string(req.ProjectID) || row.Envelope.Actor != h.owner || row.Envelope.OperationID != req.OperationID || string(row.Envelope.State) != "committed" || row.Envelope.RunID != req.RunID { + return extension.ProjectAuditLinkReceipt{}, extension.ErrProjectAuditDenied + } + if req.RunID != "" { + bound, err := h.caps.st.RunBoundToAudit(h.owner, projectID, row.Envelope.ConversationID, req.RunID) + if err != nil { + return extension.ProjectAuditLinkReceipt{}, err + } + if !bound { + return extension.ProjectAuditLinkReceipt{}, extension.ErrProjectAuditDenied + } + } + previous, lookupErr := h.caps.st.ProjectAuditLinkByKey(h.owner, req.IdempotencyKey) + if lookupErr == nil { + if previous.HostAuditOffset != req.HostAuditOffset || previous.ProjectID != string(req.ProjectID) || previous.SourceKind != req.SourceKind || previous.SourceID != req.SourceID || previous.OperationID != req.OperationID || previous.ResourceKind != req.ResourceKind || previous.ResourceID != req.ResourceID || previous.RunID != req.RunID || previous.DisclosureClass != req.DisclosureClass { + return extension.ProjectAuditLinkReceipt{}, extension.ErrProjectAuditLinkConflict + } + return extension.ProjectAuditLinkReceipt{LinkID: previous.ID, HostAuditOffset: previous.HostAuditOffset}, nil + } + if !errors.Is(lookupErr, store.ErrNotFound) { + return extension.ProjectAuditLinkReceipt{}, lookupErr + } + proof := extension.ProjectAuditLinkProof{ProjectAuditLinkRequest: req, Owner: h.owner} + ok, err := verify(ctx, proof) + if err != nil { + return extension.ProjectAuditLinkReceipt{}, err + } + if !ok { + return extension.ProjectAuditLinkReceipt{}, extension.ErrProjectAuditDenied + } + if err := ctx.Err(); err != nil { + return extension.ProjectAuditLinkReceipt{}, err + } + link := store.ProjectAuditLink{HostAuditOffset: req.HostAuditOffset, ProjectID: projectID, Owner: h.owner, + SourceKind: req.SourceKind, SourceID: req.SourceID, OperationID: req.OperationID, ResourceKind: req.ResourceKind, + ResourceID: req.ResourceID, RunID: req.RunID, DisclosureClass: req.DisclosureClass, IdempotencyKey: req.IdempotencyKey} + saved, err := h.caps.st.SaveProjectAuditLink(link) + if errors.Is(err, store.ErrConflict) { + return extension.ProjectAuditLinkReceipt{}, extension.ErrProjectAuditLinkConflict + } + if err != nil { + return extension.ProjectAuditLinkReceipt{}, err + } + return extension.ProjectAuditLinkReceipt{LinkID: saved.ID, HostAuditOffset: saved.HostAuditOffset}, nil +} func (h inprocHost) QueryProjectAudit(ctx context.Context, q extension.ProjectAuditQuery) (extension.ProjectAuditPage, error) { if err := ctx.Err(); err != nil { @@ -69,21 +202,31 @@ func (h inprocHost) QueryProjectAudit(ctx context.Context, q extension.ProjectAu return extension.ProjectAuditPage{}, extension.ErrProjectAuditUnsupported } ok, err := check(h.actor, core.ID(q.ProjectID)) - if err != nil || !ok { + if err != nil { + return extension.ProjectAuditPage{}, err + } + if !ok { return extension.ProjectAuditPage{}, extension.ErrProjectAuditDenied } if err := ctx.Err(); err != nil { return extension.ProjectAuditPage{}, err } + if q.LinkedSourceKind != "" || q.LinkedSourceID != "" || q.LinkedHostOffset != 0 { + return h.queryLinkedProjectAudit(ctx, q, slot) + } rows, cutoff, next, err := h.caps.st.ListProjectCommandAudits(h.owner, string(q.ProjectID), q.BeforeOffset, q.CutoffOffset, q.Limit) if err != nil { return extension.ProjectAuditPage{}, err } + cutoffConsistency := "committed-prefix" + if h.caps.st.Dialect() == "postgres" { + cutoffConsistency = "offset-upper-bound-only" + } page := extension.ProjectAuditPage{ Receipts: make([]extension.HostAuditReceipt, 0, len(rows)), NextOffset: next, CutoffOffset: cutoff, Coverage: extension.ProjectAuditCoverage{ - CommandAudit: "actor-owned-project-bound-only", CrossMember: "unsupported", LegacyProjectBinding: "not-recorded", RunRelations: "unsupported", ModelReceipts: "unsupported", + CommandAudit: "actor-owned-project-bound-only", CutoffConsistency: cutoffConsistency, CrossMember: "unsupported", LegacyProjectBinding: "not-recorded", RunRelations: "unsupported", ModelReceipts: "unsupported", BackgroundReceipts: "unsupported", ResourceBodies: "unsupported", }, } @@ -101,3 +244,41 @@ func (h inprocHost) QueryProjectAudit(ctx context.Context, q extension.ProjectAu } return page, nil } + +func (h inprocHost) queryLinkedProjectAudit(ctx context.Context, q extension.ProjectAuditQuery, slot *projectAuditSlot) (extension.ProjectAuditPage, error) { + if q.LinkedSourceKind != "domain-commit" || q.LinkedSourceID == "" || q.LinkedHostOffset <= 0 || q.BeforeOffset != 0 || q.CutoffOffset != 0 { + return extension.ProjectAuditPage{}, extension.ErrProjectAuditUnsupported + } + slot.mu.RLock() + disclose := slot.disclose + slot.mu.RUnlock() + if disclose == nil { + return extension.ProjectAuditPage{}, extension.ErrProjectAuditUnsupported + } + link, row, err := h.caps.st.ProjectAuditLinkedReceipt(string(q.ProjectID), q.LinkedSourceKind, q.LinkedSourceID, q.LinkedHostOffset) + if errors.Is(err, store.ErrNotFound) { + return extension.ProjectAuditPage{}, extension.ErrProjectAuditDenied + } + if err != nil { + return extension.ProjectAuditPage{}, err + } + resource := extension.ProjectAuditLinkedResource{ProjectID: q.ProjectID, Owner: link.Owner, SourceKind: link.SourceKind, SourceID: link.SourceID, + OperationID: link.OperationID, ResourceKind: link.ResourceKind, ResourceID: link.ResourceID, RunID: link.RunID, DisclosureClass: link.DisclosureClass} + allowed, err := disclose(ctx, h.actor, resource) + if err != nil { + return extension.ProjectAuditPage{}, err + } + if !allowed.Metadata { + return extension.ProjectAuditPage{}, extension.ErrProjectAuditDenied + } + nameStatus := "not-recorded" + if row.ActorName != "" { + nameStatus = "recorded" + } + return extension.ProjectAuditPage{Receipts: []extension.HostAuditReceipt{{SourceOffset: row.Offset, Time: row.Envelope.Time, + ActorID: row.Envelope.Actor, ActorName: row.ActorName, ActorNameStatus: nameStatus, CommandID: row.Envelope.CommandID, + State: string(row.Envelope.State), OperationID: row.Envelope.OperationID}}, + Coverage: extension.ProjectAuditCoverage{CommandAudit: "verified-exact-link-only", CrossMember: "verified-exact-link-only", + CutoffConsistency: "exact-link", LegacyProjectBinding: "not-recorded", RunRelations: "unsupported", + ModelReceipts: "unsupported", BackgroundReceipts: "unsupported", ResourceBodies: "unsupported"}}, nil +} diff --git a/internal/app/project_audit_link_test.go b/internal/app/project_audit_link_test.go new file mode 100644 index 0000000..5940436 --- /dev/null +++ b/internal/app/project_audit_link_test.go @@ -0,0 +1,137 @@ +package app + +import ( + "context" + "encoding/json" + "errors" + "path/filepath" + "strings" + "testing" + "time" + + agentcommand "agent-command" + "agent-system-backend/internal/store" + "agent-system-backend/pkg/extension" + core "agent-system-core" +) + +func TestProjectAuditLinkSharesOnlyVerifiedCommittedMetadata(t *testing.T) { + st, err := store.OpenSQLite(filepath.Join(t.TempDir(), "audit.db")) + if err != nil { + t.Fatal(err) + } + defer st.Close() + if err := st.EnsureUser("alice", "Alice at action"); err != nil { + t.Fatal(err) + } + if err := st.EnsureUser("bob", "Bob"); err != nil { + t.Fatal(err) + } + p, err := st.CreateProject("alice", "A") + if err != nil { + t.Fatal(err) + } + otherProject, err := st.CreateProject("alice", "B") + if err != nil { + t.Fatal(err) + } + c, err := st.CreateConversation("alice", string(p.ID), "private", "") + if err != nil { + t.Fatal(err) + } + if err := st.AppendAudit("alice", agentcommand.AuditEnvelope{Time: time.Now(), Actor: "alice", CommandID: "rdm.confirm", OperationID: "op-1", ConversationID: string(c.ID), State: agentcommand.StateCommitted, ParamsDigest: "secret-digest"}); err != nil { + t.Fatal(err) + } + private, _, _, err := st.ListProjectCommandAudits("alice", string(p.ID), 0, 0, 10) + if err != nil { + t.Fatal(err) + } + offset := private[0].Offset + slot := &projectAuditSlot{} + caps := hostcaps{st: st, projectAudit: slot} + reg := pluginRegistry{pluginID: "rdm", caps: caps} + auditAllowed := true + if err := reg.RegisterProjectAuditAuthorizer(func(actor string, projectID core.ID) (bool, error) { + return auditAllowed && actor == "bob" && projectID == p.ID, nil + }); err != nil { + t.Fatal(err) + } + if err := reg.RegisterProjectAuditLinkVerifier(func(_ context.Context, proof extension.ProjectAuditLinkProof) (bool, error) { + return proof.Owner == "alice" && proof.ProjectID == p.ID && proof.SourceKind == "domain-commit" && proof.SourceID == "commit-1" && proof.OperationID == "op-1" && proof.ResourceKind == "document" && proof.ResourceID == "doc-1", nil + }); err != nil { + t.Fatal(err) + } + metadataAllowed := true + if err := reg.RegisterProjectAuditDisclosureAuthorizer(func(_ context.Context, actor string, resource extension.ProjectAuditLinkedResource) (extension.ProjectAuditDisclosure, error) { + return extension.ProjectAuditDisclosure{Metadata: metadataAllowed && actor == "bob" && resource.ResourceID == "doc-1"}, nil + }); err != nil { + t.Fatal(err) + } + bob := inprocHost{caps: caps, pluginID: "rdm", owner: "bob", actor: "bob"} + q := extension.ProjectAuditQuery{ProjectID: p.ID, LinkedSourceKind: "domain-commit", LinkedSourceID: "commit-1", LinkedHostOffset: offset} + if _, err := bob.QueryProjectAudit(context.Background(), q); !errors.Is(err, extension.ErrProjectAuditDenied) { + t.Fatalf("unlinked private audit: %v", err) + } + alicePublisher := inprocHost{caps: caps, pluginID: "rdm", owner: "alice"} // trusted outbox-scoped host + linkReq := extension.ProjectAuditLinkRequest{ProjectID: p.ID, HostAuditOffset: offset, SourceKind: "domain-commit", SourceID: "commit-1", OperationID: "op-1", ResourceKind: "document", ResourceID: "doc-1", DisclosureClass: "metadata", IdempotencyKey: "outbox-1"} + if rows, err := bob.QueryProjectAudit(context.Background(), extension.ProjectAuditQuery{ProjectID: p.ID}); err != nil || len(rows.Receipts) != 0 { + t.Fatalf("private owner row visible without exact link: %+v %v", rows, err) + } + wrongProject := linkReq + wrongProject.ProjectID = otherProject.ID + if _, err := alicePublisher.PublishProjectAuditLink(context.Background(), wrongProject); !errors.Is(err, extension.ErrProjectAuditDenied) { + t.Fatalf("wrong host project: %v", err) + } + uncommitted := linkReq + uncommitted.SourceID, uncommitted.IdempotencyKey = "uncommitted", "outbox-uncommitted" + if _, err := alicePublisher.PublishProjectAuditLink(context.Background(), uncommitted); !errors.Is(err, extension.ErrProjectAuditDenied) { + t.Fatalf("uncommitted source: %v", err) + } + if _, err := (inprocHost{caps: caps, pluginID: "other", owner: "alice"}).PublishProjectAuditLink(context.Background(), linkReq); !errors.Is(err, extension.ErrProjectAuditUnsupported) { + t.Fatalf("other plugin: %v", err) + } + first, err := alicePublisher.PublishProjectAuditLink(context.Background(), linkReq) + if err != nil { + t.Fatal(err) + } + retry, err := alicePublisher.PublishProjectAuditLink(context.Background(), linkReq) + if err != nil || retry.LinkID != first.LinkID { + t.Fatalf("idempotent retry: first=%+v retry=%+v err=%v", first, retry, err) + } + page, err := bob.QueryProjectAudit(context.Background(), q) + if err != nil { + t.Fatal(err) + } + if len(page.Receipts) != 1 || page.Receipts[0].CommandID != "rdm.confirm" || page.Receipts[0].ActorName != "Alice at action" || page.Receipts[0].ConversationID != "" || page.Coverage.CrossMember != "verified-exact-link-only" { + t.Fatalf("linked page: %+v", page) + } + raw, err := json.Marshal(page) + if err != nil { + t.Fatal(err) + } + if strings.Contains(string(raw), "secret-digest") || strings.Contains(string(raw), string(c.ID)) { + t.Fatalf("private receipt fields leaked: %s", raw) + } + metadataAllowed = false + if _, err := bob.QueryProjectAudit(context.Background(), q); !errors.Is(err, extension.ErrProjectAuditDenied) { + t.Fatalf("revoked object metadata: %v", err) + } + metadataAllowed, auditAllowed = true, false + if _, err := bob.QueryProjectAudit(context.Background(), q); !errors.Is(err, extension.ErrProjectAuditDenied) { + t.Fatalf("revoked audit.read: %v", err) + } + linkReq.ResourceID = "doc-2" + if _, err := alicePublisher.PublishProjectAuditLink(context.Background(), linkReq); !errors.Is(err, extension.ErrProjectAuditLinkConflict) { + t.Fatalf("same key different link: %v", err) + } + metadataAllowed, auditAllowed = true, true + if err := st.Close(); err != nil { + t.Fatal(err) + } + if _, err := alicePublisher.PublishProjectAuditLink(context.Background(), linkReq); err == nil || errors.Is(err, extension.ErrProjectAuditDenied) { + t.Fatalf("storage outage during publish must remain retryable: %v", err) + } + if _, err := bob.QueryProjectAudit(context.Background(), q); err == nil || errors.Is(err, extension.ErrProjectAuditDenied) { + t.Fatalf("storage outage during linked read must be explicit: %v", err) + } +} diff --git a/internal/app/project_audit_test.go b/internal/app/project_audit_test.go index 4157fa9..3640da9 100644 --- a/internal/app/project_audit_test.go +++ b/internal/app/project_audit_test.go @@ -72,7 +72,7 @@ func TestProjectAuditHostChecksDomainReadAndProjectsStoredReceipts(t *testing.T) if len(page.Receipts) != 1 || page.Receipts[0].CommandID != "shared.command" { t.Fatalf("A page: %+v", page) } - if page.Coverage.CommandAudit != "actor-owned-project-bound-only" || page.Coverage.CrossMember != "unsupported" || page.Coverage.LegacyProjectBinding != "not-recorded" || page.Coverage.RunRelations != "unsupported" || page.Coverage.ModelReceipts != "unsupported" { + if page.Coverage.CommandAudit != "actor-owned-project-bound-only" || page.Coverage.CrossMember != "unsupported" || page.Coverage.LegacyProjectBinding != "not-recorded" || page.Coverage.RunRelations != "unsupported" || page.Coverage.ModelReceipts != "unsupported" || page.Coverage.CutoffConsistency != "committed-prefix" { t.Fatalf("coverage: %+v", page.Coverage) } if page.Receipts[0].ActorName != "BOB" { diff --git a/internal/app/surface_audit_actor_test.go b/internal/app/surface_audit_actor_test.go new file mode 100644 index 0000000..2749d7a --- /dev/null +++ b/internal/app/surface_audit_actor_test.go @@ -0,0 +1,50 @@ +package app + +import ( + "context" + "path/filepath" + "testing" + "time" + + agentcommand "agent-command" + "agent-system-backend/internal/cmdbus" + "agent-system-backend/internal/store" + "agent-system-backend/internal/surfacesvc" +) + +func TestSurfaceButtonDispatchUsesAuthenticatedActor(t *testing.T) { + st, err := store.OpenSQLite(filepath.Join(t.TempDir(), "audit.db")) + if err != nil { + t.Fatal(err) + } + defer st.Close() + if err := st.EnsureUser("alice", "Alice at action"); err != nil { + t.Fatal(err) + } + p, err := st.CreateProject("alice", "A") + if err != nil { + t.Fatal(err) + } + c, err := st.CreateConversation("alice", string(p.ID), "work", "") + if err != nil { + t.Fatal(err) + } + bus := cmdbus.New(st, nil, func() time.Time { return time.Now().UTC() }) + if err := bus.RegisterBuiltin(agentcommand.CommandSpec{ID: "demo.submit", Title: "Submit"}, "", func(context.Context, cmdbus.Request) (any, error) { return "ok", nil }); err != nil { + t.Fatal(err) + } + result, err := dispatchSurfaceAction(context.Background(), bus, surfacesvc.ActionDispatch{CommandID: "demo.submit", Owner: "alice", ConversationID: string(c.ID)}) + if err != nil { + t.Fatal(err) + } + if result.State != "committed" { + t.Fatalf("state: %s", result.State) + } + rows, _, _, err := st.ListProjectCommandAudits("alice", string(p.ID), 0, 0, 10) + if err != nil { + t.Fatal(err) + } + if len(rows) != 1 || rows[0].Envelope.Actor != "alice" || rows[0].ActorName != "Alice at action" { + t.Fatalf("button audit actor: %+v", rows) + } +} diff --git a/internal/app/surface_dispatch.go b/internal/app/surface_dispatch.go new file mode 100644 index 0000000..7a8137a --- /dev/null +++ b/internal/app/surface_dispatch.go @@ -0,0 +1,25 @@ +package app + +import ( + "context" + + "agent-system-backend/internal/cmdbus" + "agent-system-backend/internal/surfacesvc" +) + +// dispatchSurfaceAction receives Owner from SurfaceService's authenticated +// caller. The button is acting for that user, so both Actor and Owner must be +// populated before the command bus writes its audit envelope. +func dispatchSurfaceAction(ctx context.Context, bus *cmdbus.Bus, d surfacesvc.ActionDispatch) (surfacesvc.ActionOutcome, error) { + resp := bus.Dispatch(ctx, cmdbus.Request{ID: d.CommandID, Params: d.Params, + Entrance: "button", Actor: d.Owner, Owner: d.Owner, ConversationID: d.ConversationID}) + state := "committed" + if resp.Receipt.State != "" { + state = string(resp.Receipt.State) + } + cardID := "" + if resp.Card != nil { + cardID = string(resp.Card.ID) + } + return surfacesvc.ActionOutcome{State: state, CardID: cardID, Receipt: resp.Receipt, Payload: resp.Payload}, nil +} diff --git a/internal/store/migrate.go b/internal/store/migrate.go index 003b913..0c44edb 100644 --- a/internal/store/migrate.go +++ b/internal/store/migrate.go @@ -857,6 +857,15 @@ func init() { "sqlite": {`DROP INDEX IF EXISTS idx_command_audit_project_owner_offset`, `ALTER TABLE command_audit DROP COLUMN project_id`, `ALTER TABLE command_audit DROP COLUMN actor_name`}, "postgres": {`DROP INDEX IF EXISTS idx_command_audit_project_owner_offset`, `ALTER TABLE command_audit DROP COLUMN project_id`, `ALTER TABLE command_audit DROP COLUMN actor_name`}, }}, + migration{version: 32, name: "project_audit_committed_links", + up: map[string][]string{ + "sqlite": {`CREATE TABLE project_audit_links (id INTEGER PRIMARY KEY AUTOINCREMENT,host_audit_offset INTEGER NOT NULL REFERENCES command_audit(id),project_id TEXT NOT NULL,owner TEXT NOT NULL,source_kind TEXT NOT NULL,source_id TEXT NOT NULL,operation_id TEXT NOT NULL,resource_kind TEXT NOT NULL,resource_id TEXT NOT NULL,run_id TEXT NOT NULL DEFAULT '',disclosure_class TEXT NOT NULL,idempotency_key TEXT NOT NULL,created_at TEXT NOT NULL,UNIQUE(owner,idempotency_key),UNIQUE(host_audit_offset,source_kind,source_id))`, `CREATE INDEX idx_project_audit_links_source ON project_audit_links(project_id,source_kind,source_id,host_audit_offset)`}, + "postgres": {`CREATE TABLE project_audit_links (id BIGSERIAL PRIMARY KEY,host_audit_offset BIGINT NOT NULL REFERENCES command_audit(id),project_id TEXT NOT NULL,owner TEXT NOT NULL,source_kind TEXT NOT NULL,source_id TEXT NOT NULL,operation_id TEXT NOT NULL,resource_kind TEXT NOT NULL,resource_id TEXT NOT NULL,run_id TEXT NOT NULL DEFAULT '',disclosure_class TEXT NOT NULL,idempotency_key TEXT NOT NULL,created_at TEXT NOT NULL,UNIQUE(owner,idempotency_key),UNIQUE(host_audit_offset,source_kind,source_id))`, `CREATE INDEX idx_project_audit_links_source ON project_audit_links(project_id,source_kind,source_id,host_audit_offset)`}, + }, + down: map[string][]string{ + "sqlite": {`DROP TABLE IF EXISTS project_audit_links`}, + "postgres": {`DROP TABLE IF EXISTS project_audit_links`}, + }}, ) } diff --git a/internal/store/migrate_compat.go b/internal/store/migrate_compat.go index 88fd006..9160ed1 100644 --- a/internal/store/migrate_compat.go +++ b/internal/store/migrate_compat.go @@ -36,6 +36,7 @@ var migrationBreaksOldReaders = map[int]bool{ 29: false, // redeem_attempts：新表，旧读者不受影响 30: false, // project_event_publication_proofs：新表，旧读者不受影响 31: false, // command_audit_attribution_snapshot：仅加列/索引，旧读者不受影响 + 32: false, // project_audit_committed_links：新表，旧读者不受影响 } // SchemaTarget 是本二进制会迁移到的 schema 版本。 diff --git a/internal/store/project_audit_links.go b/internal/store/project_audit_links.go new file mode 100644 index 0000000..5b58dd8 --- /dev/null +++ b/internal/store/project_audit_links.go @@ -0,0 +1,143 @@ +package store + +import ( + "database/sql" + "encoding/json" + "errors" +) + +// ProjectAuditLink is an immutable association written only after a trusted +// domain verifier has checked the committed source event. +type ProjectAuditLink struct { + ID int64 + HostAuditOffset int64 + ProjectID string + Owner string + SourceKind string + SourceID string + OperationID string + ResourceKind string + ResourceID string + RunID string + DisclosureClass string + IdempotencyKey string +} + +func (s *Store) CommandAuditForLink(owner string, offset int64) (ProjectCommandAuditRow, string, error) { + var row ProjectCommandAuditRow + var projectID, raw string + if owner == "" || offset <= 0 { + return row, "", ErrNotFound + } + err := s.db.QueryRow(s.q(`SELECT id,actor_name,project_id,payload FROM command_audit WHERE id=? AND owner=? AND project_id<>''`), offset, owner). + Scan(&row.Offset, &row.ActorName, &projectID, &raw) + if errors.Is(err, sql.ErrNoRows) { + return row, "", ErrNotFound + } + if err != nil { + return row, "", err + } + if err := json.Unmarshal([]byte(raw), &row.Envelope); err != nil { + return row, "", err + } + return row, projectID, nil +} + +func (s *Store) RunBoundToAudit(owner, projectID, conversationID, runID string) (bool, error) { + if owner == "" || projectID == "" || conversationID == "" || runID == "" { + return false, nil + } + var one int + err := s.db.QueryRow(s.q(`SELECT 1 FROM runs WHERE id=? AND owner=? AND project_id=? AND conversation_id=?`), runID, owner, projectID, conversationID).Scan(&one) + if errors.Is(err, sql.ErrNoRows) { + return false, nil + } + return err == nil, err +} + +const projectAuditLinkColumns = `id,host_audit_offset,project_id,owner,source_kind,source_id,operation_id,resource_kind,resource_id,run_id,disclosure_class,idempotency_key` +const projectAuditLinkAliasedColumns = `l.id,l.host_audit_offset,l.project_id,l.owner,l.source_kind,l.source_id,l.operation_id,l.resource_kind,l.resource_id,l.run_id,l.disclosure_class,l.idempotency_key` + +func scanProjectAuditLink(scan func(...any) error) (ProjectAuditLink, error) { + var link ProjectAuditLink + err := scan(&link.ID, &link.HostAuditOffset, &link.ProjectID, &link.Owner, &link.SourceKind, &link.SourceID, + &link.OperationID, &link.ResourceKind, &link.ResourceID, &link.RunID, &link.DisclosureClass, &link.IdempotencyKey) + if errors.Is(err, sql.ErrNoRows) { + return link, ErrNotFound + } + return link, err +} + +func (s *Store) ProjectAuditLinkByKey(owner, key string) (ProjectAuditLink, error) { + if owner == "" || key == "" { + return ProjectAuditLink{}, ErrNotFound + } + return scanProjectAuditLink(func(dst ...any) error { + return s.db.QueryRow(s.q(`SELECT `+projectAuditLinkColumns+` FROM project_audit_links WHERE owner=? AND idempotency_key=?`), owner, key).Scan(dst...) + }) +} + +func sameProjectAuditLink(a, b ProjectAuditLink) bool { + return a.HostAuditOffset == b.HostAuditOffset && a.ProjectID == b.ProjectID && a.Owner == b.Owner && + a.SourceKind == b.SourceKind && a.SourceID == b.SourceID && a.OperationID == b.OperationID && + a.ResourceKind == b.ResourceKind && a.ResourceID == b.ResourceID && a.RunID == b.RunID && + a.DisclosureClass == b.DisclosureClass && a.IdempotencyKey == b.IdempotencyKey +} + +// SaveProjectAuditLink is idempotent for an identical key and binding. Both the +// key and the host/source triple are unique; racing or conflicting retries +// resolve by reading the committed winner, never by overwriting it. +func (s *Store) SaveProjectAuditLink(link ProjectAuditLink) (ProjectAuditLink, error) { + var id int64 + err := s.db.QueryRow(s.q(`INSERT INTO project_audit_links(host_audit_offset,project_id,owner,source_kind,source_id,operation_id,resource_kind,resource_id,run_id,disclosure_class,idempotency_key,created_at) + VALUES (?,?,?,?,?,?,?,?,?,?,?,?) ON CONFLICT DO NOTHING RETURNING id`), link.HostAuditOffset, link.ProjectID, link.Owner, + link.SourceKind, link.SourceID, link.OperationID, link.ResourceKind, link.ResourceID, link.RunID, link.DisclosureClass, + link.IdempotencyKey, nowISO()).Scan(&id) + if err == nil { + link.ID = id + return link, nil + } + if !errors.Is(err, sql.ErrNoRows) { + return ProjectAuditLink{}, err + } + previous, err := scanProjectAuditLink(func(dst ...any) error { + return s.db.QueryRow(s.q(`SELECT `+projectAuditLinkColumns+` FROM project_audit_links + WHERE (owner=? AND idempotency_key=?) OR (host_audit_offset=? AND source_kind=? AND source_id=?) LIMIT 1`), + link.Owner, link.IdempotencyKey, link.HostAuditOffset, link.SourceKind, link.SourceID).Scan(dst...) + }) + if err != nil { + return ProjectAuditLink{}, err + } + if !sameProjectAuditLink(previous, link) { + return ProjectAuditLink{}, ErrConflict + } + return previous, nil +} + +// ProjectAuditLinkedReceipt reads one exact association and the underlying +// host row. It does not enumerate private links or decide field disclosure. +func (s *Store) ProjectAuditLinkedReceipt(projectID, sourceKind, sourceID string, hostOffset int64) (ProjectAuditLink, ProjectCommandAuditRow, error) { + var row ProjectCommandAuditRow + var link ProjectAuditLink + var raw string + if projectID == "" || sourceKind == "" || sourceID == "" || hostOffset <= 0 { + return link, row, ErrNotFound + } + err := s.db.QueryRow(s.q(`SELECT `+projectAuditLinkAliasedColumns+`,a.actor_name,a.payload FROM project_audit_links l + JOIN command_audit a ON a.id=l.host_audit_offset AND a.owner=l.owner AND a.project_id=l.project_id + WHERE l.project_id=? AND l.source_kind=? AND l.source_id=? AND l.host_audit_offset=?`), + projectID, sourceKind, sourceID, hostOffset).Scan(&link.ID, &link.HostAuditOffset, &link.ProjectID, &link.Owner, + &link.SourceKind, &link.SourceID, &link.OperationID, &link.ResourceKind, &link.ResourceID, &link.RunID, + &link.DisclosureClass, &link.IdempotencyKey, &row.ActorName, &raw) + if errors.Is(err, sql.ErrNoRows) { + return link, row, ErrNotFound + } + if err != nil { + return link, row, err + } + row.Offset = link.HostAuditOffset + if err := json.Unmarshal([]byte(raw), &row.Envelope); err != nil { + return link, row, err + } + return link, row, nil +} diff --git a/internal/store/project_audit_links_test.go b/internal/store/project_audit_links_test.go new file mode 100644 index 0000000..b77838c --- /dev/null +++ b/internal/store/project_audit_links_test.go @@ -0,0 +1,84 @@ +package store + +import ( + "errors" + "testing" + "time" + + agentcommand "agent-command" +) + +func TestProjectAuditLinkStoreIdempotenceAndExactScope(t *testing.T) { + st := openTestStore(t) // SQLite locally; isolated PostgreSQL schema when configured. + if err := st.EnsureUser("alice", "Alice"); err != nil { + t.Fatal(err) + } + a, err := st.CreateProject("alice", "A") + if err != nil { + t.Fatal(err) + } + b, err := st.CreateProject("alice", "B") + if err != nil { + t.Fatal(err) + } + c, err := st.CreateConversation("alice", string(a.ID), "work", "") + if err != nil { + t.Fatal(err) + } + if err := st.AppendAudit("alice", agentcommand.AuditEnvelope{Time: time.Now(), Actor: "alice", CommandID: "rdm.confirm", OperationID: "op-1", ConversationID: string(c.ID), State: agentcommand.StateCommitted}); err != nil { + t.Fatal(err) + } + rows, _, _, err := st.ListProjectCommandAudits("alice", string(a.ID), 0, 0, 10) + if err != nil { + t.Fatal(err) + } + link := ProjectAuditLink{HostAuditOffset: rows[0].Offset, ProjectID: string(a.ID), Owner: "alice", SourceKind: "domain-commit", SourceID: "commit-1", OperationID: "op-1", ResourceKind: "document", ResourceID: "doc-1", DisclosureClass: "metadata", IdempotencyKey: "outbox-1"} + first, err := st.SaveProjectAuditLink(link) + if err != nil { + t.Fatal(err) + } + retry, err := st.SaveProjectAuditLink(link) + if err != nil || retry.ID != first.ID { + t.Fatalf("retry: first=%+v retry=%+v err=%v", first, retry, err) + } + if found, err := st.ProjectAuditLinkByKey("alice", "outbox-1"); err != nil || found.ID != first.ID { + t.Fatalf("key lookup: %+v %v", found, err) + } + if _, _, err := st.ProjectAuditLinkedReceipt(string(b.ID), "domain-commit", "commit-1", rows[0].Offset); !errors.Is(err, ErrNotFound) { + t.Fatalf("wrong project: %v", err) + } + if _, _, err := st.ProjectAuditLinkedReceipt(string(a.ID), "domain-commit", "other", rows[0].Offset); !errors.Is(err, ErrNotFound) { + t.Fatalf("wrong source: %v", err) + } + got, audit, err := st.ProjectAuditLinkedReceipt(string(a.ID), "domain-commit", "commit-1", rows[0].Offset) + if err != nil || got.ID != first.ID || audit.Envelope.CommandID != "rdm.confirm" { + t.Fatalf("linked read: %+v %+v %v", got, audit, err) + } + link.ResourceID = "doc-2" + if _, err := st.SaveProjectAuditLink(link); !errors.Is(err, ErrConflict) { + t.Fatalf("same key different binding: %v", err) + } + link.ResourceID = "doc-1" + link.IdempotencyKey = "outbox-2" + if _, err := st.SaveProjectAuditLink(link); !errors.Is(err, ErrConflict) { + t.Fatalf("same source different key: %v", err) + } + if err := st.EnsureUser("bob", "Bob"); err != nil { + t.Fatal(err) + } + bobConversation, err := st.CreateConversationInProject("bob", string(a.ID), "shared work", "") + if err != nil { + t.Fatal(err) + } + if err := st.AppendAudit("bob", agentcommand.AuditEnvelope{Time: time.Now(), Actor: "bob", CommandID: "rdm.confirm", OperationID: "op-bob", ConversationID: string(bobConversation.ID), State: agentcommand.StateCommitted}); err != nil { + t.Fatal(err) + } + bobRows, _, _, err := st.ListProjectCommandAudits("bob", string(a.ID), 0, 0, 10) + if err != nil { + t.Fatal(err) + } + bobLink := ProjectAuditLink{HostAuditOffset: bobRows[0].Offset, ProjectID: string(a.ID), Owner: "bob", SourceKind: "domain-commit", SourceID: "commit-bob", OperationID: "op-bob", ResourceKind: "document", ResourceID: "doc-bob", DisclosureClass: "metadata", IdempotencyKey: "outbox-1"} + if _, err := st.SaveProjectAuditLink(bobLink); err != nil { + t.Fatalf("another owner may use the same outbox key: %v", err) + } +} diff --git a/internal/store/project_audit_test.go b/internal/store/project_audit_test.go index 2ccb55b..db91605 100644 --- a/internal/store/project_audit_test.go +++ b/internal/store/project_audit_test.go @@ -2,6 +2,7 @@ package store import ( "encoding/json" + "os" "path/filepath" "testing" "time" @@ -172,3 +173,62 @@ func TestProjectCommandAuditDoesNotMoveWithConversation(t *testing.T) { t.Fatalf("project attribution changed: A=%+v B=%+v", oldProject, newProject) } } + +// PostgreSQL sequence IDs are allocated before commit. This test records the +// current upper-bound semantics: a lower ID can appear after a page cutoff was +// captured, so callers must not describe the cutoff as a visibility snapshot. +func TestProjectAuditPostgresCutoffLateCommit(t *testing.T) { + if os.Getenv("AGENT_PG_TEST_DSN") == "" { + t.Skip("AGENT_PG_TEST_DSN unset: PG concurrency check NOT_RUN") + } + st := openTestStore(t) + if st.Dialect() != "postgres" { + t.Fatal("expected postgres") + } + if err := st.EnsureUser("alice", "Alice"); err != nil { + t.Fatal(err) + } + p, err := st.CreateProject("alice", "A") + if err != nil { + t.Fatal(err) + } + c, err := st.CreateConversation("alice", string(p.ID), "work", "") + if err != nil { + t.Fatal(err) + } + env := agentcommand.AuditEnvelope{Time: time.Now(), Actor: "alice", CommandID: "late-low-id", ConversationID: string(c.ID)} + raw, err := json.Marshal(env) + if err != nil { + t.Fatal(err) + } + tx, err := st.db.Begin() + if err != nil { + t.Fatal(err) + } + defer tx.Rollback() + var lowID int64 + if err := tx.QueryRow(st.q(`INSERT INTO command_audit(time,command_id,source,entrance,state,operation_id,conversation_id,owner,payload,actor_name,project_id) + VALUES (?,?,'','','','',?,?,?,?,?) RETURNING id`), time.Now().UTC().Format(time.RFC3339Nano), "late-low-id", string(c.ID), "alice", string(raw), "Alice", string(p.ID)).Scan(&lowID); err != nil { + t.Fatal(err) + } + if err := st.AppendAudit("alice", agentcommand.AuditEnvelope{Time: time.Now(), Actor: "alice", CommandID: "committed-high-id", ConversationID: string(c.ID)}); err != nil { + t.Fatal(err) + } + first, cutoff, _, err := st.ListProjectCommandAudits("alice", string(p.ID), 0, 0, 10) + if err != nil { + t.Fatal(err) + } + if len(first) != 1 || first[0].Envelope.CommandID != "committed-high-id" || lowID >= cutoff { + t.Fatalf("first page: rows=%+v low=%d cutoff=%d", first, lowID, cutoff) + } + if err := tx.Commit(); err != nil { + t.Fatal(err) + } + later, fixed, _, err := st.ListProjectCommandAudits("alice", string(p.ID), 0, cutoff, 10) + if err != nil { + t.Fatal(err) + } + if fixed != cutoff || len(later) != 2 || later[1].Envelope.CommandID != "late-low-id" { + t.Fatalf("late commit not exposed: rows=%+v cutoff=%d", later, fixed) + } +} diff --git a/pkg/extension/extension.go b/pkg/extension/extension.go index 2996105..fca22f9 100644 --- a/pkg/extension/extension.go +++ b/pkg/extension/extension.go @@ -36,7 +36,9 @@ import ( // ResourceAuthzQuery.Source for per-document publication authorization. // 2.13.0-experimental: optional ProjectAuditHost and ProjectAuditRegistry (X2 // project-bound command-audit read slice and domain audit.read callback). -const SurfaceVersion = "2.13.0-experimental" +// 2.14.0-experimental: X2 optional committed project-audit link publisher, +// verifier, disclosure callback, and exact linked receipt read. +const SurfaceVersion = "2.14.0-experimental" // ErrNotLinked 表示进程没有空白导入 link 包，Main 无法启动服务。 var ErrNotLinked = errors.New("extension: runner not linked; blank-import agent-system-backend/pkg/extension/link") diff --git a/pkg/extension/project_audit.go b/pkg/extension/project_audit.go index 43beaed..e993508 100644 --- a/pkg/extension/project_audit.go +++ b/pkg/extension/project_audit.go @@ -20,18 +20,89 @@ type ProjectAuditRegistry interface { } var ( - ErrProjectAuditDenied = errors.New("extension: project audit denied") - ErrProjectAuditUnsupported = errors.New("extension: project audit unsupported") + ErrProjectAuditDenied = errors.New("extension: project audit denied") + ErrProjectAuditUnsupported = errors.New("extension: project audit unsupported") + ErrProjectAuditLinkConflict = errors.New("extension: project audit link conflict") ) +// ProjectAuditLinkRequest binds one host command receipt to an already +// committed domain fact. Owner is never caller supplied; the host handle and +// stored audit row establish it. This first slice supports domain-commit only. +type ProjectAuditLinkRequest struct { + ProjectID core.ID `json:"projectId"` + HostAuditOffset int64 `json:"hostAuditOffset"` + SourceKind string `json:"sourceKind"` + SourceID string `json:"sourceId"` + OperationID string `json:"operationId"` + ResourceKind string `json:"resourceKind"` + ResourceID string `json:"resourceId"` + RunID string `json:"runId,omitempty"` + DisclosureClass string `json:"disclosureClass"` + IdempotencyKey string `json:"idempotencyKey"` +} + +// ProjectAuditLinkProof contains the caller request plus identity and source +// fields re-read from trusted host storage. The domain verifier must check its +// committed source event and operation/resource attribution, not a model claim. +type ProjectAuditLinkProof struct { + ProjectAuditLinkRequest + Owner string +} + +type ProjectAuditLinkVerifier func(context.Context, ProjectAuditLinkProof) (bool, error) + +// ProjectAuditLinkedResource is the stored, immutable link presented to the +// current domain disclosure policy. A caller ID alone never authorizes it. +type ProjectAuditLinkedResource struct { + ProjectID core.ID + Owner string + SourceKind string + SourceID string + OperationID string + ResourceKind string + ResourceID string + RunID string + DisclosureClass string +} + +type ProjectAuditDisclosure struct { + Metadata bool + Body bool +} + +type ProjectAuditDisclosureAuthorizer func(context.Context, string, ProjectAuditLinkedResource) (ProjectAuditDisclosure, error) + +// ProjectAuditLinkRegistry is optional. Only the registering compiled domain +// plugin may publish or read its links. +type ProjectAuditLinkRegistry interface { + RegisterProjectAuditLinkVerifier(ProjectAuditLinkVerifier) error + RegisterProjectAuditDisclosureAuthorizer(ProjectAuditDisclosureAuthorizer) error +} + +type ProjectAuditLinkReceipt struct { + LinkID int64 `json:"linkId"` + HostAuditOffset int64 `json:"hostAuditOffset"` +} + +type ProjectAuditPublisher interface { + PublishProjectAuditLink(context.Context, ProjectAuditLinkRequest) (ProjectAuditLinkReceipt, error) +} + // ProjectAuditQuery reads one project-bound command-audit slice. Offset is a // host source offset, not a cross-domain event sequence. A nonzero BeforeOffset -// must be paired with the CutoffOffset returned on the first page. +// must be paired with the CutoffOffset returned on the first page. On PostgreSQL +// that cutoff bounds offsets but is not a fixed visibility snapshot: a lower ID +// from a still-open transaction may commit later. See Coverage.CutoffConsistency. type ProjectAuditQuery struct { ProjectID core.ID `json:"projectId"` BeforeOffset int64 `json:"beforeOffset,omitempty"` CutoffOffset int64 `json:"cutoffOffset,omitempty"` Limit int `json:"limit,omitempty"` + // Linked* select one exact committed link. This avoids enumerating hidden + // private links or leaking their counts before cursor policy is complete. + LinkedSourceKind string `json:"linkedSourceKind,omitempty"` + LinkedSourceID string `json:"linkedSourceId,omitempty"` + LinkedHostOffset int64 `json:"linkedHostOffset,omitempty"` } // HostAuditReceipt is a server-projected receipt, never a raw audit payload. @@ -52,6 +123,7 @@ type HostAuditReceipt struct { // host sources and old unbound rows cannot be inferred from owner-wide audit. type ProjectAuditCoverage struct { CommandAudit string `json:"commandAudit"` + CutoffConsistency string `json:"cutoffConsistency"` CrossMember string `json:"crossMember"` LegacyProjectBinding string `json:"legacyProjectBinding"` RunRelations string `json:"runRelations"` diff --git a/pkg/extension/surface.txt b/pkg/extension/surface.txt index 66b08a9..2e88d0e 100644 --- a/pkg/extension/surface.txt +++ b/pkg/extension/surface.txt @@ -9,6 +9,7 @@ AdminZoneSpec Compiled ErrNotLinked ErrProjectAuditDenied +ErrProjectAuditLinkConflict ErrProjectAuditUnsupported Handler Host @@ -37,9 +38,21 @@ NewScopedHost Options ProjectAuditAuthorizer ProjectAuditCoverage +ProjectAuditDisclosure +ProjectAuditDisclosureAuthorizer ProjectAuditHost ProjectAuditHost.QueryProjectAudit +ProjectAuditLinkProof +ProjectAuditLinkReceipt +ProjectAuditLinkRegistry +ProjectAuditLinkRegistry.RegisterProjectAuditDisclosureAuthorizer +ProjectAuditLinkRegistry.RegisterProjectAuditLinkVerifier +ProjectAuditLinkRequest +ProjectAuditLinkVerifier +ProjectAuditLinkedResource ProjectAuditPage +ProjectAuditPublisher +ProjectAuditPublisher.PublishProjectAuditLink ProjectAuditQuery ProjectAuditRegistry ProjectAuditRegistry.RegisterProjectAuditAuthorizer -- 2.54.0 From 44ccd63d3bec14cb87ee39ba5376247562326a75 Mon Sep 17 00:00:00 2001 From: weichen Date: Wed, 14 Oct 2026 04:09:58 +0000 Subject: [PATCH 03/41] Add trusted project context to work model calls Why: Project work currently reaches model calls without current authorized project facts or a persisted input receipt. Evidence: SELF go test ./... -count=1, targeted go test -race for W6 paths, go vet ./..., and CGO_ENABLED=0 go build ./cmd/agent-system passed on this change set. Impact: Add optional X1 interfaces, trusted persisted work-task binding, request-scoped context injection, evidence reauthorization, and attempted/responded/unknown manifests. Existing non-project behavior stays available. Refs: TT-C01 TT-C02 TT-C03 TT-C04; stage5 W6; Dev stage6 X1 public extension request r1 --- cmd/storage-migrate/main.go | 4 +- internal/app/app.go | 32 +- internal/app/compiled.go | 3 +- internal/app/hostcaps.go | 11 +- internal/app/project_context.go | 328 +++++++++++++++++++ internal/app/project_context_test.go | 347 +++++++++++++++++++++ internal/projectcontext/context.go | 82 +++++ internal/projectcontext/context_test.go | 43 +++ internal/projectcontext/receipt.go | 57 ++++ internal/runmgr/project_context.go | 226 ++++++++++++++ internal/runmgr/project_context_test.go | 194 ++++++++++++ internal/runmgr/runmgr.go | 39 ++- internal/runtime/llm.go | 38 ++- internal/runtime/llm_direct.go | 122 +++++++- internal/runtime/project_context_test.go | 193 ++++++++++++ internal/runtime/project_stream.go | 165 ++++++++++ internal/runtime/squad_runner.go | 8 +- internal/runtime/sub_loop.go | 1 + internal/runtime/transcript_compact.go | 8 +- internal/runtime/workflow_compiled.go | 3 +- internal/runtime/workflow_compiled_test.go | 45 +++ internal/store/context_manifest.go | 50 +++ internal/store/migrate.go | 7 + internal/store/migrate_compat.go | 1 + internal/store/work_tasks.go | 57 ++++ pkg/extension/extension.go | 5 +- pkg/extension/host.go | 2 + pkg/extension/link/link.go | 1 + pkg/extension/project_context.go | 142 +++++++++ pkg/extension/surface.txt | 24 ++ 30 files changed, 2191 insertions(+), 47 deletions(-) create mode 100644 internal/app/project_context.go create mode 100644 internal/app/project_context_test.go create mode 100644 internal/projectcontext/context.go create mode 100644 internal/projectcontext/context_test.go create mode 100644 internal/projectcontext/receipt.go create mode 100644 internal/runmgr/project_context.go create mode 100644 internal/runmgr/project_context_test.go create mode 100644 internal/runtime/project_context_test.go create mode 100644 internal/runtime/project_stream.go create mode 100644 internal/store/context_manifest.go create mode 100644 internal/store/work_tasks.go create mode 100644 pkg/extension/project_context.go diff --git a/cmd/storage-migrate/main.go b/cmd/storage-migrate/main.go index 7ee9cb2..2229194 100644 --- a/cmd/storage-migrate/main.go +++ b/cmd/storage-migrate/main.go @@ -286,7 +286,7 @@ var copyOrder = []string{ "hitl_cards", "plans", "todos", "knowledge", "knowledge_vectors", "activity_cards", "project_event_shares", "command_audit", "prompt_modules", "sessions", "api_keys", - "plugin_grants", "plugin_schema", "plugin_kv", "background_tasks", + "plugin_grants", "plugin_schema", "plugin_kv", "background_tasks", "work_task_bindings", "memory_entries", "audit_events", "pending_confirms", "llm_usage_daily", "secret_keys", "settings_snapshots", "regen_pending", "context_entries", "user_commands", "pending_notices", "recovery_holds", @@ -784,7 +784,7 @@ func advanceSequences(db *sql.DB, table string) error { // checkOwners：业务行引用的 owner 必须存在于 users（单租户默认 ”/'local' // 除外）。未知 owner 阻塞迁移（U4/R7：不静默带过未知归属）。 func checkOwners(db *sql.DB, src *sql.DB) error { - ownerTables := []string{"projects", "conversations", "runs", "artifacts", "knowledge", "hitl_cards", "profiles", "activity_cards", "project_event_shares", "command_audit"} + ownerTables := []string{"projects", "conversations", "runs", "artifacts", "knowledge", "hitl_cards", "profiles", "activity_cards", "project_event_shares", "command_audit", "work_task_bindings"} for _, t := range ownerTables { if !sqliteHasTable(src, t) { continue diff --git a/internal/app/app.go b/internal/app/app.go index 33749b7..0f9a111 100644 --- a/internal/app/app.go +++ b/internal/app/app.go @@ -60,16 +60,17 @@ import ( ) type Options struct { - Addr string - DataDir string - PluginsDir string - ForceMock bool - StorageDSN string // 空 = 嵌入式 SQLite 档；非空 = PostgreSQL 档（多用户/多实例） - ArtifactsDir string // PG 档工件对象目录（空 = /artifacts） - AuthMode string // auto（默认：PG 档开、嵌入式关）| on | off - InstanceID string // 空 = 主机名:监听地址；写入 runs.instance_id，启动对账只收口本实例 - InsecureListen bool - AllowedHosts []string + Addr string + DataDir string + PluginsDir string + ForceMock bool + StorageDSN string // 空 = 嵌入式 SQLite 档；非空 = PostgreSQL 档（多用户/多实例） + ArtifactsDir string // PG 档工件对象目录（空 = /artifacts） + AuthMode string // auto（默认：PG 档开、嵌入式关）| on | off + RequireProjectContext bool + InstanceID string // 空 = 主机名:监听地址；写入 runs.instance_id，启动对账只收口本实例 + InsecureListen bool + AllowedHosts []string // DisableUploadIndexing EXT-9：true 时上传端点不自动写检索索引（发布决定 // 移交下游命令层）；零值=false=现状。由 link 层自 extension.Options 透传。 DisableUploadIndexing bool @@ -380,6 +381,7 @@ func Run(opt Options) error { return nil }, } + cfg.Stream = runtime.GuardProjectStream(rc, "", cfg.Client.Stream) tavilyNow := effNow.GetString("tools.tavily.apiKeys", "") if active, ok := st.ActiveSecret(store.OwnerDefault, "tools.tavily"); ok { tavilyNow = active @@ -597,7 +599,8 @@ func Run(opt Options) error { // hostcaps：hostapi 闭包与进程内插件句柄共用的 owner 作用域能力（EXT-1 批注 1）。 authzSlot := &projectAuthz{} projectSlot := &projectLifecycleSlot{} - caps := hostcaps{projects: projectSlot, st: st, pipe: pipe, set: setSvc, authz: authzSlot, surfaces: surfaceSvc} + contextSlot := &projectContextSlot{} + caps := hostcaps{projects: projectSlot, contexts: contextSlot, st: st, pipe: pipe, set: setSvc, authz: authzSlot, surfaces: surfaceSvc} // EXT-13：回合内检索（knowledge_search / @knowledge 注入）与 HTTP/Host 检索面 // 同一适配器授权；槽为共享指针，扩展在 applyCompiled 期间注册后即生效。 mgr.SetSharedKnowledgeAllow(func(owner string, projectID core.ID) bool { @@ -610,7 +613,14 @@ func Run(opt Options) error { // EXT-11：公开受限 Host 工厂（下游恢复路径经 extension.NewScopedHost 重建句柄）。 wireScopedHostFactory(caps) compiledSummary := applyCompiled(skillsRoot, bus, caps) + if err := requireProjectContextProvider(opt.RequireProjectContext, contextSlot); err != nil { + return err + } mgr.SetProjectWorkAuthorization(projectSlot.work()) + if contextSlot.active() { + mgr.SetProjectContextResolver(contextSlot.resolve) + mgr.SetProjectEvidenceReader(contextSlot.readEvidence) + } mgr.SetKnowledgeProjectScope(func(ctx context.Context, actor string, id core.ID) (core.ID, error) { return projectSlot.resolve(ctx, caps, actor, id) }) diff --git a/internal/app/compiled.go b/internal/app/compiled.go index da47164..f73b6f3 100644 --- a/internal/app/compiled.go +++ b/internal/app/compiled.go @@ -64,7 +64,8 @@ func (r pluginRegistry) AddCommandHandler(spec json.RawMessage, h extension.Hand return fmt.Errorf("extension: command spec: %w", err) } return r.bus.RegisterPluginCommand(s, func(ctx context.Context, req cmdbus.Request) (any, error) { - host := inprocHost{caps: r.caps, pluginID: r.pluginID, owner: req.Owner, actor: req.Actor} + host := inprocHost{caps: r.caps, pluginID: r.pluginID, owner: req.Owner, actor: req.Actor, + conversationID: core.ID(req.ConversationID), hostProjectID: core.ID(req.HostProjectID)} return h(ctx, host, extension.Request{ ID: req.ID, Params: req.Params, Entrance: req.Entrance, Actor: req.Actor, Owner: req.Owner, ConversationID: req.ConversationID, diff --git a/internal/app/hostcaps.go b/internal/app/hostcaps.go index 866a4f4..890adb6 100644 --- a/internal/app/hostcaps.go +++ b/internal/app/hostcaps.go @@ -22,6 +22,7 @@ import ( // inprocHost（EXT-1 批注 1：复用现有 owner 作用域函数，不新造句柄）。 type hostcaps struct { projects *projectLifecycleSlot + contexts *projectContextSlot st *store.Store pipe *rag.Pipeline set *settings.Service @@ -170,10 +171,12 @@ func (c hostcaps) parse(ctx context.Context, filename, mime string, content []by // actor 是本次分发主体（通常等于 owner）；AdminProvider 能力经 actor 查询 // （EXT-18）。非 dispatch 上下文（EXT-11 scoped host）actor 为空——IsAdmin 恒 false。 type inprocHost struct { - caps hostcaps - pluginID string - owner string - actor string // EXT-18：分发主体（空＝非 dispatch 上下文） + caps hostcaps + pluginID string + owner string + actor string // EXT-18：分发主体（空＝非 dispatch 上下文） + conversationID core.ID // dispatch-bound, never taken from completion arguments + hostProjectID core.ID // dispatch project; rechecked against stored conversation } func (h inprocHost) PluginID() string { return h.pluginID } diff --git a/internal/app/project_context.go b/internal/app/project_context.go new file mode 100644 index 0000000..fb056d3 --- /dev/null +++ b/internal/app/project_context.go @@ -0,0 +1,328 @@ +package app + +import ( + "context" + "crypto/sha256" + "errors" + "fmt" + "strings" + "sync" + "time" + + "agent-system-backend/internal/projectcontext" + "agent-system-backend/internal/runtime" + "agent-system-backend/pkg/extension" + core "agent-system-core" +) + +type projectContextSlot struct { + mu sync.RWMutex + holder string + provider extension.ProjectContextProvider +} + +func (s *projectContextSlot) active() bool { + if s == nil { + return false + } + s.mu.RLock() + defer s.mu.RUnlock() + return s.provider != nil +} + +func requireProjectContextProvider(required bool, slot *projectContextSlot) error { + if required && !slot.active() { + return errors.New("extension: required project context provider not assembled") + } + return nil +} + +func (r compiledRegistry) RegisterProjectContextProvider(extension.ProjectContextProvider) error { + return errors.New("extension: declarative plugins cannot register project context providers") +} + +func (r pluginRegistry) RegisterProjectContextProvider(p extension.ProjectContextProvider) error { + if r.caps.contexts == nil || r.pluginID == "" || p == nil { + return errors.New("extension: project context provider unavailable") + } + slot := r.caps.contexts + slot.mu.Lock() + defer slot.mu.Unlock() + if slot.provider != nil { + return errors.New("extension: project context provider already registered") + } + slot.holder, slot.provider = r.pluginID, p + return nil +} + +func (r recordRegistry) RegisterProjectContextProvider(p extension.ProjectContextProvider) error { + reg, ok := r.Registry.(extension.ProjectContextRegistry) + if !ok { + return errors.New("extension: project context registration unavailable") + } + return reg.RegisterProjectContextProvider(p) +} + +func (s *projectContextSlot) resolve(ctx context.Context, req extension.ProjectContextRequest) (extension.ProjectContextBundle, error) { + if s == nil { + return extension.ProjectContextBundle{}, errors.New("extension: project context provider missing") + } + s.mu.RLock() + p, holder := s.provider, s.holder + s.mu.RUnlock() + if p == nil { + return extension.ProjectContextBundle{}, errors.New("extension: project context provider missing") + } + if req.Actor == "" || req.ProjectID == "" { + return extension.ProjectContextBundle{}, errors.New("extension: trusted project scope missing") + } + req.PluginID = holder + bounded, cancel := context.WithTimeout(ctx, 3*time.Second) + defer cancel() + b, err := p.Resolve(bounded, req) + if err != nil { + return extension.ProjectContextBundle{}, err + } + if err := bounded.Err(); err != nil { + return extension.ProjectContextBundle{}, err + } + if b.ProjectID != req.ProjectID || b.Status != extension.ProjectContextReady { + return extension.ProjectContextBundle{}, fmt.Errorf("extension: project context unavailable: %s", b.Status) + } + return b, nil +} + +func (s *projectContextSlot) readEvidence(ctx context.Context, req extension.ProjectEvidenceRequest) (extension.ProjectEvidence, error) { + if s == nil || req.Scope.Actor == "" || req.Scope.ProjectID == "" || req.Reference.ID == "" { + return extension.ProjectEvidence{}, errors.New("extension: trusted evidence scope missing") + } + s.mu.RLock() + p, holder := s.provider, s.holder + s.mu.RUnlock() + if p == nil { + return extension.ProjectEvidence{}, errors.New("extension: project context provider missing") + } + req.Scope.PluginID = holder + bounded, cancel := context.WithTimeout(ctx, 3*time.Second) + defer cancel() + evidence, err := p.ReadEvidence(bounded, req) + if err != nil { + return extension.ProjectEvidence{}, err + } + if err := bounded.Err(); err != nil { + return extension.ProjectEvidence{}, err + } + if evidence.Reference != req.Reference || len([]rune(evidence.Text)) > req.Scope.BudgetChars { + return extension.ProjectEvidence{}, errors.New("extension: project evidence response mismatches reference or budget") + } + return evidence, nil +} + +const workContextBudgetChars = 12000 + +// TaskCreateForWork fixes the project binding while the authenticated command +// dispatch still owns its conversation. Legacy TaskCreate has no such binding. +func (h inprocHost) TaskCreateForWork(kind, title string) (string, error) { + if h.actor == "" || h.actor != h.owner || h.pluginID == "" || h.conversationID == "" || h.caps.st == nil || !h.caps.contexts.active() { + return "", errors.New("extension: trusted project work dispatch required") + } + conv, err := h.caps.st.GetConversation(h.owner, string(h.conversationID)) + if err != nil { + return "", err + } + if conv.ProjectID == "" || (h.hostProjectID != "" && h.hostProjectID != conv.ProjectID) || h.caps.projects == nil || h.caps.projects.work() == nil { + return "", errors.New("extension: trusted project work scope missing") + } + ctx, cancel := context.WithTimeout(context.Background(), 3*time.Second) + defer cancel() + allowed, err := h.caps.projects.work()(ctx, h.actor, conv.ProjectID) + if err != nil || !allowed { + return "", errors.New("extension: project work denied") + } + task, err := h.caps.st.CreateWorkTask(h.owner, h.pluginID, string(conv.ProjectID), string(conv.ID), kind, title) + return task.ID, err +} + +// completeForWork is the dispatch-scoped completion path. The conversation is +// reloaded so a plugin's goal/target and a stale dispatch project cannot select +// another project's context. Work authorization is checked on every call. +func (h inprocHost) CompleteForWork(ctx context.Context, req extension.WorkCompletionRequest) (extension.WorkCompletionResult, error) { + if strings.TrimSpace(req.Goal) == "" { + return extension.WorkCompletionResult{}, errors.New("extension: work goal required") + } + if h.caps.st == nil { + return extension.WorkCompletionResult{}, errors.New("extension: trusted work store missing") + } + actor, convID, targetID := h.actor, h.conversationID, string(h.conversationID) + var boundProjectID core.ID + if actor == "" { + if req.TaskID == "" || convID != "" { + return extension.WorkCompletionResult{}, errors.New("extension: persisted work task required for scoped host") + } + binding, err := h.caps.st.WorkTaskScope(h.owner, h.pluginID, req.TaskID) + if err != nil { + return extension.WorkCompletionResult{}, err + } + if binding.Status == "done" || binding.Status == "completed" || binding.Status == "failed" || binding.Status == "cancelled" { + return extension.WorkCompletionResult{}, errors.New("extension: work task already terminal") + } + actor, convID, boundProjectID, targetID = binding.Owner, core.ID(binding.ConversationID), core.ID(binding.ProjectID), binding.TaskID + } else if actor != h.owner || convID == "" || req.TaskID != "" { + return extension.WorkCompletionResult{}, errors.New("extension: trusted work dispatch required") + } + conv, err := h.caps.st.GetConversation(h.owner, string(convID)) + if err != nil { + return extension.WorkCompletionResult{}, err + } + if conv.ProjectID == "" || (h.hostProjectID != "" && h.hostProjectID != conv.ProjectID) || (boundProjectID != "" && boundProjectID != conv.ProjectID) { + return extension.WorkCompletionResult{}, errors.New("extension: trusted project scope mismatch") + } + if h.caps.projects == nil || h.caps.projects.work() == nil { + return extension.WorkCompletionResult{}, errors.New("extension: project work authorization missing") + } + allowed, err := h.caps.projects.work()(ctx, actor, conv.ProjectID) + if err != nil { + return extension.WorkCompletionResult{}, err + } + if !allowed { + return extension.WorkCompletionResult{}, errors.New("extension: project work denied") + } + requested := extension.ProjectContextRequest{ + Actor: actor, ProjectID: conv.ProjectID, ConversationID: conv.ID, TaskID: core.ID(req.TaskID), + Goal: req.Goal, TargetID: req.TargetID, BudgetChars: workContextBudgetChars, + } + bundle, err := h.caps.contexts.resolve(ctx, requested) + if err != nil { + return extension.WorkCompletionResult{}, err + } + evidenceText, usedEvidence, err := h.readWorkEvidence(ctx, requested, bundle, req.EvidenceRefs) + if err != nil { + return extension.WorkCompletionResult{}, err + } + prompt, manifest, err := assembleWorkCompletionWithEvidence(req.Goal, bundle, workContextBudgetChars, evidenceText, usedEvidence) + if err != nil { + return extension.WorkCompletionResult{}, err + } + manifest.ProjectID = conv.ProjectID + manifest.TaskID = req.TaskID + route := runtime.ResolveChatModel(core.AgentProfile{}, h.caps.set.Effective(h.owner, "")) + manifest.Model = route.Model + if route.Model == "" || route.Base == "" { + return extension.WorkCompletionResult{}, errors.New("llm route not configured") + } + // Resolve can be slow. A member may be revoked while the provider is + // assembling summaries, so check the live work policy again at send time. + allowed, err = h.caps.projects.work()(ctx, actor, conv.ProjectID) + if err != nil { + return extension.WorkCompletionResult{}, err + } + if !allowed { + return extension.WorkCompletionResult{}, errors.New("extension: project work denied") + } + current, err := h.caps.contexts.resolve(ctx, requested) + if err != nil { + return extension.WorkCompletionResult{}, err + } + if err := projectcontext.ValidateCurrent(manifest, current); err != nil { + return extension.WorkCompletionResult{}, err + } + for _, used := range manifest.ReadEvidence { + found := false + for _, ref := range current.Evidence { + if ref.ID != used.ReferenceID || ref.SourceID != used.SourceID || ref.Revision != used.Revision || ref.Hash != used.SourceHash { + continue + } + scope := requested + scope.BudgetChars = 8000 + now, err := h.caps.contexts.readEvidence(ctx, extension.ProjectEvidenceRequest{Scope: scope, Reference: ref}) + if err != nil { + return extension.WorkCompletionResult{}, err + } + if fmt.Sprintf("%x", sha256.Sum256([]byte(now.Text))) == used.InputSHA256 { + found = true + } + break + } + if !found { + return extension.WorkCompletionResult{}, errors.New("extension: requested work evidence changed before model send") + } + } + attemptID, err := projectcontext.NewAttemptID() + if err != nil { + return extension.WorkCompletionResult{}, err + } + manifest.AttemptID, manifest.Delivery = attemptID, "attempted" + if err := h.caps.st.AppendContextManifest(h.owner, targetID, manifest); err != nil { + return extension.WorkCompletionResult{}, err + } + text, err := completeChat(ctx, route.Base, route.Key, route.Model, prompt) + if err != nil { + manifest.Delivery = "unknown" + _ = h.caps.st.AppendContextManifest(h.owner, targetID, manifest) + return extension.WorkCompletionResult{}, err + } + manifest.Delivery = "responded" + if err := h.caps.st.AppendContextManifest(h.owner, targetID, manifest); err != nil { + return extension.WorkCompletionResult{}, err + } + return extension.WorkCompletionResult{Text: text, Manifest: manifest}, nil +} + +func assembleWorkCompletion(goal string, bundle extension.ProjectContextBundle, budget int) (string, extension.ProjectContextManifest, error) { + return assembleWorkCompletionWithEvidence(goal, bundle, budget, "", nil) +} + +func assembleWorkCompletionWithEvidence(goal string, bundle extension.ProjectContextBundle, budget int, evidenceText string, used []extension.ProjectContextManifestEntry) (string, extension.ProjectContextManifest, error) { + prefix := "Work goal:\n" + goal + "\n\n" + ref, m, err := projectcontext.Assemble(bundle, budget-len([]rune(prefix))-len([]rune(evidenceText))) + if err != nil { + return "", m, err + } + prompt := prefix + ref + evidenceText + m.BudgetChars = budget + m.ReadEvidence = used + m.InputSHA256 = fmt.Sprintf("%x", sha256.Sum256([]byte(prompt))) + return prompt, m, nil +} + +func (h inprocHost) readWorkEvidence(ctx context.Context, scope extension.ProjectContextRequest, bundle extension.ProjectContextBundle, ids []string) (string, []extension.ProjectContextManifestEntry, error) { + if len(ids) > 4 { + return "", nil, errors.New("extension: too many work evidence references") + } + var b strings.Builder + var used []extension.ProjectContextManifestEntry + seen := make(map[string]bool, len(ids)) + for _, id := range ids { + if id == "" || seen[id] { + return "", nil, errors.New("extension: invalid or duplicate work evidence reference") + } + seen[id] = true + var selected extension.ProjectEvidenceRef + for _, ref := range bundle.Evidence { + if ref.ID == id { + selected = ref + break + } + } + if selected.ID == "" { + return "", nil, errors.New("extension: work evidence reference not in current bundle") + } + readScope := scope + readScope.BudgetChars = 8000 + evidence, err := h.caps.contexts.readEvidence(ctx, extension.ProjectEvidenceRequest{Scope: readScope, Reference: selected}) + if err != nil { + return "", nil, err + } + b.WriteString("\n[Evidence ") + b.WriteString(selected.ID) + b.WriteString(" source ") + b.WriteString(selected.SourceID) + b.WriteString(" revision ") + b.WriteString(selected.Revision) + b.WriteString("]\n") + b.WriteString(evidence.Text) + used = append(used, extension.ProjectContextManifestEntry{ReferenceID: selected.ID, SourceID: selected.SourceID, Revision: selected.Revision, SourceHash: selected.Hash, + InputSHA256: fmt.Sprintf("%x", sha256.Sum256([]byte(evidence.Text)))}) + } + return b.String(), used, nil +} diff --git a/internal/app/project_context_test.go b/internal/app/project_context_test.go new file mode 100644 index 0000000..833615b --- /dev/null +++ b/internal/app/project_context_test.go @@ -0,0 +1,347 @@ +package app + +import ( + "context" + "crypto/sha256" + "encoding/json" + "fmt" + "net/http" + "net/http/httptest" + "path/filepath" + "strings" + "testing" + + "agent-system-backend/internal/settings" + "agent-system-backend/internal/store" + "agent-system-backend/pkg/extension" + core "agent-system-core" +) + +type testProjectContextProvider struct { + resolve func(extension.ProjectContextRequest) (extension.ProjectContextBundle, error) + read func(extension.ProjectEvidenceRequest) (extension.ProjectEvidence, error) +} + +type deadlineContextProvider struct{ sawDeadline *bool } + +func (p deadlineContextProvider) Resolve(ctx context.Context, req extension.ProjectContextRequest) (extension.ProjectContextBundle, error) { + _, *p.sawDeadline = ctx.Deadline() + return extension.ProjectContextBundle{Status: extension.ProjectContextReady, ProjectID: req.ProjectID}, nil +} +func (p deadlineContextProvider) ReadEvidence(ctx context.Context, req extension.ProjectEvidenceRequest) (extension.ProjectEvidence, error) { + _, *p.sawDeadline = ctx.Deadline() + return extension.ProjectEvidence{Reference: req.Reference, Text: "detail"}, nil +} + +func TestProjectContextProviderCallsHaveBoundedDeadline(t *testing.T) { + seen := false + slot := &projectContextSlot{} + if err := (pluginRegistry{pluginID: "rdm", caps: hostcaps{contexts: slot}}).RegisterProjectContextProvider(deadlineContextProvider{sawDeadline: &seen}); err != nil { + t.Fatal(err) + } + if _, err := slot.resolve(context.Background(), extension.ProjectContextRequest{Actor: "alice", ProjectID: "p1"}); err != nil || !seen { + t.Fatalf("Resolve missing bounded context: seen=%v err=%v", seen, err) + } + seen = false + if _, err := slot.readEvidence(context.Background(), extension.ProjectEvidenceRequest{Scope: extension.ProjectContextRequest{Actor: "alice", ProjectID: "p1", BudgetChars: 100}, Reference: extension.ProjectEvidenceRef{ID: "r1"}}); err != nil || !seen { + t.Fatalf("ReadEvidence missing bounded context: seen=%v err=%v", seen, err) + } +} + +func (p testProjectContextProvider) Resolve(_ context.Context, req extension.ProjectContextRequest) (extension.ProjectContextBundle, error) { + return p.resolve(req) +} + +func (p testProjectContextProvider) ReadEvidence(_ context.Context, req extension.ProjectEvidenceRequest) (extension.ProjectEvidence, error) { + if p.read != nil { + return p.read(req) + } + return extension.ProjectEvidence{}, nil +} + +func TestProjectContextRegistryOptionalAndSingleOwner(t *testing.T) { + slot := &projectContextSlot{} + reg := recordRegistry{Registry: pluginRegistry{pluginID: "rdm", caps: hostcaps{contexts: slot}}} + optional, ok := any(reg).(extension.ProjectContextRegistry) + if !ok { + t.Fatal("record registry hides optional project context registration") + } + provider := testProjectContextProvider{resolve: func(extension.ProjectContextRequest) (extension.ProjectContextBundle, error) { + return extension.ProjectContextBundle{Status: extension.ProjectContextReady}, nil + }} + if err := optional.RegisterProjectContextProvider(provider); err != nil { + t.Fatal(err) + } + if err := optional.RegisterProjectContextProvider(provider); err == nil { + t.Fatal("duplicate provider replaced the first provider") + } + if err := (compiledRegistry{}).RegisterProjectContextProvider(provider); err == nil { + t.Fatal("declarative provider accepted") + } +} + +func TestRequiredProjectContextFailsWhenProviderNotAssembled(t *testing.T) { + slot := &projectContextSlot{} + if err := requireProjectContextProvider(true, slot); err == nil { + t.Fatal("required project context silently degraded") + } + if err := requireProjectContextProvider(false, slot); err != nil { + t.Fatalf("optional legacy path blocked: %v", err) + } + provider := testProjectContextProvider{resolve: func(extension.ProjectContextRequest) (extension.ProjectContextBundle, error) { + return extension.ProjectContextBundle{}, nil + }} + if err := (pluginRegistry{pluginID: "rdm", caps: hostcaps{contexts: slot}}).RegisterProjectContextProvider(provider); err != nil { + t.Fatal(err) + } + if err := requireProjectContextProvider(true, slot); err != nil { + t.Fatalf("registered provider rejected: %v", err) + } +} + +func TestCompleteForWorkUsesStoredScopeAndActualInputManifest(t *testing.T) { + st, err := store.OpenSQLite(filepath.Join(t.TempDir(), "test.db")) + if err != nil { + t.Fatal(err) + } + defer st.Close() + p, err := st.CreateProject("alice", "Project") + if err != nil { + t.Fatal(err) + } + other, err := st.CreateProject("alice", "Other") + if err != nil { + t.Fatal(err) + } + conv, err := st.CreateConversation("alice", p.ID, "Work", "") + if err != nil { + t.Fatal(err) + } + var sent string + modelCalls := 0 + model := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { + modelCalls++ + var payload struct { + Messages []struct { + Content string `json:"content"` + } `json:"messages"` + } + if err := json.NewDecoder(r.Body).Decode(&payload); err != nil { + t.Error(err) + } + for _, m := range payload.Messages { + sent += m.Content + } + _, _ = w.Write([]byte(`{"choices":[{"message":{"content":"done"}}]}`)) + })) + defer model.Close() + set := settings.NewService(st) + set.SetSystemOverride(map[string]any{"models": map[string]any{"chat": map[string]any{"baseUrl": model.URL, "model": "test-model"}}}) + projects := &projectLifecycleSlot{} + if err := (pluginRegistry{pluginID: "rdm", caps: hostcaps{projects: projects}}).RegisterProjectLifecycle(completeLifecycle()); err != nil { + t.Fatal(err) + } + contexts := &projectContextSlot{} + called := 0 + oversized := false + revokeDuringResolve := false + revokeDocDuringResolve := false + authEpoch := "duty-1" + provider := testProjectContextProvider{resolve: func(req extension.ProjectContextRequest) (extension.ProjectContextBundle, error) { + called++ + if req.Actor != "alice" || req.ProjectID != core.ID(p.ID) || req.ConversationID != core.ID(conv.ID) || req.PluginID != "rdm" { + t.Errorf("untrusted scope: %+v", req) + } + item := extension.ProjectContextItem{SourceID: "decision-1", Revision: "r3", Hash: "source-hash", Text: "Authorized summary", Required: true} + if oversized { + item.Text = strings.Repeat("x", workContextBudgetChars+1) + } + if revokeDuringResolve { + projects.mu.Lock() + projects.provider.Work = func(context.Context, string, core.ID) (bool, error) { return false, nil } + projects.mu.Unlock() + } + epoch := authEpoch + if revokeDocDuringResolve { + authEpoch = "duty-2" + revokeDocDuringResolve = false + } + return extension.ProjectContextBundle{Status: extension.ProjectContextReady, ProjectID: core.ID(p.ID), Version: "v7", AuthorizationEpoch: epoch, Items: []extension.ProjectContextItem{item}}, nil + }} + if err := (pluginRegistry{pluginID: "rdm", caps: hostcaps{contexts: contexts}}).RegisterProjectContextProvider(provider); err != nil { + t.Fatal(err) + } + h := inprocHost{caps: hostcaps{st: st, set: set, projects: projects, contexts: contexts}, pluginID: "rdm", owner: "alice", actor: "alice", conversationID: conv.ID, hostProjectID: p.ID} + work := any(h).(extension.WorkCompletionHost) + result, err := work.CompleteForWork(context.Background(), extension.WorkCompletionRequest{Goal: "Draft report"}) + if err != nil { + t.Fatal(err) + } + if result.Text != "done" || !strings.Contains(sent, "Authorized summary") || !strings.Contains(sent, "Draft report") || result.Manifest.InputSHA256 == "" || len(result.Manifest.Included) != 1 { + t.Fatalf("input or manifest mismatch: result=%+v sent=%q", result, sent) + } + if want := fmt.Sprintf("%x", sha256.Sum256([]byte(sent))); result.Manifest.InputSHA256 != want { + t.Fatalf("manifest input hash %q differs from actual request content hash %q", result.Manifest.InputSHA256, want) + } + if got, want := result.Manifest.Included[0].InputSHA256, fmt.Sprintf("%x", sha256.Sum256([]byte("Authorized summary"))); got != want || result.Manifest.Included[0].SourceHash != "source-hash" { + t.Fatalf("manifest does not distinguish source hash and actual text hash: %+v", result.Manifest.Included[0]) + } + if called != 2 { + t.Fatalf("provider called %d times, want initial and pre-send reads", called) + } + stored, err := st.ListContextManifests("alice", string(conv.ID)) + if err != nil || len(stored) != 2 || stored[0].Delivery != "attempted" || stored[1].Delivery != "responded" || stored[0].AttemptID != stored[1].AttemptID || stored[1].InputSHA256 != result.Manifest.InputSHA256 { + t.Fatalf("work completion manifest not persisted: got=%+v err=%v", stored, err) + } + h.hostProjectID = other.ID + if _, err := h.CompleteForWork(context.Background(), extension.WorkCompletionRequest{Goal: "Draft report"}); err == nil || called != 2 { + t.Fatal("forged project scope reached provider") + } + h.hostProjectID = p.ID + h.conversationID = "" + if _, err := h.CompleteForWork(context.Background(), extension.WorkCompletionRequest{Goal: "Draft report"}); err == nil || called != 2 { + t.Fatal("scoped host without dispatch scope reached provider") + } + h.conversationID = conv.ID + projects.mu.Lock() + projects.provider.Work = func(context.Context, string, core.ID) (bool, error) { return false, nil } + projects.mu.Unlock() + if _, err := h.CompleteForWork(context.Background(), extension.WorkCompletionRequest{Goal: "Draft report"}); err == nil || called != 2 { + t.Fatal("revoked project work reached provider") + } + projects.mu.Lock() + projects.provider.Work = func(context.Context, string, core.ID) (bool, error) { return true, nil } + projects.mu.Unlock() + oversized = true + if _, err := h.CompleteForWork(context.Background(), extension.WorkCompletionRequest{Goal: "Draft report"}); err == nil || modelCalls != 1 { + t.Fatal("required context was dropped and model still called") + } + oversized = false + revokeDuringResolve = true + if _, err := h.CompleteForWork(context.Background(), extension.WorkCompletionRequest{Goal: "Draft report"}); err == nil || modelCalls != 1 { + t.Fatal("revocation during context resolution reached model") + } + projects.mu.Lock() + projects.provider.Work = func(context.Context, string, core.ID) (bool, error) { return true, nil } + projects.mu.Unlock() + revokeDuringResolve = false + revokeDocDuringResolve = true + if _, err := h.CompleteForWork(context.Background(), extension.WorkCompletionRequest{Goal: "Draft report"}); err == nil || modelCalls != 1 { + t.Fatal("document duty revoked while project membership remains reached model") + } + taskHost := any(h).(extension.WorkTaskHost) + taskID, err := taskHost.TaskCreateForWork("compose", "Draft report") + if err != nil { + t.Fatal(err) + } + scoped := inprocHost{caps: h.caps, pluginID: "rdm", owner: "alice"} + if _, err := scoped.TaskCreateForWork("compose", "Forged"); err == nil { + t.Fatal("scoped host created a work task without dispatch scope") + } + if _, err := scoped.CompleteForWork(context.Background(), extension.WorkCompletionRequest{Goal: "Resume report", TaskID: taskID}); err != nil || modelCalls != 2 { + t.Fatalf("persisted plugin task did not restore trusted work scope: err=%v calls=%d", err, modelCalls) + } + otherPlugin := inprocHost{caps: h.caps, pluginID: "other", owner: "alice"} + if _, err := otherPlugin.CompleteForWork(context.Background(), extension.WorkCompletionRequest{Goal: "Steal task", TaskID: taskID}); err == nil || modelCalls != 2 { + t.Fatal("other plugin reused task binding") + } + otherOwner := inprocHost{caps: h.caps, pluginID: "rdm", owner: "bob"} + if _, err := otherOwner.CompleteForWork(context.Background(), extension.WorkCompletionRequest{Goal: "Steal task", TaskID: taskID}); err == nil || modelCalls != 2 { + t.Fatal("other owner reused task binding") + } + legacyTaskID, err := h.TaskCreate("legacy", "Unbound", string(conv.ID)) + if err != nil { + t.Fatal(err) + } + if _, err := scoped.CompleteForWork(context.Background(), extension.WorkCompletionRequest{Goal: "Old task", TaskID: legacyTaskID}); err == nil || modelCalls != 2 { + t.Fatal("old unbound task was treated as trusted work scope") + } + if _, err := st.DB().Exec(`UPDATE conversations SET project_id=? WHERE id=?`, other.ID, conv.ID); err != nil { + t.Fatal(err) + } + if _, err := scoped.CompleteForWork(context.Background(), extension.WorkCompletionRequest{Goal: "Moved project", TaskID: taskID}); err == nil || modelCalls != 2 { + t.Fatal("task silently followed a conversation to another project") + } +} + +func TestWorkContextBudgetKeepsRequiredEvidenceFirst(t *testing.T) { + bundle := extension.ProjectContextBundle{Status: extension.ProjectContextReady, ProjectID: "project-1", Items: []extension.ProjectContextItem{ + {SourceID: "optional", Text: "12345678"}, + {SourceID: "required", Text: "must keep", Required: true}, + }} + prompt, manifest, err := assembleWorkCompletion("goal", bundle, 140) + if err != nil { + t.Fatal(err) + } + if !strings.Contains(prompt, "must keep") || strings.Contains(prompt, "12345678") { + t.Fatalf("required evidence lost to optional evidence: %q", prompt) + } + if len([]rune(prompt)) > 140 { + t.Fatalf("final prompt exceeded the budget: %d", len([]rune(prompt))) + } + if len(manifest.Included) != 1 || manifest.Included[0].SourceID != "required" || len(manifest.Dropped) != 1 || manifest.Dropped[0].SourceID != "optional" { + t.Fatalf("manifest does not match selected input: %+v", manifest) + } +} + +func TestCompleteForWorkReadsOnlyCurrentBundleEvidence(t *testing.T) { + st, err := store.OpenSQLite(filepath.Join(t.TempDir(), "evidence.db")) + if err != nil { + t.Fatal(err) + } + defer st.Close() + p, err := st.CreateProject("alice", "P") + if err != nil { + t.Fatal(err) + } + conv, err := st.CreateConversation("alice", p.ID, "C", "") + if err != nil { + t.Fatal(err) + } + var sent string + model := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { + var body struct { + Messages []struct { + Content string `json:"content"` + } `json:"messages"` + } + _ = json.NewDecoder(r.Body).Decode(&body) + for _, m := range body.Messages { + sent += m.Content + } + _, _ = w.Write([]byte(`{"choices":[{"message":{"content":"done"}}]}`)) + })) + defer model.Close() + set := settings.NewService(st) + set.SetSystemOverride(map[string]any{"models": map[string]any{"chat": map[string]any{"baseUrl": model.URL, "model": "test-model"}}}) + projects := &projectLifecycleSlot{} + if err := (pluginRegistry{pluginID: "rdm", caps: hostcaps{projects: projects}}).RegisterProjectLifecycle(completeLifecycle()); err != nil { + t.Fatal(err) + } + contexts := &projectContextSlot{} + ref := extension.ProjectEvidenceRef{ID: "ref-1", SourceID: "doc-1", Revision: "r2", Hash: "source-hash"} + readCalls := 0 + provider := testProjectContextProvider{ + resolve: func(req extension.ProjectContextRequest) (extension.ProjectContextBundle, error) { + return extension.ProjectContextBundle{Status: extension.ProjectContextReady, ProjectID: req.ProjectID, Evidence: []extension.ProjectEvidenceRef{ref}}, nil + }, + read: func(req extension.ProjectEvidenceRequest) (extension.ProjectEvidence, error) { + readCalls++ + if req.Reference != ref || req.Scope.ProjectID != core.ID(p.ID) { + t.Errorf("untrusted evidence scope: %+v", req) + } + return extension.ProjectEvidence{Reference: req.Reference, Text: "current restricted detail"}, nil + }, + } + if err := (pluginRegistry{pluginID: "rdm", caps: hostcaps{contexts: contexts}}).RegisterProjectContextProvider(provider); err != nil { + t.Fatal(err) + } + h := inprocHost{caps: hostcaps{st: st, set: set, projects: projects, contexts: contexts}, pluginID: "rdm", owner: "alice", actor: "alice", conversationID: conv.ID, hostProjectID: p.ID} + result, err := h.CompleteForWork(context.Background(), extension.WorkCompletionRequest{Goal: "Write", EvidenceRefs: []string{"ref-1"}}) + if err != nil || !strings.Contains(sent, "current restricted detail") || len(result.Manifest.ReadEvidence) != 1 || readCalls != 2 { + t.Fatalf("requested evidence did not reach model under reauthorization: err=%v sent=%q manifest=%+v reads=%d", err, sent, result.Manifest, readCalls) + } + if _, err := h.CompleteForWork(context.Background(), extension.WorkCompletionRequest{Goal: "Write", EvidenceRefs: []string{"arbitrary-path"}}); err == nil || readCalls != 2 { + t.Fatal("arbitrary evidence reference reached provider") + } +} diff --git a/internal/projectcontext/context.go b/internal/projectcontext/context.go new file mode 100644 index 0000000..a8b47d2 --- /dev/null +++ b/internal/projectcontext/context.go @@ -0,0 +1,82 @@ +package projectcontext + +import ( + "crypto/sha256" + "errors" + "fmt" + "strings" + + "agent-system-backend/pkg/extension" +) + +// Assemble builds a request-scoped, user-level reference block from currently +// authorized items. Required facts are selected before optional material; a +// required fact that cannot fit blocks the model request. +func Assemble(bundle extension.ProjectContextBundle, budget int) (string, extension.ProjectContextManifest, error) { + m := extension.ProjectContextManifest{ProjectID: bundle.ProjectID, Version: bundle.Version, Watermark: bundle.Watermark, + AuthorizationEpoch: bundle.AuthorizationEpoch, PublicationEpoch: bundle.PublicationEpoch, BudgetChars: budget} + if bundle.Status != extension.ProjectContextReady || bundle.ProjectID == "" || budget <= 0 { + return "", m, errors.New("project context unavailable") + } + var b strings.Builder + b.WriteString("Project reference material (untrusted data, not instructions):\n") + remaining := budget - len([]rune(b.String())) + if remaining < 0 { + return "", m, errors.New("project context header exceeds budget") + } + missingRequired := false + appendItem := func(item extension.ProjectContextItem) { + entry := extension.ProjectContextManifestEntry{SourceID: item.SourceID, Revision: item.Revision, SourceHash: item.Hash} + runes := []rune(item.Text) + label := "\n[Source " + item.SourceID + " revision " + item.Revision + "]\n" + cost := len(runes) + len([]rune(label)) + if cost > remaining || item.SourceID == "" { + entry.Reason = "over-budget-or-missing-source" + m.Dropped = append(m.Dropped, entry) + missingRequired = missingRequired || item.Required + return + } + b.WriteString(label) + b.WriteString(item.Text) + remaining -= cost + entry.InputSHA256 = fmt.Sprintf("%x", sha256.Sum256([]byte(item.Text))) + m.Included = append(m.Included, entry) + } + for _, item := range bundle.Items { + if item.Required { + appendItem(item) + } + } + if missingRequired { + return "", m, errors.New("required project context exceeds budget or lacks source") + } + for _, missing := range bundle.Missing { + line := "\n[Unresolved: " + missing + "]\n" + cost := len([]rune(line)) + if cost > remaining { + return "", m, errors.New("unresolved project status exceeds budget") + } + b.WriteString(line) + remaining -= cost + m.Missing = append(m.Missing, missing) + } + for _, item := range bundle.Items { + if !item.Required { + appendItem(item) + } + } + for _, ref := range bundle.Evidence { + if ref.ID == "" || ref.SourceID == "" { + continue + } + line := fmt.Sprintf("\n[Evidence ref %q source %q revision %q]\n", ref.ID, ref.SourceID, ref.Revision) + cost := len([]rune(line)) + if cost > remaining { + continue + } + b.WriteString(line) + remaining -= cost + m.OfferedReferences = append(m.OfferedReferences, ref) + } + return b.String(), m, nil +} diff --git a/internal/projectcontext/context_test.go b/internal/projectcontext/context_test.go new file mode 100644 index 0000000..bf26a3a --- /dev/null +++ b/internal/projectcontext/context_test.go @@ -0,0 +1,43 @@ +package projectcontext + +import ( + "strings" + "testing" + + "agent-system-backend/pkg/extension" +) + +func TestAssembleOffersOnlyBudgetedEvidenceReferences(t *testing.T) { + bundle := extension.ProjectContextBundle{Status: extension.ProjectContextReady, ProjectID: "p1", Evidence: []extension.ProjectEvidenceRef{{ID: "ref-1", SourceID: "doc-1", Revision: "r2"}, {ID: strings.Repeat("x", 1000), SourceID: "doc-2"}}} + text, manifest, err := Assemble(bundle, 180) + if err != nil { + t.Fatal(err) + } + if !strings.Contains(text, "ref-1") || strings.Contains(text, strings.Repeat("x", 1000)) || len(manifest.OfferedReferences) != 1 || manifest.OfferedReferences[0].ID != "ref-1" { + t.Fatalf("reference offer does not match model input: text=%q manifest=%+v", text, manifest) + } +} + +func TestValidateCurrentRejectsWithdrawnOfferedReference(t *testing.T) { + ref := extension.ProjectEvidenceRef{ID: "ref-1", SourceID: "doc-1", Revision: "r2"} + old := extension.ProjectContextBundle{Status: extension.ProjectContextReady, ProjectID: "p1", Evidence: []extension.ProjectEvidenceRef{ref}} + _, manifest, err := Assemble(old, 180) + if err != nil { + t.Fatal(err) + } + current := extension.ProjectContextBundle{Status: extension.ProjectContextReady, ProjectID: "p1"} + if err := ValidateCurrent(manifest, current); err == nil { + t.Fatal("reference withdrawn before model send was still offered") + } +} + +func TestAssembleIncludesUnresolvedMissingStatus(t *testing.T) { + bundle := extension.ProjectContextBundle{Status: extension.ProjectContextReady, ProjectID: "p1", Missing: []string{"unresolved conflict"}} + text, manifest, err := Assemble(bundle, 180) + if err != nil { + t.Fatal(err) + } + if !strings.Contains(text, "unresolved conflict") || len(manifest.Missing) != 1 { + t.Fatalf("missing status hidden from model or receipt: text=%q manifest=%+v", text, manifest) + } +} diff --git a/internal/projectcontext/receipt.go b/internal/projectcontext/receipt.go new file mode 100644 index 0000000..5cd9b2d --- /dev/null +++ b/internal/projectcontext/receipt.go @@ -0,0 +1,57 @@ +package projectcontext + +import ( + "crypto/rand" + "crypto/sha256" + "errors" + "fmt" + + "agent-system-backend/pkg/extension" +) + +func NewAttemptID() (string, error) { + var id [16]byte + if _, err := rand.Read(id[:]); err != nil { + return "", err + } + return fmt.Sprintf("%x", id), nil +} + +// ValidateCurrent rejects a stale candidate when a later provider read has +// changed the permission/publication epoch or any source actually selected for +// model input. Candidate-only references do not count as model evidence. +func ValidateCurrent(m extension.ProjectContextManifest, b extension.ProjectContextBundle) error { + if b.Status != extension.ProjectContextReady || b.ProjectID != m.ProjectID || b.Version != m.Version || + b.Watermark != m.Watermark || b.AuthorizationEpoch != m.AuthorizationEpoch || b.PublicationEpoch != m.PublicationEpoch { + return errors.New("project context changed before model send") + } + for _, used := range m.Included { + found := false + for _, item := range b.Items { + if item.SourceID != used.SourceID || item.Revision != used.Revision || item.Hash != used.SourceHash { + continue + } + actual := fmt.Sprintf("%x", sha256.Sum256([]byte(item.Text))) + if actual == used.InputSHA256 { + found = true + break + } + } + if !found { + return fmt.Errorf("project context source %q changed before model send", used.SourceID) + } + } + for _, offered := range m.OfferedReferences { + found := false + for _, current := range b.Evidence { + if current == offered { + found = true + break + } + } + if !found { + return fmt.Errorf("project evidence reference %q withdrawn before model send", offered.ID) + } + } + return nil +} diff --git a/internal/runmgr/project_context.go b/internal/runmgr/project_context.go new file mode 100644 index 0000000..5236b45 --- /dev/null +++ b/internal/runmgr/project_context.go @@ -0,0 +1,226 @@ +package runmgr + +import ( + "context" + "crypto/sha256" + "errors" + "fmt" + "strings" + + agentllm "agent-native/runtime/llm" + + "agent-system-backend/internal/projectcontext" + "agent-system-backend/pkg/extension" + core "agent-system-core" +) + +// SetProjectContextResolver activates project-context reads for persisted runs. +// Nil preserves the existing non-project and pre-provider behavior. +func (m *Manager) SetProjectContextResolver(fn func(context.Context, extension.ProjectContextRequest) (extension.ProjectContextBundle, error)) { + m.projectContextResolver = fn +} + +func (m *Manager) SetProjectEvidenceReader(fn func(context.Context, extension.ProjectEvidenceRequest) (extension.ProjectEvidence, error)) { + m.projectEvidenceReader = fn +} + +func (c *runCtx) ProjectContextEnabled() bool { + return c.run.ProjectID != "" && c.mgr.projectContextResolver != nil +} + +func (c *runCtx) contextRequest() extension.ProjectContextRequest { + c.projectContextMu.Lock() + defer c.projectContextMu.Unlock() + return c.projectContextReq +} + +func (c *runCtx) setContextRequest(req extension.ProjectContextRequest) { + c.projectContextMu.Lock() + c.projectContextReq = req + c.projectContextMu.Unlock() +} + +type projectEvidenceRecord struct { + ref extension.ProjectEvidenceRef + text string +} + +// ContextEvidenceInRequest reports only details still present in the actual +// model request after transcript compaction and window cleanup. +func (c *runCtx) ContextEvidenceInRequest(messages []agentllm.Message) []extension.ProjectContextManifestEntry { + c.projectEvidenceMu.Lock() + defer c.projectEvidenceMu.Unlock() + var out []extension.ProjectContextManifestEntry + for _, used := range c.projectEvidenceUsed { + for _, msg := range messages { + if !strings.Contains(msg.Content, used.text) { + continue + } + out = append(out, extension.ProjectContextManifestEntry{ + ReferenceID: used.ref.ID, + SourceID: used.ref.SourceID, Revision: used.ref.Revision, SourceHash: used.ref.Hash, + InputSHA256: fmt.Sprintf("%x", sha256.Sum256([]byte(used.text))), + }) + break + } + } + return out +} + +// ProjectEvidence accepts only a stable reference listed by a fresh Resolve. +// The provider must reauthorize the selected resource when reading its body. +func (c *runCtx) ProjectEvidence(ctx context.Context, id string) (extension.ProjectEvidence, error) { + if id == "" || c.mgr.projectEvidenceReader == nil || !c.ProjectContextEnabled() { + return extension.ProjectEvidence{}, errors.New("project evidence unavailable") + } + prior := c.contextRequest() + budget := prior.BudgetChars + if budget <= 0 { + budget = 12000 + } + bundle, active, err := c.ProjectContext(ctx, prior.Goal, budget) + if err != nil || !active { + return extension.ProjectEvidence{}, errors.New("project evidence scope unavailable") + } + for _, ref := range bundle.Evidence { + if ref.ID != id { + continue + } + scope := c.contextRequest() + scope.BudgetChars = 8000 + evidence, err := c.mgr.projectEvidenceReader(ctx, extension.ProjectEvidenceRequest{Scope: scope, Reference: ref}) + if err != nil { + return extension.ProjectEvidence{}, err + } + if evidence.Reference != ref || strings.TrimSpace(evidence.Text) == "" || len([]rune(evidence.Text)) > 8000 { + return extension.ProjectEvidence{}, errors.New("project evidence response does not match authorized reference or budget") + } + c.projectEvidenceMu.Lock() + c.projectEvidenceUsed = append(c.projectEvidenceUsed, projectEvidenceRecord{ref: ref, text: evidence.Text}) + c.projectEvidenceMu.Unlock() + return evidence, nil + } + return extension.ProjectEvidence{}, errors.New("project evidence reference not in current bundle") +} + +// ProjectContext reloads identity and project from trusted run and conversation +// rows on every model request, including a resumed or background run. +func (c *runCtx) ProjectContext(ctx context.Context, goal string, budget int) (extension.ProjectContextBundle, bool, error) { + if c.run.ProjectID == "" || c.mgr.projectContextResolver == nil { + return extension.ProjectContextBundle{}, false, nil + } + if c.mgr.projectWorkAuthorization == nil { + return extension.ProjectContextBundle{}, true, errors.New("project work authorization missing") + } + run, err := c.mgr.st.GetRunByID(string(c.run.ID)) + if err != nil { + return extension.ProjectContextBundle{}, true, err + } + if run.Owner == "" || run.Owner != c.run.Owner || run.ProjectID != c.run.ProjectID || run.ConversationID != c.run.ConversationID { + return extension.ProjectContextBundle{}, true, errors.New("persisted run scope mismatch") + } + conv, err := c.mgr.st.GetConversation(string(run.Owner), string(run.ConversationID)) + if err != nil { + return extension.ProjectContextBundle{}, true, err + } + if conv.ProjectID != run.ProjectID { + return extension.ProjectContextBundle{}, true, errors.New("persisted conversation scope mismatch") + } + if err := c.mgr.authorizeProjectWork(ctx, string(run.Owner), run.ProjectID); err != nil { + return extension.ProjectContextBundle{}, true, err + } + req := extension.ProjectContextRequest{ + Actor: string(run.Owner), ProjectID: run.ProjectID, ConversationID: run.ConversationID, + RunID: run.ID, Goal: goal, BudgetChars: budget, + } + bundle, err := c.mgr.projectContextResolver(ctx, req) + if err != nil { + return extension.ProjectContextBundle{}, true, err + } + if bundle.ProjectID != run.ProjectID || bundle.Status != extension.ProjectContextReady { + return extension.ProjectContextBundle{}, true, errors.New("project context unavailable for trusted run") + } + c.setContextRequest(req) + return bundle, true, nil +} + +// SaveContextManifest persists a receipt for the exact request prepared by the +// runtime. It does not store model-visible text or candidate-only references. +func (c *runCtx) SaveContextManifest(ctx context.Context, m extension.ProjectContextManifest) error { + if err := ctx.Err(); err != nil { + return err + } + run, err := c.mgr.st.GetRunByID(string(c.run.ID)) + if err != nil { + return err + } + if run.Owner != c.run.Owner || run.ProjectID != c.run.ProjectID || run.ConversationID != c.run.ConversationID || m.ProjectID != run.ProjectID { + return errors.New("context manifest run scope mismatch") + } + // A response/unknown receipt records an already attempted transport. A + // revocation after send must not erase that audit fact. + if m.Delivery != "responded" && m.Delivery != "unknown" { + if err := c.mgr.authorizeProjectWork(ctx, string(run.Owner), core.ID(run.ProjectID)); err != nil { + return err + } + } + if c.mgr.projectContextResolver != nil && m.Delivery != "responded" && m.Delivery != "unknown" { + resolvedReq := c.contextRequest() + if resolvedReq.RunID != run.ID || resolvedReq.ProjectID != run.ProjectID { + return errors.New("context manifest missing resolved run scope") + } + current, err := c.mgr.projectContextResolver(ctx, resolvedReq) + if err != nil { + return err + } + if err := projectcontext.ValidateCurrent(m, current); err != nil { + return err + } + c.projectEvidenceMu.Lock() + pastReads := append([]projectEvidenceRecord(nil), c.projectEvidenceUsed...) + c.projectEvidenceMu.Unlock() + for _, used := range pastReads { + stillListed := false + for _, ref := range current.Evidence { + if ref == used.ref { + stillListed = true + break + } + } + if !stillListed || c.mgr.projectEvidenceReader == nil { + return errors.New("previous project evidence no longer authorized") + } + scope := resolvedReq + scope.BudgetChars = 8000 + now, err := c.mgr.projectEvidenceReader(ctx, extension.ProjectEvidenceRequest{Scope: scope, Reference: used.ref}) + if err != nil || now.Reference != used.ref || now.Text != used.text { + return errors.New("previous project evidence changed before model send") + } + } + for _, used := range m.ReadEvidence { + if c.mgr.projectEvidenceReader == nil { + return errors.New("project evidence reader missing at model send") + } + matched := false + for _, ref := range current.Evidence { + if ref.ID != used.ReferenceID || ref.SourceID != used.SourceID || ref.Revision != used.Revision || ref.Hash != used.SourceHash { + continue + } + scope := resolvedReq + scope.BudgetChars = 8000 + evidence, err := c.mgr.projectEvidenceReader(ctx, extension.ProjectEvidenceRequest{Scope: scope, Reference: ref}) + if err != nil { + return err + } + if evidence.Reference == ref && fmt.Sprintf("%x", sha256.Sum256([]byte(evidence.Text))) == used.InputSHA256 { + matched = true + break + } + } + if !matched { + return errors.New("project evidence changed before model send") + } + } + } + return c.mgr.st.AppendContextManifest(string(run.Owner), string(run.ID), m) +} diff --git a/internal/runmgr/project_context_test.go b/internal/runmgr/project_context_test.go new file mode 100644 index 0000000..94f6a4e --- /dev/null +++ b/internal/runmgr/project_context_test.go @@ -0,0 +1,194 @@ +package runmgr + +import ( + "context" + "sync" + "testing" + + agentllm "agent-native/runtime/llm" + "agent-system-backend/internal/projectcontext" + "agent-system-backend/pkg/extension" + core "agent-system-core" +) + +func TestProjectContextUsesPersistedRunAndRefreshesAuthorization(t *testing.T) { + st := openRecoveryStore(t) + m := newRecoveryManager(t, st) + conv := recoveryConversation(t, st) + run := recoveryRun(t, st, conv, core.RunPending) + allowed := true + m.SetProjectWorkAuthorization(func(context.Context, string, core.ID) (bool, error) { return allowed, nil }) + called := 0 + m.SetProjectContextResolver(func(_ context.Context, req extension.ProjectContextRequest) (extension.ProjectContextBundle, error) { + called++ + if req.Actor != string(run.Owner) || req.ProjectID != run.ProjectID || req.ConversationID != run.ConversationID || req.RunID != run.ID { + t.Errorf("context scope did not come from persisted run: %+v", req) + } + return extension.ProjectContextBundle{Status: extension.ProjectContextReady, ProjectID: req.ProjectID}, nil + }) + rc := &runCtx{mgr: m, run: run, ctx: context.Background()} + if _, active, err := rc.ProjectContext(context.Background(), "work goal", 900); err != nil || !active || called != 1 { + t.Fatalf("valid persisted scope rejected: active=%v called=%d err=%v", active, called, err) + } + allowed = false + if _, _, err := rc.ProjectContext(context.Background(), "work goal", 900); err == nil || called != 1 { + t.Fatal("revoked project still reached context provider") + } + allowed = true + rc.run.ProjectID = "forged" + if _, _, err := rc.ProjectContext(context.Background(), "work goal", 900); err == nil || called != 1 { + t.Fatal("in-memory project override reached context provider") + } +} + +func TestProjectContextResumeReloadsCurrentVersionAndAuthorization(t *testing.T) { + st := openRecoveryStore(t) + m := newRecoveryManager(t, st) + conv := recoveryConversation(t, st) + run := recoveryRun(t, st, conv, core.RunInterrupted) + allowed, version := true, "v1" + m.SetProjectWorkAuthorization(func(context.Context, string, core.ID) (bool, error) { return allowed, nil }) + m.SetProjectContextResolver(func(_ context.Context, req extension.ProjectContextRequest) (extension.ProjectContextBundle, error) { + return extension.ProjectContextBundle{Status: extension.ProjectContextReady, ProjectID: req.ProjectID, Version: version}, nil + }) + first := &runCtx{mgr: m, run: run, ctx: context.Background()} + if b, _, err := first.ProjectContext(context.Background(), "work", 900); err != nil || b.Version != "v1" { + t.Fatalf("initial context: %+v err=%v", b, err) + } + reloaded, err := st.GetRunByID(string(run.ID)) + if err != nil { + t.Fatal(err) + } + resumed := &runCtx{mgr: m, run: reloaded, ctx: context.Background()} + version = "v2" + if b, _, err := resumed.ProjectContext(context.Background(), "work", 900); err != nil || b.Version != "v2" { + t.Fatalf("resumed context reused stale version: %+v err=%v", b, err) + } + allowed = false + if _, _, err := resumed.ProjectContext(context.Background(), "work", 900); err == nil { + t.Fatal("resumed context ignored current revocation") + } +} + +func TestContextManifestPersistsByOwnerAndRun(t *testing.T) { + st := openRecoveryStore(t) + m := newRecoveryManager(t, st) + conv := recoveryConversation(t, st) + run := recoveryRun(t, st, conv, core.RunPending) + rc := &runCtx{mgr: m, run: run, ctx: context.Background()} + manifest := extension.ProjectContextManifest{ProjectID: run.ProjectID, Version: "v3", Model: "model-1", InputSHA256: "abc", Included: []extension.ProjectContextManifestEntry{{SourceID: "s1", Revision: "r2", InputSHA256: "def"}}} + if err := rc.SaveContextManifest(context.Background(), manifest); err != nil { + t.Fatal(err) + } + got, err := st.ListContextManifests(string(run.Owner), string(run.ID)) + if err != nil || len(got) != 1 || got[0].Version != "v3" || got[0].Included[0].SourceID != "s1" { + t.Fatalf("manifest missing from persisted run audit: got=%+v err=%v", got, err) + } + other, err := st.ListContextManifests("other", string(run.ID)) + if err != nil || len(other) != 0 { + t.Fatalf("cross-owner manifest visible: got=%+v err=%v", other, err) + } +} + +func TestContextManifestRejectsDocumentDutyRevocationBeforeSend(t *testing.T) { + st := openRecoveryStore(t) + m := newRecoveryManager(t, st) + conv := recoveryConversation(t, st) + run := recoveryRun(t, st, conv, core.RunPending) + m.SetProjectWorkAuthorization(func(context.Context, string, core.ID) (bool, error) { return true, nil }) + epoch := "duty-1" + m.SetProjectContextResolver(func(_ context.Context, req extension.ProjectContextRequest) (extension.ProjectContextBundle, error) { + return extension.ProjectContextBundle{Status: extension.ProjectContextReady, ProjectID: req.ProjectID, Version: "v1", AuthorizationEpoch: epoch, + Items: []extension.ProjectContextItem{{SourceID: "restricted-doc", Text: "private text", Required: true}}}, nil + }) + rc := &runCtx{mgr: m, run: run, ctx: context.Background()} + bundle, active, err := rc.ProjectContext(context.Background(), "work", 900) + if err != nil || !active { + t.Fatalf("initial context: active=%v err=%v", active, err) + } + _, manifest, err := projectcontext.Assemble(bundle, 900) + if err != nil { + t.Fatal(err) + } + manifest.InputSHA256 = "request-hash" + epoch = "duty-2" // project work remains allowed; document duty changed + if err := rc.SaveContextManifest(context.Background(), manifest); err == nil { + t.Fatal("stale document duty accepted at model send") + } + stored, err := st.ListContextManifests(string(run.Owner), string(run.ID)) + if err != nil || len(stored) != 0 { + t.Fatalf("revoked context wrote a send receipt: %+v err=%v", stored, err) + } +} + +func TestProjectEvidenceOnlyReadsCurrentBundleReference(t *testing.T) { + st := openRecoveryStore(t) + m := newRecoveryManager(t, st) + conv := recoveryConversation(t, st) + run := recoveryRun(t, st, conv, core.RunPending) + m.SetProjectWorkAuthorization(func(context.Context, string, core.ID) (bool, error) { return true, nil }) + listed := true + m.SetProjectContextResolver(func(_ context.Context, req extension.ProjectContextRequest) (extension.ProjectContextBundle, error) { + b := extension.ProjectContextBundle{Status: extension.ProjectContextReady, ProjectID: req.ProjectID} + if listed { + b.Evidence = []extension.ProjectEvidenceRef{{ID: "ref-1", SourceID: "doc-1", Revision: "r3", Hash: "source-hash"}} + } + return b, nil + }) + read := 0 + m.SetProjectEvidenceReader(func(_ context.Context, req extension.ProjectEvidenceRequest) (extension.ProjectEvidence, error) { + read++ + if req.Scope.RunID != run.ID || req.Reference.ID != "ref-1" { + t.Errorf("untrusted evidence request: %+v", req) + } + return extension.ProjectEvidence{Reference: req.Reference, Text: "authorized detail"}, nil + }) + rc := &runCtx{mgr: m, run: run, ctx: context.Background()} + if _, err := rc.ProjectEvidence(context.Background(), "forged-ref"); err == nil || read != 0 { + t.Fatal("arbitrary reference reached provider") + } + evidence, err := rc.ProjectEvidence(context.Background(), "ref-1") + if err != nil || evidence.Text != "authorized detail" || read != 1 { + t.Fatalf("current reference rejected: evidence=%+v read=%d err=%v", evidence, read, err) + } + if got := rc.ContextEvidenceInRequest([]agentllm.Message{{Role: agentllm.RoleTool, Content: "authorized detail"}}); len(got) != 1 || got[0].SourceID != "doc-1" { + t.Fatalf("actual evidence read missing from request manifest: %+v", got) + } + if got := rc.ContextEvidenceInRequest([]agentllm.Message{{Role: agentllm.RoleTool, Content: "cleared old tool result"}}); len(got) != 0 { + t.Fatalf("cleared evidence still counted as model input: %+v", got) + } + listed = false + if _, err := rc.ProjectEvidence(context.Background(), "ref-1"); err == nil || read != 1 { + t.Fatal("revoked reference reached provider") + } + if err := rc.SaveContextManifest(context.Background(), extension.ProjectContextManifest{ProjectID: run.ProjectID, InputSHA256: "new-request-hash"}); err == nil { + t.Fatal("new model request accepted after an earlier evidence read was revoked") + } +} + +func TestConcurrentProjectEvidenceReadsKeepTrustedScope(t *testing.T) { + st := openRecoveryStore(t) + m := newRecoveryManager(t, st) + conv := recoveryConversation(t, st) + run := recoveryRun(t, st, conv, core.RunPending) + m.SetProjectWorkAuthorization(func(context.Context, string, core.ID) (bool, error) { return true, nil }) + ref := extension.ProjectEvidenceRef{ID: "r1", SourceID: "doc", Revision: "v1"} + m.SetProjectContextResolver(func(_ context.Context, req extension.ProjectContextRequest) (extension.ProjectContextBundle, error) { + return extension.ProjectContextBundle{Status: extension.ProjectContextReady, ProjectID: req.ProjectID, Evidence: []extension.ProjectEvidenceRef{ref}}, nil + }) + m.SetProjectEvidenceReader(func(_ context.Context, req extension.ProjectEvidenceRequest) (extension.ProjectEvidence, error) { + return extension.ProjectEvidence{Reference: req.Reference, Text: "body"}, nil + }) + rc := &runCtx{mgr: m, run: run, ctx: context.Background()} + var wg sync.WaitGroup + for i := 0; i < 8; i++ { + wg.Add(1) + go func() { + defer wg.Done() + if _, err := rc.ProjectEvidence(context.Background(), "r1"); err != nil { + t.Error(err) + } + }() + } + wg.Wait() +} diff --git a/internal/runmgr/runmgr.go b/internal/runmgr/runmgr.go index b3f3d99..1ed8485 100644 --- a/internal/runmgr/runmgr.go +++ b/internal/runmgr/runmgr.go @@ -33,6 +33,7 @@ import ( "agent-system-backend/internal/store" "agent-system-backend/internal/tools" "agent-system-backend/internal/workflow" + "agent-system-backend/pkg/extension" core "agent-system-core" ) @@ -61,6 +62,8 @@ type Manager struct { knowledgeResourceAllow func(owner string, doc core.KnowledgeDoc) bool knowledgeProjectScope func(context.Context, string, core.ID) (core.ID, error) projectWorkAuthorization func(context.Context, string, core.ID) (bool, error) + projectContextResolver func(context.Context, extension.ProjectContextRequest) (extension.ProjectContextBundle, error) + projectEvidenceReader func(context.Context, extension.ProjectEvidenceRequest) (extension.ProjectEvidence, error) // commands EXT-14：命令即工具的投影与分发源（nil = 未接线，命令不进工具清单）。 commands CommandSource indexer core.DocumentIndexer // 可选索引入口（nil = store 整文档单块） @@ -313,22 +316,26 @@ type sharedRetriever interface { // ---- runCtx 实现（runtime.RunCtx）---- type runCtx struct { - mgr *Manager - run core.Run - prof core.AgentProfile - eff core.EffectiveSettings - ctx context.Context - h *runHandle - userMessage core.Message - attachments []core.ParsedDocument - inputPaths []string - subTask string - subHint string - subAgent string - subModel string // 系统派发覆盖（"chat" = 子代理用对话同档；空 = 按 spec） - launch *workflow.Launch - files *filestate.Tracker - permissionMode string + mgr *Manager + run core.Run + projectContextReq extension.ProjectContextRequest + projectContextMu sync.Mutex + projectEvidenceMu sync.Mutex + projectEvidenceUsed []projectEvidenceRecord + prof core.AgentProfile + eff core.EffectiveSettings + ctx context.Context + h *runHandle + userMessage core.Message + attachments []core.ParsedDocument + inputPaths []string + subTask string + subHint string + subAgent string + subModel string // 系统派发覆盖（"chat" = 子代理用对话同档；空 = 按 spec） + launch *workflow.Launch + files *filestate.Tracker + permissionMode string // 材料整理（附件即保证）：预启动说明注入第 0 回合；ensureMaterial 兜底幂等。 materialNote string materialEnsured bool diff --git a/internal/runtime/llm.go b/internal/runtime/llm.go index d06dae1..8f7e654 100644 --- a/internal/runtime/llm.go +++ b/internal/runtime/llm.go @@ -1,6 +1,7 @@ package runtime import ( + "context" "encoding/json" "fmt" "math" @@ -15,8 +16,10 @@ import ( "agent-native/runtime/policy" agenttools "agent-native/runtime/tools" "agent-system-backend/internal/ctxasm" + "agent-system-backend/internal/projectcontext" "agent-system-backend/internal/prompts" "agent-system-backend/internal/quality" + "agent-system-backend/pkg/extension" core "agent-system-core" ) @@ -68,7 +71,8 @@ const ( toolCardAppend = "card_append" toolCardCommit = "card_commit" // confirm_choice 发起待确认选择卡（材料整理完成后选交付物；I2）。 - toolConfirmChoice = "confirm_choice" + toolConfirmChoice = "confirm_choice" + toolReadProjectEvidence = "read_project_evidence" ) // resolveSystem 经提示词库组装 system 段（基座+环境+命中技能），并产出可观测条目 @@ -260,6 +264,12 @@ func (l *LLMRunner) Execute(rc RunCtx) error { // 组装初始上下文。 hist := rc.History() currentUser, _ := lastAddressed(hist) + if projectContextEnabled(rc) { + // Historical assistant/tool text has no durable resource provenance. A + // later duty revocation cannot safely reauthorize it, so project work + // starts from the current user turn and a fresh provider bundle. + hist = []core.Message{currentUser} + } var sys []agentllm.Message var promptObs []string var taskBlocks []core.PromptBlock @@ -346,6 +356,14 @@ func (l *LLMRunner) Execute(rc RunCtx) error { Parameters: json.RawMessage(`{"type":"object","properties":{}}`), }) } + if reader, ok := rc.(interface { + ProjectContextEnabled() bool + ProjectEvidence(context.Context, string) (extension.ProjectEvidence, error) + }); ok && reader.ProjectContextEnabled() { + decls = append(decls, agentllm.ToolDecl{Name: toolReadProjectEvidence, + Description: "Read one currently authorized project evidence reference offered in this request. Access is checked again at read time.", + Parameters: json.RawMessage(`{"type":"object","properties":{"reference":{"type":"string"}},"required":["reference"]}`)}) + } for _, t := range toolList(rc) { if prof.Tools.ToolAllowed(t.Name) { td := t @@ -367,9 +385,27 @@ func (l *LLMRunner) Execute(rc RunCtx) error { EnvUpdate: envUpdateLine(rc, route.Model), TaskBlocks: taskBlocks, } + if source, ok := rc.(interface { + ProjectContext(context.Context, string, int) (extension.ProjectContextBundle, bool, error) + }); ok { + refresh.ProjectContext = func() (string, *extension.ProjectContextManifest, error) { + const budget = 12000 + bundle, active, err := source.ProjectContext(rc.Context(), currentUserText(rc), budget) + if err != nil || !active { + return "", nil, err + } + body, m, err := projectcontext.Assemble(bundle, budget) + return body, &m, err + } + } return l.runDirect(rc, stream, route.Model, msgs, decls, streamOpts, cardflow, eff, maxTurns, maxTools, refresh) } +func projectContextEnabled(rc RunCtx) bool { + source, ok := rc.(interface{ ProjectContextEnabled() bool }) + return ok && source.ProjectContextEnabled() +} + func permissionModeOf(rc RunCtx) string { if m, ok := rc.(interface{ PermissionMode() string }); ok { return m.PermissionMode() diff --git a/internal/runtime/llm_direct.go b/internal/runtime/llm_direct.go index aa40273..e0307be 100644 --- a/internal/runtime/llm_direct.go +++ b/internal/runtime/llm_direct.go @@ -2,6 +2,7 @@ package runtime import ( "context" + "crypto/sha256" "encoding/json" "fmt" "log" @@ -19,8 +20,10 @@ import ( agentsession "agent-native/runtime/session" agenttools "agent-native/runtime/tools" "agent-system-backend/internal/ctxasm" + "agent-system-backend/internal/projectcontext" "agent-system-backend/internal/squadadapter" "agent-system-backend/internal/wfcompile" + "agent-system-backend/pkg/extension" core "agent-system-core" ) @@ -219,7 +222,51 @@ func (l *LLMRunner) runDirect(rc RunCtx, stream agentllm.StreamFunc, model strin if len(msgs) > 0 { user = msgs[len(msgs)-1] } + var projectErr error + var projectManifest *extension.ProjectContextManifest wrapped := func(ctx context.Context, model string, messages []agentllm.Message, _ []agentllm.ToolDecl, opts agentllm.StreamOptions) <-chan agentllm.Event { + fail := func(err error) <-chan agentllm.Event { + out := make(chan agentllm.Event, 1) + out <- agentllm.Event{Kind: agentllm.KindError, Err: err} + close(out) + return out + } + if projectErr != nil { + return fail(projectErr) + } + var manifest *extension.ProjectContextManifest + var saveManifest func(context.Context, extension.ProjectContextManifest) error + if projectManifest != nil { + copy := *projectManifest + manifest = © + manifest.Model = model + if err := checkProjectInputBudget(rc, messages, decls); err != nil { + return fail(err) + } + wire, err := json.Marshal(messages) + if err != nil { + return fail(err) + } + manifest.InputSHA256 = fmt.Sprintf("%x", sha256.Sum256(wire)) + if ledger, ok := rc.(interface { + ContextEvidenceInRequest([]agentllm.Message) []extension.ProjectContextManifestEntry + }); ok { + manifest.ReadEvidence = ledger.ContextEvidenceInRequest(messages) + } + attemptID, err := projectcontext.NewAttemptID() + if err != nil { + return fail(err) + } + manifest.AttemptID, manifest.Delivery = attemptID, "attempted" + if sink, ok := rc.(interface { + SaveContextManifest(context.Context, extension.ProjectContextManifest) error + }); ok { + saveManifest = sink.SaveContextManifest + if err := saveManifest(ctx, *manifest); err != nil { + return fail(err) + } + } + } if streamOpts.MaxTokens > 0 { opts.MaxTokens = streamOpts.MaxTokens } @@ -227,9 +274,24 @@ func (l *LLMRunner) runDirect(rc RunCtx, stream agentllm.StreamFunc, model strin opts.MessageShape = streamOpts.MessageShape } in := stream(ctx, model, messages, decls, opts) - out := make(chan agentllm.Event) + out := make(chan agentllm.Event, 1) go func() { - defer close(out) + terminalRecorded := false + record := func(status string) error { + if manifest == nil || saveManifest == nil { + return nil + } + manifest.Delivery = status + receiptCtx, cancel := context.WithTimeout(context.Background(), 3*time.Second) + defer cancel() + return saveManifest(receiptCtx, *manifest) + } + defer func() { + if !terminalRecorded { + _ = record("unknown") + } + close(out) + }() for ev := range in { if ev.Kind == agentllm.KindToolCallDelta { st.noteToolDelta(ev) @@ -242,11 +304,29 @@ func (l *LLMRunner) runDirect(rc RunCtx, stream agentllm.StreamFunc, model strin ev.Message.StopReason = agentllm.StopToolCalls } } + if ev.Kind == agentllm.KindMessageEnd || ev.Kind == agentllm.KindError { + status := "unknown" + if ev.Kind == agentllm.KindMessageEnd { + status = "responded" + } + if err := record(status); err != nil { + terminalRecorded = true + select { + case out <- agentllm.Event{Kind: agentllm.KindError, Err: err}: + case <-ctx.Done(): + } + return + } + terminalRecorded = true + } select { case out <- ev: case <-ctx.Done(): return } + if terminalRecorded { + return + } } }() return out @@ -269,7 +349,7 @@ func (l *LLMRunner) runDirect(rc RunCtx, stream agentllm.StreamFunc, model strin // 打开失败降级为无 Session（旧行为：ctxasm 整段组装，不阻断对话）。 var sessStore *agentsession.Store seedRun := true - if sandbox != "" { + if sandbox != "" && !projectContextEnabled(rc) { transcriptPath := filepath.Join(sandbox, ".agentx", "transcript.jsonl") rev := contextRevision(rc.History()) if opened, oerr := agentsession.Open(transcriptPath); oerr == nil { @@ -343,6 +423,14 @@ func (l *LLMRunner) runDirect(rc RunCtx, stream agentllm.StreamFunc, model strin Reminders: func(turn int) []string { var out []string out = append(out, st.reminders(turn)...) + projectErr, projectManifest = nil, nil + if refresh.ProjectContext != nil { + var body string + body, projectManifest, projectErr = refresh.ProjectContext() + if projectErr == nil && body != "" { + out = append(out, body) + } + } // 快慢双速入口前置（SR-B10 实路径）：带附件的任务在第 0 回合就把 // 双速选项摆给模型——模型对开场指令的遵循远好于中途提醒（实测 // MiniMax 无视中途 system-reminder，但对工作方法开场指令照办）。 @@ -397,11 +485,11 @@ func (l *LLMRunner) runDirect(rc RunCtx, stream agentllm.StreamFunc, model strin // 只见 160 字摘要——实测会虚构章节、承诺未做之事。开启或异常兜底时才重写。 composeWanted := st.eff.GetBool("runtime.composeFinal", false) if err == nil && res.Err == nil && len(st.evidence) > 0 && composeWanted { - composed = st.composeFinal(stream, model, res.Notice, streamOpts) + composed = st.composeFinal(GuardProjectStream(rc, currentUserText(rc), stream), model, res.Notice, streamOpts) } if err == nil && res.Err == nil && !composed && res.Notice == "" && strings.TrimSpace(st.turnBody) == "" && len(st.evidence) > 0 { // 兜底：工作轮结束但没有任何给用户的正文（罕见），才用重写层补一段。 - composed = st.composeFinal(stream, model, "", streamOpts) + composed = st.composeFinal(GuardProjectStream(rc, currentUserText(rc), stream), model, "", streamOpts) } if res.Notice != "" && !composed { st.finalParts = append(st.finalParts, core.Part{Type: core.PartText, Text: res.Notice}) @@ -939,6 +1027,30 @@ func (st *directRun) runToolCtx(ctx context.Context, name, args string) agenttoo } case toolRunWorkflow: out = st.runRegisteredWorkflow(call.Arguments) + case toolReadProjectEvidence: + var a struct { + Reference string `json:"reference"` + } + if e := json.Unmarshal([]byte(call.Arguments), &a); e != nil || strings.TrimSpace(a.Reference) == "" { + err = fmt.Errorf("project evidence requires a reference") + break + } + reader, ok := st.rc.(interface { + ProjectEvidence(context.Context, string) (extension.ProjectEvidence, error) + }) + if !ok { + err = fmt.Errorf("project evidence unavailable") + break + } + var evidence extension.ProjectEvidence + evidence, err = reader.ProjectEvidence(ctx, a.Reference) + if err == nil { + if evidence.Reference.ID != a.Reference { + err = fmt.Errorf("project evidence reference mismatch") + } else { + out = evidence.Text + } + } case toolCard: out = st.submitCard(call.Arguments) case toolCardBegin: diff --git a/internal/runtime/project_context_test.go b/internal/runtime/project_context_test.go new file mode 100644 index 0000000..d07002f --- /dev/null +++ b/internal/runtime/project_context_test.go @@ -0,0 +1,193 @@ +package runtime + +import ( + "context" + "crypto/sha256" + "encoding/json" + "errors" + "fmt" + "strings" + "testing" + + agentllm "agent-native/runtime/llm" + "agent-squad/squad" + "agent-system-backend/pkg/extension" + core "agent-system-core" +) + +type projectRunCtx struct { + *fakeRunCtx + bundle extension.ProjectContextBundle + readErr error + reads int + manifests []extension.ProjectContextManifest + evidence func(string) (extension.ProjectEvidence, error) + budgetSettings core.EffectiveSettings +} + +func (c *projectRunCtx) Settings() core.EffectiveSettings { + if c.budgetSettings != nil { + return c.budgetSettings + } + return c.fakeRunCtx.Settings() +} + +func (c *projectRunCtx) ProjectContext(context.Context, string, int) (extension.ProjectContextBundle, bool, error) { + c.reads++ + return c.bundle, true, c.readErr +} + +func (c *projectRunCtx) SaveContextManifest(_ context.Context, m extension.ProjectContextManifest) error { + c.manifests = append(c.manifests, m) + return nil +} + +func (c *projectRunCtx) ProjectContextEnabled() bool { return true } +func (c *projectRunCtx) ProjectEvidence(_ context.Context, ref string) (extension.ProjectEvidence, error) { + return c.evidence(ref) +} + +func TestProjectContextRefreshesPerModelRequestWithoutPersistingOldSummary(t *testing.T) { + var requests [][]agentllm.Message + base := scriptStream(textTurns("private old model summary", "ok"), nil) + runner := &LLMRunner{Stream: func(ctx context.Context, model string, msgs []agentllm.Message, tools []agentllm.ToolDecl, opts agentllm.StreamOptions) <-chan agentllm.Event { + requests = append(requests, append([]agentllm.Message(nil), msgs...)) + return base(ctx, model, msgs, tools, opts) + }} + c := &projectRunCtx{fakeRunCtx: &fakeRunCtx{ctx: context.Background(), sandbox: t.TempDir(), projectID: "project-1", prof: core.AgentProfile{Model: core.ModelRoute{Chat: "test-model"}}}} + c.bundle = extension.ProjectContextBundle{Status: extension.ProjectContextReady, ProjectID: "project-1", Version: "v1", Items: []extension.ProjectContextItem{{SourceID: "s1", Text: "summary-v1", Required: true}}} + if err := runner.Execute(c); err != nil { + t.Fatal(err) + } + c.bundle.Version = "v2" + c.bundle.Items[0].Text = "summary-v2" + if err := runner.Execute(c); err != nil { + t.Fatal(err) + } + if len(requests) != 2 || !strings.Contains(joinReq(requests[0]), "summary-v1") || !strings.Contains(joinReq(requests[1]), "summary-v2") || strings.Contains(joinReq(requests[1]), "summary-v1") || strings.Contains(joinReq(requests[1]), "private old model summary") { + t.Fatalf("project context not refreshed: first=%q second=%q", joinReq(requests[0]), joinReq(requests[1])) + } + if c.reads != 2 || len(c.manifests) != 4 || c.manifests[0].Delivery != "attempted" || c.manifests[1].Delivery != "responded" || c.manifests[2].Version != "v2" || c.manifests[3].Delivery != "responded" || c.manifests[2].AttemptID != c.manifests[3].AttemptID || c.manifests[3].InputSHA256 == "" { + t.Fatalf("actual request manifests missing: reads=%d manifests=%+v", c.reads, c.manifests) + } + wire, err := json.Marshal(requests[1]) + if err != nil { + t.Fatal(err) + } + if want := fmt.Sprintf("%x", sha256.Sum256(wire)); c.manifests[3].InputSHA256 != want { + t.Fatalf("manifest hash %q does not match actual model request %q", c.manifests[3].InputSHA256, want) + } +} + +func TestProjectContextResolutionFailureBlocksModelRequest(t *testing.T) { + called := false + runner := &LLMRunner{Stream: func(ctx context.Context, model string, msgs []agentllm.Message, tools []agentllm.ToolDecl, opts agentllm.StreamOptions) <-chan agentllm.Event { + called = true + return scriptStream(textTurns("bad"), nil)(ctx, model, msgs, tools, opts) + }} + c := &projectRunCtx{fakeRunCtx: &fakeRunCtx{ctx: context.Background(), projectID: "project-1", prof: core.AgentProfile{Model: core.ModelRoute{Chat: "test-model"}}}, readErr: errors.New("permission revoked")} + if err := runner.Execute(c); err == nil || called { + t.Fatalf("context resolution failure reached model: err=%v called=%v", err, called) + } +} + +func TestReadProjectEvidenceToolUsesScopedReader(t *testing.T) { + c := &projectRunCtx{fakeRunCtx: &fakeRunCtx{projectID: "p1"}, evidence: func(ref string) (extension.ProjectEvidence, error) { + if ref != "ref-1" { + return extension.ProjectEvidence{}, errors.New("reference denied") + } + return extension.ProjectEvidence{Reference: extension.ProjectEvidenceRef{ID: ref}, Text: "current authorized detail"}, nil + }} + st := &directRun{l: &LLMRunner{}, rc: c, eff: c.Settings()} + if got := st.runToolCtx(context.Background(), toolReadProjectEvidence, `{"reference":"ref-1"}`); got.IsError || !strings.Contains(got.Content, "current authorized detail") { + t.Fatalf("current evidence unavailable: %+v", got) + } + if got := st.runToolCtx(context.Background(), toolReadProjectEvidence, `{"reference":"../../arbitrary"}`); !got.IsError { + t.Fatalf("arbitrary evidence reference accepted: %+v", got) + } +} + +func TestSubagentModelRequestUsesProjectContextAndManifest(t *testing.T) { + var sent []agentllm.Message + base := scriptStream(textTurns("done"), nil) + sub := &SubLLMRunner{Stream: func(ctx context.Context, model string, msgs []agentllm.Message, tools []agentllm.ToolDecl, opts agentllm.StreamOptions) <-chan agentllm.Event { + sent = append([]agentllm.Message(nil), msgs...) + return base(ctx, model, msgs, tools, opts) + }} + c := &projectRunCtx{fakeRunCtx: &fakeRunCtx{ctx: context.Background(), projectID: "project-1", prof: core.AgentProfile{Model: core.ModelRoute{Chat: "test-model", Lightweight: "test-lite"}}}, + bundle: extension.ProjectContextBundle{Status: extension.ProjectContextReady, ProjectID: "project-1", Items: []extension.ProjectContextItem{{SourceID: "s1", Text: "current project fact", Required: true}}}} + if err := sub.Execute(c); err != nil { + t.Fatal(err) + } + if !strings.Contains(joinReq(sent), "current project fact") || len(c.manifests) != 2 || c.manifests[1].Delivery != "responded" { + t.Fatalf("background subagent missed project context: input=%q manifests=%+v", joinReq(sent), c.manifests) + } +} + +func TestProjectStreamRejectsProjectRunWithoutTrustedContextPort(t *testing.T) { + called := false + base := func(ctx context.Context, model string, msgs []agentllm.Message, tools []agentllm.ToolDecl, opts agentllm.StreamOptions) <-chan agentllm.Event { + called = true + return scriptStream(textTurns("bad"), nil)(ctx, model, msgs, tools, opts) + } + stream := GuardProjectStream(&fakeRunCtx{projectID: "p1"}, "goal", base) + for ev := range stream(context.Background(), "test", []agentllm.Message{{Role: agentllm.RoleUser, Content: "goal"}}, nil, agentllm.StreamOptions{}) { + if ev.Kind != agentllm.KindError { + t.Fatalf("missing scope port did not fail closed: %+v", ev) + } + } + if called { + t.Fatal("model reached without a trusted project context port") + } +} + +func TestProjectStreamBlocksRequestExceedingFinalModelBudget(t *testing.T) { + called := false + base := func(ctx context.Context, model string, msgs []agentllm.Message, tools []agentllm.ToolDecl, opts agentllm.StreamOptions) <-chan agentllm.Event { + called = true + return scriptStream(textTurns("bad"), nil)(ctx, model, msgs, tools, opts) + } + c := &projectRunCtx{fakeRunCtx: &fakeRunCtx{projectID: "p1"}, bundle: extension.ProjectContextBundle{Status: extension.ProjectContextReady, ProjectID: "p1", Items: []extension.ProjectContextItem{{SourceID: "large", Text: strings.Repeat("x", 11000), Required: true}}}, budgetSettings: core.EffectiveSettings{"models": map[string]any{"chat": map[string]any{"contextWindow": float64(4096), "outputReserve": float64(512), "contextBuffer": float64(512)}}}} + for ev := range GuardProjectStream(c, "goal", base)(context.Background(), "test", []agentllm.Message{{Role: agentllm.RoleUser, Content: "goal"}}, nil, agentllm.StreamOptions{}) { + if ev.Kind != agentllm.KindError { + t.Fatalf("oversized request did not fail: %+v", ev) + } + } + if called || len(c.manifests) != 0 { + t.Fatalf("oversized project request reached model or recorded an attempt: called=%v manifests=%+v", called, c.manifests) + } +} + +type projectSquadCtx struct { + *entryFake + manifests []extension.ProjectContextManifest +} + +func (c *projectSquadCtx) Run() core.Run { + return core.Run{ID: "run-squad", Owner: "alice", ProjectID: "project-1"} +} +func (c *projectSquadCtx) ProjectContext(context.Context, string, int) (extension.ProjectContextBundle, bool, error) { + return extension.ProjectContextBundle{Status: extension.ProjectContextReady, ProjectID: "project-1", Items: []extension.ProjectContextItem{{SourceID: "squad-source", Text: "squad project fact", Required: true}}}, true, nil +} +func (c *projectSquadCtx) SaveContextManifest(_ context.Context, m extension.ProjectContextManifest) error { + c.manifests = append(c.manifests, m) + return nil +} + +func TestSquadEntryModelRequestUsesProjectContext(t *testing.T) { + var sent []agentllm.Message + base := writeThenStop(nil, nil) + runner := &SquadRunner{Router: fixedRoute{mode: squad.RouteDirect}, Checker: squad.MinimalChecker{}, Hitl: squad.HitlPolicy{Mode: squad.HitlDisabled}, + Stream: func(ctx context.Context, model string, msgs []agentllm.Message, tools []agentllm.ToolDecl, opts agentllm.StreamOptions) <-chan agentllm.Event { + sent = append([]agentllm.Message(nil), msgs...) + return base(ctx, model, msgs, tools, opts) + }} + dir := t.TempDir() + c := &projectSquadCtx{entryFake: &entryFake{text: "write report", sandbox: dir, settings: core.EffectiveSettings{"models": map[string]any{"chat": map[string]any{"model": "test-model", "baseUrl": "http://test"}}, "storage": map[string]any{"dataDir": dir}}}} + if err := runner.Execute(c); err != nil { + t.Fatal(err) + } + if !strings.Contains(joinReq(sent), "squad project fact") || len(c.manifests) < 2 || c.manifests[len(c.manifests)-1].Delivery != "responded" { + t.Fatalf("squad model missed project context: input=%q manifests=%+v", joinReq(sent), c.manifests) + } +} diff --git a/internal/runtime/project_stream.go b/internal/runtime/project_stream.go new file mode 100644 index 0000000..b8aad50 --- /dev/null +++ b/internal/runtime/project_stream.go @@ -0,0 +1,165 @@ +package runtime + +import ( + "context" + "crypto/sha256" + "encoding/json" + "fmt" + "time" + + agentllm "agent-native/runtime/llm" + "agent-native/runtime/reminders" + "agent-system-backend/internal/ctxasm" + "agent-system-backend/internal/projectcontext" + "agent-system-backend/pkg/extension" + core "agent-system-core" +) + +// GuardProjectStream injects project reference material only into a model +// request copy. This is used by execution paths that do not use LLMRunner's +// direct loop; no project or no registered provider keeps the old request. +func GuardProjectStream(rc any, goal string, stream agentllm.StreamFunc) agentllm.StreamFunc { + source, ok := rc.(interface { + ProjectContext(context.Context, string, int) (extension.ProjectContextBundle, bool, error) + }) + if stream == nil { + return stream + } + if !ok { + if scope, hasRun := rc.(interface{ Run() core.Run }); hasRun && scope.Run().ProjectID != "" { + return func(context.Context, string, []agentllm.Message, []agentllm.ToolDecl, agentllm.StreamOptions) <-chan agentllm.Event { + out := make(chan agentllm.Event, 1) + out <- agentllm.Event{Kind: agentllm.KindError, Err: fmt.Errorf("trusted project context port missing")} + close(out) + return out + } + } + return stream + } + return func(ctx context.Context, model string, messages []agentllm.Message, tools []agentllm.ToolDecl, opts agentllm.StreamOptions) <-chan agentllm.Event { + fail := func(err error) <-chan agentllm.Event { + out := make(chan agentllm.Event, 1) + out <- agentllm.Event{Kind: agentllm.KindError, Err: err} + close(out) + return out + } + const budget = 12000 + requestGoal := goal + if requestGoal == "" { + for i := len(messages) - 1; i >= 0; i-- { + if messages[i].Role == agentllm.RoleUser { + requestGoal = messages[i].Content + break + } + } + } + bundle, active, err := source.ProjectContext(ctx, requestGoal, budget) + if err != nil { + return fail(err) + } + if !active { + return stream(ctx, model, messages, tools, opts) + } + body, manifest, err := projectcontext.Assemble(bundle, budget) + if err != nil { + return fail(err) + } + request := reminders.Attach(messages, []string{body}) + if err := checkProjectInputBudget(rc, request, tools); err != nil { + return fail(err) + } + wire, err := json.Marshal(request) + if err != nil { + return fail(err) + } + manifest.Model = model + manifest.InputSHA256 = fmt.Sprintf("%x", sha256.Sum256(wire)) + if ledger, ok := rc.(interface { + ContextEvidenceInRequest([]agentllm.Message) []extension.ProjectContextManifestEntry + }); ok { + manifest.ReadEvidence = ledger.ContextEvidenceInRequest(request) + } + attemptID, err := projectcontext.NewAttemptID() + if err != nil { + return fail(err) + } + manifest.AttemptID, manifest.Delivery = attemptID, "attempted" + var save func(context.Context, extension.ProjectContextManifest) error + if sink, ok := rc.(interface { + SaveContextManifest(context.Context, extension.ProjectContextManifest) error + }); ok { + save = sink.SaveContextManifest + if err := save(ctx, manifest); err != nil { + return fail(err) + } + } + in := stream(ctx, model, request, tools, opts) + out := make(chan agentllm.Event, 1) + go func() { + defer close(out) + terminal := false + finish := func(status string) error { + if save == nil { + return nil + } + manifest.Delivery = status + receiptCtx, cancel := context.WithTimeout(context.Background(), 3*time.Second) + defer cancel() + return save(receiptCtx, manifest) + } + defer func() { + if !terminal { + _ = finish("unknown") + } + }() + for ev := range in { + if ev.Kind == agentllm.KindMessageEnd || ev.Kind == agentllm.KindError { + status := "unknown" + if ev.Kind == agentllm.KindMessageEnd { + status = "responded" + } + if err := finish(status); err != nil { + select { + case out <- agentllm.Event{Kind: agentllm.KindError, Err: err}: + case <-ctx.Done(): + } + terminal = true + return + } + terminal = true + } + select { + case out <- ev: + case <-ctx.Done(): + return + } + } + }() + return out + } +} + +func checkProjectInputBudget(rc any, messages []agentllm.Message, tools []agentllm.ToolDecl) error { + settings, ok := rc.(interface{ Settings() core.EffectiveSettings }) + if !ok { + return fmt.Errorf("project model budget unavailable") + } + eff := settings.Settings() + limit := int(eff.GetNumber("models.chat.contextWindow", 128000) - + eff.GetNumber("models.chat.outputReserve", 16384) - + eff.GetNumber("models.chat.contextBuffer", 4096)) + if limit <= 0 { + return fmt.Errorf("project model input budget exhausted") + } + used := 0 + for _, msg := range messages { + used += ctxasm.EstimateTokens(msg.Content) + 8 + } + for _, tool := range tools { + used += ctxasm.EstimateTokens(tool.Description+string(tool.Parameters)) + 8 + } + if used > limit { + return fmt.Errorf("project model input exceeds budget: estimated %d tokens, available %d", used, limit) + } + return nil +} diff --git a/internal/runtime/squad_runner.go b/internal/runtime/squad_runner.go index 22775cb..bc789e5 100644 --- a/internal/runtime/squad_runner.go +++ b/internal/runtime/squad_runner.go @@ -65,12 +65,16 @@ func (s *SquadRunner) Execute(rc RunCtx) error { if router == nil { router = newModelRouter(rc) } + stream := s.Stream + if stream != nil { + stream = GuardProjectStream(rc, entryGoal(rc), stream) + } res, err := squadadapter.RunEntry(rc, squadadapter.EntryOptions{ DataDir: rc.Settings().GetString("storage.dataDir", "./data"), Goal: entryGoal(rc), HostTools: bridgeHostTools(rc, produced), OnEvent: onEvent, - Stream: s.Stream, + Stream: stream, Router: router, Checker: s.Checker, Hitl: s.Hitl, @@ -140,7 +144,7 @@ func newModelRouter(rc RunCtx) modelRouter { return modelRouter{} } client := openLLMClient(route.Base, route.Key, route.Model) - return modelRouter{stream: client.Stream, model: route.Model} + return modelRouter{stream: GuardProjectStream(rc, "", client.Stream), model: route.Model} } func (r modelRouter) Route(ctx context.Context, goal squad.Goal) (*squad.RouteDecision, error) { diff --git a/internal/runtime/sub_loop.go b/internal/runtime/sub_loop.go index 3e5f302..a9dc89c 100644 --- a/internal/runtime/sub_loop.go +++ b/internal/runtime/sub_loop.go @@ -76,6 +76,7 @@ func (l *SubLLMRunner) Execute(rc RunCtx) error { client := openLLMClient(route.Base, route.Key, route.Model) stream = client.Stream } + stream = GuardProjectStream(rc, subagentUserText(rc), stream) if spec.Model == "chat" { stream = agentllm.WithFallback(stream, ChatFallbacks(rc.Settings()), nil) } diff --git a/internal/runtime/transcript_compact.go b/internal/runtime/transcript_compact.go index 06dbdbc..cdb8cb7 100644 --- a/internal/runtime/transcript_compact.go +++ b/internal/runtime/transcript_compact.go @@ -7,6 +7,7 @@ import ( agentllm "agent-native/runtime/llm" agentsession "agent-native/runtime/session" + "agent-system-backend/pkg/extension" core "agent-system-core" ) @@ -16,9 +17,10 @@ const compactKeepMessages = 16 // 请求侧生效、不落转录）：个人指令/会话要求等尾注、环境更新行、本轮新命中的 // 提示词模块正文。 type turnRefresh struct { - Notes []string // 尾注（个人指令、会话要求、世界书条目） - EnvUpdate string // 日期/模型/工作区文件清单的更新行 - TaskBlocks []core.PromptBlock + Notes []string // 尾注（个人指令、会话要求、世界书条目） + EnvUpdate string // 日期/模型/工作区文件清单的更新行 + TaskBlocks []core.PromptBlock + ProjectContext func() (string, *extension.ProjectContextManifest, error) } // maybeCompact 在转录估算超过窗口阈值时先做结构化压缩：9 段模板摘要 + 保留 diff --git a/internal/runtime/workflow_compiled.go b/internal/runtime/workflow_compiled.go index ab7a3d3..428cd90 100644 --- a/internal/runtime/workflow_compiled.go +++ b/internal/runtime/workflow_compiled.go @@ -81,9 +81,10 @@ func judgeStreamFor(rc RunCtx) agentllm.StreamFunc { } client := openLLMClient(route.Base, route.Key, route.Model) model := route.Model - return func(ctx context.Context, _ string, msgs []agentllm.Message, tools []agentllm.ToolDecl, opts agentllm.StreamOptions) <-chan agentllm.Event { + base := func(ctx context.Context, _ string, msgs []agentllm.Message, tools []agentllm.ToolDecl, opts agentllm.StreamOptions) <-chan agentllm.Event { return client.Stream(ctx, model, msgs, tools, opts) } + return GuardProjectStream(rc, "", base) } // planCompiledWorkflow 规划分支（run_workflow goal=）：规划子代理产出 diff --git a/internal/runtime/workflow_compiled_test.go b/internal/runtime/workflow_compiled_test.go index 134322d..70faa07 100644 --- a/internal/runtime/workflow_compiled_test.go +++ b/internal/runtime/workflow_compiled_test.go @@ -12,6 +12,7 @@ import ( agentllm "agent-native/runtime/llm" "agent-system-backend/internal/workflow" + "agent-system-backend/pkg/extension" core "agent-system-core" ) @@ -292,4 +293,48 @@ func TestJudgeStreamUsesConfiguredModel(t *testing.T) { } } +type projectJudgeCtx struct { + *wfFake + manifests []extension.ProjectContextManifest +} + +func (c *projectJudgeCtx) Run() core.Run { + return core.Run{ID: "run-judge", Owner: "alice", ProjectID: "project-1"} +} +func (c *projectJudgeCtx) ProjectContext(context.Context, string, int) (extension.ProjectContextBundle, bool, error) { + return extension.ProjectContextBundle{Status: extension.ProjectContextReady, ProjectID: "project-1", Items: []extension.ProjectContextItem{{SourceID: "judge-source", Text: "current project rule", Required: true}}}, true, nil +} +func (c *projectJudgeCtx) SaveContextManifest(_ context.Context, m extension.ProjectContextManifest) error { + c.manifests = append(c.manifests, m) + return nil +} + +func TestWorkflowJudgeRequestUsesProjectContext(t *testing.T) { + var sent string + srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { + var body struct { + Messages []struct { + Content string `json:"content"` + } `json:"messages"` + } + _ = json.NewDecoder(r.Body).Decode(&body) + for _, m := range body.Messages { + sent += m.Content + } + w.Header().Set("Content-Type", "text/event-stream") + _, _ = io.WriteString(w, "data: {\"choices\":[{\"delta\":{\"content\":\"ok\"}}]}\n\n") + _, _ = io.WriteString(w, "data: [DONE]\n\n") + })) + defer srv.Close() + c := &projectJudgeCtx{wfFake: &wfFake{settings: core.EffectiveSettings{"models": map[string]any{"chat": map[string]any{"baseUrl": srv.URL, "apiKey": "test-key", "model": "test-model"}}}}} + for ev := range judgeStreamFor(c)(context.Background(), "test-model", []agentllm.Message{{Role: agentllm.RoleUser, Content: "judge"}}, nil, agentllm.StreamOptions{}) { + if ev.Kind == agentllm.KindError { + t.Fatalf("judge stream failed: %+v", ev) + } + } + if !strings.Contains(sent, "current project rule") || len(c.manifests) != 2 || c.manifests[1].Delivery != "responded" { + t.Fatalf("workflow judge missed project context: input=%q manifests=%+v", sent, c.manifests) + } +} + func (*wfFake) Surfaces() []core.SurfaceSnapshot { return nil } diff --git a/internal/store/context_manifest.go b/internal/store/context_manifest.go new file mode 100644 index 0000000..947b42f --- /dev/null +++ b/internal/store/context_manifest.go @@ -0,0 +1,50 @@ +package store + +import ( + "encoding/json" + "errors" + + "agent-system-backend/pkg/extension" +) + +const contextManifestAction = "model.context_manifest" + +// AppendContextManifest stores a content-free receipt before a model request. +// The caller must supply a previously verified run or conversation target. +func (s *Store) AppendContextManifest(owner, targetID string, m extension.ProjectContextManifest) error { + if owner == "" || targetID == "" || m.ProjectID == "" || m.InputSHA256 == "" { + return errors.New("context manifest requires owner, target, project and input hash") + } + raw, err := json.Marshal(m) + if err != nil { + return err + } + return s.AppendAuditEvent(AuditEvent{Owner: owner, Actor: owner, Action: contextManifestAction, Target: targetID, Evidence: string(raw)}) +} + +// ListContextManifests reads receipts only within the authenticated owner's +// scope. The target is a run ID for ordinary work, or a conversation ID for +// direct WorkCompletionHost calls. +func (s *Store) ListContextManifests(owner, targetID string) ([]extension.ProjectContextManifest, error) { + if owner == "" || targetID == "" { + return nil, errors.New("context manifest query requires owner and target") + } + rows, err := s.db.Query(s.q(`SELECT evidence FROM audit_events WHERE owner=? AND action=? AND target=? ORDER BY id`), owner, contextManifestAction, targetID) + if err != nil { + return nil, err + } + defer rows.Close() + var out []extension.ProjectContextManifest + for rows.Next() { + var raw string + if err := rows.Scan(&raw); err != nil { + return nil, err + } + var m extension.ProjectContextManifest + if err := json.Unmarshal([]byte(raw), &m); err != nil { + return nil, err + } + out = append(out, m) + } + return out, rows.Err() +} diff --git a/internal/store/migrate.go b/internal/store/migrate.go index c31e0e8..56a087f 100644 --- a/internal/store/migrate.go +++ b/internal/store/migrate.go @@ -848,6 +848,13 @@ func init() { }, down: map[string][]string{"sqlite": {`DROP TABLE IF EXISTS project_event_shares`}, "postgres": {`DROP TABLE IF EXISTS project_event_shares`}}, }, + migration{version: 31, name: "work_task_bindings", + up: map[string][]string{ + "sqlite": {`CREATE TABLE work_task_bindings(task_id TEXT PRIMARY KEY,owner TEXT NOT NULL,plugin_id TEXT NOT NULL,conversation_id TEXT NOT NULL,project_id TEXT NOT NULL,created_at TEXT NOT NULL,FOREIGN KEY(task_id) REFERENCES background_tasks(id) ON DELETE CASCADE)`}, + "postgres": {`CREATE TABLE work_task_bindings(task_id TEXT PRIMARY KEY,owner TEXT NOT NULL,plugin_id TEXT NOT NULL,conversation_id TEXT NOT NULL,project_id TEXT NOT NULL,created_at TEXT NOT NULL,FOREIGN KEY(task_id) REFERENCES background_tasks(id) ON DELETE CASCADE)`}, + }, + down: map[string][]string{"sqlite": {`DROP TABLE IF EXISTS work_task_bindings`}, "postgres": {`DROP TABLE IF EXISTS work_task_bindings`}}, + }, ) } diff --git a/internal/store/migrate_compat.go b/internal/store/migrate_compat.go index 86c692c..07944d4 100644 --- a/internal/store/migrate_compat.go +++ b/internal/store/migrate_compat.go @@ -35,6 +35,7 @@ var migrationBreaksOldReaders = map[int]bool{ 28: false, // auth_version_account_events：仅加列与新表，旧读者不受影响 29: false, // redeem_attempts：新表，旧读者不受影响 30: false, // project_event_publication_proofs：新表，旧读者不受影响 + 31: false, // work_task_bindings：新增绑定表，旧后台任务读面不受影响 } // SchemaTarget 是本二进制会迁移到的 schema 版本。 diff --git a/internal/store/work_tasks.go b/internal/store/work_tasks.go new file mode 100644 index 0000000..cb89826 --- /dev/null +++ b/internal/store/work_tasks.go @@ -0,0 +1,57 @@ +package store + +import ( + "context" + "database/sql" + "errors" +) + +type WorkTaskBinding struct { + TaskID string + Owner string + PluginID string + ConversationID string + ProjectID string + Status string +} + +// CreateWorkTask atomically saves the legacy task row and its trusted creation +// scope. A legacy TaskCreate row has no binding and cannot enter work recovery. +func (s *Store) CreateWorkTask(owner, pluginID, projectID, conversationID, kind, title string) (BackgroundTask, error) { + if owner == "" || pluginID == "" || projectID == "" || conversationID == "" || kind == "" { + return BackgroundTask{}, errors.New("work task scope incomplete") + } + tx, err := s.db.BeginTx(context.Background(), nil) + if err != nil { + return BackgroundTask{}, err + } + defer tx.Rollback() + now := nowISO() + t := BackgroundTask{ID: NewID("task"), Owner: owner, Kind: kind, Title: title, Status: "queued", ConversationID: conversationID, CreatedAt: now, UpdatedAt: now} + if _, err := tx.Exec(s.q(`INSERT INTO background_tasks(id,owner,kind,title,status,progress,error,conversation_id,created_at,updated_at) VALUES(?,?,?,?,?,?,?,?,?,?)`), + t.ID, owner, kind, title, t.Status, 0, "", conversationID, now, now); err != nil { + return BackgroundTask{}, err + } + if _, err := tx.Exec(s.q(`INSERT INTO work_task_bindings(task_id,owner,plugin_id,conversation_id,project_id,created_at) VALUES(?,?,?,?,?,?)`), + t.ID, owner, pluginID, conversationID, projectID, now); err != nil { + return BackgroundTask{}, err + } + if err := tx.Commit(); err != nil { + return BackgroundTask{}, err + } + return t, nil +} + +// WorkTaskScope resolves a task only under its original owner and plugin. +func (s *Store) WorkTaskScope(owner, pluginID, taskID string) (WorkTaskBinding, error) { + var b WorkTaskBinding + if owner == "" || pluginID == "" || taskID == "" { + return b, ErrNotFound + } + err := s.db.QueryRow(s.q(`SELECT b.task_id,b.owner,b.plugin_id,b.conversation_id,b.project_id,t.status FROM work_task_bindings b JOIN background_tasks t ON t.id=b.task_id WHERE b.task_id=? AND b.owner=? AND b.plugin_id=? AND t.owner=? AND t.conversation_id=b.conversation_id`), + taskID, owner, pluginID, owner).Scan(&b.TaskID, &b.Owner, &b.PluginID, &b.ConversationID, &b.ProjectID, &b.Status) + if errors.Is(err, sql.ErrNoRows) { + return WorkTaskBinding{}, ErrNotFound + } + return b, err +} diff --git a/pkg/extension/extension.go b/pkg/extension/extension.go index 2454e4e..f36e91e 100644 --- a/pkg/extension/extension.go +++ b/pkg/extension/extension.go @@ -34,7 +34,7 @@ import ( // 分区组件自身的命令面 fail-closed）。 // 2.12.0-experimental: optional ProjectHost/ProjectLifecycleRegistry and trusted // ResourceAuthzQuery.Source for per-document publication authorization. -const SurfaceVersion = "2.12.0-experimental" +const SurfaceVersion = "2.13.0-experimental" // ErrNotLinked 表示进程没有空白导入 link 包，Main 无法启动服务。 var ErrNotLinked = errors.New("extension: runner not linked; blank-import agent-system-backend/pkg/extension/link") @@ -179,6 +179,9 @@ type Options struct { StorageDSN string ArtifactsDir string AuthMode string + // RequireProjectContext makes startup fail if no in-process X1 provider + // registered. Downstream products opt in when project context is mandatory. + RequireProjectContext bool // DisableUploadIndexing 关闭上传端点的自动检索索引（EXT-9；零值=false=现状： // 可解析文本照旧进索引。下游以发布状态机自管索引时置 true）。 DisableUploadIndexing bool diff --git a/pkg/extension/host.go b/pkg/extension/host.go index c528b81..9d36b71 100644 --- a/pkg/extension/host.go +++ b/pkg/extension/host.go @@ -41,6 +41,8 @@ type Handler func(ctx context.Context, h Host, req Request) (any, error) // 可选能力接口（type assertion 获取，断言失败＝明确报错）： // - AdminProvider — EXT-18：调用方平台管理角色查询 // - SurfaceHost — EXT-17：页面保存/读取 +// - WorkCompletionHost — X1：受信项目工作生成 +// - WorkTaskHost — X1：分发期建立可恢复的受信项目任务绑定 type Host interface { // PluginID 返回注册处理器的插件标识（形如 rdm）。 PluginID() string diff --git a/pkg/extension/link/link.go b/pkg/extension/link/link.go index 1d6a41f..fda2744 100644 --- a/pkg/extension/link/link.go +++ b/pkg/extension/link/link.go @@ -12,6 +12,7 @@ func init() { return app.Run(app.Options{ Addr: opt.Addr, DataDir: opt.DataDir, PluginsDir: opt.PluginsDir, ForceMock: opt.Mock, StorageDSN: opt.StorageDSN, ArtifactsDir: opt.ArtifactsDir, AuthMode: opt.AuthMode, + RequireProjectContext: opt.RequireProjectContext, DisableUploadIndexing: opt.DisableUploadIndexing, DisableConvCardMirror: opt.DisableConvCardMirror, DisableExecTools: opt.DisableExecTools, diff --git a/pkg/extension/project_context.go b/pkg/extension/project_context.go new file mode 100644 index 0000000..ad85007 --- /dev/null +++ b/pkg/extension/project_context.go @@ -0,0 +1,142 @@ +package extension + +import ( + "context" + + core "agent-system-core" +) + +// ProjectContextRegistry is optional. An in-process plugin may register one +// provider; existing Registry implementations are unchanged. +type ProjectContextRegistry interface { + RegisterProjectContextProvider(ProjectContextProvider) error +} + +// ProjectContextRequest is built by the host from an authenticated dispatch or +// persisted run. Plugins and model arguments cannot choose Actor or ProjectID. +type ProjectContextRequest struct { + Actor string + PluginID string + ProjectID core.ID + ConversationID core.ID + TaskID core.ID + RunID core.ID + StepID core.ID + Goal string + TargetID string + BudgetChars int + LastWatermark string +} + +type ProjectContextStatus string + +const ( + ProjectContextReady ProjectContextStatus = "ready" + ProjectContextNotFound ProjectContextStatus = "not-found" + ProjectContextDenied ProjectContextStatus = "denied" + ProjectContextIncomplete ProjectContextStatus = "incomplete" +) + +// ProjectContextItem is a currently authorized summary or requirement. Text is +// untrusted source material and must enter the model as user-level context. +type ProjectContextItem struct { + SourceID string + Revision string + Hash string + Text string + Required bool +} + +type ProjectEvidenceRef struct { + ID string + SourceID string + Revision string + Hash string +} + +type ProjectContextBundle struct { + Status ProjectContextStatus + ProjectID core.ID + Version string + Watermark string + AuthorizationEpoch string + PublicationEpoch string + Items []ProjectContextItem + Evidence []ProjectEvidenceRef + Missing []string +} + +// ProjectEvidenceRequest permits only a reference returned by Resolve for the +// same trusted scope. The provider must recheck current access at read time. +type ProjectEvidenceRequest struct { + Scope ProjectContextRequest + Reference ProjectEvidenceRef +} + +type ProjectEvidence struct { + Reference ProjectEvidenceRef + Text string +} + +type ProjectContextProvider interface { + Resolve(context.Context, ProjectContextRequest) (ProjectContextBundle, error) + ReadEvidence(context.Context, ProjectEvidenceRequest) (ProjectEvidence, error) +} + +// WorkCompletionRequest gives the generation goal and optional target. It has +// no owner/project field; both are resolved from the dispatch host's stored +// conversation immediately before the model call. +type WorkCompletionRequest struct { + Goal string + TargetID string + TaskID string // recovery locator only; host verifies its persisted owner/plugin/project binding + EvidenceRefs []string // optional stable refs from the current provider bundle; no paths or owners +} + +// WorkTaskHost creates a persisted task bound to this dispatch's authenticated +// owner, plugin, conversation and project. Legacy Host.TaskCreate is unbound and +// cannot be used to recover a WorkCompletionHost scope. +type WorkTaskHost interface { + TaskCreateForWork(kind, title string) (taskID string, err error) +} + +type ProjectContextManifestEntry struct { + ReferenceID string + SourceID string + Revision string + SourceHash string + InputSHA256 string + Reason string +} + +// ProjectContextManifest describes the text actually passed to the completion +// client. Candidate references in a bundle are never listed as included input. +type ProjectContextManifest struct { + ProjectID core.ID + TaskID string + Version string + Watermark string + AuthorizationEpoch string + PublicationEpoch string + AttemptID string + Delivery string // attempted | responded | unknown; never implies user-visible delivery + Model string + BudgetChars int + InputSHA256 string + Included []ProjectContextManifestEntry + Dropped []ProjectContextManifestEntry + OfferedReferences []ProjectEvidenceRef + ReadEvidence []ProjectContextManifestEntry + Missing []string +} + +type WorkCompletionResult struct { + Text string + Manifest ProjectContextManifest +} + +// WorkCompletionHost is optional and available only on a dispatch-scoped Host. +// A Host obtained via NewScopedHost has no trusted conversation scope. +type WorkCompletionHost interface { + CompleteForWork(context.Context, WorkCompletionRequest) (WorkCompletionResult, error) +} diff --git a/pkg/extension/surface.txt b/pkg/extension/surface.txt index 7d88ba4..c3a08ec 100644 --- a/pkg/extension/surface.txt +++ b/pkg/extension/surface.txt @@ -32,6 +32,24 @@ Main NewHostClient NewScopedHost Options +ProjectContextBundle +ProjectContextDenied +ProjectContextIncomplete +ProjectContextItem +ProjectContextManifest +ProjectContextManifestEntry +ProjectContextNotFound +ProjectContextProvider +ProjectContextProvider.ReadEvidence +ProjectContextProvider.Resolve +ProjectContextReady +ProjectContextRegistry +ProjectContextRegistry.RegisterProjectContextProvider +ProjectContextRequest +ProjectContextStatus +ProjectEvidence +ProjectEvidenceRef +ProjectEvidenceRequest ProjectHost ProjectHost.EnsureProject ProjectHost.OwnedProject @@ -67,3 +85,9 @@ SurfaceHost.SurfaceList SurfaceHost.SurfaceSave SurfaceSaveRequest SurfaceVersion +WorkCompletionHost +WorkCompletionHost.CompleteForWork +WorkCompletionRequest +WorkCompletionResult +WorkTaskHost +WorkTaskHost.TaskCreateForWork -- 2.54.0 From a8fa2fe6c9172674b50c8548487d2f4e3abdb0ab Mon Sep 17 00:00:00 2001 From: weichen Date: Wed, 14 Oct 2026 04:11:09 +0000 Subject: [PATCH 04/41] Bind trusted operation IDs before domain handlers Why: A domain outbox could not correlate its committed event with the host receipt because the bus generated the operation ID after the handler returned. Evidence: RED-to-GREEN bus and compiled-handler tests; local go test ./... -count=1 and isolated PostgreSQL operation/link checks passed as SELF. Impact: Expose a host-generated operation ID to handlers and resolve a unique committed audit offset after dispatch; missing receipts remain retryable and ambiguous rows fail closed. Refs: Stage 5 W9; approved Stage 6 audit-link design adjustment r1 --- .task/feature-rdm-two-trees-project-audit.md | 4 +- internal/app/compiled.go | 2 +- internal/app/project_audit.go | 15 ++++- internal/app/project_audit_link_test.go | 11 +++- internal/app/surface_audit_actor_test.go | 61 ++++++++++++++++++++ internal/cmdbus/cmdbus.go | 8 ++- internal/cmdbus/cmdbus_test.go | 28 +++++++++ internal/store/project_audit_links.go | 32 ++++++++++ internal/store/project_audit_links_test.go | 13 +++++ pkg/extension/extension.go | 4 +- pkg/extension/host.go | 3 + pkg/extension/project_audit.go | 6 +- pkg/extension/surface.txt | 1 + 13 files changed, 180 insertions(+), 8 deletions(-) diff --git a/.task/feature-rdm-two-trees-project-audit.md b/.task/feature-rdm-two-trees-project-audit.md index 05a3595..6fb6a96 100644 --- a/.task/feature-rdm-two-trees-project-audit.md +++ b/.task/feature-rdm-two-trees-project-audit.md @@ -12,6 +12,7 @@ - Store write snapshots the project from the owner-matched conversation; query requires the authenticated actor's owner and that immutable project. This deliberately excludes other members' private conversations and unbound historical rows, and does not move old receipts when a conversation changes projects. - Command audit stores the current verified account display name at write time; old rows expose `not-recorded`. Public receipts omit raw payload and parameter digest. Cursor uses project-and-owner scoped source cutoff. - Initial commit `c8dd169a1fdc1451fab3b475c14f9636a7f5bf6c` exposed only the actor-owned project slice. The next local increment fixes button actor propagation and adds a trusted domain-commit link publisher, verifier callback, exact linked metadata read, current `audit.read` and per-object metadata checks, and durable idempotency. Unlinked personal conversations remain private. +- Trusted command dispatch now creates an operation ID before calling the compiled handler and passes that ID through `extension.Request`. The handler can commit the same ID with its domain event/outbox; the final Backend audit/receipt uses it. Client `params.operationId` is ignored. An outbox link request with `HostAuditOffset=0` resolves a unique committed host row by owner, fixed project, and operation ID; a missing row returns retryable `ErrProjectAuditPending`, while duplicate rows fail closed. The separate idempotency key still controls retry equivalence. - Exact-source linked reads do not enumerate hidden links or reveal raw payload, private conversation ID, or content. Body disclosure and a broad project link list are not implemented; the public coverage reports the narrower capability. ## Verification and remaining work @@ -21,5 +22,6 @@ - SELF receipt `/tmp/backend-w9-build-20261014-01.json`: `CGO_ENABLED=0 go build ./cmd/agent-system`, exit 0, run on that pre-commit tree. Generated local binary removed after the build. - SELF PostgreSQL receipt `/tmp/backend-w9-pg-cutoff-20261014-01.json`: isolated PostgreSQL 18.6 instance on port 55442 reproduced a low-ID transaction committing after a higher visible ID. `/tmp/backend-w9-pg-link-20261014-02.json` verifies the new link table, retry/conflict behavior, and the cutoff counterexample against isolated schemas. Both exited 0. The current PG cutoff means only `offset-upper-bound-only`; it is **not** a fixed historical visibility snapshot or safe incremental cursor. - SELF PostgreSQL receipt `/tmp/backend-w9-pg-migrate-20261014-01.json`: isolated SQLite→PostgreSQL migration preserved one linked receipt and advanced its target sequence; the same migration ID replayed idempotently. The temporary PG instance was stopped and removed after verification. +- SELF PostgreSQL receipt `/tmp/backend-w9-pg-operation-20261014-01.json`: a fresh isolated PG instance reran the link lookup, idempotency/conflict, and low-ID late-commit checks after trusted operation-offset resolution was added. The instance was stopped and removed. - Integration constraint: this branch uses schema v31 (audit attribution) and v32 (links), while the independent W6 Backend branch also has a local v31. Neither branch has consumed the other's unmerged work. After the first branch lands, the later branch owner must sync the new main, renumber its unpublished migrations without rewriting an already released version, and rerun fresh/old SQLite and PG migration plus combined regression on the actual merged source. These isolated tests do not prove W6+W9 compatibility. -- Required next W9 work: add a committed-order waterline or materialize the authorized ID set at the first read, then prove with PG low-ID late commits that history and cross-page incremental reads neither omit nor duplicate operations. The Backend project-event source, actual RDM committed-event verifier/outbox consumer, run ID propagation from command dispatch, model/tool/background receipts, body/detail disclosure, broad authorized list pagination, history/export, and combined product verification remain unfinished. The exact-link slice is not Stage 7 audit acceptance. +- Required next W9 work: add a committed-order waterline or materialize the authorized ID set at the first read, then prove with PG low-ID late commits that history and cross-page incremental reads neither omit nor duplicate operations. The Backend project-event source, actual RDM committed-event verifier/outbox consumer, run ID propagation from command dispatch, model/tool/background receipts, body/detail disclosure, broad authorized list pagination, history/export, and combined product verification remain unfinished. A domain commit followed by a lost Backend audit append leaves the link pending; recovery must retain and reconcile that unknown state without claiming a host receipt. The exact-link slice is not Stage 7 audit acceptance. diff --git a/internal/app/compiled.go b/internal/app/compiled.go index da47164..5af5757 100644 --- a/internal/app/compiled.go +++ b/internal/app/compiled.go @@ -67,7 +67,7 @@ func (r pluginRegistry) AddCommandHandler(spec json.RawMessage, h extension.Hand host := inprocHost{caps: r.caps, pluginID: r.pluginID, owner: req.Owner, actor: req.Actor} return h(ctx, host, extension.Request{ ID: req.ID, Params: req.Params, Entrance: req.Entrance, - Actor: req.Actor, Owner: req.Owner, ConversationID: req.ConversationID, + Actor: req.Actor, Owner: req.Owner, ConversationID: req.ConversationID, OperationID: req.OperationID, HostProjectID: req.HostProjectID, }) }) diff --git a/internal/app/project_audit.go b/internal/app/project_audit.go index 53be92d..4b5101b 100644 --- a/internal/app/project_audit.go +++ b/internal/app/project_audit.go @@ -128,9 +128,22 @@ func (h inprocHost) PublishProjectAuditLink(ctx context.Context, req extension.P if holder != h.pluginID || verify == nil { return extension.ProjectAuditLinkReceipt{}, extension.ErrProjectAuditUnsupported } - if h.owner == "" || (h.actor != "" && h.actor != h.owner) || req.HostAuditOffset <= 0 || req.ProjectID == "" || req.SourceKind != "domain-commit" || req.SourceID == "" || req.OperationID == "" || req.ResourceKind == "" || req.ResourceID == "" || req.DisclosureClass != "metadata" || req.IdempotencyKey == "" { + if h.owner == "" || (h.actor != "" && h.actor != h.owner) || req.HostAuditOffset < 0 || req.ProjectID == "" || req.SourceKind != "domain-commit" || req.SourceID == "" || req.OperationID == "" || req.ResourceKind == "" || req.ResourceID == "" || req.DisclosureClass != "metadata" || req.IdempotencyKey == "" { return extension.ProjectAuditLinkReceipt{}, extension.ErrProjectAuditDenied } + if req.HostAuditOffset == 0 { + resolved, err := h.caps.st.CommittedAuditOffset(h.owner, string(req.ProjectID), req.OperationID) + if errors.Is(err, store.ErrNotFound) { + return extension.ProjectAuditLinkReceipt{}, extension.ErrProjectAuditPending + } + if errors.Is(err, store.ErrConflict) { + return extension.ProjectAuditLinkReceipt{}, extension.ErrProjectAuditLinkConflict + } + if err != nil { + return extension.ProjectAuditLinkReceipt{}, err + } + req.HostAuditOffset = resolved + } row, projectID, err := h.caps.st.CommandAuditForLink(h.owner, req.HostAuditOffset) if errors.Is(err, store.ErrNotFound) { return extension.ProjectAuditLinkReceipt{}, extension.ErrProjectAuditDenied diff --git a/internal/app/project_audit_link_test.go b/internal/app/project_audit_link_test.go index 5940436..8c805ca 100644 --- a/internal/app/project_audit_link_test.go +++ b/internal/app/project_audit_link_test.go @@ -73,12 +73,13 @@ func TestProjectAuditLinkSharesOnlyVerifiedCommittedMetadata(t *testing.T) { t.Fatalf("unlinked private audit: %v", err) } alicePublisher := inprocHost{caps: caps, pluginID: "rdm", owner: "alice"} // trusted outbox-scoped host - linkReq := extension.ProjectAuditLinkRequest{ProjectID: p.ID, HostAuditOffset: offset, SourceKind: "domain-commit", SourceID: "commit-1", OperationID: "op-1", ResourceKind: "document", ResourceID: "doc-1", DisclosureClass: "metadata", IdempotencyKey: "outbox-1"} + linkReq := extension.ProjectAuditLinkRequest{ProjectID: p.ID, SourceKind: "domain-commit", SourceID: "commit-1", OperationID: "op-1", ResourceKind: "document", ResourceID: "doc-1", DisclosureClass: "metadata", IdempotencyKey: "outbox-1"} if rows, err := bob.QueryProjectAudit(context.Background(), extension.ProjectAuditQuery{ProjectID: p.ID}); err != nil || len(rows.Receipts) != 0 { t.Fatalf("private owner row visible without exact link: %+v %v", rows, err) } wrongProject := linkReq wrongProject.ProjectID = otherProject.ID + wrongProject.HostAuditOffset = offset if _, err := alicePublisher.PublishProjectAuditLink(context.Background(), wrongProject); !errors.Is(err, extension.ErrProjectAuditDenied) { t.Fatalf("wrong host project: %v", err) } @@ -90,10 +91,18 @@ func TestProjectAuditLinkSharesOnlyVerifiedCommittedMetadata(t *testing.T) { if _, err := (inprocHost{caps: caps, pluginID: "other", owner: "alice"}).PublishProjectAuditLink(context.Background(), linkReq); !errors.Is(err, extension.ErrProjectAuditUnsupported) { t.Fatalf("other plugin: %v", err) } + pending := linkReq + pending.OperationID, pending.IdempotencyKey = "op-not-yet-recorded", "outbox-pending" + if _, err := alicePublisher.PublishProjectAuditLink(context.Background(), pending); !errors.Is(err, extension.ErrProjectAuditPending) { + t.Fatalf("host receipt race must be retryable: %v", err) + } first, err := alicePublisher.PublishProjectAuditLink(context.Background(), linkReq) if err != nil { t.Fatal(err) } + if first.HostAuditOffset != offset { + t.Fatalf("trusted resolved offset: got %d want %d", first.HostAuditOffset, offset) + } retry, err := alicePublisher.PublishProjectAuditLink(context.Background(), linkReq) if err != nil || retry.LinkID != first.LinkID { t.Fatalf("idempotent retry: first=%+v retry=%+v err=%v", first, retry, err) diff --git a/internal/app/surface_audit_actor_test.go b/internal/app/surface_audit_actor_test.go index 2749d7a..d57eae1 100644 --- a/internal/app/surface_audit_actor_test.go +++ b/internal/app/surface_audit_actor_test.go @@ -2,6 +2,7 @@ package app import ( "context" + "encoding/json" "path/filepath" "testing" "time" @@ -10,6 +11,8 @@ import ( "agent-system-backend/internal/cmdbus" "agent-system-backend/internal/store" "agent-system-backend/internal/surfacesvc" + "agent-system-backend/pkg/extension" + core "agent-system-core" ) func TestSurfaceButtonDispatchUsesAuthenticatedActor(t *testing.T) { @@ -48,3 +51,61 @@ func TestSurfaceButtonDispatchUsesAuthenticatedActor(t *testing.T) { t.Fatalf("button audit actor: %+v", rows) } } + +func TestCompiledHandlerReceivesHostOperationID(t *testing.T) { + st, err := store.OpenSQLite(filepath.Join(t.TempDir(), "audit.db")) + if err != nil { + t.Fatal(err) + } + defer st.Close() + p, err := st.CreateProject("alice", "A") + if err != nil { + t.Fatal(err) + } + c, err := st.CreateConversation("alice", string(p.ID), "work", "") + if err != nil { + t.Fatal(err) + } + bus := cmdbus.New(st, nil, func() time.Time { return time.Now().UTC() }) + slot := &projectAuditSlot{} + caps := hostcaps{st: st, projectAudit: slot} + reg := pluginRegistry{compiledRegistry: compiledRegistry{bus: bus}, pluginID: "rdm", caps: caps} + var seen string + if err := reg.AddCommandHandler(json.RawMessage(`{"id":"rdm.confirm","title":"Confirm"}`), func(_ context.Context, _ extension.Host, req extension.Request) (any, error) { + seen = req.OperationID + return "domain-committed", nil + }); err != nil { + t.Fatal(err) + } + resp := bus.Dispatch(context.Background(), cmdbus.Request{ID: "rdm.confirm", Actor: "alice", Owner: "alice", ConversationID: string(c.ID)}) + rows, _, _, err := st.ListProjectCommandAudits("alice", string(p.ID), 0, 0, 10) + if err != nil { + t.Fatal(err) + } + if seen == "" || resp.Receipt.OperationID != seen || len(rows) != 1 || rows[0].Envelope.OperationID != seen { + t.Fatalf("handler/domain correlation: seen=%q receipt=%+v rows=%+v", seen, resp.Receipt, rows) + } + if err := reg.RegisterProjectAuditAuthorizer(func(actor string, project core.ID) (bool, error) { return actor == "bob" && project == p.ID, nil }); err != nil { + t.Fatal(err) + } + if err := reg.RegisterProjectAuditLinkVerifier(func(_ context.Context, proof extension.ProjectAuditLinkProof) (bool, error) { + return proof.Owner == "alice" && proof.ProjectID == p.ID && proof.OperationID == seen && proof.SourceID == "domain-commit-1" && proof.ResourceID == "doc-1", nil + }); err != nil { + t.Fatal(err) + } + if err := reg.RegisterProjectAuditDisclosureAuthorizer(func(_ context.Context, actor string, r extension.ProjectAuditLinkedResource) (extension.ProjectAuditDisclosure, error) { + return extension.ProjectAuditDisclosure{Metadata: actor == "bob" && r.ResourceID == "doc-1"}, nil + }); err != nil { + t.Fatal(err) + } + publisher := inprocHost{caps: caps, owner: "alice", pluginID: "rdm"} + linked, err := publisher.PublishProjectAuditLink(context.Background(), extension.ProjectAuditLinkRequest{ProjectID: p.ID, OperationID: seen, SourceKind: "domain-commit", SourceID: "domain-commit-1", ResourceKind: "document", ResourceID: "doc-1", DisclosureClass: "metadata", IdempotencyKey: "outbox-1"}) + if err != nil || linked.HostAuditOffset != rows[0].Offset { + t.Fatalf("publish by trusted operation: %+v %v", linked, err) + } + bob := inprocHost{caps: caps, owner: "bob", actor: "bob", pluginID: "rdm"} + page, err := bob.QueryProjectAudit(context.Background(), extension.ProjectAuditQuery{ProjectID: p.ID, LinkedSourceKind: "domain-commit", LinkedSourceID: "domain-commit-1", LinkedHostOffset: linked.HostAuditOffset}) + if err != nil || len(page.Receipts) != 1 || page.Receipts[0].OperationID != seen { + t.Fatalf("linked read: %+v %v", page, err) + } +} diff --git a/internal/cmdbus/cmdbus.go b/internal/cmdbus/cmdbus.go index 9b63e7d..8507aa7 100644 --- a/internal/cmdbus/cmdbus.go +++ b/internal/cmdbus/cmdbus.go @@ -89,6 +89,7 @@ type Request struct { Actor string Owner string ConversationID string + OperationID string // overwritten by the trusted bus before handler execution AnchorMessageID string // 确认卡锚定的发起消息（内联渲染） Confirmed bool // 危险命令经确认卡放行后的执行 HostProjectID string // EXT-18：分发所属基座项目（空＝无项目上下文） @@ -279,12 +280,15 @@ func (b *Bus) Dispatch(ctx context.Context, req Request) Response { if !ok { return receipt(agentcommand.StateRejected, "", "no host handler bound for "+req.ID) } + // The domain handler can persist this trusted ID with its transaction/outbox. + // Never accept an ID from Params or the incoming Request. A handler failure + // still writes only a rejected audit receipt with no committed operation ID. + req.OperationID = fmt.Sprintf("op_%s_%d", strings.ReplaceAll(req.ID, ".", "_"), b.now().UnixNano()) payload, err := h(ctx, req) if err != nil { return receipt(agentcommand.StateRejected, "", "rejected: "+err.Error()) } - op := fmt.Sprintf("op_%s_%d", strings.ReplaceAll(strings.TrimPrefix(req.ID, ""), ".", "_"), b.now().UnixNano()) - return Response{Receipt: b.auditReceipt(req, agentcommand.StateCommitted, op, "", start), Payload: payload} + return Response{Receipt: b.auditReceipt(req, agentcommand.StateCommitted, req.OperationID, "", start), Payload: payload} } // Confirm 确认卡回道：actionID=confirm 执行挂起请求（entrance 归一 card），其余视为取消。 diff --git a/internal/cmdbus/cmdbus_test.go b/internal/cmdbus/cmdbus_test.go index 7b4e3f3..4d64948 100644 --- a/internal/cmdbus/cmdbus_test.go +++ b/internal/cmdbus/cmdbus_test.go @@ -87,6 +87,34 @@ func TestDispatchFourEntrancesSameAudit(t *testing.T) { } } +func TestHandlerReceivesCommittedOperationIDBeforeDomainWrite(t *testing.T) { + audit := &memAudit{} + bus := New(audit, nil, func() time.Time { return time.Unix(1700000000, 123).UTC() }) + var seen string + if err := bus.RegisterBuiltin(agentcommand.CommandSpec{ID: "rdm.confirm", Title: "Confirm"}, "", func(_ context.Context, req Request) (any, error) { + seen = req.OperationID + return "committed-domain-event", nil + }); err != nil { + t.Fatal(err) + } + resp := bus.Dispatch(context.Background(), Request{ID: "rdm.confirm", Actor: "alice", Owner: "alice", Params: map[string]any{"operationId": "forged-client-id"}}) + if seen == "" || seen == "forged-client-id" || resp.Receipt.OperationID != seen || len(audit.logs) != 1 || audit.logs[0].OperationID != seen { + t.Fatalf("operation correlation missing: handler=%q receipt=%+v audit=%+v", seen, resp.Receipt, audit.logs) + } + if err := bus.RegisterBuiltin(agentcommand.CommandSpec{ID: "rdm.fail", Title: "Fail"}, "", func(_ context.Context, req Request) (any, error) { + if req.OperationID == "" { + t.Fatal("handler must receive a tentative host operation ID") + } + return nil, errors.New("domain transaction rejected") + }); err != nil { + t.Fatal(err) + } + failed := bus.Dispatch(context.Background(), Request{ID: "rdm.fail", Actor: "alice", Owner: "alice"}) + if failed.Receipt.State != agentcommand.StateRejected || failed.Receipt.OperationID != "" || len(audit.logs) != 2 || audit.logs[1].OperationID != "" { + t.Fatalf("failed handler was marked committed: %+v audits=%+v", failed.Receipt, audit.logs) + } +} + func TestDispatchUnknownAndBadParams(t *testing.T) { a := &memAudit{} b := newTestBus(a, &memCards{}) diff --git a/internal/store/project_audit_links.go b/internal/store/project_audit_links.go index 5b58dd8..6d5c96f 100644 --- a/internal/store/project_audit_links.go +++ b/internal/store/project_audit_links.go @@ -23,6 +23,38 @@ type ProjectAuditLink struct { IdempotencyKey string } +// CommittedAuditOffset resolves exactly one persisted host receipt. A domain +// outbox can have the operation ID before the bus appends its audit row; no row +// yet is a retryable pending state, while duplicates are ambiguous and refused. +func (s *Store) CommittedAuditOffset(owner, projectID, operationID string) (int64, error) { + if owner == "" || projectID == "" || operationID == "" { + return 0, ErrNotFound + } + rows, err := s.db.Query(s.q(`SELECT id FROM command_audit WHERE owner=? AND project_id=? AND operation_id=? AND state='committed' ORDER BY id LIMIT 2`), owner, projectID, operationID) + if err != nil { + return 0, err + } + defer rows.Close() + var ids []int64 + for rows.Next() { + var id int64 + if err := rows.Scan(&id); err != nil { + return 0, err + } + ids = append(ids, id) + } + if err := rows.Err(); err != nil { + return 0, err + } + if len(ids) == 0 { + return 0, ErrNotFound + } + if len(ids) > 1 { + return 0, ErrConflict + } + return ids[0], nil +} + func (s *Store) CommandAuditForLink(owner string, offset int64) (ProjectCommandAuditRow, string, error) { var row ProjectCommandAuditRow var projectID, raw string diff --git a/internal/store/project_audit_links_test.go b/internal/store/project_audit_links_test.go index b77838c..64b5b07 100644 --- a/internal/store/project_audit_links_test.go +++ b/internal/store/project_audit_links_test.go @@ -32,6 +32,13 @@ func TestProjectAuditLinkStoreIdempotenceAndExactScope(t *testing.T) { if err != nil { t.Fatal(err) } + resolved, err := st.CommittedAuditOffset("alice", string(a.ID), "op-1") + if err != nil || resolved != rows[0].Offset { + t.Fatalf("trusted operation lookup: %d %v", resolved, err) + } + if _, err := st.CommittedAuditOffset("alice", string(a.ID), "op-pending"); !errors.Is(err, ErrNotFound) { + t.Fatalf("unrecorded operation should wait: %v", err) + } link := ProjectAuditLink{HostAuditOffset: rows[0].Offset, ProjectID: string(a.ID), Owner: "alice", SourceKind: "domain-commit", SourceID: "commit-1", OperationID: "op-1", ResourceKind: "document", ResourceID: "doc-1", DisclosureClass: "metadata", IdempotencyKey: "outbox-1"} first, err := st.SaveProjectAuditLink(link) if err != nil { @@ -81,4 +88,10 @@ func TestProjectAuditLinkStoreIdempotenceAndExactScope(t *testing.T) { if _, err := st.SaveProjectAuditLink(bobLink); err != nil { t.Fatalf("another owner may use the same outbox key: %v", err) } + if err := st.AppendAudit("alice", agentcommand.AuditEnvelope{Time: time.Now(), Actor: "alice", CommandID: "rdm.confirm", OperationID: "op-1", ConversationID: string(c.ID), State: agentcommand.StateCommitted}); err != nil { + t.Fatal(err) + } + if _, err := st.CommittedAuditOffset("alice", string(a.ID), "op-1"); !errors.Is(err, ErrConflict) { + t.Fatalf("ambiguous host operation must not choose one: %v", err) + } } diff --git a/pkg/extension/extension.go b/pkg/extension/extension.go index fca22f9..793f074 100644 --- a/pkg/extension/extension.go +++ b/pkg/extension/extension.go @@ -38,7 +38,9 @@ import ( // project-bound command-audit read slice and domain audit.read callback). // 2.14.0-experimental: X2 optional committed project-audit link publisher, // verifier, disclosure callback, and exact linked receipt read. -const SurfaceVersion = "2.14.0-experimental" +// 2.15.0-experimental: trusted Request.OperationID before handler execution and +// retryable ProjectAuditLinkRequest.HostAuditOffset=0 resolution. +const SurfaceVersion = "2.15.0-experimental" // ErrNotLinked 表示进程没有空白导入 link 包，Main 无法启动服务。 var ErrNotLinked = errors.New("extension: runner not linked; blank-import agent-system-backend/pkg/extension/link") diff --git a/pkg/extension/host.go b/pkg/extension/host.go index c528b81..134d61c 100644 --- a/pkg/extension/host.go +++ b/pkg/extension/host.go @@ -14,6 +14,9 @@ type Request struct { Actor string Owner string ConversationID string + // OperationID is generated by the trusted host bus before this handler runs. + // Persist it with an actual domain commit/outbox; never treat it as a retry key. + OperationID string // HostProjectID 本次分发所属基座项目（EXT-18 可选上下文；空＝无项目 // 上下文——API 入口无对话或对话未关联项目时为零值）。下游按显式映射 // 解析（如 RDM rdm_host_project_map），不得据此替代自身授权判定。 diff --git a/pkg/extension/project_audit.go b/pkg/extension/project_audit.go index e993508..0900efe 100644 --- a/pkg/extension/project_audit.go +++ b/pkg/extension/project_audit.go @@ -23,11 +23,15 @@ var ( ErrProjectAuditDenied = errors.New("extension: project audit denied") ErrProjectAuditUnsupported = errors.New("extension: project audit unsupported") ErrProjectAuditLinkConflict = errors.New("extension: project audit link conflict") + ErrProjectAuditPending = errors.New("extension: committed host audit receipt pending") ) // ProjectAuditLinkRequest binds one host command receipt to an already // committed domain fact. Owner is never caller supplied; the host handle and -// stored audit row establish it. This first slice supports domain-commit only. +// stored audit row establish it. HostAuditOffset=0 asks the host to resolve a +// unique committed row by its trusted owner/project/OperationID, which lets an +// outbox wait for the bus audit commit after the domain handler returns. This +// first slice supports domain-commit only. type ProjectAuditLinkRequest struct { ProjectID core.ID `json:"projectId"` HostAuditOffset int64 `json:"hostAuditOffset"` diff --git a/pkg/extension/surface.txt b/pkg/extension/surface.txt index 2e88d0e..6f06b8f 100644 --- a/pkg/extension/surface.txt +++ b/pkg/extension/surface.txt @@ -10,6 +10,7 @@ Compiled ErrNotLinked ErrProjectAuditDenied ErrProjectAuditLinkConflict +ErrProjectAuditPending ErrProjectAuditUnsupported Handler Host -- 2.54.0 From 0e8cd040cc75c329eb8950676acc7a9a08487ad2 Mon Sep 17 00:00:00 2001 From: weichen Date: Wed, 14 Oct 2026 04:29:38 +0000 Subject: [PATCH 05/41] Bind audit publishers and randomize operation IDs Why: Clock-derived IDs could collide and string-scoped hosts could impersonate a registered audit publisher. Evidence: Fixed-clock concurrent, ambiguous private offset, forged scoped-host, and registered publisher RED-to-GREEN tests; go test ./... -count=1 and targeted race test passed locally as SELF. Impact: Generate 192-bit host IDs, reject ambiguous explicit offsets, and issue a publication-only capability at verifier registration. Refs: Stage 5 W9; approved Stage 6 audit-link design adjustment r1; review of a8fa2fe --- .task/feature-rdm-two-trees-project-audit.md | 2 + internal/app/project_audit.go | 103 +++++++++++++------ internal/app/project_audit_link_test.go | 48 ++++++++- internal/app/surface_audit_actor_test.go | 10 +- internal/cmdbus/cmdbus.go | 11 +- internal/cmdbus/cmdbus_test.go | 32 ++++++ pkg/extension/extension.go | 4 +- pkg/extension/project_audit.go | 12 ++- pkg/extension/surface.txt | 2 + 9 files changed, 180 insertions(+), 44 deletions(-) diff --git a/.task/feature-rdm-two-trees-project-audit.md b/.task/feature-rdm-two-trees-project-audit.md index 6fb6a96..f72e33b 100644 --- a/.task/feature-rdm-two-trees-project-audit.md +++ b/.task/feature-rdm-two-trees-project-audit.md @@ -13,6 +13,8 @@ - Command audit stores the current verified account display name at write time; old rows expose `not-recorded`. Public receipts omit raw payload and parameter digest. Cursor uses project-and-owner scoped source cutoff. - Initial commit `c8dd169a1fdc1451fab3b475c14f9636a7f5bf6c` exposed only the actor-owned project slice. The next local increment fixes button actor propagation and adds a trusted domain-commit link publisher, verifier callback, exact linked metadata read, current `audit.read` and per-object metadata checks, and durable idempotency. Unlinked personal conversations remain private. - Trusted command dispatch now creates an operation ID before calling the compiled handler and passes that ID through `extension.Request`. The handler can commit the same ID with its domain event/outbox; the final Backend audit/receipt uses it. Client `params.operationId` is ignored. An outbox link request with `HostAuditOffset=0` resolves a unique committed host row by owner, fixed project, and operation ID; a missing row returns retryable `ErrProjectAuditPending`, while duplicate rows fail closed. The separate idempotency key still controls retry equivalence. +- Independent review of `a8fa2fe` found two P2 security defects: clock-based operation IDs could collide; and `NewScopedHost(owner,"rdm")` let another compiled plugin self-report the publisher's plugin ID. The new local increment uses 192 bits from `crypto/rand` for each host-generated operation ID. Both zero-offset and explicit-offset publication require a unique committed row for owner/project/operation; a historical duplicate rejects publication, including attempts to link another private command. Verifier registration returns a private `ProjectAuditPublisherFactory` for the registering plugin's background outbox; a generic scoped Host has no publisher method. Fixed-clock concurrent IDs, forged params, ambiguous private offset, forged scoped Host, and legitimate registered publisher each have focused tests. +- The minted publisher exposes only `ProjectAuditPublisher`, not the full owner-scoped `Host`; tests reject attempts to use `NewScopedHost` with a self-reported `rdm` string as publisher authority. A publisher is a registration-time capability, while `IdempotencyKey` remains the separate retry identity. - Exact-source linked reads do not enumerate hidden links or reveal raw payload, private conversation ID, or content. Body disclosure and a broad project link list are not implemented; the public coverage reports the narrower capability. ## Verification and remaining work diff --git a/internal/app/project_audit.go b/internal/app/project_audit.go index 4b5101b..8a005cc 100644 --- a/internal/app/project_audit.go +++ b/internal/app/project_audit.go @@ -13,11 +13,41 @@ import ( // projectAuditSlot binds the audit.read policy to its registering domain plugin. // A different plugin cannot borrow that policy through its own Host handle. type projectAuditSlot struct { - mu sync.RWMutex - holder string - check extension.ProjectAuditAuthorizer - verifier extension.ProjectAuditLinkVerifier - disclose extension.ProjectAuditDisclosureAuthorizer + mu sync.RWMutex + holder string + check extension.ProjectAuditAuthorizer + verifier extension.ProjectAuditLinkVerifier + disclose extension.ProjectAuditDisclosureAuthorizer + publisherToken *auditPublisherToken +} + +// This identity is available only to the publisher factory returned at +// registration. A caller-provided pluginID cannot manufacture the pointer. +type auditPublisherToken struct{ marker byte } + +type projectAuditPublisherFactory struct { + caps hostcaps + pluginID string + token *auditPublisherToken +} + +func (f projectAuditPublisherFactory) ForOwner(owner string) (extension.ProjectAuditPublisher, error) { + if owner == "" || f.token == nil { + return nil, extension.ErrProjectAuditDenied + } + return projectAuditPublisher{caps: f.caps, owner: owner, pluginID: f.pluginID, token: f.token}, nil +} + +type projectAuditPublisher struct { + caps hostcaps + owner string + pluginID string + token *auditPublisherToken +} + +func (p projectAuditPublisher) PublishProjectAuditLink(ctx context.Context, req extension.ProjectAuditLinkRequest) (extension.ProjectAuditLinkReceipt, error) { + h := inprocHost{caps: p.caps, owner: p.owner, pluginID: p.pluginID} + return h.publishProjectAuditLink(ctx, req, p.token) } func (s *projectAuditSlot) register(pluginID string, check extension.ProjectAuditAuthorizer) error { @@ -33,17 +63,18 @@ func (s *projectAuditSlot) register(pluginID string, check extension.ProjectAudi return nil } -func (s *projectAuditSlot) registerVerifier(pluginID string, verify extension.ProjectAuditLinkVerifier) error { +func (s *projectAuditSlot) registerVerifier(pluginID string, verify extension.ProjectAuditLinkVerifier) (*auditPublisherToken, error) { if pluginID == "" || verify == nil { - return extension.ErrProjectAuditUnsupported + return nil, extension.ErrProjectAuditUnsupported } s.mu.Lock() defer s.mu.Unlock() if s.verifier != nil || (s.holder != "" && s.holder != pluginID) { - return errors.New("extension: project audit verifier already registered") + return nil, errors.New("extension: project audit verifier already registered") } s.holder, s.verifier = pluginID, verify - return nil + s.publisherToken = &auditPublisherToken{marker: 1} + return s.publisherToken, nil } func (s *projectAuditSlot) registerDisclosure(pluginID string, disclose extension.ProjectAuditDisclosureAuthorizer) error { @@ -78,17 +109,21 @@ func (r recordRegistry) RegisterProjectAuditAuthorizer(check extension.ProjectAu return reg.RegisterProjectAuditAuthorizer(check) } -func (r compiledRegistry) RegisterProjectAuditLinkVerifier(extension.ProjectAuditLinkVerifier) error { - return errors.New("extension: declarative plugins cannot register project audit link verifiers") +func (r compiledRegistry) RegisterProjectAuditLinkVerifier(extension.ProjectAuditLinkVerifier) (extension.ProjectAuditPublisherFactory, error) { + return nil, errors.New("extension: declarative plugins cannot register project audit link verifiers") } func (r compiledRegistry) RegisterProjectAuditDisclosureAuthorizer(extension.ProjectAuditDisclosureAuthorizer) error { return errors.New("extension: declarative plugins cannot register project audit disclosure authorizers") } -func (r pluginRegistry) RegisterProjectAuditLinkVerifier(verify extension.ProjectAuditLinkVerifier) error { +func (r pluginRegistry) RegisterProjectAuditLinkVerifier(verify extension.ProjectAuditLinkVerifier) (extension.ProjectAuditPublisherFactory, error) { if r.caps.projectAudit == nil { - return extension.ErrProjectAuditUnsupported + return nil, extension.ErrProjectAuditUnsupported } - return r.caps.projectAudit.registerVerifier(r.pluginID, verify) + token, err := r.caps.projectAudit.registerVerifier(r.pluginID, verify) + if err != nil { + return nil, err + } + return projectAuditPublisherFactory{caps: r.caps, pluginID: r.pluginID, token: token}, nil } func (r pluginRegistry) RegisterProjectAuditDisclosureAuthorizer(disclose extension.ProjectAuditDisclosureAuthorizer) error { if r.caps.projectAudit == nil { @@ -96,10 +131,10 @@ func (r pluginRegistry) RegisterProjectAuditDisclosureAuthorizer(disclose extens } return r.caps.projectAudit.registerDisclosure(r.pluginID, disclose) } -func (r recordRegistry) RegisterProjectAuditLinkVerifier(verify extension.ProjectAuditLinkVerifier) error { +func (r recordRegistry) RegisterProjectAuditLinkVerifier(verify extension.ProjectAuditLinkVerifier) (extension.ProjectAuditPublisherFactory, error) { reg, ok := r.Registry.(extension.ProjectAuditLinkRegistry) if !ok { - return extension.ErrProjectAuditUnsupported + return nil, extension.ErrProjectAuditUnsupported } return reg.RegisterProjectAuditLinkVerifier(verify) } @@ -112,9 +147,10 @@ func (r recordRegistry) RegisterProjectAuditDisclosureAuthorizer(disclose extens } var _ extension.ProjectAuditHost = inprocHost{} -var _ extension.ProjectAuditPublisher = inprocHost{} +var _ extension.ProjectAuditPublisher = projectAuditPublisher{} +var _ extension.ProjectAuditPublisherFactory = projectAuditPublisherFactory{} -func (h inprocHost) PublishProjectAuditLink(ctx context.Context, req extension.ProjectAuditLinkRequest) (extension.ProjectAuditLinkReceipt, error) { +func (h inprocHost) publishProjectAuditLink(ctx context.Context, req extension.ProjectAuditLinkRequest, capability *auditPublisherToken) (extension.ProjectAuditLinkReceipt, error) { if err := ctx.Err(); err != nil { return extension.ProjectAuditLinkReceipt{}, err } @@ -123,27 +159,34 @@ func (h inprocHost) PublishProjectAuditLink(ctx context.Context, req extension.P } slot := h.caps.projectAudit slot.mu.RLock() - holder, verify := slot.holder, slot.verifier + holder, verify, registeredToken := slot.holder, slot.verifier, slot.publisherToken slot.mu.RUnlock() - if holder != h.pluginID || verify == nil { + if holder != h.pluginID || verify == nil || registeredToken == nil || capability != registeredToken { return extension.ProjectAuditLinkReceipt{}, extension.ErrProjectAuditUnsupported } if h.owner == "" || (h.actor != "" && h.actor != h.owner) || req.HostAuditOffset < 0 || req.ProjectID == "" || req.SourceKind != "domain-commit" || req.SourceID == "" || req.OperationID == "" || req.ResourceKind == "" || req.ResourceID == "" || req.DisclosureClass != "metadata" || req.IdempotencyKey == "" { return extension.ProjectAuditLinkReceipt{}, extension.ErrProjectAuditDenied } - if req.HostAuditOffset == 0 { - resolved, err := h.caps.st.CommittedAuditOffset(h.owner, string(req.ProjectID), req.OperationID) - if errors.Is(err, store.ErrNotFound) { + // An explicit offset is only a locator. A historical collision or a forged + // offset must not turn a private command with the same operation ID into a + // published project receipt. + resolved, err := h.caps.st.CommittedAuditOffset(h.owner, string(req.ProjectID), req.OperationID) + if errors.Is(err, store.ErrNotFound) { + if req.HostAuditOffset == 0 { return extension.ProjectAuditLinkReceipt{}, extension.ErrProjectAuditPending } - if errors.Is(err, store.ErrConflict) { - return extension.ProjectAuditLinkReceipt{}, extension.ErrProjectAuditLinkConflict - } - if err != nil { - return extension.ProjectAuditLinkReceipt{}, err - } - req.HostAuditOffset = resolved + return extension.ProjectAuditLinkReceipt{}, extension.ErrProjectAuditDenied } + if errors.Is(err, store.ErrConflict) { + return extension.ProjectAuditLinkReceipt{}, extension.ErrProjectAuditLinkConflict + } + if err != nil { + return extension.ProjectAuditLinkReceipt{}, err + } + if req.HostAuditOffset != 0 && req.HostAuditOffset != resolved { + return extension.ProjectAuditLinkReceipt{}, extension.ErrProjectAuditLinkConflict + } + req.HostAuditOffset = resolved row, projectID, err := h.caps.st.CommandAuditForLink(h.owner, req.HostAuditOffset) if errors.Is(err, store.ErrNotFound) { return extension.ProjectAuditLinkReceipt{}, extension.ErrProjectAuditDenied diff --git a/internal/app/project_audit_link_test.go b/internal/app/project_audit_link_test.go index 8c805ca..8668fed 100644 --- a/internal/app/project_audit_link_test.go +++ b/internal/app/project_audit_link_test.go @@ -56,9 +56,10 @@ func TestProjectAuditLinkSharesOnlyVerifiedCommittedMetadata(t *testing.T) { }); err != nil { t.Fatal(err) } - if err := reg.RegisterProjectAuditLinkVerifier(func(_ context.Context, proof extension.ProjectAuditLinkProof) (bool, error) { + publisherFactory, err := (recordRegistry{Registry: reg}).RegisterProjectAuditLinkVerifier(func(_ context.Context, proof extension.ProjectAuditLinkProof) (bool, error) { return proof.Owner == "alice" && proof.ProjectID == p.ID && proof.SourceKind == "domain-commit" && proof.SourceID == "commit-1" && proof.OperationID == "op-1" && proof.ResourceKind == "document" && proof.ResourceID == "doc-1", nil - }); err != nil { + }) + if err != nil { t.Fatal(err) } metadataAllowed := true @@ -72,8 +73,27 @@ func TestProjectAuditLinkSharesOnlyVerifiedCommittedMetadata(t *testing.T) { if _, err := bob.QueryProjectAudit(context.Background(), q); !errors.Is(err, extension.ErrProjectAuditDenied) { t.Fatalf("unlinked private audit: %v", err) } - alicePublisher := inprocHost{caps: caps, pluginID: "rdm", owner: "alice"} // trusted outbox-scoped host + alicePublisher, err := publisherFactory.ForOwner("alice") // capability retained by trusted RDM outbox + if err != nil { + t.Fatal(err) + } + if _, ok := alicePublisher.(extension.Host); ok { + t.Fatal("publisher factory exposed a full owner-scoped Host") + } linkReq := extension.ProjectAuditLinkRequest{ProjectID: p.ID, SourceKind: "domain-commit", SourceID: "commit-1", OperationID: "op-1", ResourceKind: "document", ResourceID: "doc-1", DisclosureClass: "metadata", IdempotencyKey: "outbox-1"} + // A different compiled plugin can call the public scoped-host factory with + // "rdm" as text. That must not mint RDM's audit publication authority. + wireScopedHostFactory(caps) + t.Cleanup(func() { extension.SetScopedHostFactory(nil) }) + forged, err := extension.NewScopedHost("alice", "rdm") + if err != nil { + t.Fatal(err) + } + if publisher, ok := forged.(extension.ProjectAuditPublisher); ok { + if _, err := publisher.PublishProjectAuditLink(context.Background(), linkReq); !errors.Is(err, extension.ErrProjectAuditUnsupported) { + t.Fatalf("self-reported plugin ID minted audit publisher: %v", err) + } + } if rows, err := bob.QueryProjectAudit(context.Background(), extension.ProjectAuditQuery{ProjectID: p.ID}); err != nil || len(rows.Receipts) != 0 { t.Fatalf("private owner row visible without exact link: %+v %v", rows, err) } @@ -88,8 +108,8 @@ func TestProjectAuditLinkSharesOnlyVerifiedCommittedMetadata(t *testing.T) { if _, err := alicePublisher.PublishProjectAuditLink(context.Background(), uncommitted); !errors.Is(err, extension.ErrProjectAuditDenied) { t.Fatalf("uncommitted source: %v", err) } - if _, err := (inprocHost{caps: caps, pluginID: "other", owner: "alice"}).PublishProjectAuditLink(context.Background(), linkReq); !errors.Is(err, extension.ErrProjectAuditUnsupported) { - t.Fatalf("other plugin: %v", err) + if _, err := (pluginRegistry{pluginID: "other", caps: caps}).RegisterProjectAuditLinkVerifier(func(context.Context, extension.ProjectAuditLinkProof) (bool, error) { return true, nil }); err == nil { + t.Fatal("other plugin replaced the registered verifier") } pending := linkReq pending.OperationID, pending.IdempotencyKey = "op-not-yet-recorded", "outbox-pending" @@ -121,6 +141,24 @@ func TestProjectAuditLinkSharesOnlyVerifiedCommittedMetadata(t *testing.T) { if strings.Contains(string(raw), "secret-digest") || strings.Contains(string(raw), string(c.ID)) { t.Fatalf("private receipt fields leaked: %s", raw) } + if err := st.AppendAudit("alice", agentcommand.AuditEnvelope{Time: time.Now(), Actor: "alice", CommandID: "private.note", OperationID: "op-1", ConversationID: string(c.ID), State: agentcommand.StateCommitted}); err != nil { + t.Fatal(err) + } + duplicates, _, _, err := st.ListProjectCommandAudits("alice", string(p.ID), 0, 0, 10) + if err != nil { + t.Fatal(err) + } + privateOffset := duplicates[0].Offset + mislink := linkReq + mislink.HostAuditOffset, mislink.IdempotencyKey = privateOffset, "outbox-private" + if _, err := alicePublisher.PublishProjectAuditLink(context.Background(), mislink); !errors.Is(err, extension.ErrProjectAuditLinkConflict) { + t.Fatalf("ambiguous operation linked a private command: %v", err) + } + privateQuery := q + privateQuery.LinkedHostOffset = privateOffset + if _, err := bob.QueryProjectAudit(context.Background(), privateQuery); !errors.Is(err, extension.ErrProjectAuditDenied) { + t.Fatalf("private command disclosed through ambiguous operation: %v", err) + } metadataAllowed = false if _, err := bob.QueryProjectAudit(context.Background(), q); !errors.Is(err, extension.ErrProjectAuditDenied) { t.Fatalf("revoked object metadata: %v", err) diff --git a/internal/app/surface_audit_actor_test.go b/internal/app/surface_audit_actor_test.go index d57eae1..b4f3fb3 100644 --- a/internal/app/surface_audit_actor_test.go +++ b/internal/app/surface_audit_actor_test.go @@ -88,9 +88,10 @@ func TestCompiledHandlerReceivesHostOperationID(t *testing.T) { if err := reg.RegisterProjectAuditAuthorizer(func(actor string, project core.ID) (bool, error) { return actor == "bob" && project == p.ID, nil }); err != nil { t.Fatal(err) } - if err := reg.RegisterProjectAuditLinkVerifier(func(_ context.Context, proof extension.ProjectAuditLinkProof) (bool, error) { + publisherFactory, err := (recordRegistry{Registry: reg}).RegisterProjectAuditLinkVerifier(func(_ context.Context, proof extension.ProjectAuditLinkProof) (bool, error) { return proof.Owner == "alice" && proof.ProjectID == p.ID && proof.OperationID == seen && proof.SourceID == "domain-commit-1" && proof.ResourceID == "doc-1", nil - }); err != nil { + }) + if err != nil { t.Fatal(err) } if err := reg.RegisterProjectAuditDisclosureAuthorizer(func(_ context.Context, actor string, r extension.ProjectAuditLinkedResource) (extension.ProjectAuditDisclosure, error) { @@ -98,7 +99,10 @@ func TestCompiledHandlerReceivesHostOperationID(t *testing.T) { }); err != nil { t.Fatal(err) } - publisher := inprocHost{caps: caps, owner: "alice", pluginID: "rdm"} + publisher, err := publisherFactory.ForOwner("alice") + if err != nil { + t.Fatal(err) + } linked, err := publisher.PublishProjectAuditLink(context.Background(), extension.ProjectAuditLinkRequest{ProjectID: p.ID, OperationID: seen, SourceKind: "domain-commit", SourceID: "domain-commit-1", ResourceKind: "document", ResourceID: "doc-1", DisclosureClass: "metadata", IdempotencyKey: "outbox-1"}) if err != nil || linked.HostAuditOffset != rows[0].Offset { t.Fatalf("publish by trusted operation: %+v %v", linked, err) diff --git a/internal/cmdbus/cmdbus.go b/internal/cmdbus/cmdbus.go index 8507aa7..3fb4a14 100644 --- a/internal/cmdbus/cmdbus.go +++ b/internal/cmdbus/cmdbus.go @@ -5,6 +5,7 @@ package cmdbus import ( "context" + "crypto/rand" "crypto/sha256" "encoding/hex" "encoding/json" @@ -281,9 +282,13 @@ func (b *Bus) Dispatch(ctx context.Context, req Request) Response { return receipt(agentcommand.StateRejected, "", "no host handler bound for "+req.ID) } // The domain handler can persist this trusted ID with its transaction/outbox. - // Never accept an ID from Params or the incoming Request. A handler failure - // still writes only a rejected audit receipt with no committed operation ID. - req.OperationID = fmt.Sprintf("op_%s_%d", strings.ReplaceAll(req.ID, ".", "_"), b.now().UnixNano()) + // Entropy, not the clock or caller Params, distinguishes concurrent operations. + // A handler failure still writes only a rejected audit receipt without an ID. + var opBytes [24]byte + if _, err := rand.Read(opBytes[:]); err != nil { + return receipt(agentcommand.StateUnknown, "", "operation ID unavailable") + } + req.OperationID = "op_" + hex.EncodeToString(opBytes[:]) payload, err := h(ctx, req) if err != nil { return receipt(agentcommand.StateRejected, "", "rejected: "+err.Error()) diff --git a/internal/cmdbus/cmdbus_test.go b/internal/cmdbus/cmdbus_test.go index 4d64948..90d5c63 100644 --- a/internal/cmdbus/cmdbus_test.go +++ b/internal/cmdbus/cmdbus_test.go @@ -115,6 +115,38 @@ func TestHandlerReceivesCommittedOperationIDBeforeDomainWrite(t *testing.T) { } } +func TestOperationIDsRemainUniqueWithFixedClockAndConcurrentDispatch(t *testing.T) { + audit := &memAudit{} + bus := New(audit, nil, func() time.Time { return time.Unix(1700000000, 123).UTC() }) + if err := bus.RegisterBuiltin(agentcommand.CommandSpec{ID: "rdm.confirm", Title: "Confirm"}, "", func(_ context.Context, req Request) (any, error) { + return req.OperationID, nil + }); err != nil { + t.Fatal(err) + } + const count = 64 + var wg sync.WaitGroup + ids := make([]string, count) + for i := range ids { + wg.Add(1) + go func(i int) { + defer wg.Done() + resp := bus.Dispatch(context.Background(), Request{ID: "rdm.confirm", Actor: "alice", Owner: "alice"}) + ids[i] = resp.Receipt.OperationID + }(i) + } + wg.Wait() + seen := map[string]bool{} + for _, id := range ids { + if id == "" || seen[id] { + t.Fatalf("fixed clock produced a missing or duplicate trusted operation ID: %q", id) + } + seen[id] = true + } + if len(audit.logs) != count { + t.Fatalf("audit rows=%d want=%d", len(audit.logs), count) + } +} + func TestDispatchUnknownAndBadParams(t *testing.T) { a := &memAudit{} b := newTestBus(a, &memCards{}) diff --git a/pkg/extension/extension.go b/pkg/extension/extension.go index 793f074..1812671 100644 --- a/pkg/extension/extension.go +++ b/pkg/extension/extension.go @@ -40,7 +40,9 @@ import ( // verifier, disclosure callback, and exact linked receipt read. // 2.15.0-experimental: trusted Request.OperationID before handler execution and // retryable ProjectAuditLinkRequest.HostAuditOffset=0 resolution. -const SurfaceVersion = "2.15.0-experimental" +// 2.16.0-experimental: cryptographic operation IDs and registration-bound +// ProjectAuditPublisherFactory; scoped Host string IDs cannot publish links. +const SurfaceVersion = "2.16.0-experimental" // ErrNotLinked 表示进程没有空白导入 link 包，Main 无法启动服务。 var ErrNotLinked = errors.New("extension: runner not linked; blank-import agent-system-backend/pkg/extension/link") diff --git a/pkg/extension/project_audit.go b/pkg/extension/project_audit.go index 0900efe..ddca97c 100644 --- a/pkg/extension/project_audit.go +++ b/pkg/extension/project_audit.go @@ -76,10 +76,18 @@ type ProjectAuditDisclosure struct { type ProjectAuditDisclosureAuthorizer func(context.Context, string, ProjectAuditLinkedResource) (ProjectAuditDisclosure, error) +// ProjectAuditPublisherFactory is issued only by successful verifier +// registration. A domain outbox may retain it and bind an owner for each job; +// owner and committed-source attribution are checked again when publishing. +// NewScopedHost(owner, pluginID) cannot mint this capability. +type ProjectAuditPublisherFactory interface { + ForOwner(owner string) (ProjectAuditPublisher, error) +} + // ProjectAuditLinkRegistry is optional. Only the registering compiled domain -// plugin may publish or read its links. +// plugin receives a publisher factory; string plugin IDs carry no authority. type ProjectAuditLinkRegistry interface { - RegisterProjectAuditLinkVerifier(ProjectAuditLinkVerifier) error + RegisterProjectAuditLinkVerifier(ProjectAuditLinkVerifier) (ProjectAuditPublisherFactory, error) RegisterProjectAuditDisclosureAuthorizer(ProjectAuditDisclosureAuthorizer) error } diff --git a/pkg/extension/surface.txt b/pkg/extension/surface.txt index 6f06b8f..7d5f851 100644 --- a/pkg/extension/surface.txt +++ b/pkg/extension/surface.txt @@ -54,6 +54,8 @@ ProjectAuditLinkedResource ProjectAuditPage ProjectAuditPublisher ProjectAuditPublisher.PublishProjectAuditLink +ProjectAuditPublisherFactory +ProjectAuditPublisherFactory.ForOwner ProjectAuditQuery ProjectAuditRegistry ProjectAuditRegistry.RegisterProjectAuditAuthorizer -- 2.54.0 From 5f62b3d2261d9a78e7881595ec5fe2eafb9e7446 Mon Sep 17 00:00:00 2001 From: weichen Date: Wed, 14 Oct 2026 04:33:05 +0000 Subject: [PATCH 06/41] Protect project context from stale history and forged receipts Why: Revoked project material could remain in later model turns, and plugin Audit could impersonate a model-input manifest. Evidence: SELF red tests reproduced both paths; updated project revocation, trusted receipt, migration, and entrypoint tests pass locally with go test ./... -count=1 and targeted race checks. Impact: Rebuild direct model requests after scope changes, sanitize or block unproven generic history, omit legacy project injections, and persist manifests in a dedicated state-checked table. Refs: TT-C02 TT-C03 TT-C04; stage5 W6; review P1 stale context and manifest provenance --- cmd/storage-migrate/main.go | 4 +- internal/app/hostcaps.go | 3 + internal/app/project_context_test.go | 40 ++++- internal/runmgr/project_context_test.go | 6 +- internal/runtime/llm.go | 42 +++-- internal/runtime/llm_direct.go | 29 +++- internal/runtime/project_context_test.go | 174 ++++++++++++++++++++- internal/runtime/project_stream.go | 61 +++++++- internal/runtime/workflow_compiled_test.go | 19 ++- internal/store/context_manifest.go | 47 +++++- internal/store/context_manifest_test.go | 38 +++++ internal/store/migrate.go | 7 + internal/store/migrate_compat.go | 1 + 13 files changed, 428 insertions(+), 43 deletions(-) create mode 100644 internal/store/context_manifest_test.go diff --git a/cmd/storage-migrate/main.go b/cmd/storage-migrate/main.go index 2229194..49206c6 100644 --- a/cmd/storage-migrate/main.go +++ b/cmd/storage-migrate/main.go @@ -287,7 +287,7 @@ var copyOrder = []string{ "activity_cards", "project_event_shares", "command_audit", "prompt_modules", "sessions", "api_keys", "plugin_grants", "plugin_schema", "plugin_kv", "background_tasks", "work_task_bindings", - "memory_entries", "audit_events", "pending_confirms", "llm_usage_daily", + "memory_entries", "audit_events", "context_manifests", "pending_confirms", "llm_usage_daily", "secret_keys", "settings_snapshots", "regen_pending", "context_entries", "user_commands", "pending_notices", "recovery_holds", "surfaces", "surface_revisions", "surface_actions", "plugin_activation", @@ -784,7 +784,7 @@ func advanceSequences(db *sql.DB, table string) error { // checkOwners：业务行引用的 owner 必须存在于 users（单租户默认 ”/'local' // 除外）。未知 owner 阻塞迁移（U4/R7：不静默带过未知归属）。 func checkOwners(db *sql.DB, src *sql.DB) error { - ownerTables := []string{"projects", "conversations", "runs", "artifacts", "knowledge", "hitl_cards", "profiles", "activity_cards", "project_event_shares", "command_audit", "work_task_bindings"} + ownerTables := []string{"projects", "conversations", "runs", "artifacts", "knowledge", "hitl_cards", "profiles", "activity_cards", "project_event_shares", "command_audit", "work_task_bindings", "context_manifests"} for _, t := range ownerTables { if !sqliteHasTable(src, t) { continue diff --git a/internal/app/hostcaps.go b/internal/app/hostcaps.go index 890adb6..40025bb 100644 --- a/internal/app/hostcaps.go +++ b/internal/app/hostcaps.go @@ -274,6 +274,9 @@ func (h inprocHost) KVGet(key string) (string, bool, error) { } func (h inprocHost) Audit(action, target, evidence string) error { + if strings.HasPrefix(action, "model.context_manifest") { + return fmt.Errorf("extension: model context manifest is a reserved host receipt") + } return h.caps.st.AppendAuditEvent(store.AuditEvent{ Owner: h.owner, Actor: "plugin:" + h.pluginID, Action: action, Target: target, Evidence: evidence, diff --git a/internal/app/project_context_test.go b/internal/app/project_context_test.go index 833615b..4b40b36 100644 --- a/internal/app/project_context_test.go +++ b/internal/app/project_context_test.go @@ -298,7 +298,7 @@ func TestCompleteForWorkReadsOnlyCurrentBundleEvidence(t *testing.T) { if err != nil { t.Fatal(err) } - var sent string + var sent []string model := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { var body struct { Messages []struct { @@ -306,9 +306,11 @@ func TestCompleteForWorkReadsOnlyCurrentBundleEvidence(t *testing.T) { } `json:"messages"` } _ = json.NewDecoder(r.Body).Decode(&body) + var input string for _, m := range body.Messages { - sent += m.Content + input += m.Content } + sent = append(sent, input) _, _ = w.Write([]byte(`{"choices":[{"message":{"content":"done"}}]}`)) })) defer model.Close() @@ -321,16 +323,17 @@ func TestCompleteForWorkReadsOnlyCurrentBundleEvidence(t *testing.T) { contexts := &projectContextSlot{} ref := extension.ProjectEvidenceRef{ID: "ref-1", SourceID: "doc-1", Revision: "r2", Hash: "source-hash"} readCalls := 0 + readText, authEpoch := "current restricted detail", "duty-1" provider := testProjectContextProvider{ resolve: func(req extension.ProjectContextRequest) (extension.ProjectContextBundle, error) { - return extension.ProjectContextBundle{Status: extension.ProjectContextReady, ProjectID: req.ProjectID, Evidence: []extension.ProjectEvidenceRef{ref}}, nil + return extension.ProjectContextBundle{Status: extension.ProjectContextReady, ProjectID: req.ProjectID, AuthorizationEpoch: authEpoch, PublicationEpoch: "pub-1", Evidence: []extension.ProjectEvidenceRef{ref}}, nil }, read: func(req extension.ProjectEvidenceRequest) (extension.ProjectEvidence, error) { readCalls++ if req.Reference != ref || req.Scope.ProjectID != core.ID(p.ID) { t.Errorf("untrusted evidence scope: %+v", req) } - return extension.ProjectEvidence{Reference: req.Reference, Text: "current restricted detail"}, nil + return extension.ProjectEvidence{Reference: req.Reference, Text: readText}, nil }, } if err := (pluginRegistry{pluginID: "rdm", caps: hostcaps{contexts: contexts}}).RegisterProjectContextProvider(provider); err != nil { @@ -338,10 +341,37 @@ func TestCompleteForWorkReadsOnlyCurrentBundleEvidence(t *testing.T) { } h := inprocHost{caps: hostcaps{st: st, set: set, projects: projects, contexts: contexts}, pluginID: "rdm", owner: "alice", actor: "alice", conversationID: conv.ID, hostProjectID: p.ID} result, err := h.CompleteForWork(context.Background(), extension.WorkCompletionRequest{Goal: "Write", EvidenceRefs: []string{"ref-1"}}) - if err != nil || !strings.Contains(sent, "current restricted detail") || len(result.Manifest.ReadEvidence) != 1 || readCalls != 2 { + if err != nil || len(sent) != 1 || !strings.Contains(sent[0], "current restricted detail") || len(result.Manifest.ReadEvidence) != 1 || readCalls != 2 { t.Fatalf("requested evidence did not reach model under reauthorization: err=%v sent=%q manifest=%+v reads=%d", err, sent, result.Manifest, readCalls) } if _, err := h.CompleteForWork(context.Background(), extension.WorkCompletionRequest{Goal: "Write", EvidenceRefs: []string{"arbitrary-path"}}); err == nil || readCalls != 2 { t.Fatal("arbitrary evidence reference reached provider") } + readText, authEpoch = "new public detail", "duty-2" + if _, err := h.CompleteForWork(context.Background(), extension.WorkCompletionRequest{Goal: "Write", EvidenceRefs: []string{"ref-1"}}); err != nil || len(sent) != 2 || strings.Contains(sent[1], "current restricted detail") || !strings.Contains(sent[1], "new public detail") { + t.Fatalf("same Host reused old evidence after duty change: err=%v sent=%q", err, sent) + } +} + +func TestPluginAuditCannotForgeOrCorruptContextManifest(t *testing.T) { + st, err := store.OpenSQLite(filepath.Join(t.TempDir(), "manifest.db")) + if err != nil { + t.Fatal(err) + } + defer st.Close() + good := extension.ProjectContextManifest{ProjectID: "p1", AttemptID: "attempt-1", Delivery: "attempted", InputSHA256: "sha-good"} + if err := st.AppendContextManifest("alice", "run-1", good); err != nil { + t.Fatal(err) + } + h := inprocHost{caps: hostcaps{st: st}, pluginID: "malicious", owner: "alice"} + if err := h.Audit("model.context_manifest", "run-1", `{"Delivery":"responded","InputSHA256":"forged"}`); err == nil { + t.Fatal("plugin forged a trusted model manifest action") + } + if err := st.AppendAuditEvent(store.AuditEvent{Owner: "alice", Action: "model.context_manifest", Target: "run-1", Evidence: "not-json"}); err != nil { + t.Fatal(err) + } + got, err := st.ListContextManifests("alice", "run-1") + if err != nil || len(got) != 1 || got[0].InputSHA256 != "sha-good" { + t.Fatalf("untrusted audit row corrupted manifest reader: got=%+v err=%v", got, err) + } } diff --git a/internal/runmgr/project_context_test.go b/internal/runmgr/project_context_test.go index 94f6a4e..3177358 100644 --- a/internal/runmgr/project_context_test.go +++ b/internal/runmgr/project_context_test.go @@ -76,7 +76,7 @@ func TestContextManifestPersistsByOwnerAndRun(t *testing.T) { conv := recoveryConversation(t, st) run := recoveryRun(t, st, conv, core.RunPending) rc := &runCtx{mgr: m, run: run, ctx: context.Background()} - manifest := extension.ProjectContextManifest{ProjectID: run.ProjectID, Version: "v3", Model: "model-1", InputSHA256: "abc", Included: []extension.ProjectContextManifestEntry{{SourceID: "s1", Revision: "r2", InputSHA256: "def"}}} + manifest := extension.ProjectContextManifest{ProjectID: run.ProjectID, Version: "v3", Model: "model-1", AttemptID: "attempt-1", Delivery: "attempted", InputSHA256: "abc", Included: []extension.ProjectContextManifestEntry{{SourceID: "s1", Revision: "r2", InputSHA256: "def"}}} if err := rc.SaveContextManifest(context.Background(), manifest); err != nil { t.Fatal(err) } @@ -110,7 +110,7 @@ func TestContextManifestRejectsDocumentDutyRevocationBeforeSend(t *testing.T) { if err != nil { t.Fatal(err) } - manifest.InputSHA256 = "request-hash" + manifest.InputSHA256, manifest.AttemptID, manifest.Delivery = "request-hash", "attempt-revoked", "attempted" epoch = "duty-2" // project work remains allowed; document duty changed if err := rc.SaveContextManifest(context.Background(), manifest); err == nil { t.Fatal("stale document duty accepted at model send") @@ -161,7 +161,7 @@ func TestProjectEvidenceOnlyReadsCurrentBundleReference(t *testing.T) { if _, err := rc.ProjectEvidence(context.Background(), "ref-1"); err == nil || read != 1 { t.Fatal("revoked reference reached provider") } - if err := rc.SaveContextManifest(context.Background(), extension.ProjectContextManifest{ProjectID: run.ProjectID, InputSHA256: "new-request-hash"}); err == nil { + if err := rc.SaveContextManifest(context.Background(), extension.ProjectContextManifest{ProjectID: run.ProjectID, InputSHA256: "new-request-hash", AttemptID: "attempt-revoked", Delivery: "attempted"}); err == nil { t.Fatal("new model request accepted after an earlier evidence read was revoked") } } diff --git a/internal/runtime/llm.go b/internal/runtime/llm.go index 8f7e654..fce32b0 100644 --- a/internal/runtime/llm.go +++ b/internal/runtime/llm.go @@ -232,6 +232,7 @@ func weekdayCN(t time.Time) string { func (l *LLMRunner) Execute(rc RunCtx) error { eff := rc.Settings() prof := rc.Profile() + projectMode := projectContextEnabled(rc) route := ResolveChatModel(prof, eff) if route.Model == "" || route.Base == "" { return fmt.Errorf("llm: 主模型未配置（当前解析：model=%q base=%q；检查 settings.models.chat 与画像 ModelRoute；演示模式可开 runtime.mock）", route.Model, route.Base) @@ -254,7 +255,7 @@ func (l *LLMRunner) Execute(rc RunCtx) error { // 知识注入：当前消息包含 @knowledge 引用时检索注入（最小实现：显式引用）。 var knowledge []core.RetrievalHit - if strings.Contains(currentUserText(rc), "@knowledge") { + if !projectMode && strings.Contains(currentUserText(rc), "@knowledge") { q := strings.TrimSpace(strings.ReplaceAll(currentUserText(rc), "@knowledge", "")) if hits, err := rc.Retrieve(core.RetrievalQuery{Text: q}); err == nil { knowledge = hits @@ -264,7 +265,7 @@ func (l *LLMRunner) Execute(rc RunCtx) error { // 组装初始上下文。 hist := rc.History() currentUser, _ := lastAddressed(hist) - if projectContextEnabled(rc) { + if projectMode { // Historical assistant/tool text has no durable resource provenance. A // later duty revocation cannot safely reauthorize it, so project work // starts from the current user turn and a fresh provider bundle. @@ -281,24 +282,33 @@ func (l *LLMRunner) Execute(rc RunCtx) error { // 记忆注入迁移到记忆端口（N3 WP5）：由循环经 Config.Memory 按请求注入， // 组装侧不再注入（防双份；注入文案同一形态）。 _ = ctxasm.InjectMemory - msgs, asmReport := ctxasm.AssembleInput(prof, eff, hist, currentUser, rc.Attachments(), knowledge, sys, promptObs, rc.Card, resolveArtifact, ctxasm.AssembleOptions{ - Surfaces: rc.Surfaces(), + asmProf := prof + var surfaces []core.SurfaceSnapshot + if projectMode { + asmProf.SystemPrompt = "" // profile text has no resource provenance + } else { + surfaces = rc.Surfaces() + } + msgs, asmReport := ctxasm.AssembleInput(asmProf, eff, hist, currentUser, rc.Attachments(), knowledge, sys, promptObs, rc.Card, resolveArtifact, ctxasm.AssembleOptions{ + Surfaces: surfaces, ThinkReplay: thinkReplayEnabled(eff, route.Model), }) tail := ctxasm.Tail{ - Instructions: eff.GetString("context.userInstructions", ""), - History: hist, - Window: int(eff.GetNumber("context.contextWindow", 32000)), + History: hist, + Window: int(eff.GetNumber("context.contextWindow", 32000)), } - if note, ok := rc.(interface{ SessionNote() string }); ok { - tail.Note = note.SessionNote() - } - if src, ok := rc.(interface{ Injections() []ContextInjection }); ok { - for _, e := range src.Injections() { - tail.Entries = append(tail.Entries, ctxasm.Injection{ - Keys: e.Keys, Secondary: e.Secondary, Logic: e.Logic, Content: e.Content, - Constant: e.Constant, ScanDepth: e.ScanDepth, BudgetChars: e.BudgetChars, - }) + if !projectMode { + tail.Instructions = eff.GetString("context.userInstructions", "") + if note, ok := rc.(interface{ SessionNote() string }); ok { + tail.Note = note.SessionNote() + } + if src, ok := rc.(interface{ Injections() []ContextInjection }); ok { + for _, e := range src.Injections() { + tail.Entries = append(tail.Entries, ctxasm.Injection{ + Keys: e.Keys, Secondary: e.Secondary, Logic: e.Logic, Content: e.Content, + Constant: e.Constant, ScanDepth: e.ScanDepth, BudgetChars: e.BudgetChars, + }) + } } } msgs, asmReport = ctxasm.FinishAssembly(msgs, asmReport, tail) diff --git a/internal/runtime/llm_direct.go b/internal/runtime/llm_direct.go index e0307be..e9b53e7 100644 --- a/internal/runtime/llm_direct.go +++ b/internal/runtime/llm_direct.go @@ -17,6 +17,7 @@ import ( "agent-native/runtime/gates" "agent-native/runtime/hooks" agentllm "agent-native/runtime/llm" + "agent-native/runtime/reminders" agentsession "agent-native/runtime/session" agenttools "agent-native/runtime/tools" "agent-system-backend/internal/ctxasm" @@ -132,10 +133,12 @@ func (t directTool) Execute(ctx context.Context, args json.RawMessage) (agenttoo func (l *LLMRunner) runDirect(rc RunCtx, stream agentllm.StreamFunc, model string, msgs []agentllm.Message, decls []agentllm.ToolDecl, streamOpts agentllm.StreamOptions, cardflow bool, eff core.EffectiveSettings, maxTurns, maxTools int, refresh turnRefresh) error { st := &directRun{l: l, rc: rc, eff: eff, cardflow: cardflow, started: l.now(), inflight: map[string]*toolSlot{}} // 记忆端口（N3 WP5）：runCtx 暴露 store 时接线（注入由循环按请求完成）。 - if ms, ok := rc.(interface{ StoreMemory() memoryStore }); ok { + if ms, ok := rc.(interface{ StoreMemory() memoryStore }); ok && !projectContextEnabled(rc) { st.memoryStore = ms.StoreMemory() } - st.loadChecklist() + if !projectContextEnabled(rc) { + st.loadChecklist() + } if msg, ok := lastAddressed(rc.History()); ok && msg.Role == core.RoleSystem { var text string for _, p := range msg.Parts { @@ -224,6 +227,9 @@ func (l *LLMRunner) runDirect(rc RunCtx, stream agentllm.StreamFunc, model strin } var projectErr error var projectManifest *extension.ProjectContextManifest + var projectBody string + var lastProjectScope string + var projectHistoryTainted bool wrapped := func(ctx context.Context, model string, messages []agentllm.Message, _ []agentllm.ToolDecl, opts agentllm.StreamOptions) <-chan agentllm.Event { fail := func(err error) <-chan agentllm.Event { out := make(chan agentllm.Event, 1) @@ -240,6 +246,22 @@ func (l *LLMRunner) runDirect(rc RunCtx, stream agentllm.StreamFunc, model strin copy := *projectManifest manifest = © manifest.Model = model + scope := projectScopeKey(*manifest) + if lastProjectScope != "" && (scope != lastProjectScope || manifest.AuthorizationEpoch == "" || manifest.PublicationEpoch == "") { + projectHistoryTainted = true + } + lastProjectScope = scope + if projectHistoryTainted { + if len(msgs) == 0 || user.Role != agentllm.RoleUser || projectBody == "" { + return fail(fmt.Errorf("trusted project request seed unavailable after scope change")) + } + // The kernel's conversation still contains assistant/tool text from + // the previous authorization epoch. Rebuild this request solely from + // the current run's clean seed and freshly resolved project bundle. + messages = append([]agentllm.Message(nil), msgs[:len(msgs)-1]...) + messages = append(messages, user) + messages = reminders.Attach(messages, []string{projectBody}) + } if err := checkProjectInputBudget(rc, messages, decls); err != nil { return fail(err) } @@ -423,11 +445,12 @@ func (l *LLMRunner) runDirect(rc RunCtx, stream agentllm.StreamFunc, model strin Reminders: func(turn int) []string { var out []string out = append(out, st.reminders(turn)...) - projectErr, projectManifest = nil, nil + projectErr, projectManifest, projectBody = nil, nil, "" if refresh.ProjectContext != nil { var body string body, projectManifest, projectErr = refresh.ProjectContext() if projectErr == nil && body != "" { + projectBody = body out = append(out, body) } } diff --git a/internal/runtime/project_context_test.go b/internal/runtime/project_context_test.go index d07002f..06299fe 100644 --- a/internal/runtime/project_context_test.go +++ b/internal/runtime/project_context_test.go @@ -23,8 +23,18 @@ type projectRunCtx struct { manifests []extension.ProjectContextManifest evidence func(string) (extension.ProjectEvidence, error) budgetSettings core.EffectiveSettings + sessionNote string + injections []ContextInjection + surfaces []core.SurfaceSnapshot + toolList []core.ToolDesc } +func (c *projectRunCtx) Tools() []core.ToolDesc { return c.toolList } + +func (c *projectRunCtx) SessionNote() string { return c.sessionNote } +func (c *projectRunCtx) Injections() []ContextInjection { return c.injections } +func (c *projectRunCtx) Surfaces() []core.SurfaceSnapshot { return c.surfaces } + func (c *projectRunCtx) Settings() core.EffectiveSettings { if c.budgetSettings != nil { return c.budgetSettings @@ -91,6 +101,74 @@ func TestProjectContextResolutionFailureBlocksModelRequest(t *testing.T) { } } +func TestProjectRevocationScrubsOldMachineContextBeforeSecondTurn(t *testing.T) { + const old = "OLD_RESTRICTED_BODY" + turns := [][]agentllm.Event{ + {{Kind: agentllm.KindTextDelta, Text: old}, {Kind: agentllm.KindMessageEnd, Message: agentllm.Message{Role: agentllm.RoleAssistant, Content: old, StopReason: agentllm.StopToolCalls, ToolCalls: []agentllm.ToolCall{{ID: "c1", Name: "knowledge_search", Arguments: `{}`}}}}}, + {{Kind: agentllm.KindTextDelta, Text: "done"}, {Kind: agentllm.KindMessageEnd, Message: agentllm.Message{Role: agentllm.RoleAssistant, Content: "done", StopReason: agentllm.StopEnd}}}, + } + base := scriptStream(turns, nil) + var requests [][]agentllm.Message + c := &projectRunCtx{fakeRunCtx: &fakeRunCtx{ctx: context.Background(), projectID: "p1", prof: core.AgentProfile{Model: core.ModelRoute{Chat: "test-model"}}, memEntries: []memEntry{{typ: "note", content: "STALE_MEMORY"}}, execOutput: old}, + bundle: extension.ProjectContextBundle{Status: extension.ProjectContextReady, ProjectID: "p1", Version: "v1", AuthorizationEpoch: "duty-1", PublicationEpoch: "pub-1", Items: []extension.ProjectContextItem{{SourceID: "doc", Text: old, Required: true}}}, + budgetSettings: core.EffectiveSettings{"models": map[string]any{"chat": map[string]any{"baseUrl": "http://test"}}, "context": map[string]any{"userInstructions": "STALE_INSTRUCTIONS"}, "runtime": map[string]any{"verify": false, "composeFinal": false}}, + sessionNote: "STALE_SESSION_NOTE", injections: []ContextInjection{{Content: "STALE_INJECTION", Constant: true}}, + surfaces: []core.SurfaceSnapshot{{SemanticText: "STALE_SURFACE"}}, + } + runner := &LLMRunner{Stream: func(ctx context.Context, model string, msgs []agentllm.Message, tools []agentllm.ToolDecl, opts agentllm.StreamOptions) <-chan agentllm.Event { + requests = append(requests, append([]agentllm.Message(nil), msgs...)) + if len(requests) == 1 { + c.bundle = extension.ProjectContextBundle{Status: extension.ProjectContextReady, ProjectID: "p1", Version: "v2", AuthorizationEpoch: "duty-2", PublicationEpoch: "pub-2", Items: []extension.ProjectContextItem{{SourceID: "public", Text: "CURRENT_PUBLIC_FACT", Required: true}}} + } + return base(ctx, model, msgs, tools, opts) + }} + if err := runner.Execute(c); err != nil { + t.Fatal(err) + } + if len(requests) != 2 { + t.Fatalf("model requests=%d, want 2", len(requests)) + } + if c.fakeRunCtx.toolRuns != 1 { + t.Fatalf("expected restricted tool output before revocation, tool runs=%d", c.fakeRunCtx.toolRuns) + } + first := joinReq(requests[0]) + for _, unproven := range []string{"STALE_MEMORY", "STALE_INSTRUCTIONS", "STALE_SESSION_NOTE", "STALE_INJECTION", "STALE_SURFACE"} { + if strings.Contains(first, unproven) { + t.Fatalf("unproven machine context %q reached first project request: %s", unproven, first) + } + } + second := joinReq(requests[1]) + for _, forbidden := range []string{old, "STALE_MEMORY", "STALE_INSTRUCTIONS", "STALE_SESSION_NOTE", "STALE_INJECTION", "STALE_SURFACE"} { + if strings.Contains(second, forbidden) { + t.Fatalf("revoked machine context %q reached second model request: %s", forbidden, second) + } + } + if !strings.Contains(second, "CURRENT_PUBLIC_FACT") { + t.Fatalf("current context absent from second model request: %s", second) + } +} + +func TestProjectSameScopeKeepsCurrentRunToolContext(t *testing.T) { + turns := [][]agentllm.Event{ + {{Kind: agentllm.KindMessageEnd, Message: agentllm.Message{Role: agentllm.RoleAssistant, StopReason: agentllm.StopToolCalls, ToolCalls: []agentllm.ToolCall{{ID: "c1", Name: "knowledge_search", Arguments: `{}`}}}}}, + {{Kind: agentllm.KindMessageEnd, Message: agentllm.Message{Role: agentllm.RoleAssistant, Content: "done", StopReason: agentllm.StopEnd}}}, + } + base := scriptStream(turns, nil) + var requests [][]agentllm.Message + runner := &LLMRunner{Stream: func(ctx context.Context, model string, msgs []agentllm.Message, tools []agentllm.ToolDecl, opts agentllm.StreamOptions) <-chan agentllm.Event { + requests = append(requests, append([]agentllm.Message(nil), msgs...)) + return base(ctx, model, msgs, tools, opts) + }} + c := &projectRunCtx{fakeRunCtx: &fakeRunCtx{ctx: context.Background(), projectID: "p1", prof: core.AgentProfile{Model: core.ModelRoute{Chat: "test-model"}}, execOutput: "AUTHORIZED_TOOL_RESULT"}, + bundle: extension.ProjectContextBundle{Status: extension.ProjectContextReady, ProjectID: "p1", AuthorizationEpoch: "duty-1", PublicationEpoch: "pub-1", Items: []extension.ProjectContextItem{{SourceID: "fact", Text: "CURRENT_FACT", Required: true}}}} + if err := runner.Execute(c); err != nil { + t.Fatal(err) + } + if len(requests) < 2 || !strings.Contains(joinReq(requests[1]), "AUTHORIZED_TOOL_RESULT") || !strings.Contains(joinReq(requests[1]), "CURRENT_FACT") { + t.Fatalf("same-scope direct run lost current tool context: requests=%+v", requests) + } +} + func TestReadProjectEvidenceToolUsesScopedReader(t *testing.T) { c := &projectRunCtx{fakeRunCtx: &fakeRunCtx{projectID: "p1"}, evidence: func(ref string) (extension.ProjectEvidence, error) { if ref != "ref-1" { @@ -124,6 +202,29 @@ func TestSubagentModelRequestUsesProjectContextAndManifest(t *testing.T) { } } +func TestSubagentSameScopeKeepsNewToolResultAcrossTurns(t *testing.T) { + turns := [][]agentllm.Event{ + {{Kind: agentllm.KindMessageEnd, Message: agentllm.Message{Role: agentllm.RoleAssistant, StopReason: agentllm.StopToolCalls, ToolCalls: []agentllm.ToolCall{{ID: "search-1", Name: "knowledge_search", Arguments: `{}`}}}}}, + {{Kind: agentllm.KindMessageEnd, Message: agentllm.Message{Role: agentllm.RoleAssistant, Content: "done", StopReason: agentllm.StopEnd}}}, + } + base := scriptStream(turns, nil) + var requests [][]agentllm.Message + sub := &SubLLMRunner{Stream: func(ctx context.Context, model string, msgs []agentllm.Message, tools []agentllm.ToolDecl, opts agentllm.StreamOptions) <-chan agentllm.Event { + requests = append(requests, append([]agentllm.Message(nil), msgs...)) + return base(ctx, model, msgs, tools, opts) + }} + c := &projectRunCtx{fakeRunCtx: &fakeRunCtx{ctx: context.Background(), projectID: "p1", prof: core.AgentProfile{Model: core.ModelRoute{Chat: "test-model", Lightweight: "test-lite"}}, execOutput: "NEW_AUTHORIZED_TOOL"}, + bundle: extension.ProjectContextBundle{Status: extension.ProjectContextReady, ProjectID: "p1", AuthorizationEpoch: "duty-1", PublicationEpoch: "pub-1", Items: []extension.ProjectContextItem{{SourceID: "fact", Text: "CURRENT_FACT", Required: true}}}, + toolList: []core.ToolDesc{{Name: "knowledge_search", Description: "Search", Parameters: json.RawMessage(`{"type":"object"}`)}}, + } + if err := sub.Execute(c); err != nil { + t.Fatal(err) + } + if len(requests) != 2 || !strings.Contains(joinReq(requests[1]), "NEW_AUTHORIZED_TOOL") || !strings.Contains(joinReq(requests[1]), "CURRENT_FACT") || len(c.manifests) != 4 { + t.Fatalf("same-scope subagent lost authorized tool context: requests=%+v manifests=%+v", requests, c.manifests) + } +} + func TestProjectStreamRejectsProjectRunWithoutTrustedContextPort(t *testing.T) { called := false base := func(ctx context.Context, model string, msgs []agentllm.Message, tools []agentllm.ToolDecl, opts agentllm.StreamOptions) <-chan agentllm.Event { @@ -158,6 +259,73 @@ func TestProjectStreamBlocksRequestExceedingFinalModelBudget(t *testing.T) { } } +func TestProjectStreamBlocksStaleMachineHistoryAfterDutyRevocation(t *testing.T) { + c := &projectRunCtx{fakeRunCtx: &fakeRunCtx{projectID: "p1"}, bundle: extension.ProjectContextBundle{Status: extension.ProjectContextReady, ProjectID: "p1", Version: "v1", AuthorizationEpoch: "duty-1", PublicationEpoch: "pub-1"}} + calls := 0 + base := scriptStream(textTurns("done"), nil) + guarded := GuardProjectStream(c, "goal", func(ctx context.Context, model string, msgs []agentllm.Message, tools []agentllm.ToolDecl, opts agentllm.StreamOptions) <-chan agentllm.Event { + calls++ + return base(ctx, model, msgs, tools, opts) + }) + initial := []agentllm.Message{{Role: agentllm.RoleSystem, Content: "base"}, {Role: agentllm.RoleUser, Content: "goal"}} + for range guarded(context.Background(), "model", initial, nil, agentllm.StreamOptions{}) { + } + c.bundle = extension.ProjectContextBundle{Status: extension.ProjectContextReady, ProjectID: "p1", Version: "v2", AuthorizationEpoch: "duty-2", PublicationEpoch: "pub-2"} + stale := append(append([]agentllm.Message(nil), initial...), agentllm.Message{Role: agentllm.RoleAssistant, Content: "OLD_RESTRICTED_BODY"}, agentllm.Message{Role: agentllm.RoleTool, Content: "OLD_RESTRICTED_BODY"}) + sawError := false + for ev := range guarded(context.Background(), "model", stale, nil, agentllm.StreamOptions{}) { + sawError = sawError || ev.Kind == agentllm.KindError + } + if !sawError || calls != 1 { + t.Fatalf("revoked history reached generic model stream: error=%v calls=%d", sawError, calls) + } +} + +func TestProjectStreamRebuildsFirstRequestWithPriorMachineHistory(t *testing.T) { + c := &projectRunCtx{fakeRunCtx: &fakeRunCtx{projectID: "p1"}, bundle: extension.ProjectContextBundle{Status: extension.ProjectContextReady, ProjectID: "p1", AuthorizationEpoch: "duty-1", PublicationEpoch: "pub-1"}} + called := false + var requests [][]agentllm.Message + baseTurns := scriptStream(textTurns("ok", "done"), nil) + base := func(ctx context.Context, model string, msgs []agentllm.Message, tools []agentllm.ToolDecl, opts agentllm.StreamOptions) <-chan agentllm.Event { + called = true + requests = append(requests, append([]agentllm.Message(nil), msgs...)) + return baseTurns(ctx, model, msgs, tools, opts) + } + msgs := []agentllm.Message{{Role: agentllm.RoleSystem, Content: "old system"}, {Role: agentllm.RoleUser, Content: "old goal"}, {Role: agentllm.RoleAssistant, Content: "OLD_RESTRICTED_BODY"}, {Role: agentllm.RoleTool, Content: "OLD_RESTRICTED_BODY"}, {Role: agentllm.RoleUser, Content: "current goal"}} + guarded := GuardProjectStream(c, "goal", base) + sawError := false + for ev := range guarded(context.Background(), "model", msgs, nil, agentllm.StreamOptions{}) { + sawError = sawError || ev.Kind == agentllm.KindError + } + if sawError || !called || strings.Contains(joinReq(requests[0]), "OLD_RESTRICTED_BODY") || !strings.Contains(joinReq(requests[0]), "current goal") { + t.Fatalf("first request was not safely rebuilt: error=%v called=%v sent=%q", sawError, called, joinReq(requests[0])) + } + second := append(append([]agentllm.Message(nil), msgs...), agentllm.Message{Role: agentllm.RoleAssistant, Content: "NEW_AUTHORIZED_STEP"}, agentllm.Message{Role: agentllm.RoleTool, Content: "NEW_AUTHORIZED_TOOL"}) + for ev := range guarded(context.Background(), "model", second, nil, agentllm.StreamOptions{}) { + sawError = sawError || ev.Kind == agentllm.KindError + } + if sawError || len(requests) != 2 || strings.Contains(joinReq(requests[1]), "OLD_RESTRICTED_BODY") || !strings.Contains(joinReq(requests[1]), "NEW_AUTHORIZED_TOOL") { + t.Fatalf("second request failed to keep only same-scope new tool history: error=%v requests=%+v", sawError, requests) + } +} + +func TestProjectStreamRejectsPriorMachineHistoryWithoutFreshGoal(t *testing.T) { + c := &projectRunCtx{fakeRunCtx: &fakeRunCtx{projectID: "p1"}, bundle: extension.ProjectContextBundle{Status: extension.ProjectContextReady, ProjectID: "p1", AuthorizationEpoch: "duty-1", PublicationEpoch: "pub-1"}} + called := false + base := func(ctx context.Context, model string, msgs []agentllm.Message, tools []agentllm.ToolDecl, opts agentllm.StreamOptions) <-chan agentllm.Event { + called = true + return scriptStream(textTurns("bad"), nil)(ctx, model, msgs, tools, opts) + } + msgs := []agentllm.Message{{Role: agentllm.RoleSystem, Content: "base"}, {Role: agentllm.RoleUser, Content: "old goal"}, {Role: agentllm.RoleAssistant, Content: "OLD_RESTRICTED_BODY"}} + sawError := false + for ev := range GuardProjectStream(c, "goal", base)(context.Background(), "model", msgs, nil, agentllm.StreamOptions{}) { + sawError = sawError || ev.Kind == agentllm.KindError + } + if !sawError || called { + t.Fatalf("machine history without a fresh goal reached model: error=%v called=%v", sawError, called) + } +} + type projectSquadCtx struct { *entryFake manifests []extension.ProjectContextManifest @@ -167,7 +335,7 @@ func (c *projectSquadCtx) Run() core.Run { return core.Run{ID: "run-squad", Owner: "alice", ProjectID: "project-1"} } func (c *projectSquadCtx) ProjectContext(context.Context, string, int) (extension.ProjectContextBundle, bool, error) { - return extension.ProjectContextBundle{Status: extension.ProjectContextReady, ProjectID: "project-1", Items: []extension.ProjectContextItem{{SourceID: "squad-source", Text: "squad project fact", Required: true}}}, true, nil + return extension.ProjectContextBundle{Status: extension.ProjectContextReady, ProjectID: "project-1", AuthorizationEpoch: "duty-1", PublicationEpoch: "pub-1", Items: []extension.ProjectContextItem{{SourceID: "squad-source", Text: "squad project fact", Required: true}}}, true, nil } func (c *projectSquadCtx) SaveContextManifest(_ context.Context, m extension.ProjectContextManifest) error { c.manifests = append(c.manifests, m) @@ -176,9 +344,11 @@ func (c *projectSquadCtx) SaveContextManifest(_ context.Context, m extension.Pro func TestSquadEntryModelRequestUsesProjectContext(t *testing.T) { var sent []agentllm.Message + calls := 0 base := writeThenStop(nil, nil) runner := &SquadRunner{Router: fixedRoute{mode: squad.RouteDirect}, Checker: squad.MinimalChecker{}, Hitl: squad.HitlPolicy{Mode: squad.HitlDisabled}, Stream: func(ctx context.Context, model string, msgs []agentllm.Message, tools []agentllm.ToolDecl, opts agentllm.StreamOptions) <-chan agentllm.Event { + calls++ sent = append([]agentllm.Message(nil), msgs...) return base(ctx, model, msgs, tools, opts) }} @@ -187,7 +357,7 @@ func TestSquadEntryModelRequestUsesProjectContext(t *testing.T) { if err := runner.Execute(c); err != nil { t.Fatal(err) } - if !strings.Contains(joinReq(sent), "squad project fact") || len(c.manifests) < 2 || c.manifests[len(c.manifests)-1].Delivery != "responded" { + if calls < 2 || !strings.Contains(joinReq(sent), "squad project fact") || !strings.Contains(joinReq(sent), "output.md") || len(c.manifests) < 4 || c.manifests[len(c.manifests)-1].Delivery != "responded" { t.Fatalf("squad model missed project context: input=%q manifests=%+v", joinReq(sent), c.manifests) } } diff --git a/internal/runtime/project_stream.go b/internal/runtime/project_stream.go index b8aad50..d3648f7 100644 --- a/internal/runtime/project_stream.go +++ b/internal/runtime/project_stream.go @@ -5,6 +5,7 @@ import ( "crypto/sha256" "encoding/json" "fmt" + "sync" "time" agentllm "agent-native/runtime/llm" @@ -36,6 +37,12 @@ func GuardProjectStream(rc any, goal string, stream agentllm.StreamFunc) agentll } return stream } + var scopeMu sync.Mutex + var previousScope string + var seenScope, taintedHistory bool + var cleanPrefixIndex int + var cleanTask agentllm.Message + var droppedPriorHistory bool return func(ctx context.Context, model string, messages []agentllm.Message, tools []agentllm.ToolDecl, opts agentllm.StreamOptions) <-chan agentllm.Event { fail := func(err error) <-chan agentllm.Event { out := make(chan agentllm.Event, 1) @@ -64,7 +71,50 @@ func GuardProjectStream(rc any, goal string, stream agentllm.StreamFunc) agentll if err != nil { return fail(err) } - request := reminders.Attach(messages, []string{body}) + scopeMu.Lock() + scope := projectScopeKey(manifest) + requestBase := messages + if !seenScope { + users, lastUser, lastMachine := 0, -1, -1 + for i, msg := range messages { + if msg.Role == agentllm.RoleAssistant || msg.Role == agentllm.RoleTool { + lastMachine = i + } + if msg.Role == agentllm.RoleUser { + users++ + lastUser = i + } + } + if lastUser < 0 || lastUser <= lastMachine { + scopeMu.Unlock() + return fail(fmt.Errorf("project model request lacks a fresh user task after unproven machine history")) + } + if lastMachine >= 0 || users != 1 { + // This backend may have loaded a prior session. Keep only the new + // task, then attach the freshly resolved bundle below. + droppedPriorHistory, cleanPrefixIndex, cleanTask = true, lastUser, messages[lastUser] + } + } + if seenScope && (scope != previousScope || manifest.AuthorizationEpoch == "" || manifest.PublicationEpoch == "") { + taintedHistory = true + } + previousScope, seenScope = scope, true + unsafe := taintedHistory + if droppedPriorHistory && !unsafe { + requestBase = []agentllm.Message{{Role: agentllm.RoleSystem, Content: "Work on the current authorized project task. Prior machine history was discarded."}} + if cleanPrefixIndex < len(messages) && messages[cleanPrefixIndex].Role == agentllm.RoleUser && messages[cleanPrefixIndex].Content == cleanTask.Content { + requestBase = append(requestBase, messages[cleanPrefixIndex:]...) + } else { + // A compacted or rewritten session lost the trusted boundary. + // Continue from the saved user task without prior machine text. + requestBase = append(requestBase, cleanTask) + } + } + scopeMu.Unlock() + if unsafe { + return fail(fmt.Errorf("project authorization changed; generic model history lacks source provenance")) + } + request := reminders.Attach(requestBase, []string{body}) if err := checkProjectInputBudget(rc, request, tools); err != nil { return fail(err) } @@ -163,3 +213,12 @@ func checkProjectInputBudget(rc any, messages []agentllm.Message, tools []agentl } return nil } + +func projectScopeKey(m extension.ProjectContextManifest) string { + selected, _ := json.Marshal(struct { + Included []extension.ProjectContextManifestEntry + Offered []extension.ProjectEvidenceRef + Missing []string + }{m.Included, m.OfferedReferences, m.Missing}) + return fmt.Sprintf("%s\x00%s\x00%s\x00%s\x00%s\x00%s", m.ProjectID, m.Version, m.Watermark, m.AuthorizationEpoch, m.PublicationEpoch, selected) +} diff --git a/internal/runtime/workflow_compiled_test.go b/internal/runtime/workflow_compiled_test.go index 70faa07..6308895 100644 --- a/internal/runtime/workflow_compiled_test.go +++ b/internal/runtime/workflow_compiled_test.go @@ -302,7 +302,7 @@ func (c *projectJudgeCtx) Run() core.Run { return core.Run{ID: "run-judge", Owner: "alice", ProjectID: "project-1"} } func (c *projectJudgeCtx) ProjectContext(context.Context, string, int) (extension.ProjectContextBundle, bool, error) { - return extension.ProjectContextBundle{Status: extension.ProjectContextReady, ProjectID: "project-1", Items: []extension.ProjectContextItem{{SourceID: "judge-source", Text: "current project rule", Required: true}}}, true, nil + return extension.ProjectContextBundle{Status: extension.ProjectContextReady, ProjectID: "project-1", AuthorizationEpoch: "duty-1", PublicationEpoch: "pub-1", Items: []extension.ProjectContextItem{{SourceID: "judge-source", Text: "current project rule", Required: true}}}, true, nil } func (c *projectJudgeCtx) SaveContextManifest(_ context.Context, m extension.ProjectContextManifest) error { c.manifests = append(c.manifests, m) @@ -310,7 +310,7 @@ func (c *projectJudgeCtx) SaveContextManifest(_ context.Context, m extension.Pro } func TestWorkflowJudgeRequestUsesProjectContext(t *testing.T) { - var sent string + var sent []string srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { var body struct { Messages []struct { @@ -318,21 +318,30 @@ func TestWorkflowJudgeRequestUsesProjectContext(t *testing.T) { } `json:"messages"` } _ = json.NewDecoder(r.Body).Decode(&body) + var input string for _, m := range body.Messages { - sent += m.Content + input += m.Content } + sent = append(sent, input) w.Header().Set("Content-Type", "text/event-stream") _, _ = io.WriteString(w, "data: {\"choices\":[{\"delta\":{\"content\":\"ok\"}}]}\n\n") _, _ = io.WriteString(w, "data: [DONE]\n\n") })) defer srv.Close() c := &projectJudgeCtx{wfFake: &wfFake{settings: core.EffectiveSettings{"models": map[string]any{"chat": map[string]any{"baseUrl": srv.URL, "apiKey": "test-key", "model": "test-model"}}}}} - for ev := range judgeStreamFor(c)(context.Background(), "test-model", []agentllm.Message{{Role: agentllm.RoleUser, Content: "judge"}}, nil, agentllm.StreamOptions{}) { + stream := judgeStreamFor(c) + for ev := range stream(context.Background(), "test-model", []agentllm.Message{{Role: agentllm.RoleUser, Content: "judge"}}, nil, agentllm.StreamOptions{}) { if ev.Kind == agentllm.KindError { t.Fatalf("judge stream failed: %+v", ev) } } - if !strings.Contains(sent, "current project rule") || len(c.manifests) != 2 || c.manifests[1].Delivery != "responded" { + second := []agentllm.Message{{Role: agentllm.RoleSystem, Content: "judge role"}, {Role: agentllm.RoleUser, Content: "judge"}, {Role: agentllm.RoleAssistant, Content: "previous authorized step"}, {Role: agentllm.RoleTool, Content: "NEW_AUTHORIZED_TOOL"}} + for ev := range stream(context.Background(), "test-model", second, nil, agentllm.StreamOptions{}) { + if ev.Kind == agentllm.KindError { + t.Fatalf("second judge stream failed: %+v", ev) + } + } + if len(sent) != 2 || !strings.Contains(sent[0], "current project rule") || !strings.Contains(sent[1], "NEW_AUTHORIZED_TOOL") || !strings.Contains(sent[1], "current project rule") || len(c.manifests) != 4 || c.manifests[3].Delivery != "responded" { t.Fatalf("workflow judge missed project context: input=%q manifests=%+v", sent, c.manifests) } } diff --git a/internal/store/context_manifest.go b/internal/store/context_manifest.go index 947b42f..5179f6b 100644 --- a/internal/store/context_manifest.go +++ b/internal/store/context_manifest.go @@ -1,25 +1,60 @@ package store import ( + "database/sql" "encoding/json" "errors" + "fmt" "agent-system-backend/pkg/extension" ) const contextManifestAction = "model.context_manifest" -// AppendContextManifest stores a content-free receipt before a model request. -// The caller must supply a previously verified run or conversation target. +// AppendContextManifest writes to the trusted receipt table, never to the +// plugin-writable generic audit log. A terminal state must follow a matching +// attempted state for the same owner, target, project and input hash. func (s *Store) AppendContextManifest(owner, targetID string, m extension.ProjectContextManifest) error { - if owner == "" || targetID == "" || m.ProjectID == "" || m.InputSHA256 == "" { - return errors.New("context manifest requires owner, target, project and input hash") + if owner == "" || targetID == "" || m.ProjectID == "" || m.InputSHA256 == "" || m.AttemptID == "" { + return errors.New("context manifest requires owner, target, project, attempt and input hash") + } + if m.Delivery != "attempted" && m.Delivery != "responded" && m.Delivery != "unknown" { + return errors.New("context manifest has invalid delivery state") } raw, err := json.Marshal(m) if err != nil { return err } - return s.AppendAuditEvent(AuditEvent{Owner: owner, Actor: owner, Action: contextManifestAction, Target: targetID, Evidence: string(raw)}) + tx, err := s.db.Begin() + if err != nil { + return err + } + defer tx.Rollback() + if m.Delivery != "attempted" { + var found int + err := tx.QueryRow(s.q(`SELECT 1 FROM context_manifests WHERE attempt_id=? AND delivery='attempted' AND owner=? AND target_id=? AND project_id=? AND input_sha256=?`), + m.AttemptID, owner, targetID, m.ProjectID, m.InputSHA256).Scan(&found) + if errors.Is(err, sql.ErrNoRows) { + return errors.New("context manifest terminal receipt lacks matching attempt") + } + if err != nil { + return err + } + var terminal int + err = tx.QueryRow(s.q(`SELECT 1 FROM context_manifests WHERE attempt_id=? AND delivery IN ('responded','unknown') LIMIT 1`), m.AttemptID).Scan(&terminal) + if err == nil { + return errors.New("context manifest attempt already terminal") + } + if !errors.Is(err, sql.ErrNoRows) { + return err + } + } + _, err = tx.Exec(s.q(`INSERT INTO context_manifests(id,attempt_id,owner,target_id,project_id,input_sha256,delivery,manifest_json,created_at) VALUES(?,?,?,?,?,?,?,?,?)`), + NewID("ctxm"), m.AttemptID, owner, targetID, m.ProjectID, m.InputSHA256, m.Delivery, string(raw), nowISO()) + if err != nil { + return fmt.Errorf("insert context manifest: %w", err) + } + return tx.Commit() } // ListContextManifests reads receipts only within the authenticated owner's @@ -29,7 +64,7 @@ func (s *Store) ListContextManifests(owner, targetID string) ([]extension.Projec if owner == "" || targetID == "" { return nil, errors.New("context manifest query requires owner and target") } - rows, err := s.db.Query(s.q(`SELECT evidence FROM audit_events WHERE owner=? AND action=? AND target=? ORDER BY id`), owner, contextManifestAction, targetID) + rows, err := s.db.Query(s.q(`SELECT manifest_json FROM context_manifests WHERE owner=? AND target_id=? ORDER BY created_at,id`), owner, targetID) if err != nil { return nil, err } diff --git a/internal/store/context_manifest_test.go b/internal/store/context_manifest_test.go new file mode 100644 index 0000000..7d9018d --- /dev/null +++ b/internal/store/context_manifest_test.go @@ -0,0 +1,38 @@ +package store + +import ( + "path/filepath" + "testing" + + "agent-system-backend/pkg/extension" +) + +func TestContextManifestTerminalRequiresMatchingAttempt(t *testing.T) { + st, err := OpenSQLite(filepath.Join(t.TempDir(), "receipt.db")) + if err != nil { + t.Fatal(err) + } + defer st.Close() + m := extension.ProjectContextManifest{ProjectID: "p1", AttemptID: "attempt-1", InputSHA256: "input-hash", Delivery: "responded"} + if err := st.AppendContextManifest("alice", "run-1", m); err == nil { + t.Fatal("terminal receipt without attempted send") + } + m.Delivery = "attempted" + if err := st.AppendContextManifest("alice", "run-1", m); err != nil { + t.Fatal(err) + } + if err := st.AppendContextManifest("alice", "run-1", m); err == nil { + t.Fatal("duplicate attempted receipt") + } + m.Delivery = "responded" + if err := st.AppendContextManifest("alice", "run-2", m); err == nil { + t.Fatal("attempt reused across target") + } + if err := st.AppendContextManifest("alice", "run-1", m); err != nil { + t.Fatal(err) + } + m.Delivery = "unknown" + if err := st.AppendContextManifest("alice", "run-1", m); err == nil { + t.Fatal("one attempt acquired two terminal states") + } +} diff --git a/internal/store/migrate.go b/internal/store/migrate.go index 56a087f..5f26e2c 100644 --- a/internal/store/migrate.go +++ b/internal/store/migrate.go @@ -855,6 +855,13 @@ func init() { }, down: map[string][]string{"sqlite": {`DROP TABLE IF EXISTS work_task_bindings`}, "postgres": {`DROP TABLE IF EXISTS work_task_bindings`}}, }, + migration{version: 32, name: "trusted_context_manifests", + up: map[string][]string{ + "sqlite": {`CREATE TABLE context_manifests(id TEXT PRIMARY KEY,attempt_id TEXT NOT NULL,owner TEXT NOT NULL,target_id TEXT NOT NULL,project_id TEXT NOT NULL,input_sha256 TEXT NOT NULL,delivery TEXT NOT NULL CHECK(delivery IN ('attempted','responded','unknown')),manifest_json TEXT NOT NULL,created_at TEXT NOT NULL,UNIQUE(attempt_id,delivery))`, `CREATE INDEX idx_context_manifests_owner_target ON context_manifests(owner,target_id,created_at)`, `CREATE UNIQUE INDEX uniq_context_manifest_terminal ON context_manifests(attempt_id) WHERE delivery IN ('responded','unknown')`}, + "postgres": {`CREATE TABLE context_manifests(id TEXT PRIMARY KEY,attempt_id TEXT NOT NULL,owner TEXT NOT NULL,target_id TEXT NOT NULL,project_id TEXT NOT NULL,input_sha256 TEXT NOT NULL,delivery TEXT NOT NULL CHECK(delivery IN ('attempted','responded','unknown')),manifest_json TEXT NOT NULL,created_at TEXT NOT NULL,UNIQUE(attempt_id,delivery))`, `CREATE INDEX idx_context_manifests_owner_target ON context_manifests(owner,target_id,created_at)`, `CREATE UNIQUE INDEX uniq_context_manifest_terminal ON context_manifests(attempt_id) WHERE delivery IN ('responded','unknown')`}, + }, + down: map[string][]string{"sqlite": {`DROP INDEX IF EXISTS uniq_context_manifest_terminal`, `DROP INDEX IF EXISTS idx_context_manifests_owner_target`, `DROP TABLE IF EXISTS context_manifests`}, "postgres": {`DROP INDEX IF EXISTS uniq_context_manifest_terminal`, `DROP INDEX IF EXISTS idx_context_manifests_owner_target`, `DROP TABLE IF EXISTS context_manifests`}}, + }, ) } diff --git a/internal/store/migrate_compat.go b/internal/store/migrate_compat.go index 07944d4..6458fd4 100644 --- a/internal/store/migrate_compat.go +++ b/internal/store/migrate_compat.go @@ -36,6 +36,7 @@ var migrationBreaksOldReaders = map[int]bool{ 29: false, // redeem_attempts：新表，旧读者不受影响 30: false, // project_event_publication_proofs：新表，旧读者不受影响 31: false, // work_task_bindings：新增绑定表，旧后台任务读面不受影响 + 32: false, // trusted_context_manifests：独立可信回执表，旧读者不受影响 } // SchemaTarget 是本二进制会迁移到的 schema 版本。 -- 2.54.0 From 7a00b20cd4282c62aa4560085a804ea8c2a60349 Mon Sep 17 00:00:00 2001 From: weichen Date: Wed, 14 Oct 2026 04:55:14 +0000 Subject: [PATCH 07/41] Bind workflow judge inputs to trusted step attempts Why: Compiled workflow critics could resend a prior prompt output after document duty or publication changed across separate model guards. Evidence: RED cross-guard revocation and retry tests; go test ./... -count=1 and targeted go test -race passed locally before commit. Impact: Bind materialized prompt bytes to the engine step attempt and responded model receipt; recheck current project sources and epochs before judging, failing closed for unproven or ambiguous output. Refs: RDM two-trees stage5 W6; stage6 X1 public extension request; W6 independent review P1. --- cmd/storage-migrate/main.go | 4 +- internal/projectcontext/workflow_step.go | 16 +++ internal/runmgr/project_context.go | 107 ++++++++++++++++ internal/runmgr/project_context_test.go | 88 ++++++++++++++ internal/runtime/project_stream.go | 8 ++ internal/runtime/workflow_compiled.go | 32 +++++ internal/runtime/workflow_compiled_test.go | 65 +++++++++- internal/store/migrate.go | 7 ++ internal/store/migrate_compat.go | 1 + internal/store/workflow_step_source.go | 128 ++++++++++++++++++++ internal/store/workflow_step_source_test.go | 75 ++++++++++++ internal/wfcompile/host.go | 32 ++++- internal/wfcompile/project_backend.go | 37 ++++++ internal/wfcompile/project_sources.go | 107 ++++++++++++++++ internal/wfcompile/run.go | 21 +++- internal/wfcompile/wfcompile_test.go | 116 ++++++++++++++++++ pkg/extension/project_context.go | 33 ++--- 17 files changed, 852 insertions(+), 25 deletions(-) create mode 100644 internal/projectcontext/workflow_step.go create mode 100644 internal/store/workflow_step_source.go create mode 100644 internal/store/workflow_step_source_test.go create mode 100644 internal/wfcompile/project_backend.go create mode 100644 internal/wfcompile/project_sources.go diff --git a/cmd/storage-migrate/main.go b/cmd/storage-migrate/main.go index 49206c6..92de9f2 100644 --- a/cmd/storage-migrate/main.go +++ b/cmd/storage-migrate/main.go @@ -287,7 +287,7 @@ var copyOrder = []string{ "activity_cards", "project_event_shares", "command_audit", "prompt_modules", "sessions", "api_keys", "plugin_grants", "plugin_schema", "plugin_kv", "background_tasks", "work_task_bindings", - "memory_entries", "audit_events", "context_manifests", "pending_confirms", "llm_usage_daily", + "memory_entries", "audit_events", "context_manifests", "workflow_step_sources", "pending_confirms", "llm_usage_daily", "secret_keys", "settings_snapshots", "regen_pending", "context_entries", "user_commands", "pending_notices", "recovery_holds", "surfaces", "surface_revisions", "surface_actions", "plugin_activation", @@ -784,7 +784,7 @@ func advanceSequences(db *sql.DB, table string) error { // checkOwners：业务行引用的 owner 必须存在于 users（单租户默认 ”/'local' // 除外）。未知 owner 阻塞迁移（U4/R7：不静默带过未知归属）。 func checkOwners(db *sql.DB, src *sql.DB) error { - ownerTables := []string{"projects", "conversations", "runs", "artifacts", "knowledge", "hitl_cards", "profiles", "activity_cards", "project_event_shares", "command_audit", "work_task_bindings", "context_manifests"} + ownerTables := []string{"projects", "conversations", "runs", "artifacts", "knowledge", "hitl_cards", "profiles", "activity_cards", "project_event_shares", "command_audit", "work_task_bindings", "context_manifests", "workflow_step_sources"} for _, t := range ownerTables { if !sqliteHasTable(src, t) { continue diff --git a/internal/projectcontext/workflow_step.go b/internal/projectcontext/workflow_step.go new file mode 100644 index 0000000..048d808 --- /dev/null +++ b/internal/projectcontext/workflow_step.go @@ -0,0 +1,16 @@ +package projectcontext + +import "context" + +type workflowStepAttemptKey struct{} + +// WithWorkflowStepAttempt is used by the trusted squad executor adapter. The +// value comes from the engine's persisted step attempt, never from model text. +func WithWorkflowStepAttempt(ctx context.Context, attemptID string) context.Context { + return context.WithValue(ctx, workflowStepAttemptKey{}, attemptID) +} + +func WorkflowStepAttempt(ctx context.Context) string { + value, _ := ctx.Value(workflowStepAttemptKey{}).(string) + return value +} diff --git a/internal/runmgr/project_context.go b/internal/runmgr/project_context.go index 5236b45..072e671 100644 --- a/internal/runmgr/project_context.go +++ b/internal/runmgr/project_context.go @@ -6,6 +6,7 @@ import ( "errors" "fmt" "strings" + "time" agentllm "agent-native/runtime/llm" @@ -28,6 +29,30 @@ func (c *runCtx) ProjectContextEnabled() bool { return c.run.ProjectID != "" && c.mgr.projectContextResolver != nil } +// ValidateProjectCrossGuard links separate model streams in one persisted run. +// A new guard cannot treat a workflow/user prompt as fresh when earlier model +// work under the same run used another authorization or publication revision. +func (c *runCtx) ValidateProjectCrossGuard(ctx context.Context, current extension.ProjectContextBundle) error { + if !c.ProjectContextEnabled() { + return nil + } + if err := ctx.Err(); err != nil { + return err + } + prior, err := c.mgr.st.ListContextManifests(string(c.run.Owner), string(c.run.ID)) + if err != nil { + return err + } + for _, m := range prior { + if m.ProjectID != current.ProjectID || m.AuthorizationEpoch == "" || m.PublicationEpoch == "" || + current.AuthorizationEpoch == "" || current.PublicationEpoch == "" || + m.AuthorizationEpoch != current.AuthorizationEpoch || m.PublicationEpoch != current.PublicationEpoch || m.Watermark != current.Watermark { + return errors.New("prior project model work used a different authorization or publication revision") + } + } + return nil +} + func (c *runCtx) contextRequest() extension.ProjectContextRequest { c.projectContextMu.Lock() defer c.projectContextMu.Unlock() @@ -224,3 +249,85 @@ func (c *runCtx) SaveContextManifest(ctx context.Context, m extension.ProjectCon } return c.mgr.st.AppendContextManifest(string(run.Owner), string(run.ID), m) } + +// InvalidateProjectStepOutput prevents a retry from inheriting the prior +// attempt's binding, even when the new attempt produces identical bytes. +func (c *runCtx) InvalidateProjectStepOutput(ctx context.Context, stepID string) error { + if err := ctx.Err(); err != nil { + return err + } + return c.mgr.st.UnbindWorkflowStepSource(string(c.run.Owner), string(c.run.ID), stepID) +} + +// BindProjectStepOutput stores exact bytes and their responded model attempt +// after a prompt step has materialized. The step start timestamp fences out +// receipts from earlier steps; the workflow sink rejects concurrent ambiguity. +func (c *runCtx) BindProjectStepOutput(ctx context.Context, stepID, stepAttemptID, kind string, startedAt time.Time, output []byte) error { + if kind != "prompt" || !c.ProjectContextEnabled() { + return errors.New("project prompt step provenance unavailable") + } + bundle, active, err := c.ProjectContext(ctx, "", 12000) + if err != nil || !active { + return errors.New("project step current scope unavailable") + } + bound, err := c.mgr.st.BindWorkflowStepSource(string(c.run.Owner), string(c.run.ID), stepID, stepAttemptID, kind, startedAt, output) + if err != nil { + return err + } + if bound.ProjectID != string(bundle.ProjectID) || bound.AuthorizationEpoch != bundle.AuthorizationEpoch || + bound.PublicationEpoch != bundle.PublicationEpoch || bound.Watermark != bundle.Watermark { + return errors.New("project step source changed before binding") + } + return nil +} + +// VerifyProjectStepOutput is the last gate before a workflow critic receives +// output.md. It checks the persisted run+step association, current file bytes, +// the trusted responded request, and live domain authorization epochs. +func (c *runCtx) VerifyProjectStepOutput(ctx context.Context, stepID, stepAttemptID, kind string, output []byte) error { + if kind != "prompt" || !c.ProjectContextEnabled() { + return errors.New("project workflow output has no verifiable prompt source") + } + bound, err := c.mgr.st.WorkflowStepSource(string(c.run.Owner), string(c.run.ID), stepID) + if err != nil { + return errors.New("project workflow output has no trusted step binding") + } + if bound.ProjectID != string(c.run.ProjectID) || bound.StepAttemptID != stepAttemptID || bound.OutputSHA256 != sha256.Sum256(output) { + return errors.New("project workflow output bytes or project scope changed") + } + receipt, err := c.mgr.st.RespondedContextManifest(string(c.run.Owner), string(c.run.ID), bound.AttemptID) + if err != nil || receipt.ProjectID != c.run.ProjectID || receipt.WorkflowStepAttemptID != stepAttemptID || receipt.AuthorizationEpoch != bound.AuthorizationEpoch || + receipt.PublicationEpoch != bound.PublicationEpoch || receipt.Watermark != bound.Watermark || receipt.Version != bound.Version { + return errors.New("project workflow output lost its trusted model source") + } + current, active, err := c.ProjectContext(ctx, "", 12000) + if err != nil || !active || current.ProjectID != receipt.ProjectID || + current.AuthorizationEpoch != receipt.AuthorizationEpoch || current.PublicationEpoch != receipt.PublicationEpoch || current.Watermark != receipt.Watermark { + return errors.New("project workflow output authorization or publication changed") + } + if err := projectcontext.ValidateCurrent(receipt, current); err != nil { + return fmt.Errorf("project workflow output source changed: %w", err) + } + for _, used := range receipt.ReadEvidence { + if c.mgr.projectEvidenceReader == nil { + return errors.New("project workflow evidence reader unavailable") + } + matched := false + for _, ref := range current.Evidence { + if ref.ID != used.ReferenceID || ref.SourceID != used.SourceID || ref.Revision != used.Revision || ref.Hash != used.SourceHash { + continue + } + scope := c.contextRequest() + scope.BudgetChars = 8000 + now, err := c.mgr.projectEvidenceReader(ctx, extension.ProjectEvidenceRequest{Scope: scope, Reference: ref}) + if err == nil && now.Reference == ref && fmt.Sprintf("%x", sha256.Sum256([]byte(now.Text))) == used.InputSHA256 { + matched = true + } + break + } + if !matched { + return errors.New("project workflow evidence permission or content changed") + } + } + return nil +} diff --git a/internal/runmgr/project_context_test.go b/internal/runmgr/project_context_test.go index 3177358..c18aee1 100644 --- a/internal/runmgr/project_context_test.go +++ b/internal/runmgr/project_context_test.go @@ -4,6 +4,7 @@ import ( "context" "sync" "testing" + "time" agentllm "agent-native/runtime/llm" "agent-system-backend/internal/projectcontext" @@ -70,6 +71,93 @@ func TestProjectContextResumeReloadsCurrentVersionAndAuthorization(t *testing.T) } } +func TestProjectJudgeChecksPersistedSourceEpochAcrossGuards(t *testing.T) { + st := openRecoveryStore(t) + m := newRecoveryManager(t, st) + conv := recoveryConversation(t, st) + run := recoveryRun(t, st, conv, core.RunPending) + m.SetProjectWorkAuthorization(func(context.Context, string, core.ID) (bool, error) { return true, nil }) + epoch := "duty-1" + publication := "pub-1" + items := []extension.ProjectContextItem{{SourceID: "restricted-doc", Revision: "r1", Hash: "h1", Text: "OLD_RESTRICTED_BODY", Required: true}} + m.SetProjectContextResolver(func(_ context.Context, req extension.ProjectContextRequest) (extension.ProjectContextBundle, error) { + return extension.ProjectContextBundle{Status: extension.ProjectContextReady, ProjectID: req.ProjectID, AuthorizationEpoch: epoch, PublicationEpoch: publication, Watermark: "commit-1", Items: items}, nil + }) + rc := &runCtx{mgr: m, run: run, ctx: context.Background()} + started := time.Now().Add(-time.Second) + bundle, _, err := rc.ProjectContext(context.Background(), "write output", 900) + if err != nil { + t.Fatal(err) + } + _, manifest, err := projectcontext.Assemble(bundle, 900) + if err != nil { + t.Fatal(err) + } + manifest.InputSHA256, manifest.AttemptID, manifest.Delivery = "input-hash", "step-attempt", "attempted" + manifest.WorkflowStepAttemptID = "engine-run/draft/1" + if err := rc.SaveContextManifest(context.Background(), manifest); err != nil { + t.Fatal(err) + } + manifest.Delivery = "responded" + if err := rc.SaveContextManifest(context.Background(), manifest); err != nil { + t.Fatal(err) + } + if err := rc.BindProjectStepOutput(context.Background(), "draft", "engine-run/draft/1", "prompt", started, []byte("OLD_RESTRICTED_BODY")); err != nil { + t.Fatal(err) + } + if err := rc.VerifyProjectStepOutput(context.Background(), "draft", "engine-run/draft/1", "prompt", []byte("OLD_RESTRICTED_BODY")); err != nil { + t.Fatalf("same epoch output rejected: %v", err) + } + if err := rc.ValidateProjectCrossGuard(context.Background(), bundle); err != nil { + t.Fatalf("same epoch cross-guard request rejected: %v", err) + } + if err := rc.VerifyProjectStepOutput(context.Background(), "draft", "engine-run/draft/1", "prompt", []byte("replaced bytes")); err == nil { + t.Fatal("replaced output accepted") + } + if err := rc.VerifyProjectStepOutput(context.Background(), "draft", "engine-run/draft/2", "prompt", []byte("OLD_RESTRICTED_BODY")); err == nil { + t.Fatal("second execution reused first attempt's identical output") + } + if err := rc.VerifyProjectStepOutput(context.Background(), "other", "engine-run/other/1", "prompt", []byte("OLD_RESTRICTED_BODY")); err == nil { + t.Fatal("another step reused output binding") + } + items = nil // provider withdraws the document while retaining project membership and epoch + if err := rc.VerifyProjectStepOutput(context.Background(), "draft", "engine-run/draft/1", "prompt", []byte("OLD_RESTRICTED_BODY")); err == nil { + t.Fatal("withdrawn document accepted with unchanged authorization epoch") + } + items = []extension.ProjectContextItem{{SourceID: "restricted-doc", Revision: "r1", Hash: "h1", Text: "OLD_RESTRICTED_BODY", Required: true}} + epoch = "duty-2" + current, _, err := rc.ProjectContext(context.Background(), "judge", 900) + if err != nil { + t.Fatal(err) + } + if err := rc.ValidateProjectCrossGuard(context.Background(), current); err == nil { + t.Fatal("cross-guard request ignored persisted epoch change") + } + if err := rc.VerifyProjectStepOutput(context.Background(), "draft", "engine-run/draft/1", "prompt", []byte("OLD_RESTRICTED_BODY")); err == nil { + t.Fatal("revoked source epoch accepted for workflow judge") + } + reloaded, err := st.GetRunByID(string(run.ID)) + if err != nil { + t.Fatal(err) + } + resumed := &runCtx{mgr: m, run: reloaded, ctx: context.Background()} + if err := resumed.VerifyProjectStepOutput(context.Background(), "draft", "engine-run/draft/1", "prompt", []byte("OLD_RESTRICTED_BODY")); err == nil { + t.Fatal("resumed judge ignored revocation") + } + epoch, publication = "duty-1", "pub-2" + if err := resumed.VerifyProjectStepOutput(context.Background(), "draft", "engine-run/draft/1", "prompt", []byte("OLD_RESTRICTED_BODY")); err == nil { + t.Fatal("resumed judge ignored publication epoch change") + } + other := recoveryRun(t, st, conv, core.RunPending) + noReceipt := &runCtx{mgr: m, run: other, ctx: context.Background()} + if err := noReceipt.BindProjectStepOutput(context.Background(), "draft", "engine-run/draft/1", "prompt", started, []byte("tool body")); err == nil { + t.Fatal("tool-only output without model provenance accepted") + } + if err := noReceipt.VerifyProjectStepOutput(context.Background(), "draft", "engine-run/draft/1", "prompt", []byte("tool body")); err == nil { + t.Fatal("another run reused output binding") + } +} + func TestContextManifestPersistsByOwnerAndRun(t *testing.T) { st := openRecoveryStore(t) m := newRecoveryManager(t, st) diff --git a/internal/runtime/project_stream.go b/internal/runtime/project_stream.go index d3648f7..aae73ae 100644 --- a/internal/runtime/project_stream.go +++ b/internal/runtime/project_stream.go @@ -67,6 +67,13 @@ func GuardProjectStream(rc any, goal string, stream agentllm.StreamFunc) agentll if !active { return stream(ctx, model, messages, tools, opts) } + if checker, ok := rc.(interface { + ValidateProjectCrossGuard(context.Context, extension.ProjectContextBundle) error + }); ok { + if err := checker.ValidateProjectCrossGuard(ctx, bundle); err != nil { + return fail(err) + } + } body, manifest, err := projectcontext.Assemble(bundle, budget) if err != nil { return fail(err) @@ -134,6 +141,7 @@ func GuardProjectStream(rc any, goal string, stream agentllm.StreamFunc) agentll return fail(err) } manifest.AttemptID, manifest.Delivery = attemptID, "attempted" + manifest.WorkflowStepAttemptID = projectcontext.WorkflowStepAttempt(ctx) var save func(context.Context, extension.ProjectContextManifest) error if sink, ok := rc.(interface { SaveContextManifest(context.Context, extension.ProjectContextManifest) error diff --git a/internal/runtime/workflow_compiled.go b/internal/runtime/workflow_compiled.go index 428cd90..ac56ec4 100644 --- a/internal/runtime/workflow_compiled.go +++ b/internal/runtime/workflow_compiled.go @@ -64,6 +64,8 @@ func (w CompiledWorkflowRunner) runLaunch(rc RunCtx, launch workflow.Launch, opt } if deps.JudgeStream == nil { deps.JudgeStream = judgeStreamFor(rc) + } else { + deps.JudgeStream = GuardProjectStream(rc, "", deps.JudgeStream) } return wfcompile.RunCompiled(workflowHost{rc: rc}, deps, launch, workflow.Vars{ Input: currentUserText(rc), @@ -169,3 +171,33 @@ func (h workflowHost) ConversationSandbox() string { } return "" } + +func (h workflowHost) InvalidateProjectStepOutput(ctx context.Context, stepID string) error { + invalidate, ok := h.rc.(interface { + InvalidateProjectStepOutput(context.Context, string) error + }) + if !ok { + return fmt.Errorf("project workflow step invalidation unavailable") + } + return invalidate.InvalidateProjectStepOutput(ctx, stepID) +} + +func (h workflowHost) BindProjectStepOutput(ctx context.Context, stepID, stepAttemptID, kind string, startedAt time.Time, output []byte) error { + binder, ok := h.rc.(interface { + BindProjectStepOutput(context.Context, string, string, string, time.Time, []byte) error + }) + if !ok { + return fmt.Errorf("project workflow step binding unavailable") + } + return binder.BindProjectStepOutput(ctx, stepID, stepAttemptID, kind, startedAt, output) +} + +func (h workflowHost) VerifyProjectStepOutput(ctx context.Context, stepID, stepAttemptID, kind string, output []byte) error { + verifier, ok := h.rc.(interface { + VerifyProjectStepOutput(context.Context, string, string, string, []byte) error + }) + if !ok { + return fmt.Errorf("project workflow step verification unavailable") + } + return verifier.VerifyProjectStepOutput(ctx, stepID, stepAttemptID, kind, output) +} diff --git a/internal/runtime/workflow_compiled_test.go b/internal/runtime/workflow_compiled_test.go index 6308895..51b1301 100644 --- a/internal/runtime/workflow_compiled_test.go +++ b/internal/runtime/workflow_compiled_test.go @@ -11,6 +11,7 @@ import ( "testing" agentllm "agent-native/runtime/llm" + "agent-system-backend/internal/projectcontext" "agent-system-backend/internal/workflow" "agent-system-backend/pkg/extension" core "agent-system-core" @@ -296,18 +297,31 @@ func TestJudgeStreamUsesConfiguredModel(t *testing.T) { type projectJudgeCtx struct { *wfFake manifests []extension.ProjectContextManifest + authEpoch string } func (c *projectJudgeCtx) Run() core.Run { return core.Run{ID: "run-judge", Owner: "alice", ProjectID: "project-1"} } func (c *projectJudgeCtx) ProjectContext(context.Context, string, int) (extension.ProjectContextBundle, bool, error) { - return extension.ProjectContextBundle{Status: extension.ProjectContextReady, ProjectID: "project-1", AuthorizationEpoch: "duty-1", PublicationEpoch: "pub-1", Items: []extension.ProjectContextItem{{SourceID: "judge-source", Text: "current project rule", Required: true}}}, true, nil + epoch := c.authEpoch + if epoch == "" { + epoch = "duty-1" + } + return extension.ProjectContextBundle{Status: extension.ProjectContextReady, ProjectID: "project-1", AuthorizationEpoch: epoch, PublicationEpoch: "pub-1", Items: []extension.ProjectContextItem{{SourceID: "judge-source", Text: "current project rule", Required: true}}}, true, nil } func (c *projectJudgeCtx) SaveContextManifest(_ context.Context, m extension.ProjectContextManifest) error { c.manifests = append(c.manifests, m) return nil } +func (c *projectJudgeCtx) ValidateProjectCrossGuard(_ context.Context, current extension.ProjectContextBundle) error { + for _, m := range c.manifests { + if m.AuthorizationEpoch != current.AuthorizationEpoch || m.PublicationEpoch != current.PublicationEpoch || m.Watermark != current.Watermark { + return fmt.Errorf("prior workflow model source was revoked") + } + } + return nil +} func TestWorkflowJudgeRequestUsesProjectContext(t *testing.T) { var sent []string @@ -346,4 +360,53 @@ func TestWorkflowJudgeRequestUsesProjectContext(t *testing.T) { } } +func TestWorkflowModelReceiptCarriesEngineStepAttempt(t *testing.T) { + c := &projectJudgeCtx{wfFake: &wfFake{}, authEpoch: "duty-1"} + ctx := projectcontext.WithWorkflowStepAttempt(context.Background(), "engine-run/draft/2") + for ev := range GuardProjectStream(c, "draft", scriptStream(textTurns("done"), nil))(ctx, "model", []agentllm.Message{{Role: agentllm.RoleUser, Content: "write"}}, nil, agentllm.StreamOptions{}) { + if ev.Kind == agentllm.KindError { + t.Fatalf("step model failed: %+v", ev) + } + } + if len(c.manifests) != 2 || c.manifests[0].WorkflowStepAttemptID != "engine-run/draft/2" || c.manifests[1].WorkflowStepAttemptID != "engine-run/draft/2" || c.manifests[1].Delivery != "responded" { + t.Fatalf("engine attempt missing from trusted model receipts: %+v", c.manifests) + } +} + +func TestWorkflowJudgeBlocksOutputFromEarlierAuthorizationEpoch(t *testing.T) { + const old = "OLD_RESTRICTED_BODY" + seen := false + srv := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { + var body struct { + Messages []struct { + Content string `json:"content"` + } `json:"messages"` + } + _ = json.NewDecoder(r.Body).Decode(&body) + for _, m := range body.Messages { + if strings.Contains(m.Content, old) { + seen = true + } + } + w.Header().Set("Content-Type", "text/event-stream") + _, _ = io.WriteString(w, "data: [DONE]\n\n") + })) + defer srv.Close() + c := &projectJudgeCtx{wfFake: &wfFake{settings: core.EffectiveSettings{"models": map[string]any{"chat": map[string]any{"baseUrl": srv.URL, "apiKey": "test-key", "model": "test-model"}}}}, authEpoch: "duty-1"} + step := GuardProjectStream(c, "write", scriptStream(textTurns("step done"), nil)) + for range step(context.Background(), "test-model", []agentllm.Message{{Role: agentllm.RoleUser, Content: "write report"}}, nil, agentllm.StreamOptions{}) { + } + if len(c.manifests) != 2 || c.manifests[1].Delivery != "responded" { + t.Fatalf("step source receipt missing: %+v", c.manifests) + } + c.authEpoch = "duty-2" // member remains; document duty and publication changed before critic + blocked := false + for ev := range judgeStreamFor(c)(context.Background(), "test-model", []agentllm.Message{{Role: agentllm.RoleUser, Content: "Judge output.md:\n" + old}}, nil, agentllm.StreamOptions{}) { + blocked = blocked || ev.Kind == agentllm.KindError + } + if seen || !blocked { + t.Fatalf("old workflow output reached a separate judge guard: seen=%v blocked=%v", seen, blocked) + } +} + func (*wfFake) Surfaces() []core.SurfaceSnapshot { return nil } diff --git a/internal/store/migrate.go b/internal/store/migrate.go index 5f26e2c..f5ab653 100644 --- a/internal/store/migrate.go +++ b/internal/store/migrate.go @@ -862,6 +862,13 @@ func init() { }, down: map[string][]string{"sqlite": {`DROP INDEX IF EXISTS uniq_context_manifest_terminal`, `DROP INDEX IF EXISTS idx_context_manifests_owner_target`, `DROP TABLE IF EXISTS context_manifests`}, "postgres": {`DROP INDEX IF EXISTS uniq_context_manifest_terminal`, `DROP INDEX IF EXISTS idx_context_manifests_owner_target`, `DROP TABLE IF EXISTS context_manifests`}}, }, + migration{version: 33, name: "workflow_step_sources", + up: map[string][]string{ + "sqlite": {`CREATE TABLE workflow_step_sources(run_id TEXT NOT NULL,step_id TEXT NOT NULL,owner TEXT NOT NULL,project_id TEXT NOT NULL,step_attempt_id TEXT NOT NULL,output_sha256 TEXT NOT NULL,attempt_id TEXT NOT NULL,authorization_epoch TEXT NOT NULL,publication_epoch TEXT NOT NULL,watermark TEXT NOT NULL,version TEXT NOT NULL,created_at TEXT NOT NULL,PRIMARY KEY(run_id,step_id),FOREIGN KEY(run_id) REFERENCES runs(id) ON DELETE CASCADE)`}, + "postgres": {`CREATE TABLE workflow_step_sources(run_id TEXT NOT NULL,step_id TEXT NOT NULL,owner TEXT NOT NULL,project_id TEXT NOT NULL,step_attempt_id TEXT NOT NULL,output_sha256 TEXT NOT NULL,attempt_id TEXT NOT NULL,authorization_epoch TEXT NOT NULL,publication_epoch TEXT NOT NULL,watermark TEXT NOT NULL,version TEXT NOT NULL,created_at TEXT NOT NULL,PRIMARY KEY(run_id,step_id),FOREIGN KEY(run_id) REFERENCES runs(id) ON DELETE CASCADE)`}, + }, + down: map[string][]string{"sqlite": {`DROP TABLE IF EXISTS workflow_step_sources`}, "postgres": {`DROP TABLE IF EXISTS workflow_step_sources`}}, + }, ) } diff --git a/internal/store/migrate_compat.go b/internal/store/migrate_compat.go index 6458fd4..efb7cb2 100644 --- a/internal/store/migrate_compat.go +++ b/internal/store/migrate_compat.go @@ -37,6 +37,7 @@ var migrationBreaksOldReaders = map[int]bool{ 30: false, // project_event_publication_proofs：新表，旧读者不受影响 31: false, // work_task_bindings：新增绑定表，旧后台任务读面不受影响 32: false, // trusted_context_manifests：独立可信回执表，旧读者不受影响 + 33: false, // workflow_step_sources：新增逐步骤来源绑定表，旧读者不受影响 } // SchemaTarget 是本二进制会迁移到的 schema 版本。 diff --git a/internal/store/workflow_step_source.go b/internal/store/workflow_step_source.go new file mode 100644 index 0000000..3ff9efd --- /dev/null +++ b/internal/store/workflow_step_source.go @@ -0,0 +1,128 @@ +package store + +import ( + "crypto/sha256" + "database/sql" + "encoding/hex" + "encoding/json" + "errors" + "fmt" + "time" + + "agent-system-backend/pkg/extension" +) + +type WorkflowStepSource struct { + RunID, StepID, Owner, ProjectID, StepAttemptID string + OutputSHA256 [32]byte + AttemptID, AuthorizationEpoch, PublicationEpoch, Watermark, Version string +} + +// UnbindWorkflowStepSource removes an earlier attempt before the engine begins +// another execution of the same step. A failed/unknown retry cannot inherit a +// previous output's proof, even if the output bytes happen to be identical. +func (s *Store) UnbindWorkflowStepSource(owner, runID, stepID string) error { + if owner == "" || runID == "" || stepID == "" { + return errors.New("workflow step source scope is incomplete") + } + _, err := s.db.Exec(s.q(`DELETE FROM workflow_step_sources WHERE owner=? AND run_id=? AND step_id=?`), owner, runID, stepID) + return err +} + +// BindWorkflowStepSource associates a materialized prompt step with only the +// responded model receipts created during that step. The caller must have +// excluded parallel prompt execution, whose receipt attribution is ambiguous. +func (s *Store) BindWorkflowStepSource(owner, runID, stepID, stepAttemptID, kind string, startedAt time.Time, output []byte) (WorkflowStepSource, error) { + if kind != "prompt" || owner == "" || runID == "" || stepID == "" || stepAttemptID == "" || startedAt.IsZero() { + return WorkflowStepSource{}, errors.New("workflow step source requires a started prompt step") + } + run, err := s.GetRunByID(runID) + if err != nil || run.Owner != owner || run.ProjectID == "" { + return WorkflowStepSource{}, ErrNotFound + } + rows, err := s.db.Query(s.q(`SELECT created_at,manifest_json FROM context_manifests WHERE owner=? AND target_id=? AND delivery='responded'`), owner, runID) + if err != nil { + return WorkflowStepSource{}, err + } + defer rows.Close() + var latest extension.ProjectContextManifest + var latestAt time.Time + for rows.Next() { + var atRaw, raw string + if err := rows.Scan(&atRaw, &raw); err != nil { + return WorkflowStepSource{}, err + } + at, err := time.Parse(time.RFC3339Nano, atRaw) + if err != nil { + return WorkflowStepSource{}, err + } + if at.Before(startedAt) { + continue + } + var m extension.ProjectContextManifest + if err := json.Unmarshal([]byte(raw), &m); err != nil { + return WorkflowStepSource{}, err + } + if m.WorkflowStepAttemptID != stepAttemptID { + continue + } + if m.ProjectID != run.ProjectID || m.AuthorizationEpoch == "" || m.PublicationEpoch == "" || m.AttemptID == "" { + return WorkflowStepSource{}, errors.New("workflow step model receipt lacks trusted project epochs") + } + if !latestAt.IsZero() && (m.ProjectID != latest.ProjectID || m.AuthorizationEpoch != latest.AuthorizationEpoch || m.PublicationEpoch != latest.PublicationEpoch || m.Watermark != latest.Watermark) { + return WorkflowStepSource{}, errors.New("workflow step model receipts span project authorization revisions") + } + if latestAt.IsZero() || at.After(latestAt) { + latest, latestAt = m, at + } + } + if err := rows.Err(); err != nil { + return WorkflowStepSource{}, err + } + if latestAt.IsZero() { + return WorkflowStepSource{}, errors.New("workflow prompt output has no responded model receipt") + } + b := WorkflowStepSource{RunID: runID, StepID: stepID, Owner: owner, ProjectID: string(run.ProjectID), StepAttemptID: stepAttemptID, OutputSHA256: sha256.Sum256(output), + AttemptID: latest.AttemptID, AuthorizationEpoch: latest.AuthorizationEpoch, PublicationEpoch: latest.PublicationEpoch, Watermark: latest.Watermark, Version: latest.Version} + _, err = s.db.Exec(s.q(`INSERT INTO workflow_step_sources(run_id,step_id,owner,project_id,step_attempt_id,output_sha256,attempt_id,authorization_epoch,publication_epoch,watermark,version,created_at) VALUES(?,?,?,?,?,?,?,?,?,?,?,?) ON CONFLICT(run_id,step_id) DO UPDATE SET owner=excluded.owner,project_id=excluded.project_id,step_attempt_id=excluded.step_attempt_id,output_sha256=excluded.output_sha256,attempt_id=excluded.attempt_id,authorization_epoch=excluded.authorization_epoch,publication_epoch=excluded.publication_epoch,watermark=excluded.watermark,version=excluded.version,created_at=excluded.created_at`), + runID, stepID, owner, b.ProjectID, b.StepAttemptID, hex.EncodeToString(b.OutputSHA256[:]), b.AttemptID, b.AuthorizationEpoch, b.PublicationEpoch, b.Watermark, b.Version, nowISO()) + if err != nil { + return WorkflowStepSource{}, fmt.Errorf("bind workflow step output: %w", err) + } + return b, nil +} + +func (s *Store) WorkflowStepSource(owner, runID, stepID string) (WorkflowStepSource, error) { + var b WorkflowStepSource + var hash string + err := s.db.QueryRow(s.q(`SELECT run_id,step_id,owner,project_id,step_attempt_id,output_sha256,attempt_id,authorization_epoch,publication_epoch,watermark,version FROM workflow_step_sources WHERE owner=? AND run_id=? AND step_id=?`), + owner, runID, stepID).Scan(&b.RunID, &b.StepID, &b.Owner, &b.ProjectID, &b.StepAttemptID, &hash, &b.AttemptID, &b.AuthorizationEpoch, &b.PublicationEpoch, &b.Watermark, &b.Version) + if errors.Is(err, sql.ErrNoRows) { + return WorkflowStepSource{}, ErrNotFound + } + if err != nil { + return WorkflowStepSource{}, err + } + decoded, err := hex.DecodeString(hash) + if err != nil || len(decoded) != len(b.OutputSHA256) { + return WorkflowStepSource{}, errors.New("workflow step source has invalid output hash") + } + copy(b.OutputSHA256[:], decoded) + return b, nil +} + +func (s *Store) RespondedContextManifest(owner, runID, attemptID string) (extension.ProjectContextManifest, error) { + var raw string + err := s.db.QueryRow(s.q(`SELECT manifest_json FROM context_manifests WHERE owner=? AND target_id=? AND attempt_id=? AND delivery='responded'`), owner, runID, attemptID).Scan(&raw) + if errors.Is(err, sql.ErrNoRows) { + return extension.ProjectContextManifest{}, ErrNotFound + } + if err != nil { + return extension.ProjectContextManifest{}, err + } + var m extension.ProjectContextManifest + if err := json.Unmarshal([]byte(raw), &m); err != nil { + return extension.ProjectContextManifest{}, err + } + return m, nil +} diff --git a/internal/store/workflow_step_source_test.go b/internal/store/workflow_step_source_test.go new file mode 100644 index 0000000..2c68602 --- /dev/null +++ b/internal/store/workflow_step_source_test.go @@ -0,0 +1,75 @@ +package store + +import ( + "crypto/sha256" + "path/filepath" + "testing" + "time" + + "agent-system-backend/pkg/extension" + core "agent-system-core" +) + +func TestWorkflowStepSourceRequiresRespondedManifestAndExactRunStep(t *testing.T) { + st, err := OpenSQLite(filepath.Join(t.TempDir(), "step.db")) + if err != nil { + t.Fatal(err) + } + defer st.Close() + p, err := st.CreateProject("alice", "P") + if err != nil { + t.Fatal(err) + } + c, err := st.CreateConversation("alice", string(p.ID), "C", "") + if err != nil { + t.Fatal(err) + } + r := core.Run{Owner: "alice", ConversationID: c.ID, ProjectID: p.ID, Kind: core.RunConversation, Status: core.RunPending} + if err := st.CreateRun(&r); err != nil { + t.Fatal(err) + } + started := time.Now().Add(-time.Second) + m := extension.ProjectContextManifest{ProjectID: p.ID, AttemptID: "attempt-1", WorkflowStepAttemptID: "engine-run/draft/1", Delivery: "attempted", InputSHA256: "input", AuthorizationEpoch: "duty-1", PublicationEpoch: "pub-1", Watermark: "w1"} + if err := st.AppendContextManifest("alice", string(r.ID), m); err != nil { + t.Fatal(err) + } + if _, err := st.BindWorkflowStepSource("alice", string(r.ID), "draft", "engine-run/draft/1", "prompt", started, []byte("old body")); err == nil { + t.Fatal("unanswered model attempt bound output") + } + unrelated := m + unrelated.AttemptID = "other-model-attempt" + unrelated.WorkflowStepAttemptID = "engine-run/other/1" + if err := st.AppendContextManifest("alice", string(r.ID), unrelated); err != nil { + t.Fatal(err) + } + unrelated.Delivery = "responded" + if err := st.AppendContextManifest("alice", string(r.ID), unrelated); err != nil { + t.Fatal(err) + } + if _, err := st.BindWorkflowStepSource("alice", string(r.ID), "draft", "engine-run/draft/1", "prompt", started, []byte("old body")); err == nil { + t.Fatal("another step's responded attempt bound draft output") + } + m.Delivery = "responded" + if err := st.AppendContextManifest("alice", string(r.ID), m); err != nil { + t.Fatal(err) + } + bound, err := st.BindWorkflowStepSource("alice", string(r.ID), "draft", "engine-run/draft/1", "prompt", started, []byte("old body")) + if err != nil || bound.AttemptID != "attempt-1" || bound.StepAttemptID != "engine-run/draft/1" || bound.OutputSHA256 != sha256.Sum256([]byte("old body")) { + t.Fatalf("source binding missed actual output: %+v err=%v", bound, err) + } + if _, err := st.WorkflowStepSource("alice", string(r.ID), "other"); err == nil { + t.Fatal("another step reused output binding") + } + if _, err := st.WorkflowStepSource("bob", string(r.ID), "draft"); err == nil { + t.Fatal("another owner read output binding") + } + if _, err := st.BindWorkflowStepSource("alice", string(r.ID), "tool", "engine-run/tool/1", "tool", started, []byte("tool body")); err == nil { + t.Fatal("tool output bound as model-sourced material") + } + if err := st.UnbindWorkflowStepSource("alice", string(r.ID), "draft"); err != nil { + t.Fatal(err) + } + if _, err := st.WorkflowStepSource("alice", string(r.ID), "draft"); err == nil { + t.Fatal("retry retained an earlier source binding") + } +} diff --git a/internal/wfcompile/host.go b/internal/wfcompile/host.go index 67434b6..b0ca13a 100644 --- a/internal/wfcompile/host.go +++ b/internal/wfcompile/host.go @@ -36,6 +36,15 @@ type Host interface { Tools() []core.ToolDesc } +// ProjectStepProvenance is implemented by the trusted Backend run host. Prompt +// output is bound after materialization; a critic must verify the exact bytes +// and current project authorization before it includes output in a model call. +type ProjectStepProvenance interface { + InvalidateProjectStepOutput(context.Context, string) error + BindProjectStepOutput(context.Context, string, string, string, time.Time, []byte) error + VerifyProjectStepOutput(context.Context, string, string, string, []byte) error +} + // Spawner 可选子代理派发能力（脚本回调 agent.spawn 用）。 type Spawner interface { SpawnAgent(agentID, name, task, hint string) (core.AgentResultPayload, error) @@ -74,10 +83,11 @@ const ( // hostRunner 宿主 intent 步执行器（squad.IntentRunner 实现）。 type hostRunner struct { - rc Host - deps Deps - scripts map[string]string - subOf map[string]string + rc Host + deps Deps + scripts map[string]string + subOf map[string]string + stepKinds map[string]string mu sync.Mutex verdicts map[string]string // verdict 字段 → 最近一次判定 @@ -421,6 +431,20 @@ func (r *hostRunner) doCritic(ctx context.Context, step squad.IntentStep) (strin target := step.Slots["target_step"] field := step.Slots["verdict_field"] output := r.readStepOutput(step.WorkDir, target) + if r.rc.Run().ProjectID != "" { + guard, ok := r.rc.(ProjectStepProvenance) + if !ok { + return "", nil, fmt.Errorf("项目工作流产物缺少可信来源校验") + } + wsDir := filepath.Dir(filepath.Dir(step.WorkDir)) + stepAttemptID, err := completedStepAttempt(wsDir, target) + if err != nil { + return "", nil, fmt.Errorf("项目工作流步骤 %s 状态不可核验: %w", target, err) + } + if err := guard.VerifyProjectStepOutput(ctx, target, stepAttemptID, r.stepKinds[target], []byte(output)); err != nil { + return "", nil, fmt.Errorf("项目工作流步骤 %s 产物依据不可用: %w", target, err) + } + } verdict := r.judge(ctx, step.Slots["goal"], step.Slots["criteria"], output) fields := map[string]string{} if verdict.Passed { diff --git a/internal/wfcompile/project_backend.go b/internal/wfcompile/project_backend.go new file mode 100644 index 0000000..47e2e1c --- /dev/null +++ b/internal/wfcompile/project_backend.go @@ -0,0 +1,37 @@ +package wfcompile + +import ( + "context" + + "agent-squad/squad" + "agent-system-backend/internal/projectcontext" +) + +// projectStepBackends carries the engine-generated execution ID through the +// executor's request context into each model manifest. This associates a +// responded model request with exactly one workflow step attempt. +func projectStepBackends(base *squad.BackendResolver) *squad.BackendResolver { + wrapped := squad.NewBackendResolver() + for _, name := range base.ListBackends() { + backendName := name + wrapped.Register(backendName, func(role squad.RoleSpec) (squad.Executor, error) { + backend, _, err := base.Resolve(role, backendName) + if err != nil { + return nil, err + } + return &projectStepExecutor{next: backend}, nil + }) + } + return wrapped +} + +type projectStepExecutor struct{ next squad.Executor } + +func (e *projectStepExecutor) Name() string { return e.next.Name() } + +func (e *projectStepExecutor) Execute(ctx context.Context, req squad.ExecRequest) (*squad.ExecResult, error) { + if req.ExecutionID == "" { + return &squad.ExecResult{Success: false, ErrorReason: "project workflow step attempt unavailable"}, nil + } + return e.next.Execute(projectcontext.WithWorkflowStepAttempt(ctx, req.ExecutionID), req) +} diff --git a/internal/wfcompile/project_sources.go b/internal/wfcompile/project_sources.go new file mode 100644 index 0000000..0c971ab --- /dev/null +++ b/internal/wfcompile/project_sources.go @@ -0,0 +1,107 @@ +package wfcompile + +import ( + "context" + "errors" + "os" + "path/filepath" + "sync" + "time" + + "agent-squad/squad" +) + +// completedStepAttempt comes from the squad engine's persisted state, not a +// model response or plugin argument. It identifies the exact execution that +// produced output.md, including after a workflow resumes. +func completedStepAttempt(wsDir, stepID string) (string, error) { + state, err := (squad.FileStore{}).LoadRun(wsDir) + if err != nil { + return "", err + } + for _, step := range state.Plan.Workflow.Steps { + if step.ID == stepID && step.Status == "completed" && step.AttemptID != "" { + return step.AttemptID, nil + } + } + return "", errors.New("completed step attempt unavailable") +} + +// projectOutputSink binds only a completed prompt step's materialized bytes. +// Parallel prompt executions have no unambiguous request-to-step attribution +// in the current backend contract, so they receive no binding and the critic +// fails closed. A recovered completion without its start event likewise needs +// an existing persisted binding to pass its critic. +type projectOutputSink struct { + rc ProjectStepProvenance + ctx context.Context + root string + subOf map[string]string + kinds map[string]string + mu sync.Mutex + started map[string]time.Time + ambiguous map[string]bool +} + +func newProjectOutputSink(rc Host, root string, subOf, kinds map[string]string) squad.ProgressSink { + binder := rc.(ProjectStepProvenance) + return &projectOutputSink{rc: binder, ctx: rc.Context(), root: root, subOf: subOf, kinds: kinds, + started: map[string]time.Time{}, ambiguous: map[string]bool{}} +} + +func (s *projectOutputSink) Emit(ev squad.Event) { + if ev.StepID == "" { + return + } + s.mu.Lock() + switch ev.Type { + case squad.EvStepStarted: + if s.kinds[ev.StepID] == "prompt" { + if err := s.rc.InvalidateProjectStepOutput(s.ctx, ev.StepID); err != nil { + s.ambiguous[ev.StepID] = true + } + } + if len(s.started) != 0 { + if s.kinds[ev.StepID] == "prompt" { + s.ambiguous[ev.StepID] = true + } + for id := range s.started { + if s.kinds[id] == "prompt" { + s.ambiguous[id] = true + } + } + } + s.started[ev.StepID] = ev.At + s.mu.Unlock() + return + case squad.EvStepCompleted: + startedAt, started := s.started[ev.StepID] + ambiguous := s.ambiguous[ev.StepID] + delete(s.started, ev.StepID) + delete(s.ambiguous, ev.StepID) + s.mu.Unlock() + if s.kinds[ev.StepID] != "prompt" || !started || startedAt.IsZero() || ambiguous { + return + } + sub := s.subOf[ev.StepID] + if sub == "" { + return + } + data, err := os.ReadFile(filepath.Join(s.root, "runs", ev.RunID, filepath.FromSlash(sub), "output.md")) + if err == nil { + wsDir := filepath.Join(s.root, "runs", ev.RunID) + attemptID, attemptErr := completedStepAttempt(wsDir, ev.StepID) + if attemptErr == nil { + _ = s.rc.BindProjectStepOutput(s.ctx, ev.StepID, attemptID, "prompt", startedAt, data) + } + } + return + case squad.EvStepFailed: + delete(s.started, ev.StepID) + delete(s.ambiguous, ev.StepID) + s.mu.Unlock() + return + default: + s.mu.Unlock() + } +} diff --git a/internal/wfcompile/run.go b/internal/wfcompile/run.go index 661c5bf..8799e13 100644 --- a/internal/wfcompile/run.go +++ b/internal/wfcompile/run.go @@ -76,6 +76,15 @@ func RunCompiled(rc Host, deps Deps, launch workflow.Launch, vars workflow.Vars, if err != nil { return Outcome{}, err } + stepKinds := make(map[string]string, len(def.Steps)) + for _, step := range def.Steps { + stepKinds[step.ID] = step.Kind + } + if rc.Run().ProjectID != "" { + if _, ok := rc.(ProjectStepProvenance); !ok { + return Outcome{}, fmt.Errorf("项目工作流缺少可信步骤产物绑定能力") + } + } registry := squad.NewRoleRegistry() for _, role := range compiled.Plan.Squad.Agents { @@ -87,9 +96,17 @@ func RunCompiled(rc Host, deps Deps, launch workflow.Launch, vars workflow.Vars, if backends == nil { backends = squad.NewBackendResolver() } + if rc.Run().ProjectID != "" { + backends = projectStepBackends(backends) + } runner := &hostRunner{ rc: rc, deps: deps, scripts: launch.Scripts, subOf: compiled.SubOf, - verdicts: map[string]string{}, lastWhy: map[string]string{}, fails: map[string]int{}, + stepKinds: stepKinds, + verdicts: map[string]string{}, lastWhy: map[string]string{}, fails: map[string]int{}, + } + var progress squad.ProgressSink = squad.NopSink{} + if rc.Run().ProjectID != "" { + progress = newProjectOutputSink(rc, filepath.Join(deps.DataDir, "wf", string(rc.Run().ID)), compiled.SubOf, stepKinds) } engine, err := squad.NewEngine(squad.Options{ DataDir: filepath.Join(deps.DataDir, "wf", string(rc.Run().ID)), @@ -102,7 +119,7 @@ func RunCompiled(rc Host, deps Deps, launch workflow.Launch, vars workflow.Vars, Checker: passChecker{}, IntentCatalog: compiled.Catalog, IntentRunner: runner, - Sink: squad.NopSink{}, + Sink: progress, }) if err != nil { return Outcome{}, fmt.Errorf("workflow: 引擎装配: %w", err) diff --git a/internal/wfcompile/wfcompile_test.go b/internal/wfcompile/wfcompile_test.go index 6881c70..a9a57e2 100644 --- a/internal/wfcompile/wfcompile_test.go +++ b/internal/wfcompile/wfcompile_test.go @@ -2,15 +2,19 @@ package wfcompile import ( "context" + "crypto/sha256" "encoding/json" "fmt" "os" + "path/filepath" "strings" "sync" "testing" + "time" agentllm "agent-native/runtime/llm" "agent-squad/squad" + "agent-system-backend/internal/projectcontext" "agent-system-backend/internal/workflow" core "agent-system-core" ) @@ -452,6 +456,118 @@ func TestRunCompiledDemoBrief(t *testing.T) { } } +type projectSourceHost struct { + *fakeHost + boundID string + boundHash [32]byte + verified int + invalidated int +} + +type stepContextProbe struct{ got string } + +func (p *stepContextProbe) Name() string { return "probe" } +func (p *stepContextProbe) Execute(ctx context.Context, _ squad.ExecRequest) (*squad.ExecResult, error) { + p.got = projectcontext.WorkflowStepAttempt(ctx) + return &squad.ExecResult{Success: true}, nil +} + +func TestProjectStepBackendCarriesEngineAttempt(t *testing.T) { + probe := &stepContextProbe{} + base := squad.NewBackendResolver() + base.RegisterInstance("probe", probe) + backend, _, err := projectStepBackends(base).Resolve(squad.RoleSpec{Role: "writer", Backend: "probe"}, "") + if err != nil { + t.Fatal(err) + } + if _, err := backend.Execute(context.Background(), squad.ExecRequest{ExecutionID: "engine-run/draft/2"}); err != nil { + t.Fatal(err) + } + if probe.got != "engine-run/draft/2" { + t.Fatalf("model backend lost trusted step attempt: %q", probe.got) + } +} + +func (h *projectSourceHost) Run() core.Run { + return core.Run{ID: "run_project_wf", ProjectID: "p1", Owner: "alice"} +} +func (h *projectSourceHost) BindProjectStepOutput(_ context.Context, stepID, stepAttemptID, kind string, startedAt time.Time, output []byte) error { + if kind != "prompt" || stepAttemptID == "" || startedAt.IsZero() { + return fmt.Errorf("untrusted step binding: %s %s %s", stepID, kind, startedAt) + } + h.boundID, h.boundHash = stepID, sha256.Sum256(output) + return nil +} +func (h *projectSourceHost) VerifyProjectStepOutput(_ context.Context, stepID, stepAttemptID, kind string, output []byte) error { + h.verified++ + if stepID != h.boundID || stepAttemptID == "" || kind != "prompt" || sha256.Sum256(output) != h.boundHash { + return fmt.Errorf("step output provenance mismatch: bound=%q/%x got=%q/%x", h.boundID, h.boundHash, stepID, sha256.Sum256(output)) + } + return nil +} +func (h *projectSourceHost) InvalidateProjectStepOutput(_ context.Context, stepID string) error { + if stepID == h.boundID { + h.boundID = "" + h.boundHash = [32]byte{} + } + h.invalidated++ + return nil +} + +func TestProjectOutputSinkRejectsConcurrentAndRetriedAttribution(t *testing.T) { + h := &projectSourceHost{fakeHost: &fakeHost{}} + root := t.TempDir() + sub := "tasks/01_draft" + path := filepath.Join(root, "runs", "engine-run", sub, "output.md") + if err := os.MkdirAll(filepath.Dir(path), 0o755); err != nil { + t.Fatal(err) + } + if err := os.WriteFile(path, []byte("model body"), 0o600); err != nil { + t.Fatal(err) + } + sink := newProjectOutputSink(h, root, map[string]string{"draft": sub}, map[string]string{"draft": "prompt", "other": "tool"}) + started := time.Now().Add(-time.Second) + if err := h.BindProjectStepOutput(context.Background(), "draft", "engine-run/draft/1", "prompt", started, []byte("old attempt")); err != nil { + t.Fatal(err) + } + sink.Emit(squad.Event{Type: squad.EvStepStarted, RunID: "engine-run", StepID: "draft", At: started}) + if err := h.VerifyProjectStepOutput(context.Background(), "draft", "engine-run/draft/1", "prompt", []byte("old attempt")); err == nil { + t.Fatal("retry retained previous attempt's binding") + } + sink.Emit(squad.Event{Type: squad.EvStepStarted, RunID: "engine-run", StepID: "other", At: started.Add(time.Millisecond)}) + sink.Emit(squad.Event{Type: squad.EvStepCompleted, RunID: "engine-run", StepID: "draft", At: time.Now()}) + if h.boundID != "" || h.invalidated == 0 { + t.Fatalf("ambiguous retry rebound output: id=%q invalidated=%d", h.boundID, h.invalidated) + } +} + +func TestProjectPromptCriticBindsActualStepOutputBeforeJudge(t *testing.T) { + f := &projectSourceHost{fakeHost: &fakeHost{hitl: []core.HITLResponse{{ChoiceID: "short"}, {ChoiceID: "yes"}}}} + be := &seqBackend{texts: []string{"draft text\n核对标记：P4"}} + _, err := RunCompiled(f, Deps{DataDir: t.TempDir(), Backends: seqResolver(t, be), DefaultBackend: "seq", JudgeStream: verdictStream(verdictPass)}, + workflow.Launch{Def: parseDef(t, demoBriefJSON)}, workflow.Vars{Input: "write", Slots: map[string]string{"topic": "topic"}}, RunOptions{}) + if err != nil { + t.Fatal(err) + } + if f.boundID != "draft" || f.boundHash != sha256.Sum256([]byte("draft text\n核对标记：P4\n")) || f.verified == 0 { + t.Fatalf("project workflow output lacked trusted step binding: id=%q verified=%d", f.boundID, f.verified) + } +} + +func TestProjectToolCriticRejectsUnprovenOutputBeforeModel(t *testing.T) { + f := &projectSourceHost{fakeHost: &fakeHost{toolNames: []string{"time_now"}}} + def := core.WorkflowDef{ID: "tool-critic", Title: "Tool review", Steps: []core.WorkflowStep{{ID: "get", Title: "Read", Kind: "tool", Tool: "time_now", Critic: &core.StepCritic{Criteria: "check"}}}} + called := false + judge := func(ctx context.Context, model string, messages []agentllm.Message, tools []agentllm.ToolDecl, opts agentllm.StreamOptions) <-chan agentllm.Event { + called = true + return verdictStream(verdictPass)(ctx, model, messages, tools, opts) + } + _, err := RunCompiled(f, Deps{DataDir: t.TempDir(), JudgeStream: judge}, workflow.Launch{Def: def}, workflow.Vars{Input: "read"}, RunOptions{}) + if err == nil || called || !strings.Contains(err.Error(), "产物依据不可用") { + t.Fatalf("unproven tool output reached judge: err=%v called=%v", err, called) + } +} + // critic 预算耗尽仍不通过 → 工作流失败（P4 fail-closed）。 func TestRunCompiledCriticExhaustedFails(t *testing.T) { def := parseDef(t, demoBriefJSON) diff --git a/pkg/extension/project_context.go b/pkg/extension/project_context.go index ad85007..2010b0c 100644 --- a/pkg/extension/project_context.go +++ b/pkg/extension/project_context.go @@ -112,22 +112,23 @@ type ProjectContextManifestEntry struct { // ProjectContextManifest describes the text actually passed to the completion // client. Candidate references in a bundle are never listed as included input. type ProjectContextManifest struct { - ProjectID core.ID - TaskID string - Version string - Watermark string - AuthorizationEpoch string - PublicationEpoch string - AttemptID string - Delivery string // attempted | responded | unknown; never implies user-visible delivery - Model string - BudgetChars int - InputSHA256 string - Included []ProjectContextManifestEntry - Dropped []ProjectContextManifestEntry - OfferedReferences []ProjectEvidenceRef - ReadEvidence []ProjectContextManifestEntry - Missing []string + ProjectID core.ID + TaskID string + Version string + Watermark string + AuthorizationEpoch string + PublicationEpoch string + AttemptID string + WorkflowStepAttemptID string + Delivery string // attempted | responded | unknown; never implies user-visible delivery + Model string + BudgetChars int + InputSHA256 string + Included []ProjectContextManifestEntry + Dropped []ProjectContextManifestEntry + OfferedReferences []ProjectEvidenceRef + ReadEvidence []ProjectContextManifestEntry + Missing []string } type WorkCompletionResult struct { -- 2.54.0 From 6ba53e43ede296e192bb8875d284ba5a9dc27acc Mon Sep 17 00:00:00 2001 From: weichen Date: Wed, 14 Oct 2026 05:08:35 +0000 Subject: [PATCH 08/41] Preserve workflow model Resolve scopes for source checks Why: A goal-sensitive project provider can return different authorized sources for a prompt step and its judge, causing a valid workflow to fail when the judge re-resolves with an empty goal. Evidence: RED goal-sensitive step test; full compiled workflow positive and withdrawal negative tests; go test ./... -count=1 and targeted race passed locally before commit. Impact: Persist each trusted model attempt selector outside the public manifest, enforce receipt state continuity, and reauthorize every contributing model turn with its original selector before judging. Refs: RDM two-trees stage5 W6; W6 independent review P2. --- internal/projectcontext/workflow_step.go | 15 ++ internal/runmgr/project_context.go | 92 +++++++----- internal/runmgr/project_context_test.go | 154 +++++++++++++++++++- internal/runtime/project_stream.go | 4 +- internal/store/context_manifest.go | 37 ++++- internal/store/context_manifest_test.go | 23 +++ internal/store/migrate.go | 10 ++ internal/store/migrate_compat.go | 1 + internal/store/workflow_step_source.go | 54 ++++++- internal/store/workflow_step_source_test.go | 21 ++- 10 files changed, 360 insertions(+), 51 deletions(-) diff --git a/internal/projectcontext/workflow_step.go b/internal/projectcontext/workflow_step.go index 048d808..186adbf 100644 --- a/internal/projectcontext/workflow_step.go +++ b/internal/projectcontext/workflow_step.go @@ -3,6 +3,9 @@ package projectcontext import "context" type workflowStepAttemptKey struct{} +type resolveScopeKey struct{} + +type resolveScope struct{ goal, targetID string } // WithWorkflowStepAttempt is used by the trusted squad executor adapter. The // value comes from the engine's persisted step attempt, never from model text. @@ -14,3 +17,15 @@ func WorkflowStepAttempt(ctx context.Context) string { value, _ := ctx.Value(workflowStepAttemptKey{}).(string) return value } + +// WithResolveScope carries the exact selector used for this model request to +// Backend's trusted receipt writer. It is saved separately from the public +// final-input manifest and survives a resumed workflow judge. +func WithResolveScope(ctx context.Context, goal, targetID string) context.Context { + return context.WithValue(ctx, resolveScopeKey{}, resolveScope{goal: goal, targetID: targetID}) +} + +func ResolveScope(ctx context.Context) (goal, targetID string, ok bool) { + scope, ok := ctx.Value(resolveScopeKey{}).(resolveScope) + return scope.goal, scope.targetID, ok +} diff --git a/internal/runmgr/project_context.go b/internal/runmgr/project_context.go index 072e671..763eb84 100644 --- a/internal/runmgr/project_context.go +++ b/internal/runmgr/project_context.go @@ -11,6 +11,7 @@ import ( agentllm "agent-native/runtime/llm" "agent-system-backend/internal/projectcontext" + "agent-system-backend/internal/store" "agent-system-backend/pkg/extension" core "agent-system-core" ) @@ -182,6 +183,10 @@ func (c *runCtx) SaveContextManifest(ctx context.Context, m extension.ProjectCon if run.Owner != c.run.Owner || run.ProjectID != c.run.ProjectID || run.ConversationID != c.run.ConversationID || m.ProjectID != run.ProjectID { return errors.New("context manifest run scope mismatch") } + resolveGoal, resolveTarget, scopeBound := projectcontext.ResolveScope(ctx) + if scopeBound && resolveTarget != "" { + return errors.New("run context does not support a model-selected Resolve target") + } // A response/unknown receipt records an already attempted transport. A // revocation after send must not erase that audit fact. if m.Delivery != "responded" && m.Delivery != "unknown" { @@ -191,6 +196,10 @@ func (c *runCtx) SaveContextManifest(ctx context.Context, m extension.ProjectCon } if c.mgr.projectContextResolver != nil && m.Delivery != "responded" && m.Delivery != "unknown" { resolvedReq := c.contextRequest() + if scopeBound { + resolvedReq = extension.ProjectContextRequest{Actor: string(run.Owner), ProjectID: run.ProjectID, + ConversationID: run.ConversationID, RunID: run.ID, Goal: resolveGoal, TargetID: resolveTarget, BudgetChars: m.BudgetChars} + } if resolvedReq.RunID != run.ID || resolvedReq.ProjectID != run.ProjectID { return errors.New("context manifest missing resolved run scope") } @@ -247,6 +256,10 @@ func (c *runCtx) SaveContextManifest(ctx context.Context, m extension.ProjectCon } } } + if scopeBound { + return c.mgr.st.AppendContextManifestWithScope(string(run.Owner), string(run.ID), m, + store.ContextManifestScope{Goal: resolveGoal, TargetID: resolveTarget, Bound: true}) + } return c.mgr.st.AppendContextManifest(string(run.Owner), string(run.ID), m) } @@ -266,17 +279,12 @@ func (c *runCtx) BindProjectStepOutput(ctx context.Context, stepID, stepAttemptI if kind != "prompt" || !c.ProjectContextEnabled() { return errors.New("project prompt step provenance unavailable") } - bundle, active, err := c.ProjectContext(ctx, "", 12000) - if err != nil || !active { - return errors.New("project step current scope unavailable") - } - bound, err := c.mgr.st.BindWorkflowStepSource(string(c.run.Owner), string(c.run.ID), stepID, stepAttemptID, kind, startedAt, output) + _, err := c.mgr.st.BindWorkflowStepSource(string(c.run.Owner), string(c.run.ID), stepID, stepAttemptID, kind, startedAt, output) if err != nil { return err } - if bound.ProjectID != string(bundle.ProjectID) || bound.AuthorizationEpoch != bundle.AuthorizationEpoch || - bound.PublicationEpoch != bundle.PublicationEpoch || bound.Watermark != bundle.Watermark { - return errors.New("project step source changed before binding") + if err := c.VerifyProjectStepOutput(ctx, stepID, stepAttemptID, kind, output); err != nil { + return errors.Join(err, c.mgr.st.UnbindWorkflowStepSource(string(c.run.Owner), string(c.run.ID), stepID)) } return nil } @@ -295,39 +303,53 @@ func (c *runCtx) VerifyProjectStepOutput(ctx context.Context, stepID, stepAttemp if bound.ProjectID != string(c.run.ProjectID) || bound.StepAttemptID != stepAttemptID || bound.OutputSHA256 != sha256.Sum256(output) { return errors.New("project workflow output bytes or project scope changed") } - receipt, err := c.mgr.st.RespondedContextManifest(string(c.run.Owner), string(c.run.ID), bound.AttemptID) - if err != nil || receipt.ProjectID != c.run.ProjectID || receipt.WorkflowStepAttemptID != stepAttemptID || receipt.AuthorizationEpoch != bound.AuthorizationEpoch || - receipt.PublicationEpoch != bound.PublicationEpoch || receipt.Watermark != bound.Watermark || receipt.Version != bound.Version { + receipts, err := c.mgr.st.RespondedWorkflowStepManifests(string(c.run.Owner), string(c.run.ID), stepAttemptID) + if err != nil { return errors.New("project workflow output lost its trusted model source") } - current, active, err := c.ProjectContext(ctx, "", 12000) - if err != nil || !active || current.ProjectID != receipt.ProjectID || - current.AuthorizationEpoch != receipt.AuthorizationEpoch || current.PublicationEpoch != receipt.PublicationEpoch || current.Watermark != receipt.Watermark { - return errors.New("project workflow output authorization or publication changed") - } - if err := projectcontext.ValidateCurrent(receipt, current); err != nil { - return fmt.Errorf("project workflow output source changed: %w", err) - } - for _, used := range receipt.ReadEvidence { - if c.mgr.projectEvidenceReader == nil { - return errors.New("project workflow evidence reader unavailable") + matchedBound := false + for _, source := range receipts { + receipt, selector := source.Manifest, source.Scope + if !selector.Bound || selector.TargetID != "" || receipt.ProjectID != c.run.ProjectID || + receipt.WorkflowStepAttemptID != stepAttemptID || receipt.AuthorizationEpoch != bound.AuthorizationEpoch || + receipt.PublicationEpoch != bound.PublicationEpoch || receipt.Watermark != bound.Watermark || receipt.Version != bound.Version { + return errors.New("project workflow output lost its trusted model source") } - matched := false - for _, ref := range current.Evidence { - if ref.ID != used.ReferenceID || ref.SourceID != used.SourceID || ref.Revision != used.Revision || ref.Hash != used.SourceHash { - continue + if receipt.AttemptID == bound.AttemptID { + matchedBound = true + } + current, active, err := c.ProjectContext(ctx, selector.Goal, receipt.BudgetChars) + if err != nil || !active || current.ProjectID != receipt.ProjectID || + current.AuthorizationEpoch != receipt.AuthorizationEpoch || current.PublicationEpoch != receipt.PublicationEpoch || current.Watermark != receipt.Watermark { + return errors.New("project workflow output authorization or publication changed") + } + if err := projectcontext.ValidateCurrent(receipt, current); err != nil { + return fmt.Errorf("project workflow output source changed: %w", err) + } + for _, used := range receipt.ReadEvidence { + if c.mgr.projectEvidenceReader == nil { + return errors.New("project workflow evidence reader unavailable") } - scope := c.contextRequest() - scope.BudgetChars = 8000 - now, err := c.mgr.projectEvidenceReader(ctx, extension.ProjectEvidenceRequest{Scope: scope, Reference: ref}) - if err == nil && now.Reference == ref && fmt.Sprintf("%x", sha256.Sum256([]byte(now.Text))) == used.InputSHA256 { - matched = true + matched := false + for _, ref := range current.Evidence { + if ref.ID != used.ReferenceID || ref.SourceID != used.SourceID || ref.Revision != used.Revision || ref.Hash != used.SourceHash { + continue + } + scope := extension.ProjectContextRequest{Actor: string(c.run.Owner), ProjectID: c.run.ProjectID, + ConversationID: c.run.ConversationID, RunID: c.run.ID, Goal: selector.Goal, TargetID: selector.TargetID, BudgetChars: 8000} + now, err := c.mgr.projectEvidenceReader(ctx, extension.ProjectEvidenceRequest{Scope: scope, Reference: ref}) + if err == nil && now.Reference == ref && fmt.Sprintf("%x", sha256.Sum256([]byte(now.Text))) == used.InputSHA256 { + matched = true + } + break + } + if !matched { + return errors.New("project workflow evidence permission or content changed") } - break - } - if !matched { - return errors.New("project workflow evidence permission or content changed") } } + if !matchedBound { + return errors.New("project workflow output binding lost its responded model attempt") + } return nil } diff --git a/internal/runmgr/project_context_test.go b/internal/runmgr/project_context_test.go index c18aee1..290802f 100644 --- a/internal/runmgr/project_context_test.go +++ b/internal/runmgr/project_context_test.go @@ -2,12 +2,19 @@ package runmgr import ( "context" + "fmt" + "os" + "strings" "sync" "testing" "time" agentllm "agent-native/runtime/llm" + "agent-squad/squad" "agent-system-backend/internal/projectcontext" + "agent-system-backend/internal/runtime" + "agent-system-backend/internal/wfcompile" + "agent-system-backend/internal/workflow" "agent-system-backend/pkg/extension" core "agent-system-core" ) @@ -95,11 +102,12 @@ func TestProjectJudgeChecksPersistedSourceEpochAcrossGuards(t *testing.T) { } manifest.InputSHA256, manifest.AttemptID, manifest.Delivery = "input-hash", "step-attempt", "attempted" manifest.WorkflowStepAttemptID = "engine-run/draft/1" - if err := rc.SaveContextManifest(context.Background(), manifest); err != nil { + sourceCtx := projectcontext.WithResolveScope(context.Background(), "write output", "") + if err := rc.SaveContextManifest(sourceCtx, manifest); err != nil { t.Fatal(err) } manifest.Delivery = "responded" - if err := rc.SaveContextManifest(context.Background(), manifest); err != nil { + if err := rc.SaveContextManifest(sourceCtx, manifest); err != nil { t.Fatal(err) } if err := rc.BindProjectStepOutput(context.Background(), "draft", "engine-run/draft/1", "prompt", started, []byte("OLD_RESTRICTED_BODY")); err != nil { @@ -158,6 +166,148 @@ func TestProjectJudgeChecksPersistedSourceEpochAcrossGuards(t *testing.T) { } } +func TestProjectJudgeRetainsGoalSensitiveSourceScope(t *testing.T) { + st := openRecoveryStore(t) + m := newRecoveryManager(t, st) + conv := recoveryConversation(t, st) + run := recoveryRun(t, st, conv, core.RunPending) + m.SetProjectWorkAuthorization(func(context.Context, string, core.ID) (bool, error) { return true, nil }) + available := true + var goals []string + m.SetProjectContextResolver(func(_ context.Context, req extension.ProjectContextRequest) (extension.ProjectContextBundle, error) { + goals = append(goals, req.Goal) + item := extension.ProjectContextItem{SourceID: "source-b", Revision: "r1", Hash: "hb", Text: "PUBLIC_B", Required: true} + if strings.Contains(req.Goal, "draft report") && available { + item = extension.ProjectContextItem{SourceID: "source-a", Revision: "r1", Hash: "ha", Text: "AUTHORIZED_A", Required: true} + } + return extension.ProjectContextBundle{Status: extension.ProjectContextReady, ProjectID: req.ProjectID, AuthorizationEpoch: "duty-1", PublicationEpoch: "pub-1", Watermark: "w1", Items: []extension.ProjectContextItem{item}}, nil + }) + rc := &runCtx{mgr: m, run: run, ctx: context.Background()} + const goal = "draft report from approved source" + bundle, _, err := rc.ProjectContext(context.Background(), goal, 900) + if err != nil { + t.Fatal(err) + } + _, receipt, err := projectcontext.Assemble(bundle, 900) + if err != nil { + t.Fatal(err) + } + receipt.InputSHA256, receipt.AttemptID, receipt.WorkflowStepAttemptID = "input-hash", "model-attempt", "engine-run/draft/1" + receipt.Delivery = "attempted" + sourceCtx := projectcontext.WithResolveScope(context.Background(), goal, "") + if err := rc.SaveContextManifest(sourceCtx, receipt); err != nil { + t.Fatal(err) + } + receipt.Delivery = "responded" + if err := rc.SaveContextManifest(sourceCtx, receipt); err != nil { + t.Fatal(err) + } + // The final model turn uses Source B; output may still carry Source A from + // the first turn. Revalidate both receipts at the critic boundary. + bundleB, _, err := rc.ProjectContext(context.Background(), "revise using B", 900) + if err != nil { + t.Fatal(err) + } + _, second, err := projectcontext.Assemble(bundleB, 900) + if err != nil { + t.Fatal(err) + } + second.InputSHA256, second.AttemptID, second.WorkflowStepAttemptID = "second-input-hash", "model-attempt-2", "engine-run/draft/1" + secondCtx := projectcontext.WithResolveScope(context.Background(), "revise using B", "") + second.Delivery = "attempted" + if err := rc.SaveContextManifest(secondCtx, second); err != nil { + t.Fatal(err) + } + second.Delivery = "responded" + if err := rc.SaveContextManifest(secondCtx, second); err != nil { + t.Fatal(err) + } + started := time.Now().Add(-time.Second) + if err := rc.BindProjectStepOutput(context.Background(), "draft", "engine-run/draft/1", "prompt", started, []byte("report A")); err != nil { + t.Fatalf("same-scope binding rejected: %v", err) + } + if err := rc.VerifyProjectStepOutput(context.Background(), "draft", "engine-run/draft/1", "prompt", []byte("report A")); err != nil { + t.Fatalf("goal-sensitive provider rejected authorized critic: %v; goals=%q", err, goals) + } + available = false + if err := rc.VerifyProjectStepOutput(context.Background(), "draft", "engine-run/draft/1", "prompt", []byte("report A")); err == nil { + t.Fatal("withdrawn source passed goal-sensitive revalidation") + } +} + +type goalSensitiveStepBackend struct { + stream agentllm.StreamFunc + sent string +} + +func (*goalSensitiveStepBackend) Name() string { return "goal-sensitive-test" } +func (b *goalSensitiveStepBackend) Execute(ctx context.Context, req squad.ExecRequest) (*squad.ExecResult, error) { + for ev := range b.stream(ctx, "test-model", []agentllm.Message{{Role: agentllm.RoleUser, Content: req.Prompt}}, nil, agentllm.StreamOptions{}) { + if ev.Kind == agentllm.KindError { + return &squad.ExecResult{Success: false, ErrorReason: ev.Err.Error()}, nil + } + } + b.sent = req.Prompt + if err := os.WriteFile(req.WorkDir+"/output.md", []byte("AUTHORIZED_A report\n"), 0o600); err != nil { + return nil, err + } + return &squad.ExecResult{Success: true, Patches: map[string][]byte{"output.md": []byte("AUTHORIZED_A report\n")}}, nil +} + +func TestCompiledWorkflowJudgeAcceptsGoalSensitiveProviderAndRejectsWithdrawal(t *testing.T) { + st := openRecoveryStore(t) + mgr := newRecoveryManager(t, st) + conv := recoveryConversation(t, st) + run := recoveryRun(t, st, conv, core.RunPending) + mgr.SetProjectWorkAuthorization(func(context.Context, string, core.ID) (bool, error) { return true, nil }) + available := true + var resolved []string + mgr.SetProjectContextResolver(func(_ context.Context, req extension.ProjectContextRequest) (extension.ProjectContextBundle, error) { + resolved = append(resolved, req.Goal) + item := extension.ProjectContextItem{SourceID: "source-b", Revision: "r1", Hash: "hb", Text: "PUBLIC_B", Required: true} + if strings.Contains(req.Goal, "draft report") && !strings.Contains(req.Goal, "你是验收员") && available { + item = extension.ProjectContextItem{SourceID: "source-a", Revision: "r1", Hash: "ha", Text: "AUTHORIZED_A", Required: true} + } + return extension.ProjectContextBundle{Status: extension.ProjectContextReady, ProjectID: req.ProjectID, AuthorizationEpoch: "duty-1", PublicationEpoch: "pub-1", Watermark: "w1", Items: []extension.ProjectContextItem{item}}, nil + }) + rc := &runCtx{mgr: mgr, run: run, ctx: context.Background()} + stepBase := func(_ context.Context, _ string, messages []agentllm.Message, _ []agentllm.ToolDecl, _ agentllm.StreamOptions) <-chan agentllm.Event { + ch := make(chan agentllm.Event, 1) + if !strings.Contains(messages[len(messages)-1].Content, "AUTHORIZED_A") { + ch <- agentllm.Event{Kind: agentllm.KindError, Err: fmt.Errorf("draft model did not receive source A")} + } else { + ch <- agentllm.Event{Kind: agentllm.KindMessageEnd, Message: agentllm.Message{Role: agentllm.RoleAssistant, Content: "drafted"}} + } + close(ch) + return ch + } + judgeCalls := 0 + judgeBase := func(_ context.Context, _ string, messages []agentllm.Message, _ []agentllm.ToolDecl, _ agentllm.StreamOptions) <-chan agentllm.Event { + judgeCalls++ + ch := make(chan agentllm.Event, 1) + ch <- agentllm.Event{Kind: agentllm.KindMessageEnd, Message: agentllm.Message{Role: agentllm.RoleAssistant, Content: `{"passed":true,"reason":"ok","nextAction":""}`}} + close(ch) + return ch + } + backend := &goalSensitiveStepBackend{stream: runtime.GuardProjectStream(rc, "", stepBase)} + backends := squad.NewBackendResolver() + backends.RegisterInstance(backend.Name(), backend) + def := core.WorkflowDef{ID: "goal-sensitive", Title: "Report", Steps: []core.WorkflowStep{{ID: "draft", Title: "Draft", Kind: "prompt", Agent: "writer", Prompt: "draft report using the approved source", Critic: &core.StepCritic{Criteria: "contains report"}}}} + _, err := wfcompile.RunCompiled(rc, wfcompile.Deps{DataDir: t.TempDir(), Backends: backends, DefaultBackend: backend.Name(), JudgeStream: runtime.GuardProjectStream(rc, "", judgeBase)}, + workflow.Launch{Def: def}, workflow.Vars{Input: "draft report"}, wfcompile.RunOptions{}) + if err != nil || judgeCalls != 1 || backend.sent == "" { + t.Fatalf("authorized goal-sensitive workflow failed: err=%v judgeCalls=%d sent=%q resolved=%q", err, judgeCalls, backend.sent, resolved) + } + bound, err := st.WorkflowStepSource(string(run.Owner), string(run.ID), "draft") + if err != nil { + t.Fatal(err) + } + available = false + if err := rc.VerifyProjectStepOutput(context.Background(), "draft", bound.StepAttemptID, "prompt", []byte("AUTHORIZED_A report\n")); err == nil { + t.Fatal("withdrawn source A passed resumed goal-sensitive judge") + } +} + func TestContextManifestPersistsByOwnerAndRun(t *testing.T) { st := openRecoveryStore(t) m := newRecoveryManager(t, st) diff --git a/internal/runtime/project_stream.go b/internal/runtime/project_stream.go index aae73ae..31fd97c 100644 --- a/internal/runtime/project_stream.go +++ b/internal/runtime/project_stream.go @@ -146,7 +146,9 @@ func GuardProjectStream(rc any, goal string, stream agentllm.StreamFunc) agentll if sink, ok := rc.(interface { SaveContextManifest(context.Context, extension.ProjectContextManifest) error }); ok { - save = sink.SaveContextManifest + save = func(saveCtx context.Context, receipt extension.ProjectContextManifest) error { + return sink.SaveContextManifest(projectcontext.WithResolveScope(saveCtx, requestGoal, ""), receipt) + } if err := save(ctx, manifest); err != nil { return fail(err) } diff --git a/internal/store/context_manifest.go b/internal/store/context_manifest.go index 5179f6b..779f7b2 100644 --- a/internal/store/context_manifest.go +++ b/internal/store/context_manifest.go @@ -11,10 +11,29 @@ import ( const contextManifestAction = "model.context_manifest" +// ContextManifestScope records the exact trusted Resolve selector separately +// from the public final-input manifest. Bound distinguishes an intentionally +// empty goal from a legacy receipt with no recoverable selector. +type ContextManifestScope struct { + Goal, TargetID string + Bound bool +} + // AppendContextManifest writes to the trusted receipt table, never to the // plugin-writable generic audit log. A terminal state must follow a matching // attempted state for the same owner, target, project and input hash. func (s *Store) AppendContextManifest(owner, targetID string, m extension.ProjectContextManifest) error { + return s.appendContextManifest(owner, targetID, m, ContextManifestScope{}) +} + +func (s *Store) AppendContextManifestWithScope(owner, targetID string, m extension.ProjectContextManifest, scope ContextManifestScope) error { + if !scope.Bound { + return errors.New("trusted context manifest resolve scope is not bound") + } + return s.appendContextManifest(owner, targetID, m, scope) +} + +func (s *Store) appendContextManifest(owner, targetID string, m extension.ProjectContextManifest, scope ContextManifestScope) error { if owner == "" || targetID == "" || m.ProjectID == "" || m.InputSHA256 == "" || m.AttemptID == "" { return errors.New("context manifest requires owner, target, project, attempt and input hash") } @@ -31,15 +50,19 @@ func (s *Store) AppendContextManifest(owner, targetID string, m extension.Projec } defer tx.Rollback() if m.Delivery != "attempted" { - var found int - err := tx.QueryRow(s.q(`SELECT 1 FROM context_manifests WHERE attempt_id=? AND delivery='attempted' AND owner=? AND target_id=? AND project_id=? AND input_sha256=?`), - m.AttemptID, owner, targetID, m.ProjectID, m.InputSHA256).Scan(&found) + var attemptedGoal, attemptedTarget string + var attemptedBound int + err := tx.QueryRow(s.q(`SELECT resolve_goal,resolve_target_id,scope_bound FROM context_manifests WHERE attempt_id=? AND delivery='attempted' AND owner=? AND target_id=? AND project_id=? AND input_sha256=?`), + m.AttemptID, owner, targetID, m.ProjectID, m.InputSHA256).Scan(&attemptedGoal, &attemptedTarget, &attemptedBound) if errors.Is(err, sql.ErrNoRows) { return errors.New("context manifest terminal receipt lacks matching attempt") } if err != nil { return err } + if attemptedGoal != scope.Goal || attemptedTarget != scope.TargetID || (attemptedBound != 0) != scope.Bound { + return errors.New("context manifest terminal resolve scope changed") + } var terminal int err = tx.QueryRow(s.q(`SELECT 1 FROM context_manifests WHERE attempt_id=? AND delivery IN ('responded','unknown') LIMIT 1`), m.AttemptID).Scan(&terminal) if err == nil { @@ -49,8 +72,12 @@ func (s *Store) AppendContextManifest(owner, targetID string, m extension.Projec return err } } - _, err = tx.Exec(s.q(`INSERT INTO context_manifests(id,attempt_id,owner,target_id,project_id,input_sha256,delivery,manifest_json,created_at) VALUES(?,?,?,?,?,?,?,?,?)`), - NewID("ctxm"), m.AttemptID, owner, targetID, m.ProjectID, m.InputSHA256, m.Delivery, string(raw), nowISO()) + bound := 0 + if scope.Bound { + bound = 1 + } + _, err = tx.Exec(s.q(`INSERT INTO context_manifests(id,attempt_id,owner,target_id,project_id,input_sha256,delivery,manifest_json,created_at,resolve_goal,resolve_target_id,scope_bound) VALUES(?,?,?,?,?,?,?,?,?,?,?,?)`), + NewID("ctxm"), m.AttemptID, owner, targetID, m.ProjectID, m.InputSHA256, m.Delivery, string(raw), nowISO(), scope.Goal, scope.TargetID, bound) if err != nil { return fmt.Errorf("insert context manifest: %w", err) } diff --git a/internal/store/context_manifest_test.go b/internal/store/context_manifest_test.go index 7d9018d..c4411b8 100644 --- a/internal/store/context_manifest_test.go +++ b/internal/store/context_manifest_test.go @@ -36,3 +36,26 @@ func TestContextManifestTerminalRequiresMatchingAttempt(t *testing.T) { t.Fatal("one attempt acquired two terminal states") } } + +func TestContextManifestTerminalCannotChangeTrustedResolveScope(t *testing.T) { + st, err := OpenSQLite(filepath.Join(t.TempDir(), "scope.db")) + if err != nil { + t.Fatal(err) + } + defer st.Close() + m := extension.ProjectContextManifest{ProjectID: "p1", AttemptID: "model-1", WorkflowStepAttemptID: "engine/draft/1", InputSHA256: "input-hash", Delivery: "attempted"} + scope := ContextManifestScope{Goal: "draft from A", Bound: true} + if err := st.AppendContextManifestWithScope("alice", "run-1", m, scope); err != nil { + t.Fatal(err) + } + m.Delivery = "responded" + if err := st.AppendContextManifestWithScope("alice", "run-1", m, ContextManifestScope{Goal: "draft from B", Bound: true}); err == nil { + t.Fatal("terminal receipt changed its trusted Resolve goal") + } + if err := st.AppendContextManifest("alice", "run-1", m); err == nil { + t.Fatal("terminal receipt dropped its trusted Resolve scope") + } + if err := st.AppendContextManifestWithScope("alice", "run-1", m, scope); err != nil { + t.Fatal(err) + } +} diff --git a/internal/store/migrate.go b/internal/store/migrate.go index f5ab653..bf6fab9 100644 --- a/internal/store/migrate.go +++ b/internal/store/migrate.go @@ -869,6 +869,16 @@ func init() { }, down: map[string][]string{"sqlite": {`DROP TABLE IF EXISTS workflow_step_sources`}, "postgres": {`DROP TABLE IF EXISTS workflow_step_sources`}}, }, + migration{version: 34, name: "context_manifest_resolve_scope", + up: map[string][]string{ + "sqlite": {`ALTER TABLE context_manifests ADD COLUMN resolve_goal TEXT NOT NULL DEFAULT ''`, `ALTER TABLE context_manifests ADD COLUMN resolve_target_id TEXT NOT NULL DEFAULT ''`, `ALTER TABLE context_manifests ADD COLUMN scope_bound INTEGER NOT NULL DEFAULT 0`}, + "postgres": {`ALTER TABLE context_manifests ADD COLUMN resolve_goal TEXT NOT NULL DEFAULT ''`, `ALTER TABLE context_manifests ADD COLUMN resolve_target_id TEXT NOT NULL DEFAULT ''`, `ALTER TABLE context_manifests ADD COLUMN scope_bound INTEGER NOT NULL DEFAULT 0`}, + }, + down: map[string][]string{ + "sqlite": {`ALTER TABLE context_manifests DROP COLUMN scope_bound`, `ALTER TABLE context_manifests DROP COLUMN resolve_target_id`, `ALTER TABLE context_manifests DROP COLUMN resolve_goal`}, + "postgres": {`ALTER TABLE context_manifests DROP COLUMN scope_bound`, `ALTER TABLE context_manifests DROP COLUMN resolve_target_id`, `ALTER TABLE context_manifests DROP COLUMN resolve_goal`}, + }, + }, ) } diff --git a/internal/store/migrate_compat.go b/internal/store/migrate_compat.go index efb7cb2..7b17ce6 100644 --- a/internal/store/migrate_compat.go +++ b/internal/store/migrate_compat.go @@ -38,6 +38,7 @@ var migrationBreaksOldReaders = map[int]bool{ 31: false, // work_task_bindings：新增绑定表，旧后台任务读面不受影响 32: false, // trusted_context_manifests：独立可信回执表，旧读者不受影响 33: false, // workflow_step_sources：新增逐步骤来源绑定表，旧读者不受影响 + 34: false, // context_manifest_resolve_scope：可信回执增加原Resolve范围，旧读者不受影响 } // SchemaTarget 是本二进制会迁移到的 schema 版本。 diff --git a/internal/store/workflow_step_source.go b/internal/store/workflow_step_source.go index 3ff9efd..e5bbfad 100644 --- a/internal/store/workflow_step_source.go +++ b/internal/store/workflow_step_source.go @@ -40,7 +40,7 @@ func (s *Store) BindWorkflowStepSource(owner, runID, stepID, stepAttemptID, kind if err != nil || run.Owner != owner || run.ProjectID == "" { return WorkflowStepSource{}, ErrNotFound } - rows, err := s.db.Query(s.q(`SELECT created_at,manifest_json FROM context_manifests WHERE owner=? AND target_id=? AND delivery='responded'`), owner, runID) + rows, err := s.db.Query(s.q(`SELECT created_at,manifest_json,resolve_target_id,scope_bound FROM context_manifests WHERE owner=? AND target_id=? AND delivery='responded'`), owner, runID) if err != nil { return WorkflowStepSource{}, err } @@ -48,8 +48,9 @@ func (s *Store) BindWorkflowStepSource(owner, runID, stepID, stepAttemptID, kind var latest extension.ProjectContextManifest var latestAt time.Time for rows.Next() { - var atRaw, raw string - if err := rows.Scan(&atRaw, &raw); err != nil { + var atRaw, raw, resolveTarget string + var scopeBound int + if err := rows.Scan(&atRaw, &raw, &resolveTarget, &scopeBound); err != nil { return WorkflowStepSource{}, err } at, err := time.Parse(time.RFC3339Nano, atRaw) @@ -66,10 +67,13 @@ func (s *Store) BindWorkflowStepSource(owner, runID, stepID, stepAttemptID, kind if m.WorkflowStepAttemptID != stepAttemptID { continue } + if scopeBound != 1 || resolveTarget != "" { + return WorkflowStepSource{}, errors.New("workflow step model receipt lacks trusted original Resolve scope") + } if m.ProjectID != run.ProjectID || m.AuthorizationEpoch == "" || m.PublicationEpoch == "" || m.AttemptID == "" { return WorkflowStepSource{}, errors.New("workflow step model receipt lacks trusted project epochs") } - if !latestAt.IsZero() && (m.ProjectID != latest.ProjectID || m.AuthorizationEpoch != latest.AuthorizationEpoch || m.PublicationEpoch != latest.PublicationEpoch || m.Watermark != latest.Watermark) { + if !latestAt.IsZero() && (m.ProjectID != latest.ProjectID || m.AuthorizationEpoch != latest.AuthorizationEpoch || m.PublicationEpoch != latest.PublicationEpoch || m.Watermark != latest.Watermark || m.Version != latest.Version) { return WorkflowStepSource{}, errors.New("workflow step model receipts span project authorization revisions") } if latestAt.IsZero() || at.After(latestAt) { @@ -92,6 +96,48 @@ func (s *Store) BindWorkflowStepSource(owner, runID, stepID, stepAttemptID, kind return b, nil } +type ScopedContextManifest struct { + Manifest extension.ProjectContextManifest + Scope ContextManifestScope +} + +// RespondedWorkflowStepManifests returns every model response from this exact +// engine step attempt. A final output can depend on earlier model turns, so a +// critic must revalidate all of them, not just the last response. +func (s *Store) RespondedWorkflowStepManifests(owner, runID, stepAttemptID string) ([]ScopedContextManifest, error) { + if owner == "" || runID == "" || stepAttemptID == "" { + return nil, errors.New("workflow receipt scope is incomplete") + } + rows, err := s.db.Query(s.q(`SELECT manifest_json,resolve_goal,resolve_target_id,scope_bound FROM context_manifests WHERE owner=? AND target_id=? AND delivery='responded' ORDER BY created_at,id`), owner, runID) + if err != nil { + return nil, err + } + defer rows.Close() + var out []ScopedContextManifest + for rows.Next() { + var raw, goal, target string + var bound int + if err := rows.Scan(&raw, &goal, &target, &bound); err != nil { + return nil, err + } + var manifest extension.ProjectContextManifest + if err := json.Unmarshal([]byte(raw), &manifest); err != nil { + return nil, err + } + if manifest.WorkflowStepAttemptID != stepAttemptID { + continue + } + out = append(out, ScopedContextManifest{Manifest: manifest, Scope: ContextManifestScope{Goal: goal, TargetID: target, Bound: bound == 1}}) + } + if err := rows.Err(); err != nil { + return nil, err + } + if len(out) == 0 { + return nil, ErrNotFound + } + return out, nil +} + func (s *Store) WorkflowStepSource(owner, runID, stepID string) (WorkflowStepSource, error) { var b WorkflowStepSource var hash string diff --git a/internal/store/workflow_step_source_test.go b/internal/store/workflow_step_source_test.go index 2c68602..f58d9f7 100644 --- a/internal/store/workflow_step_source_test.go +++ b/internal/store/workflow_step_source_test.go @@ -30,7 +30,8 @@ func TestWorkflowStepSourceRequiresRespondedManifestAndExactRunStep(t *testing.T } started := time.Now().Add(-time.Second) m := extension.ProjectContextManifest{ProjectID: p.ID, AttemptID: "attempt-1", WorkflowStepAttemptID: "engine-run/draft/1", Delivery: "attempted", InputSHA256: "input", AuthorizationEpoch: "duty-1", PublicationEpoch: "pub-1", Watermark: "w1"} - if err := st.AppendContextManifest("alice", string(r.ID), m); err != nil { + scope := ContextManifestScope{Goal: "draft report", Bound: true} + if err := st.AppendContextManifestWithScope("alice", string(r.ID), m, scope); err != nil { t.Fatal(err) } if _, err := st.BindWorkflowStepSource("alice", string(r.ID), "draft", "engine-run/draft/1", "prompt", started, []byte("old body")); err == nil { @@ -39,18 +40,18 @@ func TestWorkflowStepSourceRequiresRespondedManifestAndExactRunStep(t *testing.T unrelated := m unrelated.AttemptID = "other-model-attempt" unrelated.WorkflowStepAttemptID = "engine-run/other/1" - if err := st.AppendContextManifest("alice", string(r.ID), unrelated); err != nil { + if err := st.AppendContextManifestWithScope("alice", string(r.ID), unrelated, scope); err != nil { t.Fatal(err) } unrelated.Delivery = "responded" - if err := st.AppendContextManifest("alice", string(r.ID), unrelated); err != nil { + if err := st.AppendContextManifestWithScope("alice", string(r.ID), unrelated, scope); err != nil { t.Fatal(err) } if _, err := st.BindWorkflowStepSource("alice", string(r.ID), "draft", "engine-run/draft/1", "prompt", started, []byte("old body")); err == nil { t.Fatal("another step's responded attempt bound draft output") } m.Delivery = "responded" - if err := st.AppendContextManifest("alice", string(r.ID), m); err != nil { + if err := st.AppendContextManifestWithScope("alice", string(r.ID), m, scope); err != nil { t.Fatal(err) } bound, err := st.BindWorkflowStepSource("alice", string(r.ID), "draft", "engine-run/draft/1", "prompt", started, []byte("old body")) @@ -66,6 +67,18 @@ func TestWorkflowStepSourceRequiresRespondedManifestAndExactRunStep(t *testing.T if _, err := st.BindWorkflowStepSource("alice", string(r.ID), "tool", "engine-run/tool/1", "tool", started, []byte("tool body")); err == nil { t.Fatal("tool output bound as model-sourced material") } + legacy := m + legacy.AttemptID, legacy.WorkflowStepAttemptID, legacy.Delivery = "legacy-model", "engine-run/legacy/1", "attempted" + if err := st.AppendContextManifest("alice", string(r.ID), legacy); err != nil { + t.Fatal(err) + } + legacy.Delivery = "responded" + if err := st.AppendContextManifest("alice", string(r.ID), legacy); err != nil { + t.Fatal(err) + } + if _, err := st.BindWorkflowStepSource("alice", string(r.ID), "legacy", "engine-run/legacy/1", "prompt", started, []byte("legacy body")); err == nil { + t.Fatal("model receipt without bound original Resolve scope became a workflow source") + } if err := st.UnbindWorkflowStepSource("alice", string(r.ID), "draft"); err != nil { t.Fatal(err) } -- 2.54.0 From ecb86f4309193bf40b0c3b2846de68eae3a2dcdb Mon Sep 17 00:00:00 2001 From: weichen Date: Wed, 14 Oct 2026 05:38:11 +0000 Subject: [PATCH 09/41] Recheck project workflow sources without storing prompts Why: Goal-sensitive workflow verification persisted model prompts and prior output text in trusted receipt rows, while cross-step model inputs could reuse stale machine output. Evidence: RED receipt privacy test; full Go suite, targeted race, isolated PostgreSQL store/runmgr/storage-migrate tests, vet, and static build passed locally before commit. A known unrelated TempDir cleanup flake failed once and passed on targeted and serial full replay. Impact: Add optional same-provider source recheck, verify every included item and evidence body before reuse, gate cross-step outputs, reject unsettled attempts, remove raw scope columns, scrub isolated candidate v34 SQLite/PG schemas, and reject unsafe backups. Refs: Approved RDM stage6 W6 source-recheck design adjustment r1; W6 independent review. --- cmd/storage-migrate/integration_test.go | 43 +++++ cmd/storage-migrate/main.go | 23 +++ cmd/storage-migrate/main_test.go | 53 ++++++ internal/app/app.go | 1 + internal/app/project_context.go | 27 +++ internal/app/project_context_test.go | 44 ++++- internal/projectcontext/context.go | 10 +- internal/projectcontext/context_test.go | 11 +- internal/runmgr/project_context.go | 194 ++++++++++++++------ internal/runmgr/project_context_test.go | 156 +++++++++++++++- internal/runmgr/runmgr.go | 1 + internal/runtime/project_context_test.go | 16 +- internal/runtime/workflow_compiled_test.go | 2 +- internal/store/context_manifest.go | 19 +- internal/store/context_manifest_test.go | 134 +++++++++++++- internal/store/migrate.go | 73 +++++++- internal/store/migrate_compat.go | 1 + internal/store/workflow_step_source.go | 52 +++++- internal/store/workflow_step_source_test.go | 17 +- internal/wfcompile/host.go | 11 ++ internal/wfcompile/project_backend.go | 17 +- internal/wfcompile/project_sources.go | 36 ++++ internal/wfcompile/run.go | 5 +- internal/wfcompile/wfcompile_test.go | 17 +- pkg/extension/project_context.go | 21 +++ pkg/extension/surface.txt | 4 + 26 files changed, 884 insertions(+), 104 deletions(-) diff --git a/cmd/storage-migrate/integration_test.go b/cmd/storage-migrate/integration_test.go index d4997c0..5fa87c9 100644 --- a/cmd/storage-migrate/integration_test.go +++ b/cmd/storage-migrate/integration_test.go @@ -9,8 +9,51 @@ import ( "testing" "agent-system-backend/internal/store" + "agent-system-backend/pkg/extension" ) +func TestMigrateTrustedContextManifestWithoutRawScope(t *testing.T) { + target, cleanup := pgSchemaDSN(t) + defer cleanup() + fixture := buildFixture(t) + src, err := store.OpenSQLite(fixture) + if err != nil { + t.Fatal(err) + } + m := extension.ProjectContextManifest{ProjectID: "p1", AttemptID: "model-attempt", InputSHA256: "request-hash", Delivery: "attempted", + Included: []extension.ProjectContextManifestEntry{{SourceID: "source-a", Revision: "r1", SourceHash: "ha", InputSHA256: "input-hash"}}} + if err := src.AppendContextManifestWithScope("alice", "r1", m, store.ContextManifestScope{Bound: true}); err != nil { + t.Fatal(err) + } + m.Delivery = "responded" + if err := src.AppendContextManifestWithScope("alice", "r1", m, store.ContextManifestScope{Bound: true}); err != nil { + t.Fatal(err) + } + if err := src.Close(); err != nil { + t.Fatal(err) + } + snapshot := filepath.Join(t.TempDir(), "snapshot.db") + if err := cmdBackup([]string{"--source", fixture, "--out", snapshot}); err != nil { + t.Fatal(err) + } + if err := cmdMigrate([]string{"--source", snapshot, "--target", target, "--migration-id", "context-copy"}); err != nil { + t.Fatal(err) + } + pg, err := store.OpenPostgres(target, filepath.Join(t.TempDir(), "artifacts")) + if err != nil { + t.Fatal(err) + } + defer pg.Close() + receipts, err := pg.ListContextManifests("alice", "r1") + if err != nil || len(receipts) != 2 || len(receipts[1].Included) != 1 || receipts[1].Included[0].SourceID != "source-a" { + t.Fatalf("content-free model receipts not copied: count=%d err=%v", len(receipts), err) + } + var rawColumns int + if err := pg.DB().QueryRow(`SELECT COUNT(*) FROM information_schema.columns WHERE table_schema=current_schema() AND table_name='context_manifests' AND column_name IN ('resolve_goal','resolve_target_id')`).Scan(&rawColumns); err != nil || rawColumns != 0 { + t.Fatalf("migrated PG schema has raw prompt columns: count=%d err=%v", rawColumns, err) + } +} + // U4 集成（环境门控 AGENT_PG_TEST_DSN：CI test-pg job / 本机隔离实例）： // 夹具 → 受管迁移 → 校验和验证 → 幂等重跑 → 断点续传 → 非空目标拒绝 → // 未知 owner 阻塞。每用例独立 PG schema（与 store 测试同隔离约定）。 diff --git a/cmd/storage-migrate/main.go b/cmd/storage-migrate/main.go index 92de9f2..93d9463 100644 --- a/cmd/storage-migrate/main.go +++ b/cmd/storage-migrate/main.go @@ -242,6 +242,9 @@ func cmdBackup(args []string) error { return err } defer db.Close() + if err := refuseCandidateRawContextScope(db); err != nil { + return err + } if _, err := db.Exec(`VACUUM INTO ?`, *out); err != nil { return fmt.Errorf("vacuum into: %w", err) } @@ -336,6 +339,9 @@ func cmdMigrate(args []string) error { return err } defer src.Close() + if err := refuseCandidateRawContextScope(src); err != nil { + return err + } snapID, _, err := fileSHA256(*source) if err != nil { return err @@ -410,6 +416,23 @@ func cmdMigrate(args []string) error { return writeReport(rep, *out) } +// Candidate W6 v34 may contain full model prompts in private scope columns. +// Never copy or back up such a source implicitly; it must be migrated and +// reviewed in an isolated Backend store before this tool accepts it. +func refuseCandidateRawContextScope(db *sql.DB) error { + if !sqliteHasTable(db, "context_manifests") { + return nil + } + var columns int + if err := db.QueryRow(`SELECT COUNT(*) FROM pragma_table_info('context_manifests') WHERE name IN ('resolve_goal','resolve_target_id')`).Scan(&columns); err != nil { + return err + } + if columns > 0 { + return fmt.Errorf("candidate context scope text columns remain; isolate and scrub source before backup or migration") + } + return nil +} + // guardIdentity：目标非空且身份不同即拒绝（R7：不覆盖他人数据）。 // - 存在其他 migration_id 的完成记录 → 拒绝； // - 同 migration_id 但 source_snapshot_id 不同（换了快照续传）→ 拒绝； diff --git a/cmd/storage-migrate/main_test.go b/cmd/storage-migrate/main_test.go index 8731e0e..24b9170 100644 --- a/cmd/storage-migrate/main_test.go +++ b/cmd/storage-migrate/main_test.go @@ -1,7 +1,10 @@ package main import ( + "bytes" + "database/sql" "encoding/json" + "os" "path/filepath" "strings" "testing" @@ -195,3 +198,53 @@ func TestCopyOrderCoversAllFixtureTables(t *testing.T) { t.Fatalf("copyOrder 漏表（新表加入 schema 后须同步工具清单）：%v", missing) } } + +func TestBackupAndMigrateRejectCandidateRawContextScope(t *testing.T) { + path := buildFixture(t) + db, err := sql.Open("sqlite", path) + if err != nil { + t.Fatal(err) + } + if _, err := db.Exec(`ALTER TABLE context_manifests ADD COLUMN resolve_goal TEXT NOT NULL DEFAULT ''`); err != nil { + t.Fatal(err) + } + if _, err := db.Exec(`ALTER TABLE context_manifests ADD COLUMN resolve_target_id TEXT NOT NULL DEFAULT ''`); err != nil { + t.Fatal(err) + } + if _, err := db.Exec(`DELETE FROM schema_migrations WHERE version=35`); err != nil { + t.Fatal(err) + } + if _, err := db.Exec(`INSERT INTO context_manifests(id,attempt_id,owner,target_id,project_id,input_sha256,delivery,manifest_json,created_at,scope_bound,resolve_goal,resolve_target_id) VALUES('candidate-ctx','candidate-attempt','alice','r1','p1','input-hash','attempted','{}','2026-10-14T00:00:00Z',1,'OLD_RESTRICTED_BODY','doc-private')`); err != nil { + t.Fatal(err) + } + if err := db.Close(); err != nil { + t.Fatal(err) + } + out := filepath.Join(t.TempDir(), "unsafe-backup.db") + if err := cmdBackup([]string{"--source", path, "--out", out}); err == nil || !strings.Contains(err.Error(), "candidate context scope text") { + t.Fatalf("backup accepted candidate v34 raw scope: %v", err) + } + if _, err := os.Stat(out); !os.IsNotExist(err) { + t.Fatalf("rejected backup still created output: %v", err) + } + if err := cmdMigrate([]string{"--source", path, "--target", "postgres://invalid", "--migration-id", "unsafe"}); err == nil || !strings.Contains(err.Error(), "candidate context scope text") { + t.Fatalf("migration accepted candidate v34 raw source: %v", err) + } + scrubbed, err := store.OpenSQLite(path) + if err != nil { + t.Fatal(err) + } + if err := scrubbed.Close(); err != nil { + t.Fatal(err) + } + if err := cmdBackup([]string{"--source", path, "--out", out}); err != nil { + t.Fatalf("scrubbed source rejected: %v", err) + } + data, err := os.ReadFile(out) + if err != nil { + t.Fatal(err) + } + if bytes.Contains(data, []byte("OLD_RESTRICTED_BODY")) { + t.Fatal("backup retained candidate raw scope body") + } +} diff --git a/internal/app/app.go b/internal/app/app.go index 0f9a111..af7521e 100644 --- a/internal/app/app.go +++ b/internal/app/app.go @@ -620,6 +620,7 @@ func Run(opt Options) error { if contextSlot.active() { mgr.SetProjectContextResolver(contextSlot.resolve) mgr.SetProjectEvidenceReader(contextSlot.readEvidence) + mgr.SetProjectContextSourceRechecker(contextSlot.recheck) } mgr.SetKnowledgeProjectScope(func(ctx context.Context, actor string, id core.ID) (core.ID, error) { return projectSlot.resolve(ctx, caps, actor, id) diff --git a/internal/app/project_context.go b/internal/app/project_context.go index fb056d3..1f1aeeb 100644 --- a/internal/app/project_context.go +++ b/internal/app/project_context.go @@ -118,6 +118,33 @@ func (s *projectContextSlot) readEvidence(ctx context.Context, req extension.Pro return evidence, nil } +func (s *projectContextSlot) recheck(ctx context.Context, req extension.ProjectContextSourceRecheckRequest) (extension.ProjectContextSourceRecheckResult, error) { + if s == nil || req.Scope.Actor == "" || req.Scope.ProjectID == "" || req.Scope.Goal != "" { + return extension.ProjectContextSourceRecheckResult{}, errors.New("extension: trusted source recheck scope missing") + } + s.mu.RLock() + p, holder := s.provider, s.holder + s.mu.RUnlock() + rechecker, ok := p.(extension.ProjectContextSourceRechecker) + if !ok { + return extension.ProjectContextSourceRecheckResult{}, errors.New("extension: project source rechecker unavailable") + } + req.Scope.PluginID = holder + bounded, cancel := context.WithTimeout(ctx, 3*time.Second) + defer cancel() + result, err := rechecker.Recheck(bounded, req) + if err != nil { + return extension.ProjectContextSourceRecheckResult{}, err + } + if err := bounded.Err(); err != nil { + return extension.ProjectContextSourceRecheckResult{}, err + } + if result.Bundle.ProjectID != req.Scope.ProjectID || result.Bundle.Status != extension.ProjectContextReady { + return extension.ProjectContextSourceRecheckResult{}, errors.New("extension: project sources no longer authorized") + } + return result, nil +} + const workContextBudgetChars = 12000 // TaskCreateForWork fixes the project binding while the authenticated command diff --git a/internal/app/project_context_test.go b/internal/app/project_context_test.go index 4b40b36..0725ff8 100644 --- a/internal/app/project_context_test.go +++ b/internal/app/project_context_test.go @@ -22,6 +22,46 @@ type testProjectContextProvider struct { read func(extension.ProjectEvidenceRequest) (extension.ProjectEvidence, error) } +type testSourceRecheckProvider struct { + testProjectContextProvider + called *bool +} + +func (p testSourceRecheckProvider) Recheck(ctx context.Context, req extension.ProjectContextSourceRecheckRequest) (extension.ProjectContextSourceRecheckResult, error) { + if _, ok := ctx.Deadline(); !ok || req.Scope.PluginID != "rdm" || req.Scope.Actor != "alice" || req.Scope.ProjectID != "p1" || req.Scope.Goal != "" { + return extension.ProjectContextSourceRecheckResult{}, fmt.Errorf("untrusted or unbounded recheck scope") + } + *p.called = true + return extension.ProjectContextSourceRecheckResult{Bundle: extension.ProjectContextBundle{Status: extension.ProjectContextReady, ProjectID: req.Scope.ProjectID}}, nil +} + +func TestProjectSourceRecheckUsesSameRegisteredProviderAndDeadline(t *testing.T) { + called := false + slot := &projectContextSlot{} + provider := testSourceRecheckProvider{called: &called} + if err := (pluginRegistry{pluginID: "rdm", caps: hostcaps{contexts: slot}}).RegisterProjectContextProvider(provider); err != nil { + t.Fatal(err) + } + if _, err := slot.recheck(context.Background(), extension.ProjectContextSourceRecheckRequest{Scope: extension.ProjectContextRequest{Actor: "alice", ProjectID: "p1"}}); err != nil || !called { + t.Fatalf("registered source rechecker unavailable: called=%v err=%v", called, err) + } + if _, err := slot.recheck(context.Background(), extension.ProjectContextSourceRecheckRequest{Scope: extension.ProjectContextRequest{Actor: "alice", ProjectID: "p1", Goal: "OLD_RESTRICTED_BODY"}}); err == nil { + t.Fatal("raw Goal entered source recheck provider") + } + cancelled, cancel := context.WithCancel(context.Background()) + cancel() + if _, err := slot.recheck(cancelled, extension.ProjectContextSourceRecheckRequest{Scope: extension.ProjectContextRequest{Actor: "alice", ProjectID: "p1"}}); err == nil { + t.Fatal("cancelled source recheck returned authorized context") + } + legacy := &projectContextSlot{} + if err := (pluginRegistry{pluginID: "rdm", caps: hostcaps{contexts: legacy}}).RegisterProjectContextProvider(testProjectContextProvider{}); err != nil { + t.Fatal(err) + } + if _, err := legacy.recheck(context.Background(), extension.ProjectContextSourceRecheckRequest{Scope: extension.ProjectContextRequest{Actor: "alice", ProjectID: "p1"}}); err == nil { + t.Fatal("provider without optional rechecker silently accepted old sources") + } +} + type deadlineContextProvider struct{ sawDeadline *bool } func (p deadlineContextProvider) Resolve(ctx context.Context, req extension.ProjectContextRequest) (extension.ProjectContextBundle, error) { @@ -266,8 +306,8 @@ func TestCompleteForWorkUsesStoredScopeAndActualInputManifest(t *testing.T) { func TestWorkContextBudgetKeepsRequiredEvidenceFirst(t *testing.T) { bundle := extension.ProjectContextBundle{Status: extension.ProjectContextReady, ProjectID: "project-1", Items: []extension.ProjectContextItem{ - {SourceID: "optional", Text: "12345678"}, - {SourceID: "required", Text: "must keep", Required: true}, + {SourceID: "optional", Revision: "r1", Hash: "h1", Text: "12345678"}, + {SourceID: "required", Revision: "r1", Hash: "h2", Text: "must keep", Required: true}, }} prompt, manifest, err := assembleWorkCompletion("goal", bundle, 140) if err != nil { diff --git a/internal/projectcontext/context.go b/internal/projectcontext/context.go index a8b47d2..255c799 100644 --- a/internal/projectcontext/context.go +++ b/internal/projectcontext/context.go @@ -27,10 +27,16 @@ func Assemble(bundle extension.ProjectContextBundle, budget int) (string, extens missingRequired := false appendItem := func(item extension.ProjectContextItem) { entry := extension.ProjectContextManifestEntry{SourceID: item.SourceID, Revision: item.Revision, SourceHash: item.Hash} + if item.SourceID == "" || item.Revision == "" || item.Hash == "" { + entry.Reason = "unverifiable-source" + m.Dropped = append(m.Dropped, entry) + missingRequired = missingRequired || item.Required + return + } runes := []rune(item.Text) label := "\n[Source " + item.SourceID + " revision " + item.Revision + "]\n" cost := len(runes) + len([]rune(label)) - if cost > remaining || item.SourceID == "" { + if cost > remaining { entry.Reason = "over-budget-or-missing-source" m.Dropped = append(m.Dropped, entry) missingRequired = missingRequired || item.Required @@ -66,7 +72,7 @@ func Assemble(bundle extension.ProjectContextBundle, budget int) (string, extens } } for _, ref := range bundle.Evidence { - if ref.ID == "" || ref.SourceID == "" { + if ref.ID == "" || ref.SourceID == "" || ref.Revision == "" || ref.Hash == "" { continue } line := fmt.Sprintf("\n[Evidence ref %q source %q revision %q]\n", ref.ID, ref.SourceID, ref.Revision) diff --git a/internal/projectcontext/context_test.go b/internal/projectcontext/context_test.go index bf26a3a..abaeda3 100644 --- a/internal/projectcontext/context_test.go +++ b/internal/projectcontext/context_test.go @@ -8,7 +8,7 @@ import ( ) func TestAssembleOffersOnlyBudgetedEvidenceReferences(t *testing.T) { - bundle := extension.ProjectContextBundle{Status: extension.ProjectContextReady, ProjectID: "p1", Evidence: []extension.ProjectEvidenceRef{{ID: "ref-1", SourceID: "doc-1", Revision: "r2"}, {ID: strings.Repeat("x", 1000), SourceID: "doc-2"}}} + bundle := extension.ProjectContextBundle{Status: extension.ProjectContextReady, ProjectID: "p1", Evidence: []extension.ProjectEvidenceRef{{ID: "ref-1", SourceID: "doc-1", Revision: "r2", Hash: "h1"}, {ID: strings.Repeat("x", 1000), SourceID: "doc-2", Revision: "r2", Hash: "h2"}}} text, manifest, err := Assemble(bundle, 180) if err != nil { t.Fatal(err) @@ -19,7 +19,7 @@ func TestAssembleOffersOnlyBudgetedEvidenceReferences(t *testing.T) { } func TestValidateCurrentRejectsWithdrawnOfferedReference(t *testing.T) { - ref := extension.ProjectEvidenceRef{ID: "ref-1", SourceID: "doc-1", Revision: "r2"} + ref := extension.ProjectEvidenceRef{ID: "ref-1", SourceID: "doc-1", Revision: "r2", Hash: "h1"} old := extension.ProjectContextBundle{Status: extension.ProjectContextReady, ProjectID: "p1", Evidence: []extension.ProjectEvidenceRef{ref}} _, manifest, err := Assemble(old, 180) if err != nil { @@ -41,3 +41,10 @@ func TestAssembleIncludesUnresolvedMissingStatus(t *testing.T) { t.Fatalf("missing status hidden from model or receipt: text=%q manifest=%+v", text, manifest) } } + +func TestAssembleRejectsRequiredSourceWithoutStableRevisionAndHash(t *testing.T) { + bundle := extension.ProjectContextBundle{Status: extension.ProjectContextReady, ProjectID: "p1", Items: []extension.ProjectContextItem{{SourceID: "legacy", Text: "private", Required: true}}} + if _, _, err := Assemble(bundle, 900); err == nil { + t.Fatal("legacy source without revision/hash entered recoverable project model input") + } +} diff --git a/internal/runmgr/project_context.go b/internal/runmgr/project_context.go index 763eb84..11c02b8 100644 --- a/internal/runmgr/project_context.go +++ b/internal/runmgr/project_context.go @@ -5,6 +5,7 @@ import ( "crypto/sha256" "errors" "fmt" + "slices" "strings" "time" @@ -26,6 +27,10 @@ func (m *Manager) SetProjectEvidenceReader(fn func(context.Context, extension.Pr m.projectEvidenceReader = fn } +func (m *Manager) SetProjectContextSourceRechecker(fn func(context.Context, extension.ProjectContextSourceRecheckRequest) (extension.ProjectContextSourceRecheckResult, error)) { + m.projectSourceRechecker = fn +} + func (c *runCtx) ProjectContextEnabled() bool { return c.run.ProjectID != "" && c.mgr.projectContextResolver != nil } @@ -44,12 +49,114 @@ func (c *runCtx) ValidateProjectCrossGuard(ctx context.Context, current extensio if err != nil { return err } + terminal := map[string]string{} for _, m := range prior { + if m.Delivery == "responded" || m.Delivery == "unknown" { + terminal[m.AttemptID] = m.Delivery + } + } + for _, m := range prior { + if m.Delivery == "attempted" { + if terminal[m.AttemptID] != "responded" { + return errors.New("prior project model attempt has no trusted response") + } + continue + } + if m.Delivery != "responded" { + return errors.New("prior project model delivery is unknown") + } if m.ProjectID != current.ProjectID || m.AuthorizationEpoch == "" || m.PublicationEpoch == "" || current.AuthorizationEpoch == "" || current.PublicationEpoch == "" || m.AuthorizationEpoch != current.AuthorizationEpoch || m.PublicationEpoch != current.PublicationEpoch || m.Watermark != current.Watermark { return errors.New("prior project model work used a different authorization or publication revision") } + if err := c.recheckManifest(ctx, m, ""); err != nil { + return err + } + } + return nil +} + +// recheckManifest reauthorizes the exact source identities that were actually +// present in a prior model request. It never persists or reconstructs a Goal. +func (c *runCtx) recheckManifest(ctx context.Context, m extension.ProjectContextManifest, stepID string) error { + if m.Delivery != "responded" || c.mgr.projectSourceRechecker == nil { + return errors.New("project source recheck unavailable") + } + if m.BudgetChars <= 0 || len(m.Included)+len(m.OfferedReferences)+len(m.ReadEvidence) == 0 { + return errors.New("prior project model input has no stable source") + } + for _, entry := range m.Included { + if entry.SourceID == "" || entry.Revision == "" || entry.SourceHash == "" || entry.InputSHA256 == "" { + return errors.New("prior project model input has incomplete source identity") + } + } + for _, ref := range m.OfferedReferences { + if ref.ID == "" || ref.SourceID == "" || ref.Revision == "" || ref.Hash == "" { + return errors.New("prior project evidence reference is incomplete") + } + } + scope, err := c.trustedProjectContextRequest(ctx, m.BudgetChars) + if err != nil { + return err + } + scope.StepID = core.ID(stepID) + result, err := c.mgr.projectSourceRechecker(ctx, extension.ProjectContextSourceRecheckRequest{ + Scope: scope, Included: append([]extension.ProjectContextManifestEntry(nil), m.Included...), + OfferedReferences: append([]extension.ProjectEvidenceRef(nil), m.OfferedReferences...), + ReadEvidence: append([]extension.ProjectContextManifestEntry(nil), m.ReadEvidence...), + }) + if err != nil { + return err + } + current := result.Bundle + expectedRefs := map[string]extension.ProjectEvidenceRef{} + for _, ref := range m.OfferedReferences { + expectedRefs[ref.ID] = ref + } + for _, used := range m.ReadEvidence { + ref := extension.ProjectEvidenceRef{ID: used.ReferenceID, SourceID: used.SourceID, Revision: used.Revision, Hash: used.SourceHash} + if ref.ID == "" || ref.SourceID == "" || ref.Revision == "" || ref.Hash == "" { + return errors.New("read project evidence lacks stable reference") + } + if existing, ok := expectedRefs[ref.ID]; ok && existing != ref { + return errors.New("project evidence reference identity changed") + } + expectedRefs[ref.ID] = ref + } + if len(current.Items) != len(m.Included) || len(current.Evidence) != len(expectedRefs) || !slices.Equal(current.Missing, m.Missing) { + return errors.New("project source recheck returned an incomplete source set") + } + seenRefs := map[string]bool{} + for _, ref := range current.Evidence { + if ref != expectedRefs[ref.ID] || seenRefs[ref.ID] { + return errors.New("project source recheck returned an unrelated evidence reference") + } + seenRefs[ref.ID] = true + } + if err := projectcontext.ValidateCurrent(m, current); err != nil { + return err + } + for _, used := range m.ReadEvidence { + if used.ReferenceID == "" || used.InputSHA256 == "" || c.mgr.projectEvidenceReader == nil { + return errors.New("project evidence recheck unavailable") + } + matched := false + for _, ref := range current.Evidence { + if ref.ID != used.ReferenceID || ref.SourceID != used.SourceID || ref.Revision != used.Revision || ref.Hash != used.SourceHash { + continue + } + readScope := scope + readScope.BudgetChars = 8000 + now, err := c.mgr.projectEvidenceReader(ctx, extension.ProjectEvidenceRequest{Scope: readScope, Reference: ref}) + if err == nil && now.Reference == ref && fmt.Sprintf("%x", sha256.Sum256([]byte(now.Text))) == used.InputSHA256 { + matched = true + } + break + } + if !matched { + return errors.New("project evidence permission or content changed") + } } return nil } @@ -135,41 +242,50 @@ func (c *runCtx) ProjectContext(ctx context.Context, goal string, budget int) (e if c.run.ProjectID == "" || c.mgr.projectContextResolver == nil { return extension.ProjectContextBundle{}, false, nil } - if c.mgr.projectWorkAuthorization == nil { - return extension.ProjectContextBundle{}, true, errors.New("project work authorization missing") - } - run, err := c.mgr.st.GetRunByID(string(c.run.ID)) + req, err := c.trustedProjectContextRequest(ctx, budget) if err != nil { return extension.ProjectContextBundle{}, true, err } - if run.Owner == "" || run.Owner != c.run.Owner || run.ProjectID != c.run.ProjectID || run.ConversationID != c.run.ConversationID { - return extension.ProjectContextBundle{}, true, errors.New("persisted run scope mismatch") - } - conv, err := c.mgr.st.GetConversation(string(run.Owner), string(run.ConversationID)) - if err != nil { - return extension.ProjectContextBundle{}, true, err - } - if conv.ProjectID != run.ProjectID { - return extension.ProjectContextBundle{}, true, errors.New("persisted conversation scope mismatch") - } - if err := c.mgr.authorizeProjectWork(ctx, string(run.Owner), run.ProjectID); err != nil { - return extension.ProjectContextBundle{}, true, err - } - req := extension.ProjectContextRequest{ - Actor: string(run.Owner), ProjectID: run.ProjectID, ConversationID: run.ConversationID, - RunID: run.ID, Goal: goal, BudgetChars: budget, - } + req.Goal = goal bundle, err := c.mgr.projectContextResolver(ctx, req) if err != nil { return extension.ProjectContextBundle{}, true, err } - if bundle.ProjectID != run.ProjectID || bundle.Status != extension.ProjectContextReady { + if bundle.ProjectID != req.ProjectID || bundle.Status != extension.ProjectContextReady { return extension.ProjectContextBundle{}, true, errors.New("project context unavailable for trusted run") } c.setContextRequest(req) return bundle, true, nil } +func (c *runCtx) trustedProjectContextRequest(ctx context.Context, budget int) (extension.ProjectContextRequest, error) { + if c.mgr.projectWorkAuthorization == nil { + return extension.ProjectContextRequest{}, errors.New("project work authorization missing") + } + run, err := c.mgr.st.GetRunByID(string(c.run.ID)) + if err != nil { + return extension.ProjectContextRequest{}, err + } + if run.Owner == "" || run.Owner != c.run.Owner || run.ProjectID != c.run.ProjectID || run.ConversationID != c.run.ConversationID { + return extension.ProjectContextRequest{}, errors.New("persisted run scope mismatch") + } + conv, err := c.mgr.st.GetConversation(string(run.Owner), string(run.ConversationID)) + if err != nil { + return extension.ProjectContextRequest{}, err + } + if conv.ProjectID != run.ProjectID { + return extension.ProjectContextRequest{}, errors.New("persisted conversation scope mismatch") + } + if err := c.mgr.authorizeProjectWork(ctx, string(run.Owner), run.ProjectID); err != nil { + return extension.ProjectContextRequest{}, err + } + req := extension.ProjectContextRequest{ + Actor: string(run.Owner), ProjectID: run.ProjectID, ConversationID: run.ConversationID, + RunID: run.ID, BudgetChars: budget, + } + return req, nil +} + // SaveContextManifest persists a receipt for the exact request prepared by the // runtime. It does not store model-visible text or candidate-only references. func (c *runCtx) SaveContextManifest(ctx context.Context, m extension.ProjectContextManifest) error { @@ -258,7 +374,7 @@ func (c *runCtx) SaveContextManifest(ctx context.Context, m extension.ProjectCon } if scopeBound { return c.mgr.st.AppendContextManifestWithScope(string(run.Owner), string(run.ID), m, - store.ContextManifestScope{Goal: resolveGoal, TargetID: resolveTarget, Bound: true}) + store.ContextManifestScope{Bound: true}) } return c.mgr.st.AppendContextManifest(string(run.Owner), string(run.ID), m) } @@ -309,8 +425,8 @@ func (c *runCtx) VerifyProjectStepOutput(ctx context.Context, stepID, stepAttemp } matchedBound := false for _, source := range receipts { - receipt, selector := source.Manifest, source.Scope - if !selector.Bound || selector.TargetID != "" || receipt.ProjectID != c.run.ProjectID || + receipt := source.Manifest + if !source.Scope.Bound || receipt.ProjectID != c.run.ProjectID || receipt.WorkflowStepAttemptID != stepAttemptID || receipt.AuthorizationEpoch != bound.AuthorizationEpoch || receipt.PublicationEpoch != bound.PublicationEpoch || receipt.Watermark != bound.Watermark || receipt.Version != bound.Version { return errors.New("project workflow output lost its trusted model source") @@ -318,35 +434,9 @@ func (c *runCtx) VerifyProjectStepOutput(ctx context.Context, stepID, stepAttemp if receipt.AttemptID == bound.AttemptID { matchedBound = true } - current, active, err := c.ProjectContext(ctx, selector.Goal, receipt.BudgetChars) - if err != nil || !active || current.ProjectID != receipt.ProjectID || - current.AuthorizationEpoch != receipt.AuthorizationEpoch || current.PublicationEpoch != receipt.PublicationEpoch || current.Watermark != receipt.Watermark { - return errors.New("project workflow output authorization or publication changed") - } - if err := projectcontext.ValidateCurrent(receipt, current); err != nil { + if err := c.recheckManifest(ctx, receipt, stepID); err != nil { return fmt.Errorf("project workflow output source changed: %w", err) } - for _, used := range receipt.ReadEvidence { - if c.mgr.projectEvidenceReader == nil { - return errors.New("project workflow evidence reader unavailable") - } - matched := false - for _, ref := range current.Evidence { - if ref.ID != used.ReferenceID || ref.SourceID != used.SourceID || ref.Revision != used.Revision || ref.Hash != used.SourceHash { - continue - } - scope := extension.ProjectContextRequest{Actor: string(c.run.Owner), ProjectID: c.run.ProjectID, - ConversationID: c.run.ConversationID, RunID: c.run.ID, Goal: selector.Goal, TargetID: selector.TargetID, BudgetChars: 8000} - now, err := c.mgr.projectEvidenceReader(ctx, extension.ProjectEvidenceRequest{Scope: scope, Reference: ref}) - if err == nil && now.Reference == ref && fmt.Sprintf("%x", sha256.Sum256([]byte(now.Text))) == used.InputSHA256 { - matched = true - } - break - } - if !matched { - return errors.New("project workflow evidence permission or content changed") - } - } } if !matchedBound { return errors.New("project workflow output binding lost its responded model attempt") diff --git a/internal/runmgr/project_context_test.go b/internal/runmgr/project_context_test.go index 290802f..3e7b938 100644 --- a/internal/runmgr/project_context_test.go +++ b/internal/runmgr/project_context_test.go @@ -2,6 +2,7 @@ package runmgr import ( "context" + "crypto/sha256" "fmt" "os" "strings" @@ -19,6 +20,69 @@ import ( core "agent-system-core" ) +func TestProjectSourceRecheckVerifiesIncludedRefsAndEvidenceBody(t *testing.T) { + st := openRecoveryStore(t) + mgr := newRecoveryManager(t, st) + conv := recoveryConversation(t, st) + run := recoveryRun(t, st, conv, core.RunPending) + mgr.SetProjectWorkAuthorization(func(context.Context, string, core.ID) (bool, error) { return true, nil }) + item := extension.ProjectContextItem{SourceID: "source-a", Revision: "r1", Hash: "ha", Text: "AUTHORIZED_A", Required: true} + ref := extension.ProjectEvidenceRef{ID: "ref-a", SourceID: "doc-a", Revision: "r1", Hash: "hd"} + bundle := extension.ProjectContextBundle{Status: extension.ProjectContextReady, ProjectID: run.ProjectID, Version: "v1", Watermark: "w1", AuthorizationEpoch: "duty-1", PublicationEpoch: "pub-1", Items: []extension.ProjectContextItem{item}, Evidence: []extension.ProjectEvidenceRef{ref}} + _, receipt, err := projectcontext.Assemble(bundle, 900) + if err != nil { + t.Fatal(err) + } + receipt.Delivery = "responded" + receipt.ReadEvidence = []extension.ProjectContextManifestEntry{{ReferenceID: ref.ID, SourceID: ref.SourceID, Revision: ref.Revision, SourceHash: ref.Hash, InputSHA256: fmt.Sprintf("%x", sha256.Sum256([]byte("DETAIL_A")))}} + rc := &runCtx{mgr: mgr, run: run, ctx: context.Background()} + current := bundle + readBody := "DETAIL_A" + offeredCount := 1 + mgr.SetProjectContextSourceRechecker(func(_ context.Context, req extension.ProjectContextSourceRecheckRequest) (extension.ProjectContextSourceRecheckResult, error) { + if req.Scope.Actor != string(run.Owner) || req.Scope.ProjectID != run.ProjectID || req.Scope.RunID != run.ID || req.Scope.ConversationID != run.ConversationID || req.Scope.StepID != "draft" || req.Scope.Goal != "" || len(req.Included) != 1 || len(req.OfferedReferences) != offeredCount || len(req.ReadEvidence) != 1 { + return extension.ProjectContextSourceRecheckResult{}, fmt.Errorf("source recheck lost trusted run scope or actual input refs") + } + return extension.ProjectContextSourceRecheckResult{Bundle: current}, nil + }) + mgr.SetProjectEvidenceReader(func(_ context.Context, req extension.ProjectEvidenceRequest) (extension.ProjectEvidence, error) { + if req.Scope.Actor != string(run.Owner) || req.Scope.RunID != run.ID || req.Scope.StepID != "draft" || req.Scope.Goal != "" || req.Reference != ref { + return extension.ProjectEvidence{}, fmt.Errorf("evidence read lost current trusted scope") + } + return extension.ProjectEvidence{Reference: req.Reference, Text: readBody}, nil + }) + if err := rc.recheckManifest(context.Background(), receipt, "draft"); err != nil { + t.Fatalf("same authorized sources rejected: %v", err) + } + // A detailed body may be in the final request even when its reference was + // not offered in that request's short context. Recheck that exact read too. + receipt.OfferedReferences = nil + offeredCount = 0 + if err := rc.recheckManifest(context.Background(), receipt, "draft"); err != nil { + t.Fatalf("read evidence not offered as a short ref was rejected: %v", err) + } + receipt.OfferedReferences = []extension.ProjectEvidenceRef{ref} + offeredCount = 1 + current.Items = []extension.ProjectContextItem{{SourceID: item.SourceID, Revision: item.Revision, Hash: item.Hash, Text: "CHANGED", Required: true}} + if err := rc.recheckManifest(context.Background(), receipt, "draft"); err == nil { + t.Fatal("provider echoed old source hash but changed model-visible text") + } + current = bundle + current.Evidence = nil + if err := rc.recheckManifest(context.Background(), receipt, "draft"); err == nil { + t.Fatal("withdrawn offered reference accepted") + } + current = bundle + readBody = "REVOKED_DETAIL" + if err := rc.recheckManifest(context.Background(), receipt, "draft"); err == nil { + t.Fatal("changed ReadEvidence body accepted") + } + mgr.SetProjectContextSourceRechecker(nil) + if err := rc.recheckManifest(context.Background(), receipt, "draft"); err == nil { + t.Fatal("missing rechecker accepted old machine context") + } +} + func TestProjectContextUsesPersistedRunAndRefreshesAuthorization(t *testing.T) { st := openRecoveryStore(t) m := newRecoveryManager(t, st) @@ -90,6 +154,10 @@ func TestProjectJudgeChecksPersistedSourceEpochAcrossGuards(t *testing.T) { m.SetProjectContextResolver(func(_ context.Context, req extension.ProjectContextRequest) (extension.ProjectContextBundle, error) { return extension.ProjectContextBundle{Status: extension.ProjectContextReady, ProjectID: req.ProjectID, AuthorizationEpoch: epoch, PublicationEpoch: publication, Watermark: "commit-1", Items: items}, nil }) + m.SetProjectContextSourceRechecker(func(_ context.Context, req extension.ProjectContextSourceRecheckRequest) (extension.ProjectContextSourceRecheckResult, error) { + return extension.ProjectContextSourceRecheckResult{Bundle: extension.ProjectContextBundle{Status: extension.ProjectContextReady, ProjectID: req.Scope.ProjectID, + AuthorizationEpoch: epoch, PublicationEpoch: publication, Watermark: "commit-1", Items: items}}, nil + }) rc := &runCtx{mgr: m, run: run, ctx: context.Background()} started := time.Now().Add(-time.Second) bundle, _, err := rc.ProjectContext(context.Background(), "write output", 900) @@ -182,6 +250,14 @@ func TestProjectJudgeRetainsGoalSensitiveSourceScope(t *testing.T) { } return extension.ProjectContextBundle{Status: extension.ProjectContextReady, ProjectID: req.ProjectID, AuthorizationEpoch: "duty-1", PublicationEpoch: "pub-1", Watermark: "w1", Items: []extension.ProjectContextItem{item}}, nil }) + m.SetProjectContextSourceRechecker(func(_ context.Context, req extension.ProjectContextSourceRecheckRequest) (extension.ProjectContextSourceRecheckResult, error) { + item := extension.ProjectContextItem{SourceID: "source-b", Revision: "r1", Hash: "hb", Text: "PUBLIC_B", Required: true} + if len(req.Included) == 1 && req.Included[0].SourceID == "source-a" && available { + item = extension.ProjectContextItem{SourceID: "source-a", Revision: "r1", Hash: "ha", Text: "AUTHORIZED_A", Required: true} + } + return extension.ProjectContextSourceRecheckResult{Bundle: extension.ProjectContextBundle{Status: extension.ProjectContextReady, ProjectID: req.Scope.ProjectID, + AuthorizationEpoch: "duty-1", PublicationEpoch: "pub-1", Watermark: "w1", Items: []extension.ProjectContextItem{item}}}, nil + }) rc := &runCtx{mgr: m, run: run, ctx: context.Background()} const goal = "draft report from approved source" bundle, _, err := rc.ProjectContext(context.Background(), goal, 900) @@ -238,10 +314,12 @@ func TestProjectJudgeRetainsGoalSensitiveSourceScope(t *testing.T) { type goalSensitiveStepBackend struct { stream agentllm.StreamFunc sent string + calls int } func (*goalSensitiveStepBackend) Name() string { return "goal-sensitive-test" } func (b *goalSensitiveStepBackend) Execute(ctx context.Context, req squad.ExecRequest) (*squad.ExecResult, error) { + b.calls++ for ev := range b.stream(ctx, "test-model", []agentllm.Message{{Role: agentllm.RoleUser, Content: req.Prompt}}, nil, agentllm.StreamOptions{}) { if ev.Kind == agentllm.KindError { return &squad.ExecResult{Success: false, ErrorReason: ev.Err.Error()}, nil @@ -254,6 +332,52 @@ func (b *goalSensitiveStepBackend) Execute(ctx context.Context, req squad.ExecRe return &squad.ExecResult{Success: true, Patches: map[string][]byte{"output.md": []byte("AUTHORIZED_A report\n")}}, nil } +func TestCompiledWorkflowSecondPromptRejectsRevokedPriorOutput(t *testing.T) { + st := openRecoveryStore(t) + mgr := newRecoveryManager(t, st) + conv := recoveryConversation(t, st) + run := recoveryRun(t, st, conv, core.RunPending) + mgr.SetProjectWorkAuthorization(func(context.Context, string, core.ID) (bool, error) { return true, nil }) + available := true + item := extension.ProjectContextItem{SourceID: "source-a", Revision: "r1", Hash: "ha", Text: "AUTHORIZED_A", Required: true} + mgr.SetProjectContextResolver(func(_ context.Context, req extension.ProjectContextRequest) (extension.ProjectContextBundle, error) { + items := []extension.ProjectContextItem{item} + if !available { + items = []extension.ProjectContextItem{{SourceID: "source-b", Revision: "r1", Hash: "hb", Text: "PUBLIC_B", Required: true}} + } + return extension.ProjectContextBundle{Status: extension.ProjectContextReady, ProjectID: req.ProjectID, AuthorizationEpoch: "duty-1", PublicationEpoch: "pub-1", Watermark: "w1", Items: items}, nil + }) + rechecks := 0 + mgr.SetProjectContextSourceRechecker(func(_ context.Context, req extension.ProjectContextSourceRecheckRequest) (extension.ProjectContextSourceRecheckResult, error) { + rechecks++ + result := extension.ProjectContextSourceRecheckResult{Bundle: extension.ProjectContextBundle{Status: extension.ProjectContextReady, ProjectID: req.Scope.ProjectID, AuthorizationEpoch: "duty-1", PublicationEpoch: "pub-1", Watermark: "w1", Items: []extension.ProjectContextItem{item}}} + if rechecks == 1 { + available = false + } else { + result.Bundle.Items = nil + } + return result, nil + }) + rc := &runCtx{mgr: mgr, run: run, ctx: context.Background()} + base := func(_ context.Context, _ string, _ []agentllm.Message, _ []agentllm.ToolDecl, _ agentllm.StreamOptions) <-chan agentllm.Event { + ch := make(chan agentllm.Event, 1) + ch <- agentllm.Event{Kind: agentllm.KindMessageEnd, Message: agentllm.Message{Role: agentllm.RoleAssistant, Content: "done"}} + close(ch) + return ch + } + backend := &goalSensitiveStepBackend{stream: runtime.GuardProjectStream(rc, "", base)} + backends := squad.NewBackendResolver() + backends.RegisterInstance(backend.Name(), backend) + def := core.WorkflowDef{ID: "two-prompts", Title: "Two prompts", Steps: []core.WorkflowStep{ + {ID: "draft", Title: "Draft", Kind: "prompt", Agent: "writer", Prompt: "draft report"}, + {ID: "rewrite", Title: "Rewrite", Kind: "prompt", Agent: "writer", Prompt: "revise {{steps.draft.output}}"}, + }} + _, err := wfcompile.RunCompiled(rc, wfcompile.Deps{DataDir: t.TempDir(), Backends: backends, DefaultBackend: backend.Name()}, workflow.Launch{Def: def}, workflow.Vars{Input: "draft"}, wfcompile.RunOptions{}) + if err == nil || backend.calls != 1 || rechecks < 2 { + t.Fatalf("second prompt consumed revoked first output: err=%v calls=%d rechecks=%d", err, backend.calls, rechecks) + } +} + func TestCompiledWorkflowJudgeAcceptsGoalSensitiveProviderAndRejectsWithdrawal(t *testing.T) { st := openRecoveryStore(t) mgr := newRecoveryManager(t, st) @@ -270,6 +394,14 @@ func TestCompiledWorkflowJudgeAcceptsGoalSensitiveProviderAndRejectsWithdrawal(t } return extension.ProjectContextBundle{Status: extension.ProjectContextReady, ProjectID: req.ProjectID, AuthorizationEpoch: "duty-1", PublicationEpoch: "pub-1", Watermark: "w1", Items: []extension.ProjectContextItem{item}}, nil }) + mgr.SetProjectContextSourceRechecker(func(_ context.Context, req extension.ProjectContextSourceRecheckRequest) (extension.ProjectContextSourceRecheckResult, error) { + item := extension.ProjectContextItem{SourceID: "source-b", Revision: "r1", Hash: "hb", Text: "PUBLIC_B", Required: true} + if len(req.Included) == 1 && req.Included[0].SourceID == "source-a" && available { + item = extension.ProjectContextItem{SourceID: "source-a", Revision: "r1", Hash: "ha", Text: "AUTHORIZED_A", Required: true} + } + return extension.ProjectContextSourceRecheckResult{Bundle: extension.ProjectContextBundle{Status: extension.ProjectContextReady, ProjectID: req.Scope.ProjectID, + AuthorizationEpoch: "duty-1", PublicationEpoch: "pub-1", Watermark: "w1", Items: []extension.ProjectContextItem{item}}}, nil + }) rc := &runCtx{mgr: mgr, run: run, ctx: context.Background()} stepBase := func(_ context.Context, _ string, messages []agentllm.Message, _ []agentllm.ToolDecl, _ agentllm.StreamOptions) <-chan agentllm.Event { ch := make(chan agentllm.Event, 1) @@ -298,6 +430,26 @@ func TestCompiledWorkflowJudgeAcceptsGoalSensitiveProviderAndRejectsWithdrawal(t if err != nil || judgeCalls != 1 || backend.sent == "" { t.Fatalf("authorized goal-sensitive workflow failed: err=%v judgeCalls=%d sent=%q resolved=%q", err, judgeCalls, backend.sent, resolved) } + rows, err := st.DB().Query(`SELECT manifest_json FROM context_manifests WHERE owner=$1 AND target_id=$2`, string(run.Owner), string(run.ID)) + if err != nil { + t.Fatal(err) + } + for rows.Next() { + var raw string + if err := rows.Scan(&raw); err != nil { + rows.Close() + t.Fatal(err) + } + if strings.Contains(raw, "AUTHORIZED_A report") || strings.Contains(raw, "draft report using") { + rows.Close() + t.Fatal("workflow model prompt or output body entered trusted receipt JSON") + } + } + if err := rows.Err(); err != nil { + rows.Close() + t.Fatal(err) + } + rows.Close() bound, err := st.WorkflowStepSource(string(run.Owner), string(run.ID), "draft") if err != nil { t.Fatal(err) @@ -337,7 +489,7 @@ func TestContextManifestRejectsDocumentDutyRevocationBeforeSend(t *testing.T) { epoch := "duty-1" m.SetProjectContextResolver(func(_ context.Context, req extension.ProjectContextRequest) (extension.ProjectContextBundle, error) { return extension.ProjectContextBundle{Status: extension.ProjectContextReady, ProjectID: req.ProjectID, Version: "v1", AuthorizationEpoch: epoch, - Items: []extension.ProjectContextItem{{SourceID: "restricted-doc", Text: "private text", Required: true}}}, nil + Items: []extension.ProjectContextItem{{SourceID: "restricted-doc", Revision: "r1", Hash: "h1", Text: "private text", Required: true}}}, nil }) rc := &runCtx{mgr: m, run: run, ctx: context.Background()} bundle, active, err := rc.ProjectContext(context.Background(), "work", 900) @@ -410,7 +562,7 @@ func TestConcurrentProjectEvidenceReadsKeepTrustedScope(t *testing.T) { conv := recoveryConversation(t, st) run := recoveryRun(t, st, conv, core.RunPending) m.SetProjectWorkAuthorization(func(context.Context, string, core.ID) (bool, error) { return true, nil }) - ref := extension.ProjectEvidenceRef{ID: "r1", SourceID: "doc", Revision: "v1"} + ref := extension.ProjectEvidenceRef{ID: "r1", SourceID: "doc", Revision: "v1", Hash: "h1"} m.SetProjectContextResolver(func(_ context.Context, req extension.ProjectContextRequest) (extension.ProjectContextBundle, error) { return extension.ProjectContextBundle{Status: extension.ProjectContextReady, ProjectID: req.ProjectID, Evidence: []extension.ProjectEvidenceRef{ref}}, nil }) diff --git a/internal/runmgr/runmgr.go b/internal/runmgr/runmgr.go index 1ed8485..fee313a 100644 --- a/internal/runmgr/runmgr.go +++ b/internal/runmgr/runmgr.go @@ -64,6 +64,7 @@ type Manager struct { projectWorkAuthorization func(context.Context, string, core.ID) (bool, error) projectContextResolver func(context.Context, extension.ProjectContextRequest) (extension.ProjectContextBundle, error) projectEvidenceReader func(context.Context, extension.ProjectEvidenceRequest) (extension.ProjectEvidence, error) + projectSourceRechecker func(context.Context, extension.ProjectContextSourceRecheckRequest) (extension.ProjectContextSourceRecheckResult, error) // commands EXT-14：命令即工具的投影与分发源（nil = 未接线，命令不进工具清单）。 commands CommandSource indexer core.DocumentIndexer // 可选索引入口（nil = store 整文档单块） diff --git a/internal/runtime/project_context_test.go b/internal/runtime/project_context_test.go index 06299fe..0edb559 100644 --- a/internal/runtime/project_context_test.go +++ b/internal/runtime/project_context_test.go @@ -65,7 +65,7 @@ func TestProjectContextRefreshesPerModelRequestWithoutPersistingOldSummary(t *te return base(ctx, model, msgs, tools, opts) }} c := &projectRunCtx{fakeRunCtx: &fakeRunCtx{ctx: context.Background(), sandbox: t.TempDir(), projectID: "project-1", prof: core.AgentProfile{Model: core.ModelRoute{Chat: "test-model"}}}} - c.bundle = extension.ProjectContextBundle{Status: extension.ProjectContextReady, ProjectID: "project-1", Version: "v1", Items: []extension.ProjectContextItem{{SourceID: "s1", Text: "summary-v1", Required: true}}} + c.bundle = extension.ProjectContextBundle{Status: extension.ProjectContextReady, ProjectID: "project-1", Version: "v1", Items: []extension.ProjectContextItem{{SourceID: "s1", Revision: "r1", Hash: "h1", Text: "summary-v1", Required: true}}} if err := runner.Execute(c); err != nil { t.Fatal(err) } @@ -110,7 +110,7 @@ func TestProjectRevocationScrubsOldMachineContextBeforeSecondTurn(t *testing.T) base := scriptStream(turns, nil) var requests [][]agentllm.Message c := &projectRunCtx{fakeRunCtx: &fakeRunCtx{ctx: context.Background(), projectID: "p1", prof: core.AgentProfile{Model: core.ModelRoute{Chat: "test-model"}}, memEntries: []memEntry{{typ: "note", content: "STALE_MEMORY"}}, execOutput: old}, - bundle: extension.ProjectContextBundle{Status: extension.ProjectContextReady, ProjectID: "p1", Version: "v1", AuthorizationEpoch: "duty-1", PublicationEpoch: "pub-1", Items: []extension.ProjectContextItem{{SourceID: "doc", Text: old, Required: true}}}, + bundle: extension.ProjectContextBundle{Status: extension.ProjectContextReady, ProjectID: "p1", Version: "v1", AuthorizationEpoch: "duty-1", PublicationEpoch: "pub-1", Items: []extension.ProjectContextItem{{SourceID: "doc", Revision: "r1", Hash: "h1", Text: old, Required: true}}}, budgetSettings: core.EffectiveSettings{"models": map[string]any{"chat": map[string]any{"baseUrl": "http://test"}}, "context": map[string]any{"userInstructions": "STALE_INSTRUCTIONS"}, "runtime": map[string]any{"verify": false, "composeFinal": false}}, sessionNote: "STALE_SESSION_NOTE", injections: []ContextInjection{{Content: "STALE_INJECTION", Constant: true}}, surfaces: []core.SurfaceSnapshot{{SemanticText: "STALE_SURFACE"}}, @@ -118,7 +118,7 @@ func TestProjectRevocationScrubsOldMachineContextBeforeSecondTurn(t *testing.T) runner := &LLMRunner{Stream: func(ctx context.Context, model string, msgs []agentllm.Message, tools []agentllm.ToolDecl, opts agentllm.StreamOptions) <-chan agentllm.Event { requests = append(requests, append([]agentllm.Message(nil), msgs...)) if len(requests) == 1 { - c.bundle = extension.ProjectContextBundle{Status: extension.ProjectContextReady, ProjectID: "p1", Version: "v2", AuthorizationEpoch: "duty-2", PublicationEpoch: "pub-2", Items: []extension.ProjectContextItem{{SourceID: "public", Text: "CURRENT_PUBLIC_FACT", Required: true}}} + c.bundle = extension.ProjectContextBundle{Status: extension.ProjectContextReady, ProjectID: "p1", Version: "v2", AuthorizationEpoch: "duty-2", PublicationEpoch: "pub-2", Items: []extension.ProjectContextItem{{SourceID: "public", Revision: "r1", Hash: "h2", Text: "CURRENT_PUBLIC_FACT", Required: true}}} } return base(ctx, model, msgs, tools, opts) }} @@ -160,7 +160,7 @@ func TestProjectSameScopeKeepsCurrentRunToolContext(t *testing.T) { return base(ctx, model, msgs, tools, opts) }} c := &projectRunCtx{fakeRunCtx: &fakeRunCtx{ctx: context.Background(), projectID: "p1", prof: core.AgentProfile{Model: core.ModelRoute{Chat: "test-model"}}, execOutput: "AUTHORIZED_TOOL_RESULT"}, - bundle: extension.ProjectContextBundle{Status: extension.ProjectContextReady, ProjectID: "p1", AuthorizationEpoch: "duty-1", PublicationEpoch: "pub-1", Items: []extension.ProjectContextItem{{SourceID: "fact", Text: "CURRENT_FACT", Required: true}}}} + bundle: extension.ProjectContextBundle{Status: extension.ProjectContextReady, ProjectID: "p1", AuthorizationEpoch: "duty-1", PublicationEpoch: "pub-1", Items: []extension.ProjectContextItem{{SourceID: "fact", Revision: "r1", Hash: "h1", Text: "CURRENT_FACT", Required: true}}}} if err := runner.Execute(c); err != nil { t.Fatal(err) } @@ -193,7 +193,7 @@ func TestSubagentModelRequestUsesProjectContextAndManifest(t *testing.T) { return base(ctx, model, msgs, tools, opts) }} c := &projectRunCtx{fakeRunCtx: &fakeRunCtx{ctx: context.Background(), projectID: "project-1", prof: core.AgentProfile{Model: core.ModelRoute{Chat: "test-model", Lightweight: "test-lite"}}}, - bundle: extension.ProjectContextBundle{Status: extension.ProjectContextReady, ProjectID: "project-1", Items: []extension.ProjectContextItem{{SourceID: "s1", Text: "current project fact", Required: true}}}} + bundle: extension.ProjectContextBundle{Status: extension.ProjectContextReady, ProjectID: "project-1", Items: []extension.ProjectContextItem{{SourceID: "s1", Revision: "r1", Hash: "h1", Text: "current project fact", Required: true}}}} if err := sub.Execute(c); err != nil { t.Fatal(err) } @@ -214,7 +214,7 @@ func TestSubagentSameScopeKeepsNewToolResultAcrossTurns(t *testing.T) { return base(ctx, model, msgs, tools, opts) }} c := &projectRunCtx{fakeRunCtx: &fakeRunCtx{ctx: context.Background(), projectID: "p1", prof: core.AgentProfile{Model: core.ModelRoute{Chat: "test-model", Lightweight: "test-lite"}}, execOutput: "NEW_AUTHORIZED_TOOL"}, - bundle: extension.ProjectContextBundle{Status: extension.ProjectContextReady, ProjectID: "p1", AuthorizationEpoch: "duty-1", PublicationEpoch: "pub-1", Items: []extension.ProjectContextItem{{SourceID: "fact", Text: "CURRENT_FACT", Required: true}}}, + bundle: extension.ProjectContextBundle{Status: extension.ProjectContextReady, ProjectID: "p1", AuthorizationEpoch: "duty-1", PublicationEpoch: "pub-1", Items: []extension.ProjectContextItem{{SourceID: "fact", Revision: "r1", Hash: "h1", Text: "CURRENT_FACT", Required: true}}}, toolList: []core.ToolDesc{{Name: "knowledge_search", Description: "Search", Parameters: json.RawMessage(`{"type":"object"}`)}}, } if err := sub.Execute(c); err != nil { @@ -248,7 +248,7 @@ func TestProjectStreamBlocksRequestExceedingFinalModelBudget(t *testing.T) { called = true return scriptStream(textTurns("bad"), nil)(ctx, model, msgs, tools, opts) } - c := &projectRunCtx{fakeRunCtx: &fakeRunCtx{projectID: "p1"}, bundle: extension.ProjectContextBundle{Status: extension.ProjectContextReady, ProjectID: "p1", Items: []extension.ProjectContextItem{{SourceID: "large", Text: strings.Repeat("x", 11000), Required: true}}}, budgetSettings: core.EffectiveSettings{"models": map[string]any{"chat": map[string]any{"contextWindow": float64(4096), "outputReserve": float64(512), "contextBuffer": float64(512)}}}} + c := &projectRunCtx{fakeRunCtx: &fakeRunCtx{projectID: "p1"}, bundle: extension.ProjectContextBundle{Status: extension.ProjectContextReady, ProjectID: "p1", Items: []extension.ProjectContextItem{{SourceID: "large", Revision: "r1", Hash: "h1", Text: strings.Repeat("x", 11000), Required: true}}}, budgetSettings: core.EffectiveSettings{"models": map[string]any{"chat": map[string]any{"contextWindow": float64(4096), "outputReserve": float64(512), "contextBuffer": float64(512)}}}} for ev := range GuardProjectStream(c, "goal", base)(context.Background(), "test", []agentllm.Message{{Role: agentllm.RoleUser, Content: "goal"}}, nil, agentllm.StreamOptions{}) { if ev.Kind != agentllm.KindError { t.Fatalf("oversized request did not fail: %+v", ev) @@ -335,7 +335,7 @@ func (c *projectSquadCtx) Run() core.Run { return core.Run{ID: "run-squad", Owner: "alice", ProjectID: "project-1"} } func (c *projectSquadCtx) ProjectContext(context.Context, string, int) (extension.ProjectContextBundle, bool, error) { - return extension.ProjectContextBundle{Status: extension.ProjectContextReady, ProjectID: "project-1", AuthorizationEpoch: "duty-1", PublicationEpoch: "pub-1", Items: []extension.ProjectContextItem{{SourceID: "squad-source", Text: "squad project fact", Required: true}}}, true, nil + return extension.ProjectContextBundle{Status: extension.ProjectContextReady, ProjectID: "project-1", AuthorizationEpoch: "duty-1", PublicationEpoch: "pub-1", Items: []extension.ProjectContextItem{{SourceID: "squad-source", Revision: "r1", Hash: "h1", Text: "squad project fact", Required: true}}}, true, nil } func (c *projectSquadCtx) SaveContextManifest(_ context.Context, m extension.ProjectContextManifest) error { c.manifests = append(c.manifests, m) diff --git a/internal/runtime/workflow_compiled_test.go b/internal/runtime/workflow_compiled_test.go index 51b1301..1f7148f 100644 --- a/internal/runtime/workflow_compiled_test.go +++ b/internal/runtime/workflow_compiled_test.go @@ -308,7 +308,7 @@ func (c *projectJudgeCtx) ProjectContext(context.Context, string, int) (extensio if epoch == "" { epoch = "duty-1" } - return extension.ProjectContextBundle{Status: extension.ProjectContextReady, ProjectID: "project-1", AuthorizationEpoch: epoch, PublicationEpoch: "pub-1", Items: []extension.ProjectContextItem{{SourceID: "judge-source", Text: "current project rule", Required: true}}}, true, nil + return extension.ProjectContextBundle{Status: extension.ProjectContextReady, ProjectID: "project-1", AuthorizationEpoch: epoch, PublicationEpoch: "pub-1", Items: []extension.ProjectContextItem{{SourceID: "judge-source", Revision: "r1", Hash: "h1", Text: "current project rule", Required: true}}}, true, nil } func (c *projectJudgeCtx) SaveContextManifest(_ context.Context, m extension.ProjectContextManifest) error { c.manifests = append(c.manifests, m) diff --git a/internal/store/context_manifest.go b/internal/store/context_manifest.go index 779f7b2..48e52a9 100644 --- a/internal/store/context_manifest.go +++ b/internal/store/context_manifest.go @@ -11,12 +11,10 @@ import ( const contextManifestAction = "model.context_manifest" -// ContextManifestScope records the exact trusted Resolve selector separately -// from the public final-input manifest. Bound distinguishes an intentionally -// empty goal from a legacy receipt with no recoverable selector. +// ContextManifestScope records only that the request came from a trusted model +// guard. Raw goals and model output are never persisted in this receipt. type ContextManifestScope struct { - Goal, TargetID string - Bound bool + Bound bool } // AppendContextManifest writes to the trusted receipt table, never to the @@ -50,17 +48,16 @@ func (s *Store) appendContextManifest(owner, targetID string, m extension.Projec } defer tx.Rollback() if m.Delivery != "attempted" { - var attemptedGoal, attemptedTarget string var attemptedBound int - err := tx.QueryRow(s.q(`SELECT resolve_goal,resolve_target_id,scope_bound FROM context_manifests WHERE attempt_id=? AND delivery='attempted' AND owner=? AND target_id=? AND project_id=? AND input_sha256=?`), - m.AttemptID, owner, targetID, m.ProjectID, m.InputSHA256).Scan(&attemptedGoal, &attemptedTarget, &attemptedBound) + err := tx.QueryRow(s.q(`SELECT scope_bound FROM context_manifests WHERE attempt_id=? AND delivery='attempted' AND owner=? AND target_id=? AND project_id=? AND input_sha256=?`), + m.AttemptID, owner, targetID, m.ProjectID, m.InputSHA256).Scan(&attemptedBound) if errors.Is(err, sql.ErrNoRows) { return errors.New("context manifest terminal receipt lacks matching attempt") } if err != nil { return err } - if attemptedGoal != scope.Goal || attemptedTarget != scope.TargetID || (attemptedBound != 0) != scope.Bound { + if (attemptedBound != 0) != scope.Bound { return errors.New("context manifest terminal resolve scope changed") } var terminal int @@ -76,8 +73,8 @@ func (s *Store) appendContextManifest(owner, targetID string, m extension.Projec if scope.Bound { bound = 1 } - _, err = tx.Exec(s.q(`INSERT INTO context_manifests(id,attempt_id,owner,target_id,project_id,input_sha256,delivery,manifest_json,created_at,resolve_goal,resolve_target_id,scope_bound) VALUES(?,?,?,?,?,?,?,?,?,?,?,?)`), - NewID("ctxm"), m.AttemptID, owner, targetID, m.ProjectID, m.InputSHA256, m.Delivery, string(raw), nowISO(), scope.Goal, scope.TargetID, bound) + _, err = tx.Exec(s.q(`INSERT INTO context_manifests(id,attempt_id,owner,target_id,project_id,input_sha256,delivery,manifest_json,created_at,scope_bound) VALUES(?,?,?,?,?,?,?,?,?,?)`), + NewID("ctxm"), m.AttemptID, owner, targetID, m.ProjectID, m.InputSHA256, m.Delivery, string(raw), nowISO(), bound) if err != nil { return fmt.Errorf("insert context manifest: %w", err) } diff --git a/internal/store/context_manifest_test.go b/internal/store/context_manifest_test.go index c4411b8..2259897 100644 --- a/internal/store/context_manifest_test.go +++ b/internal/store/context_manifest_test.go @@ -1,7 +1,10 @@ package store import ( + "bytes" + "os" "path/filepath" + "strings" "testing" "agent-system-backend/pkg/extension" @@ -37,6 +40,132 @@ func TestContextManifestTerminalRequiresMatchingAttempt(t *testing.T) { } } +func TestContextManifestDoesNotPersistWorkflowOutputInResolveScope(t *testing.T) { + st, err := OpenSQLite(filepath.Join(t.TempDir(), "scope-privacy.db")) + if err != nil { + t.Fatal(err) + } + defer st.Close() + const restricted = "OLD_RESTRICTED_BODY" + m := extension.ProjectContextManifest{ProjectID: "project-1", AttemptID: "judge-attempt", InputSHA256: "input-hash", Delivery: "attempted"} + scope := ContextManifestScope{Bound: true} + if err := st.AppendContextManifestWithScope("alice", "run-1", m, scope); err != nil { + t.Fatal(err) + } + m.Delivery = "responded" + if err := st.AppendContextManifestWithScope("alice", "run-1", m, scope); err != nil { + t.Fatal(err) + } + rows, err := st.db.Query(st.q(`SELECT delivery,manifest_json FROM context_manifests WHERE attempt_id=? ORDER BY created_at,id`), m.AttemptID) + if err != nil { + t.Fatal(err) + } + defer rows.Close() + seen := 0 + for rows.Next() { + var delivery, manifest string + if err := rows.Scan(&delivery, &manifest); err != nil { + t.Fatal(err) + } + seen++ + if strings.Contains(manifest, restricted) { + t.Errorf("%s trusted receipt persisted workflow output body", delivery) + } + } + if err := rows.Err(); err != nil { + t.Fatal(err) + } + if seen != 2 { + t.Fatalf("expected attempted and responded receipts, got %d", seen) + } + var rawColumns int + if err := st.db.QueryRow(`SELECT COUNT(*) FROM pragma_table_info('context_manifests') WHERE name IN ('resolve_goal','resolve_target_id')`).Scan(&rawColumns); err != nil || rawColumns != 0 { + t.Fatalf("fresh receipt schema retains raw scope columns: columns=%d err=%v", rawColumns, err) + } +} + +func TestCandidateV34RawScopeColumnsAreScrubbedOnUpgrade(t *testing.T) { + path := filepath.Join(t.TempDir(), "candidate-v34.db") + st, err := OpenSQLite(path) + if err != nil { + t.Fatal(err) + } + m := extension.ProjectContextManifest{ProjectID: "p1", AttemptID: "old-model", InputSHA256: "input", Delivery: "attempted"} + if err := st.AppendContextManifestWithScope("alice", "run-1", m, ContextManifestScope{Bound: true}); err != nil { + t.Fatal(err) + } + for _, query := range []string{ + `DELETE FROM schema_migrations WHERE version=35`, + `ALTER TABLE context_manifests ADD COLUMN resolve_goal TEXT NOT NULL DEFAULT ''`, + `ALTER TABLE context_manifests ADD COLUMN resolve_target_id TEXT NOT NULL DEFAULT ''`, + `UPDATE context_manifests SET resolve_goal='OLD_RESTRICTED_BODY',resolve_target_id='doc-private'`, + } { + if _, err := st.db.Exec(query); err != nil { + t.Fatal(err) + } + } + if err := st.Close(); err != nil { + t.Fatal(err) + } + upgraded, err := OpenSQLite(path) + if err != nil { + t.Fatal(err) + } + defer upgraded.Close() + var columns int + if err := upgraded.db.QueryRow(`SELECT COUNT(*) FROM pragma_table_info('context_manifests') WHERE name IN ('resolve_goal','resolve_target_id')`).Scan(&columns); err != nil || columns != 0 { + t.Fatalf("candidate raw scope columns survived v35: columns=%d err=%v", columns, err) + } + var count int + if err := upgraded.db.QueryRow(`SELECT COUNT(*) FROM context_manifests WHERE attempt_id='old-model'`).Scan(&count); err != nil || count != 1 { + t.Fatalf("trusted manifest disappeared during scrub: count=%d err=%v", count, err) + } + for _, suffix := range []string{"", "-wal"} { + data, err := os.ReadFile(path + suffix) + if err == nil && bytes.Contains(data, []byte("OLD_RESTRICTED_BODY")) { + t.Fatalf("candidate raw scope bytes remain in SQLite %s after upgrade", suffix) + } + } +} + +func TestCandidateV34PostgresRawScopeScrubAndFreshSchema(t *testing.T) { + st := openTestStore(t) + if st.Dialect() != "postgres" { + t.Skip("isolated PostgreSQL DSN not configured") + } + checkColumns := func(want int) { + t.Helper() + var count int + if err := st.db.QueryRow(`SELECT COUNT(*) FROM information_schema.columns WHERE table_schema=current_schema() AND table_name='context_manifests' AND column_name IN ('resolve_goal','resolve_target_id')`).Scan(&count); err != nil || count != want { + t.Fatalf("raw scope columns=%d want=%d err=%v", count, want, err) + } + } + checkColumns(0) + m := extension.ProjectContextManifest{ProjectID: "p1", AttemptID: "candidate-model", InputSHA256: "input", Delivery: "attempted"} + if err := st.AppendContextManifestWithScope("alice", "run-1", m, ContextManifestScope{Bound: true}); err != nil { + t.Fatal(err) + } + for _, query := range []string{ + `DELETE FROM schema_migrations WHERE version=35`, + `ALTER TABLE context_manifests ADD COLUMN resolve_goal TEXT NOT NULL DEFAULT ''`, + `ALTER TABLE context_manifests ADD COLUMN resolve_target_id TEXT NOT NULL DEFAULT ''`, + `UPDATE context_manifests SET resolve_goal='OLD_RESTRICTED_BODY',resolve_target_id='doc-private'`, + } { + if _, err := st.db.Exec(query); err != nil { + t.Fatal(err) + } + } + checkColumns(2) + if err := st.migrate(); err != nil { + t.Fatal(err) + } + checkColumns(0) + var count int + if err := st.db.QueryRow(`SELECT COUNT(*) FROM context_manifests WHERE attempt_id='candidate-model'`).Scan(&count); err != nil || count != 1 { + t.Fatalf("trusted manifest lost during PG scrub: count=%d err=%v", count, err) + } +} + func TestContextManifestTerminalCannotChangeTrustedResolveScope(t *testing.T) { st, err := OpenSQLite(filepath.Join(t.TempDir(), "scope.db")) if err != nil { @@ -44,14 +173,11 @@ func TestContextManifestTerminalCannotChangeTrustedResolveScope(t *testing.T) { } defer st.Close() m := extension.ProjectContextManifest{ProjectID: "p1", AttemptID: "model-1", WorkflowStepAttemptID: "engine/draft/1", InputSHA256: "input-hash", Delivery: "attempted"} - scope := ContextManifestScope{Goal: "draft from A", Bound: true} + scope := ContextManifestScope{Bound: true} if err := st.AppendContextManifestWithScope("alice", "run-1", m, scope); err != nil { t.Fatal(err) } m.Delivery = "responded" - if err := st.AppendContextManifestWithScope("alice", "run-1", m, ContextManifestScope{Goal: "draft from B", Bound: true}); err == nil { - t.Fatal("terminal receipt changed its trusted Resolve goal") - } if err := st.AppendContextManifest("alice", "run-1", m); err == nil { t.Fatal("terminal receipt dropped its trusted Resolve scope") } diff --git a/internal/store/migrate.go b/internal/store/migrate.go index bf6fab9..b9bb9af 100644 --- a/internal/store/migrate.go +++ b/internal/store/migrate.go @@ -3,6 +3,7 @@ package store import ( "context" "database/sql" + "errors" "fmt" "strings" "time" @@ -871,14 +872,18 @@ func init() { }, migration{version: 34, name: "context_manifest_resolve_scope", up: map[string][]string{ - "sqlite": {`ALTER TABLE context_manifests ADD COLUMN resolve_goal TEXT NOT NULL DEFAULT ''`, `ALTER TABLE context_manifests ADD COLUMN resolve_target_id TEXT NOT NULL DEFAULT ''`, `ALTER TABLE context_manifests ADD COLUMN scope_bound INTEGER NOT NULL DEFAULT 0`}, - "postgres": {`ALTER TABLE context_manifests ADD COLUMN resolve_goal TEXT NOT NULL DEFAULT ''`, `ALTER TABLE context_manifests ADD COLUMN resolve_target_id TEXT NOT NULL DEFAULT ''`, `ALTER TABLE context_manifests ADD COLUMN scope_bound INTEGER NOT NULL DEFAULT 0`}, + "sqlite": {`ALTER TABLE context_manifests ADD COLUMN scope_bound INTEGER NOT NULL DEFAULT 0`}, + "postgres": {`ALTER TABLE context_manifests ADD COLUMN scope_bound INTEGER NOT NULL DEFAULT 0`}, }, down: map[string][]string{ - "sqlite": {`ALTER TABLE context_manifests DROP COLUMN scope_bound`, `ALTER TABLE context_manifests DROP COLUMN resolve_target_id`, `ALTER TABLE context_manifests DROP COLUMN resolve_goal`}, - "postgres": {`ALTER TABLE context_manifests DROP COLUMN scope_bound`, `ALTER TABLE context_manifests DROP COLUMN resolve_target_id`, `ALTER TABLE context_manifests DROP COLUMN resolve_goal`}, + "sqlite": {`ALTER TABLE context_manifests DROP COLUMN scope_bound`}, + "postgres": {`ALTER TABLE context_manifests DROP COLUMN scope_bound`}, }, }, + migration{version: 35, name: "scrub_candidate_context_scope_text", + up: map[string][]string{"sqlite": {`SELECT 1`}, "postgres": {`SELECT 1`}}, + down: map[string][]string{"sqlite": {`SELECT 1`}, "postgres": {`SELECT 1`}}, + }, ) } @@ -971,10 +976,35 @@ func (s *Store) migrate() error { if s.dialect.name() == "postgres" { return s.migratePG() } + var candidateRawColumns int + if err := s.db.QueryRow(`SELECT COUNT(*) FROM pragma_table_info('context_manifests') WHERE name IN ('resolve_goal','resolve_target_id')`).Scan(&candidateRawColumns); err != nil { + return err + } // SQLite：_txlock=immediate（OpenSQLite DSN）保证迁移事务在 BEGIN 即取写锁， // 跨进程迁移者按 busy_timeout 排队；后续版本读取发生在同一事务内， // 前一个迁移者提交后本进程看到的已是完整账本（无部分版本可见）。 - return s.migratePass() + if err := s.migratePass(); err != nil { + return err + } + if candidateRawColumns > 0 { + // The prior candidate schema may have stored full prompts. VACUUM is + // outside the DDL transaction; it compacts the isolated SQLite file + // after v35 drops those columns. Refuse to serve if compaction fails. + if _, err := s.db.Exec(`PRAGMA secure_delete=ON`); err != nil { + return fmt.Errorf("candidate context scrub: %w", err) + } + if _, err := s.db.Exec(`VACUUM`); err != nil { + return fmt.Errorf("candidate context scrub: %w", err) + } + var busy, logFrames, checkpointed int + if err := s.db.QueryRow(`PRAGMA wal_checkpoint(TRUNCATE)`).Scan(&busy, &logFrames, &checkpointed); err != nil { + return fmt.Errorf("candidate context scrub checkpoint: %w", err) + } + if busy != 0 { + return errors.New("candidate context scrub checkpoint remains busy") + } + } + return nil } // migratePG 以会话级咨询锁串行化并发迁移者（KTD8）：锁在专用连接上获取， @@ -1052,6 +1082,11 @@ func (s *Store) migratePass() error { if applied[m.version] { continue } + if m.version == 35 { + if err := scrubCandidateContextScope(tx, s.dialect.name()); err != nil { + return fmt.Errorf("migrate v35: %w", err) + } + } stmts := m.up[s.dialect.name()] if len(stmts) == 0 { return fmt.Errorf("migrate: v%d %s 缺少 %s 方言", m.version, m.name, s.dialect.name()) @@ -1073,6 +1108,34 @@ func (s *Store) migratePass() error { return tx.Commit() } +// Candidate v34 was never released, but isolated test databases may already +// contain raw Resolve goals. Fresh v34 creates no such columns; v35 removes +// them conditionally from the earlier candidate schema before serving. +func scrubCandidateContextScope(tx *sql.Tx, dialect string) error { + for _, column := range []string{"resolve_goal", "resolve_target_id"} { + var exists int + var err error + if dialect == "sqlite" { + err = tx.QueryRow(`SELECT COUNT(*) FROM pragma_table_info('context_manifests') WHERE name=?`, column).Scan(&exists) + } else { + err = tx.QueryRow(`SELECT COUNT(*) FROM information_schema.columns WHERE table_schema=current_schema() AND table_name='context_manifests' AND column_name=$1`, column).Scan(&exists) + } + if err != nil { + return err + } + if exists == 0 { + continue + } + if _, err := tx.Exec(`UPDATE context_manifests SET ` + column + `=''`); err != nil { + return err + } + if _, err := tx.Exec(`ALTER TABLE context_manifests DROP COLUMN ` + column); err != nil { + return err + } + } + return nil +} + func latestMigrationVersion() int { if len(migrations) == 0 { return 0 diff --git a/internal/store/migrate_compat.go b/internal/store/migrate_compat.go index 7b17ce6..a3addac 100644 --- a/internal/store/migrate_compat.go +++ b/internal/store/migrate_compat.go @@ -39,6 +39,7 @@ var migrationBreaksOldReaders = map[int]bool{ 32: false, // trusted_context_manifests：独立可信回执表，旧读者不受影响 33: false, // workflow_step_sources：新增逐步骤来源绑定表，旧读者不受影响 34: false, // context_manifest_resolve_scope：可信回执增加原Resolve范围，旧读者不受影响 + 35: false, // scrub_candidate_context_scope_text：候选v34原文列清理，旧读者不受影响 } // SchemaTarget 是本二进制会迁移到的 schema 版本。 diff --git a/internal/store/workflow_step_source.go b/internal/store/workflow_step_source.go index e5bbfad..7806c6b 100644 --- a/internal/store/workflow_step_source.go +++ b/internal/store/workflow_step_source.go @@ -40,17 +40,18 @@ func (s *Store) BindWorkflowStepSource(owner, runID, stepID, stepAttemptID, kind if err != nil || run.Owner != owner || run.ProjectID == "" { return WorkflowStepSource{}, ErrNotFound } - rows, err := s.db.Query(s.q(`SELECT created_at,manifest_json,resolve_target_id,scope_bound FROM context_manifests WHERE owner=? AND target_id=? AND delivery='responded'`), owner, runID) + rows, err := s.db.Query(s.q(`SELECT created_at,delivery,manifest_json,scope_bound FROM context_manifests WHERE owner=? AND target_id=?`), owner, runID) if err != nil { return WorkflowStepSource{}, err } defer rows.Close() var latest extension.ProjectContextManifest var latestAt time.Time + states := map[string]uint8{} for rows.Next() { - var atRaw, raw, resolveTarget string + var atRaw, delivery, raw string var scopeBound int - if err := rows.Scan(&atRaw, &raw, &resolveTarget, &scopeBound); err != nil { + if err := rows.Scan(&atRaw, &delivery, &raw, &scopeBound); err != nil { return WorkflowStepSource{}, err } at, err := time.Parse(time.RFC3339Nano, atRaw) @@ -67,7 +68,19 @@ func (s *Store) BindWorkflowStepSource(owner, runID, stepID, stepAttemptID, kind if m.WorkflowStepAttemptID != stepAttemptID { continue } - if scopeBound != 1 || resolveTarget != "" { + switch delivery { + case "attempted": + states[m.AttemptID] |= 1 + continue + case "unknown": + states[m.AttemptID] |= 4 + continue + case "responded": + states[m.AttemptID] |= 2 + default: + return WorkflowStepSource{}, errors.New("workflow model receipt has unknown delivery state") + } + if scopeBound != 1 { return WorkflowStepSource{}, errors.New("workflow step model receipt lacks trusted original Resolve scope") } if m.ProjectID != run.ProjectID || m.AuthorizationEpoch == "" || m.PublicationEpoch == "" || m.AttemptID == "" { @@ -83,6 +96,11 @@ func (s *Store) BindWorkflowStepSource(owner, runID, stepID, stepAttemptID, kind if err := rows.Err(); err != nil { return WorkflowStepSource{}, err } + for _, state := range states { + if state != 3 { + return WorkflowStepSource{}, errors.New("workflow step has an unsettled or unknown model attempt") + } + } if latestAt.IsZero() { return WorkflowStepSource{}, errors.New("workflow prompt output has no responded model receipt") } @@ -108,16 +126,17 @@ func (s *Store) RespondedWorkflowStepManifests(owner, runID, stepAttemptID strin if owner == "" || runID == "" || stepAttemptID == "" { return nil, errors.New("workflow receipt scope is incomplete") } - rows, err := s.db.Query(s.q(`SELECT manifest_json,resolve_goal,resolve_target_id,scope_bound FROM context_manifests WHERE owner=? AND target_id=? AND delivery='responded' ORDER BY created_at,id`), owner, runID) + rows, err := s.db.Query(s.q(`SELECT delivery,manifest_json,scope_bound FROM context_manifests WHERE owner=? AND target_id=? ORDER BY created_at,id`), owner, runID) if err != nil { return nil, err } defer rows.Close() var out []ScopedContextManifest + states := map[string]uint8{} for rows.Next() { - var raw, goal, target string + var delivery, raw string var bound int - if err := rows.Scan(&raw, &goal, &target, &bound); err != nil { + if err := rows.Scan(&delivery, &raw, &bound); err != nil { return nil, err } var manifest extension.ProjectContextManifest @@ -127,11 +146,28 @@ func (s *Store) RespondedWorkflowStepManifests(owner, runID, stepAttemptID strin if manifest.WorkflowStepAttemptID != stepAttemptID { continue } - out = append(out, ScopedContextManifest{Manifest: manifest, Scope: ContextManifestScope{Goal: goal, TargetID: target, Bound: bound == 1}}) + switch delivery { + case "attempted": + states[manifest.AttemptID] |= 1 + continue + case "unknown": + states[manifest.AttemptID] |= 4 + continue + case "responded": + states[manifest.AttemptID] |= 2 + default: + return nil, errors.New("workflow model receipt has unknown delivery state") + } + out = append(out, ScopedContextManifest{Manifest: manifest, Scope: ContextManifestScope{Bound: bound == 1}}) } if err := rows.Err(); err != nil { return nil, err } + for _, state := range states { + if state != 3 { + return nil, errors.New("workflow step has an unsettled or unknown model attempt") + } + } if len(out) == 0 { return nil, ErrNotFound } diff --git a/internal/store/workflow_step_source_test.go b/internal/store/workflow_step_source_test.go index f58d9f7..50eed31 100644 --- a/internal/store/workflow_step_source_test.go +++ b/internal/store/workflow_step_source_test.go @@ -30,7 +30,7 @@ func TestWorkflowStepSourceRequiresRespondedManifestAndExactRunStep(t *testing.T } started := time.Now().Add(-time.Second) m := extension.ProjectContextManifest{ProjectID: p.ID, AttemptID: "attempt-1", WorkflowStepAttemptID: "engine-run/draft/1", Delivery: "attempted", InputSHA256: "input", AuthorizationEpoch: "duty-1", PublicationEpoch: "pub-1", Watermark: "w1"} - scope := ContextManifestScope{Goal: "draft report", Bound: true} + scope := ContextManifestScope{Bound: true} if err := st.AppendContextManifestWithScope("alice", string(r.ID), m, scope); err != nil { t.Fatal(err) } @@ -79,6 +79,21 @@ func TestWorkflowStepSourceRequiresRespondedManifestAndExactRunStep(t *testing.T if _, err := st.BindWorkflowStepSource("alice", string(r.ID), "legacy", "engine-run/legacy/1", "prompt", started, []byte("legacy body")); err == nil { t.Fatal("model receipt without bound original Resolve scope became a workflow source") } + unknown := m + unknown.AttemptID, unknown.Delivery = "unknown-model-attempt", "attempted" + if err := st.AppendContextManifestWithScope("alice", string(r.ID), unknown, scope); err != nil { + t.Fatal(err) + } + unknown.Delivery = "unknown" + if err := st.AppendContextManifestWithScope("alice", string(r.ID), unknown, scope); err != nil { + t.Fatal(err) + } + if _, err := st.RespondedWorkflowStepManifests("alice", string(r.ID), "engine-run/draft/1"); err == nil { + t.Fatal("unknown model attempt hidden by earlier responded attempt") + } + if _, err := st.BindWorkflowStepSource("alice", string(r.ID), "draft", "engine-run/draft/1", "prompt", started, []byte("old body")); err == nil { + t.Fatal("unknown model attempt rebound completed step") + } if err := st.UnbindWorkflowStepSource("alice", string(r.ID), "draft"); err != nil { t.Fatal(err) } diff --git a/internal/wfcompile/host.go b/internal/wfcompile/host.go index b0ca13a..12a57da 100644 --- a/internal/wfcompile/host.go +++ b/internal/wfcompile/host.go @@ -98,6 +98,17 @@ type hostRunner struct { } func (r *hostRunner) Run(ctx context.Context, step squad.IntentStep) (*squad.ExecResult, error) { + if r.rc.Run().ProjectID != "" { + guard, ok := r.rc.(ProjectStepProvenance) + if !ok { + return &squad.ExecResult{Success: false, ErrorReason: "project workflow source guard unavailable"}, nil + } + wsDir := filepath.Dir(filepath.Dir(step.WorkDir)) + strict := step.IntentID == IntentTool || step.IntentID == IntentArtifact || step.IntentID == IntentScript || step.IntentID == IntentCritic + if err := verifyPriorWorkflowOutputs(ctx, guard, wsDir, r.subOf, r.stepKinds, strict); err != nil { + return &squad.ExecResult{Success: false, ErrorReason: err.Error()}, nil + } + } var content string var fields map[string]string var err error diff --git a/internal/wfcompile/project_backend.go b/internal/wfcompile/project_backend.go index 47e2e1c..08eb01a 100644 --- a/internal/wfcompile/project_backend.go +++ b/internal/wfcompile/project_backend.go @@ -2,6 +2,7 @@ package wfcompile import ( "context" + "path/filepath" "agent-squad/squad" "agent-system-backend/internal/projectcontext" @@ -10,7 +11,7 @@ import ( // projectStepBackends carries the engine-generated execution ID through the // executor's request context into each model manifest. This associates a // responded model request with exactly one workflow step attempt. -func projectStepBackends(base *squad.BackendResolver) *squad.BackendResolver { +func projectStepBackends(base *squad.BackendResolver, rc ProjectStepProvenance, subOf, kinds map[string]string) *squad.BackendResolver { wrapped := squad.NewBackendResolver() for _, name := range base.ListBackends() { backendName := name @@ -19,13 +20,17 @@ func projectStepBackends(base *squad.BackendResolver) *squad.BackendResolver { if err != nil { return nil, err } - return &projectStepExecutor{next: backend}, nil + return &projectStepExecutor{next: backend, rc: rc, subOf: subOf, kinds: kinds}, nil }) } return wrapped } -type projectStepExecutor struct{ next squad.Executor } +type projectStepExecutor struct { + next squad.Executor + rc ProjectStepProvenance + subOf, kinds map[string]string +} func (e *projectStepExecutor) Name() string { return e.next.Name() } @@ -33,5 +38,11 @@ func (e *projectStepExecutor) Execute(ctx context.Context, req squad.ExecRequest if req.ExecutionID == "" { return &squad.ExecResult{Success: false, ErrorReason: "project workflow step attempt unavailable"}, nil } + if e.rc != nil { + wsDir := filepath.Dir(filepath.Dir(req.WorkDir)) + if err := verifyPriorWorkflowOutputs(ctx, e.rc, wsDir, e.subOf, e.kinds, true); err != nil { + return &squad.ExecResult{Success: false, ErrorReason: err.Error()}, nil + } + } return e.next.Execute(projectcontext.WithWorkflowStepAttempt(ctx, req.ExecutionID), req) } diff --git a/internal/wfcompile/project_sources.go b/internal/wfcompile/project_sources.go index 0c971ab..c191f94 100644 --- a/internal/wfcompile/project_sources.go +++ b/internal/wfcompile/project_sources.go @@ -3,6 +3,7 @@ package wfcompile import ( "context" "errors" + "fmt" "os" "path/filepath" "sync" @@ -11,6 +12,41 @@ import ( "agent-squad/squad" ) +// verifyPriorWorkflowOutputs is shared by model and host steps. The engine's +// task brief/blackboard/handoff can carry earlier output as a fresh user +// prompt, so every completed machine step must have a current source proof. +func verifyPriorWorkflowOutputs(ctx context.Context, rc ProjectStepProvenance, wsDir string, subOf, kinds map[string]string, modelSend bool) error { + state, err := (squad.FileStore{}).LoadRun(wsDir) + if err != nil { + return fmt.Errorf("project workflow state unavailable: %w", err) + } + for _, step := range state.Plan.Workflow.Steps { + if step.Status != "completed" { + continue + } + switch kinds[step.ID] { + case "prompt": + sub := subOf[step.ID] + if sub == "" || step.AttemptID == "" { + return fmt.Errorf("project workflow step %s lacks source identity", step.ID) + } + data, err := os.ReadFile(filepath.Join(wsDir, filepath.FromSlash(sub), "output.md")) + if err != nil { + return fmt.Errorf("project workflow step %s output unavailable: %w", step.ID, err) + } + if err := rc.VerifyProjectStepOutput(ctx, step.ID, step.AttemptID, "prompt", data); err != nil { + return fmt.Errorf("project workflow step %s output source changed: %w", step.ID, err) + } + case "hitl", "critic": // human input or a verdict whose prompt source was checked above + default: + if modelSend { + return fmt.Errorf("project workflow step %s has unproven machine output", step.ID) + } + } + } + return nil +} + // completedStepAttempt comes from the squad engine's persisted state, not a // model response or plugin argument. It identifies the exact execution that // produced output.md, including after a workflow resumes. diff --git a/internal/wfcompile/run.go b/internal/wfcompile/run.go index 8799e13..41c011b 100644 --- a/internal/wfcompile/run.go +++ b/internal/wfcompile/run.go @@ -80,6 +80,9 @@ func RunCompiled(rc Host, deps Deps, launch workflow.Launch, vars workflow.Vars, for _, step := range def.Steps { stepKinds[step.ID] = step.Kind } + for _, pair := range compiled.Critics { + stepKinds[pair.EvalID] = "critic" + } if rc.Run().ProjectID != "" { if _, ok := rc.(ProjectStepProvenance); !ok { return Outcome{}, fmt.Errorf("项目工作流缺少可信步骤产物绑定能力") @@ -97,7 +100,7 @@ func RunCompiled(rc Host, deps Deps, launch workflow.Launch, vars workflow.Vars, backends = squad.NewBackendResolver() } if rc.Run().ProjectID != "" { - backends = projectStepBackends(backends) + backends = projectStepBackends(backends, rc.(ProjectStepProvenance), compiled.SubOf, stepKinds) } runner := &hostRunner{ rc: rc, deps: deps, scripts: launch.Scripts, subOf: compiled.SubOf, diff --git a/internal/wfcompile/wfcompile_test.go b/internal/wfcompile/wfcompile_test.go index a9a57e2..7ec0bfa 100644 --- a/internal/wfcompile/wfcompile_test.go +++ b/internal/wfcompile/wfcompile_test.go @@ -476,7 +476,7 @@ func TestProjectStepBackendCarriesEngineAttempt(t *testing.T) { probe := &stepContextProbe{} base := squad.NewBackendResolver() base.RegisterInstance("probe", probe) - backend, _, err := projectStepBackends(base).Resolve(squad.RoleSpec{Role: "writer", Backend: "probe"}, "") + backend, _, err := projectStepBackends(base, nil, nil, nil).Resolve(squad.RoleSpec{Role: "writer", Backend: "probe"}, "") if err != nil { t.Fatal(err) } @@ -563,11 +563,24 @@ func TestProjectToolCriticRejectsUnprovenOutputBeforeModel(t *testing.T) { return verdictStream(verdictPass)(ctx, model, messages, tools, opts) } _, err := RunCompiled(f, Deps{DataDir: t.TempDir(), JudgeStream: judge}, workflow.Launch{Def: def}, workflow.Vars{Input: "read"}, RunOptions{}) - if err == nil || called || !strings.Contains(err.Error(), "产物依据不可用") { + if err == nil || called || (!strings.Contains(err.Error(), "产物依据不可用") && !strings.Contains(err.Error(), "unproven machine output")) { t.Fatalf("unproven tool output reached judge: err=%v called=%v", err, called) } } +func TestProjectModelStepRejectsEarlierToolOutputInTaskBrief(t *testing.T) { + f := &projectSourceHost{fakeHost: &fakeHost{toolNames: []string{"time_now"}}} + be := &seqBackend{texts: []string{"should not run"}} + def := core.WorkflowDef{ID: "tool-then-model", Title: "Tool then model", Steps: []core.WorkflowStep{ + {ID: "get", Title: "Read", Kind: "tool", Tool: "time_now"}, + {ID: "draft", Title: "Draft", Kind: "prompt", Agent: "writer", Prompt: "use {{steps.get.output}}"}, + }} + _, err := RunCompiled(f, Deps{DataDir: t.TempDir(), Backends: seqResolver(t, be), DefaultBackend: "seq"}, workflow.Launch{Def: def}, workflow.Vars{Input: "write"}, RunOptions{}) + if err == nil || be.calls != 0 || !strings.Contains(err.Error(), "unproven machine output") { + t.Fatalf("tool output entered project model step: err=%v modelCalls=%d", err, be.calls) + } +} + // critic 预算耗尽仍不通过 → 工作流失败（P4 fail-closed）。 func TestRunCompiledCriticExhaustedFails(t *testing.T) { def := parseDef(t, demoBriefJSON) diff --git a/pkg/extension/project_context.go b/pkg/extension/project_context.go index 2010b0c..9c207bb 100644 --- a/pkg/extension/project_context.go +++ b/pkg/extension/project_context.go @@ -83,6 +83,27 @@ type ProjectContextProvider interface { ReadEvidence(context.Context, ProjectEvidenceRequest) (ProjectEvidence, error) } +// ProjectContextSourceRecheckRequest names only sources already present in a +// trusted model-input receipt. Scope identity is rebuilt by Backend from the +// persisted run; no prompt, output body, or caller-chosen owner is accepted. +type ProjectContextSourceRecheckRequest struct { + Scope ProjectContextRequest + Included []ProjectContextManifestEntry + OfferedReferences []ProjectEvidenceRef + ReadEvidence []ProjectContextManifestEntry +} + +// ProjectContextSourceRecheckResult contains current authorized source text +// only for transient Backend hash verification. It is never stored as a new +// model receipt. Every requested source/ref must be present in Bundle. +type ProjectContextSourceRecheckResult struct{ Bundle ProjectContextBundle } + +// ProjectContextSourceRechecker is an optional method of the same registered +// ProjectContextProvider. Project workflow reuse fails closed without it. +type ProjectContextSourceRechecker interface { + Recheck(context.Context, ProjectContextSourceRecheckRequest) (ProjectContextSourceRecheckResult, error) +} + // WorkCompletionRequest gives the generation goal and optional target. It has // no owner/project field; both are resolved from the dispatch host's stored // conversation immediately before the model call. diff --git a/pkg/extension/surface.txt b/pkg/extension/surface.txt index c3a08ec..e8d69ad 100644 --- a/pkg/extension/surface.txt +++ b/pkg/extension/surface.txt @@ -46,6 +46,10 @@ ProjectContextReady ProjectContextRegistry ProjectContextRegistry.RegisterProjectContextProvider ProjectContextRequest +ProjectContextSourceRecheckRequest +ProjectContextSourceRecheckResult +ProjectContextSourceRechecker +ProjectContextSourceRechecker.Recheck ProjectContextStatus ProjectEvidence ProjectEvidenceRef -- 2.54.0 From 63ebc85695790e7d0c2b758e5c0ed1b4adaec008 Mon Sep 17 00:00:00 2001 From: weichen Date: Wed, 14 Oct 2026 05:41:37 +0000 Subject: [PATCH 10/41] Make PostgreSQL project audit cutoffs commit ordered Why: PostgreSQL sequence IDs could commit out of order and make fixed project audit cursors permanently skip a late row. Evidence: SELF PG cross-page RED, CACHE 10 counterexample, configuration drift RED/GREEN, and pre-commit Go, PG migration, and race receipts are recorded in the W9 task card. Fixed-HEAD checks follow this commit. Impact: Guard implicit command audit ID allocation with a transaction advisory lock; reject unsafe sequence/default drift; preserve explicit-ID storage migration; report committed-prefix only for verified project pages. Refs: Approved W9 PostgreSQL cutoff adjustment r1; W9 Backend task card. --- .task/feature-rdm-two-trees-project-audit.md | 12 +- cmd/storage-migrate/main.go | 24 +- internal/app/project_audit.go | 6 +- internal/store/audit.go | 25 + internal/store/migrate.go | 53 ++ internal/store/migrate_compat.go | 1 + internal/store/project_audit_sequence_test.go | 500 ++++++++++++++++++ internal/store/project_audit_test.go | 69 ++- pkg/extension/extension.go | 4 +- pkg/extension/project_audit.go | 7 +- 10 files changed, 661 insertions(+), 40 deletions(-) create mode 100644 internal/store/project_audit_sequence_test.go diff --git a/.task/feature-rdm-two-trees-project-audit.md b/.task/feature-rdm-two-trees-project-audit.md index f72e33b..6eb2de3 100644 --- a/.task/feature-rdm-two-trees-project-audit.md +++ b/.task/feature-rdm-two-trees-project-audit.md @@ -5,6 +5,7 @@ - R0: Backend authoritative `origin/main` `5d5fc9891c0eb8994545ccb8b740535d9b99fb0e`; main was clean and equal to the fetched remote before this worktree was created. Core gitlink in this worktree is `5773e74086791731059730bd3726dc8c9cd1381f`. - Startup receipt: `/tmp/backend-w9-precheck-20261014-01.json` (SELF, exit 2, `SYNC_REQUIRED` for the separate Dev checkout `feature/rdm-increment-acceptance-note`, six commits behind Dev `origin/main`). This Backend task uses the independent-development path in Backend `AGENTS.md`; it does not write that Dev checkout or its task card. The receipt is preserved as a failure, not relabeled READY. - Approved affected design: `rdm-two-trees-stage6-audit-link-design-adjustment-r1.md`, SHA256 `385d9d7570217ddcce9fe60a60c99dc58c9a4875ad790584a724d09a210a6e52`; user approval in the task session covers this local Backend increment, not tag publication or Stage 7 acceptance. +- Approved PostgreSQL cutoff adjustment: `rdm-two-trees-stage6-w9-pg-audit-cutoff-adjustment-r1.md`, SHA256 `2357b715a7c8f3451b34cc25a578d655e8a48f3f26d9cf7561ea7a13998ca857`; scope is isolated Backend implementation/testing, with no real database migration or release authorization. ## Implemented local slice @@ -16,14 +17,19 @@ - Independent review of `a8fa2fe` found two P2 security defects: clock-based operation IDs could collide; and `NewScopedHost(owner,"rdm")` let another compiled plugin self-report the publisher's plugin ID. The new local increment uses 192 bits from `crypto/rand` for each host-generated operation ID. Both zero-offset and explicit-offset publication require a unique committed row for owner/project/operation; a historical duplicate rejects publication, including attempts to link another private command. Verifier registration returns a private `ProjectAuditPublisherFactory` for the registering plugin's background outbox; a generic scoped Host has no publisher method. Fixed-clock concurrent IDs, forged params, ambiguous private offset, forged scoped Host, and legitimate registered publisher each have focused tests. - The minted publisher exposes only `ProjectAuditPublisher`, not the full owner-scoped `Host`; tests reject attempts to use `NewScopedHost` with a self-reported `rdm` string as publisher authority. A publisher is a registration-time capability, while `IdempotencyKey` remains the separate retry identity. - Exact-source linked reads do not enumerate hidden links or reveal raw payload, private conversation ID, or content. Body disclosure and a broad project link list are not implemented; the public coverage reports the narrower capability. +- A PostgreSQL-only v33 default function now takes a table-specific transaction advisory lock before assigning `command_audit.id`, making supported implicit-ID writes commit in source-offset order. Migration and each PG append/project page verify CACHE 1, ascending non-cyclic positive IDs, the exact guarded default expression, and the next ID above the committed maximum; unsafe drift fails closed. SQLite remains single-writer. The owner-only project page reports `committed-prefix` only after the runtime check. Explicit online IDs and sequence maintenance remain prohibited; offline `storage-migrate` advances the owned sequence after copying IDs. ## Verification and remaining work - The session saw RED for the missing store and host interfaces, unscoped cutoff, cross-member private disclosure, and conversation-project reassignment before the respective fixes. These RED outputs were not captured by `make evidence`, so this card does not use them as formal evidence. - SELF receipt `/tmp/backend-w9-go-test-20261014-01.json`: `go test ./...`, exit 0, run on the pre-commit worktree based on R0. - SELF receipt `/tmp/backend-w9-build-20261014-01.json`: `CGO_ENABLED=0 go build ./cmd/agent-system`, exit 0, run on that pre-commit tree. Generated local binary removed after the build. -- SELF PostgreSQL receipt `/tmp/backend-w9-pg-cutoff-20261014-01.json`: isolated PostgreSQL 18.6 instance on port 55442 reproduced a low-ID transaction committing after a higher visible ID. `/tmp/backend-w9-pg-link-20261014-02.json` verifies the new link table, retry/conflict behavior, and the cutoff counterexample against isolated schemas. Both exited 0. The current PG cutoff means only `offset-upper-bound-only`; it is **not** a fixed historical visibility snapshot or safe incremental cursor. +- Historical SELF PostgreSQL receipt `/tmp/backend-w9-pg-cutoff-20261014-01.json`: isolated PostgreSQL 18.6 instance on port 55442 reproduced a low-ID transaction committing after a higher visible ID. `/tmp/backend-w9-pg-link-20261014-02.json` verifies the link table, retry/conflict behavior, and the pre-v33 cutoff counterexample. These receipts describe the old `offset-upper-bound-only` candidate, not the new v33 guarantee. - SELF PostgreSQL receipt `/tmp/backend-w9-pg-migrate-20261014-01.json`: isolated SQLite→PostgreSQL migration preserved one linked receipt and advanced its target sequence; the same migration ID replayed idempotently. The temporary PG instance was stopped and removed after verification. - SELF PostgreSQL receipt `/tmp/backend-w9-pg-operation-20261014-01.json`: a fresh isolated PG instance reran the link lookup, idempotency/conflict, and low-ID late-commit checks after trusted operation-offset resolution was added. The instance was stopped and removed. -- Integration constraint: this branch uses schema v31 (audit attribution) and v32 (links), while the independent W6 Backend branch also has a local v31. Neither branch has consumed the other's unmerged work. After the first branch lands, the later branch owner must sync the new main, renumber its unpublished migrations without rewriting an already released version, and rerun fresh/old SQLite and PG migration plus combined regression on the actual merged source. These isolated tests do not prove W6+W9 compatibility. -- Required next W9 work: add a committed-order waterline or materialize the authorized ID set at the first read, then prove with PG low-ID late commits that history and cross-page incremental reads neither omit nor duplicate operations. The Backend project-event source, actual RDM committed-event verifier/outbox consumer, run ID propagation from command dispatch, model/tool/background receipts, body/detail disclosure, broad authorized list pagination, history/export, and combined product verification remain unfinished. A domain commit followed by a lost Backend audit append leaves the link pending; recovery must retain and reconcile that unknown state without claiming a host receipt. The exact-link slice is not Stage 7 audit acceptance. +- New PG cross-page RED receipt `/tmp/backend-w9-pg-crosspage-red-20261014-01.json`: before v33, page 1 returned offsets 4 and 2, page 2 returned 1 after offset 3 committed, and the paged view omitted 3. The same test now passes with v33. Isolated PG tests also cover CACHE 10 counterexample/rejection, CACHE 1, sequence rewind into a vacant low ID, down/up with unchanged link IDs, advisory-lock timeout and rollback gaps, and SQLite→PG explicit-ID migration. +- Historical pre-commit SELF load receipt `/tmp/backend-w9-pg-load-precommit-20261014-01.json` captured an initial v33 variant whose unlocked status function later produced false `cutoff unsafe` errors under concurrency; it is **not** valid performance acceptance evidence. The corrected status check reads committed MAX before non-MVCC sequence state and does not lock readers; the default ID allocator alone holds the transaction advisory lock and rechecks after `nextval`. `TestProjectAuditConcurrentReadWriteNeverReportsFalseDrift` and repeated PG load/cross-page runs protect that ordering. Three-condition pre-commit SELF raw receipts: `/tmp/backend-w9-pg-load-readlock-precommit-20261014-01.json` uses a test-only locked status wrapper, while `/tmp/backend-w9-pg-load-unlocked2-precommit-20261014-01.json` uses the final MAX-first unlocked status; each run also logs its v32 direct-INSERT baseline, PostgreSQL 18.6 version, 192 writes per mode/8 workers, elapsed time, p95, and throughput. The wrapper adds overhead and all measurements vary with hardware/load; no performance threshold has been approved, so they are Stage 6 cost evidence only. +- Pre-commit SELF `/tmp/backend-w9-default-drift-red-20261014-01.json` showed that a replacement default containing the guarded function name but executing unguarded `nextval` was accepted; `/tmp/backend-w9-default-drift-green-20261014-01.json` verifies exact-expression rejection. Pre-commit SELF `/tmp/backend-w9-precommit-all-20261014-02.json` and `/tmp/backend-w9-precommit-pg-20261014-02.json` passed before this last guard tightening; fixed-HEAD runs are required below. +- After the guard tightening, pre-commit SELF receipts `/tmp/backend-w9-precommit-all-final-20261014-01.json` (`go test ./... -count=1`), `/tmp/backend-w9-precommit-pg-final-20261014-01.json` (isolated PG store/storage-migrate), and `/tmp/backend-w9-precommit-pg-race-20261014-01.json` (cross-page/concurrent read-write with race detector) all exited 0. These still identify the dirty pre-commit tree, so they do not replace fixed-HEAD verification. +- Integration constraint: this branch uses schema v31 (audit attribution), v32 (links), and v33 (PG cutoff), while the independent W6 Backend branch also has a local v31. Neither branch has consumed the other's unmerged work. After the first branch lands, the later branch owner must sync the new main, renumber its unpublished migrations without rewriting an already released version, and rerun fresh/old SQLite and PG migration plus combined regression on the actual merged source. These isolated tests do not prove W6+W9 compatibility. +- Required next W9 work: real RDM committed-event verifier/outbox consumer, Backend project-event source, run ID propagation, model/tool/background receipts, body/detail disclosure, broad authorized linked-operation pagination, history/export, and combined product verification remain unfinished. A domain commit followed by a lost Backend audit append leaves the link pending; recovery must retain and reconcile that unknown state without claiming a host receipt. Exact-link and owner-only paging do not satisfy Stage 7 audit acceptance. PostgreSQL v33 adds a global command-audit append lock; its measured wait/throughput cost has no approved performance threshold and needs human Stage 6 review. diff --git a/cmd/storage-migrate/main.go b/cmd/storage-migrate/main.go index 884ca51..3a4f366 100644 --- a/cmd/storage-migrate/main.go +++ b/cmd/storage-migrate/main.go @@ -752,30 +752,34 @@ func sqliteBool(v any) bool { // 后续应用插入会撞主键）。无序列表为空操作。 func advanceSequences(db *sql.DB, table string) error { rows, err := db.Query(` - SELECT pg_get_serial_sequence($1, column_name) + SELECT column_name, pg_get_serial_sequence(format('%I.%I',table_schema,table_name), column_name) FROM information_schema.columns - WHERE table_schema=current_schema() AND table_name=$1 - AND (column_default LIKE 'nextval%' OR is_identity='YES')`, table) + WHERE table_schema=current_schema() AND table_name=$1`, table) if err != nil { return err } defer rows.Close() - var seqs []string + var seqs []struct{ name, column string } for rows.Next() { - var s any - if err := rows.Scan(&s); err != nil { + var column string + var seq sql.NullString + if err := rows.Scan(&column, &seq); err != nil { return err } - if s != nil { - seqs = append(seqs, s.(string)) + if seq.Valid { + seqs = append(seqs, struct{ name, column string }{seq.String, column}) } } if err := rows.Err(); err != nil { return err } for _, s := range seqs { - if _, err := db.Exec(fmt.Sprintf(`SELECT setval('%s', COALESCE((SELECT MAX(id) FROM "%s"), 1))`, s, table)); err != nil { - return fmt.Errorf("setval %s: %w", s, err) + // Sequence ownership remains authoritative when a column's default is a + // guarded function rather than a literal nextval expression. + column := `"` + strings.ReplaceAll(s.column, `"`, `""`) + `"` + tableName := `"` + strings.ReplaceAll(table, `"`, `""`) + `"` + if _, err := db.Exec(fmt.Sprintf(`SELECT setval($1::regclass, COALESCE((SELECT MAX(%s) FROM %s), 1))`, column, tableName), s.name); err != nil { + return fmt.Errorf("setval %s (%s): %w", s.name, s.column, err) } } return nil diff --git a/internal/app/project_audit.go b/internal/app/project_audit.go index 8a005cc..43a7183 100644 --- a/internal/app/project_audit.go +++ b/internal/app/project_audit.go @@ -274,15 +274,11 @@ func (h inprocHost) QueryProjectAudit(ctx context.Context, q extension.ProjectAu if err != nil { return extension.ProjectAuditPage{}, err } - cutoffConsistency := "committed-prefix" - if h.caps.st.Dialect() == "postgres" { - cutoffConsistency = "offset-upper-bound-only" - } page := extension.ProjectAuditPage{ Receipts: make([]extension.HostAuditReceipt, 0, len(rows)), NextOffset: next, CutoffOffset: cutoff, Coverage: extension.ProjectAuditCoverage{ - CommandAudit: "actor-owned-project-bound-only", CutoffConsistency: cutoffConsistency, CrossMember: "unsupported", LegacyProjectBinding: "not-recorded", RunRelations: "unsupported", ModelReceipts: "unsupported", + CommandAudit: "actor-owned-project-bound-only", CutoffConsistency: "committed-prefix", CrossMember: "unsupported", LegacyProjectBinding: "not-recorded", RunRelations: "unsupported", ModelReceipts: "unsupported", BackgroundReceipts: "unsupported", ResourceBodies: "unsupported", }, } diff --git a/internal/store/audit.go b/internal/store/audit.go index d77301a..6894c02 100644 --- a/internal/store/audit.go +++ b/internal/store/audit.go @@ -4,6 +4,7 @@ import ( "database/sql" "encoding/json" "errors" + "fmt" "time" agentcommand "agent-command" @@ -13,6 +14,9 @@ import ( // owner 是租户身份（认证注入），与信封里的 Actor（发起主体）语义不同：查询按 // owner 过滤，跨租户审计不可见。 func (s *Store) AppendAudit(owner string, env agentcommand.AuditEnvelope) error { + if err := s.requireProjectAuditCommittedPrefix(); err != nil { + return err + } raw, err := json.Marshal(env) if err != nil { return err @@ -33,6 +37,24 @@ type ProjectCommandAuditRow struct { Envelope agentcommand.AuditEnvelope } +// ErrAuditCutoffUnsafe prevents a PostgreSQL page from claiming a fixed cutoff +// when the installed ID generator or sequence no longer proves commit order. +var ErrAuditCutoffUnsafe = errors.New("store: project audit cutoff unsafe") + +func (s *Store) requireProjectAuditCommittedPrefix() error { + if s.dialect.name() != "postgres" { + return nil + } // SQLite serializes writers. + var safe bool + if err := s.db.QueryRow(`SELECT project_audit_cutoff_safe('command_audit'::regclass)`).Scan(&safe); err != nil { + return fmt.Errorf("%w: %v", ErrAuditCutoffUnsafe, err) + } + if !safe { + return ErrAuditCutoffUnsafe + } + return nil +} + // ListProjectCommandAudits reads the project resolved from a trusted conversation // at append time. Reassigning or deleting that conversation cannot rewrite the // original project. Legacy rows without this snapshot are excluded: current @@ -42,6 +64,9 @@ func (s *Store) ListProjectCommandAudits(actorOwner, projectID string, before, c if actorOwner == "" || projectID == "" || before < 0 || cutoff < 0 || (before != 0 && cutoff == 0) { return nil, 0, 0, errors.New("project audit: invalid scope or cursor") } + if err := s.requireProjectAuditCommittedPrefix(); err != nil { + return nil, 0, 0, err + } if limit <= 0 || limit > 200 { limit = 50 } diff --git a/internal/store/migrate.go b/internal/store/migrate.go index 0c44edb..24a9763 100644 --- a/internal/store/migrate.go +++ b/internal/store/migrate.go @@ -866,6 +866,59 @@ func init() { "sqlite": {`DROP TABLE IF EXISTS project_audit_links`}, "postgres": {`DROP TABLE IF EXISTS project_audit_links`}, }}, + migration{version: 33, name: "project_audit_committed_prefix", + up: map[string][]string{ + // SQLite has one writer and one connection per Store; this migration + // only changes PostgreSQL's implicit command_audit ID allocation. + "sqlite": {`SELECT 1`}, + "postgres": { + `LOCK TABLE command_audit IN ACCESS EXCLUSIVE MODE`, + `CREATE FUNCTION project_audit_cutoff_safe(target regclass) RETURNS boolean LANGUAGE plpgsql VOLATILE AS $$ + DECLARE seq regclass; default_expr text; increment_by bigint; min_value bigint; start_value bigint; cache_size bigint; cycles boolean; + last_number numeric; was_called boolean; next_number numeric; min_id bigint; max_id bigint; + BEGIN + seq := pg_get_serial_sequence(target::text,'id')::regclass; + IF seq IS NULL THEN RETURN false; END IF; + SELECT pg_get_expr(d.adbin,d.adrelid) INTO default_expr FROM pg_attrdef d + JOIN pg_attribute a ON a.attrelid=d.adrelid AND a.attnum=d.adnum + WHERE d.adrelid=target AND a.attname='id'; + IF default_expr IS DISTINCT FROM format('next_command_audit_id(%L::regclass)',target::text) THEN RETURN false; END IF; + SELECT seqincrement,seqmin,seqstart,seqcache,seqcycle + INTO increment_by,min_value,start_value,cache_size,cycles FROM pg_sequence WHERE seqrelid=seq; + IF increment_by IS NULL OR increment_by<=0 OR min_value<=0 OR start_value<=0 OR cache_size<>1 OR cycles THEN RETURN false; END IF; + -- Supported writers allocate under the lock before they commit. Read + -- committed rows first, then the non-MVCC sequence state: a writer + -- committing between these reads can only advance the latter. + EXECUTE format('SELECT COALESCE(MIN(id),1),COALESCE(MAX(id),0) FROM %s',target) INTO min_id,max_id; + EXECUTE format('SELECT last_value,is_called FROM %s',seq) INTO last_number,was_called; + next_number := last_number; + IF was_called THEN next_number := last_number+increment_by; END IF; + RETURN min_id>0 AND next_number>0 AND next_number>max_id; + END $$`, + `CREATE FUNCTION next_command_audit_id(target regclass) RETURNS bigint LANGUAGE plpgsql VOLATILE AS $$ + DECLARE seq regclass; allocated bigint; max_id bigint; + BEGIN + PERFORM pg_advisory_xact_lock(715328491,target::oid::int4); + IF NOT project_audit_cutoff_safe(target) THEN RAISE EXCEPTION 'project audit cutoff sequence is unsafe'; END IF; + seq := pg_get_serial_sequence(target::text,'id')::regclass; + allocated := nextval(seq); + EXECUTE format('SELECT COALESCE(MAX(id),0) FROM %s',target) INTO max_id; + IF allocated<=0 OR allocated<=max_id THEN RAISE EXCEPTION 'project audit ID did not advance beyond committed rows'; END IF; + RETURN allocated; + END $$`, + `ALTER TABLE command_audit ALTER COLUMN id SET DEFAULT next_command_audit_id('command_audit'::regclass)`, + `DO $$ BEGIN IF NOT project_audit_cutoff_safe('command_audit'::regclass) THEN RAISE EXCEPTION 'project audit cutoff migration precondition failed'; END IF; END $$`, + }, + }, + down: map[string][]string{ + "sqlite": {`SELECT 1`}, + "postgres": { + `LOCK TABLE command_audit IN ACCESS EXCLUSIVE MODE`, + `ALTER TABLE command_audit ALTER COLUMN id SET DEFAULT nextval(pg_get_serial_sequence('command_audit','id')::regclass)`, + `DROP FUNCTION next_command_audit_id(regclass)`, + `DROP FUNCTION project_audit_cutoff_safe(regclass)`, + }, + }}, ) } diff --git a/internal/store/migrate_compat.go b/internal/store/migrate_compat.go index 9160ed1..a653f3b 100644 --- a/internal/store/migrate_compat.go +++ b/internal/store/migrate_compat.go @@ -37,6 +37,7 @@ var migrationBreaksOldReaders = map[int]bool{ 30: false, // project_event_publication_proofs：新表，旧读者不受影响 31: false, // command_audit_attribution_snapshot：仅加列/索引，旧读者不受影响 32: false, // project_audit_committed_links：新表，旧读者不受影响 + 33: false, // project_audit_committed_prefix：PG 审计 ID 默认函数，旧读者兼容 } // SchemaTarget 是本二进制会迁移到的 schema 版本。 diff --git a/internal/store/project_audit_sequence_test.go b/internal/store/project_audit_sequence_test.go new file mode 100644 index 0000000..022f2b8 --- /dev/null +++ b/internal/store/project_audit_sequence_test.go @@ -0,0 +1,500 @@ +package store + +import ( + "context" + "encoding/json" + "fmt" + "os" + "sort" + "strings" + "sync" + "testing" + "time" + + agentcommand "agent-command" +) + +func openProjectAuditPG(t *testing.T) *Store { + t.Helper() + if os.Getenv("AGENT_PG_TEST_DSN") == "" { + t.Skip("AGENT_PG_TEST_DSN unset: isolated PostgreSQL check NOT_RUN") + } + st := openTestStore(t) + if st.Dialect() != "postgres" { + t.Fatal("expected PostgreSQL") + } + return st +} + +func commandAuditSequenceName(t *testing.T, st *Store) string { + t.Helper() + var name string + if err := st.db.QueryRow(`SELECT pg_get_serial_sequence('command_audit','id')`).Scan(&name); err != nil { + t.Fatal(err) + } + if name == "" { + t.Fatal("command_audit has no owned sequence") + } + return name +} + +func TestProjectAuditSequenceMigrationRejectsCacheTen(t *testing.T) { + st := openProjectAuditPG(t) + if err := st.MigrateDown(32); err != nil { + t.Fatal(err) + } + seq := commandAuditSequenceName(t, st) + if _, err := st.db.Exec("ALTER SEQUENCE " + seq + " CACHE 10"); err != nil { + t.Fatal(err) + } + if err := st.migrate(); err == nil { + t.Fatal("migration accepted CACHE 10, which permits out-of-order IDs") + } + if _, err := st.db.Exec("ALTER SEQUENCE " + seq + " CACHE 1"); err != nil { + t.Fatal(err) + } + if err := st.migrate(); err != nil { + t.Fatalf("safe CACHE 1 migration: %v", err) + } +} + +func TestProjectAuditSequenceRuntimeRejectsConfigurationDrift(t *testing.T) { + st := openProjectAuditPG(t) + seq := commandAuditSequenceName(t, st) + if _, err := st.db.Exec("ALTER SEQUENCE " + seq + " CACHE 10"); err != nil { + t.Fatal(err) + } + if _, _, _, err := st.ListProjectCommandAudits("alice", "project", 0, 0, 10); err == nil { + t.Fatal("project audit reported a cutoff with CACHE 10") + } + if err := st.AppendAudit("alice", agentcommand.AuditEnvelope{Time: time.Now(), Actor: "alice", CommandID: "unsafe-cache"}); err == nil { + t.Fatal("append allocated an ID with CACHE 10") + } + if _, err := st.db.Exec("ALTER SEQUENCE " + seq + " CACHE 1"); err != nil { + t.Fatal(err) + } + if err := st.AppendAudit("alice", agentcommand.AuditEnvelope{Time: time.Now(), Actor: "alice", CommandID: "safe-cache"}); err != nil { + t.Fatalf("safe append after reset: %v", err) + } + if _, err := st.db.Exec("ALTER SEQUENCE " + seq + " CYCLE"); err != nil { + t.Fatal(err) + } + if _, _, _, err := st.ListProjectCommandAudits("alice", "project", 0, 0, 10); err == nil { + t.Fatal("read accepted cyclic audit IDs") + } + if err := st.AppendAudit("alice", agentcommand.AuditEnvelope{Time: time.Now(), Actor: "alice", CommandID: "cyclic"}); err == nil { + t.Fatal("append accepted cyclic audit IDs") + } + if _, err := st.db.Exec("ALTER SEQUENCE " + seq + " NO CYCLE"); err != nil { + t.Fatal(err) + } + if _, err := st.db.Exec("ALTER SEQUENCE " + seq + " MINVALUE -10"); err != nil { + t.Fatal(err) + } + if _, _, _, err := st.ListProjectCommandAudits("alice", "project", 0, 0, 10); err == nil { + t.Fatal("read accepted a nonpositive audit ID range") + } + if _, err := st.db.Exec("ALTER SEQUENCE " + seq + " MINVALUE 1"); err != nil { + t.Fatal(err) + } + if _, err := st.db.Exec(`ALTER TABLE command_audit ALTER COLUMN id SET DEFAULT nextval(pg_get_serial_sequence('command_audit','id')::regclass)`); err != nil { + t.Fatal(err) + } + if _, _, _, err := st.ListProjectCommandAudits("alice", "project", 0, 0, 10); err == nil { + t.Fatal("read accepted an unguarded sequence default") + } + if err := st.AppendAudit("alice", agentcommand.AuditEnvelope{Time: time.Now(), Actor: "alice", CommandID: "unguarded-default"}); err == nil { + t.Fatal("append accepted an unguarded sequence default") + } + if _, err := st.db.Exec(`ALTER TABLE command_audit ALTER COLUMN id SET DEFAULT CASE WHEN false THEN next_command_audit_id('command_audit'::regclass) ELSE nextval(pg_get_serial_sequence('command_audit','id')::regclass) END`); err != nil { + t.Fatal(err) + } + if _, _, _, err := st.ListProjectCommandAudits("alice", "project", 0, 0, 10); err == nil { + t.Fatal("read accepted a replaced default that merely mentions the guarded function") + } + if _, err := st.db.Exec(`ALTER TABLE command_audit ALTER COLUMN id SET DEFAULT next_command_audit_id('command_audit'::regclass)`); err != nil { + t.Fatal(err) + } +} + +func TestProjectAuditSequenceRejectsRewindIntoUnusedGap(t *testing.T) { + st := openProjectAuditPG(t) + p, err := st.CreateProject("alice", "A") + if err != nil { + t.Fatal(err) + } + c, err := st.CreateConversation("alice", string(p.ID), "work", "") + if err != nil { + t.Fatal(err) + } + appendAudit := func(id string) error { + return st.AppendAudit("alice", agentcommand.AuditEnvelope{Time: time.Now(), Actor: "alice", CommandID: id, ConversationID: string(c.ID), State: agentcommand.StateCommitted}) + } + if err := appendAudit("first"); err != nil { + t.Fatal(err) + } + seq := commandAuditSequenceName(t, st) + if _, err := st.db.Exec("SELECT nextval('" + seq + "'::regclass)"); err != nil { + t.Fatal(err) + } // consume one ID without a row + if err := appendAudit("third"); err != nil { + t.Fatal(err) + } + if _, err := st.db.Exec("SELECT setval('" + seq + "'::regclass,1)"); err != nil { + t.Fatal(err) + } + if err := appendAudit("rewound-into-gap"); err == nil { + t.Fatal("rewound sequence inserted a low ID into a committed-prefix gap") + } + if _, _, _, err := st.ListProjectCommandAudits("alice", string(p.ID), 0, 0, 10); err == nil { + t.Fatal("read claimed a safe cutoff after sequence rewind") + } + if _, err := st.db.Exec("SELECT setval('" + seq + "'::regclass,3)"); err != nil { + t.Fatal(err) + } + if err := appendAudit("recovered"); err != nil { + t.Fatalf("append after restoring sequence: %v", err) + } +} + +// Advisory locking alone does not fix cached sequence allocation: session A +// can hold 2..10 while session B commits 11, then A later commits 2. +func TestProjectAuditSequenceCacheTenDefeatsAdvisoryLock(t *testing.T) { + st := openProjectAuditPG(t) + for _, query := range []string{ + `CREATE TABLE cache_probe(id BIGSERIAL PRIMARY KEY)`, + `ALTER SEQUENCE cache_probe_id_seq CACHE 10`, + `CREATE FUNCTION cache_probe_next_id(target regclass) RETURNS bigint LANGUAGE plpgsql AS $$ + BEGIN PERFORM pg_advisory_xact_lock(715328491,target::oid::int4); + RETURN nextval(pg_get_serial_sequence(target::text,'id')::regclass); END $$`, + `ALTER TABLE cache_probe ALTER COLUMN id SET DEFAULT cache_probe_next_id('cache_probe'::regclass)`, + } { + if _, err := st.db.Exec(query); err != nil { + t.Fatal(err) + } + } + ctx := context.Background() + a, err := st.db.Conn(ctx) + if err != nil { + t.Fatal(err) + } + defer a.Close() + b, err := st.db.Conn(ctx) + if err != nil { + t.Fatal(err) + } + defer b.Close() + var first, other, late int64 + if err := a.QueryRowContext(ctx, `INSERT INTO cache_probe DEFAULT VALUES RETURNING id`).Scan(&first); err != nil { + t.Fatal(err) + } + if err := b.QueryRowContext(ctx, `INSERT INTO cache_probe DEFAULT VALUES RETURNING id`).Scan(&other); err != nil { + t.Fatal(err) + } + if err := a.QueryRowContext(ctx, `INSERT INTO cache_probe DEFAULT VALUES RETURNING id`).Scan(&late); err != nil { + t.Fatal(err) + } + if first != 1 || other != 11 || late != 2 { + t.Fatalf("CACHE 10 counterexample changed: A=%d B=%d A-late=%d", first, other, late) + } +} + +func TestProjectAuditSequenceNeverCommitsPreUpgradeCachedLowID(t *testing.T) { + st := openProjectAuditPG(t) + if err := st.MigrateDown(32); err != nil { + t.Fatal(err) + } + seq := commandAuditSequenceName(t, st) + if _, err := st.db.Exec("ALTER SEQUENCE " + seq + " CACHE 10"); err != nil { + t.Fatal(err) + } + ctx := context.Background() + a, err := st.db.Conn(ctx) + if err != nil { + t.Fatal(err) + } + defer a.Close() + b, err := st.db.Conn(ctx) + if err != nil { + t.Fatal(err) + } + defer b.Close() + insert := `INSERT INTO command_audit(time,command_id,source,entrance,state,operation_id,conversation_id,owner,payload) + VALUES ('2026-10-14T00:00:00Z','legacy','','','committed','','','alice','{}') RETURNING id` + var first, high, late int64 + if err := a.QueryRowContext(ctx, insert).Scan(&first); err != nil { + t.Fatal(err) + } + if err := b.QueryRowContext(ctx, insert).Scan(&high); err != nil { + t.Fatal(err) + } + if first != 1 || high != 11 { + t.Fatalf("old cached allocation: first=%d high=%d", first, high) + } + if _, err := st.db.Exec("ALTER SEQUENCE " + seq + " CACHE 1"); err != nil { + t.Fatal(err) + } + if err := st.migrate(); err != nil { + t.Fatalf("upgrade with idle cached connections: %v", err) + } + if err := a.QueryRowContext(ctx, insert).Scan(&late); err == nil && late <= high { + t.Fatalf("old connection committed late low ID %d below %d", late, high) + } + var count int + if err := st.db.QueryRow(`SELECT COUNT(*) FROM command_audit WHERE id=2`).Scan(&count); err != nil || count != 0 { + t.Fatalf("late cached row persisted: count=%d err=%v", count, err) + } +} + +func TestProjectAuditSequenceMigrationRoundTripPreservesLinks(t *testing.T) { + st := openProjectAuditPG(t) + if err := st.EnsureUser("alice", "Alice"); err != nil { + t.Fatal(err) + } + p, err := st.CreateProject("alice", "A") + if err != nil { + t.Fatal(err) + } + c, err := st.CreateConversation("alice", string(p.ID), "work", "") + if err != nil { + t.Fatal(err) + } + if err := st.AppendAudit("alice", agentcommand.AuditEnvelope{Time: time.Now(), Actor: "alice", CommandID: "rdm.confirm", OperationID: "op-1", ConversationID: string(c.ID), State: agentcommand.StateCommitted}); err != nil { + t.Fatal(err) + } + rows, _, _, err := st.ListProjectCommandAudits("alice", string(p.ID), 0, 0, 10) + if err != nil { + t.Fatal(err) + } + offset := rows[0].Offset + link := ProjectAuditLink{HostAuditOffset: offset, ProjectID: string(p.ID), Owner: "alice", SourceKind: "domain-commit", SourceID: "commit-1", OperationID: "op-1", ResourceKind: "document", ResourceID: "doc-1", DisclosureClass: "metadata", IdempotencyKey: "outbox-1"} + if _, err := st.SaveProjectAuditLink(link); err != nil { + t.Fatal(err) + } + if err := st.MigrateDown(32); err != nil { + t.Fatalf("down to v32: %v", err) + } + if _, _, _, err := st.ListProjectCommandAudits("alice", string(p.ID), 0, 0, 10); err == nil { + t.Fatal("old default exposed a strong cutoff after down") + } + if _, row, err := st.ProjectAuditLinkedReceipt(string(p.ID), "domain-commit", "commit-1", offset); err != nil || row.Offset != offset { + t.Fatalf("link changed during down: %+v %v", row, err) + } + if err := st.migrate(); err != nil { + t.Fatalf("up to v33: %v", err) + } + rows, _, _, err = st.ListProjectCommandAudits("alice", string(p.ID), 0, 0, 10) + if err != nil || len(rows) != 1 || rows[0].Offset != offset { + t.Fatalf("restored audit: %+v %v", rows, err) + } + if err := st.AppendAudit("alice", agentcommand.AuditEnvelope{Time: time.Now(), Actor: "alice", CommandID: "after-up", ConversationID: string(c.ID), State: agentcommand.StateCommitted}); err != nil { + t.Fatal(err) + } + rows, _, _, err = st.ListProjectCommandAudits("alice", string(p.ID), 0, 0, 10) + if err != nil || len(rows) != 2 || rows[0].Offset <= offset { + t.Fatalf("sequence not advanced after up: %+v %v", rows, err) + } +} + +func TestProjectAuditSequenceLockTimeoutAndRollback(t *testing.T) { + st := openProjectAuditPG(t) + p, err := st.CreateProject("alice", "A") + if err != nil { + t.Fatal(err) + } + c, err := st.CreateConversation("alice", string(p.ID), "work", "") + if err != nil { + t.Fatal(err) + } + tx, err := st.db.Begin() + if err != nil { + t.Fatal(err) + } + defer tx.Rollback() + insert := st.q(`INSERT INTO command_audit(time,command_id,source,entrance,state,operation_id,conversation_id,owner,payload,actor_name,project_id) + VALUES (?,?,'','','committed','',?,?,?,?,?) RETURNING id`) + args := []any{time.Now().UTC().Format(time.RFC3339Nano), "held", string(c.ID), "alice", `{}`, "Alice", string(p.ID)} + var heldID int64 + if err := tx.QueryRow(insert, args...).Scan(&heldID); err != nil { + t.Fatal(err) + } + ctx := context.Background() + conn, err := st.db.Conn(ctx) + if err != nil { + t.Fatal(err) + } + defer conn.Close() + if _, err := conn.ExecContext(ctx, `SET lock_timeout='150ms'`); err != nil { + t.Fatal(err) + } + var blockedID int64 + err = conn.QueryRowContext(ctx, insert, args...).Scan(&blockedID) + if err == nil || !strings.Contains(err.Error(), "lock timeout") { + t.Fatalf("second writer did not stop on advisory lock: id=%d err=%v", blockedID, err) + } + if _, err := conn.ExecContext(ctx, `RESET lock_timeout`); err != nil { + t.Fatal(err) + } + if err := tx.Rollback(); err != nil { + t.Fatal(err) + } + if err := st.AppendAudit("alice", agentcommand.AuditEnvelope{Time: time.Now(), Actor: "alice", CommandID: "after-rollback", ConversationID: string(c.ID), State: agentcommand.StateCommitted}); err != nil { + t.Fatal(err) + } + rows, cutoff, _, err := st.ListProjectCommandAudits("alice", string(p.ID), 0, 0, 10) + if err != nil || len(rows) != 1 || rows[0].Offset <= heldID || cutoff != rows[0].Offset { + t.Fatalf("rollback gap affected cutoff: rows=%+v cutoff=%d held=%d err=%v", rows, cutoff, heldID, err) + } +} + +func TestProjectAuditSequenceConcurrentLoad(t *testing.T) { + st := openProjectAuditPG(t) + var serverVersion string + if err := st.db.QueryRow(`SHOW server_version`).Scan(&serverVersion); err != nil { + t.Fatal(err) + } + if err := st.EnsureUser("alice", "Alice"); err != nil { + t.Fatal(err) + } + p, err := st.CreateProject("alice", "A") + if err != nil { + t.Fatal(err) + } + c, err := st.CreateConversation("alice", string(p.ID), "work", "") + if err != nil { + t.Fatal(err) + } + const writers, each = 8, 24 + run := func(label string, write func(agentcommand.AuditEnvelope) error) (time.Duration, time.Duration) { + t.Helper() + durations := make([]time.Duration, writers*each) + errors := make(chan error, writers*each) + start := time.Now() + var wg sync.WaitGroup + for worker := 0; worker < writers; worker++ { + wg.Add(1) + go func(worker int) { + defer wg.Done() + for i := 0; i < each; i++ { + env := agentcommand.AuditEnvelope{Time: time.Now(), Actor: "alice", CommandID: fmt.Sprintf("%s-%d-%d", label, worker, i), ConversationID: string(c.ID), State: agentcommand.StateCommitted} + at := time.Now() + if err := write(env); err != nil { + errors <- err + return + } + durations[worker*each+i] = time.Since(at) + } + }(worker) + } + wg.Wait() + close(errors) + for err := range errors { + t.Fatalf("%s append: %v", label, err) + } + elapsed := time.Since(start) + sort.Slice(durations, func(i, j int) bool { return durations[i] < durations[j] }) + return elapsed, durations[len(durations)*95/100] + } + if err := st.MigrateDown(32); err != nil { + t.Fatal(err) + } + oldQuery := st.q(`INSERT INTO command_audit(time,command_id,source,entrance,state,operation_id,conversation_id,owner,payload,actor_name,project_id) + VALUES (?,?,?,?,?,?,?,?,?,COALESCE((SELECT name FROM users WHERE owner=?),''),COALESCE((SELECT project_id FROM conversations WHERE id=? AND owner=?),''))`) + oldElapsed, oldP95 := run("old", func(env agentcommand.AuditEnvelope) error { + raw, err := json.Marshal(env) + if err != nil { + return err + } + _, err = st.db.Exec(oldQuery, env.Time.UTC().Format(time.RFC3339Nano), env.CommandID, "", "", string(env.State), "", env.ConversationID, "alice", string(raw), env.Actor, env.ConversationID, "alice") + return err + }) + if err := st.migrate(); err != nil { + t.Fatalf("upgrade after baseline: %v", err) + } + statusMode := "MAX-first unlocked status" + if os.Getenv("AGENT_AUDIT_BENCH_READ_LOCK") == "1" { + // A test-only wrapper reconstructs the earlier status-read lock so the + // isolated load receipt can compare its cost against the final design. + if _, err := st.db.Exec(`ALTER FUNCTION project_audit_cutoff_safe(regclass) RENAME TO project_audit_cutoff_unlocked`); err != nil { + t.Fatal(err) + } + if _, err := st.db.Exec(`CREATE FUNCTION project_audit_cutoff_safe(target regclass) RETURNS boolean LANGUAGE plpgsql VOLATILE AS $$ + BEGIN PERFORM pg_advisory_xact_lock(715328491,target::oid::int4); + RETURN project_audit_cutoff_unlocked(target); END $$`); err != nil { + t.Fatal(err) + } + statusMode = "test-only locked status wrapper" + } + newElapsed, newP95 := run("guarded", func(env agentcommand.AuditEnvelope) error { return st.AppendAudit("alice", env) }) + t.Logf("isolated PostgreSQL %s audit append: %d writes per mode / %d workers; v32 direct INSERT=%s p95=%s (%.0f/s), v33 Store.AppendAudit with %s=%s p95=%s (%.0f/s); hardware/load dependent SELF only", + serverVersion, writers*each, writers, oldElapsed, oldP95, float64(writers*each)/oldElapsed.Seconds(), statusMode, newElapsed, newP95, float64(writers*each)/newElapsed.Seconds()) + seen := map[string]bool{} + var before, cutoff int64 + for { + page, fixed, next, err := st.ListProjectCommandAudits("alice", string(p.ID), before, cutoff, 100) + if err != nil { + t.Fatal(err) + } + if cutoff == 0 { + cutoff = fixed + } + for _, row := range page { + if seen[row.Envelope.CommandID] { + t.Fatalf("duplicate paged command: %s", row.Envelope.CommandID) + } + seen[row.Envelope.CommandID] = true + } + if next == 0 { + break + } + before = next + } + if len(seen) != 2*writers*each { + t.Fatalf("paged commands=%d want=%d", len(seen), 2*writers*each) + } +} + +func TestProjectAuditConcurrentReadWriteNeverReportsFalseDrift(t *testing.T) { + st := openProjectAuditPG(t) + p, err := st.CreateProject("alice", "A") + if err != nil { + t.Fatal(err) + } + c, err := st.CreateConversation("alice", string(p.ID), "work", "") + if err != nil { + t.Fatal(err) + } + const writers, writes, readers, reads = 6, 30, 4, 40 + errs := make(chan error, writers*writes+readers*reads) + var wg sync.WaitGroup + for worker := 0; worker < writers; worker++ { + wg.Add(1) + go func(worker int) { + defer wg.Done() + for i := 0; i < writes; i++ { + err := st.AppendAudit("alice", agentcommand.AuditEnvelope{Time: time.Now(), Actor: "alice", CommandID: fmt.Sprintf("write-%d-%d", worker, i), ConversationID: string(c.ID), State: agentcommand.StateCommitted}) + if err != nil { + errs <- fmt.Errorf("append: %w", err) + return + } + } + }(worker) + } + for reader := 0; reader < readers; reader++ { + wg.Add(1) + go func() { + defer wg.Done() + for i := 0; i < reads; i++ { + if _, _, _, err := st.ListProjectCommandAudits("alice", string(p.ID), 0, 0, 10); err != nil { + errs <- fmt.Errorf("read: %w", err) + return + } + } + }() + } + wg.Wait() + close(errs) + for err := range errs { + t.Fatal(err) + } +} diff --git a/internal/store/project_audit_test.go b/internal/store/project_audit_test.go index db91605..7234dd7 100644 --- a/internal/store/project_audit_test.go +++ b/internal/store/project_audit_test.go @@ -174,10 +174,10 @@ func TestProjectCommandAuditDoesNotMoveWithConversation(t *testing.T) { } } -// PostgreSQL sequence IDs are allocated before commit. This test records the -// current upper-bound semantics: a lower ID can appear after a page cutoff was -// captured, so callers must not describe the cutoff as a visibility snapshot. -func TestProjectAuditPostgresCutoffLateCommit(t *testing.T) { +// Under the old PostgreSQL SERIAL default, an uncommitted middle ID can be +// skipped after a higher committed row advances the page cursor past it. +// The committed-prefix implementation must keep the later writer waiting. +func TestProjectAuditPostgresCursorNeverSkipsLateCommit(t *testing.T) { if os.Getenv("AGENT_PG_TEST_DSN") == "" { t.Skip("AGENT_PG_TEST_DSN unset: PG concurrency check NOT_RUN") } @@ -196,7 +196,12 @@ func TestProjectAuditPostgresCutoffLateCommit(t *testing.T) { if err != nil { t.Fatal(err) } - env := agentcommand.AuditEnvelope{Time: time.Now(), Actor: "alice", CommandID: "late-low-id", ConversationID: string(c.ID)} + for _, command := range []string{"lower-one", "lower-two"} { + if err := st.AppendAudit("alice", agentcommand.AuditEnvelope{Time: time.Now(), Actor: "alice", CommandID: command, ConversationID: string(c.ID), State: agentcommand.StateCommitted}); err != nil { + t.Fatal(err) + } + } + env := agentcommand.AuditEnvelope{Time: time.Now(), Actor: "alice", CommandID: "middle-pending", ConversationID: string(c.ID), State: agentcommand.StateCommitted} raw, err := json.Marshal(env) if err != nil { t.Fatal(err) @@ -206,29 +211,57 @@ func TestProjectAuditPostgresCutoffLateCommit(t *testing.T) { t.Fatal(err) } defer tx.Rollback() - var lowID int64 + var middleID int64 if err := tx.QueryRow(st.q(`INSERT INTO command_audit(time,command_id,source,entrance,state,operation_id,conversation_id,owner,payload,actor_name,project_id) - VALUES (?,?,'','','','',?,?,?,?,?) RETURNING id`), time.Now().UTC().Format(time.RFC3339Nano), "late-low-id", string(c.ID), "alice", string(raw), "Alice", string(p.ID)).Scan(&lowID); err != nil { + VALUES (?,?,'','','committed','',?,?,?,?,?) RETURNING id`), time.Now().UTC().Format(time.RFC3339Nano), "middle-pending", string(c.ID), "alice", string(raw), "Alice", string(p.ID)).Scan(&middleID); err != nil { t.Fatal(err) } - if err := st.AppendAudit("alice", agentcommand.AuditEnvelope{Time: time.Now(), Actor: "alice", CommandID: "committed-high-id", ConversationID: string(c.ID)}); err != nil { - t.Fatal(err) + highDone := make(chan error, 1) + started := make(chan struct{}) + go func() { + close(started) + highDone <- st.AppendAudit("alice", agentcommand.AuditEnvelope{Time: time.Now(), Actor: "alice", CommandID: "higher-committed", ConversationID: string(c.ID), State: agentcommand.StateCommitted}) + }() + <-started + highCommittedEarly := false + select { + case err := <-highDone: + if err != nil { + t.Fatal(err) + } + highCommittedEarly = true + case <-time.After(250 * time.Millisecond): } - first, cutoff, _, err := st.ListProjectCommandAudits("alice", string(p.ID), 0, 0, 10) - if err != nil { - t.Fatal(err) - } - if len(first) != 1 || first[0].Envelope.CommandID != "committed-high-id" || lowID >= cutoff { - t.Fatalf("first page: rows=%+v low=%d cutoff=%d", first, lowID, cutoff) + var first []ProjectCommandAuditRow + var cutoff, next int64 + if highCommittedEarly { + first, cutoff, next, err = st.ListProjectCommandAudits("alice", string(p.ID), 0, 0, 2) + if err != nil { + tx.Rollback() + t.Fatal(err) + } } if err := tx.Commit(); err != nil { t.Fatal(err) } - later, fixed, _, err := st.ListProjectCommandAudits("alice", string(p.ID), 0, cutoff, 10) + if !highCommittedEarly { + if err := <-highDone; err != nil { + t.Fatal(err) + } + first, cutoff, next, err = st.ListProjectCommandAudits("alice", string(p.ID), 0, 0, 2) + if err != nil { + t.Fatal(err) + } + } + second, fixed, _, err := st.ListProjectCommandAudits("alice", string(p.ID), next, cutoff, 2) if err != nil { t.Fatal(err) } - if fixed != cutoff || len(later) != 2 || later[1].Envelope.CommandID != "late-low-id" { - t.Fatalf("late commit not exposed: rows=%+v cutoff=%d", later, fixed) + seen := map[string]bool{} + for _, row := range append(first, second...) { + seen[row.Envelope.CommandID] = true + } + if next == 0 || fixed != cutoff || len(seen) != 4 || !seen["middle-pending"] { + t.Fatalf("cross-page audit omitted a committed row: early=%v middleID=%d first=%+v second=%+v cutoff=%d next=%d", highCommittedEarly, middleID, first, second, cutoff, next) } } diff --git a/pkg/extension/extension.go b/pkg/extension/extension.go index 1812671..173e5f0 100644 --- a/pkg/extension/extension.go +++ b/pkg/extension/extension.go @@ -42,7 +42,9 @@ import ( // retryable ProjectAuditLinkRequest.HostAuditOffset=0 resolution. // 2.16.0-experimental: cryptographic operation IDs and registration-bound // ProjectAuditPublisherFactory; scoped Host string IDs cannot publish links. -const SurfaceVersion = "2.16.0-experimental" +// 2.17.0-experimental: PostgreSQL project audit pages require a verified +// committed-prefix ID generator; unsafe sequence/default drift rejects reads. +const SurfaceVersion = "2.17.0-experimental" // ErrNotLinked 表示进程没有空白导入 link 包，Main 无法启动服务。 var ErrNotLinked = errors.New("extension: runner not linked; blank-import agent-system-backend/pkg/extension/link") diff --git a/pkg/extension/project_audit.go b/pkg/extension/project_audit.go index ddca97c..d1592fe 100644 --- a/pkg/extension/project_audit.go +++ b/pkg/extension/project_audit.go @@ -102,9 +102,10 @@ type ProjectAuditPublisher interface { // ProjectAuditQuery reads one project-bound command-audit slice. Offset is a // host source offset, not a cross-domain event sequence. A nonzero BeforeOffset -// must be paired with the CutoffOffset returned on the first page. On PostgreSQL -// that cutoff bounds offsets but is not a fixed visibility snapshot: a lower ID -// from a still-open transaction may commit later. See Coverage.CutoffConsistency. +// must be paired with the CutoffOffset returned on the first page. PostgreSQL +// pages are served only while the installed generator and sequence prove a +// committed prefix; otherwise the host rejects the read instead of claiming a +// fixed snapshot. See Coverage.CutoffConsistency. type ProjectAuditQuery struct { ProjectID core.ID `json:"projectId"` BeforeOffset int64 `json:"beforeOffset,omitempty"` -- 2.54.0 From d8129abead96be7c35ab2650e949ac817745e786 Mon Sep 17 00:00:00 2001 From: weichen Date: Wed, 14 Oct 2026 05:48:41 +0000 Subject: [PATCH 11/41] Persist candidate scope scrub state across restarts Why: A crash after dropping candidate raw prompt columns but before SQLite compaction left physical prompt bytes without a visible reason to retry, and storage backup could accept that file. Evidence: RED post-commit interruption and pending-backup tests; full Go suite, targeted race, isolated PostgreSQL package tests, vet, and build passed locally before commit. Impact: Commit a durable pending marker with v35, retry compaction and WAL truncation until completion, conservatively re-scrub earlier v35 candidates, and reject backup or migration while cleanup is pending or unverified. Refs: Approved RDM stage6 W6 source-recheck design adjustment r1; W6 independent review crash-window finding. --- cmd/storage-migrate/main.go | 15 +++++ cmd/storage-migrate/main_test.go | 58 +++++++++++++++- internal/store/context_manifest_test.go | 89 +++++++++++++++++++++++++ internal/store/migrate.go | 70 +++++++++++++++---- 4 files changed, 218 insertions(+), 14 deletions(-) diff --git a/cmd/storage-migrate/main.go b/cmd/storage-migrate/main.go index 93d9463..3a60187 100644 --- a/cmd/storage-migrate/main.go +++ b/cmd/storage-migrate/main.go @@ -430,6 +430,21 @@ func refuseCandidateRawContextScope(db *sql.DB) error { if columns > 0 { return fmt.Errorf("candidate context scope text columns remain; isolate and scrub source before backup or migration") } + var version int + if sqliteHasTable(db, "schema_migrations") { + if err := db.QueryRow(`SELECT COALESCE(MAX(version),0) FROM schema_migrations`).Scan(&version); err != nil { + return err + } + } + if version >= 34 { + if !sqliteHasTable(db, "context_scope_scrub_state") { + return fmt.Errorf("candidate context physical scrub marker missing; isolate and scrub source before backup or migration") + } + var pending int + if err := db.QueryRow(`SELECT pending FROM context_scope_scrub_state WHERE id=1`).Scan(&pending); err != nil || pending != 0 { + return fmt.Errorf("candidate context physical scrub pending or unverified; isolate and scrub source before backup or migration") + } + } return nil } diff --git a/cmd/storage-migrate/main_test.go b/cmd/storage-migrate/main_test.go index 24b9170..de09be6 100644 --- a/cmd/storage-migrate/main_test.go +++ b/cmd/storage-migrate/main_test.go @@ -173,7 +173,8 @@ func TestCopyOrderCoversAllFixtureTables(t *testing.T) { for _, t := range copyOrder { known[t] = true } - known["schema_migrations"] = true // 迁移器管理，不随迁 + known["schema_migrations"] = true // 迁移器管理，不随迁 + known["context_scope_scrub_state"] = true // SQLite 候选原文物理清理状态，不随迁 // 运行态表不随迁：执行许可是进程瞬态；执行租约与跨实例命令属当前 // 实例的调度现场（接管语义在 U5 内由 lease/fencing 处理，不复制历史）。 for _, rt := range []string{"admission_leases", "conversation_executions", "run_commands"} { @@ -248,3 +249,58 @@ func TestBackupAndMigrateRejectCandidateRawContextScope(t *testing.T) { t.Fatal("backup retained candidate raw scope body") } } + +func TestBackupAndMigrateRejectPendingOrMissingContextScrubMarker(t *testing.T) { + path := buildFixture(t) + db, err := sql.Open("sqlite", path) + if err != nil { + t.Fatal(err) + } + for _, query := range []string{ + `CREATE TABLE IF NOT EXISTS context_scope_scrub_state(id INTEGER PRIMARY KEY,pending INTEGER NOT NULL)`, + `INSERT OR REPLACE INTO context_scope_scrub_state(id,pending) VALUES(1,1)`, + } { + if _, err := db.Exec(query); err != nil { + t.Fatal(err) + } + } + if err := db.Close(); err != nil { + t.Fatal(err) + } + assertRejected := func(name string) { + t.Helper() + out := filepath.Join(t.TempDir(), name+".db") + if err := cmdBackup([]string{"--source", path, "--out", out}); err == nil { + t.Fatalf("backup accepted %s context scrub state", name) + } + if _, err := os.Stat(out); !os.IsNotExist(err) { + t.Fatalf("rejected %s backup created output: %v", name, err) + } + if err := cmdMigrate([]string{"--source", path, "--target", "postgres://invalid", "--migration-id", name}); err == nil { + t.Fatalf("migration accepted %s context scrub state", name) + } + } + assertRejected("pending") + db, err = sql.Open("sqlite", path) + if err != nil { + t.Fatal(err) + } + if _, err := db.Exec(`DROP TABLE context_scope_scrub_state`); err != nil { + t.Fatal(err) + } + if err := db.Close(); err != nil { + t.Fatal(err) + } + assertRejected("missing") + db, err = sql.Open("sqlite", path) + if err != nil { + t.Fatal(err) + } + if _, err := db.Exec(`DELETE FROM schema_migrations WHERE version=35`); err != nil { + t.Fatal(err) + } + if err := db.Close(); err != nil { + t.Fatal(err) + } + assertRejected("v34-missing") +} diff --git a/internal/store/context_manifest_test.go b/internal/store/context_manifest_test.go index 2259897..2200a42 100644 --- a/internal/store/context_manifest_test.go +++ b/internal/store/context_manifest_test.go @@ -128,6 +128,95 @@ func TestCandidateV34RawScopeColumnsAreScrubbedOnUpgrade(t *testing.T) { } } +func TestCandidateV34CommittedDropKeepsPendingScrubAcrossRestart(t *testing.T) { + path := filepath.Join(t.TempDir(), "candidate-crash.db") + st, err := OpenSQLite(path) + if err != nil { + t.Fatal(err) + } + m := extension.ProjectContextManifest{ProjectID: "p1", AttemptID: "crash-model", InputSHA256: "input", Delivery: "attempted"} + if err := st.AppendContextManifestWithScope("alice", "run-1", m, ContextManifestScope{Bound: true}); err != nil { + t.Fatal(err) + } + for _, query := range []string{ + `DELETE FROM schema_migrations WHERE version=35`, + `ALTER TABLE context_manifests ADD COLUMN resolve_goal TEXT NOT NULL DEFAULT ''`, + `ALTER TABLE context_manifests ADD COLUMN resolve_target_id TEXT NOT NULL DEFAULT ''`, + `UPDATE context_manifests SET resolve_goal='OLD_RESTRICTED_BODY',resolve_target_id='doc-private'`, + } { + if _, err := st.db.Exec(query); err != nil { + t.Fatal(err) + } + } + // Apply only the transactional DDL and ledger. A process crash at this + // boundary must not make the next open mistake the file for scrubbed. + if err := st.migratePass(); err != nil { + t.Fatal(err) + } + var pending int + if err := st.db.QueryRow(`SELECT pending FROM context_scope_scrub_state WHERE id=1`).Scan(&pending); err != nil || pending != 1 { + t.Fatalf("committed v35 lost physical scrub obligation: pending=%d err=%v", pending, err) + } + if err := st.Close(); err != nil { + t.Fatal(err) + } + restarted, err := OpenSQLite(path) + if err != nil { + t.Fatal(err) + } + defer restarted.Close() + if err := restarted.db.QueryRow(`SELECT pending FROM context_scope_scrub_state WHERE id=1`).Scan(&pending); err != nil || pending != 0 { + t.Fatalf("restart did not complete pending scrub: pending=%d err=%v", pending, err) + } + for _, suffix := range []string{"", "-wal"} { + data, err := os.ReadFile(path + suffix) + if err == nil && bytes.Contains(data, []byte("OLD_RESTRICTED_BODY")) { + t.Fatalf("restart left candidate raw bytes in SQLite %s", suffix) + } + } +} + +func TestEarlierV35WithoutMarkerIsConservativelyRescrubbed(t *testing.T) { + path := filepath.Join(t.TempDir(), "old-v35.db") + st, err := OpenSQLite(path) + if err != nil { + t.Fatal(err) + } + m := extension.ProjectContextManifest{ProjectID: "p1", AttemptID: "old-v35-model", InputSHA256: "input", Delivery: "attempted"} + if err := st.AppendContextManifestWithScope("alice", "run-1", m, ContextManifestScope{Bound: true}); err != nil { + t.Fatal(err) + } + for _, query := range []string{ + `ALTER TABLE context_manifests ADD COLUMN resolve_goal TEXT NOT NULL DEFAULT ''`, + `UPDATE context_manifests SET resolve_goal='OLD_RESTRICTED_BODY'`, + `UPDATE context_manifests SET resolve_goal=''`, + `ALTER TABLE context_manifests DROP COLUMN resolve_goal`, + `DROP TABLE context_scope_scrub_state`, + } { + if _, err := st.db.Exec(query); err != nil { + t.Fatal(err) + } + } + if err := st.Close(); err != nil { + t.Fatal(err) + } + restarted, err := OpenSQLite(path) + if err != nil { + t.Fatal(err) + } + defer restarted.Close() + var pending int + if err := restarted.db.QueryRow(`SELECT pending FROM context_scope_scrub_state WHERE id=1`).Scan(&pending); err != nil || pending != 0 { + t.Fatalf("earlier v35 without marker was not re-scrubbed: pending=%d err=%v", pending, err) + } + for _, suffix := range []string{"", "-wal"} { + data, err := os.ReadFile(path + suffix) + if err == nil && bytes.Contains(data, []byte("OLD_RESTRICTED_BODY")) { + t.Fatalf("old v35 raw bytes survived re-scrub in SQLite %s", suffix) + } + } +} + func TestCandidateV34PostgresRawScopeScrubAndFreshSchema(t *testing.T) { st := openTestStore(t) if st.Dialect() != "postgres" { diff --git a/internal/store/migrate.go b/internal/store/migrate.go index b9bb9af..5ca9f0d 100644 --- a/internal/store/migrate.go +++ b/internal/store/migrate.go @@ -881,8 +881,11 @@ func init() { }, }, migration{version: 35, name: "scrub_candidate_context_scope_text", - up: map[string][]string{"sqlite": {`SELECT 1`}, "postgres": {`SELECT 1`}}, - down: map[string][]string{"sqlite": {`SELECT 1`}, "postgres": {`SELECT 1`}}, + up: map[string][]string{ + "sqlite": {`CREATE TABLE IF NOT EXISTS context_scope_scrub_state(id INTEGER PRIMARY KEY CHECK(id=1),pending INTEGER NOT NULL CHECK(pending IN (0,1)))`}, + "postgres": {`SELECT 1`}, + }, + down: map[string][]string{"sqlite": {`DROP TABLE IF EXISTS context_scope_scrub_state`}, "postgres": {`SELECT 1`}}, }, ) } @@ -976,17 +979,17 @@ func (s *Store) migrate() error { if s.dialect.name() == "postgres" { return s.migratePG() } - var candidateRawColumns int - if err := s.db.QueryRow(`SELECT COUNT(*) FROM pragma_table_info('context_manifests') WHERE name IN ('resolve_goal','resolve_target_id')`).Scan(&candidateRawColumns); err != nil { - return err - } // SQLite：_txlock=immediate（OpenSQLite DSN）保证迁移事务在 BEGIN 即取写锁， // 跨进程迁移者按 busy_timeout 排队；后续版本读取发生在同一事务内， // 前一个迁移者提交后本进程看到的已是完整账本（无部分版本可见）。 if err := s.migratePass(); err != nil { return err } - if candidateRawColumns > 0 { + pending, err := s.ensureContextScrubState() + if err != nil { + return err + } + if pending { // The prior candidate schema may have stored full prompts. VACUUM is // outside the DDL transaction; it compacts the isolated SQLite file // after v35 drops those columns. Refuse to serve if compaction fails. @@ -1003,10 +1006,38 @@ func (s *Store) migrate() error { if busy != 0 { return errors.New("candidate context scrub checkpoint remains busy") } + if _, err := s.db.Exec(`UPDATE context_scope_scrub_state SET pending=0 WHERE id=1 AND pending=1`); err != nil { + return fmt.Errorf("candidate context scrub completion: %w", err) + } } return nil } +// ensureContextScrubState handles databases that ran the earlier candidate +// v35 before a durable marker existed. They are conservatively re-scrubbed. +func (s *Store) ensureContextScrubState() (bool, error) { + var rawColumns int + if err := s.db.QueryRow(`SELECT COUNT(*) FROM pragma_table_info('context_manifests') WHERE name IN ('resolve_goal','resolve_target_id')`).Scan(&rawColumns); err != nil { + return false, err + } + if rawColumns != 0 { + return false, errors.New("candidate context raw scope columns remain after migration") + } + if _, err := s.db.Exec(`CREATE TABLE IF NOT EXISTS context_scope_scrub_state(id INTEGER PRIMARY KEY CHECK(id=1),pending INTEGER NOT NULL CHECK(pending IN (0,1)))`); err != nil { + return false, err + } + // An absent row may be a partially initialized earlier candidate; mark it + // pending before any physical cleanup. A fresh v35 inserted pending=0. + if _, err := s.db.Exec(`INSERT OR IGNORE INTO context_scope_scrub_state(id,pending) VALUES(1,1)`); err != nil { + return false, err + } + var pending int + if err := s.db.QueryRow(`SELECT pending FROM context_scope_scrub_state WHERE id=1`).Scan(&pending); err != nil { + return false, err + } + return pending != 0, nil +} + // migratePG 以会话级咨询锁串行化并发迁移者（KTD8）：锁在专用连接上获取， // 等锁者在轮到自己后重新读取账本——前一个迁移者已完成时本轮为空操作。 // 锁与迁移事务分离：迁移语句走连接池，锁只负责让 migrator 全局互斥。 @@ -1082,8 +1113,10 @@ func (s *Store) migratePass() error { if applied[m.version] { continue } + candidateRawScope := false if m.version == 35 { - if err := scrubCandidateContextScope(tx, s.dialect.name()); err != nil { + candidateRawScope, err = scrubCandidateContextScope(tx, s.dialect.name()) + if err != nil { return fmt.Errorf("migrate v35: %w", err) } } @@ -1096,6 +1129,15 @@ func (s *Store) migratePass() error { return fmt.Errorf("migrate v%d (%s): %w", m.version, m.name, err) } } + if m.version == 35 && s.dialect.name() == "sqlite" { + pending := 0 + if candidateRawScope { + pending = 1 + } + if _, err := tx.Exec(`INSERT OR REPLACE INTO context_scope_scrub_state(id,pending) VALUES(1,?)`, pending); err != nil { + return fmt.Errorf("migrate v35 scrub marker: %w", err) + } + } // 故障注入点：DDL 已执行、版本未登记——历史实现在此处崩溃会留下 // 「DDL 生效而账本缺失」的中间态；同事务设计下这里失败必须整体回滚。 if fault := s.takeMigrateFault(); fault != nil { @@ -1111,7 +1153,8 @@ func (s *Store) migratePass() error { // Candidate v34 was never released, but isolated test databases may already // contain raw Resolve goals. Fresh v34 creates no such columns; v35 removes // them conditionally from the earlier candidate schema before serving. -func scrubCandidateContextScope(tx *sql.Tx, dialect string) error { +func scrubCandidateContextScope(tx *sql.Tx, dialect string) (bool, error) { + found := false for _, column := range []string{"resolve_goal", "resolve_target_id"} { var exists int var err error @@ -1121,19 +1164,20 @@ func scrubCandidateContextScope(tx *sql.Tx, dialect string) error { err = tx.QueryRow(`SELECT COUNT(*) FROM information_schema.columns WHERE table_schema=current_schema() AND table_name='context_manifests' AND column_name=$1`, column).Scan(&exists) } if err != nil { - return err + return false, err } if exists == 0 { continue } + found = true if _, err := tx.Exec(`UPDATE context_manifests SET ` + column + `=''`); err != nil { - return err + return false, err } if _, err := tx.Exec(`ALTER TABLE context_manifests DROP COLUMN ` + column); err != nil { - return err + return false, err } } - return nil + return found, nil } func latestMigrationVersion() int { -- 2.54.0 From 130ac344aaba988026fbc497c9548cdb59f5774f Mon Sep 17 00:00:00 2001 From: weichen Date: Wed, 14 Oct 2026 06:15:01 +0000 Subject: [PATCH 12/41] Guard every PostgreSQL command audit write Why: Explicit low IDs bypassed the implicit sequence allocator and could commit after a higher audit page cutoff. Evidence: Isolated PostgreSQL RED receipt for cross-page omission; local GREEN for explicit and default writes, trigger drift, isolation, mutation denial, offline copy rollback, retry, and sequence non-rewind. Fixed-HEAD receipts follow. Impact: Add v34 all-writer and append-only guards; reject unsafe strong reads; make command audit storage migration exclusive and atomic with guard restoration and a forward-only sequence. Refs: Approved W9 all-writers cutoff adjustment r1; W9 Backend task card. --- .task/feature-rdm-two-trees-project-audit.md | 8 +- cmd/storage-migrate/integration_test.go | 99 +++++++++++++ cmd/storage-migrate/main.go | 103 ++++++++++++- internal/app/project_audit_test.go | 137 ++++++++++++++++++ internal/store/audit.go | 5 +- internal/store/migrate.go | 78 ++++++++++ internal/store/migrate_compat.go | 1 + internal/store/project_audit_sequence_test.go | 114 ++++++++++++++- pkg/extension/extension.go | 4 +- pkg/extension/project_audit.go | 3 +- 10 files changed, 537 insertions(+), 15 deletions(-) diff --git a/.task/feature-rdm-two-trees-project-audit.md b/.task/feature-rdm-two-trees-project-audit.md index 6eb2de3..04598fb 100644 --- a/.task/feature-rdm-two-trees-project-audit.md +++ b/.task/feature-rdm-two-trees-project-audit.md @@ -6,6 +6,7 @@ - Startup receipt: `/tmp/backend-w9-precheck-20261014-01.json` (SELF, exit 2, `SYNC_REQUIRED` for the separate Dev checkout `feature/rdm-increment-acceptance-note`, six commits behind Dev `origin/main`). This Backend task uses the independent-development path in Backend `AGENTS.md`; it does not write that Dev checkout or its task card. The receipt is preserved as a failure, not relabeled READY. - Approved affected design: `rdm-two-trees-stage6-audit-link-design-adjustment-r1.md`, SHA256 `385d9d7570217ddcce9fe60a60c99dc58c9a4875ad790584a724d09a210a6e52`; user approval in the task session covers this local Backend increment, not tag publication or Stage 7 acceptance. - Approved PostgreSQL cutoff adjustment: `rdm-two-trees-stage6-w9-pg-audit-cutoff-adjustment-r1.md`, SHA256 `2357b715a7c8f3451b34cc25a578d655e8a48f3f26d9cf7561ea7a13998ca857`; scope is isolated Backend implementation/testing, with no real database migration or release authorization. +- Approved all-writers affected design: `rdm-two-trees-stage6-w9-all-writers-cutoff-adjustment-r1.md`, SHA256 `44f6f7cd34bf95a9c1eb844bfdd70a5c2233e1b5ffc89b3091359dcb5fc3b5d8`; the direct user approval allows the local v34 correction and isolated tests only. ## Implemented local slice @@ -17,7 +18,9 @@ - Independent review of `a8fa2fe` found two P2 security defects: clock-based operation IDs could collide; and `NewScopedHost(owner,"rdm")` let another compiled plugin self-report the publisher's plugin ID. The new local increment uses 192 bits from `crypto/rand` for each host-generated operation ID. Both zero-offset and explicit-offset publication require a unique committed row for owner/project/operation; a historical duplicate rejects publication, including attempts to link another private command. Verifier registration returns a private `ProjectAuditPublisherFactory` for the registering plugin's background outbox; a generic scoped Host has no publisher method. Fixed-clock concurrent IDs, forged params, ambiguous private offset, forged scoped Host, and legitimate registered publisher each have focused tests. - The minted publisher exposes only `ProjectAuditPublisher`, not the full owner-scoped `Host`; tests reject attempts to use `NewScopedHost` with a self-reported `rdm` string as publisher authority. A publisher is a registration-time capability, while `IdempotencyKey` remains the separate retry identity. - Exact-source linked reads do not enumerate hidden links or reveal raw payload, private conversation ID, or content. Body disclosure and a broad project link list are not implemented; the public coverage reports the narrower capability. -- A PostgreSQL-only v33 default function now takes a table-specific transaction advisory lock before assigning `command_audit.id`, making supported implicit-ID writes commit in source-offset order. Migration and each PG append/project page verify CACHE 1, ascending non-cyclic positive IDs, the exact guarded default expression, and the next ID above the committed maximum; unsafe drift fails closed. SQLite remains single-writer. The owner-only project page reports `committed-prefix` only after the runtime check. Explicit online IDs and sequence maintenance remain prohibited; offline `storage-migrate` advances the owned sequence after copying IDs. +- A PostgreSQL-only v33 default function takes a table-specific transaction advisory lock before assigning `command_audit.id`, making supported implicit-ID writes commit in source-offset order. Migration and each PG append/project page verify CACHE 1, ascending non-cyclic positive IDs, the exact guarded default expression, and the next ID above the committed maximum; unsafe drift fails closed. SQLite remains single-writer. The owner-only project page reports `committed-prefix` only after runtime checks. v34 below closes the explicit-ID bypass; online sequence maintenance remains prohibited. +- Isolated PG RED receipt `/tmp/backend-w9-explicit-low-red-20261014-01.json` proved v33 still misreported `committed-prefix`: explicit ID 3 committed after normal ID 4 and disappeared across pages. Local v34 adds `ENABLE ALWAYS` insert and append-only mutation triggers. Every online INSERT checks READ COMMITTED, obtains the same transaction lock, and rejects a nonpositive, nonmonotone, or beyond-reserved ID. UPDATE/DELETE reject. PG append and every strong project page verify both trigger identities, exact event shape, and enablement; the existing default allocator also checks this guard. This is a local candidate, not yet independently reviewed or deployed. +- `storage-migrate` now copies `command_audit` within one ACCESS EXCLUSIVE transaction: it disables only the named insert guard, copies explicit IDs, verifies count and checksum, advances the owned sequence only forward, restores and verifies the guard, and records done before commit. Failure rolls back table data, trigger state, and done; nontransactional `setval` may leave a safe forward gap. Idempotent done checks guard health before reporting success. Other tables retain their existing path. ## Verification and remaining work @@ -31,5 +34,6 @@ - Historical pre-commit SELF load receipt `/tmp/backend-w9-pg-load-precommit-20261014-01.json` captured an initial v33 variant whose unlocked status function later produced false `cutoff unsafe` errors under concurrency; it is **not** valid performance acceptance evidence. The corrected status check reads committed MAX before non-MVCC sequence state and does not lock readers; the default ID allocator alone holds the transaction advisory lock and rechecks after `nextval`. `TestProjectAuditConcurrentReadWriteNeverReportsFalseDrift` and repeated PG load/cross-page runs protect that ordering. Three-condition pre-commit SELF raw receipts: `/tmp/backend-w9-pg-load-readlock-precommit-20261014-01.json` uses a test-only locked status wrapper, while `/tmp/backend-w9-pg-load-unlocked2-precommit-20261014-01.json` uses the final MAX-first unlocked status; each run also logs its v32 direct-INSERT baseline, PostgreSQL 18.6 version, 192 writes per mode/8 workers, elapsed time, p95, and throughput. The wrapper adds overhead and all measurements vary with hardware/load; no performance threshold has been approved, so they are Stage 6 cost evidence only. - Pre-commit SELF `/tmp/backend-w9-default-drift-red-20261014-01.json` showed that a replacement default containing the guarded function name but executing unguarded `nextval` was accepted; `/tmp/backend-w9-default-drift-green-20261014-01.json` verifies exact-expression rejection. Pre-commit SELF `/tmp/backend-w9-precommit-all-20261014-02.json` and `/tmp/backend-w9-precommit-pg-20261014-02.json` passed before this last guard tightening; fixed-HEAD runs are required below. - After the guard tightening, pre-commit SELF receipts `/tmp/backend-w9-precommit-all-final-20261014-01.json` (`go test ./... -count=1`), `/tmp/backend-w9-precommit-pg-final-20261014-01.json` (isolated PG store/storage-migrate), and `/tmp/backend-w9-precommit-pg-race-20261014-01.json` (cross-page/concurrent read-write with race detector) all exited 0. These still identify the dirty pre-commit tree, so they do not replace fixed-HEAD verification. -- Integration constraint: this branch uses schema v31 (audit attribution), v32 (links), and v33 (PG cutoff), while the independent W6 Backend branch also has a local v31. Neither branch has consumed the other's unmerged work. After the first branch lands, the later branch owner must sync the new main, renumber its unpublished migrations without rewriting an already released version, and rerun fresh/old SQLite and PG migration plus combined regression on the actual merged source. These isolated tests do not prove W6+W9 compatibility. +- v34 pre-commit SELF `/tmp/backend-w9-allwriters-load-precommit-20261014-01.json` records isolated PostgreSQL 18.6, three runs of 192 writes per mode with 8 workers, comparing v32 direct INSERT with v34 guarded `Store.AppendAudit`; it also logs three mixed runs of 180 writes with 6 writers and 160 200-row pages with 4 readers. Protected write throughput ranged about 2.7–3.0k/s, write p95 6.4–6.6ms, and mixed large-page p95 1.2–1.9ms on this one host. These are SELF cost signals with no approved threshold and no Stage 7 acceptance meaning; fixed-HEAD tests still follow. +- Integration constraint: this branch uses schema v31 (audit attribution), v32 (links), v33 (PG implicit cutoff), and v34 (all-writer guard), while the independent W6 Backend branch also has a local v31. Neither branch has consumed the other's unmerged work. After the first branch lands, the later branch owner must sync the new main, renumber its unpublished migrations without rewriting an already released version, and rerun fresh/old SQLite and PG migration plus combined regression on the actual merged source. These isolated tests do not prove W6+W9 compatibility. - Required next W9 work: real RDM committed-event verifier/outbox consumer, Backend project-event source, run ID propagation, model/tool/background receipts, body/detail disclosure, broad authorized linked-operation pagination, history/export, and combined product verification remain unfinished. A domain commit followed by a lost Backend audit append leaves the link pending; recovery must retain and reconcile that unknown state without claiming a host receipt. Exact-link and owner-only paging do not satisfy Stage 7 audit acceptance. PostgreSQL v33 adds a global command-audit append lock; its measured wait/throughput cost has no approved performance threshold and needs human Stage 6 review. diff --git a/cmd/storage-migrate/integration_test.go b/cmd/storage-migrate/integration_test.go index 57cb9f0..7df23a7 100644 --- a/cmd/storage-migrate/integration_test.go +++ b/cmd/storage-migrate/integration_test.go @@ -101,6 +101,105 @@ func TestMigrateEndToEndAndIdempotent(t *testing.T) { } } +func TestCommandAuditExclusiveCopyRollsBackAndNeverRewindsSequence(t *testing.T) { + target, cleanup := pgSchemaDSN(t) + defer cleanup() + fixture := buildFixture(t) + src, err := openSourceRO(fixture) + if err != nil { + t.Fatal(err) + } + defer src.Close() + st, err := store.OpenPostgres(target, filepath.Join(t.TempDir(), "artifacts")) + if err != nil { + t.Fatal(err) + } + defer st.Close() + db := st.DB() + if _, err := db.Exec(controlDDL); err != nil { + t.Fatal(err) + } + cols, pk, err := targetColumns(db, "command_audit") + if err != nil { + t.Fatal(err) + } + bools, err := boolColumns(db, "command_audit", cols) + if err != nil { + t.Fatal(err) + } + count, checksum, err := sourceScan(src, "command_audit", cols, pk, bools) + if err != nil { + t.Fatal(err) + } + blocker, err := db.Begin() + if err != nil { + t.Fatal(err) + } + var existing int + if err := blocker.QueryRow(`SELECT COUNT(*) FROM command_audit`).Scan(&existing); err != nil { + t.Fatal(err) + } + timeoutDB, err := sql.Open("pgx", store.AppendPGRuntimeParam(target, "lock_timeout", "100")) + if err != nil { + t.Fatal(err) + } + if _, err := migrateCommandAudit(timeoutDB, src, "retry-audit", cols, pk, bools, count, checksum); err == nil || !strings.Contains(err.Error(), "lock timeout") { + t.Fatalf("exclusive copy did not fail on a held reader: %v", err) + } + timeoutDB.Close() + if err := blocker.Rollback(); err != nil { + t.Fatal(err) + } + if _, err := migrateCommandAudit(db, src, "retry-audit", cols, pk, bools, count+1, checksum); err == nil { + t.Fatal("mismatched copy committed despite in-transaction target count check") + } + var rows, done int + if err := db.QueryRow(`SELECT COUNT(*) FROM command_audit`).Scan(&rows); err != nil || rows != 0 { + t.Fatalf("failed copy left rows: %d %v", rows, err) + } + if err := db.QueryRow(`SELECT COUNT(*) FROM migration_table_state WHERE table_name='command_audit'`).Scan(&done); err != nil || done != 0 { + t.Fatalf("failed copy recorded done: %d %v", done, err) + } + var enabled string + if err := db.QueryRow(`SELECT tgenabled FROM pg_trigger WHERE tgrelid='command_audit'::regclass AND tgname='project_audit_insert_guard_v1'`).Scan(&enabled); err != nil || enabled != "A" { + t.Fatalf("failed copy left guard disabled: %q %v", enabled, err) + } + var seq string + if err := db.QueryRow(`SELECT pg_get_serial_sequence('command_audit','id')`).Scan(&seq); err != nil { + t.Fatal(err) + } + // setval is non-transactional; an interrupted offline attempt can leave a + // forward gap even though its rows and trigger-state changes roll back. + tx, err := db.Begin() + if err != nil { + t.Fatal(err) + } + if _, err := tx.Exec(`LOCK TABLE command_audit IN ACCESS EXCLUSIVE MODE`); err != nil { + t.Fatal(err) + } + if _, err := tx.Exec(`ALTER TABLE command_audit DISABLE TRIGGER project_audit_insert_guard_v1`); err != nil { + t.Fatal(err) + } + if _, err := tx.Exec(`SELECT setval($1::regclass,50,true)`, seq); err != nil { + t.Fatal(err) + } + if err := tx.Rollback(); err != nil { + t.Fatal(err) + } + if _, err := migrateCommandAudit(db, src, "retry-audit", cols, pk, bools, count, checksum); err != nil { + t.Fatalf("retry after rollback: %v", err) + } + var last int64 + if err := db.QueryRow(`SELECT last_value FROM ` + seq).Scan(&last); err != nil || last < 50 { + t.Fatalf("copy rewound sequence: last=%d err=%v", last, err) + } + var nextID int64 + if err := db.QueryRow(`INSERT INTO command_audit(time,command_id,source,entrance,state,operation_id,conversation_id,owner,payload) + VALUES ('2026-10-14T00:00:00Z','after-copy','','','committed','','','alice','{}') RETURNING id`).Scan(&nextID); err != nil || nextID <= 50 { + t.Fatalf("post-copy ID did not advance: id=%d err=%v", nextID, err) + } +} + func TestMigrateResumeAfterInterrupt(t *testing.T) { target, cleanup := pgSchemaDSN(t) defer cleanup() diff --git a/cmd/storage-migrate/main.go b/cmd/storage-migrate/main.go index 3a4f366..65b571c 100644 --- a/cmd/storage-migrate/main.go +++ b/cmd/storage-migrate/main.go @@ -508,9 +508,18 @@ func migrateTable(db *sql.DB, src *sql.DB, migrationID, table string) (map[strin if countNow != srcCount || sumNow != srcChecksum { return nil, fmt.Errorf("源与登记不符（疑似换快照）：count %d/%d checksum %s…/%s…", countNow, srcCount, sumNow[:12], srcChecksum[:12]) } + if table == "command_audit" { + var guarded bool + if err := db.QueryRow(`SELECT project_audit_cutoff_safe('command_audit'::regclass) AND project_audit_writers_guarded('command_audit'::regclass)`).Scan(&guarded); err != nil || !guarded { + return nil, fmt.Errorf("command_audit idempotent guard is unsafe: safe=%v err=%v", guarded, err) + } + } entry := map[string]any{"table": table, "source_count": countNow, "target_count": dstCountStored, "checksum": sumNow, "state": "done(idempotent)"} return entry, nil } + if table == "command_audit" { + return migrateCommandAudit(db, src, migrationID, cols, pk, bools, countNow, sumNow) + } if err := copyRows(db, src, table, cols); err != nil { return nil, err } @@ -663,7 +672,11 @@ func sourceScan(src *sql.DB, table string, cols, pk []string, bools map[string]b return scanChecksum(rows, cols, bools) } -func targetScan(db *sql.DB, table string, cols, pk []string, bools map[string]bool) (int64, string, error) { +type rowsQuerier interface { + Query(string, ...any) (*sql.Rows, error) +} + +func targetScan(db rowsQuerier, table string, cols, pk []string, bools map[string]bool) (int64, string, error) { rows, err := db.Query(`SELECT ` + quoteJoin(cols, `"`) + ` FROM "` + table + `" ORDER BY ` + quoteJoin(pk, `"`)) if err != nil { return 0, "", err @@ -686,6 +699,18 @@ func copyRows(db *sql.DB, src *sql.DB, table string, cols []string) error { if err != nil { return err } + tx, err := db.Begin() + if err != nil { + return err + } + defer tx.Rollback() + if err := copyRowsInTx(tx, src, table, cols, bools); err != nil { + return err + } + return tx.Commit() +} + +func copyRowsInTx(tx *sql.Tx, src *sql.DB, table string, cols []string, bools map[string]bool) error { colList := quoteJoin(cols, `"`) ph := make([]string, len(cols)) for i := range ph { @@ -702,11 +727,6 @@ func copyRows(db *sql.DB, src *sql.DB, table string, cols []string) error { for i := range vals { ptrs[i] = &vals[i] } - tx, err := db.Begin() - if err != nil { - return err - } - defer tx.Rollback() stmt, err := tx.Prepare(fmt.Sprintf(`INSERT INTO "%s" (%s) VALUES (%s) ON CONFLICT DO NOTHING`, table, colList, placeholders)) if err != nil { return err @@ -734,7 +754,76 @@ func copyRows(db *sql.DB, src *sql.DB, table string, cols []string) error { if err := srcRows.Err(); err != nil { return err } - return tx.Commit() + return nil +} + +// command_audit alone needs an offline transaction: explicit source IDs do not +// pass the online monotone guard, and disabling it must never become visible +// separately from the copied rows, sequence advance, or done marker. +func migrateCommandAudit(db *sql.DB, src *sql.DB, migrationID string, cols, pk []string, bools map[string]bool, sourceCount int64, sourceChecksum string) (map[string]any, error) { + tx, err := db.Begin() + if err != nil { + return nil, err + } + defer tx.Rollback() + if _, err := tx.Exec(`LOCK TABLE command_audit IN ACCESS EXCLUSIVE MODE`); err != nil { + return nil, err + } + if _, err := tx.Exec(`ALTER TABLE command_audit DISABLE TRIGGER project_audit_insert_guard_v1`); err != nil { + return nil, err + } + if err := copyRowsInTx(tx, src, "command_audit", cols, bools); err != nil { + return nil, err + } + targetCount, targetChecksum, err := targetScan(tx, "command_audit", cols, pk, bools) + if err != nil { + return nil, err + } + if targetCount != sourceCount || targetChecksum != sourceChecksum { + return nil, fmt.Errorf("command_audit copy mismatch: count %d/%d checksum %s/%s", targetCount, sourceCount, targetChecksum, sourceChecksum) + } + if err := advanceCommandAuditSequence(tx); err != nil { + return nil, err + } + if _, err := tx.Exec(`ALTER TABLE command_audit ENABLE ALWAYS TRIGGER project_audit_insert_guard_v1`); err != nil { + return nil, err + } + var guarded bool + if err := tx.QueryRow(`SELECT project_audit_cutoff_safe('command_audit'::regclass) AND project_audit_writers_guarded('command_audit'::regclass)`).Scan(&guarded); err != nil || !guarded { + return nil, fmt.Errorf("command_audit guard not restored: safe=%v err=%v", guarded, err) + } + if _, err := tx.Exec(`INSERT INTO migration_table_state (migration_id, table_name, source_count, target_count, checksum, state, finished_at) + VALUES ($1,'command_audit',$2,$3,$4,'done',$5) + ON CONFLICT(migration_id, table_name) DO UPDATE SET source_count=excluded.source_count, target_count=excluded.target_count, checksum=excluded.checksum, state=excluded.state, finished_at=excluded.finished_at`, + migrationID, sourceCount, targetCount, sourceChecksum, nowISO()); err != nil { + return nil, err + } + if err := tx.Commit(); err != nil { + return nil, err + } + return map[string]any{"table": "command_audit", "source_count": sourceCount, "target_count": targetCount, "checksum": sourceChecksum, "state": "done"}, nil +} + +func advanceCommandAuditSequence(tx *sql.Tx) error { + var seq string + if err := tx.QueryRow(`SELECT pg_get_serial_sequence('command_audit','id')`).Scan(&seq); err != nil || seq == "" { + return fmt.Errorf("command_audit sequence missing: %v", err) + } + var last int64 + var called bool + if err := tx.QueryRow(fmt.Sprintf(`SELECT last_value,is_called FROM %s`, seq)).Scan(&last, &called); err != nil { + return err + } + var maxID sql.NullInt64 + if err := tx.QueryRow(`SELECT MAX(id) FROM command_audit`).Scan(&maxID); err != nil { + return err + } + if maxID.Valid && (maxID.Int64 > last || (maxID.Int64 == last && !called)) { + if _, err := tx.Exec(`SELECT setval($1::regclass,$2,true)`, seq, maxID.Int64); err != nil { + return err + } + } + return nil } func sqliteBool(v any) bool { diff --git a/internal/app/project_audit_test.go b/internal/app/project_audit_test.go index 3640da9..7bda52b 100644 --- a/internal/app/project_audit_test.go +++ b/internal/app/project_audit_test.go @@ -2,8 +2,10 @@ package app import ( "context" + "database/sql" "encoding/json" "errors" + "os" "path/filepath" "strings" "testing" @@ -99,3 +101,138 @@ func TestProjectAuditHostChecksDomainReadAndProjectsStoredReceipts(t *testing.T) t.Fatalf("revoked audit.read: %v", err) } } + +// A direct explicit ID bypasses the v33 default allocator. This must never +// yield a committed-prefix page that permanently skips the late lower row. +func TestProjectAuditPostgresExplicitLowIDCannotHideAcrossPages(t *testing.T) { + dsn := os.Getenv("AGENT_PG_TEST_DSN") + if dsn == "" { + t.Skip("AGENT_PG_TEST_DSN unset: isolated PostgreSQL check NOT_RUN") + } + admin, err := sql.Open("pgx", dsn) + if err != nil { + t.Fatal(err) + } + t.Cleanup(func() { admin.Close() }) + if _, err := admin.Exec(`CREATE EXTENSION IF NOT EXISTS pg_trgm`); err != nil { + t.Fatal(err) + } + schema := "w9_" + strings.ToLower(string(store.NewID("audit"))) + if _, err := admin.Exec(`CREATE SCHEMA ` + schema); err != nil { + t.Fatal(err) + } + t.Cleanup(func() { admin.Exec(`DROP SCHEMA IF EXISTS ` + schema + ` CASCADE`) }) + st, err := store.OpenPostgres(store.AppendPGRuntimeParam(dsn, "search_path", schema+",public"), filepath.Join(t.TempDir(), "artifacts")) + if err != nil { + t.Fatal(err) + } + defer st.Close() + if err := st.EnsureUser("alice", "Alice"); err != nil { + t.Fatal(err) + } + project, err := st.CreateProject("alice", "A") + if err != nil { + t.Fatal(err) + } + conversation, err := st.CreateConversation("alice", string(project.ID), "work", "") + if err != nil { + t.Fatal(err) + } + for _, command := range []string{"first", "second"} { + if err := st.AppendAudit("alice", agentcommand.AuditEnvelope{Time: time.Now(), Actor: "alice", CommandID: command, ConversationID: string(conversation.ID), State: agentcommand.StateCommitted}); err != nil { + t.Fatal(err) + } + } + insert := `INSERT INTO command_audit(time,command_id,source,entrance,state,operation_id,conversation_id,owner,payload,actor_name,project_id) + VALUES ($1,$2,'','','committed','',$3,'alice',$4,'Alice',$5) RETURNING id` + gap, err := st.DB().Begin() + if err != nil { + t.Fatal(err) + } + defer gap.Rollback() + var gapID int64 + if err := gap.QueryRow(insert, time.Now().UTC().Format(time.RFC3339Nano), "rolled-back-gap", string(conversation.ID), `{}`, string(project.ID)).Scan(&gapID); err != nil { + t.Fatal(err) + } + if gapID != 3 { + t.Fatalf("rollback gap ID=%d want=3", gapID) + } + if err := gap.Rollback(); err != nil { + t.Fatal(err) + } + a, err := st.DB().Begin() + if err != nil { + t.Fatal(err) + } + defer a.Rollback() + env := agentcommand.AuditEnvelope{Time: time.Now(), Actor: "alice", CommandID: "explicit-late", ConversationID: string(conversation.ID), State: agentcommand.StateCommitted} + raw, err := json.Marshal(env) + if err != nil { + t.Fatal(err) + } + _, err = a.Exec(`INSERT INTO command_audit(id,time,command_id,source,entrance,state,operation_id,conversation_id,owner,payload,actor_name,project_id) + VALUES (3,$1,$2,'','','committed','',$3,'alice',$4,'Alice',$5)`, env.Time.UTC().Format(time.RFC3339Nano), env.CommandID, string(conversation.ID), string(raw), string(project.ID)) + if err != nil { + // Rejecting the online explicit ID is also a safe outcome. + t.Logf("online explicit low ID rejected: %v", err) + return + } + slot := &projectAuditSlot{} + caps := hostcaps{st: st, projectAudit: slot} + reg := pluginRegistry{pluginID: "rdm", caps: caps} + if err := reg.RegisterProjectAuditAuthorizer(func(actor string, projectID core.ID) (bool, error) { + return actor == "alice" && projectID == project.ID, nil + }); err != nil { + t.Fatal(err) + } + h := inprocHost{caps: caps, owner: "alice", actor: "alice", pluginID: "rdm"} + committed := make(chan error, 1) + started := make(chan struct{}) + go func() { + close(started) + committed <- st.AppendAudit("alice", agentcommand.AuditEnvelope{Time: time.Now(), Actor: "alice", CommandID: "implicit-high", ConversationID: string(conversation.ID), State: agentcommand.StateCommitted}) + }() + <-started + var first extension.ProjectAuditPage + highCommittedEarly := false + select { + case err := <-committed: + if err != nil { + t.Fatal(err) + } + highCommittedEarly = true + case <-time.After(500 * time.Millisecond): + } + if highCommittedEarly { + first, err = h.QueryProjectAudit(context.Background(), extension.ProjectAuditQuery{ProjectID: project.ID, Limit: 2}) + if err != nil { + t.Fatal(err) + } + if len(first.Receipts) != 2 || first.Receipts[0].SourceOffset != 4 || first.Receipts[1].SourceOffset != 2 || first.CutoffOffset != 4 || first.NextOffset != 2 || first.Coverage.CutoffConsistency != "committed-prefix" { + t.Fatalf("counterexample first page changed: %+v", first) + } + } + if err := a.Commit(); err != nil { + t.Fatal(err) + } + if !highCommittedEarly { + if err := <-committed; err != nil { + t.Fatal(err) + } + first, err = h.QueryProjectAudit(context.Background(), extension.ProjectAuditQuery{ProjectID: project.ID, Limit: 2}) + if err != nil { + t.Fatal(err) + } + } + second, err := h.QueryProjectAudit(context.Background(), extension.ProjectAuditQuery{ProjectID: project.ID, BeforeOffset: first.NextOffset, CutoffOffset: first.CutoffOffset, Limit: 2}) + if err != nil { + t.Fatal(err) + } + seen := map[int64]bool{} + for _, receipt := range append(first.Receipts, second.Receipts...) { + seen[receipt.SourceOffset] = true + } + if !seen[3] || len(seen) != 4 { + t.Fatalf("committed-prefix omitted explicit low ID 3: early=%v first=%+v second=%+v", highCommittedEarly, first, second) + } +} diff --git a/internal/store/audit.go b/internal/store/audit.go index 6894c02..9b41a1c 100644 --- a/internal/store/audit.go +++ b/internal/store/audit.go @@ -38,7 +38,8 @@ type ProjectCommandAuditRow struct { } // ErrAuditCutoffUnsafe prevents a PostgreSQL page from claiming a fixed cutoff -// when the installed ID generator or sequence no longer proves commit order. +// when the ID generator, sequence, or all-writer database guard cannot prove +// commit order. var ErrAuditCutoffUnsafe = errors.New("store: project audit cutoff unsafe") func (s *Store) requireProjectAuditCommittedPrefix() error { @@ -46,7 +47,7 @@ func (s *Store) requireProjectAuditCommittedPrefix() error { return nil } // SQLite serializes writers. var safe bool - if err := s.db.QueryRow(`SELECT project_audit_cutoff_safe('command_audit'::regclass)`).Scan(&safe); err != nil { + if err := s.db.QueryRow(`SELECT project_audit_cutoff_safe('command_audit'::regclass) AND project_audit_writers_guarded('command_audit'::regclass)`).Scan(&safe); err != nil { return fmt.Errorf("%w: %v", ErrAuditCutoffUnsafe, err) } if !safe { diff --git a/internal/store/migrate.go b/internal/store/migrate.go index 24a9763..2ab5a1c 100644 --- a/internal/store/migrate.go +++ b/internal/store/migrate.go @@ -919,6 +919,84 @@ func init() { `DROP FUNCTION project_audit_cutoff_safe(regclass)`, }, }}, + migration{version: 34, name: "project_audit_all_writers_guard", + up: map[string][]string{ + "sqlite": {`SELECT 1`}, + "postgres": { + `LOCK TABLE command_audit IN ACCESS EXCLUSIVE MODE`, + `CREATE FUNCTION project_audit_insert_guard_v1() RETURNS trigger LANGUAGE plpgsql VOLATILE AS $$ + DECLARE seq regclass; last_number numeric; was_called boolean; max_id bigint; + BEGIN + IF current_setting('transaction_isolation') <> 'read committed' THEN + RAISE EXCEPTION 'command audit insert requires read committed isolation'; + END IF; + PERFORM pg_advisory_xact_lock(715328491,TG_RELID::int4); + IF NOT project_audit_cutoff_safe(TG_RELID) OR NOT project_audit_writers_guarded(TG_RELID) THEN + RAISE EXCEPTION 'command audit write guard is unsafe'; + END IF; + seq := pg_get_serial_sequence(TG_RELID::regclass::text,'id')::regclass; + EXECUTE format('SELECT last_value,is_called FROM %s',seq) INTO last_number,was_called; + EXECUTE format('SELECT COALESCE(MAX(id),0) FROM %s',TG_RELID::regclass) INTO max_id; + IF NEW.id IS NULL OR NEW.id<=0 OR NEW.id<=max_id OR NOT was_called OR NEW.id>last_number THEN + RAISE EXCEPTION 'command audit ID is not commit-monotone'; + END IF; + RETURN NEW; + END $$`, + `CREATE FUNCTION project_audit_mutation_guard_v1() RETURNS trigger LANGUAGE plpgsql AS $$ + BEGIN RAISE EXCEPTION 'command audit is append-only'; END $$`, + `CREATE TRIGGER project_audit_insert_guard_v1 BEFORE INSERT ON command_audit FOR EACH ROW EXECUTE FUNCTION project_audit_insert_guard_v1()`, + `CREATE TRIGGER project_audit_mutation_guard_v1 BEFORE UPDATE OR DELETE ON command_audit FOR EACH ROW EXECUTE FUNCTION project_audit_mutation_guard_v1()`, + `ALTER TABLE command_audit ENABLE ALWAYS TRIGGER project_audit_insert_guard_v1`, + `ALTER TABLE command_audit ENABLE ALWAYS TRIGGER project_audit_mutation_guard_v1`, + `CREATE FUNCTION project_audit_writers_guarded(target regclass) RETURNS boolean LANGUAGE plpgsql VOLATILE AS $$ + DECLARE insert_ok boolean; mutation_ok boolean; + BEGIN + SELECT EXISTS (SELECT 1 FROM pg_trigger WHERE tgrelid=target AND tgname='project_audit_insert_guard_v1' + AND NOT tgisinternal AND tgenabled='A' AND tgtype=7 + AND tgfoid=to_regprocedure('project_audit_insert_guard_v1()')) INTO insert_ok; + SELECT EXISTS (SELECT 1 FROM pg_trigger WHERE tgrelid=target AND tgname='project_audit_mutation_guard_v1' + AND NOT tgisinternal AND tgenabled='A' AND tgtype=27 + AND tgfoid=to_regprocedure('project_audit_mutation_guard_v1()')) INTO mutation_ok; + RETURN insert_ok AND mutation_ok; + END $$`, + `CREATE OR REPLACE FUNCTION next_command_audit_id(target regclass) RETURNS bigint LANGUAGE plpgsql VOLATILE AS $$ + DECLARE seq regclass; allocated bigint; max_id bigint; + BEGIN + PERFORM pg_advisory_xact_lock(715328491,target::oid::int4); + IF NOT project_audit_cutoff_safe(target) OR NOT project_audit_writers_guarded(target) THEN + RAISE EXCEPTION 'project audit cutoff guard is unsafe'; + END IF; + seq := pg_get_serial_sequence(target::text,'id')::regclass; + allocated := nextval(seq); + EXECUTE format('SELECT COALESCE(MAX(id),0) FROM %s',target) INTO max_id; + IF allocated<=0 OR allocated<=max_id THEN RAISE EXCEPTION 'project audit ID did not advance beyond committed rows'; END IF; + RETURN allocated; + END $$`, + `DO $$ BEGIN IF NOT project_audit_cutoff_safe('command_audit'::regclass) OR NOT project_audit_writers_guarded('command_audit'::regclass) THEN RAISE EXCEPTION 'project audit writer guard migration precondition failed'; END IF; END $$`, + }, + }, + down: map[string][]string{ + "sqlite": {`SELECT 1`}, + "postgres": { + `LOCK TABLE command_audit IN ACCESS EXCLUSIVE MODE`, + `CREATE OR REPLACE FUNCTION next_command_audit_id(target regclass) RETURNS bigint LANGUAGE plpgsql VOLATILE AS $$ + DECLARE seq regclass; allocated bigint; max_id bigint; + BEGIN + PERFORM pg_advisory_xact_lock(715328491,target::oid::int4); + IF NOT project_audit_cutoff_safe(target) THEN RAISE EXCEPTION 'project audit cutoff sequence is unsafe'; END IF; + seq := pg_get_serial_sequence(target::text,'id')::regclass; + allocated := nextval(seq); + EXECUTE format('SELECT COALESCE(MAX(id),0) FROM %s',target) INTO max_id; + IF allocated<=0 OR allocated<=max_id THEN RAISE EXCEPTION 'project audit ID did not advance beyond committed rows'; END IF; + RETURN allocated; + END $$`, + `DROP TRIGGER project_audit_insert_guard_v1 ON command_audit`, + `DROP TRIGGER project_audit_mutation_guard_v1 ON command_audit`, + `DROP FUNCTION project_audit_insert_guard_v1()`, + `DROP FUNCTION project_audit_mutation_guard_v1()`, + `DROP FUNCTION project_audit_writers_guarded(regclass)`, + }, + }}, ) } diff --git a/internal/store/migrate_compat.go b/internal/store/migrate_compat.go index a653f3b..a4f7766 100644 --- a/internal/store/migrate_compat.go +++ b/internal/store/migrate_compat.go @@ -38,6 +38,7 @@ var migrationBreaksOldReaders = map[int]bool{ 31: false, // command_audit_attribution_snapshot：仅加列/索引，旧读者不受影响 32: false, // project_audit_committed_links：新表，旧读者不受影响 33: false, // project_audit_committed_prefix：PG 审计 ID 默认函数，旧读者兼容 + 34: false, // project_audit_all_writers_guard：PG 在线审计写入门禁，旧读者兼容 } // SchemaTarget 是本二进制会迁移到的 schema 版本。 diff --git a/internal/store/project_audit_sequence_test.go b/internal/store/project_audit_sequence_test.go index 022f2b8..5742ffc 100644 --- a/internal/store/project_audit_sequence_test.go +++ b/internal/store/project_audit_sequence_test.go @@ -2,6 +2,7 @@ package store import ( "context" + "database/sql" "encoding/json" "fmt" "os" @@ -26,6 +27,88 @@ func openProjectAuditPG(t *testing.T) *Store { return st } +func TestProjectAuditAllWritersRejectUnsafeOnlineChanges(t *testing.T) { + st := openProjectAuditPG(t) + if err := st.AppendAudit("alice", agentcommand.AuditEnvelope{Time: time.Now(), Actor: "alice", CommandID: "first", State: agentcommand.StateCommitted}); err != nil { + t.Fatal(err) + } + row := `INSERT INTO command_audit(id,time,command_id,source,entrance,state,operation_id,conversation_id,owner,payload) + VALUES ($1,'2026-10-14T00:00:00Z','explicit','','','committed','','','alice','{}')` + if _, err := st.db.Exec(row, 100); err == nil { + t.Fatal("online explicit ID above reserved sequence position was accepted") + } + if _, err := st.db.Exec(`UPDATE command_audit SET command_id='changed' WHERE id=1`); err == nil { + t.Fatal("online audit UPDATE was accepted") + } + if _, err := st.db.Exec(`DELETE FROM command_audit WHERE id=1`); err == nil { + t.Fatal("online audit DELETE was accepted") + } + for _, level := range []sql.IsolationLevel{sql.LevelRepeatableRead, sql.LevelSerializable} { + tx, err := st.db.BeginTx(context.Background(), &sql.TxOptions{Isolation: level}) + if err != nil { + t.Fatal(err) + } + _, err = tx.Exec(`INSERT INTO command_audit(time,command_id,source,entrance,state,operation_id,conversation_id,owner,payload) + VALUES ('2026-10-14T00:00:00Z','stale-snapshot','','','committed','','','alice','{}')`) + tx.Rollback() + if err == nil || !strings.Contains(err.Error(), "read committed") { + t.Fatalf("isolation %v did not fail closed: %v", level, err) + } + } + seq := commandAuditSequenceName(t, st) + if _, err := st.db.Exec(`SELECT nextval($1::regclass)`, seq); err != nil { + t.Fatal(err) + } + if _, err := st.db.Exec(`INSERT INTO command_audit(id,time,command_id,source,entrance,state,operation_id,conversation_id,owner,payload) + VALUES (4,'2026-10-14T00:00:00Z','first-of-batch','','','committed','','','alice','{}'), + (1,'2026-10-14T00:00:00Z','decreasing','','','committed','','','alice','{}')`); err == nil { + t.Fatal("unordered multirow audit INSERT was accepted") + } + if _, err := st.db.Exec(row+` ON CONFLICT DO NOTHING`, 1); err == nil { + t.Fatal("online replay bypassed the INSERT guard through ON CONFLICT") + } + var count int + if err := st.db.QueryRow(`SELECT COUNT(*) FROM command_audit`).Scan(&count); err != nil || count != 1 { + t.Fatalf("unsafe writes persisted: count=%d err=%v", count, err) + } +} + +func TestProjectAuditAllWritersGuardDriftFailsClosed(t *testing.T) { + st := openProjectAuditPG(t) + for _, trigger := range []string{"project_audit_insert_guard_v1", "project_audit_mutation_guard_v1"} { + if _, err := st.db.Exec(`ALTER TABLE command_audit DISABLE TRIGGER ` + trigger); err != nil { + t.Fatal(err) + } + if _, _, _, err := st.ListProjectCommandAudits("alice", "project", 0, 0, 10); err == nil { + t.Fatalf("read accepted disabled trigger %s", trigger) + } + if err := st.AppendAudit("alice", agentcommand.AuditEnvelope{Time: time.Now(), Actor: "alice", CommandID: "drift"}); err == nil { + t.Fatalf("append accepted disabled trigger %s", trigger) + } + if _, err := st.db.Exec(`ALTER TABLE command_audit ENABLE ALWAYS TRIGGER ` + trigger); err != nil { + t.Fatal(err) + } + } + if _, err := st.db.Exec(`CREATE OR REPLACE TRIGGER project_audit_insert_guard_v1 BEFORE INSERT ON command_audit FOR EACH ROW EXECUTE FUNCTION project_audit_mutation_guard_v1()`); err != nil { + t.Fatal(err) + } + if _, err := st.db.Exec(`ALTER TABLE command_audit ENABLE ALWAYS TRIGGER project_audit_insert_guard_v1`); err != nil { + t.Fatal(err) + } + if _, _, _, err := st.ListProjectCommandAudits("alice", "project", 0, 0, 10); err == nil { + t.Fatal("read accepted rebound insert trigger") + } + if _, err := st.db.Exec(`CREATE OR REPLACE TRIGGER project_audit_insert_guard_v1 BEFORE INSERT ON command_audit FOR EACH ROW EXECUTE FUNCTION project_audit_insert_guard_v1()`); err != nil { + t.Fatal(err) + } + if _, err := st.db.Exec(`ALTER TABLE command_audit ENABLE ALWAYS TRIGGER project_audit_insert_guard_v1`); err != nil { + t.Fatal(err) + } + if err := st.AppendAudit("alice", agentcommand.AuditEnvelope{Time: time.Now(), Actor: "alice", CommandID: "restored"}); err != nil { + t.Fatalf("restored guard: %v", err) + } +} + func commandAuditSequenceName(t *testing.T, st *Store) string { t.Helper() var name string @@ -335,6 +418,12 @@ func TestProjectAuditSequenceLockTimeoutAndRollback(t *testing.T) { if _, err := conn.ExecContext(ctx, `RESET lock_timeout`); err != nil { t.Fatal(err) } + cancelCtx, cancel := context.WithTimeout(ctx, 150*time.Millisecond) + defer cancel() + var canceledID int64 + if err := conn.QueryRowContext(cancelCtx, insert, args...).Scan(&canceledID); err == nil { + t.Fatalf("canceled writer passed advisory lock: id=%d", canceledID) + } if err := tx.Rollback(); err != nil { t.Fatal(err) } @@ -426,7 +515,7 @@ func TestProjectAuditSequenceConcurrentLoad(t *testing.T) { statusMode = "test-only locked status wrapper" } newElapsed, newP95 := run("guarded", func(env agentcommand.AuditEnvelope) error { return st.AppendAudit("alice", env) }) - t.Logf("isolated PostgreSQL %s audit append: %d writes per mode / %d workers; v32 direct INSERT=%s p95=%s (%.0f/s), v33 Store.AppendAudit with %s=%s p95=%s (%.0f/s); hardware/load dependent SELF only", + t.Logf("isolated PostgreSQL %s audit append: %d writes per mode / %d workers; v32 direct INSERT=%s p95=%s (%.0f/s), v34 Store.AppendAudit with %s=%s p95=%s (%.0f/s); hardware/load dependent SELF only", serverVersion, writers*each, writers, oldElapsed, oldP95, float64(writers*each)/oldElapsed.Seconds(), statusMode, newElapsed, newP95, float64(writers*each)/newElapsed.Seconds()) seen := map[string]bool{} var before, cutoff int64 @@ -464,8 +553,14 @@ func TestProjectAuditConcurrentReadWriteNeverReportsFalseDrift(t *testing.T) { if err != nil { t.Fatal(err) } + for i := 0; i < 210; i++ { + if err := st.AppendAudit("alice", agentcommand.AuditEnvelope{Time: time.Now(), Actor: "alice", CommandID: fmt.Sprintf("seed-%d", i), ConversationID: string(c.ID), State: agentcommand.StateCommitted}); err != nil { + t.Fatal(err) + } + } const writers, writes, readers, reads = 6, 30, 4, 40 errs := make(chan error, writers*writes+readers*reads) + readDurations := make(chan time.Duration, readers*reads) var wg sync.WaitGroup for worker := 0; worker < writers; worker++ { wg.Add(1) @@ -485,10 +580,17 @@ func TestProjectAuditConcurrentReadWriteNeverReportsFalseDrift(t *testing.T) { go func() { defer wg.Done() for i := 0; i < reads; i++ { - if _, _, _, err := st.ListProjectCommandAudits("alice", string(p.ID), 0, 0, 10); err != nil { + started := time.Now() + page, _, _, err := st.ListProjectCommandAudits("alice", string(p.ID), 0, 0, 200) + if err != nil { errs <- fmt.Errorf("read: %w", err) return } + if len(page) != 200 { + errs <- fmt.Errorf("large page rows=%d want=200", len(page)) + return + } + readDurations <- time.Since(started) } }() } @@ -497,4 +599,12 @@ func TestProjectAuditConcurrentReadWriteNeverReportsFalseDrift(t *testing.T) { for err := range errs { t.Fatal(err) } + close(readDurations) + var samples []time.Duration + for duration := range readDurations { + samples = append(samples, duration) + } + sort.Slice(samples, func(i, j int) bool { return samples[i] < samples[j] }) + t.Logf("isolated PG mixed load: %d append writes / %d writers and %d 200-row pages / %d readers; page p95=%s, SELF cost signal only", + writers*writes, writers, readers*reads, readers, samples[len(samples)*95/100]) } diff --git a/pkg/extension/extension.go b/pkg/extension/extension.go index 173e5f0..0287fc8 100644 --- a/pkg/extension/extension.go +++ b/pkg/extension/extension.go @@ -44,7 +44,9 @@ import ( // ProjectAuditPublisherFactory; scoped Host string IDs cannot publish links. // 2.17.0-experimental: PostgreSQL project audit pages require a verified // committed-prefix ID generator; unsafe sequence/default drift rejects reads. -const SurfaceVersion = "2.17.0-experimental" +// 2.18.0-experimental: all PostgreSQL audit writes require the database +// insert guard and append-only policy before a committed-prefix claim. +const SurfaceVersion = "2.18.0-experimental" // ErrNotLinked 表示进程没有空白导入 link 包，Main 无法启动服务。 var ErrNotLinked = errors.New("extension: runner not linked; blank-import agent-system-backend/pkg/extension/link") diff --git a/pkg/extension/project_audit.go b/pkg/extension/project_audit.go index d1592fe..c05d6dc 100644 --- a/pkg/extension/project_audit.go +++ b/pkg/extension/project_audit.go @@ -103,7 +103,8 @@ type ProjectAuditPublisher interface { // ProjectAuditQuery reads one project-bound command-audit slice. Offset is a // host source offset, not a cross-domain event sequence. A nonzero BeforeOffset // must be paired with the CutoffOffset returned on the first page. PostgreSQL -// pages are served only while the installed generator and sequence prove a +// pages are served only while the installed generator, sequence, and all-writer +// database guards prove a // committed prefix; otherwise the host rejects the read instead of claiming a // fixed snapshot. See Coverage.CutoffConsistency. type ProjectAuditQuery struct { -- 2.54.0 From 14dc48de79b27878ab1cf4ad81ce11258599d0ed Mon Sep 17 00:00:00 2001 From: weichen Date: Wed, 14 Oct 2026 06:39:18 +0000 Subject: [PATCH 13/41] Reject reused migration identities before data copy Why: Parallel unpublished candidates reused numeric versions, so version-only checks could reinterpret a different schema after combination. Evidence: SQLite ledger and source-copy mismatch tests failed before the guard and pass now; PostgreSQL store/migrator and full Go suites pass. Impact: Fail closed on version-name mismatch before opening a migration target or serving a database. Refs: feature/rdm-two-trees-latest-templates Backend combination probe --- cmd/storage-migrate/main.go | 23 +++++++++++++++++++++++ cmd/storage-migrate/main_test.go | 17 +++++++++++++++++ internal/store/migrate.go | 16 +++++++++++----- internal/store/migrate_atomic_test.go | 18 ++++++++++++++++++ internal/store/migrate_compat.go | 11 +++++++++++ 5 files changed, 80 insertions(+), 5 deletions(-) diff --git a/cmd/storage-migrate/main.go b/cmd/storage-migrate/main.go index 63a6beb..4ee8cf4 100644 --- a/cmd/storage-migrate/main.go +++ b/cmd/storage-migrate/main.go @@ -350,6 +350,9 @@ func cmdMigrate(args []string) error { if err != nil { return err } + if err := validateSourceMigrationLedger(src); err != nil { + return err + } // 目标：先用 store 同款迁移器建 schema/扩展（OpenPostgres 会跑迁移与 // 未知版本门禁），再落控制表。DSN 不回显、不入报告。 @@ -416,6 +419,26 @@ func cmdMigrate(args []string) error { return writeReport(rep, *out) } +func validateSourceMigrationLedger(src *sql.DB) error { + rows, err := src.Query(`SELECT version,name FROM schema_migrations`) + if err != nil { + return err + } + defer rows.Close() + for rows.Next() { + var version int + var name string + if err := rows.Scan(&version, &name); err != nil { + return err + } + expected, known := store.MigrationName(version) + if !known || expected != name { + return fmt.Errorf("source migration identity mismatch at v%d; refuse to reinterpret another schema", version) + } + } + return rows.Err() +} + // Candidate context-scope v35 may contain full model prompts in private columns. // Never copy or back up such a source implicitly; it must be migrated and // reviewed in an isolated Backend store before this tool accepts it. diff --git a/cmd/storage-migrate/main_test.go b/cmd/storage-migrate/main_test.go index e89ee3f..c7d8005 100644 --- a/cmd/storage-migrate/main_test.go +++ b/cmd/storage-migrate/main_test.go @@ -30,6 +30,23 @@ func buildFixture(t *testing.T) string { return path } +func TestMigrateRejectsSourceLedgerNameCollisionBeforeTargetOpen(t *testing.T) { + source := buildFixture(t) + db, err := sql.Open("sqlite", source) + if err != nil { + t.Fatal(err) + } + if _, err := db.Exec(`UPDATE schema_migrations SET name='work_task_bindings' WHERE version=31`); err != nil { + db.Close() + t.Fatal(err) + } + db.Close() + err = cmdMigrate([]string{"--source", source, "--target", "invalid://target", "--migration-id", "name-collision"}) + if err == nil || !strings.Contains(err.Error(), "source migration identity mismatch") { + t.Fatalf("candidate branch ledger was not rejected before opening target: %v", err) + } +} + func seedEdgeRows(t *testing.T, st *store.Store) { t.Helper() // users（含 is_admin/must_change 布尔）与单租户默认身份。 diff --git a/internal/store/migrate.go b/internal/store/migrate.go index 6248aa3..6103aac 100644 --- a/internal/store/migrate.go +++ b/internal/store/migrate.go @@ -1254,26 +1254,32 @@ func (s *Store) migratePass() error { return fmt.Errorf("migrate: %w", err) } applied := map[int]bool{} - known := map[int]bool{} + known := map[int]string{} for _, m := range migrations { - known[m.version] = true + known[m.version] = m.name } - rows, err := tx.Query(`SELECT version FROM schema_migrations`) + rows, err := tx.Query(`SELECT version,name FROM schema_migrations`) if err != nil { return fmt.Errorf("migrate: %w", err) } for rows.Next() { var v int - if err := rows.Scan(&v); err != nil { + var name string + if err := rows.Scan(&v, &name); err != nil { rows.Close() return fmt.Errorf("migrate: %w", err) } // 兼容门禁（KTD8 应用侧只核对兼容版本）：库里有本二进制不认识的版本 // 说明库由更新的构建迁移过——拒绝启动，不冒险在未知 schema 上服务。 - if !known[v] { + expectedName, knownVersion := known[v] + if !knownVersion { rows.Close() return fmt.Errorf("migrate: 数据库 schema 版本 v%d 超出本构建（最高 v%d）；拒绝启动，请升级二进制", v, latestMigrationVersion()) } + if name != expectedName { + rows.Close() + return fmt.Errorf("migrate: migration identity mismatch at v%d; refuse to reinterpret another schema", v) + } applied[v] = true } if err := rows.Err(); err != nil { diff --git a/internal/store/migrate_atomic_test.go b/internal/store/migrate_atomic_test.go index e2421c4..7256f15 100644 --- a/internal/store/migrate_atomic_test.go +++ b/internal/store/migrate_atomic_test.go @@ -87,6 +87,24 @@ func assertFullLedger(t *testing.T, st *Store) { } } +// Separate feature candidates reused version 31 before current main assigned +// that number to account_audit. A version match alone must not silently treat +// the candidate's different schema as an applied release migration. +func TestMigrateRejectsLedgerNameMismatch(t *testing.T) { + path := filepath.Join(t.TempDir(), "name-mismatch.db") + st := openSQLiteAt(t, path) + if _, err := st.db.Exec(`UPDATE schema_migrations SET name='work_task_bindings' WHERE version=31`); err != nil { + t.Fatal(err) + } + st.Close() + if reopened, err := OpenSQLite(path); err == nil { + reopened.Close() + t.Fatal("reused migration version with different name was accepted") + } else if !strings.Contains(err.Error(), "migration identity mismatch") { + t.Fatalf("missing fail-closed migration identity error: %v", err) + } +} + // DDL 与账本同事务：在「DDL 已执行、版本未登记」处注入故障 → 全部回滚， // 不留下 v6 的表，也不留下 v6 的账本行（历史两步实现的中间态缺口）。 func TestMigrateAtomicDDLAndLedger(t *testing.T) { diff --git a/internal/store/migrate_compat.go b/internal/store/migrate_compat.go index 774bc90..3f408b5 100644 --- a/internal/store/migrate_compat.go +++ b/internal/store/migrate_compat.go @@ -50,6 +50,17 @@ var migrationBreaksOldReaders = map[int]bool{ // SchemaTarget 是本二进制会迁移到的 schema 版本。 func SchemaTarget() int { return latestMigrationVersion() } +// MigrationName lets the offline copier reject an unpublished branch schema +// that reused a numeric version for a different migration before copying rows. +func MigrationName(version int) (string, bool) { + for _, migration := range migrations { + if migration.version == version { + return migration.name, true + } + } + return "", false +} + // SchemaCompatFloor 是旧制品仍能读取的最高破坏性版本。0 表示当前全部迁移都不破坏旧读。 func SchemaCompatFloor() int { floor := 0 -- 2.54.0 From f4ed6b063ff3aaa7cf3917c8b40bd0eb10e8d291 Mon Sep 17 00:00:00 2001 From: weichen Date: Wed, 14 Oct 2026 06:49:34 +0000 Subject: [PATCH 14/41] Verify nonempty workflow context tables survive migration Why: Combined W6 and W9 storage validation must cover actual work task and step-source rows, not only empty tables. Evidence: Isolated PostgreSQL migration test copies and reads both rows with their trusted scope intact. Impact: Adds integration coverage for the combined v31-v40 migration; no production behavior change. Refs: feature/rdm-two-trees-latest-templates Backend combination probe --- cmd/storage-migrate/integration_test.go | 17 +++++++++++++++++ 1 file changed, 17 insertions(+) diff --git a/cmd/storage-migrate/integration_test.go b/cmd/storage-migrate/integration_test.go index 87b05d9..1f2d341 100644 --- a/cmd/storage-migrate/integration_test.go +++ b/cmd/storage-migrate/integration_test.go @@ -29,6 +29,15 @@ func TestMigrateTrustedContextManifestWithoutRawScope(t *testing.T) { if err := src.AppendContextManifestWithScope("alice", "r1", m, store.ContextManifestScope{Bound: true}); err != nil { t.Fatal(err) } + task, err := src.CreateWorkTask("alice", "rdm", "p1", "c1", "document", "Prepare document") + if err != nil { + t.Fatal(err) + } + stepHash := strings.Repeat("a", 64) + if _, err := src.DB().Exec(`INSERT INTO workflow_step_sources(run_id,step_id,owner,project_id,step_attempt_id,output_sha256,attempt_id,authorization_epoch,publication_epoch,watermark,version,created_at) VALUES(?,?,?,?,?,?,?,?,?,?,?,?)`, + "r1", "draft", "alice", "p1", "step-attempt", stepHash, "model-attempt", "auth-1", "pub-1", "water-1", "v1", "2026-10-14T00:00:00Z"); err != nil { + t.Fatal(err) + } if err := src.Close(); err != nil { t.Fatal(err) } @@ -48,6 +57,14 @@ func TestMigrateTrustedContextManifestWithoutRawScope(t *testing.T) { if err != nil || len(receipts) != 2 || len(receipts[1].Included) != 1 || receipts[1].Included[0].SourceID != "source-a" { t.Fatalf("content-free model receipts not copied: count=%d err=%v", len(receipts), err) } + workScope, err := pg.WorkTaskScope("alice", "rdm", task.ID) + if err != nil || workScope.ProjectID != "p1" || workScope.ConversationID != "c1" { + t.Fatalf("trusted work task binding not copied: scope=%+v err=%v", workScope, err) + } + stepSource, err := pg.WorkflowStepSource("alice", "r1", "draft") + if err != nil || stepSource.StepAttemptID != "step-attempt" || stepSource.AttemptID != "model-attempt" || stepSource.ProjectID != "p1" { + t.Fatalf("workflow step source not copied: source=%+v err=%v", stepSource, err) + } var rawColumns int if err := pg.DB().QueryRow(`SELECT COUNT(*) FROM information_schema.columns WHERE table_schema=current_schema() AND table_name='context_manifests' AND column_name IN ('resolve_goal','resolve_target_id')`).Scan(&rawColumns); err != nil || rawColumns != 0 { t.Fatalf("migrated PG schema has raw prompt columns: count=%d err=%v", rawColumns, err) -- 2.54.0 From d9b00c23c818bfc4a8d8233c845266fabd863137 Mon Sep 17 00:00:00 2001 From: weichen Date: Wed, 14 Oct 2026 06:52:29 +0000 Subject: [PATCH 15/41] Refuse rollback after migration ledger identity drift Why: An already-open Store could otherwise execute a numbered down migration after its ledger name changed. Evidence: The targeted rollback test failed before the guard and passed after it; focused SQLite and isolated PostgreSQL store/migrator checks passed. Impact: MigrationStatus and MigrateDown fail closed on version-name mismatch before changing schema. Refs: feature/rdm-two-trees-latest-templates Backend combination probe --- internal/store/migrate.go | 9 +++++++-- internal/store/migrate_atomic_test.go | 16 ++++++++++++++++ 2 files changed, 23 insertions(+), 2 deletions(-) diff --git a/internal/store/migrate.go b/internal/store/migrate.go index 6103aac..ea39d6b 100644 --- a/internal/store/migrate.go +++ b/internal/store/migrate.go @@ -1381,7 +1381,7 @@ func (s *Store) execInTx(stmts []string) error { // MigrationStatus 返回已应用版本列表（诊断/验收用）。 func (s *Store) MigrationStatus() ([]int, error) { - rows, err := s.db.Query(`SELECT version FROM schema_migrations ORDER BY version`) + rows, err := s.db.Query(`SELECT version,name FROM schema_migrations ORDER BY version`) if err != nil { return nil, err } @@ -1389,9 +1389,14 @@ func (s *Store) MigrationStatus() ([]int, error) { out := []int{} for rows.Next() { var v int - if err := rows.Scan(&v); err != nil { + var name string + if err := rows.Scan(&v, &name); err != nil { return nil, err } + expected, known := MigrationName(v) + if !known || expected != name { + return nil, fmt.Errorf("migrate: migration identity mismatch at v%d; refuse to roll back another schema", v) + } out = append(out, v) } return out, rows.Err() diff --git a/internal/store/migrate_atomic_test.go b/internal/store/migrate_atomic_test.go index 7256f15..ca8f1d0 100644 --- a/internal/store/migrate_atomic_test.go +++ b/internal/store/migrate_atomic_test.go @@ -105,6 +105,22 @@ func TestMigrateRejectsLedgerNameMismatch(t *testing.T) { } } +func TestMigrateDownRejectsLedgerNameDriftBeforeChangingSchema(t *testing.T) { + path := filepath.Join(t.TempDir(), "down-name-drift.db") + st := openSQLiteAt(t, path) + if _, err := st.db.Exec(`UPDATE schema_migrations SET name='wrong-candidate' WHERE version=40`); err != nil { + t.Fatal(err) + } + err := st.MigrateDown(39) + if err == nil || !strings.Contains(err.Error(), "migration identity mismatch") { + t.Fatalf("rollback accepted a changed migration identity: %v", err) + } + var remain int + if err := st.db.QueryRow(`SELECT COUNT(*) FROM schema_migrations WHERE version=40`).Scan(&remain); err != nil || remain != 1 { + t.Fatalf("rollback changed ledger before refusing: remaining=%d err=%v", remain, err) + } +} + // DDL 与账本同事务：在「DDL 已执行、版本未登记」处注入故障 → 全部回滚， // 不留下 v6 的表，也不留下 v6 的账本行（历史两步实现的中间态缺口）。 func TestMigrateAtomicDDLAndLedger(t *testing.T) { -- 2.54.0 From 2c4ccc33c446bca5b93dff3be7c4f5f1aea95f5a Mon Sep 17 00:00:00 2001 From: weichen Date: Wed, 14 Oct 2026 15:33:26 +0000 Subject: [PATCH 16/41] Define trusted project work observation contract Why: Real project messages and retrieved material need a scoped observer and preflight decision contract before they can become governed project candidates. Evidence: Registration denial test was RED before the implementation; go test ./... passed on Backend origin/main 2716b9e. Impact: Add public X3 types and trusted single-provider registration; the production observer slot is deliberately not wired yet, so no project observation behavior is claimed. Refs: TT-N03, TT-R01; approved work observation stage-five plan r1 --- internal/app/hostcaps.go | 1 + internal/app/project_work_observation.go | 56 ++++++++ internal/app/project_work_observation_test.go | 46 +++++++ pkg/extension/extension.go | 4 +- pkg/extension/project_work.go | 128 ++++++++++++++++++ pkg/extension/surface.txt | 19 +++ 6 files changed, 253 insertions(+), 1 deletion(-) create mode 100644 internal/app/project_work_observation.go create mode 100644 internal/app/project_work_observation_test.go create mode 100644 pkg/extension/project_work.go diff --git a/internal/app/hostcaps.go b/internal/app/hostcaps.go index 7ffd00c..ae13a7c 100644 --- a/internal/app/hostcaps.go +++ b/internal/app/hostcaps.go @@ -22,6 +22,7 @@ import ( // inprocHost（EXT-1 批注 1：复用现有 owner 作用域函数，不新造句柄）。 type hostcaps struct { projects *projectLifecycleSlot + workObserver *projectWorkObserverSlot directory *accountDirectorySlot accountGuard func(string) error allowImplicitLocal bool diff --git a/internal/app/project_work_observation.go b/internal/app/project_work_observation.go new file mode 100644 index 0000000..489ad1b --- /dev/null +++ b/internal/app/project_work_observation.go @@ -0,0 +1,56 @@ +package app + +import ( + "errors" + "sync" + + "agent-system-backend/pkg/extension" +) + +type projectWorkObserverSlot struct { + mu sync.RWMutex + provider *extension.ProjectWorkObserver +} + +func (s *projectWorkObserverSlot) get() *extension.ProjectWorkObserver { + if s == nil { + return nil + } + s.mu.RLock() + defer s.mu.RUnlock() + if s.provider == nil { + return nil + } + copy := *s.provider + return © +} + +func (r compiledRegistry) RegisterProjectWorkObserver(extension.ProjectWorkObserver) error { + return errors.New("extension: declarative plugins cannot register project work observers") +} + +func (r pluginRegistry) RegisterProjectWorkObserver(p extension.ProjectWorkObserver) error { + if r.pluginID != "rdm" || r.caps.workObserver == nil { + return errors.New("extension: project work observer requires trusted RDM registration") + } + if p.Observe == nil || p.Preflight == nil || p.Respond == nil { + return errors.New("extension: project work observer requires all callbacks") + } + s := r.caps.workObserver + s.mu.Lock() + defer s.mu.Unlock() + if s.provider != nil { + return errors.New("extension: project work observer already registered") + } + copy := p + s.provider = © + return nil +} + +func (r recordRegistry) RegisterProjectWorkObserver(p extension.ProjectWorkObserver) error { + reg, ok := r.Registry.(extension.ProjectWorkObservationRegistry) + if !ok { + return errors.New("extension: project work observation registration unavailable") + } + return reg.RegisterProjectWorkObserver(p) +} diff --git a/internal/app/project_work_observation_test.go b/internal/app/project_work_observation_test.go new file mode 100644 index 0000000..68b5ba7 --- /dev/null +++ b/internal/app/project_work_observation_test.go @@ -0,0 +1,46 @@ +package app + +import ( + "context" + "testing" + + "agent-system-backend/pkg/extension" +) + +func workObserverForTest() extension.ProjectWorkObserver { + return extension.ProjectWorkObserver{ + Observe: func(context.Context, extension.WorkObservation) (extension.WorkObservationResult, error) { + return extension.WorkObservationResult{State: extension.WorkObservationPending}, nil + }, + Preflight: func(context.Context, extension.ProjectWorkAction) (extension.ProjectWorkDecision, error) { + return extension.ProjectWorkDecision{State: extension.ProjectWorkPending}, nil + }, + Respond: func(context.Context, extension.ProjectRiskAnswer) (extension.ProjectWorkDecision, error) { + return extension.ProjectWorkDecision{State: extension.ProjectWorkPending}, nil + }, + } +} + +func TestProjectWorkObservationRegistrationIsTrustedAndUnique(t *testing.T) { + slot := &projectWorkObserverSlot{} + trusted := pluginRegistry{pluginID: "rdm", caps: hostcaps{workObserver: slot}} + other := pluginRegistry{pluginID: "other", caps: hostcaps{workObserver: slot}} + if err := other.RegisterProjectWorkObserver(workObserverForTest()); err == nil { + t.Fatal("untrusted plugin registered project observer") + } + if err := (compiledRegistry{}).RegisterProjectWorkObserver(workObserverForTest()); err == nil { + t.Fatal("declarative plugin registered live observer callback") + } + if err := trusted.RegisterProjectWorkObserver(extension.ProjectWorkObserver{}); err == nil { + t.Fatal("partial observer registered") + } + if err := trusted.RegisterProjectWorkObserver(workObserverForTest()); err != nil { + t.Fatal(err) + } + if err := trusted.RegisterProjectWorkObserver(workObserverForTest()); err == nil { + t.Fatal("second observer replaced the trusted provider") + } + if got := slot.get(); got == nil || got.Observe == nil || got.Preflight == nil || got.Respond == nil { + t.Fatal("registered observer not available to host") + } +} diff --git a/pkg/extension/extension.go b/pkg/extension/extension.go index bbfe1d1..36ba193 100644 --- a/pkg/extension/extension.go +++ b/pkg/extension/extension.go @@ -36,7 +36,9 @@ import ( // ResourceAuthzQuery.Source for per-document publication authorization. // 2.13.0-experimental: optional AccountDirectoryProvider and trusted in-process // AccountDirectoryRegistrar for scoped, current account candidate decisions. -const SurfaceVersion = "2.13.0-experimental" +// 2.14.0-experimental: optional ProjectWorkObservationRegistry; host-origin +// work-source observations and project action decisions (X3 contract). +const SurfaceVersion = "2.14.0-experimental" // ErrNotLinked 表示进程没有空白导入 link 包，Main 无法启动服务。 var ErrNotLinked = errors.New("extension: runner not linked; blank-import agent-system-backend/pkg/extension/link") diff --git a/pkg/extension/project_work.go b/pkg/extension/project_work.go new file mode 100644 index 0000000..7aea802 --- /dev/null +++ b/pkg/extension/project_work.go @@ -0,0 +1,128 @@ +package extension + +import ( + "context" + "time" + + core "agent-system-core" +) + +// WorkObservation is built by the host from a committed message or an actual +// retrieval, tool, or visible analysis result. Callers and models cannot supply +// Actor, ProjectID, source identity, or the source authorization epoch. +// RunID may be empty for a newly committed user message or chat command. +type WorkObservation struct { + EventID string `json:"eventId"` + Phase string `json:"phase"` + Actor string `json:"actor"` + Owner string `json:"owner"` + ProjectID core.ID `json:"projectId"` + ConversationID core.ID `json:"conversationId,omitempty"` + RunID core.ID `json:"runId,omitempty"` + SourceKind string `json:"sourceKind"` + SourceID string `json:"sourceId"` + SourceVersion string `json:"sourceVersion"` + SourceSHA256 string `json:"sourceSha256"` + PartIndex int `json:"partIndex"` + SpanStart int `json:"spanStart"` // UTF-8 byte offset in the exact source + SpanEnd int `json:"spanEnd"` + Text string `json:"text,omitempty"` // only the actual authorized fragment + Scope string `json:"scope"` // private|project|controlled + Delivery string `json:"delivery"` // complete|summary-only|partial + AuthorizationEpoch string `json:"authorizationEpoch"` + ObservedAt time.Time `json:"observedAt"` +} + +type WorkObservationState string + +const ( + WorkObservationAccepted WorkObservationState = "accepted" // durable intake, analysis may be pending + WorkObservationPending WorkObservationState = "pending" + WorkObservationDenied WorkObservationState = "denied" + WorkObservationPartial WorkObservationState = "partial" +) + +type WorkObservationResult struct { + ReceiptID string `json:"receiptId"` + State WorkObservationState `json:"state"` + Reason string `json:"reason,omitempty"` +} + +// ProjectWorkSource is one exact part consumed by the pending action. A hash +// mismatch or missing part must block Preflight rather than use a stale receipt. +type ProjectWorkSource struct { + EventID string `json:"eventId"` + SourceKind string `json:"sourceKind"` + SourceID string `json:"sourceId"` + SourceVersion string `json:"sourceVersion"` + SourceSHA256 string `json:"sourceSha256"` + PartIndex int `json:"partIndex"` +} + +// ProjectWorkAction is constructed by the host immediately before model use, +// project command dispatch, or another project-affecting action. ProjectID is +// checked against the stored conversation or run, never trusted from Params. +type ProjectWorkAction struct { + Actor string `json:"actor"` + Owner string `json:"owner"` + ProjectID core.ID `json:"projectId"` + ConversationID core.ID `json:"conversationId,omitempty"` + RunID core.ID `json:"runId,omitempty"` + Action string `json:"action"` + TargetID string `json:"targetId,omitempty"` + TargetVersion string `json:"targetVersion,omitempty"` + Manifest []ProjectWorkSource `json:"manifest"` + SourceWatermark string `json:"sourceWatermark"` +} + +type ProjectWorkDecisionState string + +const ( + ProjectWorkProceed ProjectWorkDecisionState = "proceed" + ProjectWorkClarify ProjectWorkDecisionState = "clarify" + ProjectWorkPending ProjectWorkDecisionState = "pending" + ProjectWorkDenied ProjectWorkDecisionState = "denied" +) + +// ProjectWorkDecision is a domain decision, not a replacement for a controlled +// document's separate one-time human approval. A successful Observe ACK cannot +// be interpreted as ProjectWorkProceed. +type ProjectWorkDecision struct { + State ProjectWorkDecisionState `json:"state"` + DecisionID string `json:"decisionId"` + RiskID string `json:"riskId,omitempty"` + RiskRevision string `json:"riskRevision,omitempty"` + SourceWatermark string `json:"sourceWatermark,omitempty"` + Reason string `json:"reason,omitempty"` + Question string `json:"question,omitempty"` + Options []string `json:"options,omitempty"` +} + +// ProjectRiskAnswer comes from a current authenticated session and persisted +// risk card. An answer is applied only after the provider commits a CAS receipt. +type ProjectRiskAnswer struct { + Actor string `json:"actor"` + Owner string `json:"owner"` + ProjectID core.ID `json:"projectId"` + RiskID string `json:"riskId"` + RiskRevision string `json:"riskRevision"` + Answer string `json:"answer"` + IdempotencyKey string `json:"idempotencyKey"` +} + +// ProjectWorkObserver is owned by the project domain. Backend must check a +// returned decision against the exact current source manifest and must fail +// closed on missing provider, timeout, or partial analysis when project facts +// are required. RDM remains the sole persistent risk-state owner. +type ProjectWorkObserver struct { + Observe func(context.Context, WorkObservation) (WorkObservationResult, error) + Preflight func(context.Context, ProjectWorkAction) (ProjectWorkDecision, error) + Respond func(context.Context, ProjectRiskAnswer) (ProjectWorkDecision, error) +} + +// ProjectWorkObservationRegistry is optional so older in-process extensions do +// not acquire a mandatory Registry method. Declarative plugins cannot register +// a callback. The host accepts one trusted RDM provider. +type ProjectWorkObservationRegistry interface { + RegisterProjectWorkObserver(ProjectWorkObserver) error +} diff --git a/pkg/extension/surface.txt b/pkg/extension/surface.txt index ca7118a..61c7c8c 100644 --- a/pkg/extension/surface.txt +++ b/pkg/extension/surface.txt @@ -64,6 +64,18 @@ ProjectHost.RenameOwnedProject ProjectLifecycle ProjectLifecycleRegistry ProjectLifecycleRegistry.RegisterProjectLifecycle +ProjectRiskAnswer +ProjectWorkAction +ProjectWorkClarify +ProjectWorkDecision +ProjectWorkDecisionState +ProjectWorkDenied +ProjectWorkObservationRegistry +ProjectWorkObservationRegistry.RegisterProjectWorkObserver +ProjectWorkObserver +ProjectWorkPending +ProjectWorkProceed +ProjectWorkSource RegisterCompiled Registry Registry.AddAdminZone @@ -88,3 +100,10 @@ SurfaceHost.SurfaceList SurfaceHost.SurfaceSave SurfaceSaveRequest SurfaceVersion +WorkObservation +WorkObservationAccepted +WorkObservationDenied +WorkObservationPartial +WorkObservationPending +WorkObservationResult +WorkObservationState -- 2.54.0 From 18cd0d4247a6609673a6451007bb866a61a209e3 Mon Sep 17 00:00:00 2001 From: weichen Date: Wed, 14 Oct 2026 15:52:42 +0000 Subject: [PATCH 17/41] Persist private project message observations atomically Why: Project user messages and final assistant replies need exact, replayable source parts before a domain observer can safely analyze them. Evidence: go test -p 1 ./... passed; isolated PostgreSQL outbox, audit, migration, and work-context tests passed against a temporary cluster; request dedup, fenced settlement rollback, authorization recheck, and receipt idempotency tests passed. Impact: Add migration 44 and a private host outbox for committed message parts; actual observer delivery and action preflight are not yet wired into the product path. Refs: TT-N03, TT-R01; approved X3 stage-five plan r1 --- cmd/storage-migrate/main.go | 4 +- internal/app/project_work_observation.go | 58 ++++++ internal/app/project_work_observation_test.go | 52 +++++ internal/store/messages.go | 8 +- internal/store/migrate.go | 9 + internal/store/migrate_compat.go | 1 + internal/store/project_work_outbox.go | 181 ++++++++++++++++++ internal/store/project_work_outbox_test.go | 124 ++++++++++++ internal/store/recovery.go | 8 +- internal/store/run_account_write.go | 3 + 10 files changed, 444 insertions(+), 4 deletions(-) create mode 100644 internal/store/project_work_outbox.go create mode 100644 internal/store/project_work_outbox_test.go diff --git a/cmd/storage-migrate/main.go b/cmd/storage-migrate/main.go index 86d16db..eb395be 100644 --- a/cmd/storage-migrate/main.go +++ b/cmd/storage-migrate/main.go @@ -285,7 +285,7 @@ func cmdBackup(args []string) error { // admission_leases 是运行态执行许可（迁移无意义），明确排除。 var copyOrder = []string{ "projects", "users", "account_directory_revision", "profiles", "settings", "plugins", - "conversations", "runs", "messages", "events", "artifacts", + "conversations", "runs", "messages", "project_work_outbox", "events", "artifacts", "hitl_cards", "plans", "todos", "knowledge", "knowledge_vectors", "activity_cards", "project_event_shares", "command_audit", "project_audit_links", "prompt_modules", "sessions", "api_keys", @@ -953,7 +953,7 @@ func advanceSequences(db *sql.DB, table string) error { // 除外）。未知 owner 阻塞迁移（U4/R7：不静默带过未知归属）。 func checkOwners(db *sql.DB, src *sql.DB) error { ownerTables := []string{"projects", "conversations", "runs", "artifacts", "knowledge", "hitl_cards", "profiles", "activity_cards", - "project_event_shares", "command_audit", "project_audit_links", "work_task_bindings", "context_manifests", "workflow_step_sources", + "project_event_shares", "command_audit", "project_audit_links", "project_work_outbox", "work_task_bindings", "context_manifests", "workflow_step_sources", "sessions", "api_keys", "login_keys", "account_events", "recovery_proposals"} for _, t := range ownerTables { if !sqliteHasTable(src, t) { diff --git a/internal/app/project_work_observation.go b/internal/app/project_work_observation.go index 489ad1b..c6bca54 100644 --- a/internal/app/project_work_observation.go +++ b/internal/app/project_work_observation.go @@ -1,10 +1,14 @@ package app import ( + "context" "errors" + "fmt" "sync" + "agent-system-backend/internal/store" "agent-system-backend/pkg/extension" + core "agent-system-core" ) type projectWorkObserverSlot struct { @@ -54,3 +58,57 @@ func (r recordRegistry) RegisterProjectWorkObserver(p extension.ProjectWorkObser } return reg.RegisterProjectWorkObserver(p) } + +// deliverProjectWorkObservations replays only committed source parts, rechecking +// their owner and current project work authority before disclosing text to RDM. +// An Observe ACK is an intake receipt, not a preflight or publication decision. +// Failures leave the row pending for a later idempotent retry. +func deliverProjectWorkObservations(ctx context.Context, st *store.Store, slot *projectWorkObserverSlot, + work func(context.Context, string, core.ID) (bool, error), limit int, +) (int, error) { + provider := slot.get() + if provider == nil || work == nil { + return 0, errors.New("extension: trusted project work observer unavailable") + } + rows, err := st.PendingProjectWorkObservations(limit) + if err != nil { + return 0, err + } + completed := 0 + for _, row := range rows { + if err := ctx.Err(); err != nil { + return completed, err + } + conv, err := st.GetConversation(row.Owner, row.ConversationID) + if err != nil || string(conv.ProjectID) != row.ProjectID { + return completed, fmt.Errorf("project work source %s: current conversation binding unavailable", row.EventID) + } + allowed, err := work(ctx, row.Owner, core.ID(row.ProjectID)) + if err != nil || !allowed { + return completed, fmt.Errorf("project work source %s: current project authorization denied", row.EventID) + } + observation := extension.WorkObservation{ + EventID: row.EventID, Phase: "source-committed", Actor: row.Owner, Owner: row.Owner, + ProjectID: core.ID(row.ProjectID), ConversationID: core.ID(row.ConversationID), RunID: core.ID(row.RunID), + SourceKind: row.SourceKind, SourceID: row.SourceID, SourceVersion: row.SourceVersion, + SourceSHA256: row.SourceSHA256, PartIndex: row.PartIndex, SpanStart: row.SpanStart, SpanEnd: row.SpanEnd, + Text: row.Text, Scope: row.Scope, Delivery: row.Delivery, ObservedAt: row.ObservedAt, + } + result, err := provider.Observe(ctx, observation) + if err != nil { + return completed, err + } + switch result.State { + case extension.WorkObservationPending: + continue + case extension.WorkObservationAccepted, extension.WorkObservationPartial, extension.WorkObservationDenied: + if err := st.FinishProjectWorkObservation(row.EventID, result.ReceiptID, string(result.State)); err != nil { + return completed, err + } + completed++ + default: + return completed, fmt.Errorf("project work source %s: invalid observer result %q", row.EventID, result.State) + } + } + return completed, nil +} diff --git a/internal/app/project_work_observation_test.go b/internal/app/project_work_observation_test.go index 68b5ba7..079ab87 100644 --- a/internal/app/project_work_observation_test.go +++ b/internal/app/project_work_observation_test.go @@ -2,9 +2,12 @@ package app import ( "context" + "path/filepath" "testing" + "agent-system-backend/internal/store" "agent-system-backend/pkg/extension" + core "agent-system-core" ) func workObserverForTest() extension.ProjectWorkObserver { @@ -21,6 +24,55 @@ func workObserverForTest() extension.ProjectWorkObserver { } } +func TestProjectWorkDeliveryRechecksCurrentAuthorityAndACKsOnce(t *testing.T) { + st, err := store.OpenSQLite(filepath.Join(t.TempDir(), "work.db")) + if err != nil { + t.Fatal(err) + } + defer st.Close() + if err := st.EnsureUser("alice", "Alice"); err != nil { + t.Fatal(err) + } + project, err := st.CreateProject("alice", "P") + if err != nil { + t.Fatal(err) + } + conv, err := st.CreateConversation("alice", string(project.ID), "Work", "") + if err != nil { + t.Fatal(err) + } + msg := core.Message{ConversationID: conv.ID, Role: core.RoleUser, Parts: []core.Part{{Type: core.PartText, Text: "要求效率和成本都低于人工"}}} + if err := st.AppendMessageWithRequestAccountChecked("alice", false, &msg, "req-1"); err != nil { + t.Fatal(err) + } + called := 0 + slot := &projectWorkObserverSlot{} + observer := workObserverForTest() + observer.Observe = func(_ context.Context, source extension.WorkObservation) (extension.WorkObservationResult, error) { + called++ + if source.Owner != "alice" || source.Actor != "alice" || source.ProjectID != project.ID || source.SourceID != string(msg.ID) || source.Text != msg.Parts[0].Text || source.Scope != "private" { + t.Fatalf("provider received forged or wrong source: %+v", source) + } + return extension.WorkObservationResult{State: extension.WorkObservationAccepted, ReceiptID: "rdm-receipt-1"}, nil + } + if err := (pluginRegistry{pluginID: "rdm", caps: hostcaps{workObserver: slot}}).RegisterProjectWorkObserver(observer); err != nil { + t.Fatal(err) + } + denied := func(context.Context, string, core.ID) (bool, error) { return false, nil } + if _, err := deliverProjectWorkObservations(context.Background(), st, slot, denied, 10); err == nil || called != 0 { + t.Fatalf("revoked source was disclosed: calls=%d err=%v", called, err) + } + allowed := func(_ context.Context, actor string, id core.ID) (bool, error) { + return actor == "alice" && id == project.ID, nil + } + if delivered, err := deliverProjectWorkObservations(context.Background(), st, slot, allowed, 10); err != nil || delivered != 1 || called != 1 { + t.Fatalf("authorized source delivery failed: delivered=%d calls=%d err=%v", delivered, called, err) + } + if delivered, err := deliverProjectWorkObservations(context.Background(), st, slot, allowed, 10); err != nil || delivered != 0 || called != 1 { + t.Fatalf("delivered source was replayed without need: delivered=%d calls=%d err=%v", delivered, called, err) + } +} + func TestProjectWorkObservationRegistrationIsTrustedAndUnique(t *testing.T) { slot := &projectWorkObserverSlot{} trusted := pluginRegistry{pluginID: "rdm", caps: hostcaps{workObserver: slot}} diff --git a/internal/store/messages.go b/internal/store/messages.go index 061b24c..5cabdd7 100644 --- a/internal/store/messages.go +++ b/internal/store/messages.go @@ -48,6 +48,9 @@ func (s *Store) appendMessageWithRequest(m *core.Message, requestID, actor strin if m.ID == "" { m.ID = newID("msg") } + if m.CreatedAt.IsZero() { + m.CreatedAt = time.Now().UTC() + } m.CreatedAt = m.CreatedAt.UTC() insert := `INSERT INTO messages(id,conversation_id,run_id,role,parts,seq,created_at,request_id) SELECT ?,?,?,?,?,COALESCE(MAX(seq),0)+1,?,? FROM messages WHERE conversation_id=?` @@ -113,7 +116,10 @@ func (s *Store) appendMessageRows(tx *sql.Tx, m *core.Message, requestID, insert if err := s.dialect.lockConversation(tx, string(m.ConversationID)); err != nil { return err } - if _, err := tx.Exec(s.q(insert), m.ID, m.ConversationID, m.RunID, string(m.Role), marshalJSON(m.Parts), nowISO(), requestID, m.ConversationID); err != nil { + if _, err := tx.Exec(s.q(insert), m.ID, m.ConversationID, m.RunID, string(m.Role), marshalJSON(m.Parts), m.CreatedAt.Format(time.RFC3339Nano), requestID, m.ConversationID); err != nil { + return err + } + if err := s.appendProjectMessageObservationsTx(tx, m); err != nil { return err } _, err := tx.Exec(s.q(`UPDATE conversations SET updated_at=? WHERE id=?`), nowISO(), m.ConversationID) diff --git a/internal/store/migrate.go b/internal/store/migrate.go index 57e43a1..a773e0e 100644 --- a/internal/store/migrate.go +++ b/internal/store/migrate.go @@ -1085,6 +1085,15 @@ func init() { `DROP FUNCTION project_audit_writers_guarded(regclass)`, }, }}, + migration{version: 44, name: "project_work_observation_outbox", + up: map[string][]string{ + "sqlite": {`CREATE TABLE project_work_outbox (event_id TEXT PRIMARY KEY,owner TEXT NOT NULL,project_id TEXT NOT NULL,conversation_id TEXT NOT NULL,run_id TEXT NOT NULL DEFAULT '',source_kind TEXT NOT NULL,source_id TEXT NOT NULL,source_version TEXT NOT NULL,source_sha256 TEXT NOT NULL,part_index INTEGER NOT NULL,span_start INTEGER NOT NULL,span_end INTEGER NOT NULL,delivery TEXT NOT NULL,scope TEXT NOT NULL,observed_at TEXT NOT NULL,state TEXT NOT NULL DEFAULT 'pending',receipt_id TEXT NOT NULL DEFAULT '',UNIQUE(source_kind,source_id,part_index))`, `CREATE INDEX idx_project_work_outbox_pending ON project_work_outbox(state,observed_at,event_id)`}, + "postgres": {`CREATE TABLE project_work_outbox (event_id TEXT PRIMARY KEY,owner TEXT NOT NULL,project_id TEXT NOT NULL,conversation_id TEXT NOT NULL,run_id TEXT NOT NULL DEFAULT '',source_kind TEXT NOT NULL,source_id TEXT NOT NULL,source_version TEXT NOT NULL,source_sha256 TEXT NOT NULL,part_index INTEGER NOT NULL,span_start INTEGER NOT NULL,span_end INTEGER NOT NULL,delivery TEXT NOT NULL,scope TEXT NOT NULL,observed_at TEXT NOT NULL,state TEXT NOT NULL DEFAULT 'pending',receipt_id TEXT NOT NULL DEFAULT '',UNIQUE(source_kind,source_id,part_index))`, `CREATE INDEX idx_project_work_outbox_pending ON project_work_outbox(state,observed_at,event_id)`}, + }, + down: map[string][]string{ + "sqlite": {`DROP INDEX IF EXISTS idx_project_work_outbox_pending`, `DROP TABLE IF EXISTS project_work_outbox`}, + "postgres": {`DROP INDEX IF EXISTS idx_project_work_outbox_pending`, `DROP TABLE IF EXISTS project_work_outbox`}, + }}, ) } diff --git a/internal/store/migrate_compat.go b/internal/store/migrate_compat.go index b7623d5..97d8efd 100644 --- a/internal/store/migrate_compat.go +++ b/internal/store/migrate_compat.go @@ -48,6 +48,7 @@ var migrationBreaksOldReaders = map[int]bool{ 41: false, // project_audit_committed_links：新表，旧读者不受影响 42: false, // project_audit_committed_prefix：PG 审计 ID 默认函数，旧读者兼容 43: false, // project_audit_all_writers_guard：PG 在线审计写入门禁，旧读者兼容 + 44: false, // project_work_observation_outbox：独立私域投递表，旧读者不读取 } // SchemaTarget 是本二进制会迁移到的 schema 版本。 diff --git a/internal/store/project_work_outbox.go b/internal/store/project_work_outbox.go new file mode 100644 index 0000000..9f39c26 --- /dev/null +++ b/internal/store/project_work_outbox.go @@ -0,0 +1,181 @@ +package store + +import ( + "crypto/sha256" + "database/sql" + "encoding/hex" + "errors" + "fmt" + "time" + + core "agent-system-core" +) + +// ProjectWorkObservationRow is a private host delivery record. A project ID is +// a trusted locator here, not authorization to reveal the original message to +// other project members. The source body is fetched from the message row only +// for the current provider delivery and is never part of project audit DTOs. +type ProjectWorkObservationRow struct { + EventID string + Owner string + ProjectID string + ConversationID string + RunID string + SourceKind string + SourceID string + SourceVersion string + SourceSHA256 string + PartIndex int + SpanStart int + SpanEnd int + Delivery string + Scope string + ObservedAt time.Time + State string + ReceiptID string + Text string + Reason string +} + +func (s *Store) appendProjectMessageObservationsTx(tx *sql.Tx, m *core.Message) error { + if m == nil || (m.Role != core.RoleUser && m.Role != core.RoleAssistant) { + return nil + } + var owner, projectID string + if err := tx.QueryRow(s.q(`SELECT owner,project_id FROM conversations WHERE id=?`), m.ConversationID).Scan(&owner, &projectID); err != nil { + return err + } + if projectID == "" { + return nil + } + kind := string(m.Role) + "-message" + observed := m.CreatedAt.UTC().Format(time.RFC3339Nano) + for i, part := range m.Parts { + // A tool summary, artifact reference, card, or hidden thinking part is not + // evidence of the original resource body. The separate retrieval/tool + // adapters will supply their actual source IDs and spans later. + if part.Type == core.PartThinking { + continue + } + delivery, text := "partial", "" + var material []byte + if part.Type == core.PartText && part.Text != "" { + delivery, text = "complete", part.Text + material = []byte(text) + } else { + material = []byte(marshalJSON(part)) + } + hash := sha256.Sum256(material) + idDigest := sha256.Sum256([]byte(fmt.Sprintf("%s:%s:%d", kind, m.ID, i))) + eventID := "obs_" + hex.EncodeToString(idDigest[:16]) + if _, err := tx.Exec(s.q(`INSERT INTO project_work_outbox(event_id,owner,project_id,conversation_id,run_id,source_kind,source_id,source_version,source_sha256,part_index,span_start,span_end,delivery,scope,observed_at) + VALUES(?,?,?,?,?,?,?,?,?,?,?,?,?,?,?)`), eventID, owner, projectID, m.ConversationID, m.RunID, + kind, m.ID, m.ID, hex.EncodeToString(hash[:]), i, 0, len(text), delivery, "private", observed); err != nil { + return err + } + } + return nil +} + +// PendingProjectWorkObservations returns committed, not-yet-ACKed source parts. +// It rechecks that the immutable source bytes still match the recorded hash. +// Missing or changed source bytes become partial, never invented complete text. +func (s *Store) PendingProjectWorkObservations(limit int) ([]ProjectWorkObservationRow, error) { + if limit <= 0 || limit > 200 { + limit = 50 + } + rows, err := s.db.Query(s.q(`SELECT event_id,owner,project_id,conversation_id,run_id,source_kind,source_id,source_version,source_sha256,part_index,span_start,span_end,delivery,scope,observed_at,state,receipt_id + FROM project_work_outbox WHERE state='pending' ORDER BY observed_at,event_id LIMIT ?`), limit) + if err != nil { + return nil, err + } + out := make([]ProjectWorkObservationRow, 0, limit) + for rows.Next() { + var row ProjectWorkObservationRow + var observed string + if err := rows.Scan(&row.EventID, &row.Owner, &row.ProjectID, &row.ConversationID, &row.RunID, + &row.SourceKind, &row.SourceID, &row.SourceVersion, &row.SourceSHA256, &row.PartIndex, + &row.SpanStart, &row.SpanEnd, &row.Delivery, &row.Scope, &observed, &row.State, &row.ReceiptID); err != nil { + rows.Close() + return nil, err + } + row.ObservedAt, err = time.Parse(time.RFC3339Nano, observed) + if err != nil { + rows.Close() + return nil, err + } + out = append(out, row) + } + err = rows.Err() + rows.Close() + if err != nil { + return nil, err + } + for i := range out { + row := &out[i] + if row.Delivery != "complete" { + continue + } + msg, err := s.MessageByID(row.SourceID) + if errors.Is(err, ErrNotFound) { + row.Delivery, row.Reason = "partial", "source-missing" + continue + } + if err != nil { + return nil, err + } + if msg.ConversationID != core.ID(row.ConversationID) || row.PartIndex < 0 || row.PartIndex >= len(msg.Parts) || msg.Parts[row.PartIndex].Type != core.PartText { + row.Delivery, row.Reason = "partial", "source-changed" + continue + } + text := msg.Parts[row.PartIndex].Text + hash := sha256.Sum256([]byte(text)) + if hex.EncodeToString(hash[:]) != row.SourceSHA256 || row.SpanEnd != len(text) { + row.Delivery, row.Reason = "partial", "source-changed" + continue + } + row.Text = text + } + return out, nil +} + +// AckProjectWorkObservation records only the provider's durable intake receipt. +// It does not assert that source analysis, risk checks, or project publication +// finished. A different receipt for the same event is a conflict, not a retry. +func (s *Store) AckProjectWorkObservation(eventID, receiptID string) error { + return s.FinishProjectWorkObservation(eventID, receiptID, "accepted") +} + +// FinishProjectWorkObservation records the provider's terminal intake result. +// "accepted" is only durable receipt; "partial" and "denied" are truthful +// terminal treatment of this source part, not a project fact publication. +func (s *Store) FinishProjectWorkObservation(eventID, receiptID, state string) error { + if eventID == "" || receiptID == "" { + return errors.New("project work observation: empty event or receipt") + } + if state != "accepted" && state != "partial" && state != "denied" { + return errors.New("project work observation: invalid terminal state") + } + res, err := s.db.Exec(s.q(`UPDATE project_work_outbox SET state=?,receipt_id=? WHERE event_id=? AND state='pending'`), state, receiptID, eventID) + if err != nil { + return err + } + changed, err := res.RowsAffected() + if err != nil { + return err + } + if changed == 1 { + return nil + } + var currentReceipt, currentState string + if err := s.db.QueryRow(s.q(`SELECT receipt_id,state FROM project_work_outbox WHERE event_id=?`), eventID).Scan(¤tReceipt, ¤tState); err != nil { + if errors.Is(err, sql.ErrNoRows) { + return ErrNotFound + } + return err + } + if currentReceipt != receiptID || currentState != state { + return fmt.Errorf("project work observation: receipt conflict for %s", eventID) + } + return nil +} diff --git a/internal/store/project_work_outbox_test.go b/internal/store/project_work_outbox_test.go new file mode 100644 index 0000000..38c9b57 --- /dev/null +++ b/internal/store/project_work_outbox_test.go @@ -0,0 +1,124 @@ +package store + +import ( + "crypto/sha256" + "fmt" + "testing" + "time" + + core "agent-system-core" +) + +func TestProjectMessageOutboxFollowsCommittedMessage(t *testing.T) { + st := openTestStore(t) + if err := st.EnsureUser("alice", "Alice"); err != nil { + t.Fatal(err) + } + p, err := st.CreateProject("alice", "Project") + if err != nil { + t.Fatal(err) + } + projectConv, err := st.CreateConversation("alice", string(p.ID), "Work", "") + if err != nil { + t.Fatal(err) + } + privateConv, err := st.CreateConversation("alice", string(p.ID), "Private", "") + if err != nil { + t.Fatal(err) + } + msg := core.Message{ConversationID: projectConv.ID, Role: core.RoleUser, Parts: []core.Part{ + {Type: core.PartText, Text: "要求效率和成本都低于人工"}, + {Type: core.PartArtifactRef, Artifact: &core.ArtifactRef{ArtifactID: "file-1"}}, + }} + if err := st.AppendMessageWithRequestAccountChecked("alice", false, &msg, "request-1"); err != nil { + t.Fatal(err) + } + rows, err := st.PendingProjectWorkObservations(10) + if err != nil { + t.Fatal(err) + } + if len(rows) != 2 { + t.Fatalf("message and artifact parts were not each recorded: %+v", rows) + } + byPart := map[int]ProjectWorkObservationRow{} + for _, row := range rows { + byPart[row.PartIndex] = row + } + wantHash := fmt.Sprintf("%x", sha256.Sum256([]byte(msg.Parts[0].Text))) + textPart := byPart[0] + if textPart.ProjectID != string(p.ID) || textPart.Owner != "alice" || textPart.SourceID != string(msg.ID) || textPart.SourceSHA256 != wantHash || textPart.Text != msg.Parts[0].Text || textPart.Delivery != "complete" || textPart.RunID != "" { + t.Fatalf("incorrect trusted user message observation: %+v", textPart) + } + artifactPart := byPart[1] + if artifactPart.Delivery != "partial" || artifactPart.Text != "" || artifactPart.SourceID != string(msg.ID) { + t.Fatalf("unparsed attachment was presented as analyzed text: %+v", artifactPart) + } + run := core.Run{ConversationID: projectConv.ID, ProjectID: p.ID, Owner: "alice", Kind: core.RunConversation, Status: core.RunPending, Phase: core.PhaseThinking} + if err := st.CreateRun(&run); err != nil { + t.Fatal(err) + } + if err := st.SetMessageRunIDAccountChecked("alice", string(msg.ID), string(run.ID), false); err != nil { + t.Fatal(err) + } + linked, err := st.PendingProjectWorkObservations(10) + if err != nil || len(linked) != 2 || linked[0].RunID != string(run.ID) || linked[1].RunID != string(run.ID) { + t.Fatalf("later trusted run link was not saved for every source part: %+v %v", linked, err) + } + retry := core.Message{ConversationID: projectConv.ID, Role: core.RoleUser, Parts: []core.Part{{Type: core.PartText, Text: "changed"}}} + if err := st.AppendMessageWithRequestAccountChecked("alice", false, &retry, "request-1"); err == nil { + t.Fatal("duplicate request did not surface existing message") + } + private := core.Message{ConversationID: privateConv.ID, Role: core.RoleUser, Parts: []core.Part{{Type: core.PartText, Text: "private"}}} + if err := st.AppendMessageWithRequestAccountChecked("alice", false, &private, "request-2"); err != nil { + t.Fatal(err) + } + again, err := st.PendingProjectWorkObservations(10) + if err != nil || len(again) != 3 { + t.Fatalf("duplicate request generated an extra source or private source was lost: %+v %v", again, err) + } + for _, row := range again { + if row.Scope != "private" { + t.Fatalf("project locator alone changed a message's private scope: %+v", row) + } + } + if err := st.AckProjectWorkObservation(textPart.EventID, "receipt-1"); err != nil { + t.Fatal(err) + } + if err := st.AckProjectWorkObservation(textPart.EventID, "receipt-1"); err != nil { + t.Fatalf("same committed receipt was not idempotent: %v", err) + } + if err := st.AckProjectWorkObservation(textPart.EventID, "different"); err == nil { + t.Fatal("different observer receipt replaced the first one") + } + pending, err := st.PendingProjectWorkObservations(10) + if err != nil || len(pending) != 2 { + t.Fatalf("ACK did not remove only the delivered source: %+v %v", pending, err) + } +} + +func TestAssistantObservationCommitsOnlyWithFencedRunSettlement(t *testing.T) { + st := openTestStore(t) + conv := seedConversation(t, st) + run := seedRun(t, st, conv, core.RunRunning) + now := time.Now().UTC() + run.Status, run.Phase, run.EndedAt = core.RunCompleted, core.PhaseDone, &now + answer := core.Message{ConversationID: conv.ID, RunID: run.ID, Role: core.RoleAssistant, Parts: []core.Part{{Type: core.PartText, Text: "需要澄清效率的含义"}}} + updated, err := st.SettleRun(&run, &answer) + if err != nil || !updated { + t.Fatalf("run settlement failed: updated=%t err=%v", updated, err) + } + rows, err := st.PendingProjectWorkObservations(10) + if err != nil || len(rows) != 1 || rows[0].SourceKind != "assistant-message" || rows[0].SourceID != string(answer.ID) || rows[0].RunID != string(run.ID) || rows[0].Text != answer.Parts[0].Text { + t.Fatalf("final assistant observation was not committed with the run: %+v %v", rows, err) + } + secondRun := seedRun(t, st, conv, core.RunRunning) + secondRun.Status, secondRun.Phase, secondRun.EndedAt = core.RunCompleted, core.PhaseDone, &now + failed := core.Message{ID: answer.ID, ConversationID: conv.ID, RunID: secondRun.ID, Role: core.RoleAssistant, Parts: []core.Part{{Type: core.PartText, Text: "different"}}} + if _, err := st.SettleRun(&secondRun, &failed); err == nil { + t.Fatal("duplicate final message did not fail") + } + again, err := st.PendingProjectWorkObservations(10) + if err != nil || len(again) != 1 { + t.Fatalf("failed settlement added a second observation: %+v %v", again, err) + } +} diff --git a/internal/store/recovery.go b/internal/store/recovery.go index 6adfb0b..3674046 100644 --- a/internal/store/recovery.go +++ b/internal/store/recovery.go @@ -256,9 +256,15 @@ func (s *Store) settleRunOnce(r *core.Run, msg *core.Message, fence *fenceRef, a return false, false, err } if msg != nil { + if msg.CreatedAt.IsZero() { + msg.CreatedAt = time.Now().UTC() + } insert := `INSERT INTO messages(id,conversation_id,run_id,role,parts,seq,created_at,request_id) SELECT ?,?,?,?,?,COALESCE(MAX(seq),0)+1,?,? FROM messages WHERE conversation_id=?` - if _, err := tx.Exec(s.q(insert), msg.ID, msg.ConversationID, msg.RunID, string(msg.Role), marshalJSON(msg.Parts), nowISO(), "", msg.ConversationID); err != nil { + if _, err := tx.Exec(s.q(insert), msg.ID, msg.ConversationID, msg.RunID, string(msg.Role), marshalJSON(msg.Parts), msg.CreatedAt.UTC().Format(time.RFC3339Nano), "", msg.ConversationID); err != nil { + return false, false, err + } + if err := s.appendProjectMessageObservationsTx(tx, msg); err != nil { return false, false, err } if msg.VariantGroup != "" || msg.Excluded { diff --git a/internal/store/run_account_write.go b/internal/store/run_account_write.go index 2cefab7..636b086 100644 --- a/internal/store/run_account_write.go +++ b/internal/store/run_account_write.go @@ -96,6 +96,9 @@ func (s *Store) SetMessageRunIDAccountChecked(actor, messageID, runID string, al } else if n != 1 { return ErrNotFound } + if _, err := tx.Exec(s.q(`UPDATE project_work_outbox SET run_id=? WHERE source_kind='user-message' AND source_id=?`), runID, messageID); err != nil { + return err + } return nil }) } -- 2.54.0 From 928da87a9383f7f14d2c3f39a65832a1853f9b58 Mon Sep 17 00:00:00 2001 From: weichen Date: Wed, 14 Oct 2026 16:03:21 +0000 Subject: [PATCH 18/41] Require analyzed source manifests before project actions Why: A durable observation receipt must not be mistaken for completed risk analysis or permission to execute a project action. Evidence: Exact-source preflight tests cover pending versus proceed, partial attachment, post-ACK source tampering, current authorization, and receipt idempotency; go test -p 1 ./... and go build ./... passed. Impact: Add a fail-closed host preflight helper and per-message manifest read, still unwired to the public product path pending recovery and four-route coverage. Refs: TT-N03, TT-R01; approved X3 design r1 --- internal/app/project_work_observation.go | 88 ++++++++++++++++++- internal/app/project_work_observation_test.go | 67 ++++++++++++++ internal/store/project_work_outbox.go | 31 ++++++- internal/store/project_work_outbox_test.go | 4 + pkg/extension/project_work.go | 1 + 5 files changed, 188 insertions(+), 3 deletions(-) diff --git a/internal/app/project_work_observation.go b/internal/app/project_work_observation.go index c6bca54..cce3a94 100644 --- a/internal/app/project_work_observation.go +++ b/internal/app/project_work_observation.go @@ -2,6 +2,8 @@ package app import ( "context" + "crypto/sha256" + "encoding/json" "errors" "fmt" "sync" @@ -74,8 +76,17 @@ func deliverProjectWorkObservations(ctx context.Context, st *store.Store, slot * if err != nil { return 0, err } + return deliverProjectWorkRows(ctx, st, provider, work, rows) +} + +func deliverProjectWorkRows(ctx context.Context, st *store.Store, provider *extension.ProjectWorkObserver, + work func(context.Context, string, core.ID) (bool, error), rows []store.ProjectWorkObservationRow, +) (int, error) { completed := 0 for _, row := range rows { + if row.State != "pending" { + continue + } if err := ctx.Err(); err != nil { return completed, err } @@ -92,7 +103,7 @@ func deliverProjectWorkObservations(ctx context.Context, st *store.Store, slot * ProjectID: core.ID(row.ProjectID), ConversationID: core.ID(row.ConversationID), RunID: core.ID(row.RunID), SourceKind: row.SourceKind, SourceID: row.SourceID, SourceVersion: row.SourceVersion, SourceSHA256: row.SourceSHA256, PartIndex: row.PartIndex, SpanStart: row.SpanStart, SpanEnd: row.SpanEnd, - Text: row.Text, Scope: row.Scope, Delivery: row.Delivery, ObservedAt: row.ObservedAt, + Text: row.Text, Scope: row.Scope, Delivery: row.Delivery, DeliveryReason: row.Reason, ObservedAt: row.ObservedAt, } result, err := provider.Observe(ctx, observation) if err != nil { @@ -112,3 +123,78 @@ func deliverProjectWorkObservations(ctx context.Context, st *store.Store, slot * } return completed, nil } + +// preflightProjectMessage delivers this committed message's pending parts +// inline, then asks RDM to prove that every exact source part was analyzed for +// the pending action. A durable intake ACK alone never permits the action. +func preflightProjectMessage(ctx context.Context, st *store.Store, slot *projectWorkObserverSlot, + work func(context.Context, string, core.ID) (bool, error), messageID, action string, +) (extension.ProjectWorkDecision, error) { + pending := extension.ProjectWorkDecision{State: extension.ProjectWorkPending, Reason: "project source awaiting analysis"} + provider := slot.get() + if provider == nil || work == nil { + return pending, errors.New("extension: trusted project work observer unavailable") + } + rows, err := st.ProjectMessageObservations(messageID) + if err != nil { + return pending, err + } + if len(rows) == 0 { + return pending, errors.New("extension: committed project message has no source manifest") + } + if _, err := deliverProjectWorkRows(ctx, st, provider, work, rows); err != nil { + return pending, err + } + rows, err = st.ProjectMessageObservations(messageID) + if err != nil { + return pending, err + } + manifest := make([]extension.ProjectWorkSource, 0, len(rows)) + for _, row := range rows { + if row.State != "accepted" || row.Delivery != "complete" { + return pending, nil + } + manifest = append(manifest, extension.ProjectWorkSource{ + EventID: row.EventID, SourceKind: row.SourceKind, SourceID: row.SourceID, + SourceVersion: row.SourceVersion, SourceSHA256: row.SourceSHA256, PartIndex: row.PartIndex, + }) + } + first := rows[0] + for _, row := range rows[1:] { + if row.Owner != first.Owner || row.ProjectID != first.ProjectID || row.ConversationID != first.ConversationID { + return pending, errors.New("extension: mixed project source manifest") + } + } + conv, err := st.GetConversation(first.Owner, first.ConversationID) + if err != nil || string(conv.ProjectID) != first.ProjectID { + return pending, errors.New("extension: project binding changed before preflight") + } + allowed, err := work(ctx, first.Owner, conv.ProjectID) + if err != nil || !allowed { + return pending, errors.New("extension: current project work denied before preflight") + } + raw, err := json.Marshal(manifest) + if err != nil { + return pending, err + } + watermark := fmt.Sprintf("%x", sha256.Sum256(raw)) + decision, err := provider.Preflight(ctx, extension.ProjectWorkAction{ + Actor: first.Owner, Owner: first.Owner, ProjectID: conv.ProjectID, + ConversationID: conv.ID, RunID: core.ID(first.RunID), Action: action, + Manifest: manifest, SourceWatermark: watermark, + }) + if err != nil { + return pending, err + } + switch decision.State { + case extension.ProjectWorkProceed: + if decision.DecisionID == "" || decision.SourceWatermark != watermark { + return pending, errors.New("extension: project preflight decision did not bind current sources") + } + case extension.ProjectWorkClarify, extension.ProjectWorkPending, extension.ProjectWorkDenied: + // A non-proceed decision is a real result, never an implied approval. + default: + return pending, errors.New("extension: invalid project preflight decision") + } + return decision, nil +} diff --git a/internal/app/project_work_observation_test.go b/internal/app/project_work_observation_test.go index 079ab87..31e4fbb 100644 --- a/internal/app/project_work_observation_test.go +++ b/internal/app/project_work_observation_test.go @@ -73,6 +73,73 @@ func TestProjectWorkDeliveryRechecksCurrentAuthorityAndACKsOnce(t *testing.T) { } } +func TestProjectMessagePreflightRequiresAnalysisAndExactManifest(t *testing.T) { + st, err := store.OpenSQLite(filepath.Join(t.TempDir(), "preflight.db")) + if err != nil { + t.Fatal(err) + } + defer st.Close() + if err := st.EnsureUser("alice", "Alice"); err != nil { + t.Fatal(err) + } + project, err := st.CreateProject("alice", "P") + if err != nil { + t.Fatal(err) + } + conv, err := st.CreateConversation("alice", string(project.ID), "Work", "") + if err != nil { + t.Fatal(err) + } + msg := core.Message{ConversationID: conv.ID, Role: core.RoleUser, Parts: []core.Part{{Type: core.PartText, Text: "要求效率和成本都低于人工"}}} + if err := st.AppendMessageWithRequestAccountChecked("alice", false, &msg, "req-1"); err != nil { + t.Fatal(err) + } + ready, observations, decisions := false, 0, 0 + observer := workObserverForTest() + observer.Observe = func(context.Context, extension.WorkObservation) (extension.WorkObservationResult, error) { + observations++ + return extension.WorkObservationResult{State: extension.WorkObservationAccepted, ReceiptID: "intake-1"}, nil + } + observer.Preflight = func(_ context.Context, action extension.ProjectWorkAction) (extension.ProjectWorkDecision, error) { + decisions++ + if action.Actor != "alice" || action.ProjectID != project.ID || action.ConversationID != conv.ID || action.RunID != "" || action.Action != "conversation.run" || len(action.Manifest) != 1 { + t.Fatalf("preflight did not receive exact trusted source manifest: %+v", action) + } + if !ready { + return extension.ProjectWorkDecision{State: extension.ProjectWorkPending}, nil + } + return extension.ProjectWorkDecision{State: extension.ProjectWorkProceed, DecisionID: "decision-1", SourceWatermark: action.SourceWatermark}, nil + } + slot := &projectWorkObserverSlot{provider: &observer} + work := func(_ context.Context, actor string, id core.ID) (bool, error) { + return actor == "alice" && id == project.ID, nil + } + decision, err := preflightProjectMessage(context.Background(), st, slot, work, string(msg.ID), "conversation.run") + if err != nil || decision.State != extension.ProjectWorkPending || observations != 1 || decisions != 1 { + t.Fatalf("durable intake was confused with completed analysis: %+v observations=%d decisions=%d err=%v", decision, observations, decisions, err) + } + ready = true + decision, err = preflightProjectMessage(context.Background(), st, slot, work, string(msg.ID), "conversation.run") + if err != nil || decision.State != extension.ProjectWorkProceed || observations != 1 || decisions != 2 { + t.Fatalf("same source did not proceed after domain analysis: %+v observations=%d decisions=%d err=%v", decision, observations, decisions, err) + } + if _, err := st.DB().Exec(`UPDATE messages SET parts=? WHERE id=?`, `[{"type":"text","text":"changed"}]`, msg.ID); err != nil { + t.Fatal(err) + } + decision, err = preflightProjectMessage(context.Background(), st, slot, work, string(msg.ID), "conversation.run") + if err != nil || decision.State != extension.ProjectWorkPending || decisions != 2 { + t.Fatalf("source changed after ACK but stale decision still passed: %+v decisions=%d err=%v", decision, decisions, err) + } + partial := core.Message{ConversationID: conv.ID, Role: core.RoleUser, Parts: []core.Part{{Type: core.PartArtifactRef, Artifact: &core.ArtifactRef{ArtifactID: "file-1"}}}} + if err := st.AppendMessageWithRequestAccountChecked("alice", false, &partial, "req-2"); err != nil { + t.Fatal(err) + } + decision, err = preflightProjectMessage(context.Background(), st, slot, work, string(partial.ID), "conversation.run") + if err != nil || decision.State != extension.ProjectWorkPending || decisions != 2 { + t.Fatalf("partial attachment reached project action preflight: %+v decisions=%d err=%v", decision, decisions, err) + } +} + func TestProjectWorkObservationRegistrationIsTrustedAndUnique(t *testing.T) { slot := &projectWorkObserverSlot{} trusted := pluginRegistry{pluginID: "rdm", caps: hostcaps{workObserver: slot}} diff --git a/internal/store/project_work_outbox.go b/internal/store/project_work_outbox.go index 9f39c26..de1a6dd 100644 --- a/internal/store/project_work_outbox.go +++ b/internal/store/project_work_outbox.go @@ -81,11 +81,38 @@ func (s *Store) appendProjectMessageObservationsTx(tx *sql.Tx, m *core.Message) // It rechecks that the immutable source bytes still match the recorded hash. // Missing or changed source bytes become partial, never invented complete text. func (s *Store) PendingProjectWorkObservations(limit int) ([]ProjectWorkObservationRow, error) { + return s.projectWorkObservations("", limit) +} + +// ProjectMessageObservations returns every committed part of one message, +// including already-ACKed parts, for an action's exact source manifest. +func (s *Store) ProjectMessageObservations(messageID string) ([]ProjectWorkObservationRow, error) { + if messageID == "" { + return nil, errors.New("project work observation: empty message ID") + } + var count int + if err := s.db.QueryRow(s.q(`SELECT COUNT(*) FROM project_work_outbox WHERE source_id=?`), messageID).Scan(&count); err != nil { + return nil, err + } + if count > 200 { + return nil, errors.New("project work observation: message parts exceed safe preflight limit") + } + return s.projectWorkObservations(messageID, 200) +} + +func (s *Store) projectWorkObservations(messageID string, limit int) ([]ProjectWorkObservationRow, error) { if limit <= 0 || limit > 200 { limit = 50 } - rows, err := s.db.Query(s.q(`SELECT event_id,owner,project_id,conversation_id,run_id,source_kind,source_id,source_version,source_sha256,part_index,span_start,span_end,delivery,scope,observed_at,state,receipt_id - FROM project_work_outbox WHERE state='pending' ORDER BY observed_at,event_id LIMIT ?`), limit) + query := `SELECT event_id,owner,project_id,conversation_id,run_id,source_kind,source_id,source_version,source_sha256,part_index,span_start,span_end,delivery,scope,observed_at,state,receipt_id + FROM project_work_outbox WHERE state='pending' ORDER BY observed_at,event_id LIMIT ?` + args := []any{limit} + if messageID != "" { + query = `SELECT event_id,owner,project_id,conversation_id,run_id,source_kind,source_id,source_version,source_sha256,part_index,span_start,span_end,delivery,scope,observed_at,state,receipt_id + FROM project_work_outbox WHERE source_id=? ORDER BY part_index LIMIT ?` + args = []any{messageID, limit} + } + rows, err := s.db.Query(s.q(query), args...) if err != nil { return nil, err } diff --git a/internal/store/project_work_outbox_test.go b/internal/store/project_work_outbox_test.go index 38c9b57..377b4f6 100644 --- a/internal/store/project_work_outbox_test.go +++ b/internal/store/project_work_outbox_test.go @@ -84,6 +84,10 @@ func TestProjectMessageOutboxFollowsCommittedMessage(t *testing.T) { if err := st.AckProjectWorkObservation(textPart.EventID, "receipt-1"); err != nil { t.Fatal(err) } + allParts, err := st.ProjectMessageObservations(string(msg.ID)) + if err != nil || len(allParts) != 2 { + t.Fatalf("ACK erased exact action source manifest: %+v %v", allParts, err) + } if err := st.AckProjectWorkObservation(textPart.EventID, "receipt-1"); err != nil { t.Fatalf("same committed receipt was not idempotent: %v", err) } diff --git a/pkg/extension/project_work.go b/pkg/extension/project_work.go index 7aea802..85c66c6 100644 --- a/pkg/extension/project_work.go +++ b/pkg/extension/project_work.go @@ -29,6 +29,7 @@ type WorkObservation struct { Text string `json:"text,omitempty"` // only the actual authorized fragment Scope string `json:"scope"` // private|project|controlled Delivery string `json:"delivery"` // complete|summary-only|partial + DeliveryReason string `json:"deliveryReason,omitempty"` AuthorizationEpoch string `json:"authorizationEpoch"` ObservedAt time.Time `json:"observedAt"` } -- 2.54.0 From 7cee124b8fa6ae3c8b9eb158ff3143ecacd7b92c Mon Sep 17 00:00:00 2001 From: weichen Date: Wed, 14 Oct 2026 16:25:22 +0000 Subject: [PATCH 19/41] Capture actual project work sources before reuse Why: Project retrieval hits, tool results, and saved visible analysis must be individually traceable and fully analyzed before later project actions consume them. Evidence: RED tests first showed missing run-source capture, tool-result capture, and run-wide preflight; go test -p 1 ./... and go build ./... passed; isolated PostgreSQL source, migration, audit, and context tests passed. Impact: Persist actual run-bound sources with current-status checks and exact manifests behind the disabled X3 assembly gate; no live product path, migration, deployment, or release is enabled. Refs: TT-N03, TT-R01; approved X3 stage-five plan r1 --- internal/app/project_work_observation.go | 138 ++++++++++++++- internal/app/project_work_observation_test.go | 163 ++++++++++++++++++ .../runmgr/project_work_retrieval_test.go | 58 +++++++ .../runmgr/project_work_tool_result_test.go | 30 ++++ internal/runmgr/runmgr.go | 53 ++++++ internal/store/migrate.go | 4 +- internal/store/project_work_outbox.go | 152 ++++++++++++++-- internal/store/project_work_outbox_test.go | 20 ++- .../store/project_work_run_source_test.go | 52 ++++++ internal/store/project_work_source_status.go | 28 +++ pkg/extension/project_work.go | 41 ++--- 11 files changed, 692 insertions(+), 47 deletions(-) create mode 100644 internal/runmgr/project_work_retrieval_test.go create mode 100644 internal/runmgr/project_work_tool_result_test.go create mode 100644 internal/store/project_work_run_source_test.go create mode 100644 internal/store/project_work_source_status.go diff --git a/internal/app/project_work_observation.go b/internal/app/project_work_observation.go index cce3a94..39d1999 100644 --- a/internal/app/project_work_observation.go +++ b/internal/app/project_work_observation.go @@ -66,7 +66,7 @@ func (r recordRegistry) RegisterProjectWorkObserver(p extension.ProjectWorkObser // An Observe ACK is an intake receipt, not a preflight or publication decision. // Failures leave the row pending for a later idempotent retry. func deliverProjectWorkObservations(ctx context.Context, st *store.Store, slot *projectWorkObserverSlot, - work func(context.Context, string, core.ID) (bool, error), limit int, + work func(context.Context, string, core.ID) (bool, error), limit int, verify ...func(context.Context, store.ProjectWorkObservationRow) error, ) (int, error) { provider := slot.get() if provider == nil || work == nil { @@ -76,17 +76,26 @@ func deliverProjectWorkObservations(ctx context.Context, st *store.Store, slot * if err != nil { return 0, err } - return deliverProjectWorkRows(ctx, st, provider, work, rows) + return deliverProjectWorkRows(ctx, st, provider, work, rows, verify...) } func deliverProjectWorkRows(ctx context.Context, st *store.Store, provider *extension.ProjectWorkObserver, work func(context.Context, string, core.ID) (bool, error), rows []store.ProjectWorkObservationRow, + verify ...func(context.Context, store.ProjectWorkObservationRow) error, ) (int, error) { completed := 0 for _, row := range rows { if row.State != "pending" { continue } + if row.SourceKind != "user-message" && row.SourceKind != "assistant-message" { + if len(verify) != 1 || verify[0] == nil { + return completed, fmt.Errorf("project work source %s: current resource status verifier unavailable", row.EventID) + } + if err := verify[0](ctx, row); err != nil { + return completed, err + } + } if err := ctx.Err(); err != nil { return completed, err } @@ -103,7 +112,7 @@ func deliverProjectWorkRows(ctx context.Context, st *store.Store, provider *exte ProjectID: core.ID(row.ProjectID), ConversationID: core.ID(row.ConversationID), RunID: core.ID(row.RunID), SourceKind: row.SourceKind, SourceID: row.SourceID, SourceVersion: row.SourceVersion, SourceSHA256: row.SourceSHA256, PartIndex: row.PartIndex, SpanStart: row.SpanStart, SpanEnd: row.SpanEnd, - Text: row.Text, Scope: row.Scope, Delivery: row.Delivery, DeliveryReason: row.Reason, ObservedAt: row.ObservedAt, + Text: row.Text, Scope: row.Scope, Delivery: row.Delivery, DeliveryReason: row.Reason, Metadata: row.Metadata, ObservedAt: row.ObservedAt, } result, err := provider.Observe(ctx, observation) if err != nil { @@ -124,6 +133,52 @@ func deliverProjectWorkRows(ctx context.Context, st *store.Store, provider *exte return completed, nil } +func verifyProjectKnowledgeObservation(_ context.Context, caps hostcaps, row store.ProjectWorkObservationRow) error { + if row.SourceKind != "retrieval-hit" || caps.st == nil { + return errors.New("project work source: unsupported resource verification") + } + doc, err := caps.st.ProjectWorkKnowledgeSource(row.SourceID) + if err != nil { + return errors.New("project work source: current knowledge source unavailable") + } + hash := sha256.Sum256([]byte(doc.Chunk)) + actualHash := fmt.Sprintf("%x", hash) + if actualHash != row.SourceVersion || actualHash != row.SourceSHA256 || doc.Chunk != row.Text || + (row.Metadata["ref"] != "" && row.Metadata["ref"] != doc.Ref) || + (row.Metadata["source"] != "" && row.Metadata["source"] != doc.Source) || + (doc.ProjectID != "" && string(doc.ProjectID) != row.ProjectID) { + return errors.New("project work source: knowledge version or scope changed") + } + if caps.authz != nil && caps.authz.hasV2() { + allowed, err := caps.authz.AuthorizeResource(extension.ResourceAuthzQuery{ + Actor: row.Owner, Action: "model-context", ResourceType: "knowledge", ResourceID: doc.ID, + Owner: string(doc.Owner), ProjectID: doc.ProjectID, Source: doc.Source, + }) + if err != nil || !allowed { + return errors.New("project work source: current knowledge authorization denied") + } + } else if string(doc.Owner) != row.Owner { + return errors.New("project work source: shared knowledge authorization unavailable") + } + return nil +} + +// A transient tool result has no external source authority to recheck. Its +// committed private outbox bytes and stored run are the only reliable source; +// RDM must keep it a candidate until a separately verifiable evidence source +// or human confirmation supports a formal project claim. +func verifyProjectTransientObservation(_ context.Context, st *store.Store, row store.ProjectWorkObservationRow) error { + if row.SourceKind != "tool-result" || row.Metadata["sourceStatus"] != "transient" || + row.Metadata["toolName"] == "" || row.RunID == "" { + return errors.New("project work source: transient result lacks trusted provenance") + } + run, err := st.GetRunByID(core.ID(row.RunID)) + if err != nil || string(run.Owner) != row.Owner || string(run.ProjectID) != row.ProjectID || string(run.ConversationID) != row.ConversationID { + return errors.New("project work source: transient run binding unavailable") + } + return nil +} + // preflightProjectMessage delivers this committed message's pending parts // inline, then asks RDM to prove that every exact source part was analyzed for // the pending action. A durable intake ACK alone never permits the action. @@ -198,3 +253,80 @@ func preflightProjectMessage(ctx context.Context, st *store.Store, slot *project } return decision, nil } + +// preflightProjectRun binds all committed user, retrieval, tool, and visible +// analysis parts of one run before a later model or business action consumes +// them. Missing/partial parts keep the action pending. The domain provider +// decides whether the complete source set contains a blocking risk. +func preflightProjectRun(ctx context.Context, st *store.Store, slot *projectWorkObserverSlot, + work func(context.Context, string, core.ID) (bool, error), verify func(context.Context, store.ProjectWorkObservationRow) error, + runID, action string, +) (extension.ProjectWorkDecision, error) { + pending := extension.ProjectWorkDecision{State: extension.ProjectWorkPending, Reason: "run sources awaiting analysis"} + provider := slot.get() + if provider == nil || work == nil || verify == nil { + return pending, errors.New("extension: trusted project run observer unavailable") + } + run, err := st.GetRunByID(core.ID(runID)) + if err != nil || run.ProjectID == "" { + return pending, errors.New("extension: trusted project run unavailable") + } + rows, err := st.ProjectRunObservations(runID) + if err != nil { + return pending, err + } + if len(rows) == 0 { + return pending, errors.New("extension: project run has no trusted source manifest") + } + if _, err := deliverProjectWorkRows(ctx, st, provider, work, rows, verify); err != nil { + return pending, err + } + rows, err = st.ProjectRunObservations(runID) + if err != nil { + return pending, err + } + manifest := make([]extension.ProjectWorkSource, 0, len(rows)) + for _, row := range rows { + if row.State != "accepted" || row.Delivery != "complete" { + return pending, nil + } + if row.RunID != runID || row.Owner != string(run.Owner) || row.ProjectID != string(run.ProjectID) || row.ConversationID != string(run.ConversationID) { + return pending, errors.New("extension: mixed run source manifest") + } + manifest = append(manifest, extension.ProjectWorkSource{ + EventID: row.EventID, SourceKind: row.SourceKind, SourceID: row.SourceID, + SourceVersion: row.SourceVersion, SourceSHA256: row.SourceSHA256, PartIndex: row.PartIndex, + }) + } + conv, err := st.GetConversation(string(run.Owner), string(run.ConversationID)) + if err != nil || conv.ProjectID != run.ProjectID { + return pending, errors.New("extension: run project binding changed before preflight") + } + allowed, err := work(ctx, string(run.Owner), run.ProjectID) + if err != nil || !allowed { + return pending, errors.New("extension: current run project work denied") + } + raw, err := json.Marshal(manifest) + if err != nil { + return pending, err + } + watermark := fmt.Sprintf("%x", sha256.Sum256(raw)) + decision, err := provider.Preflight(ctx, extension.ProjectWorkAction{ + Actor: string(run.Owner), Owner: string(run.Owner), ProjectID: run.ProjectID, + ConversationID: run.ConversationID, RunID: run.ID, Action: action, + Manifest: manifest, SourceWatermark: watermark, + }) + if err != nil { + return pending, err + } + switch decision.State { + case extension.ProjectWorkProceed: + if decision.DecisionID == "" || decision.SourceWatermark != watermark { + return pending, errors.New("extension: run preflight decision did not bind current sources") + } + case extension.ProjectWorkClarify, extension.ProjectWorkPending, extension.ProjectWorkDenied: + default: + return pending, errors.New("extension: invalid project run preflight decision") + } + return decision, nil +} diff --git a/internal/app/project_work_observation_test.go b/internal/app/project_work_observation_test.go index 31e4fbb..7e94bd5 100644 --- a/internal/app/project_work_observation_test.go +++ b/internal/app/project_work_observation_test.go @@ -2,6 +2,8 @@ package app import ( "context" + "crypto/sha256" + "fmt" "path/filepath" "testing" @@ -140,6 +142,167 @@ func TestProjectMessagePreflightRequiresAnalysisAndExactManifest(t *testing.T) { } } +func TestRetrievalObservationRechecksCurrentSourceBeforeDisclosure(t *testing.T) { + st, err := store.OpenSQLite(filepath.Join(t.TempDir(), "source.db")) + if err != nil { + t.Fatal(err) + } + defer st.Close() + if err := st.EnsureUser("alice", "Alice"); err != nil { + t.Fatal(err) + } + project, err := st.CreateProject("alice", "P") + if err != nil { + t.Fatal(err) + } + conv, err := st.CreateConversation("alice", string(project.ID), "Work", "") + if err != nil { + t.Fatal(err) + } + run := core.Run{ConversationID: conv.ID, ProjectID: project.ID, Owner: "alice", Kind: core.RunConversation, Status: core.RunRunning, Phase: core.PhaseThinking} + if err := st.CreateRun(&run); err != nil { + t.Fatal(err) + } + doc := core.KnowledgeDoc{ID: "knowledge-1", Owner: "alice", ProjectID: project.ID, Source: "upload", Ref: "https://example.test/a", Chunk: "actual source"} + if err := st.AddKnowledge(doc); err != nil { + t.Fatal(err) + } + observation := store.RunWorkObservationInput{RunID: string(run.ID), SourceKind: "retrieval-hit", SourceID: string(doc.ID), + SourceVersion: fmt.Sprintf("%x", sha256.Sum256([]byte(doc.Chunk))), Text: doc.Chunk, Delivery: "complete", + Metadata: map[string]string{"ref": doc.Ref, "source": doc.Source}} + if _, err := st.AppendRunWorkObservation(observation); err != nil { + t.Fatal(err) + } + called := 0 + provider := workObserverForTest() + provider.Observe = func(context.Context, extension.WorkObservation) (extension.WorkObservationResult, error) { + called++ + return extension.WorkObservationResult{State: extension.WorkObservationAccepted, ReceiptID: "rdm-1"}, nil + } + slot := &projectWorkObserverSlot{provider: &provider} + work := func(context.Context, string, core.ID) (bool, error) { return true, nil } + verify := func(ctx context.Context, row store.ProjectWorkObservationRow) error { + return verifyProjectKnowledgeObservation(ctx, hostcaps{st: st}, row) + } + if n, err := deliverProjectWorkObservations(context.Background(), st, slot, work, 10, verify); err != nil || n != 1 || called != 1 { + t.Fatalf("current owned source was not delivered: n=%d calls=%d err=%v", n, called, err) + } + if _, err := st.AppendRunWorkObservation(observation); err != nil { + t.Fatal(err) + } + if _, err := st.DB().Exec(`DELETE FROM knowledge WHERE id=?`, doc.ID); err != nil { + t.Fatal(err) + } + if n, err := deliverProjectWorkObservations(context.Background(), st, slot, work, 10, verify); err == nil || n != 0 || called != 1 { + t.Fatalf("deleted source text crossed into observer: n=%d calls=%d err=%v", n, called, err) + } +} + +func TestTransientToolSourceKeepsCurrentRunAndCandidateStatus(t *testing.T) { + st, err := store.OpenSQLite(filepath.Join(t.TempDir(), "tool.db")) + if err != nil { + t.Fatal(err) + } + defer st.Close() + if err := st.EnsureUser("alice", "Alice"); err != nil { + t.Fatal(err) + } + project, err := st.CreateProject("alice", "P") + if err != nil { + t.Fatal(err) + } + conv, err := st.CreateConversation("alice", string(project.ID), "Work", "") + if err != nil { + t.Fatal(err) + } + run := core.Run{ConversationID: conv.ID, ProjectID: project.ID, Owner: "alice", Kind: core.RunConversation, Status: core.RunRunning, Phase: core.PhaseThinking} + if err := st.CreateRun(&run); err != nil { + t.Fatal(err) + } + _, err = st.AppendRunWorkObservation(store.RunWorkObservationInput{RunID: string(run.ID), SourceKind: "tool-result", SourceID: "call-1", SourceVersion: "v1", + Text: "实际工具返回", Delivery: "complete", Metadata: map[string]string{"sourceStatus": "transient", "toolName": "lookup"}}) + if err != nil { + t.Fatal(err) + } + rows, err := st.PendingProjectWorkObservations(10) + if err != nil || len(rows) != 1 { + t.Fatalf("tool source missing: %+v %v", rows, err) + } + if err := verifyProjectTransientObservation(context.Background(), st, rows[0]); err != nil { + t.Fatalf("committed private tool source rejected: %v", err) + } + if _, err := st.DB().Exec(`DELETE FROM runs WHERE id=?`, run.ID); err != nil { + t.Fatal(err) + } + if err := verifyProjectTransientObservation(context.Background(), st, rows[0]); err == nil { + t.Fatal("deleted run still authorized its transient source") + } +} + +func TestRunPreflightWaitsForAllCommittedSourceParts(t *testing.T) { + st, err := store.OpenSQLite(filepath.Join(t.TempDir(), "run-preflight.db")) + if err != nil { + t.Fatal(err) + } + defer st.Close() + if err := st.EnsureUser("alice", "Alice"); err != nil { + t.Fatal(err) + } + project, err := st.CreateProject("alice", "P") + if err != nil { + t.Fatal(err) + } + conv, err := st.CreateConversation("alice", string(project.ID), "Work", "") + if err != nil { + t.Fatal(err) + } + run := core.Run{ConversationID: conv.ID, ProjectID: project.ID, Owner: "alice", Kind: core.RunConversation, Status: core.RunRunning, Phase: core.PhaseThinking} + if err := st.CreateRun(&run); err != nil { + t.Fatal(err) + } + msg := core.Message{ConversationID: conv.ID, Role: core.RoleUser, Parts: []core.Part{{Type: core.PartText, Text: "检查成本和效率"}}} + if err := st.AppendMessageWithRequestAccountChecked("alice", false, &msg, "req"); err != nil { + t.Fatal(err) + } + if err := st.SetMessageRunIDAccountChecked("alice", string(msg.ID), string(run.ID), false); err != nil { + t.Fatal(err) + } + if _, err := st.AppendRunWorkObservation(store.RunWorkObservationInput{RunID: string(run.ID), SourceKind: "tool-result", SourceID: "call-1", + SourceVersion: "v1", Text: "工具中的测量结果", Delivery: "complete", Metadata: map[string]string{"sourceStatus": "transient", "toolName": "measure"}}); err != nil { + t.Fatal(err) + } + ready, preflights, observed := false, 0, 0 + provider := workObserverForTest() + provider.Observe = func(context.Context, extension.WorkObservation) (extension.WorkObservationResult, error) { + observed++ + return extension.WorkObservationResult{State: extension.WorkObservationAccepted, ReceiptID: fmt.Sprintf("receipt-%d", observed)}, nil + } + provider.Preflight = func(_ context.Context, action extension.ProjectWorkAction) (extension.ProjectWorkDecision, error) { + preflights++ + if action.RunID != run.ID || action.ProjectID != project.ID || len(action.Manifest) != 2 { + t.Fatalf("run manifest omitted a committed source: %+v", action) + } + if !ready { + return extension.ProjectWorkDecision{State: extension.ProjectWorkPending}, nil + } + return extension.ProjectWorkDecision{State: extension.ProjectWorkProceed, DecisionID: "approved-risk-check", SourceWatermark: action.SourceWatermark}, nil + } + slot := &projectWorkObserverSlot{provider: &provider} + work := func(context.Context, string, core.ID) (bool, error) { return true, nil } + verify := func(ctx context.Context, row store.ProjectWorkObservationRow) error { + return verifyProjectTransientObservation(ctx, st, row) + } + decision, err := preflightProjectRun(context.Background(), st, slot, work, verify, string(run.ID), "model.consume.tool") + if err != nil || decision.State != extension.ProjectWorkPending || observed != 2 || preflights != 1 { + t.Fatalf("intake ACK was mistaken for finished risk analysis: %+v observed=%d preflights=%d err=%v", decision, observed, preflights, err) + } + ready = true + decision, err = preflightProjectRun(context.Background(), st, slot, work, verify, string(run.ID), "model.consume.tool") + if err != nil || decision.State != extension.ProjectWorkProceed || observed != 2 || preflights != 2 { + t.Fatalf("fully analyzed run was not released once: %+v observed=%d preflights=%d err=%v", decision, observed, preflights, err) + } +} + func TestProjectWorkObservationRegistrationIsTrustedAndUnique(t *testing.T) { slot := &projectWorkObserverSlot{} trusted := pluginRegistry{pluginID: "rdm", caps: hostcaps{workObserver: slot}} diff --git a/internal/runmgr/project_work_retrieval_test.go b/internal/runmgr/project_work_retrieval_test.go new file mode 100644 index 0000000..c40bca8 --- /dev/null +++ b/internal/runmgr/project_work_retrieval_test.go @@ -0,0 +1,58 @@ +package runmgr + +import ( + "context" + "path/filepath" + "testing" + + "agent-system-backend/internal/store" + core "agent-system-core" +) + +func TestProjectRetrievalRecordsEachActualAuthorizedHit(t *testing.T) { + st, err := store.OpenSQLite(filepath.Join(t.TempDir(), "retrieval.db")) + if err != nil { + t.Fatal(err) + } + defer st.Close() + if err := st.EnsureUser("alice", "Alice"); err != nil { + t.Fatal(err) + } + project, err := st.CreateProject("alice", "P") + if err != nil { + t.Fatal(err) + } + conv, err := st.CreateConversation("alice", string(project.ID), "Work", "") + if err != nil { + t.Fatal(err) + } + run := core.Run{ConversationID: conv.ID, ProjectID: project.ID, Owner: "alice", Kind: core.RunConversation, Status: core.RunRunning, Phase: core.PhaseThinking} + if err := st.CreateRun(&run); err != nil { + t.Fatal(err) + } + mgr := New(st, nil, nil, nil, nil, nil, nil, nil, nil) + fr := &sharedFakeRetriever{own: []core.RetrievalHit{ + {Doc: core.KnowledgeDoc{ID: "k1", Owner: "alice", ProjectID: project.ID, Ref: "https://example.test/a", Chunk: "source A"}, Kind: "fulltext"}, + {Doc: core.KnowledgeDoc{ID: "k2", Owner: "alice", ProjectID: project.ID, Ref: "https://example.test/b", Chunk: "source B"}, Kind: "fulltext"}, + }} + mgr.SetRetriever(fr) + mgr.SetProjectWorkObservationEnabled(true) + rc := &runCtx{mgr: mgr, run: run, ctx: context.Background()} + hits, err := rc.Retrieve(core.RetrievalQuery{Text: "test", ProjectID: project.ID}) + if err != nil || len(hits) != 2 { + t.Fatalf("authorized results not returned: %+v %v", hits, err) + } + rows, err := st.PendingProjectWorkObservations(10) + if err != nil || len(rows) != 2 { + t.Fatalf("actual hits not individually captured: %+v %v", rows, err) + } + for _, row := range rows { + if row.SourceKind != "retrieval-hit" || row.Owner != "alice" || row.RunID != string(run.ID) || row.Metadata["query"] != "test" || row.Text == "" { + t.Fatalf("retrieval source missing trusted identity or actual text: %+v", row) + } + } + fr.own = []core.RetrievalHit{{Doc: core.KnowledgeDoc{Chunk: "no stable ID"}}} + if hits, err := rc.Retrieve(core.RetrievalQuery{Text: "test", ProjectID: project.ID}); err == nil || hits != nil { + t.Fatalf("source without stable ID entered model input: %+v %v", hits, err) + } +} diff --git a/internal/runmgr/project_work_tool_result_test.go b/internal/runmgr/project_work_tool_result_test.go new file mode 100644 index 0000000..0e55463 --- /dev/null +++ b/internal/runmgr/project_work_tool_result_test.go @@ -0,0 +1,30 @@ +package runmgr + +import ( + "testing" + + core "agent-system-core" +) + +func TestProjectToolResultRecordsActualOutputBeforeModelUse(t *testing.T) { + rc, st := newExecEnv(t) + run := core.Run{ConversationID: rc.run.ConversationID, ProjectID: rc.run.ProjectID, Owner: rc.run.Owner, + Kind: core.RunConversation, Status: core.RunRunning, Phase: core.PhaseThinking} + if err := st.CreateRun(&run); err != nil { + t.Fatal(err) + } + rc.run = run + rc.mgr.SetProjectWorkObservationEnabled(true) + result := rc.ExecuteTool(core.ToolCallRequest{CallID: "tool-1", Name: "time_now", Arguments: []byte(`{}`)}) + if result.Status != "ok" || result.Output == "" { + t.Fatalf("tool did not return its actual output: %+v", result) + } + rows, err := st.PendingProjectWorkObservations(10) + if err != nil || len(rows) != 1 || rows[0].SourceKind != "tool-result" || rows[0].SourceID != "tool-1" || rows[0].Text != result.Output || rows[0].Metadata["toolName"] != "time_now" { + t.Fatalf("actual tool output was not captured before return: %+v %v", rows, err) + } + missingID := rc.ExecuteTool(core.ToolCallRequest{Name: "time_now", Arguments: []byte(`{}`)}) + if missingID.Status != "error" { + t.Fatalf("tool output without stable call ID reached model: %+v", missingID) + } +} diff --git a/internal/runmgr/runmgr.go b/internal/runmgr/runmgr.go index af3b4ed..dd63275 100644 --- a/internal/runmgr/runmgr.go +++ b/internal/runmgr/runmgr.go @@ -5,6 +5,8 @@ package runmgr import ( "context" + "crypto/sha256" + "encoding/hex" "encoding/json" "errors" "fmt" @@ -67,6 +69,7 @@ type Manager struct { projectContextResolver func(context.Context, extension.ProjectContextRequest) (extension.ProjectContextBundle, error) projectEvidenceReader func(context.Context, extension.ProjectEvidenceRequest) (extension.ProjectEvidence, error) projectSourceRechecker func(context.Context, extension.ProjectContextSourceRecheckRequest) (extension.ProjectContextSourceRecheckResult, error) + projectWorkObservationEnabled bool // commands EXT-14：命令即工具的投影与分发源（nil = 未接线，命令不进工具清单）。 commands CommandSource indexer core.DocumentIndexer // 可选索引入口（nil = store 整文档单块） @@ -292,6 +295,13 @@ func (m *Manager) SetProjectWorkAuthorization(fn func(context.Context, string, c m.projectWorkAuthorization = fn } +// SetProjectWorkObservationEnabled is set at startup after the trusted +// observer/preflight path is assembled. The disabled default preserves older +// hosts and cannot be mistaken for successful source treatment. +func (m *Manager) SetProjectWorkObservationEnabled(enabled bool) { + m.projectWorkObservationEnabled = enabled +} + // SetAccountEffectiveAuthorization binds the current account-state guard. It is // independent of the optional domain project provider. func (m *Manager) SetAccountEffectiveAuthorization(fn func(context.Context, string) (bool, error), allowImplicitLocal ...bool) { @@ -1143,6 +1153,29 @@ func indexTextOf(name, mime string, content []byte) string { } func (c *runCtx) Retrieve(q core.RetrievalQuery) ([]core.RetrievalHit, error) { + hits, err := c.retrieveRaw(q) + if err != nil || !c.mgr.projectWorkObservationEnabled || c.run.ProjectID == "" { + return hits, err + } + for _, hit := range hits { + if hit.Doc.ID == "" { + return nil, errors.New("project retrieval hit lacks a stable source ID") + } + hash := sha256.Sum256([]byte(hit.Doc.Chunk)) + _, err := c.mgr.st.AppendRunWorkObservation(store.RunWorkObservationInput{ + RunID: string(c.run.ID), SourceKind: "retrieval-hit", SourceID: string(hit.Doc.ID), + SourceVersion: hex.EncodeToString(hash[:]), Text: hit.Doc.Chunk, Delivery: "complete", + Metadata: map[string]string{"query": q.Text, "ref": hit.Doc.Ref, "title": hit.Doc.Title, + "source": hit.Doc.Source, "hitKind": hit.Kind, "retrievedAt": time.Now().UTC().Format(time.RFC3339Nano)}, + }) + if err != nil { + return nil, err + } + } + return hits, nil +} + +func (c *runCtx) retrieveRaw(q core.RetrievalQuery) ([]core.RetrievalHit, error) { if q.TopK <= 0 { q.TopK = int(c.eff.GetNumber("retrieval.topK", 5)) } @@ -1240,6 +1273,9 @@ func (c *runCtx) ExecuteTool(call core.ToolCallRequest) core.ToolCallResult { if ct.ID != call.Name { continue } + if c.mgr.projectWorkObservationEnabled && c.run.ProjectID != "" { + return core.ToolCallResult{CallID: call.CallID, Status: "error", Output: "project command tool awaits trusted source preflight"} + } var params map[string]any if len(call.Arguments) > 0 { _ = json.Unmarshal(call.Arguments, ¶ms) @@ -1276,6 +1312,23 @@ func (c *runCtx) ExecuteTool(call core.ToolCallRequest) core.ToolCallResult { last := tc.arts[len(tc.arts)-1] res.Artifact = &last } + if c.mgr.projectWorkObservationEnabled && c.run.ProjectID != "" { + if call.CallID == "" { + return core.ToolCallResult{CallID: call.CallID, Status: "error", Output: "project tool result lacks a stable call ID"} + } + hash := sha256.Sum256([]byte(res.Output)) + meta := map[string]string{"toolName": call.Name, "status": res.Status, "sourceStatus": "transient", + "observedAt": time.Now().UTC().Format(time.RFC3339Nano)} + if res.Artifact != nil { + meta["artifactId"] = string(res.Artifact.ID) + } + if _, err := c.mgr.st.AppendRunWorkObservation(store.RunWorkObservationInput{ + RunID: string(c.run.ID), SourceKind: "tool-result", SourceID: call.CallID, + SourceVersion: hex.EncodeToString(hash[:]), Text: res.Output, Delivery: "complete", Metadata: meta, + }); err != nil { + return core.ToolCallResult{CallID: call.CallID, Status: "error", Output: "project tool result could not be recorded"} + } + } // 超长截断并转工件引用（4.10）。 limit := c.prof.Context.MaxToolResultChars if limit <= 0 { diff --git a/internal/store/migrate.go b/internal/store/migrate.go index a773e0e..dac2467 100644 --- a/internal/store/migrate.go +++ b/internal/store/migrate.go @@ -1087,8 +1087,8 @@ func init() { }}, migration{version: 44, name: "project_work_observation_outbox", up: map[string][]string{ - "sqlite": {`CREATE TABLE project_work_outbox (event_id TEXT PRIMARY KEY,owner TEXT NOT NULL,project_id TEXT NOT NULL,conversation_id TEXT NOT NULL,run_id TEXT NOT NULL DEFAULT '',source_kind TEXT NOT NULL,source_id TEXT NOT NULL,source_version TEXT NOT NULL,source_sha256 TEXT NOT NULL,part_index INTEGER NOT NULL,span_start INTEGER NOT NULL,span_end INTEGER NOT NULL,delivery TEXT NOT NULL,scope TEXT NOT NULL,observed_at TEXT NOT NULL,state TEXT NOT NULL DEFAULT 'pending',receipt_id TEXT NOT NULL DEFAULT '',UNIQUE(source_kind,source_id,part_index))`, `CREATE INDEX idx_project_work_outbox_pending ON project_work_outbox(state,observed_at,event_id)`}, - "postgres": {`CREATE TABLE project_work_outbox (event_id TEXT PRIMARY KEY,owner TEXT NOT NULL,project_id TEXT NOT NULL,conversation_id TEXT NOT NULL,run_id TEXT NOT NULL DEFAULT '',source_kind TEXT NOT NULL,source_id TEXT NOT NULL,source_version TEXT NOT NULL,source_sha256 TEXT NOT NULL,part_index INTEGER NOT NULL,span_start INTEGER NOT NULL,span_end INTEGER NOT NULL,delivery TEXT NOT NULL,scope TEXT NOT NULL,observed_at TEXT NOT NULL,state TEXT NOT NULL DEFAULT 'pending',receipt_id TEXT NOT NULL DEFAULT '',UNIQUE(source_kind,source_id,part_index))`, `CREATE INDEX idx_project_work_outbox_pending ON project_work_outbox(state,observed_at,event_id)`}, + "sqlite": {`CREATE TABLE project_work_outbox (event_id TEXT PRIMARY KEY,owner TEXT NOT NULL,project_id TEXT NOT NULL,conversation_id TEXT NOT NULL,run_id TEXT NOT NULL DEFAULT '',source_kind TEXT NOT NULL,source_id TEXT NOT NULL,source_version TEXT NOT NULL,source_sha256 TEXT NOT NULL,part_index INTEGER NOT NULL,span_start INTEGER NOT NULL,span_end INTEGER NOT NULL,delivery TEXT NOT NULL,scope TEXT NOT NULL,observed_at TEXT NOT NULL,state TEXT NOT NULL DEFAULT 'pending',receipt_id TEXT NOT NULL DEFAULT '',payload_text TEXT NOT NULL DEFAULT '',metadata_json TEXT NOT NULL DEFAULT '{}')`, `CREATE INDEX idx_project_work_outbox_pending ON project_work_outbox(state,observed_at,event_id)`}, + "postgres": {`CREATE TABLE project_work_outbox (event_id TEXT PRIMARY KEY,owner TEXT NOT NULL,project_id TEXT NOT NULL,conversation_id TEXT NOT NULL,run_id TEXT NOT NULL DEFAULT '',source_kind TEXT NOT NULL,source_id TEXT NOT NULL,source_version TEXT NOT NULL,source_sha256 TEXT NOT NULL,part_index INTEGER NOT NULL,span_start INTEGER NOT NULL,span_end INTEGER NOT NULL,delivery TEXT NOT NULL,scope TEXT NOT NULL,observed_at TEXT NOT NULL,state TEXT NOT NULL DEFAULT 'pending',receipt_id TEXT NOT NULL DEFAULT '',payload_text TEXT NOT NULL DEFAULT '',metadata_json TEXT NOT NULL DEFAULT '{}')`, `CREATE INDEX idx_project_work_outbox_pending ON project_work_outbox(state,observed_at,event_id)`}, }, down: map[string][]string{ "sqlite": {`DROP INDEX IF EXISTS idx_project_work_outbox_pending`, `DROP TABLE IF EXISTS project_work_outbox`}, diff --git a/internal/store/project_work_outbox.go b/internal/store/project_work_outbox.go index de1a6dd..d5f73d6 100644 --- a/internal/store/project_work_outbox.go +++ b/internal/store/project_work_outbox.go @@ -4,6 +4,7 @@ import ( "crypto/sha256" "database/sql" "encoding/hex" + "encoding/json" "errors" "fmt" "time" @@ -34,9 +35,74 @@ type ProjectWorkObservationRow struct { State string ReceiptID string Text string + Metadata map[string]string Reason string } +// RunWorkObservationInput identifies an actual retrieval/tool/visible-analysis +// result seen by a trusted run. Owner, project, and conversation are resolved +// from the stored run; callers cannot supply or override those identities. +type RunWorkObservationInput struct { + RunID string + SourceKind string // retrieval-hit|tool-result|visible-analysis + SourceID string + SourceVersion string + Text string + Delivery string // complete|summary-only|partial + PartIndex int + Metadata map[string]string +} + +func (s *Store) AppendRunWorkObservation(input RunWorkObservationInput) (string, error) { + if input.RunID == "" || input.SourceID == "" || input.SourceVersion == "" || input.PartIndex < 0 { + return "", errors.New("project work source: missing trusted source identity") + } + switch input.SourceKind { + case "retrieval-hit", "tool-result", "visible-analysis": + default: + return "", errors.New("project work source: unsupported kind") + } + if input.Delivery != "complete" && input.Delivery != "summary-only" && input.Delivery != "partial" { + return "", errors.New("project work source: unsupported delivery state") + } + if len(input.Text) > 64*1024 { + return "", errors.New("project work source: fragment exceeds bounded intake") + } + meta, err := json.Marshal(input.Metadata) + if err != nil || len(meta) > 8*1024 { + return "", errors.New("project work source: invalid or oversized metadata") + } + tx, err := s.db.Begin() + if err != nil { + return "", err + } + defer tx.Rollback() + var owner, projectID, conversationID, convOwner, convProject string + if err := tx.QueryRow(s.q(`SELECT r.owner,r.project_id,r.conversation_id,c.owner,c.project_id FROM runs r JOIN conversations c ON c.id=r.conversation_id WHERE r.id=?`), input.RunID). + Scan(&owner, &projectID, &conversationID, &convOwner, &convProject); err != nil { + if errors.Is(err, sql.ErrNoRows) { + return "", ErrNotFound + } + return "", err + } + if owner != convOwner || projectID == "" || projectID != convProject { + return "", errors.New("project work source: run binding does not match current conversation") + } + hash := sha256.Sum256([]byte(input.Text)) + eventID := newID("obs") + observed := time.Now().UTC().Format(time.RFC3339Nano) + if _, err := tx.Exec(s.q(`INSERT INTO project_work_outbox(event_id,owner,project_id,conversation_id,run_id,source_kind,source_id,source_version,source_sha256,part_index,span_start,span_end,delivery,scope,observed_at,payload_text,metadata_json) + VALUES(?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?)`), eventID, owner, projectID, conversationID, input.RunID, + input.SourceKind, input.SourceID, input.SourceVersion, hex.EncodeToString(hash[:]), input.PartIndex, + 0, len(input.Text), input.Delivery, "private", observed, input.Text, string(meta)); err != nil { + return "", err + } + if err := tx.Commit(); err != nil { + return "", err + } + return eventID, nil +} + func (s *Store) appendProjectMessageObservationsTx(tx *sql.Tx, m *core.Message) error { if m == nil || (m.Role != core.RoleUser && m.Role != core.RoleAssistant) { return nil @@ -57,20 +123,26 @@ func (s *Store) appendProjectMessageObservationsTx(tx *sql.Tx, m *core.Message) if part.Type == core.PartThinking { continue } - delivery, text := "partial", "" + delivery := "partial" var material []byte - if part.Type == core.PartText && part.Text != "" { - delivery, text = "complete", part.Text - material = []byte(text) - } else { + switch part.Type { + case core.PartText: + material = []byte(part.Text) + case core.PartPlan, core.PartCheck, core.PartCard: + material = []byte(marshalJSON(part)) // saved, visible analysis artefact + default: material = []byte(marshalJSON(part)) } + if (part.Type == core.PartText || part.Type == core.PartPlan || part.Type == core.PartCheck || part.Type == core.PartCard) && len(material) > 0 && len(material) <= 64*1024 { + delivery = "complete" + } hash := sha256.Sum256(material) idDigest := sha256.Sum256([]byte(fmt.Sprintf("%s:%s:%d", kind, m.ID, i))) eventID := "obs_" + hex.EncodeToString(idDigest[:16]) - if _, err := tx.Exec(s.q(`INSERT INTO project_work_outbox(event_id,owner,project_id,conversation_id,run_id,source_kind,source_id,source_version,source_sha256,part_index,span_start,span_end,delivery,scope,observed_at) - VALUES(?,?,?,?,?,?,?,?,?,?,?,?,?,?,?)`), eventID, owner, projectID, m.ConversationID, m.RunID, - kind, m.ID, m.ID, hex.EncodeToString(hash[:]), i, 0, len(text), delivery, "private", observed); err != nil { + meta, _ := json.Marshal(map[string]string{"partType": string(part.Type)}) + if _, err := tx.Exec(s.q(`INSERT INTO project_work_outbox(event_id,owner,project_id,conversation_id,run_id,source_kind,source_id,source_version,source_sha256,part_index,span_start,span_end,delivery,scope,observed_at,metadata_json) + VALUES(?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?)`), eventID, owner, projectID, m.ConversationID, m.RunID, + kind, m.ID, m.ID, hex.EncodeToString(hash[:]), i, 0, len(material), delivery, "private", observed, string(meta)); err != nil { return err } } @@ -81,7 +153,7 @@ func (s *Store) appendProjectMessageObservationsTx(tx *sql.Tx, m *core.Message) // It rechecks that the immutable source bytes still match the recorded hash. // Missing or changed source bytes become partial, never invented complete text. func (s *Store) PendingProjectWorkObservations(limit int) ([]ProjectWorkObservationRow, error) { - return s.projectWorkObservations("", limit) + return s.projectWorkObservations("", "", limit) } // ProjectMessageObservations returns every committed part of one message, @@ -91,26 +163,46 @@ func (s *Store) ProjectMessageObservations(messageID string) ([]ProjectWorkObser return nil, errors.New("project work observation: empty message ID") } var count int - if err := s.db.QueryRow(s.q(`SELECT COUNT(*) FROM project_work_outbox WHERE source_id=?`), messageID).Scan(&count); err != nil { + if err := s.db.QueryRow(s.q(`SELECT COUNT(*) FROM project_work_outbox WHERE source_id=? AND source_kind IN ('user-message','assistant-message')`), messageID).Scan(&count); err != nil { return nil, err } if count > 200 { return nil, errors.New("project work observation: message parts exceed safe preflight limit") } - return s.projectWorkObservations(messageID, 200) + return s.projectWorkObservations(messageID, "", 200) } -func (s *Store) projectWorkObservations(messageID string, limit int) ([]ProjectWorkObservationRow, error) { +// ProjectRunObservations is the exact committed source set linked to a run. +// An over-limit set is an explicit incomplete manifest, never a truncated pass. +func (s *Store) ProjectRunObservations(runID string) ([]ProjectWorkObservationRow, error) { + if runID == "" { + return nil, errors.New("project work observation: empty run ID") + } + var count int + if err := s.db.QueryRow(s.q(`SELECT COUNT(*) FROM project_work_outbox WHERE run_id=?`), runID).Scan(&count); err != nil { + return nil, err + } + if count > 200 { + return nil, errors.New("project work observation: run sources exceed safe preflight limit") + } + return s.projectWorkObservations("", runID, 200) +} + +func (s *Store) projectWorkObservations(messageID, runID string, limit int) ([]ProjectWorkObservationRow, error) { if limit <= 0 || limit > 200 { limit = 50 } - query := `SELECT event_id,owner,project_id,conversation_id,run_id,source_kind,source_id,source_version,source_sha256,part_index,span_start,span_end,delivery,scope,observed_at,state,receipt_id + query := `SELECT event_id,owner,project_id,conversation_id,run_id,source_kind,source_id,source_version,source_sha256,part_index,span_start,span_end,delivery,scope,observed_at,state,receipt_id,payload_text,metadata_json FROM project_work_outbox WHERE state='pending' ORDER BY observed_at,event_id LIMIT ?` args := []any{limit} if messageID != "" { - query = `SELECT event_id,owner,project_id,conversation_id,run_id,source_kind,source_id,source_version,source_sha256,part_index,span_start,span_end,delivery,scope,observed_at,state,receipt_id - FROM project_work_outbox WHERE source_id=? ORDER BY part_index LIMIT ?` + query = `SELECT event_id,owner,project_id,conversation_id,run_id,source_kind,source_id,source_version,source_sha256,part_index,span_start,span_end,delivery,scope,observed_at,state,receipt_id,payload_text,metadata_json + FROM project_work_outbox WHERE source_id=? AND source_kind IN ('user-message','assistant-message') ORDER BY part_index LIMIT ?` args = []any{messageID, limit} + } else if runID != "" { + query = `SELECT event_id,owner,project_id,conversation_id,run_id,source_kind,source_id,source_version,source_sha256,part_index,span_start,span_end,delivery,scope,observed_at,state,receipt_id,payload_text,metadata_json + FROM project_work_outbox WHERE run_id=? ORDER BY observed_at,event_id LIMIT ?` + args = []any{runID, limit} } rows, err := s.db.Query(s.q(query), args...) if err != nil { @@ -119,13 +211,18 @@ func (s *Store) projectWorkObservations(messageID string, limit int) ([]ProjectW out := make([]ProjectWorkObservationRow, 0, limit) for rows.Next() { var row ProjectWorkObservationRow - var observed string + var observed, payload, metadata string if err := rows.Scan(&row.EventID, &row.Owner, &row.ProjectID, &row.ConversationID, &row.RunID, &row.SourceKind, &row.SourceID, &row.SourceVersion, &row.SourceSHA256, &row.PartIndex, - &row.SpanStart, &row.SpanEnd, &row.Delivery, &row.Scope, &observed, &row.State, &row.ReceiptID); err != nil { + &row.SpanStart, &row.SpanEnd, &row.Delivery, &row.Scope, &observed, &row.State, &row.ReceiptID, &payload, &metadata); err != nil { rows.Close() return nil, err } + if err := json.Unmarshal([]byte(metadata), &row.Metadata); err != nil { + rows.Close() + return nil, err + } + row.Text = payload row.ObservedAt, err = time.Parse(time.RFC3339Nano, observed) if err != nil { rows.Close() @@ -143,6 +240,13 @@ func (s *Store) projectWorkObservations(messageID string, limit int) ([]ProjectW if row.Delivery != "complete" { continue } + if row.SourceKind != "user-message" && row.SourceKind != "assistant-message" { + hash := sha256.Sum256([]byte(row.Text)) + if hex.EncodeToString(hash[:]) != row.SourceSHA256 || row.SpanEnd != len(row.Text) { + row.Delivery, row.Reason, row.Text = "partial", "source-changed", "" + } + continue + } msg, err := s.MessageByID(row.SourceID) if errors.Is(err, ErrNotFound) { row.Delivery, row.Reason = "partial", "source-missing" @@ -151,11 +255,21 @@ func (s *Store) projectWorkObservations(messageID string, limit int) ([]ProjectW if err != nil { return nil, err } - if msg.ConversationID != core.ID(row.ConversationID) || row.PartIndex < 0 || row.PartIndex >= len(msg.Parts) || msg.Parts[row.PartIndex].Type != core.PartText { + if msg.ConversationID != core.ID(row.ConversationID) || row.PartIndex < 0 || row.PartIndex >= len(msg.Parts) { + row.Delivery, row.Reason = "partial", "source-changed" + continue + } + part := msg.Parts[row.PartIndex] + var text string + switch part.Type { + case core.PartText: + text = part.Text + case core.PartPlan, core.PartCheck, core.PartCard: + text = marshalJSON(part) + default: row.Delivery, row.Reason = "partial", "source-changed" continue } - text := msg.Parts[row.PartIndex].Text hash := sha256.Sum256([]byte(text)) if hex.EncodeToString(hash[:]) != row.SourceSHA256 || row.SpanEnd != len(text) { row.Delivery, row.Reason = "partial", "source-changed" diff --git a/internal/store/project_work_outbox_test.go b/internal/store/project_work_outbox_test.go index 377b4f6..d76df12 100644 --- a/internal/store/project_work_outbox_test.go +++ b/internal/store/project_work_outbox_test.go @@ -64,6 +64,10 @@ func TestProjectMessageOutboxFollowsCommittedMessage(t *testing.T) { if err != nil || len(linked) != 2 || linked[0].RunID != string(run.ID) || linked[1].RunID != string(run.ID) { t.Fatalf("later trusted run link was not saved for every source part: %+v %v", linked, err) } + runSources, err := st.ProjectRunObservations(string(run.ID)) + if err != nil || len(runSources) != 2 { + t.Fatalf("run preflight did not find its linked user parts: %+v %v", runSources, err) + } retry := core.Message{ConversationID: projectConv.ID, Role: core.RoleUser, Parts: []core.Part{{Type: core.PartText, Text: "changed"}}} if err := st.AppendMessageWithRequestAccountChecked("alice", false, &retry, "request-1"); err == nil { t.Fatal("duplicate request did not surface existing message") @@ -106,15 +110,25 @@ func TestAssistantObservationCommitsOnlyWithFencedRunSettlement(t *testing.T) { run := seedRun(t, st, conv, core.RunRunning) now := time.Now().UTC() run.Status, run.Phase, run.EndedAt = core.RunCompleted, core.PhaseDone, &now - answer := core.Message{ConversationID: conv.ID, RunID: run.ID, Role: core.RoleAssistant, Parts: []core.Part{{Type: core.PartText, Text: "需要澄清效率的含义"}}} + answer := core.Message{ConversationID: conv.ID, RunID: run.ID, Role: core.RoleAssistant, Parts: []core.Part{ + {Type: core.PartText, Text: "需要澄清效率的含义"}, + {Type: core.PartPlan, Plan: &core.PlanSnapshot{Title: "可见分析计划", Steps: []core.PlanStep{{ID: "clarify", Text: "确认比较方向", Status: "pending"}}}}, + }} updated, err := st.SettleRun(&run, &answer) if err != nil || !updated { t.Fatalf("run settlement failed: updated=%t err=%v", updated, err) } rows, err := st.PendingProjectWorkObservations(10) - if err != nil || len(rows) != 1 || rows[0].SourceKind != "assistant-message" || rows[0].SourceID != string(answer.ID) || rows[0].RunID != string(run.ID) || rows[0].Text != answer.Parts[0].Text { + if err != nil || len(rows) != 2 { t.Fatalf("final assistant observation was not committed with the run: %+v %v", rows, err) } + byPart := map[int]ProjectWorkObservationRow{} + for _, row := range rows { + byPart[row.PartIndex] = row + } + if byPart[0].SourceKind != "assistant-message" || byPart[0].SourceID != string(answer.ID) || byPart[0].RunID != string(run.ID) || byPart[0].Text != answer.Parts[0].Text || byPart[1].Delivery != "complete" || byPart[1].Metadata["partType"] != string(core.PartPlan) || byPart[1].Text == "" { + t.Fatalf("visible analysis or final answer was lost: %+v", rows) + } secondRun := seedRun(t, st, conv, core.RunRunning) secondRun.Status, secondRun.Phase, secondRun.EndedAt = core.RunCompleted, core.PhaseDone, &now failed := core.Message{ID: answer.ID, ConversationID: conv.ID, RunID: secondRun.ID, Role: core.RoleAssistant, Parts: []core.Part{{Type: core.PartText, Text: "different"}}} @@ -122,7 +136,7 @@ func TestAssistantObservationCommitsOnlyWithFencedRunSettlement(t *testing.T) { t.Fatal("duplicate final message did not fail") } again, err := st.PendingProjectWorkObservations(10) - if err != nil || len(again) != 1 { + if err != nil || len(again) != 2 { t.Fatalf("failed settlement added a second observation: %+v %v", again, err) } } diff --git a/internal/store/project_work_run_source_test.go b/internal/store/project_work_run_source_test.go new file mode 100644 index 0000000..df7dac2 --- /dev/null +++ b/internal/store/project_work_run_source_test.go @@ -0,0 +1,52 @@ +package store + +import ( + "testing" + + core "agent-system-core" +) + +func TestRunWorkSourceUsesStoredRunAndRetainsEachActualHit(t *testing.T) { + st := openTestStore(t) + if err := st.EnsureUser("alice", "Alice"); err != nil { + t.Fatal(err) + } + p, err := st.CreateProject("alice", "P") + if err != nil { + t.Fatal(err) + } + conv, err := st.CreateConversation("alice", string(p.ID), "Work", "") + if err != nil { + t.Fatal(err) + } + run := core.Run{ConversationID: conv.ID, ProjectID: p.ID, Owner: "alice", Kind: core.RunConversation, Status: core.RunRunning, Phase: core.PhaseThinking} + if err := st.CreateRun(&run); err != nil { + t.Fatal(err) + } + input := RunWorkObservationInput{RunID: string(run.ID), SourceKind: "retrieval-hit", SourceID: "knowledge-1", SourceVersion: "v1", Text: "实际命中的资料", Delivery: "complete", Metadata: map[string]string{"query": "效率", "ref": "https://example.test/a"}} + first, err := st.AppendRunWorkObservation(input) + if err != nil { + t.Fatal(err) + } + second, err := st.AppendRunWorkObservation(input) + if err != nil || first == second { + t.Fatalf("repeated actual hit lost occurrence identity: first=%q second=%q err=%v", first, second, err) + } + rows, err := st.PendingProjectWorkObservations(10) + if err != nil || len(rows) != 2 { + t.Fatalf("run observations missing: %+v %v", rows, err) + } + for _, row := range rows { + if row.Owner != "alice" || row.ProjectID != string(p.ID) || row.ConversationID != string(conv.ID) || row.RunID != string(run.ID) || row.SourceID != "knowledge-1" || row.Text != input.Text || row.Metadata["query"] != "效率" { + t.Fatalf("source was not derived from trusted run or actual hit: %+v", row) + } + } + runRows, err := st.ProjectRunObservations(string(run.ID)) + if err != nil || len(runRows) != 2 { + t.Fatalf("run manifest omitted actual retrieval occurrences: %+v %v", runRows, err) + } + input.RunID = "run-forged" + if _, err := st.AppendRunWorkObservation(input); err == nil { + t.Fatal("unbound run locator became a project source") + } +} diff --git a/internal/store/project_work_source_status.go b/internal/store/project_work_source_status.go new file mode 100644 index 0000000..5fd2f84 --- /dev/null +++ b/internal/store/project_work_source_status.go @@ -0,0 +1,28 @@ +package store + +import ( + "database/sql" + "errors" + + core "agent-system-core" +) + +// ProjectWorkKnowledgeSource returns a stored knowledge source to the trusted +// host verifier. This is not a client read API: callers must independently +// enforce current owner, project, and resource publication permissions before +// disclosing its body to a project observer or model. +func (s *Store) ProjectWorkKnowledgeSource(id string) (core.KnowledgeDoc, error) { + var doc core.KnowledgeDoc + var owner, created string + err := s.db.QueryRow(s.q(`SELECT id,owner,project_id,source,title,ref,chunk,created_at FROM knowledge WHERE id=?`), id). + Scan(&doc.ID, &owner, &doc.ProjectID, &doc.Source, &doc.Title, &doc.Ref, &doc.Chunk, &created) + if errors.Is(err, sql.ErrNoRows) { + return doc, ErrNotFound + } + if err != nil { + return doc, err + } + doc.Owner = core.ID(owner) + doc.CreatedAt, err = parseTime(created) + return doc, err +} diff --git a/pkg/extension/project_work.go b/pkg/extension/project_work.go index 85c66c6..e397525 100644 --- a/pkg/extension/project_work.go +++ b/pkg/extension/project_work.go @@ -12,26 +12,27 @@ import ( // Actor, ProjectID, source identity, or the source authorization epoch. // RunID may be empty for a newly committed user message or chat command. type WorkObservation struct { - EventID string `json:"eventId"` - Phase string `json:"phase"` - Actor string `json:"actor"` - Owner string `json:"owner"` - ProjectID core.ID `json:"projectId"` - ConversationID core.ID `json:"conversationId,omitempty"` - RunID core.ID `json:"runId,omitempty"` - SourceKind string `json:"sourceKind"` - SourceID string `json:"sourceId"` - SourceVersion string `json:"sourceVersion"` - SourceSHA256 string `json:"sourceSha256"` - PartIndex int `json:"partIndex"` - SpanStart int `json:"spanStart"` // UTF-8 byte offset in the exact source - SpanEnd int `json:"spanEnd"` - Text string `json:"text,omitempty"` // only the actual authorized fragment - Scope string `json:"scope"` // private|project|controlled - Delivery string `json:"delivery"` // complete|summary-only|partial - DeliveryReason string `json:"deliveryReason,omitempty"` - AuthorizationEpoch string `json:"authorizationEpoch"` - ObservedAt time.Time `json:"observedAt"` + EventID string `json:"eventId"` + Phase string `json:"phase"` + Actor string `json:"actor"` + Owner string `json:"owner"` + ProjectID core.ID `json:"projectId"` + ConversationID core.ID `json:"conversationId,omitempty"` + RunID core.ID `json:"runId,omitempty"` + SourceKind string `json:"sourceKind"` + SourceID string `json:"sourceId"` + SourceVersion string `json:"sourceVersion"` + SourceSHA256 string `json:"sourceSha256"` + PartIndex int `json:"partIndex"` + SpanStart int `json:"spanStart"` // UTF-8 byte offset in the exact source + SpanEnd int `json:"spanEnd"` + Text string `json:"text,omitempty"` // only the actual authorized fragment + Scope string `json:"scope"` // private|project|controlled + Delivery string `json:"delivery"` // complete|summary-only|partial + DeliveryReason string `json:"deliveryReason,omitempty"` + Metadata map[string]string `json:"metadata,omitempty"` + AuthorizationEpoch string `json:"authorizationEpoch"` + ObservedAt time.Time `json:"observedAt"` } type WorkObservationState string -- 2.54.0 From da4b8c99569919b9913e8a614518250bad8ceadd Mon Sep 17 00:00:00 2001 From: weichen Date: Wed, 14 Oct 2026 16:54:13 +0000 Subject: [PATCH 20/41] Gate project runs and replies on source analysis Why: Project messages, retrieved evidence, tool results, and final replies must not affect model work or reach users before the domain risk decision is complete. Evidence: RED tests proved the runner, final reply, and message deltas advanced before the gate; focused tests, go test -p 1 ./..., go build ./..., and isolated PostgreSQL runtime tests now pass. Impact: Wire the optional RDM observer into project run start, retrieval, tool-result, HITL clarification, and final reply buffering; hosts without the optional provider keep existing behavior. Refs: TT-N03, TT-R01; approved work-observation design and stage-five plan --- internal/app/app.go | 4 +- internal/app/project_work_observation.go | 33 ++- internal/runmgr/project_work_gate.go | 124 ++++++++++ internal/runmgr/project_work_gate_test.go | 231 ++++++++++++++++++ .../runmgr/project_work_retrieval_test.go | 2 +- .../runmgr/project_work_tool_result_test.go | 2 +- internal/runmgr/runmgr.go | 90 +++++++ 7 files changed, 481 insertions(+), 5 deletions(-) create mode 100644 internal/runmgr/project_work_gate.go create mode 100644 internal/runmgr/project_work_gate_test.go diff --git a/internal/app/app.go b/internal/app/app.go index 8eb18cb..f6a8fde 100644 --- a/internal/app/app.go +++ b/internal/app/app.go @@ -614,12 +614,13 @@ func Run(opt Options) error { // hostcaps：hostapi 闭包与进程内插件句柄共用的 owner 作用域能力（EXT-1 批注 1）。 authzSlot := &projectAuthz{} projectSlot := &projectLifecycleSlot{} + workObserverSlot := &projectWorkObserverSlot{} directorySlot, err := newAccountDirectorySlot(st) if err != nil { return err } contextSlot := &projectContextSlot{} - caps := hostcaps{projects: projectSlot, contexts: contextSlot, projectAudit: &projectAuditSlot{}, directory: directorySlot, st: st, pipe: pipe, set: setSvc, authz: authzSlot, surfaces: surfaceSvc, allowImplicitLocal: !authOn, + caps := hostcaps{projects: projectSlot, workObserver: workObserverSlot, contexts: contextSlot, projectAudit: &projectAuditSlot{}, directory: directorySlot, st: st, pipe: pipe, set: setSvc, authz: authzSlot, surfaces: surfaceSvc, allowImplicitLocal: !authOn, accountGuard: func(owner string) error { valid, err := effectiveAccount(context.Background(), owner) if err != nil { @@ -646,6 +647,7 @@ func Run(opt Options) error { return err } mgr.SetProjectWorkAuthorization(projectSlot.work()) + wireProjectWorkGate(mgr, st, caps, workObserverSlot, projectSlot.work()) if contextSlot.active() { mgr.SetProjectContextResolver(contextSlot.resolve) mgr.SetProjectEvidenceReader(contextSlot.readEvidence) diff --git a/internal/app/project_work_observation.go b/internal/app/project_work_observation.go index 39d1999..3fb56dc 100644 --- a/internal/app/project_work_observation.go +++ b/internal/app/project_work_observation.go @@ -8,6 +8,7 @@ import ( "fmt" "sync" + "agent-system-backend/internal/runmgr" "agent-system-backend/internal/store" "agent-system-backend/pkg/extension" core "agent-system-core" @@ -31,6 +32,33 @@ func (s *projectWorkObserverSlot) get() *extension.ProjectWorkObserver { return © } +func (s *projectWorkObserverSlot) active() bool { return s.get() != nil } + +func wireProjectWorkGate(mgr *runmgr.Manager, st *store.Store, caps hostcaps, slot *projectWorkObserverSlot, + work func(context.Context, string, core.ID) (bool, error), +) { + provider := slot.get() + if provider == nil || work == nil { + return + } + verify := func(ctx context.Context, row store.ProjectWorkObservationRow) error { + switch row.SourceKind { + case "retrieval-hit": + return verifyProjectKnowledgeObservation(ctx, caps, row) + case "tool-result", "visible-analysis": + return verifyProjectTransientObservation(ctx, st, row) + default: + return fmt.Errorf("project work source %s: unsupported run source kind %q", row.EventID, row.SourceKind) + } + } + mgr.SetProjectWorkGate( + func(ctx context.Context, runID, action string) (extension.ProjectWorkDecision, error) { + return preflightProjectRun(ctx, st, slot, work, verify, runID, action) + }, + provider.Respond, + ) +} + func (r compiledRegistry) RegisterProjectWorkObserver(extension.ProjectWorkObserver) error { return errors.New("extension: declarative plugins cannot register project work observers") } @@ -168,8 +196,9 @@ func verifyProjectKnowledgeObservation(_ context.Context, caps hostcaps, row sto // RDM must keep it a candidate until a separately verifiable evidence source // or human confirmation supports a formal project claim. func verifyProjectTransientObservation(_ context.Context, st *store.Store, row store.ProjectWorkObservationRow) error { - if row.SourceKind != "tool-result" || row.Metadata["sourceStatus"] != "transient" || - row.Metadata["toolName"] == "" || row.RunID == "" { + toolSource := row.SourceKind == "tool-result" && row.Metadata["sourceStatus"] == "transient" && row.Metadata["toolName"] != "" + visibleAnalysis := row.SourceKind == "visible-analysis" && row.Metadata["stage"] == "assistant-final" && row.Metadata["partType"] != "" + if (!toolSource && !visibleAnalysis) || row.RunID == "" { return errors.New("project work source: transient result lacks trusted provenance") } run, err := st.GetRunByID(core.ID(row.RunID)) diff --git a/internal/runmgr/project_work_gate.go b/internal/runmgr/project_work_gate.go new file mode 100644 index 0000000..865aa55 --- /dev/null +++ b/internal/runmgr/project_work_gate.go @@ -0,0 +1,124 @@ +package runmgr + +import ( + "context" + "crypto/sha256" + "encoding/hex" + "encoding/json" + "errors" + "fmt" + + "agent-system-backend/internal/store" + "agent-system-backend/pkg/extension" + core "agent-system-core" +) + +type projectWorkPreflight func(context.Context, string, string) (extension.ProjectWorkDecision, error) +type projectRiskRespond func(context.Context, extension.ProjectRiskAnswer) (extension.ProjectWorkDecision, error) +type projectRiskAsk func(core.HITLCard) (core.HITLResponse, error) + +var errProjectWorkPending = errors.New("project work source analysis pending") + +func (c *runCtx) stageAssistantWorkSources(parts []core.Part) error { + if !c.mgr.projectWorkObservationEnabled || c.run.ProjectID == "" { + return nil + } + for i, part := range parts { + var body string + switch part.Type { + case core.PartText: + body = part.Text + case core.PartPlan, core.PartCheck, core.PartCard: + raw, err := json.Marshal(part) + if err != nil { + return err + } + body = string(raw) + default: + continue + } + if body == "" { + continue + } + hash := sha256.Sum256([]byte(body)) + if _, err := c.mgr.st.AppendRunWorkObservation(store.RunWorkObservationInput{ + RunID: string(c.run.ID), SourceKind: "visible-analysis", + SourceID: fmt.Sprintf("%s:assistant-final:%d", c.run.ID, i), + SourceVersion: hex.EncodeToString(hash[:]), Text: body, Delivery: "complete", PartIndex: i, + Metadata: map[string]string{"partType": string(part.Type), "stage": "assistant-final"}, + }); err != nil { + return err + } + } + return nil +} + +func resolveProjectWorkDecision(ctx context.Context, actor, projectID, runID, action string, + preflight projectWorkPreflight, respond projectRiskRespond, ask projectRiskAsk, +) (extension.ProjectWorkDecision, error) { + pending := extension.ProjectWorkDecision{State: extension.ProjectWorkPending, Reason: "project work risk decision incomplete"} + if preflight == nil { + return pending, errors.New("project work gate unavailable") + } + decision, err := preflight(ctx, runID, action) + if err != nil { + return pending, err + } + switch decision.State { + case extension.ProjectWorkProceed: + if decision.DecisionID == "" { + return pending, errors.New("project work proceed decision is not committed") + } + return decision, nil + case extension.ProjectWorkDenied: + return decision, errors.New("project work action denied: " + decision.Reason) + case extension.ProjectWorkPending: + return pending, errProjectWorkPending + case extension.ProjectWorkClarify: + if decision.RiskID == "" || decision.RiskRevision == "" || decision.Question == "" || respond == nil || ask == nil { + return pending, errors.New("project work clarification is incomplete") + } + default: + return pending, fmt.Errorf("invalid project work decision %q", decision.State) + } + choices := make([]core.HITLChoice, 0, len(decision.Options)) + for i, option := range decision.Options { + choices = append(choices, core.HITLChoice{ + ID: fmt.Sprintf("option-%d", i), Label: option, + Description: "澄清这条项目信息的实际含义", Impact: "选择结果将用于重新判断相关项目动作", + Recommended: i == 0, + }) + } + response, err := ask(core.HITLCard{ + Question: decision.Question, Kind: core.HITLKindChoice, Choices: choices, + AllowFreeInput: true, FreeInputHint: "也可以输入更准确的表述", Blocked: true, + BlockReason: decision.Reason, + }) + if err != nil { + return pending, err + } + answer := response.FreeText + if response.ChoiceID != "" { + for _, choice := range choices { + if choice.ID == response.ChoiceID { + answer = choice.Label + break + } + } + } + if answer == "" { + return pending, errors.New("project work clarification answer is empty") + } + idempotency := sha256.Sum256([]byte(decision.RiskID + "\x00" + decision.RiskRevision + "\x00" + runID + "\x00" + answer)) + resolved, err := respond(ctx, extension.ProjectRiskAnswer{ + Actor: actor, Owner: actor, ProjectID: core.ID(projectID), RiskID: decision.RiskID, + RiskRevision: decision.RiskRevision, Answer: answer, IdempotencyKey: fmt.Sprintf("%x", idempotency), + }) + if err != nil { + return pending, err + } + if resolved.State != extension.ProjectWorkProceed || resolved.DecisionID == "" { + return pending, errors.New("project work clarification did not commit a proceed decision") + } + return resolved, nil +} diff --git a/internal/runmgr/project_work_gate_test.go b/internal/runmgr/project_work_gate_test.go new file mode 100644 index 0000000..bee3012 --- /dev/null +++ b/internal/runmgr/project_work_gate_test.go @@ -0,0 +1,231 @@ +package runmgr + +import ( + "context" + "sync/atomic" + "testing" + "time" + + "agent-system-backend/internal/profiles" + backendruntime "agent-system-backend/internal/runtime" + "agent-system-backend/pkg/extension" + core "agent-system-core" +) + +type projectGateRunner struct{ calls atomic.Int32 } + +func (*projectGateRunner) Name() string { return "project-gate-test" } + +func (r *projectGateRunner) Execute(backendruntime.RunCtx) error { + r.calls.Add(1) + return nil +} + +type projectReplyRunner struct{} + +func (*projectReplyRunner) Name() string { return "project-reply-test" } +func (*projectReplyRunner) Execute(rc backendruntime.RunCtx) error { + return rc.SetAssistantParts([]core.Part{{Type: core.PartText, Text: "最终项目答复"}}) +} + +func enableProjectGateForTest(m *Manager) { + m.SetProjectWorkGate( + func(context.Context, string, string) (extension.ProjectWorkDecision, error) { + return extension.ProjectWorkDecision{State: extension.ProjectWorkProceed, DecisionID: "test-decision"}, nil + }, + func(context.Context, extension.ProjectRiskAnswer) (extension.ProjectWorkDecision, error) { + return extension.ProjectWorkDecision{State: extension.ProjectWorkProceed, DecisionID: "test-decision"}, nil + }, + ) +} + +func TestProjectWorkGateClarifiesBeforeProceeding(t *testing.T) { + preflights, responses, questions := 0, 0, 0 + preflight := func(context.Context, string, string) (extension.ProjectWorkDecision, error) { + preflights++ + if preflights == 1 { + return extension.ProjectWorkDecision{ + State: extension.ProjectWorkClarify, RiskID: "risk-1", RiskRevision: "r1", + Question: "效率低于人工是指更慢吗？", Options: []string{"效率更高且成本更低", "完成时间和成本更低", "确实允许效率更低"}, + }, nil + } + return extension.ProjectWorkDecision{State: extension.ProjectWorkPending}, nil + } + respond := func(_ context.Context, answer extension.ProjectRiskAnswer) (extension.ProjectWorkDecision, error) { + responses++ + if answer.Actor != "alice" || answer.ProjectID != "project-1" || answer.RiskID != "risk-1" || answer.RiskRevision != "r1" || answer.Answer != "效率更高且成本更低" || answer.IdempotencyKey == "" { + t.Fatalf("untrusted risk answer: %+v", answer) + } + return extension.ProjectWorkDecision{State: extension.ProjectWorkProceed, DecisionID: "decision-1"}, nil + } + ask := func(card core.HITLCard) (core.HITLResponse, error) { + questions++ + if card.Question == "" || len(card.Choices) != 3 || !card.Blocked { + t.Fatalf("risk decision did not become a blocking HITL card: %+v", card) + } + return core.HITLResponse{ChoiceID: "option-0"}, nil + } + decision, err := resolveProjectWorkDecision(context.Background(), "alice", "project-1", "run-1", "conversation.run", preflight, respond, ask) + if err != nil || decision.State != extension.ProjectWorkProceed || preflights != 1 || responses != 1 || questions != 1 { + t.Fatalf("gate did not wait for clarification: decision=%+v preflight=%d responses=%d questions=%d err=%v", decision, preflights, responses, questions, err) + } +} + +func TestProjectWorkGateNeverTreatsPendingOrMismatchedProceedAsApproval(t *testing.T) { + for _, tc := range []struct { + name string + decision extension.ProjectWorkDecision + }{ + {name: "pending", decision: extension.ProjectWorkDecision{State: extension.ProjectWorkPending}}, + {name: "unbound proceed", decision: extension.ProjectWorkDecision{State: extension.ProjectWorkProceed}}, + } { + t.Run(tc.name, func(t *testing.T) { + preflight := func(context.Context, string, string) (extension.ProjectWorkDecision, error) { return tc.decision, nil } + decision, err := resolveProjectWorkDecision(context.Background(), "alice", "project-1", "run-1", "conversation.run", preflight, nil, nil) + if err == nil || decision.State == extension.ProjectWorkProceed { + t.Fatalf("unsafe decision proceeded: %+v err=%v", decision, err) + } + }) + } +} + +func TestRunContextUsesHITLForProjectRiskBeforeContinuing(t *testing.T) { + rc, st := newExecEnv(t) + rc.run.ID = "run-risk-gate" + rc.run.Status = core.RunRunning + if err := st.CreateRun(&rc.run); err != nil { + t.Fatal(err) + } + rc.h = &runHandle{hitlCh: make(chan hitlAnswer, 1)} + rc.h.hitlCh <- hitlAnswer{resp: core.HITLResponse{ChoiceID: "option-0"}} + rc.mgr.SetProjectWorkAuthorization(func(context.Context, string, core.ID) (bool, error) { return true, nil }) + responded := false + rc.mgr.SetProjectWorkGate( + func(context.Context, string, string) (extension.ProjectWorkDecision, error) { + return extension.ProjectWorkDecision{State: extension.ProjectWorkClarify, RiskID: "risk-1", RiskRevision: "r1", Question: "效率具体指什么？", Options: []string{"效率更高"}}, nil + }, + func(_ context.Context, answer extension.ProjectRiskAnswer) (extension.ProjectWorkDecision, error) { + responded = answer.Answer == "效率更高" + return extension.ProjectWorkDecision{State: extension.ProjectWorkProceed, DecisionID: "decision-1"}, nil + }, + ) + if err := rc.requireProjectWorkDecision("conversation.run"); err != nil || !responded { + t.Fatalf("run did not wait for committed human clarification: responded=%t err=%v", responded, err) + } + cards, err := st.ActiveHITLCards("alice", rc.run.ConversationID) + if err != nil || len(cards) != 1 || cards[0].Question != "效率具体指什么？" { + t.Fatalf("clarification card was not persisted: %+v %v", cards, err) + } +} + +func TestConversationRunWaitsForProjectSourceAnalysisBeforeRunner(t *testing.T) { + rc, st := newExecEnv(t) + conv, err := st.GetConversation("alice", rc.run.ConversationID) + if err != nil { + t.Fatal(err) + } + message := core.Message{ConversationID: conv.ID, Role: core.RoleUser, Parts: []core.Part{{Type: core.PartText, Text: "要求效率和成本都低于人工"}}} + if err := st.AppendMessageWithRequest(&message, "risk-request"); err != nil { + t.Fatal(err) + } + runner := &projectGateRunner{} + rc.mgr.runner = runner + rc.mgr.profiles = profiles.New(st) + rc.mgr.active = map[string]*runHandle{} + rc.mgr.SetProjectWorkAuthorization(func(context.Context, string, core.ID) (bool, error) { return true, nil }) + ready := atomic.Bool{} + rc.mgr.SetProjectWorkGate( + func(context.Context, string, string) (extension.ProjectWorkDecision, error) { + if !ready.Load() { + return extension.ProjectWorkDecision{State: extension.ProjectWorkPending}, nil + } + return extension.ProjectWorkDecision{State: extension.ProjectWorkProceed, DecisionID: "decision-1"}, nil + }, + func(context.Context, extension.ProjectRiskAnswer) (extension.ProjectWorkDecision, error) { + return extension.ProjectWorkDecision{State: extension.ProjectWorkProceed, DecisionID: "decision-1"}, nil + }, + ) + run, err := rc.mgr.StartConversationRun(conv, message, nil, nil) + if err != nil { + t.Fatal(err) + } + time.Sleep(80 * time.Millisecond) + if runner.calls.Load() != 0 { + t.Fatal("model runner started while project sources were still pending") + } + linked, err := st.MessageByID(string(message.ID)) + if err != nil || linked.RunID != run.ID { + t.Fatalf("committed user source was not bound before preflight: %+v %v", linked, err) + } + ready.Store(true) + deadline := time.Now().Add(2 * time.Second) + for runner.calls.Load() == 0 && time.Now().Before(deadline) { + time.Sleep(10 * time.Millisecond) + } + if runner.calls.Load() != 1 { + t.Fatalf("runner calls=%d, want one after committed proceed", runner.calls.Load()) + } +} + +func TestProjectAssistantTextIsNotStreamedBeforeFinalRiskDecision(t *testing.T) { + rc, _ := newExecEnv(t) + rc.run.ID = "run-buffered-project-reply" + enableProjectGateForTest(rc.mgr) + if err := rc.Emit(core.EvMessageDelta, core.MessageDeltaPayload{Index: 0, Text: "未经风险检查的正文"}); err != nil { + t.Fatal(err) + } + rc.mgr.events.mu.Lock() + buffered := len(rc.mgr.events.buf[string(rc.run.ConversationID)]) + rc.mgr.events.mu.Unlock() + if buffered != 0 { + t.Fatalf("project reply leaked %d message delta(s) before final decision", buffered) + } +} + +func TestFinalProjectReplyWaitsForRiskDecisionBeforeCommit(t *testing.T) { + rc, st := newExecEnv(t) + conv, err := st.GetConversation("alice", rc.run.ConversationID) + if err != nil { + t.Fatal(err) + } + message := core.Message{ConversationID: conv.ID, Role: core.RoleUser, Parts: []core.Part{{Type: core.PartText, Text: "项目问题"}}} + if err := st.AppendMessageWithRequest(&message, "final-risk-request"); err != nil { + t.Fatal(err) + } + rc.mgr.runner = &projectReplyRunner{} + rc.mgr.profiles = profiles.New(st) + rc.mgr.active = map[string]*runHandle{} + rc.mgr.SetProjectWorkAuthorization(func(context.Context, string, core.ID) (bool, error) { return true, nil }) + finalReady := atomic.Bool{} + rc.mgr.SetProjectWorkGate( + func(_ context.Context, _ string, action string) (extension.ProjectWorkDecision, error) { + if action == "assistant.final" && !finalReady.Load() { + return extension.ProjectWorkDecision{State: extension.ProjectWorkPending}, nil + } + return extension.ProjectWorkDecision{State: extension.ProjectWorkProceed, DecisionID: "decision-" + action}, nil + }, + func(context.Context, extension.ProjectRiskAnswer) (extension.ProjectWorkDecision, error) { + return extension.ProjectWorkDecision{State: extension.ProjectWorkProceed, DecisionID: "decision-risk"}, nil + }, + ) + if _, err := rc.mgr.StartConversationRun(conv, message, nil, nil); err != nil { + t.Fatal(err) + } + time.Sleep(80 * time.Millisecond) + messages, err := st.ListMessages(string(conv.ID)) + if err != nil || len(messages) != 1 { + t.Fatalf("assistant reply committed before final risk decision: %+v %v", messages, err) + } + finalReady.Store(true) + deadline := time.Now().Add(2 * time.Second) + for time.Now().Before(deadline) { + messages, err = st.ListMessages(string(conv.ID)) + if err == nil && len(messages) == 2 { + break + } + time.Sleep(10 * time.Millisecond) + } + if len(messages) != 2 || messages[1].Role != core.RoleAssistant || messages[1].Parts[0].Text != "最终项目答复" { + t.Fatalf("approved final reply was not committed once: %+v", messages) + } +} diff --git a/internal/runmgr/project_work_retrieval_test.go b/internal/runmgr/project_work_retrieval_test.go index c40bca8..8be9397 100644 --- a/internal/runmgr/project_work_retrieval_test.go +++ b/internal/runmgr/project_work_retrieval_test.go @@ -36,7 +36,7 @@ func TestProjectRetrievalRecordsEachActualAuthorizedHit(t *testing.T) { {Doc: core.KnowledgeDoc{ID: "k2", Owner: "alice", ProjectID: project.ID, Ref: "https://example.test/b", Chunk: "source B"}, Kind: "fulltext"}, }} mgr.SetRetriever(fr) - mgr.SetProjectWorkObservationEnabled(true) + enableProjectGateForTest(mgr) rc := &runCtx{mgr: mgr, run: run, ctx: context.Background()} hits, err := rc.Retrieve(core.RetrievalQuery{Text: "test", ProjectID: project.ID}) if err != nil || len(hits) != 2 { diff --git a/internal/runmgr/project_work_tool_result_test.go b/internal/runmgr/project_work_tool_result_test.go index 0e55463..30e302f 100644 --- a/internal/runmgr/project_work_tool_result_test.go +++ b/internal/runmgr/project_work_tool_result_test.go @@ -14,7 +14,7 @@ func TestProjectToolResultRecordsActualOutputBeforeModelUse(t *testing.T) { t.Fatal(err) } rc.run = run - rc.mgr.SetProjectWorkObservationEnabled(true) + enableProjectGateForTest(rc.mgr) result := rc.ExecuteTool(core.ToolCallRequest{CallID: "tool-1", Name: "time_now", Arguments: []byte(`{}`)}) if result.Status != "ok" || result.Output == "" { t.Fatalf("tool did not return its actual output: %+v", result) diff --git a/internal/runmgr/runmgr.go b/internal/runmgr/runmgr.go index dd63275..8bb505e 100644 --- a/internal/runmgr/runmgr.go +++ b/internal/runmgr/runmgr.go @@ -70,6 +70,8 @@ type Manager struct { projectEvidenceReader func(context.Context, extension.ProjectEvidenceRequest) (extension.ProjectEvidence, error) projectSourceRechecker func(context.Context, extension.ProjectContextSourceRecheckRequest) (extension.ProjectContextSourceRecheckResult, error) projectWorkObservationEnabled bool + projectWorkPreflight projectWorkPreflight + projectRiskRespond projectRiskRespond // commands EXT-14：命令即工具的投影与分发源（nil = 未接线，命令不进工具清单）。 commands CommandSource indexer core.DocumentIndexer // 可选索引入口（nil = store 整文档单块） @@ -302,6 +304,43 @@ func (m *Manager) SetProjectWorkObservationEnabled(enabled bool) { m.projectWorkObservationEnabled = enabled } +// SetProjectWorkGate installs the domain-owned preflight and risk-answer +// callbacks. Both are required; a partial gate stays disabled. +func (m *Manager) SetProjectWorkGate(preflight projectWorkPreflight, respond projectRiskRespond) { + if preflight == nil || respond == nil { + m.projectWorkPreflight, m.projectRiskRespond = nil, nil + m.projectWorkObservationEnabled = false + return + } + m.projectWorkPreflight, m.projectRiskRespond = preflight, respond + m.projectWorkObservationEnabled = true +} + +func (c *runCtx) requireProjectWorkDecision(action string) error { + if !c.mgr.projectWorkObservationEnabled || c.run.ProjectID == "" { + return nil + } + for { + decision, err := resolveProjectWorkDecision(c.ctx, string(c.run.Owner), string(c.run.ProjectID), string(c.run.ID), action, + c.mgr.projectWorkPreflight, c.mgr.projectRiskRespond, c.AskHITL) + if errors.Is(err, errProjectWorkPending) { + select { + case <-time.After(250 * time.Millisecond): + continue + case <-c.ctx.Done(): + return c.ctx.Err() + } + } + if err != nil { + return err + } + if decision.State != extension.ProjectWorkProceed { + return errors.New("project work action did not receive a committed proceed decision") + } + return c.mgr.setRunStatus(&c.run, core.RunRunning, c.run.Phase) + } +} + // SetAccountEffectiveAuthorization binds the current account-state guard. It is // independent of the optional domain project provider. func (m *Manager) SetAccountEffectiveAuthorization(fn func(context.Context, string) (bool, error), allowImplicitLocal ...bool) { @@ -773,6 +812,11 @@ func (c *runCtx) Emit(typ core.StreamEventType, payload any) error { if err := c.mgr.authorizeRunWork(c.ctx, c.run.Owner, c.run.ProjectID); err != nil { return err } + if c.mgr.projectWorkObservationEnabled && c.run.ProjectID != "" && (typ == core.EvMessageDelta || typ == core.EvThinkingDelta) { + // Project reply text is released only through the committed message after + // the complete run-source manifest receives a domain risk decision. + return nil + } _, err := c.mgr.emit(c.run.ConversationID, c.run.ID, typ, payload) return err } @@ -1172,6 +1216,9 @@ func (c *runCtx) Retrieve(q core.RetrievalQuery) ([]core.RetrievalHit, error) { return nil, err } } + if err := c.requireProjectWorkDecision("model.consume.retrieval"); err != nil { + return nil, err + } return hits, nil } @@ -1328,6 +1375,9 @@ func (c *runCtx) ExecuteTool(call core.ToolCallRequest) core.ToolCallResult { }); err != nil { return core.ToolCallResult{CallID: call.CallID, Status: "error", Output: "project tool result could not be recorded"} } + if err := c.requireProjectWorkDecision("model.consume.tool-result"); err != nil { + return core.ToolCallResult{CallID: call.CallID, Status: "error", Output: err.Error()} + } } // 超长截断并转工件引用（4.10）。 limit := c.prof.Context.MaxToolResultChars @@ -1647,6 +1697,26 @@ func (m *Manager) startClaimedRun(conv core.Conversation, userMessage core.Messa m.releaseConversation(conv.ID) return run, err } + if m.projectWorkObservationEnabled { + if userMessage.ID == "" { + m.releaseConversation(conv.ID) + return run, errors.New("project run requires a committed user message source") + } + var linkErr error + if m.accountEffectiveAuthorization != nil { + linkErr = m.st.SetMessageRunIDAccountChecked(string(run.Owner), string(userMessage.ID), string(run.ID), m.accountAllowImplicitLocal) + } else { + linkErr = m.st.SetMessageRunID(string(userMessage.ID), string(run.ID)) + } + if linkErr != nil { + run.Status, run.Phase = core.RunFailed, core.PhaseDone + run.Error = &core.ErrorPart{Code: "run.project_source_link_failed", Message: linkErr.Error()} + _ = m.st.UpdateRun(&run) + m.releaseConversation(conv.ID) + return run, linkErr + } + userMessage.RunID = run.ID + } ctx, cancel := context.WithCancel(context.Background()) h := &runHandle{owner: run.Owner, cancel: cancel, hitlCh: make(chan hitlAnswer, 1), started: time.Now()} m.mu.Lock() @@ -1735,6 +1805,10 @@ func (m *Manager) execute(rc *runCtx, runner runtime.Runner) { return } m.emit(rc.run.ConversationID, rc.run.ID, core.EvRunPhase, core.RunPhasePayload{Phase: core.PhaseThinking}) + if err := rc.requireProjectWorkDecision("conversation.run"); err != nil { + m.finishRun(rc, core.RunFailed, core.Usage{}, &core.ErrorPart{Code: "run.project_work_blocked", Message: err.Error()}) + return + } execErr := func() (err error) { defer func() { @@ -1804,6 +1878,22 @@ func (m *Manager) finishRun(rc *runCtx, status core.RunStatus, usage core.Usage, msg.VariantIndex = index } } + if msg != nil && status == core.RunCompleted && m.projectWorkObservationEnabled && rc.run.ProjectID != "" { + gateErr := rc.stageAssistantWorkSources(msg.Parts) + if gateErr == nil { + gateErr = rc.requireProjectWorkDecision("assistant.final") + } + if gateErr != nil { + status = core.RunFailed + errPart = &core.ErrorPart{Code: "run.project_reply_blocked", Message: gateErr.Error()} + msg.Parts = []core.Part{{Type: core.PartError, Err: errPart}} + } + } + // HITL/preflight may have moved the persisted run through waiting/running. + // Restore the intended terminal state immediately before the fenced commit. + rc.run.Status = status + rc.run.Phase = core.PhaseDone + rc.run.Error = errPart updated, fenced, err := m.settleRunWithFence(rc, msg) if err != nil { log.Printf("[runmgr] settle run %s: %v", rc.run.ID, err) -- 2.54.0 From b740f8b6f6c78fd971f012e3dfc48e25f201111f Mon Sep 17 00:00:00 2001 From: weichen Date: Thu, 15 Oct 2026 02:33:37 +0000 Subject: [PATCH 21/41] Add optional proofs for an exact human structure decision Why: A model-visible flag cannot prove that a person confirmed one proposal revision and payload hash. Evidence: go test ./pkg/extension ./internal/app ./internal/server -run 'HumanDecision|SurfaceSnapshot|ResolveHuman|NaturalLanguage' passed locally. Impact: SurfaceVersion 2.22.0-experimental adds HumanDecisionVerifier. Existing Host methods stay unchanged, and the base does not consume the proof. Refs: W4b human confirmation design r1 Co-authored-by: Cursor --- cmd/storage-migrate/main.go | 2 +- internal/app/compiled.go | 3 +- internal/app/hostcaps.go | 5 + internal/app/human_decision.go | 104 ++++++++++++ internal/app/human_decision_test.go | 170 +++++++++++++++++++ internal/cmdbus/cmdbus.go | 12 ++ internal/server/human_decision.go | 98 +++++++++++ internal/server/human_decision_test.go | 105 ++++++++++++ internal/server/server.go | 14 +- internal/store/human_decision.go | 215 +++++++++++++++++++++++++ internal/store/migrate.go | 47 ++++++ pkg/extension/extension.go | 5 +- pkg/extension/host.go | 52 ++++++ pkg/extension/surface.txt | 8 + 14 files changed, 835 insertions(+), 5 deletions(-) create mode 100644 internal/app/human_decision.go create mode 100644 internal/app/human_decision_test.go create mode 100644 internal/server/human_decision.go create mode 100644 internal/server/human_decision_test.go create mode 100644 internal/store/human_decision.go diff --git a/cmd/storage-migrate/main.go b/cmd/storage-migrate/main.go index eb395be..d1f00e1 100644 --- a/cmd/storage-migrate/main.go +++ b/cmd/storage-migrate/main.go @@ -286,7 +286,7 @@ func cmdBackup(args []string) error { var copyOrder = []string{ "projects", "users", "account_directory_revision", "profiles", "settings", "plugins", "conversations", "runs", "messages", "project_work_outbox", "events", "artifacts", - "hitl_cards", "plans", "todos", "knowledge", "knowledge_vectors", + "hitl_cards", "human_decisions", "plans", "todos", "knowledge", "knowledge_vectors", "activity_cards", "project_event_shares", "command_audit", "project_audit_links", "prompt_modules", "sessions", "api_keys", "plugin_grants", "plugin_schema", "plugin_kv", "background_tasks", "work_task_bindings", diff --git a/internal/app/compiled.go b/internal/app/compiled.go index 3e001c1..6fa498a 100644 --- a/internal/app/compiled.go +++ b/internal/app/compiled.go @@ -65,7 +65,8 @@ func (r pluginRegistry) AddCommandHandler(spec json.RawMessage, h extension.Hand } return r.bus.RegisterPluginCommand(s, func(ctx context.Context, req cmdbus.Request) (any, error) { host := requestBoundHost{inprocHost{caps: r.caps, pluginID: r.pluginID, owner: req.Owner, actor: req.Actor, - conversationID: core.ID(req.ConversationID), hostProjectID: core.ID(req.HostProjectID)}} + conversationID: core.ID(req.ConversationID), hostProjectID: core.ID(req.HostProjectID), + entrance: req.Entrance, humanGrant: req.HumanGrant}} return h(ctx, host, extension.Request{ ID: req.ID, Params: req.Params, Entrance: req.Entrance, Actor: req.Actor, Owner: req.Owner, ConversationID: req.ConversationID, OperationID: req.OperationID, diff --git a/internal/app/hostcaps.go b/internal/app/hostcaps.go index b7ec921..5e37d3f 100644 --- a/internal/app/hostcaps.go +++ b/internal/app/hostcaps.go @@ -7,7 +7,9 @@ import ( "sort" "strings" "sync" + "time" + "agent-system-backend/internal/cmdbus" "agent-system-backend/internal/ingest" "agent-system-backend/internal/rag" "agent-system-backend/internal/runtime" @@ -33,6 +35,7 @@ type hostcaps struct { set *settings.Service authz *projectAuthz // EXT-8 适配器槽（共享指针；首个注册者生效） surfaces *surfacesvc.Service // EXT-17 Surface 能力槽（nil = 未装配，明确拒绝） + now func() time.Time } // projectAuthz EXT-8 资源授权适配器槽：进程内扩展注册，组合根装配进 Server。 @@ -200,6 +203,8 @@ type inprocHost struct { actor string // EXT-18：分发主体（空＝非 dispatch 上下文） conversationID core.ID // dispatch-bound, never taken from completion arguments hostProjectID core.ID // dispatch project; rechecked against stored conversation + entrance string // dispatch entrance; model tools are "agent" + humanGrant *cmdbus.HumanGrant } func (h inprocHost) requireEffective() error { diff --git a/internal/app/human_decision.go b/internal/app/human_decision.go new file mode 100644 index 0000000..22e01a4 --- /dev/null +++ b/internal/app/human_decision.go @@ -0,0 +1,104 @@ +package app + +import ( + "fmt" + "time" + + "agent-system-backend/internal/cmdbus" + "agent-system-backend/internal/store" + "agent-system-backend/pkg/extension" +) + +func (h inprocHost) clock() time.Time { + if h.caps.now != nil { + return h.caps.now() + } + return time.Now() +} + +func humanCommand(audience string) (string, error) { + if audience == extension.HumanDecisionAudienceStructure { + return "rdm.structure.decide", nil + } + return "", fmt.Errorf("extension: human decision audience is not issued for this host") +} + +func humanEntranceAllowed(entrance string) bool { + switch entrance { + case "button", "card", "api": + return true + default: + return false + } +} + +// IssueHumanDecision opens a pending card for the authenticated person. +// Model-tool, chat, and slash entrances cannot open one. +func (h inprocHost) IssueHumanDecision(binding extension.HumanDecisionBinding, question string) (extension.HumanDecisionCard, error) { + if h.caps.st == nil || h.actor == "" || h.actor != binding.Actor || !humanEntranceAllowed(h.entrance) { + return extension.HumanDecisionCard{}, fmt.Errorf("extension: human decision cannot be issued on this dispatch") + } + commandID, err := humanCommand(binding.Audience) + if err != nil { + return extension.HumanDecisionCard{}, err + } + if binding.ProjectID == "" || binding.ProposalID == "" || binding.ProposalRevision < 1 || binding.PayloadHash == "" { + return extension.HumanDecisionCard{}, fmt.Errorf("extension: human decision binding is incomplete") + } + rec, err := h.caps.st.IssueHumanDecision(store.HumanDecision{ + PluginID: h.pluginID, Audience: binding.Audience, CommandID: commandID, + HumanActor: binding.Actor, Owner: h.owner, ProjectID: binding.ProjectID, + ProposalID: binding.ProposalID, ProposalRevision: binding.ProposalRevision, + PayloadHash: binding.PayloadHash, Question: question, ConversationID: string(h.conversationID), + }, h.clock()) + if err != nil { + return extension.HumanDecisionCard{}, err + } + return extension.HumanDecisionCard{CardID: rec.ID, Question: rec.Question, ExpiresAt: rec.ExpiresAt}, nil +} + +// VerifyHumanDecision reports the persisted human response for this dispatch. +// A model tool, a forged entrance, a mismatched binding, an expired card, or +// a revoked card fails closed. The record stays answered; it is not consumed. +func (h inprocHost) VerifyHumanDecision(expected extension.HumanDecisionBinding) (extension.HumanDecisionProof, error) { + if h.caps.st == nil || h.humanGrant == nil || h.entrance == "agent" || h.actor == "" || h.actor != h.humanGrant.Actor { + return extension.HumanDecisionProof{}, fmt.Errorf("extension: this dispatch has no authenticated human decision") + } + rec, err := h.caps.st.HumanDecision(h.humanGrant.CardID) + if err != nil { + return extension.HumanDecisionProof{}, fmt.Errorf("extension: human decision card is not pending for this dispatch") + } + now := h.clock() + if rec.Status != "responded" || rec.PluginID != h.pluginID || rec.ProofID == "" || rec.ProofID != h.humanGrant.ProofID || + rec.HumanActor != expected.Actor || rec.HumanActor != h.actor || rec.Decision != expected.Decision || + rec.Audience != expected.Audience || rec.ProjectID != expected.ProjectID || rec.ProposalID != expected.ProposalID || + rec.ProposalRevision != expected.ProposalRevision || rec.PayloadHash != expected.PayloadHash || + !now.Before(rec.ExpiresAt) { + return extension.HumanDecisionProof{}, fmt.Errorf("extension: human decision does not match this dispatch") + } + return extension.HumanDecisionProof{ + ProofID: rec.ProofID, Issuer: "agent-system-backend", HumanActor: rec.HumanActor, + Audience: rec.Audience, ProjectID: rec.ProjectID, ProposalID: rec.ProposalID, + Revision: rec.ProposalRevision, PayloadHash: rec.PayloadHash, Decision: rec.Decision, + IssuedAt: rec.IssuedAt, ExpiresAt: rec.ExpiresAt, ConversationID: rec.ConversationID, + HITLResponseRef: rec.ID, + }, nil +} + +// RevokeHumanDecision invalidates a still-pending card. Answered proofs stay +// available until they expire; consumption is not a host concern. +func (h inprocHost) RevokeHumanDecision(cardID string) error { + if h.caps.st == nil || h.actor == "" || !humanEntranceAllowed(h.entrance) { + return fmt.Errorf("extension: human decision cannot be revoked on this dispatch") + } + return h.caps.st.RevokeHumanDecision(h.pluginID, h.actor, cardID) +} + +// HumanGrantFromRecord copies the persisted response onto a dispatch. +// Callers must set it only after an authenticated response or session retry. +func HumanGrantFromRecord(rec store.HumanDecision) *cmdbus.HumanGrant { + if rec.ProofID == "" || rec.Status != "responded" { + return nil + } + return &cmdbus.HumanGrant{CardID: rec.ID, ProofID: rec.ProofID, Actor: rec.HumanActor, Decision: rec.Decision} +} diff --git a/internal/app/human_decision_test.go b/internal/app/human_decision_test.go new file mode 100644 index 0000000..064fc88 --- /dev/null +++ b/internal/app/human_decision_test.go @@ -0,0 +1,170 @@ +package app + +import ( + "testing" + "time" + + "agent-system-backend/internal/cmdbus" + "agent-system-backend/internal/store" + "agent-system-backend/pkg/extension" +) + +func openDecisionStore(t *testing.T) *store.Store { + t.Helper() + st, err := store.OpenSQLite(t.TempDir() + "/decision.db") + if err != nil { + t.Fatal(err) + } + t.Cleanup(func() { st.Close() }) + return st +} + +func decisionHost(st *store.Store, plugin, actor, entrance string, now time.Time, grant *cmdbus.HumanGrant) inprocHost { + return inprocHost{ + caps: hostcaps{st: st, now: func() time.Time { return now }}, + pluginID: plugin, owner: actor, actor: actor, entrance: entrance, humanGrant: grant, + } +} + +func binding(decision, hash string, revision int) extension.HumanDecisionBinding { + return extension.HumanDecisionBinding{ + Audience: extension.HumanDecisionAudienceStructure, Actor: "alice", ProjectID: "p1", + ProposalID: "prop-1", ProposalRevision: revision, PayloadHash: hash, Decision: decision, + } +} + +func TestHumanDecisionAuthenticatedResponse(t *testing.T) { + st := openDecisionStore(t) + now := time.Date(2026, 10, 15, 1, 0, 0, 0, time.UTC) + host := decisionHost(st, "rdm", "alice", "button", now, nil) + card, err := host.IssueHumanDecision(binding("", "hash-1", 1), "确认结构变更") + if err != nil { + t.Fatal(err) + } + answered, err := st.RespondHumanDecision("alice", card.CardID, "accept", now) + if err != nil { + t.Fatal(err) + } + host.humanGrant = &cmdbus.HumanGrant{CardID: answered.ID, ProofID: answered.ProofID, Actor: "alice", Decision: "accept"} + host.entrance = "card" + proof, err := host.VerifyHumanDecision(binding("accept", "hash-1", 1)) + if err != nil { + t.Fatal(err) + } + if proof.ProofID == "" || proof.Issuer != "agent-system-backend" || proof.HumanActor != "alice" || + proof.HITLResponseRef != card.CardID || proof.PayloadHash != "hash-1" { + t.Fatalf("proof = %+v", proof) + } + again, err := host.VerifyHumanDecision(binding("accept", "hash-1", 1)) + if err != nil || again.ProofID != proof.ProofID { + t.Fatalf("second verify consumed or changed the proof: %v %+v", err, again) + } + stored, err := st.HumanDecision(card.CardID) + if err != nil || stored.Status != "responded" { + t.Fatalf("host consumed the proof, status=%s err=%v", stored.Status, err) + } +} + +func TestHumanDecisionRejectsUntrustedDispatch(t *testing.T) { + st := openDecisionStore(t) + now := time.Date(2026, 10, 15, 1, 0, 0, 0, time.UTC) + host := decisionHost(st, "rdm", "alice", "button", now, nil) + card, err := host.IssueHumanDecision(binding("", "hash-1", 1), "确认") + if err != nil { + t.Fatal(err) + } + answered, err := st.RespondHumanDecision("alice", card.CardID, "accept", now) + if err != nil { + t.Fatal(err) + } + grant := &cmdbus.HumanGrant{CardID: answered.ID, ProofID: answered.ProofID, Actor: "alice", Decision: "accept"} + expect := binding("accept", "hash-1", 1) + + agent := decisionHost(st, "rdm", "alice", "agent", now, grant) + if _, err := agent.VerifyHumanDecision(expect); err == nil { + t.Fatal("model tool dispatch verified a human decision") + } + forged := decisionHost(st, "rdm", "alice", "card", now, nil) + if _, err := forged.VerifyHumanDecision(expect); err == nil { + t.Fatal("forged entrance verified without a host grant") + } + if _, err := decisionHost(st, "rdm", "alice", "agent", now, nil).IssueHumanDecision(binding("", "hash-2", 1), "x"); err == nil { + t.Fatal("model tool issued a human decision card") + } + if _, err := decisionHost(st, "other", "alice", "card", now, grant).VerifyHumanDecision(expect); err == nil { + t.Fatal("another plugin reused the proof") + } + other := expect + other.ProposalID = "prop-2" + if _, err := decisionHost(st, "rdm", "alice", "card", now, grant).VerifyHumanDecision(other); err == nil { + t.Fatal("proof authorized a second proposal") + } + wrongActor := expect + wrongActor.Actor = "bob" + if _, err := decisionHost(st, "rdm", "bob", "card", now, grant).VerifyHumanDecision(wrongActor); err == nil { + t.Fatal("wrong actor verified") + } + wrongProject := expect + wrongProject.ProjectID = "p2" + if _, err := decisionHost(st, "rdm", "alice", "card", now, grant).VerifyHumanDecision(wrongProject); err == nil { + t.Fatal("wrong project verified") + } + wrongRev := expect + wrongRev.ProposalRevision = 2 + if _, err := decisionHost(st, "rdm", "alice", "card", now, grant).VerifyHumanDecision(wrongRev); err == nil { + t.Fatal("wrong revision verified") + } + wrongHash := expect + wrongHash.PayloadHash = "hash-changed" + if _, err := decisionHost(st, "rdm", "alice", "card", now, grant).VerifyHumanDecision(wrongHash); err == nil { + t.Fatal("wrong payload hash verified") + } + if _, err := decisionHost(st, "rdm", "alice", "button", now, nil).IssueHumanDecision( + extension.HumanDecisionBinding{Audience: "other.plugin", Actor: "alice", ProjectID: "p1", ProposalID: "prop-1", ProposalRevision: 1, PayloadHash: "h"}, + "x"); err == nil { + t.Fatal("foreign audience was issued") + } +} + +func TestHumanDecisionCardChangeExpiryAndRevoke(t *testing.T) { + st := openDecisionStore(t) + now := time.Date(2026, 10, 15, 1, 0, 0, 0, time.UTC) + host := decisionHost(st, "rdm", "alice", "api", now, nil) + first, err := host.IssueHumanDecision(binding("", "hash-1", 1), "旧卡") + if err != nil { + t.Fatal(err) + } + if _, err := host.IssueHumanDecision(binding("", "hash-2", 2), "新卡"); err != nil { + t.Fatal(err) + } + if _, err := st.RespondHumanDecision("alice", first.CardID, "accept", now); err == nil { + t.Fatal("changed card still accepted the old confirmation") + } + current, err := host.IssueHumanDecision(binding("", "hash-3", 3), "待撤销") + if err != nil { + t.Fatal(err) + } + if err := host.RevokeHumanDecision(current.CardID); err != nil { + t.Fatal(err) + } + if _, err := st.RespondHumanDecision("alice", current.CardID, "accept", now); err == nil { + t.Fatal("revoked card was answered") + } + live, err := host.IssueHumanDecision(binding("", "hash-4", 4), "会过期") + if err != nil { + t.Fatal(err) + } + if _, err := st.RespondHumanDecision("alice", live.CardID, "accept", now.Add(16*time.Minute)); err == nil { + t.Fatal("expired card was answered") + } +} + +func TestMissingHumanDecisionStoreFailsClosed(t *testing.T) { + host := decisionHost(nil, "rdm", "alice", "button", time.Now(), nil) + if _, err := host.IssueHumanDecision(binding("", "hash-1", 1), "x"); err == nil { + t.Fatal("missing store issued a card") + } + if _, err := host.VerifyHumanDecision(binding("accept", "hash-1", 1)); err == nil { + t.Fatal("missing store verified a decision") + } +} diff --git a/internal/cmdbus/cmdbus.go b/internal/cmdbus/cmdbus.go index 2f5354a..48bae9d 100644 --- a/internal/cmdbus/cmdbus.go +++ b/internal/cmdbus/cmdbus.go @@ -101,6 +101,18 @@ type Request struct { AnchorMessageID string // 确认卡锚定的发起消息（内联渲染） Confirmed bool // 危险命令经确认卡放行后的执行 HostProjectID string // EXT-18：分发所属基座项目（空＝无项目上下文） + // HumanGrant is set only by the authenticated session path or the human + // decision resolver. Client JSON and agent tool dispatch leave it nil. + HumanGrant *HumanGrant +} + +// HumanGrant ties this dispatch to one persisted human response. +// It is not a secret token and is not read from command params. +type HumanGrant struct { + CardID string + ProofID string + Actor string + Decision string } // Response 分发结果：回执 + 处理负载 + 可能的确认卡。 diff --git a/internal/server/human_decision.go b/internal/server/human_decision.go new file mode 100644 index 0000000..a213c18 --- /dev/null +++ b/internal/server/human_decision.go @@ -0,0 +1,98 @@ +package server + +import ( + "errors" + "net/http" + "strconv" + "strings" + "time" + + "agent-system-backend/internal/cmdbus" + "agent-system-backend/internal/store" + "agent-system-core" +) + +// resolveHumanDecision handles a card issued by HumanDecisionVerifier. +// Ordinary HITL cards return handled=false and keep the existing run path. +func (s *Server) resolveHumanDecision(w http.ResponseWriter, r *http.Request, resp core.HITLResponse) (bool, error) { + rec, err := s.st.HumanDecision(string(resp.CardID)) + if errors.Is(err, store.ErrNotFound) { + return false, nil + } + if err != nil { + return true, err + } + decision := resp.ChoiceID + if decision == "" { + switch strings.TrimSpace(resp.FreeText) { + case "批准", "接受", "同意": + pending, perr := s.st.PendingHumanDecisions(s.owner(r), time.Now()) + if perr != nil { + return true, perr + } + if len(pending) != 1 || pending[0].ID != rec.ID { + return true, errors.New("human decision text matches more than one pending card") + } + decision = "accept" + default: + return true, errors.New("human decision requires an explicit choice") + } + } + answered, err := s.st.RespondHumanDecision(s.owner(r), rec.ID, decision, time.Now()) + if err != nil { + return true, err + } + out := map[string]any{ + "resolved": true, "proofId": answered.ProofID, "decision": answered.Decision, + "proposalId": answered.ProposalID, "proposalRevision": answered.ProposalRevision, + } + if s.Bus != nil && answered.CommandID != "" { + follow := s.Bus.Dispatch(r.Context(), cmdbus.Request{ + ID: answered.CommandID, + Params: map[string]any{ + "projectId": answered.ProjectID, "proposalId": answered.ProposalID, + "proposalRevision": answered.ProposalRevision, "payloadHash": answered.PayloadHash, + "decision": answered.Decision, + }, + Entrance: "card", Actor: answered.HumanActor, Owner: s.owner(r), + ConversationID: answered.ConversationID, + HumanGrant: &cmdbus.HumanGrant{ + CardID: answered.ID, ProofID: answered.ProofID, + Actor: answered.HumanActor, Decision: answered.Decision, + }, + }) + out["receipt"] = follow.Receipt + if follow.Payload != nil { + out["payload"] = follow.Payload + } + } + writeJSON(w, http.StatusOK, out) + return true, nil +} + +func (s *Server) sessionHumanGrant(actor, commandID string, params map[string]any) (*cmdbus.HumanGrant, bool) { + if commandID != "rdm.structure.decide" || s.st == nil { + return nil, false + } + project, _ := params["projectId"].(string) + proposal, _ := params["proposalId"].(string) + hash, _ := params["payloadHash"].(string) + decision, _ := params["decision"].(string) + revision := 0 + switch v := params["proposalRevision"].(type) { + case float64: + revision = int(v) + case int: + revision = v + case string: + revision, _ = strconv.Atoi(v) + } + if project == "" || proposal == "" || hash == "" || decision == "" || revision < 1 { + return nil, false + } + rec, err := s.st.SessionHumanGrant(actor, commandID, project, proposal, hash, decision, revision, time.Now()) + if err != nil { + return nil, false + } + return &cmdbus.HumanGrant{CardID: rec.ID, ProofID: rec.ProofID, Actor: rec.HumanActor, Decision: rec.Decision}, true +} diff --git a/internal/server/human_decision_test.go b/internal/server/human_decision_test.go new file mode 100644 index 0000000..0ce6550 --- /dev/null +++ b/internal/server/human_decision_test.go @@ -0,0 +1,105 @@ +package server + +import ( + "context" + "net/http/httptest" + "testing" + "time" + + agentcommand "agent-command" + "agent-system-backend/internal/cmdbus" + "agent-system-backend/internal/store" + "agent-system-backend/pkg/extension" + "agent-system-core" +) + +type nopHumanAudit struct{} + +func (nopHumanAudit) AppendAudit(string, agentcommand.AuditEnvelope) error { return nil } + +func TestResolveHumanDecisionBindsFollowUpAndRetry(t *testing.T) { + st, err := store.OpenSQLite(t.TempDir() + "/decision.db") + if err != nil { + t.Fatal(err) + } + t.Cleanup(func() { st.Close() }) + issued, err := st.IssueHumanDecision(store.HumanDecision{ + PluginID: "rdm", Audience: extension.HumanDecisionAudienceStructure, + CommandID: "rdm.structure.decide", HumanActor: "alice", Owner: "alice", + ProjectID: "p1", ProposalID: "prop-1", ProposalRevision: 1, + PayloadHash: "hash-1", Question: "确认结构变更", + }, time.Now().UTC()) + if err != nil { + t.Fatal(err) + } + var got *cmdbus.HumanGrant + bus := cmdbus.New(nopHumanAudit{}, nil, nil) + if err := bus.RegisterPluginCommand(agentcommand.CommandSpec{ID: "rdm.structure.decide", Title: "确认结构"}, + func(_ context.Context, req cmdbus.Request) (any, error) { + got = req.HumanGrant + if req.Params["confirmed"] != nil { + t.Fatal("follow-up copied a client confirmation flag") + } + return map[string]any{"applied": true}, nil + }); err != nil { + t.Fatal(err) + } + s := &Server{st: st, Bus: bus} + rec := httptest.NewRecorder() + req := httptest.NewRequest("POST", "/api/hitl/"+issued.ID+"/resolve", nil) + req = req.WithContext(context.WithValue(req.Context(), ownerCtxKey{}, "alice")) + handled, err := s.resolveHumanDecision(rec, req, core.HITLResponse{CardID: core.ID(issued.ID), ChoiceID: "accept"}) + if err != nil || !handled { + t.Fatalf("resolve handled=%v err=%v body=%s", handled, err, rec.Body.String()) + } + if got == nil || got.Actor != "alice" || got.ProofID == "" || got.CardID != issued.ID { + t.Fatalf("follow-up grant = %+v", got) + } + grant, ok := s.sessionHumanGrant("alice", "rdm.structure.decide", map[string]any{ + "projectId": "p1", "proposalId": "prop-1", "proposalRevision": float64(1), + "payloadHash": "hash-1", "decision": "accept", "confirmed": true, + }) + if !ok || grant.ProofID != got.ProofID { + t.Fatalf("retry grant = %+v ok=%v", grant, ok) + } + if _, ok := s.sessionHumanGrant("bob", "rdm.structure.decide", map[string]any{ + "projectId": "p1", "proposalId": "prop-1", "proposalRevision": float64(1), + "payloadHash": "hash-1", "decision": "accept", + }); ok { + t.Fatal("another actor received the grant") + } +} + +func TestNaturalLanguageApprovalRequiresOnePendingCard(t *testing.T) { + st, err := store.OpenSQLite(t.TempDir() + "/decision.db") + if err != nil { + t.Fatal(err) + } + t.Cleanup(func() { st.Close() }) + now := time.Now().UTC() + first, err := st.IssueHumanDecision(store.HumanDecision{ + PluginID: "rdm", Audience: extension.HumanDecisionAudienceStructure, + CommandID: "rdm.structure.decide", HumanActor: "alice", Owner: "alice", + ProjectID: "p1", ProposalID: "prop-1", ProposalRevision: 1, + PayloadHash: "hash-1", Question: "第一张", + }, now) + if err != nil { + t.Fatal(err) + } + if _, err := st.IssueHumanDecision(store.HumanDecision{ + PluginID: "rdm", Audience: extension.HumanDecisionAudienceStructure, + CommandID: "rdm.structure.decide", HumanActor: "alice", Owner: "alice", + ProjectID: "p1", ProposalID: "prop-2", ProposalRevision: 1, + PayloadHash: "hash-2", Question: "第二张", + }, now); err != nil { + t.Fatal(err) + } + s := &Server{st: st} + rec := httptest.NewRecorder() + req := httptest.NewRequest("POST", "/api/hitl/"+first.ID+"/resolve", nil) + req = req.WithContext(context.WithValue(req.Context(), ownerCtxKey{}, "alice")) + handled, err := s.resolveHumanDecision(rec, req, core.HITLResponse{CardID: core.ID(first.ID), FreeText: "批准"}) + if !handled || err == nil { + t.Fatal("ambiguous natural-language approval was accepted") + } +} diff --git a/internal/server/server.go b/internal/server/server.go index c183f7c..896dc2e 100644 --- a/internal/server/server.go +++ b/internal/server/server.go @@ -1297,11 +1297,15 @@ func (s *Server) execCommand(w http.ResponseWriter, r *http.Request) { } } - resp := s.Bus.Dispatch(r.Context(), cmdbus.Request{ + dispatch := cmdbus.Request{ ID: r.PathValue("id"), Params: body.Params, Entrance: body.Entrance, Actor: s.owner(r), Owner: s.owner(r), ConversationID: body.ConversationID, AnchorMessageID: body.AnchorMessageID, HostProjectID: hostProject, - }) + } + if grant, ok := s.sessionHumanGrant(s.owner(r), dispatch.ID, body.Params); ok { + dispatch.HumanGrant = grant + } + resp := s.Bus.Dispatch(r.Context(), dispatch) code := http.StatusOK if resp.Receipt.State == agentcommand.StateRejected { code = http.StatusBadRequest @@ -1371,6 +1375,12 @@ func (s *Server) resolveHITL(w http.ResponseWriter, r *http.Request) { return } resp.CardID = r.PathValue("id") + if handled, err := s.resolveHumanDecision(w, r, resp); handled { + if err != nil { + writeStoreErr(w, err) + } + return + } if s.projectLifecycle != nil { card, err := s.st.GetHITLCard(s.owner(r), resp.CardID) if err != nil { diff --git a/internal/store/human_decision.go b/internal/store/human_decision.go new file mode 100644 index 0000000..0742ff4 --- /dev/null +++ b/internal/store/human_decision.go @@ -0,0 +1,215 @@ +package store + +import ( + "crypto/sha256" + "database/sql" + "encoding/hex" + "errors" + "fmt" + "time" +) + +const humanDecisionTTL = 15 * time.Minute + +// HumanDecision is the base's record of one pending or answered human card. +// Status stays "responded" after a proof is issued. Consumption belongs to +// the caller that receives the proof, not to this table. +type HumanDecision struct { + ID string + PluginID string + Audience string + CommandID string + HumanActor string + Owner string + ProjectID string + ProposalID string + ProposalRevision int + PayloadHash string + Question string + Status string + Decision string + ProofID string + ConversationID string + IssuedAt time.Time + ExpiresAt time.Time + RespondedAt time.Time +} + +func humanProofID(cardID, decision, payloadHash string) string { + sum := sha256.Sum256([]byte(cardID + "\n" + decision + "\n" + payloadHash)) + return "hdp-" + hex.EncodeToString(sum[:16]) +} + +// IssueHumanDecision persists a pending card and revokes older pending cards +// for the same proposal. A changed card cannot keep an earlier confirmation. +func (s *Store) IssueHumanDecision(rec HumanDecision, now time.Time) (HumanDecision, error) { + if rec.PluginID == "" || rec.Audience == "" || rec.CommandID == "" || rec.HumanActor == "" || + rec.Owner == "" || rec.ProjectID == "" || rec.ProposalID == "" || rec.ProposalRevision < 1 || + rec.PayloadHash == "" || rec.Question == "" { + return HumanDecision{}, fmt.Errorf("store: incomplete human decision") + } + rec.ID = newID("hd") + rec.Status = "pending" + rec.Decision = "" + rec.ProofID = "" + rec.IssuedAt = now.UTC() + rec.ExpiresAt = now.UTC().Add(humanDecisionTTL) + tx, err := s.db.Begin() + if err != nil { + return HumanDecision{}, err + } + defer tx.Rollback() + if _, err := tx.Exec(s.q(`UPDATE human_decisions SET status='revoked' + WHERE plugin_id=? AND audience=? AND project_id=? AND proposal_id=? AND status='pending'`), + rec.PluginID, rec.Audience, rec.ProjectID, rec.ProposalID); err != nil { + return HumanDecision{}, err + } + if _, err := tx.Exec(s.q(`INSERT INTO human_decisions( + id,plugin_id,audience,command_id,human_actor,owner,project_id,proposal_id,proposal_revision, + payload_hash,question,status,decision,proof_id,conversation_id,issued_at,expires_at,responded_at) + VALUES(?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?)`), + rec.ID, rec.PluginID, rec.Audience, rec.CommandID, rec.HumanActor, rec.Owner, rec.ProjectID, + rec.ProposalID, rec.ProposalRevision, rec.PayloadHash, rec.Question, rec.Status, "", "", + rec.ConversationID, rec.IssuedAt.Format(time.RFC3339Nano), rec.ExpiresAt.Format(time.RFC3339Nano), ""); err != nil { + return HumanDecision{}, err + } + if err := tx.Commit(); err != nil { + return HumanDecision{}, err + } + return rec, nil +} + +func (s *Store) HumanDecision(id string) (HumanDecision, error) { + row := s.db.QueryRow(s.q(`SELECT id,plugin_id,audience,command_id,human_actor,owner,project_id,proposal_id, + proposal_revision,payload_hash,question,status,decision,proof_id,conversation_id,issued_at,expires_at,responded_at + FROM human_decisions WHERE id=?`), id) + return scanHumanDecision(row) +} + +// RespondHumanDecision records the authenticated person's choice. It does not +// mark the proof consumed. Repeating a resolved card fails closed. +func (s *Store) RespondHumanDecision(actor, cardID, decision string, now time.Time) (HumanDecision, error) { + if decision != "accept" && decision != "reject" && decision != "cancel" { + return HumanDecision{}, fmt.Errorf("store: human decision must be accept, reject, or cancel") + } + rec, err := s.HumanDecision(cardID) + if err != nil { + return HumanDecision{}, err + } + if rec.HumanActor != actor { + return HumanDecision{}, fmt.Errorf("store: human decision actor mismatch") + } + if rec.Status == "revoked" { + return HumanDecision{}, fmt.Errorf("store: human decision revoked") + } + if rec.Status != "pending" { + return HumanDecision{}, fmt.Errorf("store: human decision already answered") + } + if !now.Before(rec.ExpiresAt) { + return HumanDecision{}, fmt.Errorf("store: human decision expired") + } + proof := humanProofID(rec.ID, decision, rec.PayloadHash) + responded := now.UTC() + res, err := s.db.Exec(s.q(`UPDATE human_decisions SET status='responded', decision=?, proof_id=?, responded_at=? + WHERE id=? AND status='pending'`), decision, proof, responded.Format(time.RFC3339Nano), cardID) + if err != nil { + return HumanDecision{}, err + } + if n, _ := res.RowsAffected(); n == 0 { + return HumanDecision{}, fmt.Errorf("store: human decision already answered") + } + rec.Status = "responded" + rec.Decision = decision + rec.ProofID = proof + rec.RespondedAt = responded + return rec, nil +} + +// RevokeHumanDecision invalidates a card before it is answered. The same +// actor who was asked, and only that actor, may revoke it. +func (s *Store) RevokeHumanDecision(pluginID, actor, cardID string) error { + res, err := s.db.Exec(s.q(`UPDATE human_decisions SET status='revoked' + WHERE id=? AND plugin_id=? AND human_actor=? AND status='pending'`), cardID, pluginID, actor) + if err != nil { + return err + } + if n, _ := res.RowsAffected(); n == 0 { + return fmt.Errorf("store: human decision cannot be revoked") + } + return nil +} + +// PendingHumanDecisions returns unanswered cards for one actor. +func (s *Store) PendingHumanDecisions(actor string, now time.Time) ([]HumanDecision, error) { + rows, err := s.db.Query(s.q(`SELECT id,plugin_id,audience,command_id,human_actor,owner,project_id,proposal_id, + proposal_revision,payload_hash,question,status,decision,proof_id,conversation_id,issued_at,expires_at,responded_at + FROM human_decisions WHERE human_actor=? AND status='pending' ORDER BY issued_at`), actor) + if err != nil { + return nil, err + } + defer rows.Close() + var out []HumanDecision + for rows.Next() { + rec, err := scanHumanDecision(rows) + if err != nil { + return nil, err + } + if now.Before(rec.ExpiresAt) { + out = append(out, rec) + } + } + return out, rows.Err() +} + +// SessionHumanGrant returns the grant for an authenticated retry of the exact +// answered card. It does not consume the proof. Missing or mismatched input +// is ErrNotFound so callers can leave the dispatch ungranted. +func (s *Store) SessionHumanGrant(actor, commandID, projectID, proposalID, payloadHash, decision string, revision int, now time.Time) (HumanDecision, error) { + row := s.db.QueryRow(s.q(`SELECT id,plugin_id,audience,command_id,human_actor,owner,project_id,proposal_id, + proposal_revision,payload_hash,question,status,decision,proof_id,conversation_id,issued_at,expires_at,responded_at + FROM human_decisions + WHERE human_actor=? AND command_id=? AND project_id=? AND proposal_id=? AND proposal_revision=? + AND payload_hash=? AND decision=? AND status='responded'`), + actor, commandID, projectID, proposalID, revision, payloadHash, decision) + rec, err := scanHumanDecision(row) + if err != nil { + return HumanDecision{}, err + } + if !now.Before(rec.ExpiresAt) { + return HumanDecision{}, ErrNotFound + } + return rec, nil +} + +type humanScanner interface { + Scan(dest ...any) error +} + +func scanHumanDecision(row humanScanner) (HumanDecision, error) { + var rec HumanDecision + var issued, expires, responded string + err := row.Scan(&rec.ID, &rec.PluginID, &rec.Audience, &rec.CommandID, &rec.HumanActor, &rec.Owner, + &rec.ProjectID, &rec.ProposalID, &rec.ProposalRevision, &rec.PayloadHash, &rec.Question, &rec.Status, + &rec.Decision, &rec.ProofID, &rec.ConversationID, &issued, &expires, &responded) + if errors.Is(err, sql.ErrNoRows) { + return HumanDecision{}, ErrNotFound + } + if err != nil { + return HumanDecision{}, err + } + rec.IssuedAt, err = time.Parse(time.RFC3339Nano, issued) + if err != nil { + return HumanDecision{}, err + } + rec.ExpiresAt, err = time.Parse(time.RFC3339Nano, expires) + if err != nil { + return HumanDecision{}, err + } + if responded != "" { + rec.RespondedAt, err = time.Parse(time.RFC3339Nano, responded) + if err != nil { + return HumanDecision{}, err + } + } + return rec, nil +} diff --git a/internal/store/migrate.go b/internal/store/migrate.go index dac2467..729160d 100644 --- a/internal/store/migrate.go +++ b/internal/store/migrate.go @@ -1094,6 +1094,53 @@ func init() { "sqlite": {`DROP INDEX IF EXISTS idx_project_work_outbox_pending`, `DROP TABLE IF EXISTS project_work_outbox`}, "postgres": {`DROP INDEX IF EXISTS idx_project_work_outbox_pending`, `DROP TABLE IF EXISTS project_work_outbox`}, }}, + migration{version: 45, name: "human_decision_proofs", + up: map[string][]string{ + "sqlite": {`CREATE TABLE human_decisions ( + id TEXT PRIMARY KEY, + plugin_id TEXT NOT NULL, + audience TEXT NOT NULL, + command_id TEXT NOT NULL, + human_actor TEXT NOT NULL, + owner TEXT NOT NULL, + project_id TEXT NOT NULL, + proposal_id TEXT NOT NULL, + proposal_revision INTEGER NOT NULL, + payload_hash TEXT NOT NULL, + question TEXT NOT NULL, + status TEXT NOT NULL, + decision TEXT NOT NULL DEFAULT '', + proof_id TEXT NOT NULL DEFAULT '', + conversation_id TEXT NOT NULL DEFAULT '', + issued_at TEXT NOT NULL, + expires_at TEXT NOT NULL, + responded_at TEXT NOT NULL DEFAULT '' + )`, `CREATE INDEX idx_human_decisions_pending ON human_decisions(human_actor, status, proposal_id)`}, + "postgres": {`CREATE TABLE human_decisions ( + id TEXT PRIMARY KEY, + plugin_id TEXT NOT NULL, + audience TEXT NOT NULL, + command_id TEXT NOT NULL, + human_actor TEXT NOT NULL, + owner TEXT NOT NULL, + project_id TEXT NOT NULL, + proposal_id TEXT NOT NULL, + proposal_revision INTEGER NOT NULL, + payload_hash TEXT NOT NULL, + question TEXT NOT NULL, + status TEXT NOT NULL, + decision TEXT NOT NULL DEFAULT '', + proof_id TEXT NOT NULL DEFAULT '', + conversation_id TEXT NOT NULL DEFAULT '', + issued_at TEXT NOT NULL, + expires_at TEXT NOT NULL, + responded_at TEXT NOT NULL DEFAULT '' + )`, `CREATE INDEX idx_human_decisions_pending ON human_decisions(human_actor, status, proposal_id)`}, + }, + down: map[string][]string{ + "sqlite": {`DROP INDEX IF EXISTS idx_human_decisions_pending`, `DROP TABLE IF EXISTS human_decisions`}, + "postgres": {`DROP INDEX IF EXISTS idx_human_decisions_pending`, `DROP TABLE IF EXISTS human_decisions`}, + }}, ) } diff --git a/pkg/extension/extension.go b/pkg/extension/extension.go index 7468b4b..e20957f 100644 --- a/pkg/extension/extension.go +++ b/pkg/extension/extension.go @@ -52,7 +52,10 @@ import ( // X2 project audit capabilities on one Backend surface. // 2.21.0-experimental: optional ProjectWorkObservationRegistry; host-origin // work-source observations and project action decisions (X3 contract). -const SurfaceVersion = "2.21.0-experimental" +// 2.22.0-experimental: optional HumanDecisionVerifier. The host proves that +// this dispatch is an authenticated human response to one exact pending card. +// It does not consume the proof; the caller does that in its own transaction. +const SurfaceVersion = "2.22.0-experimental" // ErrNotLinked 表示进程没有空白导入 link 包，Main 无法启动服务。 var ErrNotLinked = errors.New("extension: runner not linked; blank-import agent-system-backend/pkg/extension/link") diff --git a/pkg/extension/host.go b/pkg/extension/host.go index df21509..5b85c4c 100644 --- a/pkg/extension/host.go +++ b/pkg/extension/host.go @@ -2,6 +2,7 @@ package extension import ( "context" + "time" core "agent-system-core" ) @@ -46,6 +47,7 @@ type Handler func(ctx context.Context, h Host, req Request) (any, error) // - SurfaceHost — EXT-17：页面保存/读取 // - WorkCompletionHost — X1：受信项目工作生成 // - WorkTaskHost — X1：分发期建立可恢复的受信项目任务绑定 +// - HumanDecisionVerifier — 本次分发是否为认证人对确切待确认卡的响应 type Host interface { // PluginID 返回注册处理器的插件标识（形如 rdm）。 PluginID() string @@ -92,3 +94,53 @@ type Host interface { } // —— AdminProvider 定义移至本文件上方（Request 之后）—— + +// HumanDecisionAudienceStructure is the only audience this proof can authorize. +// Another plugin cannot reuse the same human response as its own confirmation. +const HumanDecisionAudienceStructure = "rdm.structure.decide" + +// HumanDecisionBinding is the exact object a human must have confirmed. +// Callers pass it to the host; they do not carry a copyable secret. +type HumanDecisionBinding struct { + Audience string + Actor string + ProjectID string + ProposalID string + ProposalRevision int + PayloadHash string + Decision string +} + +// HumanDecisionCard is the pending object a person confirms. +type HumanDecisionCard struct { + CardID string + Question string + ExpiresAt time.Time +} + +// HumanDecisionProof is a read-only statement that a person already responded. +// ProofID is a consumption key for the caller. The host does not mark it used. +type HumanDecisionProof struct { + ProofID string + Issuer string + HumanActor string + Audience string + ProjectID string + ProposalID string + Revision int + PayloadHash string + Decision string + IssuedAt time.Time + ExpiresAt time.Time + ConversationID string + RunID string + HITLResponseRef string +} + +// HumanDecisionVerifier is optional. A missing assertion means the capability +// is absent and the caller must refuse the write. +type HumanDecisionVerifier interface { + IssueHumanDecision(binding HumanDecisionBinding, question string) (HumanDecisionCard, error) + VerifyHumanDecision(expected HumanDecisionBinding) (HumanDecisionProof, error) + RevokeHumanDecision(cardID string) error +} diff --git a/pkg/extension/surface.txt b/pkg/extension/surface.txt index 4e52b4a..20a6315 100644 --- a/pkg/extension/surface.txt +++ b/pkg/extension/surface.txt @@ -52,6 +52,14 @@ Host.TaskCreate Host.TaskUpdate HostAuditReceipt HostClient +HumanDecisionAudienceStructure +HumanDecisionBinding +HumanDecisionCard +HumanDecisionProof +HumanDecisionVerifier +HumanDecisionVerifier.IssueHumanDecision +HumanDecisionVerifier.RevokeHumanDecision +HumanDecisionVerifier.VerifyHumanDecision InProc IntentSpec Main -- 2.54.0 From a4d6404c5ff9fecd2c0d40d94c6896773f797ba4 Mon Sep 17 00:00:00 2001 From: weichen Date: Thu, 15 Oct 2026 03:39:15 +0000 Subject: [PATCH 22/41] Register the human decision migration as readable by old binaries Why: The new confirmation table is additive, and the compatibility ledger must name that fact or the store suite rejects the schema. Evidence: SELF go test ./internal/store/ -run TestMigrationCompatRegistered passed after the registration. Impact: Old readers keep their current floor. They do not need to understand human decision rows. Refs: W4b human confirmation design r1 Co-authored-by: Cursor --- internal/store/migrate_compat.go | 1 + 1 file changed, 1 insertion(+) diff --git a/internal/store/migrate_compat.go b/internal/store/migrate_compat.go index 97d8efd..2617323 100644 --- a/internal/store/migrate_compat.go +++ b/internal/store/migrate_compat.go @@ -49,6 +49,7 @@ var migrationBreaksOldReaders = map[int]bool{ 42: false, // project_audit_committed_prefix：PG 审计 ID 默认函数，旧读者兼容 43: false, // project_audit_all_writers_guard：PG 在线审计写入门禁，旧读者兼容 44: false, // project_work_observation_outbox：独立私域投递表，旧读者不读取 + 45: false, // human_decision_proofs：独立真人确认表，旧读者不读取 } // SchemaTarget 是本二进制会迁移到的 schema 版本。 -- 2.54.0 From 451aa4995405b26271c6a388b40d24957166da97 Mon Sep 17 00:00:00 2001 From: weichen Date: Thu, 15 Oct 2026 06:01:32 +0000 Subject: [PATCH 23/41] Alias the core package consistently Why: An interrupted import cleanup removed the cmdbus core import while two human-decision files used an explicit alias. Evidence: go test ./internal/cmdbus ./internal/server passes. Impact: The backend worktree is buildable and consistently names the core package without behavior changes. Refs: W4b human decision verifier --- internal/cmdbus/cmdbus.go | 2 +- internal/server/human_decision.go | 2 +- internal/server/human_decision_test.go | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/internal/cmdbus/cmdbus.go b/internal/cmdbus/cmdbus.go index 48bae9d..b3b7621 100644 --- a/internal/cmdbus/cmdbus.go +++ b/internal/cmdbus/cmdbus.go @@ -16,7 +16,7 @@ import ( "time" agentcommand "agent-command" - "agent-system-core" + core "agent-system-core" ) // AuditStore 审计落盘端口（store 实现；v7 建表、v18 加 owner 列）。 diff --git a/internal/server/human_decision.go b/internal/server/human_decision.go index a213c18..b792b32 100644 --- a/internal/server/human_decision.go +++ b/internal/server/human_decision.go @@ -1,6 +1,7 @@ package server import ( + core "agent-system-core" "errors" "net/http" "strconv" @@ -9,7 +10,6 @@ import ( "agent-system-backend/internal/cmdbus" "agent-system-backend/internal/store" - "agent-system-core" ) // resolveHumanDecision handles a card issued by HumanDecisionVerifier. diff --git a/internal/server/human_decision_test.go b/internal/server/human_decision_test.go index 0ce6550..55fcbe5 100644 --- a/internal/server/human_decision_test.go +++ b/internal/server/human_decision_test.go @@ -1,6 +1,7 @@ package server import ( + core "agent-system-core" "context" "net/http/httptest" "testing" @@ -10,7 +11,6 @@ import ( "agent-system-backend/internal/cmdbus" "agent-system-backend/internal/store" "agent-system-backend/pkg/extension" - "agent-system-core" ) type nopHumanAudit struct{} -- 2.54.0 From 99f1d3b3ddb43cdf69993dde16025248b297e51e Mon Sep 17 00:00:00 2001 From: weichen Date: Thu, 15 Oct 2026 06:22:20 +0000 Subject: [PATCH 24/41] Recheck project sources after clarification Why: Accepted retrieval and tool sources could become stale, and a pending HITL answer could release a changed source set. Evidence: App and run-manager suites cover per-preflight resource verification, authorization epochs, and a second exact-source preflight after HITL. Impact: Project work fails closed when authorization, source bytes, run binding, or the source watermark changes. Refs: TT-N03 TT-R01 --- internal/app/project_work_observation.go | 13 ++++++++++++- internal/app/project_work_observation_test.go | 14 +++++++++----- internal/runmgr/project_work_gate.go | 14 ++++++++++++-- internal/runmgr/project_work_gate_test.go | 14 +++++++++----- 4 files changed, 42 insertions(+), 13 deletions(-) diff --git a/internal/app/project_work_observation.go b/internal/app/project_work_observation.go index 3fb56dc..9c76b20 100644 --- a/internal/app/project_work_observation.go +++ b/internal/app/project_work_observation.go @@ -135,12 +135,18 @@ func deliverProjectWorkRows(ctx context.Context, st *store.Store, provider *exte if err != nil || !allowed { return completed, fmt.Errorf("project work source %s: current project authorization denied", row.EventID) } + account, err := st.GetAccountByOwner(row.Owner) + if err != nil || !account.Enabled { + return completed, fmt.Errorf("project work source %s: current account authorization unavailable", row.EventID) + } + authorizationEpoch := fmt.Sprintf("account:%d:project:%s", account.AuthVersion, row.ProjectID) observation := extension.WorkObservation{ EventID: row.EventID, Phase: "source-committed", Actor: row.Owner, Owner: row.Owner, ProjectID: core.ID(row.ProjectID), ConversationID: core.ID(row.ConversationID), RunID: core.ID(row.RunID), SourceKind: row.SourceKind, SourceID: row.SourceID, SourceVersion: row.SourceVersion, SourceSHA256: row.SourceSHA256, PartIndex: row.PartIndex, SpanStart: row.SpanStart, SpanEnd: row.SpanEnd, - Text: row.Text, Scope: row.Scope, Delivery: row.Delivery, DeliveryReason: row.Reason, Metadata: row.Metadata, ObservedAt: row.ObservedAt, + Text: row.Text, Scope: row.Scope, Delivery: row.Delivery, DeliveryReason: row.Reason, Metadata: row.Metadata, + AuthorizationEpoch: authorizationEpoch, ObservedAt: row.ObservedAt, } result, err := provider.Observe(ctx, observation) if err != nil { @@ -322,6 +328,11 @@ func preflightProjectRun(ctx context.Context, st *store.Store, slot *projectWork if row.RunID != runID || row.Owner != string(run.Owner) || row.ProjectID != string(run.ProjectID) || row.ConversationID != string(run.ConversationID) { return pending, errors.New("extension: mixed run source manifest") } + if row.SourceKind != "user-message" && row.SourceKind != "assistant-message" { + if err := verify(ctx, row); err != nil { + return pending, err + } + } manifest = append(manifest, extension.ProjectWorkSource{ EventID: row.EventID, SourceKind: row.SourceKind, SourceID: row.SourceID, SourceVersion: row.SourceVersion, SourceSHA256: row.SourceSHA256, PartIndex: row.PartIndex, diff --git a/internal/app/project_work_observation_test.go b/internal/app/project_work_observation_test.go index 7e94bd5..3c48d3c 100644 --- a/internal/app/project_work_observation_test.go +++ b/internal/app/project_work_observation_test.go @@ -271,10 +271,13 @@ func TestRunPreflightWaitsForAllCommittedSourceParts(t *testing.T) { SourceVersion: "v1", Text: "工具中的测量结果", Delivery: "complete", Metadata: map[string]string{"sourceStatus": "transient", "toolName": "measure"}}); err != nil { t.Fatal(err) } - ready, preflights, observed := false, 0, 0 + ready, preflights, observed, verified := false, 0, 0, 0 provider := workObserverForTest() - provider.Observe = func(context.Context, extension.WorkObservation) (extension.WorkObservationResult, error) { + provider.Observe = func(_ context.Context, observation extension.WorkObservation) (extension.WorkObservationResult, error) { observed++ + if observation.AuthorizationEpoch == "" { + t.Fatal("observation omitted the current authorization epoch") + } return extension.WorkObservationResult{State: extension.WorkObservationAccepted, ReceiptID: fmt.Sprintf("receipt-%d", observed)}, nil } provider.Preflight = func(_ context.Context, action extension.ProjectWorkAction) (extension.ProjectWorkDecision, error) { @@ -290,16 +293,17 @@ func TestRunPreflightWaitsForAllCommittedSourceParts(t *testing.T) { slot := &projectWorkObserverSlot{provider: &provider} work := func(context.Context, string, core.ID) (bool, error) { return true, nil } verify := func(ctx context.Context, row store.ProjectWorkObservationRow) error { + verified++ return verifyProjectTransientObservation(ctx, st, row) } decision, err := preflightProjectRun(context.Background(), st, slot, work, verify, string(run.ID), "model.consume.tool") - if err != nil || decision.State != extension.ProjectWorkPending || observed != 2 || preflights != 1 { + if err != nil || decision.State != extension.ProjectWorkPending || observed != 2 || preflights != 1 || verified != 2 { t.Fatalf("intake ACK was mistaken for finished risk analysis: %+v observed=%d preflights=%d err=%v", decision, observed, preflights, err) } ready = true decision, err = preflightProjectRun(context.Background(), st, slot, work, verify, string(run.ID), "model.consume.tool") - if err != nil || decision.State != extension.ProjectWorkProceed || observed != 2 || preflights != 2 { - t.Fatalf("fully analyzed run was not released once: %+v observed=%d preflights=%d err=%v", decision, observed, preflights, err) + if err != nil || decision.State != extension.ProjectWorkProceed || observed != 2 || preflights != 2 || verified != 3 { + t.Fatalf("fully analyzed run was not released once: %+v observed=%d verified=%d preflights=%d err=%v", decision, observed, verified, preflights, err) } } diff --git a/internal/runmgr/project_work_gate.go b/internal/runmgr/project_work_gate.go index 865aa55..1e83595 100644 --- a/internal/runmgr/project_work_gate.go +++ b/internal/runmgr/project_work_gate.go @@ -91,7 +91,7 @@ func resolveProjectWorkDecision(ctx context.Context, actor, projectID, runID, ac } response, err := ask(core.HITLCard{ Question: decision.Question, Kind: core.HITLKindChoice, Choices: choices, - AllowFreeInput: true, FreeInputHint: "也可以输入更准确的表述", Blocked: true, + AllowFreeInput: false, Blocked: true, BlockReason: decision.Reason, }) if err != nil { @@ -120,5 +120,15 @@ func resolveProjectWorkDecision(ctx context.Context, actor, projectID, runID, ac if resolved.State != extension.ProjectWorkProceed || resolved.DecisionID == "" { return pending, errors.New("project work clarification did not commit a proceed decision") } - return resolved, nil + refreshed, err := preflight(ctx, runID, action) + if err != nil { + return pending, err + } + if refreshed.State != extension.ProjectWorkProceed || refreshed.DecisionID == "" { + return pending, errors.New("project work sources changed or remain blocked after clarification") + } + if decision.SourceWatermark != "" && refreshed.SourceWatermark != decision.SourceWatermark { + return pending, errors.New("project work source watermark changed while clarification was pending") + } + return refreshed, nil } diff --git a/internal/runmgr/project_work_gate_test.go b/internal/runmgr/project_work_gate_test.go index bee3012..40f7e63 100644 --- a/internal/runmgr/project_work_gate_test.go +++ b/internal/runmgr/project_work_gate_test.go @@ -49,7 +49,7 @@ func TestProjectWorkGateClarifiesBeforeProceeding(t *testing.T) { Question: "效率低于人工是指更慢吗？", Options: []string{"效率更高且成本更低", "完成时间和成本更低", "确实允许效率更低"}, }, nil } - return extension.ProjectWorkDecision{State: extension.ProjectWorkPending}, nil + return extension.ProjectWorkDecision{State: extension.ProjectWorkProceed, DecisionID: "decision-after-recheck"}, nil } respond := func(_ context.Context, answer extension.ProjectRiskAnswer) (extension.ProjectWorkDecision, error) { responses++ @@ -66,7 +66,7 @@ func TestProjectWorkGateClarifiesBeforeProceeding(t *testing.T) { return core.HITLResponse{ChoiceID: "option-0"}, nil } decision, err := resolveProjectWorkDecision(context.Background(), "alice", "project-1", "run-1", "conversation.run", preflight, respond, ask) - if err != nil || decision.State != extension.ProjectWorkProceed || preflights != 1 || responses != 1 || questions != 1 { + if err != nil || decision.State != extension.ProjectWorkProceed || preflights != 2 || responses != 1 || questions != 1 { t.Fatalf("gate did not wait for clarification: decision=%+v preflight=%d responses=%d questions=%d err=%v", decision, preflights, responses, questions, err) } } @@ -99,9 +99,13 @@ func TestRunContextUsesHITLForProjectRiskBeforeContinuing(t *testing.T) { rc.h = &runHandle{hitlCh: make(chan hitlAnswer, 1)} rc.h.hitlCh <- hitlAnswer{resp: core.HITLResponse{ChoiceID: "option-0"}} rc.mgr.SetProjectWorkAuthorization(func(context.Context, string, core.ID) (bool, error) { return true, nil }) - responded := false + responded, preflights := false, 0 rc.mgr.SetProjectWorkGate( func(context.Context, string, string) (extension.ProjectWorkDecision, error) { + preflights++ + if preflights > 1 { + return extension.ProjectWorkDecision{State: extension.ProjectWorkProceed, DecisionID: "decision-after-recheck"}, nil + } return extension.ProjectWorkDecision{State: extension.ProjectWorkClarify, RiskID: "risk-1", RiskRevision: "r1", Question: "效率具体指什么？", Options: []string{"效率更高"}}, nil }, func(_ context.Context, answer extension.ProjectRiskAnswer) (extension.ProjectWorkDecision, error) { @@ -109,8 +113,8 @@ func TestRunContextUsesHITLForProjectRiskBeforeContinuing(t *testing.T) { return extension.ProjectWorkDecision{State: extension.ProjectWorkProceed, DecisionID: "decision-1"}, nil }, ) - if err := rc.requireProjectWorkDecision("conversation.run"); err != nil || !responded { - t.Fatalf("run did not wait for committed human clarification: responded=%t err=%v", responded, err) + if err := rc.requireProjectWorkDecision("conversation.run"); err != nil || !responded || preflights != 2 { + t.Fatalf("run did not recheck after committed human clarification: responded=%t preflights=%d err=%v", responded, preflights, err) } cards, err := st.ActiveHITLCards("alice", rc.run.ConversationID) if err != nil || len(cards) != 1 || cards[0].Question != "效率具体指什么？" { -- 2.54.0 From 1ec21f1c0560cdaa5fff27a8dffaec94fd63807f Mon Sep 17 00:00:00 2001 From: weichen Date: Thu, 15 Oct 2026 06:33:31 +0000 Subject: [PATCH 25/41] Disable unaudited native tools for project runs Why: Direct search, exec, fetch, and MCP providers could return project-driving results without entering the trusted source observation gate. Evidence: App and run-manager suites pass with project runs confined to the audited runCtx tool path. Impact: Non-project native runs retain configured tools; project runs fail closed until native result hooks can prove durable observation. Refs: TT-N03 TT-R01 --- internal/app/app.go | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/internal/app/app.go b/internal/app/app.go index f6a8fde..711e95a 100644 --- a/internal/app/app.go +++ b/internal/app/app.go @@ -402,6 +402,16 @@ func Run(opt Options) error { if mgr := mcpManagerFor(rawMCP, strings.TrimSpace(effNow.GetString("tools.mcp.overrides", ""))); mgr != nil { cfg.MCP = mgr } + // Native squad tools do not yet expose a fail-closed result hook to the + // project observation outbox. Project runs therefore use the audited + // runCtx retrieval/tool path only; enabling these direct providers would + // let their results reach the next model turn without source analysis. + if rc.Run().ProjectID != "" { + cfg.Search = nil + cfg.Exec = nil + cfg.Fetch = nil + cfg.MCP = nil + } cfg.CodeOrchestration = effNow.GetBool("runtime.codeOrchestration", false) if ask, ok := rc.(interface { AskUser(card core.HITLCard) (core.HITLResponse, error) -- 2.54.0 From 5ccbe8fbbcfbfb0b88fca3a549dd841a955e2554 Mon Sep 17 00:00:00 2001 From: weichen Date: Thu, 15 Oct 2026 06:34:52 +0000 Subject: [PATCH 26/41] Require source preflight for formal project commands Why: Direct HTTP and surface command dispatch could mutate RDM project facts without an analyzed committed-message manifest. Evidence: Command-bus, server, and app suites pass with a classification regression for formal writes and read/proof exceptions. Impact: Formal HTTP writes require a conversation anchor and committed proceed decision; surface writes fail closed until they can carry the same proof. Refs: TT-N03 TT-R01 --- internal/app/app.go | 3 +++ internal/app/surface_dispatch.go | 4 ++++ internal/cmdbus/cmdbus.go | 25 ++++++++++++++++++++ internal/cmdbus/project_work_command_test.go | 16 +++++++++++++ internal/server/server.go | 21 ++++++++++++++-- 5 files changed, 67 insertions(+), 2 deletions(-) create mode 100644 internal/cmdbus/project_work_command_test.go diff --git a/internal/app/app.go b/internal/app/app.go index 711e95a..1fda861 100644 --- a/internal/app/app.go +++ b/internal/app/app.go @@ -707,6 +707,9 @@ func Run(opt Options) error { } srv := server.New(st, mgr, reg, profSvc, setSvc, pluginHost) + srv.SetProjectCommandPreflight(func(ctx context.Context, messageID, action string) (extension.ProjectWorkDecision, error) { + return preflightProjectMessage(ctx, st, workObserverSlot, projectSlot.work(), messageID, action) + }) projectSlot.wire(srv, caps) // EXT-8：装载期注册的资源授权适配器注入读取入口（未注册=默认拒绝，行为不变）。 srv.SetProjectAuthorizer(authzSlot.Authorize) diff --git a/internal/app/surface_dispatch.go b/internal/app/surface_dispatch.go index 7a8137a..7540747 100644 --- a/internal/app/surface_dispatch.go +++ b/internal/app/surface_dispatch.go @@ -2,6 +2,7 @@ package app import ( "context" + "fmt" "agent-system-backend/internal/cmdbus" "agent-system-backend/internal/surfacesvc" @@ -11,6 +12,9 @@ import ( // caller. The button is acting for that user, so both Actor and Owner must be // populated before the command bus writes its audit envelope. func dispatchSurfaceAction(ctx context.Context, bus *cmdbus.Bus, d surfacesvc.ActionDispatch) (surfacesvc.ActionOutcome, error) { + if cmdbus.RequiresProjectWorkDecision(d.CommandID) { + return surfacesvc.ActionOutcome{}, fmt.Errorf("project formal action requires a committed conversation source preflight") + } resp := bus.Dispatch(ctx, cmdbus.Request{ID: d.CommandID, Params: d.Params, Entrance: "button", Actor: d.Owner, Owner: d.Owner, ConversationID: d.ConversationID}) state := "committed" diff --git a/internal/cmdbus/cmdbus.go b/internal/cmdbus/cmdbus.go index b3b7621..fe2b15c 100644 --- a/internal/cmdbus/cmdbus.go +++ b/internal/cmdbus/cmdbus.go @@ -106,6 +106,31 @@ type Request struct { HumanGrant *HumanGrant } +// RequiresProjectWorkDecision identifies formal RDM writes that must be bound +// to an analyzed committed-message manifest before dispatch. Read views and +// the separate exact-card structure issue/decision path are excluded. +func RequiresProjectWorkDecision(id string) bool { + for _, prefix := range []string{ + "rdm.reqs.", "rdm.review.", "rdm.draft.", "rdm.cnode.", "rdm.cedge.", + "rdm.conclusion.", "rdm.section.", "rdm.stage.", "rdm.change.", + } { + if strings.HasPrefix(id, prefix) { + for _, read := range []string{"rdm.reqs.list", "rdm.reqs.exports", "rdm.reqs.underived", "rdm.review.status", "rdm.review.doc.status", "rdm.draft.proposals", "rdm.conclusion.list", "rdm.change.list"} { + if id == read { + return false + } + } + return true + } + } + switch id { + case "rdm.structure.propose", "rdm.structure.revise", "rdm.docs.instantiate", "rdm.ingest", "rdm.upload.confirm", "rdm.knowledge.publish", "rdm.trace.confirm": + return true + default: + return false + } +} + // HumanGrant ties this dispatch to one persisted human response. // It is not a secret token and is not read from command params. type HumanGrant struct { diff --git a/internal/cmdbus/project_work_command_test.go b/internal/cmdbus/project_work_command_test.go new file mode 100644 index 0000000..a39e8ca --- /dev/null +++ b/internal/cmdbus/project_work_command_test.go @@ -0,0 +1,16 @@ +package cmdbus + +import "testing" + +func TestFormalRDMWritesRequireProjectWorkDecision(t *testing.T) { + for _, id := range []string{"rdm.reqs.add", "rdm.docs.instantiate", "rdm.review.doc.approve", "rdm.structure.propose", "rdm.trace.confirm"} { + if !RequiresProjectWorkDecision(id) { + t.Errorf("formal write %s bypassed project source preflight", id) + } + } + for _, id := range []string{"rdm.inspect.tree", "rdm.reqs.list", "rdm.structure.proposals", "rdm.structure.issue", "rdm.structure.decide"} { + if RequiresProjectWorkDecision(id) { + t.Errorf("read or separately proven command %s was misclassified", id) + } + } +} diff --git a/internal/server/server.go b/internal/server/server.go index c6573be..3cd5345 100644 --- a/internal/server/server.go +++ b/internal/server/server.go @@ -79,7 +79,8 @@ type Server struct { // 全部动作权威；未注册时 read 回落 ProjectAuthz（兼容），其余动作一律 // 默认拒绝——旧只读适配器不得自动获得写入能力。公开契约的版本化扩展 // 计划见 docs/guides/team-storage.md（KTD13 一节）。 - ProjectAuthzActions func(owner string, projectID core.ID, action ProjectAction) (bool, error) + ProjectAuthzActions func(owner string, projectID core.ID, action ProjectAction) (bool, error) + ProjectCommandPreflight func(context.Context, string, string) (extension.ProjectWorkDecision, error) // CompiledPlugins 编译进二进制的进程内插件摘要（组合根在 applyCompiled // 期间记录注册面生成；nil/空 = 无编译插件，清单行为不变）。 CompiledPlugins []CompiledPlugin @@ -113,6 +114,10 @@ func (s *Server) SetProjectActionAuthorizer(fn func(owner string, projectID core s.ProjectAuthzActions = fn } +func (s *Server) SetProjectCommandPreflight(fn func(context.Context, string, string) (extension.ProjectWorkDecision, error)) { + s.ProjectCommandPreflight = fn +} + // authorizeProjectAction 动作矩阵唯一判定（KTD13）： // - action-aware 适配器已注册 → 权威（出错/拒绝一律 false，fail-closed）； // - 未注册 → read 回落旧只读 ProjectAuthz（兼容 EXT-8 现网），其余动作 @@ -1280,6 +1285,18 @@ func (s *Server) execCommand(w http.ResponseWriter, r *http.Request) { if body.Params == nil { body.Params = map[string]any{} } + commandID := r.PathValue("id") + if cmdbus.RequiresProjectWorkDecision(commandID) { + if body.ConversationID == "" || body.AnchorMessageID == "" || s.ProjectCommandPreflight == nil { + http.Error(w, "project command requires a committed source message", http.StatusConflict) + return + } + decision, err := s.ProjectCommandPreflight(r.Context(), body.AnchorMessageID, "project-command:"+commandID) + if err != nil || decision.State != extension.ProjectWorkProceed || decision.DecisionID == "" { + http.Error(w, "project command source analysis is not complete", http.StatusConflict) + return + } + } var hostProject string if body.ConversationID != "" { conv, err := s.st.GetConversation(s.owner(r), body.ConversationID) @@ -1298,7 +1315,7 @@ func (s *Server) execCommand(w http.ResponseWriter, r *http.Request) { } dispatch := cmdbus.Request{ - ID: r.PathValue("id"), Params: body.Params, Entrance: body.Entrance, Actor: s.owner(r), + ID: commandID, Params: body.Params, Entrance: body.Entrance, Actor: s.owner(r), Owner: s.owner(r), ConversationID: body.ConversationID, AnchorMessageID: body.AnchorMessageID, HostProjectID: hostProject, } -- 2.54.0 From 5b1b137c4c1bd0c4a89f1a40d52d6215eeab8523 Mon Sep 17 00:00:00 2001 From: weichen Date: Thu, 15 Oct 2026 06:37:35 +0000 Subject: [PATCH 27/41] Explain blocked project command preflights Why: A generic conflict response hid whether source intake, authorization, or risk analysis blocked a formal command. Evidence: The server suite passes with bounded domain reasons included in the conflict response. Impact: Clients can present the actionable gate reason without exposing source contents. Refs: TT-N03 TT-R01 --- internal/server/server.go | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/internal/server/server.go b/internal/server/server.go index 3cd5345..e8b4a46 100644 --- a/internal/server/server.go +++ b/internal/server/server.go @@ -1293,7 +1293,14 @@ func (s *Server) execCommand(w http.ResponseWriter, r *http.Request) { } decision, err := s.ProjectCommandPreflight(r.Context(), body.AnchorMessageID, "project-command:"+commandID) if err != nil || decision.State != extension.ProjectWorkProceed || decision.DecisionID == "" { - http.Error(w, "project command source analysis is not complete", http.StatusConflict) + reason := decision.Reason + if err != nil { + reason = err.Error() + } + if reason == "" { + reason = "source analysis did not commit a proceed decision" + } + http.Error(w, "project command source analysis is not complete: "+reason, http.StatusConflict) return } } -- 2.54.0 From f8ea71f6b19f93434e8f0e45b554ea22e838fb4a Mon Sep 17 00:00:00 2001 From: weichen Date: Thu, 15 Oct 2026 06:38:18 +0000 Subject: [PATCH 28/41] Bind auth-off observations to the local project epoch Why: The real local-mode product has authoritative project access without an enabled account-model row. Evidence: The app suite passes; non-local missing or disabled accounts still fail closed. Impact: Auth-off local acceptance can record a nonempty authorization epoch while authenticated deployments retain account-version binding. Refs: TT-N03 --- internal/app/project_work_observation.go | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/internal/app/project_work_observation.go b/internal/app/project_work_observation.go index 9c76b20..9175715 100644 --- a/internal/app/project_work_observation.go +++ b/internal/app/project_work_observation.go @@ -136,10 +136,16 @@ func deliverProjectWorkRows(ctx context.Context, st *store.Store, provider *exte return completed, fmt.Errorf("project work source %s: current project authorization denied", row.EventID) } account, err := st.GetAccountByOwner(row.Owner) - if err != nil || !account.Enabled { + authorizationEpoch := "" + if err == nil && account.Enabled { + authorizationEpoch = fmt.Sprintf("account:%d:project:%s", account.AuthVersion, row.ProjectID) + } else if row.Owner == store.OwnerDefault { + // Auth-off local mode has no enabled account model. The project-work + // callback above is still authoritative for this process. + authorizationEpoch = "auth-off-local:project:" + row.ProjectID + } else { return completed, fmt.Errorf("project work source %s: current account authorization unavailable", row.EventID) } - authorizationEpoch := fmt.Sprintf("account:%d:project:%s", account.AuthVersion, row.ProjectID) observation := extension.WorkObservation{ EventID: row.EventID, Phase: "source-committed", Actor: row.Owner, Owner: row.Owner, ProjectID: core.ID(row.ProjectID), ConversationID: core.ID(row.ConversationID), RunID: core.ID(row.RunID), -- 2.54.0 From 14e780c6fa32fdd4742b6232150c5efcb0d766ff Mon Sep 17 00:00:00 2001 From: weichen Date: Thu, 15 Oct 2026 07:00:18 +0000 Subject: [PATCH 29/41] Bind formal commands to exact project sources Why: Chat intent, cross-conversation anchors, payload changes, and native workspace tools could bypass project source analysis. Evidence: Command-bus, app, server, and squad-adapter suites pass with centralized preflight and project-tool fail-closed behavior. Impact: Every classified formal entrance binds actor, conversation, project, command, payload digest, and source watermark before dispatch. Refs: TT-N03 TT-R01 --- internal/app/app.go | 29 ++++++++++-- internal/app/project_work_observation.go | 7 ++- internal/app/project_work_observation_test.go | 8 ++-- internal/cmdbus/cmdbus.go | 45 ++++++++++++------- internal/cmdbus/cmdbus_test.go | 2 + internal/cmdbus/project_work_command_test.go | 2 +- internal/cmdbus/slash_intent_test.go | 1 + internal/server/server.go | 30 ++----------- internal/squadadapter/entry.go | 19 +++++--- 9 files changed, 84 insertions(+), 59 deletions(-) diff --git a/internal/app/app.go b/internal/app/app.go index 1fda861..40e797b 100644 --- a/internal/app/app.go +++ b/internal/app/app.go @@ -5,6 +5,7 @@ package app import ( "context" "crypto/rand" + "crypto/sha256" "encoding/hex" "encoding/json" "fmt" @@ -412,7 +413,7 @@ func Run(opt Options) error { cfg.Fetch = nil cfg.MCP = nil } - cfg.CodeOrchestration = effNow.GetBool("runtime.codeOrchestration", false) + cfg.CodeOrchestration = rc.Run().ProjectID == "" && effNow.GetBool("runtime.codeOrchestration", false) if ask, ok := rc.(interface { AskUser(card core.HITLCard) (core.HITLResponse, error) }); ok { @@ -641,6 +642,29 @@ func Run(opt Options) error { } return nil }} + bus.SetProjectWorkPreflight(func(ctx context.Context, req cmdbus.Request) error { + if req.Actor == "" || req.Actor != req.Owner || req.ConversationID == "" || req.AnchorMessageID == "" || req.HostProjectID == "" { + return fmt.Errorf("formal project command requires an authenticated conversation source") + } + conv, err := st.GetConversation(req.Owner, req.ConversationID) + if err != nil || string(conv.ProjectID) != req.HostProjectID { + return fmt.Errorf("formal project command conversation binding changed") + } + raw, err := json.Marshal(req.Params) + if err != nil { + return err + } + digest := sha256.Sum256(raw) + decision, err := preflightProjectMessage(ctx, st, workObserverSlot, projectSlot.work(), req.AnchorMessageID, + "project-command:"+req.ID, req.Owner, req.ConversationID, req.HostProjectID, req.ID, hex.EncodeToString(digest[:])) + if err != nil { + return err + } + if decision.State != extension.ProjectWorkProceed || decision.DecisionID == "" { + return fmt.Errorf("source analysis did not commit a proceed decision") + } + return nil + }) // EXT-13：回合内检索（knowledge_search / @knowledge 注入）与 HTTP/Host 检索面 // 同一适配器授权；槽为共享指针，扩展在 applyCompiled 期间注册后即生效。 mgr.SetSharedKnowledgeAllow(func(owner string, projectID core.ID) bool { @@ -707,9 +731,6 @@ func Run(opt Options) error { } srv := server.New(st, mgr, reg, profSvc, setSvc, pluginHost) - srv.SetProjectCommandPreflight(func(ctx context.Context, messageID, action string) (extension.ProjectWorkDecision, error) { - return preflightProjectMessage(ctx, st, workObserverSlot, projectSlot.work(), messageID, action) - }) projectSlot.wire(srv, caps) // EXT-8：装载期注册的资源授权适配器注入读取入口（未注册=默认拒绝，行为不变）。 srv.SetProjectAuthorizer(authzSlot.Authorize) diff --git a/internal/app/project_work_observation.go b/internal/app/project_work_observation.go index 9175715..37dca04 100644 --- a/internal/app/project_work_observation.go +++ b/internal/app/project_work_observation.go @@ -224,7 +224,7 @@ func verifyProjectTransientObservation(_ context.Context, st *store.Store, row s // inline, then asks RDM to prove that every exact source part was analyzed for // the pending action. A durable intake ACK alone never permits the action. func preflightProjectMessage(ctx context.Context, st *store.Store, slot *projectWorkObserverSlot, - work func(context.Context, string, core.ID) (bool, error), messageID, action string, + work func(context.Context, string, core.ID) (bool, error), messageID, action, expectedOwner, expectedConversation, expectedProject, targetID, targetVersion string, ) (extension.ProjectWorkDecision, error) { pending := extension.ProjectWorkDecision{State: extension.ProjectWorkPending, Reason: "project source awaiting analysis"} provider := slot.get() @@ -256,6 +256,9 @@ func preflightProjectMessage(ctx context.Context, st *store.Store, slot *project }) } first := rows[0] + if first.Owner != expectedOwner || first.ConversationID != expectedConversation || first.ProjectID != expectedProject { + return pending, errors.New("extension: source message is not bound to this actor, conversation, and project") + } for _, row := range rows[1:] { if row.Owner != first.Owner || row.ProjectID != first.ProjectID || row.ConversationID != first.ConversationID { return pending, errors.New("extension: mixed project source manifest") @@ -276,7 +279,7 @@ func preflightProjectMessage(ctx context.Context, st *store.Store, slot *project watermark := fmt.Sprintf("%x", sha256.Sum256(raw)) decision, err := provider.Preflight(ctx, extension.ProjectWorkAction{ Actor: first.Owner, Owner: first.Owner, ProjectID: conv.ProjectID, - ConversationID: conv.ID, RunID: core.ID(first.RunID), Action: action, + ConversationID: conv.ID, RunID: core.ID(first.RunID), Action: action, TargetID: targetID, TargetVersion: targetVersion, Manifest: manifest, SourceWatermark: watermark, }) if err != nil { diff --git a/internal/app/project_work_observation_test.go b/internal/app/project_work_observation_test.go index 3c48d3c..bac2f51 100644 --- a/internal/app/project_work_observation_test.go +++ b/internal/app/project_work_observation_test.go @@ -116,19 +116,19 @@ func TestProjectMessagePreflightRequiresAnalysisAndExactManifest(t *testing.T) { work := func(_ context.Context, actor string, id core.ID) (bool, error) { return actor == "alice" && id == project.ID, nil } - decision, err := preflightProjectMessage(context.Background(), st, slot, work, string(msg.ID), "conversation.run") + decision, err := preflightProjectMessage(context.Background(), st, slot, work, string(msg.ID), "conversation.run", "alice", string(conv.ID), string(project.ID), "conversation.run", "v1") if err != nil || decision.State != extension.ProjectWorkPending || observations != 1 || decisions != 1 { t.Fatalf("durable intake was confused with completed analysis: %+v observations=%d decisions=%d err=%v", decision, observations, decisions, err) } ready = true - decision, err = preflightProjectMessage(context.Background(), st, slot, work, string(msg.ID), "conversation.run") + decision, err = preflightProjectMessage(context.Background(), st, slot, work, string(msg.ID), "conversation.run", "alice", string(conv.ID), string(project.ID), "conversation.run", "v1") if err != nil || decision.State != extension.ProjectWorkProceed || observations != 1 || decisions != 2 { t.Fatalf("same source did not proceed after domain analysis: %+v observations=%d decisions=%d err=%v", decision, observations, decisions, err) } if _, err := st.DB().Exec(`UPDATE messages SET parts=? WHERE id=?`, `[{"type":"text","text":"changed"}]`, msg.ID); err != nil { t.Fatal(err) } - decision, err = preflightProjectMessage(context.Background(), st, slot, work, string(msg.ID), "conversation.run") + decision, err = preflightProjectMessage(context.Background(), st, slot, work, string(msg.ID), "conversation.run", "alice", string(conv.ID), string(project.ID), "conversation.run", "v1") if err != nil || decision.State != extension.ProjectWorkPending || decisions != 2 { t.Fatalf("source changed after ACK but stale decision still passed: %+v decisions=%d err=%v", decision, decisions, err) } @@ -136,7 +136,7 @@ func TestProjectMessagePreflightRequiresAnalysisAndExactManifest(t *testing.T) { if err := st.AppendMessageWithRequestAccountChecked("alice", false, &partial, "req-2"); err != nil { t.Fatal(err) } - decision, err = preflightProjectMessage(context.Background(), st, slot, work, string(partial.ID), "conversation.run") + decision, err = preflightProjectMessage(context.Background(), st, slot, work, string(partial.ID), "conversation.run", "alice", string(conv.ID), string(project.ID), "conversation.run", "v1") if err != nil || decision.State != extension.ProjectWorkPending || decisions != 2 { t.Fatalf("partial attachment reached project action preflight: %+v decisions=%d err=%v", decision, decisions, err) } diff --git a/internal/cmdbus/cmdbus.go b/internal/cmdbus/cmdbus.go index fe2b15c..f3d388c 100644 --- a/internal/cmdbus/cmdbus.go +++ b/internal/cmdbus/cmdbus.go @@ -124,7 +124,9 @@ func RequiresProjectWorkDecision(id string) bool { } } switch id { - case "rdm.structure.propose", "rdm.structure.revise", "rdm.docs.instantiate", "rdm.ingest", "rdm.upload.confirm", "rdm.knowledge.publish", "rdm.trace.confirm": + case "rdm.structure.propose", "rdm.structure.revise", "rdm.docs.instantiate", "rdm.docs.delivery.approve", + "rdm.doc.snapshot", "rdm.ingest", "rdm.upload.confirm", "rdm.knowledge.publish", "rdm.trace.confirm", + "rdm.conflicts.resolve": return true default: return false @@ -154,20 +156,25 @@ type pending struct { } type Bus struct { - reg *agentcommand.Registry - audit AuditStore - cards CardPort - now func() time.Time - handlers map[string]Handler - slash map[string]string // "/x" → command id - pendMu sync.Mutex - pending map[string]pending - pendingStore PendingStore - intents *IntentStore // G2-2：意图声明表（自然语言路由） - toolGate ToolGate // U3：owner 级工具注入闸（nil = 不过滤） - accountGuard EffectiveAccountGuard // A1: optional command execution precheck - strictAccountWrites bool - allowImplicitLocal bool + reg *agentcommand.Registry + audit AuditStore + cards CardPort + now func() time.Time + handlers map[string]Handler + slash map[string]string // "/x" → command id + pendMu sync.Mutex + pending map[string]pending + pendingStore PendingStore + intents *IntentStore // G2-2：意图声明表（自然语言路由） + toolGate ToolGate // U3：owner 级工具注入闸（nil = 不过滤） + accountGuard EffectiveAccountGuard // A1: optional command execution precheck + strictAccountWrites bool + allowImplicitLocal bool + projectWorkPreflight func(context.Context, Request) error +} + +func (b *Bus) SetProjectWorkPreflight(fn func(context.Context, Request) error) { + b.projectWorkPreflight = fn } // PendingStore 把危险命令的确认挂起态落盘。进程内 map 仍是热路径；重启后从存储取回。 @@ -375,6 +382,14 @@ func (b *Bus) Dispatch(ctx context.Context, req Request) Response { if err := validateParams(spec.ParamsSchema, req.Params); err != nil { return receipt(agentcommand.StateRejected, "", "params: "+err.Error()) } + if RequiresProjectWorkDecision(req.ID) { + if b.projectWorkPreflight == nil { + return receipt(agentcommand.StateRejected, "", "project source preflight unavailable") + } + if err := b.projectWorkPreflight(ctx, req); err != nil { + return receipt(agentcommand.StateRejected, "", "project source preflight: "+err.Error()) + } + } // 高危收口：非确认入口先落内联确认卡（committed 语义 = 卡已创建；确认后二次分发执行）。 if spec.Danger == agentcommand.DangerHigh && !req.Confirmed { if b.cards == nil || req.ConversationID == "" { diff --git a/internal/cmdbus/cmdbus_test.go b/internal/cmdbus/cmdbus_test.go index 90d5c63..e3c37bb 100644 --- a/internal/cmdbus/cmdbus_test.go +++ b/internal/cmdbus/cmdbus_test.go @@ -62,6 +62,7 @@ func newTestBus(a AuditStore, c CardPort) *Bus { func TestDispatchFourEntrancesSameAudit(t *testing.T) { a := &memAudit{} b := newTestBus(a, &memCards{}) + b.SetProjectWorkPreflight(func(context.Context, Request) error { return nil }) for _, ent := range []string{"button", "slash", "chat", "card", "api", "weird-unknown"} { resp := b.Dispatch(context.Background(), Request{ID: "demo.ping", Entrance: ent}) if resp.Receipt.State != agentcommand.StateCommitted { @@ -277,6 +278,7 @@ func TestValidateParamsScalars(t *testing.T) { func TestRegisterPluginCommandDispatch(t *testing.T) { a := &memAudit{} b := newTestBus(a, &memCards{}) + b.SetProjectWorkPreflight(func(context.Context, Request) error { return nil }) err := b.RegisterPluginCommand(agentcommand.CommandSpec{ID: "rdm.ingest", Title: "入库"}, func(ctx context.Context, req Request) (any, error) { return map[string]any{"echo": req.Params["ref"], "owner": req.Owner}, nil }) diff --git a/internal/cmdbus/project_work_command_test.go b/internal/cmdbus/project_work_command_test.go index a39e8ca..0a6d95c 100644 --- a/internal/cmdbus/project_work_command_test.go +++ b/internal/cmdbus/project_work_command_test.go @@ -3,7 +3,7 @@ package cmdbus import "testing" func TestFormalRDMWritesRequireProjectWorkDecision(t *testing.T) { - for _, id := range []string{"rdm.reqs.add", "rdm.docs.instantiate", "rdm.review.doc.approve", "rdm.structure.propose", "rdm.trace.confirm"} { + for _, id := range []string{"rdm.reqs.add", "rdm.docs.instantiate", "rdm.docs.delivery.approve", "rdm.doc.snapshot", "rdm.conflicts.resolve", "rdm.review.doc.approve", "rdm.structure.propose", "rdm.trace.confirm"} { if !RequiresProjectWorkDecision(id) { t.Errorf("formal write %s bypassed project source preflight", id) } diff --git a/internal/cmdbus/slash_intent_test.go b/internal/cmdbus/slash_intent_test.go index 6c01f05..8798d27 100644 --- a/internal/cmdbus/slash_intent_test.go +++ b/internal/cmdbus/slash_intent_test.go @@ -67,6 +67,7 @@ func TestIntentDeclareMatchRoute(t *testing.T) { t.Fatalf("匹配 = %+v ok=%v", in, ok) } // 路由：匹配到的命令经总线 chat 入口分发成功。 + bus.SetProjectWorkPreflight(func(context.Context, Request) error { return nil }) resp := bus.Dispatch(context.Background(), Request{ID: in.Command, Params: in.Params, Entrance: "chat", Owner: "alice"}) if resp.Receipt.State != "committed" { t.Fatalf("路由分发 = %+v", resp.Receipt) diff --git a/internal/server/server.go b/internal/server/server.go index e8b4a46..d964009 100644 --- a/internal/server/server.go +++ b/internal/server/server.go @@ -79,8 +79,7 @@ type Server struct { // 全部动作权威；未注册时 read 回落 ProjectAuthz（兼容），其余动作一律 // 默认拒绝——旧只读适配器不得自动获得写入能力。公开契约的版本化扩展 // 计划见 docs/guides/team-storage.md（KTD13 一节）。 - ProjectAuthzActions func(owner string, projectID core.ID, action ProjectAction) (bool, error) - ProjectCommandPreflight func(context.Context, string, string) (extension.ProjectWorkDecision, error) + ProjectAuthzActions func(owner string, projectID core.ID, action ProjectAction) (bool, error) // CompiledPlugins 编译进二进制的进程内插件摘要（组合根在 applyCompiled // 期间记录注册面生成；nil/空 = 无编译插件，清单行为不变）。 CompiledPlugins []CompiledPlugin @@ -114,10 +113,6 @@ func (s *Server) SetProjectActionAuthorizer(fn func(owner string, projectID core s.ProjectAuthzActions = fn } -func (s *Server) SetProjectCommandPreflight(fn func(context.Context, string, string) (extension.ProjectWorkDecision, error)) { - s.ProjectCommandPreflight = fn -} - // authorizeProjectAction 动作矩阵唯一判定（KTD13）： // - action-aware 适配器已注册 → 权威（出错/拒绝一律 false，fail-closed）； // - 未注册 → read 回落旧只读 ProjectAuthz（兼容 EXT-8 现网），其余动作 @@ -280,7 +275,8 @@ func handleSystemIntent(ctx context.Context, b *cmdbus.Bus, req cmdbus.Request) } } resp := b.Dispatch(ctx, cmdbus.Request{ID: in.Command, Params: params, Entrance: "chat", - Actor: req.Actor, Owner: req.Owner, ConversationID: req.ConversationID}) + Actor: req.Actor, Owner: req.Owner, ConversationID: req.ConversationID, + AnchorMessageID: req.AnchorMessageID, HostProjectID: req.HostProjectID}) return map[string]any{"matched": true, "intent": in.ID, "command": in.Command, "dispatched": true, "receipt": resp.Receipt, "payload": resp.Payload}, nil } @@ -1151,7 +1147,7 @@ func (s *Server) postMessage(w http.ResponseWriter, r *http.Request) { if routeKind == route.KindCommand { resp := s.Bus.Dispatch(r.Context(), cmdbus.Request{ ID: recognized.ID, Params: map[string]any{"text": text}, Entrance: "chat", Actor: owner, - Owner: owner, ConversationID: convID, AnchorMessageID: msg.ID, + Owner: owner, ConversationID: convID, AnchorMessageID: msg.ID, HostProjectID: string(conv.ProjectID), }) out := map[string]any{"message": msg, "receipt": resp.Receipt, "command": recognized.ID} if resp.Card != nil { @@ -1286,24 +1282,6 @@ func (s *Server) execCommand(w http.ResponseWriter, r *http.Request) { body.Params = map[string]any{} } commandID := r.PathValue("id") - if cmdbus.RequiresProjectWorkDecision(commandID) { - if body.ConversationID == "" || body.AnchorMessageID == "" || s.ProjectCommandPreflight == nil { - http.Error(w, "project command requires a committed source message", http.StatusConflict) - return - } - decision, err := s.ProjectCommandPreflight(r.Context(), body.AnchorMessageID, "project-command:"+commandID) - if err != nil || decision.State != extension.ProjectWorkProceed || decision.DecisionID == "" { - reason := decision.Reason - if err != nil { - reason = err.Error() - } - if reason == "" { - reason = "source analysis did not commit a proceed decision" - } - http.Error(w, "project command source analysis is not complete: "+reason, http.StatusConflict) - return - } - } var hostProject string if body.ConversationID != "" { conv, err := s.st.GetConversation(s.owner(r), body.ConversationID) diff --git a/internal/squadadapter/entry.go b/internal/squadadapter/entry.go index 902c3e7..60c674d 100644 --- a/internal/squadadapter/entry.go +++ b/internal/squadadapter/entry.go @@ -75,9 +75,10 @@ func RunEntry(rc Ctx, opt EntryOptions) (EntryResult, error) { hostNames = append(hostNames, tool.Name()) } registry := squad.NewRoleRegistry() + projectRun := rc.Run().ProjectID != "" for _, role := range kernelRoles(roleCaps{ host: hostNames, exec: cfg.Exec != nil, skills: len(cfg.SkillsRoots) > 0, - search: cfg.Search != nil, fetch: cfg.Fetch != nil, + search: cfg.Search != nil, fetch: cfg.Fetch != nil, workspace: !projectRun, }) { if err := registry.Register(role); err != nil { return EntryResult{}, fmt.Errorf("squad entry: register %s: %w", role.Role, err) @@ -167,15 +168,19 @@ func readDeliverable(res *squad.RunResult) string { } type roleCaps struct { - host []string - exec bool - skills bool - search bool - fetch bool + host []string + exec bool + skills bool + search bool + fetch bool + workspace bool } func kernelRoles(caps roleCaps) []squad.RoleSpec { - base := []string{"read_file", "write_file", "list_dir", "grep"} + base := []string{} + if caps.workspace { + base = []string{"read_file", "write_file", "list_dir", "grep"} + } writerTools := append([]string{}, base...) writerTools = append(writerTools, "edit_file", "multi_edit", "glob") if caps.exec { -- 2.54.0 From b0dd53338528af9f8cdad0adeebfd5fa597976eb Mon Sep 17 00:00:00 2001 From: weichen Date: Thu, 15 Oct 2026 19:04:37 +0000 Subject: [PATCH 30/41] Add shared document renderer dependency Why: Task 10 requires Backend to consume the reviewed canonical renderer and its embedded organization-default candidate without copying assets. Evidence: Fresh GOMODCACHE resolution loaded agent-document-renderer/profiles and passed its package tests at d449b9f779f2f968f8ac556b89940a6c9aaf3fdc. Impact: Adds one immutable Renderer gitlink plus the local Go module require/replace; no production path changes yet. Refs: Unified Document Renderer Task 10; Renderer d449b9f779f2f968f8ac556b89940a6c9aaf3fdc --- .gitmodules | 3 +++ deps/agent-document-renderer | 1 + go.mod | 3 +++ 3 files changed, 7 insertions(+) create mode 160000 deps/agent-document-renderer diff --git a/.gitmodules b/.gitmodules index de8d163..d9d0672 100644 --- a/.gitmodules +++ b/.gitmodules @@ -19,3 +19,6 @@ [submodule "deps/agent-command"] path = deps/agent-command url = ssh://git@git-ssh.u1680832.nyat.app:31411/weichen/Agent-Command.git +[submodule "deps/agent-document-renderer"] + path = deps/agent-document-renderer + url = ssh://git@git-ssh.u1680832.nyat.app:31411/weichen/Agent-Document-Renderer.git diff --git a/deps/agent-document-renderer b/deps/agent-document-renderer new file mode 160000 index 0000000..d449b9f --- /dev/null +++ b/deps/agent-document-renderer @@ -0,0 +1 @@ +Subproject commit d449b9f779f2f968f8ac556b89940a6c9aaf3fdc diff --git a/go.mod b/go.mod index e61a94f..4b68924 100644 --- a/go.mod +++ b/go.mod @@ -4,6 +4,7 @@ go 1.27 require ( agent-command v0.0.0 + agent-document-renderer v0.0.0 agent-intent v0.0.0 agent-native v0.0.0 agent-squad v0.0.0 @@ -52,3 +53,5 @@ replace error-code-system => ./deps/error-code-system replace logging-system => ./deps/logging-system replace agent-command => ./deps/agent-command + +replace agent-document-renderer => ./deps/agent-document-renderer -- 2.54.0 From a21a3b57b41852a04d642a0520182d7f87665ea3 Mon Sep 17 00:00:00 2001 From: weichen Date: Thu, 15 Oct 2026 19:41:14 +0000 Subject: [PATCH 31/41] Route workspace Word delivery through the shared renderer Why: Task 10 replaces Backend's independent Markdown-to-Word production path with the reviewed canonical parser, embedded organization-default candidate, and Word adapter. Evidence: Canonical parity, deterministic package, routing, safety, cancellation, comparison, persistence, affected-package race, full test, vet, build, and static build checks passed locally. Impact: Ordinary workspace renders now persist Markdown, deterministic DOCX, manifest, and archive with hashes; controlled/project/review/approved routes fail closed to RDM, and legacy Go rendering is comparison-only. Refs: Unified Document Renderer Task 10; Renderer d449b9f779f2f968f8ac556b89940a6c9aaf3fdc --- go.mod | 3 + go.sum | 9 + internal/docgen/docgen.go | 6 +- internal/docgen/docgen_test.go | 6 +- internal/docgen/renderer.go | 423 +++++++++++++++++ internal/docgen/renderer_integration_test.go | 473 +++++++++++++++++++ internal/ingest/docgen_roundtrip_test.go | 18 +- internal/runmgr/exec_tool_artifact_test.go | 84 +++- internal/runtime/compose_test.go | 4 +- internal/runtime/llm_direct.go | 2 +- internal/runtime/llm_direct_e1_test.go | 2 +- internal/runtime/llm_test.go | 17 +- internal/runtime/mock.go | 41 +- internal/server/e2e_test.go | 29 +- internal/tools/document_renderer.go | 117 +++++ internal/tools/document_renderer_test.go | 125 +++++ internal/tools/exec.go | 6 +- internal/tools/fs.go | 8 +- internal/tools/fs_test.go | 10 +- internal/tools/registry.go | 3 + 20 files changed, 1340 insertions(+), 46 deletions(-) create mode 100644 internal/docgen/renderer.go create mode 100644 internal/docgen/renderer_integration_test.go create mode 100644 internal/tools/document_renderer.go create mode 100644 internal/tools/document_renderer_test.go diff --git a/go.mod b/go.mod index 4b68924..f976403 100644 --- a/go.mod +++ b/go.mod @@ -27,12 +27,15 @@ require ( github.com/jackc/pgpassfile v1.0.0 // indirect github.com/jackc/pgservicefile v0.0.0-20240606120523-5a60cdf6a761 // indirect github.com/jackc/puddle/v2 v2.2.2 // indirect + github.com/kr/text v0.2.0 // indirect github.com/mattn/go-isatty v0.0.24 // indirect github.com/ncruces/go-strftime v1.0.0 // indirect github.com/remyoudompheng/bigfft v0.0.0-20230129092748-24d4a6f8daec // indirect + github.com/rogpeppe/go-internal v1.16.0 // indirect golang.org/x/sync v0.23.0 // indirect golang.org/x/sys v0.48.0 // indirect golang.org/x/text v0.41.0 // indirect + gopkg.in/yaml.v3 v3.0.1 // indirect modernc.org/libc v1.77.1 // indirect modernc.org/mathutil v1.7.1 // indirect modernc.org/memory v1.12.1 // indirect diff --git a/go.sum b/go.sum index b4fc65f..1ac67f1 100644 --- a/go.sum +++ b/go.sum @@ -4,6 +4,7 @@ github.com/bsm/gomega v1.27.10 h1:yeMWxP2pV2fG3FgAODIY8EiRE3dy0aeFYt4l7wh6yKA= github.com/bsm/gomega v1.27.10/go.mod h1:JyEr/xRbxbtgWNi8tIEVPUYZ5Dzef52k01W3YH0H+O0= github.com/cespare/xxhash/v2 v2.3.0 h1:UL815xU9SqsFlibzuggzjXhog7bL6oX9BbNZnL2UFvs= github.com/cespare/xxhash/v2 v2.3.0/go.mod h1:VGX0DQ3Q6kWi7AoAeZDth3/j3BFtOZR5XLFGgcrjCOs= +github.com/creack/pty v1.1.9/go.mod h1:oKZEueFk5CKHvIhNR5MUki03XCEU+Q6VDXinZuGJ33E= github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38= github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c= github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38= @@ -25,6 +26,10 @@ github.com/jackc/pgx/v5 v5.9.2 h1:3ZhOzMWnR4yJ+RW1XImIPsD1aNSz4T4fyP7zlQb56hw= github.com/jackc/pgx/v5 v5.9.2/go.mod h1:mal1tBGAFfLHvZzaYh77YS/eC6IX9OWbRV1QIIM0Jn4= github.com/jackc/puddle/v2 v2.2.2 h1:PR8nw+E/1w0GLuRFSmiioY6UooMp6KJv0/61nB7icHo= github.com/jackc/puddle/v2 v2.2.2/go.mod h1:vriiEXHvEE654aYKXXjOvZM39qJ0q+azkZFrfEOc3H4= +github.com/kr/pretty v0.3.0 h1:WgNl7dwNpEZ6jJ9k1snq4pZsg7DOEN8hP9Xw0Tsjwk0= +github.com/kr/pretty v0.3.0/go.mod h1:640gp4NfQd8pI5XOwp5fnNeVWj67G7CFk/SaSQn7NBk= +github.com/kr/text v0.2.0 h1:5Nx0Ya0ZqY2ygV366QzturHI13Jq95ApcVaJBhpS+AY= +github.com/kr/text v0.2.0/go.mod h1:eLer722TekiGuMkidMxC/pM04lWEeraHUUmBw8l2grE= github.com/ledongthuc/pdf v0.0.0-20260907135840-6c8c28e0e8a0 h1:7Q+xNAZFmnfYOMweHN3c/PDFUKKfY1pVJ26K++QvVfU= github.com/ledongthuc/pdf v0.0.0-20260907135840-6c8c28e0e8a0/go.mod h1:1fEHWurg7pvf5SG6XNE5Q8UZmOwex51Mkx3SLhrW5B4= github.com/mattn/go-isatty v0.0.24 h1:tGZZoVgT/KiqK1c8ocVLeDS8BSWMRd47J3Lbz7vsReI= @@ -37,6 +42,8 @@ github.com/redis/go-redis/v9 v9.14.0 h1:u4tNCjXOyzfgeLN+vAZaW1xUooqWDqVEsZN0U01j github.com/redis/go-redis/v9 v9.14.0/go.mod h1:huWgSWd8mW6+m0VPhJjSSQ+d6Nh1VICQ6Q5lHuCH/Iw= github.com/remyoudompheng/bigfft v0.0.0-20230129092748-24d4a6f8daec h1:W09IVJc94icq4NjY3clb7Lk8O1qJ8BdBEF8z0ibU0rE= github.com/remyoudompheng/bigfft v0.0.0-20230129092748-24d4a6f8daec/go.mod h1:qqbHyh8v60DhA7CoWK5oRCqLrMHRGoxYCSS9EjAz6Eo= +github.com/rogpeppe/go-internal v1.16.0 h1:O9DK+vNMDVGLr2BeZqmpLeMjiMNkuXfcqntWbZV6S5g= +github.com/rogpeppe/go-internal v1.16.0/go.mod h1:DrUVZyrJU+txYW5/1kwtXQSMFio52ZOxX7yM1VHvnxs= github.com/stretchr/objx v0.1.0/go.mod h1:HFkY916IF+rwdDfMAkV7OtwuqBVzrE8GR6GFx+wExME= github.com/stretchr/testify v1.3.0/go.mod h1:M5WIy9Dh21IEIfnGCwXGc5bZfKNJtfHm1UVUgZn+9EI= github.com/stretchr/testify v1.7.0/go.mod h1:6Fq8oRcR53rry900zMqJjRRixrwX3KX962/h/Wwjteg= @@ -55,6 +62,8 @@ golang.org/x/text v0.41.0/go.mod h1:jvf1O8ajNzZqhSrQBPbutR/EB83Cc0CFrezNQIwbb5M= golang.org/x/tools v0.50.0 h1:c2ifzfcuY7L90lZ2aKd8S4K2NpASF08SZx9ZuJkHmSU= golang.org/x/tools v0.50.0/go.mod h1:7ulVMw3831Mwi5EZD6RomGyffr4VFjuNYXf2BbCEAV0= gopkg.in/check.v1 v0.0.0-20161208181325-20d25e280405/go.mod h1:Co6ibVJAznAaIkqp8huTwlJQCZ016jof/cbN4VW5Yz0= +gopkg.in/check.v1 v1.0.0-20201130134442-10cb98267c6c h1:Hei/4ADfdWqJk1ZMxUNpqntNwaWcugrBjAiHlqqRiVk= +gopkg.in/check.v1 v1.0.0-20201130134442-10cb98267c6c/go.mod h1:JHkPIbrfpd72SG/EVd6muEfDQjcINNoR0C8j2r3qZ4Q= gopkg.in/yaml.v3 v3.0.0-20200313102051-9f266ea9e77c/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM= gopkg.in/yaml.v3 v3.0.1 h1:fxVm/GzAzEWqLHuvctI91KS9hhNmmWOoWu0XTYJS7CA= gopkg.in/yaml.v3 v3.0.1/go.mod h1:K4uyk7z7BCEPqu6E+C64Yfv1cQ7kz7rIZviUmN+EgEM= diff --git a/internal/docgen/docgen.go b/internal/docgen/docgen.go index 47266ed..af83084 100644 --- a/internal/docgen/docgen.go +++ b/internal/docgen/docgen.go @@ -18,8 +18,10 @@ import ( "strings" ) -// Build 生成 docx 字节。title 为文档标题；为空时取首个标题块，再无则不带 Title 段。 -func Build(title, markdown string) ([]byte, error) { +// legacyBuild is retained only for an explicitly enabled migration comparison. +// Production callers must use Generate and never fall back here after a shared +// renderer failure. +func legacyBuild(title, markdown string) ([]byte, error) { doc := parseMarkdown(markdown) title = strings.TrimSpace(title) if title == "" { diff --git a/internal/docgen/docgen_test.go b/internal/docgen/docgen_test.go index af0736d..1cd5228 100644 --- a/internal/docgen/docgen_test.go +++ b/internal/docgen/docgen_test.go @@ -44,7 +44,7 @@ const sampleMinutes = "# 研发周会纪要\n" + ` func buildSample(t *testing.T) []byte { t.Helper() - b, err := Build("", sampleMinutes) + b, err := legacyBuild("", sampleMinutes) if err != nil { t.Fatalf("Build: %v", err) } @@ -172,7 +172,7 @@ func TestBuildHyperlinkRels(t *testing.T) { } func TestBuildEscapesXML(t *testing.T) { - b, err := Build("标题&'", "包含 <标签> & \"引号\" 的正文") + b, err := legacyBuild("标题&'", "包含 <标签> & \"引号\" 的正文") if err != nil { t.Fatalf("Build: %v", err) } @@ -202,7 +202,7 @@ func TestBuildEscapesXML(t *testing.T) { func TestBuildPlainTextFallback(t *testing.T) { // 无任何 Markdown 结构的纯文本：按段落输出，不 panic、产物良构。 - b, err := Build("", "第一行\n第二行\n\n第二段") + b, err := legacyBuild("", "第一行\n第二行\n\n第二段") if err != nil { t.Fatalf("Build: %v", err) } diff --git a/internal/docgen/renderer.go b/internal/docgen/renderer.go new file mode 100644 index 0000000..2304040 --- /dev/null +++ b/internal/docgen/renderer.go @@ -0,0 +1,423 @@ +package docgen + +import ( + "archive/zip" + "bytes" + "context" + "crypto/sha256" + "encoding/hex" + "encoding/json" + "errors" + "fmt" + "sort" + "strings" + "time" + + markdownrenderer "agent-document-renderer/markdown" + "agent-document-renderer/model" + "agent-document-renderer/profile" + "agent-document-renderer/profiles" + "agent-document-renderer/render" + "agent-document-renderer/word" +) + +const ( + WorkspaceProjectID = "workspace" + ManifestSchemaVersion = "backend-document-delivery/v1" + RendererIdentity = "agent-document-renderer@d449b9f779f2f968f8ac556b89940a6c9aaf3fdc" + AdapterIdentity = RendererIdentity + "/word-adapter-v1" +) + +var ( + ErrRDMRequired = errors.New("docgen: controlled or project document requires RDM") + ErrProfileMismatch = errors.New("docgen: organization-default profile mismatch") + ErrResourceLimit = errors.New("docgen: resource limit exceeded") +) + +type Artifact struct { + Name string + MIME string + SHA256 string + Bytes []byte +} + +type Request struct { + DocumentID string + Title string + DocumentType string + Language string + Markdown []byte + Mode render.Mode + FrozenAt time.Time + RequestedBy string + ProfileID string + ProfileVersion string + Controlled bool + ProjectDocument bool + LegacyComparison bool + Limits Limits +} + +type Limits struct { + MaxMarkdownBytes int + MaxNodes int + MaxDepth int +} + +type DiagnosticError struct { + Stage string + Code string + Diagnostics []render.Diagnostic + Err error +} + +func (failure *DiagnosticError) Error() string { + if failure == nil { + return "docgen: diagnostic failure" + } + return fmt.Sprintf("docgen: %s: %s: %v", failure.Stage, failure.Code, failure.Err) +} + +func (failure *DiagnosticError) Unwrap() error { + if failure == nil { + return nil + } + return failure.Err +} + +type ComparisonReceipt struct { + Enabled bool `json:"enabled"` + LegacySHA256 string `json:"legacySha256,omitempty"` + SharedSHA256 string `json:"sharedSha256,omitempty"` + IntentionalDifferences []string `json:"intentionalDifferences,omitempty"` + AccidentalDifferences []string `json:"accidentalDifferences,omitempty"` +} + +type ManifestArtifact struct { + Name string `json:"name"` + MIME string `json:"mime"` + Size int `json:"size"` + SHA256 string `json:"sha256"` +} + +type ProfileReceipt struct { + ProfileID string `json:"profileId"` + Version string `json:"version"` + SnapshotHash string `json:"snapshotHash"` + Candidate bool `json:"candidate"` + ReviewStatus string `json:"reviewStatus"` + PublicationAllowed bool `json:"publicationAllowed"` + Unverified []string `json:"unverified"` + ProfileSHA256 string `json:"profileSha256"` + AssetManifestSHA256 string `json:"assetManifestSha256"` + ReviewSHA256 string `json:"reviewSha256"` +} + +type Manifest struct { + SchemaVersion string `json:"schemaVersion"` + RendererIdentity string `json:"rendererIdentity"` + AdapterIdentity string `json:"adapterIdentity"` + SelectionSource string `json:"selectionSource"` + Profile ProfileReceipt `json:"profile"` + DocumentRootID string `json:"documentRootId"` + Artifacts []ManifestArtifact `json:"artifacts"` + Renderer render.Manifest `json:"renderer"` + Diagnostics []render.Diagnostic `json:"diagnostics,omitempty"` + NodeAnchors map[string]string `json:"nodeAnchors"` + Comparison ComparisonReceipt `json:"comparison"` +} + +type Delivery struct { + Document model.CanonicalDocument + Profile ProfileReceipt + Markdown Artifact + DOCX Artifact + Manifest Artifact + Archive Artifact + Comparison ComparisonReceipt +} + +type generatorDependencies struct { + loadDefault func() (profiles.Bundle, error) + newRenderer func(*profile.AssetReader) render.Renderer + legacyBuild func(string, string) ([]byte, error) +} + +func defaultGeneratorDependencies() generatorDependencies { + return generatorDependencies{ + loadDefault: profiles.LoadCompanyDefault, + newRenderer: func(assets *profile.AssetReader) render.Renderer { return word.NewAdapter(assets) }, + legacyBuild: legacyBuild, + } +} + +func Generate(ctx context.Context, request Request) (Delivery, error) { + return generate(ctx, request, defaultGeneratorDependencies()) +} + +func generate(ctx context.Context, request Request, dependencies generatorDependencies) (Delivery, error) { + if err := contextErr(ctx); err != nil { + return Delivery{}, err + } + if request.Controlled || request.ProjectDocument || request.Mode == render.ModeReview || request.Mode == render.ModeApproved { + return Delivery{}, ErrRDMRequired + } + if request.Mode != render.ModeWorking && request.Mode != render.ModePreview { + return Delivery{}, fmt.Errorf("docgen: unsupported ordinary workspace mode %q", request.Mode) + } + limits, err := normalizeLimits(request.Limits) + if err != nil { + return Delivery{}, err + } + if len(request.Markdown) > limits.MaxMarkdownBytes { + return Delivery{}, fmt.Errorf("%w: Markdown is %d bytes, limit is %d", ErrResourceLimit, len(request.Markdown), limits.MaxMarkdownBytes) + } + bundle, err := dependencies.loadDefault() + if err != nil { + return Delivery{}, fmt.Errorf("docgen: load company default: %w", err) + } + profileID, profileVersion := bundle.Snapshot.ProfileIdentity() + if request.ProfileID != "" || request.ProfileVersion != "" { + if request.ProfileID != profileID || request.ProfileVersion != profileVersion { + return Delivery{}, fmt.Errorf("%w: requested %s@%s, available %s@%s", ErrProfileMismatch, + request.ProfileID, request.ProfileVersion, profileID, profileVersion) + } + } + source, firstImport, err := workspaceMarkdown(request, profileID, profileVersion) + if err != nil { + return Delivery{}, err + } + parsed, err := markdownrenderer.Parse(source, markdownrenderer.Options{ + Controlled: true, FirstImport: firstImport, MaxBytes: limits.MaxMarkdownBytes + 64<<10, + MaxNodes: limits.MaxNodes, MaxDepth: limits.MaxDepth, + }) + if err != nil { + if errors.Is(err, markdownrenderer.ErrDocumentLimit) { + return Delivery{}, fmt.Errorf("%w: %v", ErrResourceLimit, err) + } + code := "markdown_invalid" + switch { + case errors.Is(err, markdownrenderer.ErrUnknownMetadata): + code = "unknown_metadata" + case errors.Is(err, markdownrenderer.ErrHiddenHTML): + code = "unsafe_markdown" + case errors.Is(err, markdownrenderer.ErrUnsafeDirective) && strings.Contains(err.Error(), "unknown directive"): + code = "unknown_directive" + case errors.Is(err, markdownrenderer.ErrUnsafeDirective): + code = "unsafe_markdown" + } + return Delivery{}, diagnosticFailure("parse", code, err, nil) + } + if err := validateWorkspaceMetadata(request, parsed.Metadata, profileID, profileVersion); err != nil { + return Delivery{}, err + } + if err := contextErr(ctx); err != nil { + return Delivery{}, err + } + result, err := renderWithContext(ctx, dependencies.newRenderer(bundle.Assets), render.Request{ + Document: parsed.Document, + Profile: bundle.Snapshot, + Mode: request.Mode, + FrozenAt: request.FrozenAt, + RequestedBy: request.RequestedBy, + }) + if err != nil { + code := "renderer_failed" + if strings.Contains(err.Error(), "asset") || strings.Contains(err.Error(), "hash") { + code = "asset_mismatch" + } + return Delivery{}, diagnosticFailure("render", code, err, result.Diagnostics) + } + base := safeBaseName(request.Title) + delivery := Delivery{ + Document: parsed.Document, + Profile: ProfileReceipt{ + ProfileID: profileID, Version: profileVersion, SnapshotHash: bundle.Snapshot.SnapshotHash(), + Candidate: true, ReviewStatus: bundle.Review.Status, PublicationAllowed: bundle.Review.PublicationAllowed, + Unverified: append([]string(nil), bundle.Review.Unverified...), ProfileSHA256: bundle.Review.ProfileSHA256, + AssetManifestSHA256: bundle.Review.AssetManifestSHA256, ReviewSHA256: bundle.Review.ReviewSHA256, + }, + Markdown: artifact(base+".md", "text/markdown; charset=utf-8", parsed.Markdown), + DOCX: artifact(base+".docx", result.MIME, result.Artifact), + } + if request.LegacyComparison { + legacy, err := dependencies.legacyBuild(request.Title, string(request.Markdown)) + if err != nil { + return Delivery{}, fmt.Errorf("docgen: legacy migration comparison: %w", err) + } + legacySum := sha256.Sum256(legacy) + delivery.Comparison = ComparisonReceipt{ + Enabled: true, LegacySHA256: hex.EncodeToString(legacySum[:]), SharedSHA256: delivery.DOCX.SHA256, + IntentionalDifferences: []string{ + "shared output removes the legacy duplicate title paragraph", + "shared output adds stable node bookmarks and deterministic package metadata", + "shared output uses the pending organization-default candidate page and footer rules", + }, + } + } + manifest := Manifest{ + SchemaVersion: ManifestSchemaVersion, RendererIdentity: RendererIdentity, AdapterIdentity: AdapterIdentity, + SelectionSource: "organization-default", + Profile: delivery.Profile, + DocumentRootID: parsed.Document.Root.ID, + Artifacts: []ManifestArtifact{ + manifestArtifact(delivery.Markdown), manifestArtifact(delivery.DOCX), + }, + Renderer: result.Manifest, Diagnostics: append([]render.Diagnostic(nil), result.Diagnostics...), + NodeAnchors: cloneStringMap(result.NodeAnchors), Comparison: delivery.Comparison, + } + manifestRaw, err := json.MarshalIndent(manifest, "", " ") + if err != nil { + return Delivery{}, fmt.Errorf("docgen: marshal manifest: %w", err) + } + manifestRaw = append(manifestRaw, '\n') + delivery.Manifest = artifact(base+".manifest.json", "application/json", manifestRaw) + archiveRaw, err := buildArchive(delivery.Markdown, delivery.DOCX, delivery.Manifest) + if err != nil { + return Delivery{}, err + } + delivery.Archive = artifact(base+".zip", "application/zip", archiveRaw) + return delivery, nil +} + +type renderOutcome struct { + result render.Result + err error +} + +func renderWithContext(ctx context.Context, renderer render.Renderer, request render.Request) (render.Result, error) { + outcomes := make(chan renderOutcome, 1) + go func() { + result, err := renderer.Render(ctx, request) + outcomes <- renderOutcome{result: result, err: err} + }() + select { + case <-ctx.Done(): + return render.Result{}, ctx.Err() + case outcome := <-outcomes: + return outcome.result, outcome.err + } +} + +func diagnosticFailure(stage, code string, err error, diagnostics []render.Diagnostic) error { + cloned := append([]render.Diagnostic(nil), diagnostics...) + if len(cloned) == 0 { + cloned = []render.Diagnostic{{Code: code, Severity: render.SeverityError, Message: err.Error()}} + } + return &DiagnosticError{Stage: stage, Code: code, Diagnostics: cloned, Err: err} +} + +func normalizeLimits(input Limits) (Limits, error) { + if input.MaxMarkdownBytes < 0 || input.MaxNodes < 0 || input.MaxDepth < 0 { + return Limits{}, fmt.Errorf("%w: limits cannot be negative", ErrResourceLimit) + } + if input.MaxMarkdownBytes == 0 { + input.MaxMarkdownBytes = 2 << 20 + } + if input.MaxNodes == 0 { + input.MaxNodes = 10_000 + } + if input.MaxDepth == 0 { + input.MaxDepth = 64 + } + return input, nil +} + +func workspaceMarkdown(request Request, profileID, profileVersion string) ([]byte, bool, error) { + if strings.TrimSpace(request.DocumentID) == "" || strings.TrimSpace(request.Title) == "" || + strings.TrimSpace(request.DocumentType) == "" || strings.TrimSpace(request.Language) == "" { + return nil, false, errors.New("docgen: document ID, title, document type, and language are required") + } + if request.Mode == "" || request.FrozenAt.IsZero() || strings.TrimSpace(request.RequestedBy) == "" { + return nil, false, errors.New("docgen: mode, frozen time, and requester are required") + } + if bytes.HasPrefix(bytes.TrimSpace(request.Markdown), []byte("---")) { + return bytes.Clone(request.Markdown), false, nil + } + quote := func(value string) string { + raw, _ := json.Marshal(value) + return string(raw) + } + var header strings.Builder + header.WriteString("---\n") + fmt.Fprintf(&header, "documentId: %s\n", quote(request.DocumentID)) + fmt.Fprintf(&header, "projectId: %s\n", quote(WorkspaceProjectID)) + fmt.Fprintf(&header, "documentType: %s\n", quote(request.DocumentType)) + fmt.Fprintf(&header, "title: %s\n", quote(request.Title)) + fmt.Fprintf(&header, "language: %s\n", quote(request.Language)) + fmt.Fprintf(&header, "profileId: %s\n", quote(profileID)) + fmt.Fprintf(&header, "profileVersion: %s\n", quote(profileVersion)) + header.WriteString("controlled: false\n---\n\n") + header.Write(bytes.TrimSpace(request.Markdown)) + header.WriteByte('\n') + return []byte(header.String()), true, nil +} + +func validateWorkspaceMetadata(request Request, metadata markdownrenderer.Metadata, profileID, profileVersion string) error { + if metadata.Controlled || metadata.ProjectID != WorkspaceProjectID { + return ErrRDMRequired + } + if metadata.ProfileID != profileID || metadata.ProfileVersion != profileVersion { + return fmt.Errorf("%w: Markdown binds %s@%s, available %s@%s", ErrProfileMismatch, + metadata.ProfileID, metadata.ProfileVersion, profileID, profileVersion) + } + if metadata.DocumentID != request.DocumentID || metadata.DocumentType != request.DocumentType || + metadata.Title != request.Title || metadata.Language != request.Language { + return errors.New("docgen: persisted Markdown metadata does not match the frozen request") + } + return nil +} + +func artifact(name, mime string, raw []byte) Artifact { + sum := sha256.Sum256(raw) + // Callers transfer ownership of freshly produced buffers to the delivery. + return Artifact{Name: name, MIME: mime, SHA256: hex.EncodeToString(sum[:]), Bytes: raw} +} + +func manifestArtifact(value Artifact) ManifestArtifact { + return ManifestArtifact{Name: value.Name, MIME: value.MIME, Size: len(value.Bytes), SHA256: value.SHA256} +} + +func buildArchive(artifacts ...Artifact) ([]byte, error) { + items := append([]Artifact(nil), artifacts...) + sort.Slice(items, func(i, j int) bool { return items[i].Name < items[j].Name }) + var buffer bytes.Buffer + archive := zip.NewWriter(&buffer) + for _, item := range items { + header := &zip.FileHeader{Name: item.Name, Method: zip.Deflate} + header.SetModTime(time.Date(1980, 1, 1, 0, 0, 0, 0, time.UTC)) + header.SetMode(0o644) + writer, err := archive.CreateHeader(header) + if err != nil { + return nil, fmt.Errorf("docgen: create archive entry %s: %w", item.Name, err) + } + if _, err := writer.Write(item.Bytes); err != nil { + return nil, fmt.Errorf("docgen: write archive entry %s: %w", item.Name, err) + } + } + if err := archive.Close(); err != nil { + return nil, fmt.Errorf("docgen: close delivery archive: %w", err) + } + return buffer.Bytes(), nil +} + +func cloneStringMap(source map[string]string) map[string]string { + clone := make(map[string]string, len(source)) + for key, value := range source { + clone[key] = value + } + return clone +} + +func safeBaseName(title string) string { + return strings.TrimSuffix(SuggestName(title), ".docx") +} + +func contextErr(ctx context.Context) error { + select { + case <-ctx.Done(): + return fmt.Errorf("docgen: render canceled: %w", ctx.Err()) + default: + return nil + } +} diff --git a/internal/docgen/renderer_integration_test.go b/internal/docgen/renderer_integration_test.go new file mode 100644 index 0000000..c3cacdc --- /dev/null +++ b/internal/docgen/renderer_integration_test.go @@ -0,0 +1,473 @@ +package docgen + +import ( + "archive/zip" + "bytes" + "context" + "encoding/json" + "encoding/xml" + "errors" + "io" + "reflect" + "strings" + "testing" + "time" + + markdownrenderer "agent-document-renderer/markdown" + "agent-document-renderer/model" + "agent-document-renderer/profile" + "agent-document-renderer/render" +) + +const representativeMarkdown = `# 研发周会纪要 + +这是普通工作区交付物的正文。 + +## 要点 + +- 统一解析入口 +- 保留 Markdown + +| 项目 | 状态 | +|---|---| +| 解析器 | 统一 | + +![公司默认样图](asset:company.default.sample-image@1.0.0) + +:::callout warning +公司默认规则仍待人工视觉评审。 +::: + +:::page-break + +分页后的结论。 +` + +func workspaceRequest(markdown []byte) Request { + return Request{ + DocumentID: "workspace-minutes", + Title: "研发周会纪要", + DocumentType: "general", + Language: "zh-CN", + Markdown: markdown, + Mode: render.ModePreview, + FrozenAt: time.Date(2026, 10, 15, 12, 0, 0, 0, time.UTC), + RequestedBy: "alice", + } +} + +func TestGenerateProducesDeterministicHashedDeliveryPackage(t *testing.T) { + request := workspaceRequest([]byte(representativeMarkdown)) + first, err := Generate(context.Background(), request) + if err != nil { + t.Fatalf("first Generate: %v", err) + } + second, err := Generate(context.Background(), request) + if err != nil { + t.Fatalf("second Generate: %v", err) + } + for _, pair := range []struct { + name string + a Artifact + b Artifact + }{ + {"Markdown", first.Markdown, second.Markdown}, + {"DOCX", first.DOCX, second.DOCX}, + {"manifest", first.Manifest, second.Manifest}, + {"archive", first.Archive, second.Archive}, + } { + if pair.a.SHA256 == "" || pair.a.SHA256 != pair.b.SHA256 || !bytes.Equal(pair.a.Bytes, pair.b.Bytes) { + t.Errorf("%s is not byte deterministic: first=%s second=%s", pair.name, pair.a.SHA256, pair.b.SHA256) + } + } + + var manifest Manifest + if err := json.Unmarshal(first.Manifest.Bytes, &manifest); err != nil { + t.Fatalf("decode manifest: %v", err) + } + if manifest.SchemaVersion != ManifestSchemaVersion || manifest.RendererIdentity != RendererIdentity || + manifest.SelectionSource != "organization-default" || !manifest.Profile.Candidate || + manifest.Profile.ReviewStatus != "pending-human-visual-review" || manifest.Profile.PublicationAllowed { + t.Fatalf("manifest profile provenance = %#v", manifest) + } + if manifest.Profile.ProfileSHA256 == "" || manifest.Profile.AssetManifestSHA256 == "" || manifest.Profile.ReviewSHA256 == "" { + t.Fatalf("manifest omitted source hashes: %#v", manifest.Profile) + } + listed := map[string]string{} + for _, item := range manifest.Artifacts { + listed[item.Name] = item.SHA256 + } + if listed[first.Markdown.Name] != first.Markdown.SHA256 || listed[first.DOCX.Name] != first.DOCX.SHA256 { + t.Fatalf("manifest artifact hashes = %#v, want Markdown=%s DOCX=%s", listed, first.Markdown.SHA256, first.DOCX.SHA256) + } + if manifest.Renderer.ArtifactHash != first.DOCX.SHA256 || manifest.Renderer.FrozenAt != request.FrozenAt || manifest.Renderer.RequestedBy != request.RequestedBy { + t.Fatalf("renderer receipt does not match frozen request: %#v", manifest.Renderer) + } + + zr, err := zip.NewReader(bytes.NewReader(first.Archive.Bytes), int64(len(first.Archive.Bytes))) + if err != nil { + t.Fatalf("open delivery archive: %v", err) + } + archiveFiles := map[string][]byte{} + for _, file := range zr.File { + stream, err := file.Open() + if err != nil { + t.Fatal(err) + } + raw, err := io.ReadAll(stream) + stream.Close() + if err != nil { + t.Fatal(err) + } + archiveFiles[file.Name] = raw + } + for _, item := range []Artifact{first.Markdown, first.DOCX, first.Manifest} { + if !bytes.Equal(archiveFiles[item.Name], item.Bytes) { + t.Errorf("archive %s bytes do not match delivered artifact", item.Name) + } + } +} + +func TestGeneratePersistsCanonicalMarkdownWithStableNodeParity(t *testing.T) { + delivery, err := Generate(context.Background(), workspaceRequest([]byte(representativeMarkdown))) + if err != nil { + t.Fatalf("Generate: %v", err) + } + + reparsed, err := markdownrenderer.Parse(delivery.Markdown.Bytes, markdownrenderer.Options{ + FirstImport: false, + MaxBytes: 2 << 20, + MaxNodes: 10_000, + MaxDepth: 64, + }) + if err != nil { + t.Fatalf("persisted Markdown is not independently parseable: %v", err) + } + if !reflect.DeepEqual(reparsed.Document, delivery.Document) { + t.Fatalf("canonical nodes changed across the persisted Markdown entry\nfirst: %#v\nsecond: %#v", delivery.Document, reparsed.Document) + } + if reparsed.Metadata.DocumentID != "workspace-minutes" || reparsed.Metadata.ProjectID != WorkspaceProjectID || + reparsed.Metadata.DocumentType != "general" || reparsed.Metadata.Title != "研发周会纪要" || + reparsed.Metadata.Language != "zh-CN" || reparsed.Metadata.ProfileID != "company.default" || + reparsed.Metadata.ProfileVersion != "1.0.0" || reparsed.Metadata.Controlled { + t.Fatalf("controlled metadata changed: %#v", reparsed.Metadata) + } + + wantKinds := map[model.NodeKind]int{ + model.NodeHeading: 2, + model.NodeParagraph: 2, + model.NodeList: 1, + model.NodeTable: 1, + model.NodeImage: 1, + model.NodeCallout: 1, + model.NodePageBreak: 1, + } + gotKinds := map[model.NodeKind]int{} + seenIDs := map[string]bool{} + var visit func(model.Node) + visit = func(node model.Node) { + if node.ID == "" || seenIDs[node.ID] { + t.Fatalf("node ID is missing or unstable: %q", node.ID) + } + seenIDs[node.ID] = true + gotKinds[node.Kind]++ + for _, child := range node.Children { + visit(child) + } + } + visit(delivery.Document.Root) + for kind, want := range wantKinds { + if got := gotKinds[kind]; got != want { + t.Errorf("%s nodes = %d, want %d", kind, got, want) + } + } + if !strings.Contains(string(delivery.Markdown.Bytes), "` 可选主题），再 `python3 -m housestyle.build 方案.md` 确定性渲染成 docx——build 自动跑 lint 并回读结构（写入即诊断），有 error 就改 .md 源的对应段落再重建，不要整段重写。修改已有交付物 = `edit_file` 改 .md 源 + 重新 build。Excel/PPT/图片等其他类型仍用 `run_python` + 对应 kit。文件都在会话工作区；模板和参考原件在 `inputs/`（环境段列出相对路径）。 -4. **自检**：`python3 -m housestyle.lint <文件>`。输出为 JSON；存在 severity=error 时必须修好再继续，不要带着 error 登记。然后用 `python3 -m housestyle.outline_cli <文件>` 回读标题、表格和页数，核对与规划一致。 -5. **登记**：`register_artifact`（path 传相对路径）。登记后对话里出现可预览的卡片。 +3. **生成 Word**：先用 `time_now` 冻结 `frozenAt`，再调用 `render_document`，传稳定 `documentId`、标题 `name`、Markdown、语言和 `working|preview` 模式，并显式传 `controlled=false`、`projectDocument=false`；任何一项不是 false 就停止并交给 RDM。Markdown 用 `#`-`######` 标题、段落、`-`/`1.` 列表、GFM 表格、`asset:` 图片、`:::callout warning`/`:::` 提示块和 `:::page-break`。工具先保存带稳定 node ID 的 Markdown，再生成确定性 DOCX、manifest 和完整 zip；返回值逐项列出 SHA-256。失败时按诊断修 Markdown，绝不调用 legacy Word 路径回退。 +4. **生成其他格式并自检**：Excel/PPT/图片用 `run_python` + house-style 对应 kit；用 lint/outline 回读。Word 的 OPC、安全、锚点与回读校验已经由统一 renderer 执行，复核 manifest 中的诊断、组织默认候选状态和 Markdown/DOCX 哈希。 +5. **登记**：`render_document` 已登记 Markdown、DOCX、manifest 和 zip，不要重复登记。其他格式继续用 `register_artifact`。 6. **收尾**：回复只写结论摘要，并说明这次用的样式（主题、是否模板、是否仿制）以及用户还能怎么调。不要在回复里复述全文，也不要只口头说文件名。 检索与读取的工具结果末尾带【src_N｜工具名】来源标记：成文时数字与关键事实的出处就是这些带标记的结果，逐项核对；交付物里的每一个百分比、日期和大额数字，都必须能在本轮上传材料或你自己的工具/计算输出里找到出处；找不到出处的，要么删除，要么用「目标 / 预计 / 假设」等词在文中显式标注为规划量（如「目标 85%」「预计三个月」）。终轮会对无出处且未标注的数字拦截两轮；仍无法回溯又拒绝标注的，会被系统如实记为未核实。 @@ -34,7 +34,7 @@ description: 生成文档、表格、演示稿的工作流、样式决策与技 技能与路径： - 技能目录是环境变量 `AGENT_SKILLS_DIR`（环境段会写出绝对路径）。`PYTHONPATH` 已包含其中的 `house-style`，脚本里直接 `import housestyle`。 -- **house-style**：设计系统、三套主题、模板与仿制、lint。先读 `$AGENT_SKILLS_DIR/house-style/SKILL.md`。 +- **house-style**：Excel/PPT/图片设计系统及 Word 迁移对照工具。普通 Word 生产路径仍以 `render_document` 为唯一入口；先读 `$AGENT_SKILLS_DIR/house-style/SKILL.md`。 - **docx-author / xlsx-author / pptx-author**：各类交付物的版面范式和最小示例。 - **frontend-design / canvas-design / copywriting / copy-editing**（第三方 vendor，溯源见各自 UPSTREAM.md）：视觉方向与排版审美、海报/信息图等 png·pdf 视觉产物（PIL 渲染，字体已随包）、营销/商务文案的撰写改写与编辑润色。交付物主题与配色仍以 house-style 为权威；需要超出主题规范的视觉判断或文案功力时 `load_skill` 对应技能。 - 小队角色用 `load_skill`；其他路径用 `run_shell` 查看技能文件，例如 `cat "$AGENT_SKILLS_DIR/house-style/SKILL.md"`。不要假设工作区里有 `skills/` 目录。 diff --git a/internal/prompts/library/base-quality.md b/internal/prompts/library/base-quality.md index 8cf616b..e8d9597 100644 --- a/internal/prompts/library/base-quality.md +++ b/internal/prompts/library/base-quality.md @@ -42,4 +42,4 @@ description: 对回复、文档、表格、演示、代码与数据一律适用 - 完整：要求的部分都在，没有空节。 - 准确：人名、时间、数字、引用与材料一致；不确定处已标注。 - 一致：术语、日期格式、称谓、口径前后相同。 -- 版式：Office 文件必须先过 housestyle.lint，存在 error 先修再登记。 +- 版式：Word 必须有共享 renderer manifest 且无 error 诊断；Excel/PPT 必须先过 housestyle.lint，存在 error 先修再登记。 diff --git a/internal/prompts/library/task-doc-minutes.md b/internal/prompts/library/task-doc-minutes.md index f3c23a3..3483fd2 100644 --- a/internal/prompts/library/task-doc-minutes.md +++ b/internal/prompts/library/task-doc-minutes.md @@ -28,4 +28,4 @@ triggers: - 待办事项若原文未指明负责人或期限，写"未指明"，不要编造。 - 版面：标题下用键值表写会议信息（时间、地点、主持人、参会人、缺席）。讨论按议题分节，每节含要点、分歧和结论。决议用真编号列表，不要再手写“1.”。待办用表格，列：序号、事项、负责人、期限、状态；原文没有的写“未指明”。发言人用统一称谓（职务或姓名）；原文只有“说话人X”时保留并在文末说明。引语只留关键句，并标注是谁说的。 - 日期和数字全文一种格式。不要空节、空段落和手打项目符号。 -- 交付形态：按「交付物工作流」用 housestyle.docx_kit 生成「<主题>会议纪要.docx」，lint 无 error 后再 register_artifact。对话里只简述结论和所用样式，不要复述全文。 +- 交付形态：普通工作区纪要按「交付物工作流」调用 `render_document`，生成「<主题>会议纪要.md/.docx/.manifest.json/.zip」；项目或受控纪要交给 RDM。对话里只简述结论、规则候选状态和可调项，不要复述全文。 diff --git a/internal/prompts/library/task-report.md b/internal/prompts/library/task-report.md index 3fe6b48..f17f3df 100644 --- a/internal/prompts/library/task-report.md +++ b/internal/prompts/library/task-report.md @@ -25,4 +25,4 @@ triggers: - 结构服务于阅读动线：先结论后论证；每章开头一句话说清本章要点。 - 篇幅完整不注水：覆盖必要内容，删掉不改变结论的空话。 - 版面：封面（标题、受众、日期）、正文从执行摘要开始。执行摘要用强调块，控制在契约规定的篇幅内。章标题用标题样式，章首一句点明本章要点。数据进表格或附录，不埋在段落里。需要时在正文前放由标题生成的目录说明（页码以文件为准）。 -- 交付 Word 时走交付物工作流：housestyle.docx_kit 生成，lint 无 error 后登记。回复说明样式，不复述全文。 +- 交付普通工作区 Word 时走交付物工作流的 `render_document`，同时保留 Markdown、manifest 和归档；项目或受控报告交给 RDM。回复说明规则候选状态，不复述全文。 diff --git a/internal/prompts/library/tool-render-document.md b/internal/prompts/library/tool-render-document.md new file mode 100644 index 0000000..b9e5068 --- /dev/null +++ b/internal/prompts/library/tool-render-document.md @@ -0,0 +1,10 @@ +--- +id: tool.render_document +layer: tool +version: 1 +title: render_document 工具描述 +description: 普通工作区 Markdown 到统一 Word 交付包的安全渲染入口 +--- +把普通、非受控的工作区 Markdown 交给共享 canonical parser、组织默认候选 profile 和 Word adapter。先用 time_now 取得 frozenAt；必须显式传 `controlled=false` 和 `projectDocument=false`，缺任一字段即拒绝；requester 由系统可信身份填写，不要作为参数伪造。成功会按顺序保存 Markdown、DOCX、manifest 和 zip，并返回每项 SHA-256。 + +只允许 working 或 preview。项目文档、受控文档、专用模板、审阅稿或批准稿必须交给 RDM；失败不得改走 legacy Word builder。当前公司默认规则状态是 pending-human-visual-review，只可用于普通工作/预览交付，不能称为已发布或已视觉批准。 diff --git a/internal/prompts/library/tool-run-python.md b/internal/prompts/library/tool-run-python.md index 1a5cf53..dfa5c8d 100644 --- a/internal/prompts/library/tool-run-python.md +++ b/internal/prompts/library/tool-run-python.md @@ -5,4 +5,4 @@ version: 4 title: run_python 工具描述 description: Python 执行原语的模型侧说明文案 --- -执行完整 Python 脚本（python3，工作目录=会话工作区）。适用：数据处理、生成 Excel/PPT/图片（housestyle kit）、批量操作。Word 交付物优先写 .md 源后用 run_shell 跑 `python3 -m housestyle.build`。任何 Office 交付物（docx/xlsx/pptx）都禁止用 zipfile 或字符串手工拼 OOXML——手拼的包缺母版与主题，register_artifact 的结构自检会直接拒绝；一律走 housestyle kit 构件。基础层已有 python-docx、openpyxl、python-pptx 等，直接 import。缺的包用 python_env 申请（status 先看清单，request 再等），不要 pip install：沙箱不联网。申请被拒绝就如实说明缺什么，不要退回手拼。kit 路线执行失败（报错、超时、后台任务溢出）时，修复后仍走 kit 路线重试——任何失败都不构成退回手工拼 OOXML 的理由。报错先读退出码与 traceback 定位行号再改，同一错误不要原样重跑。生成带排版的文件（xlsx/pptx）先读 `$AGENT_SKILLS_DIR/house-style/SKILL.md` 的构件表，不确定签名先 `inspect.signature`。 +执行完整 Python 脚本（python3，工作目录=会话工作区）。适用：数据处理、生成 Excel/PPT/图片（housestyle kit）、批量操作。普通 Word 生产交付不用 Python，调用 `render_document`；受控或项目 Word 交给 RDM。任何 Office 交付物都禁止用 zipfile 或字符串手工拼 OOXML。基础层已有 openpyxl、python-pptx 等；缺包用 python_env，禁止 pip install。失败先读退出码与 traceback，不原样盲试。生成 xlsx/pptx 前读 `$AGENT_SKILLS_DIR/house-style/SKILL.md`。 diff --git a/internal/prompts/library/tool-run-shell.md b/internal/prompts/library/tool-run-shell.md index 2409e58..581d5e7 100644 --- a/internal/prompts/library/tool-run-shell.md +++ b/internal/prompts/library/tool-run-shell.md @@ -5,4 +5,4 @@ version: 2 title: run_shell 工具描述 description: bash 执行原语的模型侧说明文案 --- -在会话工作区内执行 bash 脚本（环境最小化：PATH/HOME/LANG；AGENT_SKILLS_DIR 与 PYTHONPATH 已注入）。适用：housestyle build/lint、文件批操作。Python 缺包用 python_env，不要 pip install。读文件用 read_file、找内容用 grep——不要用 cat/sed/grep 命令行代替专用工具。同一命令失败两次换方法。 +在会话工作区内执行 bash 脚本（环境最小化：PATH/HOME/LANG；AGENT_SKILLS_DIR 与 PYTHONPATH 已注入）。适用：Excel/PPT 的 housestyle lint、文件批操作。普通 Word 用 `render_document`，不要运行 legacy housestyle Word builder；受控或项目 Word 交给 RDM。Python 缺包用 python_env，不要 pip install。读文件用 read_file、找内容用 grep；同一命令失败两次换方法。 diff --git a/internal/prompts/library/tool-write-artifact.md b/internal/prompts/library/tool-write-artifact.md index dbbcc0f..55e64ea 100644 --- a/internal/prompts/library/tool-write-artifact.md +++ b/internal/prompts/library/tool-write-artifact.md @@ -9,4 +9,4 @@ description: 工件写入工具的模型侧说明文案 Markdown 交付物同样遵守专业交付标准：标题层级连续、对比用表格、不写空节、术语和日期格式全文一致。它不是把纯文本改一个扩展名。 -分工：本工具只收字符串内容，**不要用它写 .docx/.xlsx/.pptx 等二进制文件**（纯文本改扩展名是无排版的伪文件）。带排版的 Office/PDF/图片交付物由你用 run_python（或 run_shell）生成到工作区后，用 register_artifact 登记交付——配方见交付物工作流（base.deliverables）。 +分工：本工具只收字符串内容，**不要用它写 .docx/.xlsx/.pptx 等二进制文件**。普通 Word 用 `render_document` 一次生成并登记 Markdown、DOCX、manifest 和归档；受控或项目 Word 交给 RDM。Excel/PPT/PDF/图片用 run_python 或 run_shell 生成后再用 register_artifact 登记。 diff --git a/internal/prompts/prompts_test.go b/internal/prompts/prompts_test.go index 973696b..8cda4ce 100644 --- a/internal/prompts/prompts_test.go +++ b/internal/prompts/prompts_test.go @@ -96,6 +96,21 @@ func TestResolveSystemDefaultBase(t *testing.T) { } } +func TestBaseDeliverablesRoutesWordThroughUnifiedRenderer(t *testing.T) { + body, found, err := mustService(t).ModuleBody("", "base.deliverables") + if err != nil || !found { + t.Fatalf("base.deliverables: found=%v err=%v", found, err) + } + for _, required := range []string{"render_document", "Markdown", "manifest", "SHA-256", "pending-human-visual-review", "RDM"} { + if !strings.Contains(body, required) { + t.Errorf("base.deliverables missing %q", required) + } + } + if strings.Contains(body, "python3 -m housestyle.build") { + t.Fatal("base.deliverables still routes production Word through legacy housestyle.build") + } +} + func TestEnvDeliverablePlaceholders(t *testing.T) { svc := mustService(t) blocks, _, err := svc.ResolveSystem(core.AgentProfile{}, TriggerCtx{Text: "你好"}, EnvData{ diff --git a/internal/runtime/llm.go b/internal/runtime/llm.go index 1b479d7..94b2cec 100644 --- a/internal/runtime/llm.go +++ b/internal/runtime/llm.go @@ -651,7 +651,7 @@ func orDefault(s, def string) string { return s } -const deliverableGuardNote = "你的上一段回复声称已经生成或登记了文件，但这一轮没有产生对应的工件。请二选一：用 run_python 写出文件并调用 register_artifact 登记，或如实说明这一轮没有生成文件。不要编造工件 ID，也不要在回复里写 art_ 开头的编号。正文里的「调用工具」「工具结果」「产出工件」字样不会执行任何东西，调用工具必须用函数调用。" +const deliverableGuardNote = "你的上一段回复声称已经生成或登记了文件，但这一轮没有产生对应的工件。普通 Word 请调用 render_document；Excel/PPT/PDF/图片请用 run_python 生成并调用 register_artifact；否则如实说明没有生成。项目或受控 Word 必须交给 RDM。不要编造工件 ID，也不要在回复里写 art_ 开头的编号。正文里的「调用工具」「工具结果」「产出工件」字样不会执行任何东西，调用工具必须用函数调用。" const discardedClaimNote = "（上一段回复声称已交付，但本轮没有任何工具调用，已作废）" diff --git a/internal/skills/recipes/docx-author/SKILL.md b/internal/skills/recipes/docx-author/SKILL.md index 782c836..0ed9480 100644 --- a/internal/skills/recipes/docx-author/SKILL.md +++ b/internal/skills/recipes/docx-author/SKILL.md @@ -1,11 +1,13 @@ --- name: docx-author -description: 用 housestyle 生成可直接交付的 Word（.docx） +description: 用统一 renderer 生成 Markdown、DOCX、manifest 和归档 --- # docx 生成配方 -先读 `$AGENT_SKILLS_DIR/house-style/SKILL.md` 选定主题、模板或仿制结果。缺库时 `pip install --user python-docx`。脚本由 run_python 执行，文件落在会话工作区。 +先读 `$AGENT_SKILLS_DIR/house-style/SKILL.md`。普通、非受控工作区 Word 调用 `render_document`；先用 `time_now` 冻结时间，传稳定 documentId、标题和 Markdown。项目或受控 Word、专用模板、审阅与批准输出必须交给 RDM，禁止默认回退。 + +成功结果包括 Markdown、DOCX、manifest 和 zip，逐项核对 SHA-256；当前组织默认候选仍是 `pending-human-visual-review`。下面的 Python 构件只供显式迁移对照，不得用于生产交付或 renderer 失败回退。 ```python from housestyle import docx_kit as dx @@ -23,7 +25,7 @@ dx.add_callout(doc, "只看这一段也能知道要做什么。", "摘要") dx.save(doc, "交付物.docx") ``` -然后执行 `python3 -m housestyle.lint 交付物.docx`。没有 error 再 `register_artifact`。修订用新文件名。 +迁移对照必须显式设置 `AGENT_SYSTEM_LEGACY_WORD_COMPARISON=1`。生产 Word 的 OPC、安全、锚点与回读结果以共享 renderer manifest 为准；修订以返回的 Markdown 为权威源。 版面范式： diff --git a/internal/skills/recipes/house-style/SKILL.md b/internal/skills/recipes/house-style/SKILL.md index 8d12e88..001b191 100644 --- a/internal/skills/recipes/house-style/SKILL.md +++ b/internal/skills/recipes/house-style/SKILL.md @@ -1,11 +1,13 @@ --- name: house-style -description: 交付物设计系统。用 housestyle 生成 Word、Excel、PowerPoint，并在登记前自检。 +description: 交付物设计系统。普通 Word 使用统一 renderer；housestyle 继续生成 Excel、PowerPoint、图片并提供迁移对照。 --- # house-style -正式交付物的版式都从这里来。先选主题或模板，再用对应 kit 的构件，最后跑 lint。不要手写空段落、项目符号或 Word 默认蓝标题。 +普通、非受控工作区 Word 的生产入口是 `render_document`：它保存 Markdown、确定性 DOCX、manifest 和 zip，并在 manifest 标注组织默认候选 `pending-human-visual-review`。项目或受控 Word、专用模板、审阅和批准输出必须交给 RDM，禁止 Backend 默认回退。 + +housestyle 的 Excel、PowerPoint、图片构件继续用于生产。Python Word 构件只保留给显式迁移对照；`housestyle.build` 默认禁用，仅在 `AGENT_SYSTEM_LEGACY_WORD_COMPARISON=1` 时运行，而且永不作为共享 renderer 失败后的回退。 ## 主题 @@ -71,25 +73,27 @@ xs.save(wb, "交付物.xlsx", ["单位：元。口径见源表。"]) 标题用 `add_heading`，列表用 `add_bullets` / `add_numbers`，数据用 `add_table`。间距由样式控制。不要 `add_paragraph("")`，不要在普通段落开头写 `•`。 -## 源码化构建（Word 首选） +## 统一 Word 构建（生产） -```bash -python3 -m housestyle.build 方案.md # 渲染为 方案.docx，自动 lint + 回读结构 -python3 -m housestyle.build 方案.md -o 输出.docx +```text +1. time_now 冻结 frozenAt。 +2. 调用 render_document，传稳定 documentId、name、Markdown、language、working|preview，并显式传 controlled=false、projectDocument=false。 +3. 核对返回的 Markdown、DOCX、manifest、zip 四项 SHA-256。 +4. 修改时以返回的 Markdown 为权威源，再次调用同一工具；失败不走 legacy 回退。 ``` -`.md` 源是可编辑的交付物源码：`# 标题`、`>` 引用、`##/###/####` 三级标题、`-`/`1.` 列表、 -`| |` 表格、`!!! 标签 文本` 强调块；首行 `` -可选主题。build 退出码非 0 时按输出的诊断改 .md 源对应段落后重建；修改交付物 = edit 源 + 重建。 -Excel/PPT 用对应 kit 的 run_python 脚本。 +Markdown 支持 `#`-`######` 标题、段落、`-`/`1.` 列表、GFM 表格、已声明 `asset:` 图片、 +`:::callout warning`/`:::` 提示块和 `:::page-break`。脚本、HTML、外链图片、未知指令和未声明资产会 fail-closed。 + +迁移对照如需运行旧构建器，显式设置 `AGENT_SYSTEM_LEGACY_WORD_COMPARISON=1` 后调用模块；它的输出只供对照，不得交付或替代统一 renderer 输出。Excel/PPT 仍用对应 kit 的 run_python 脚本。 ## 自检 ```bash -python3 -m housestyle.lint 交付物.docx -python3 -m housestyle.outline_cli 交付物.docx +python3 -m housestyle.lint 交付物.xlsx +python3 -m housestyle.outline_cli 交付物.pptx ``` -lint 打印 JSON。`severity` 为 `error` 时退出码是 1，必须修好再 `register_artifact`。模板生成的文件会把纸张、字体、主题色、页码降为 warning，结构问题（空段、空节、手打符号、跳级）仍然是 error。 +lint 打印 JSON。`severity` 为 `error` 时退出码是 1，必须修好再 `register_artifact`。Word 的安全、OPC、锚点和结构诊断由共享 renderer 写入 manifest。 回读结果要和动笔前的结构一致：没有空节，表格列和内容对应，页数或幻灯片数合理。 diff --git a/internal/skills/recipes/house-style/housestyle/build.py b/internal/skills/recipes/house-style/housestyle/build.py index 8230ae5..e1a06aa 100644 --- a/internal/skills/recipes/house-style/housestyle/build.py +++ b/internal/skills/recipes/house-style/housestyle/build.py @@ -1,9 +1,9 @@ -"""交付物源码化渲染：python3 -m housestyle.build <源.md> [-o 输出.docx]。 +"""Legacy Word migration comparator. -把可编辑的 Markdown 源文件确定性渲染为 docx（docx_kit 构件 + 主题）， -写入即诊断：渲染后自动跑 lint 并回读结构，severity=error 时退出码 1， -诊断信息带触发段落原文，模型据此改 .md 源再重建（改源码→编译→看诊断）， -不再整段重写生成脚本。xlsx/pptx 等其他类型仍走 run_python + 对应 kit。 +普通 Word 生产交付必须调用 Backend 的 render_document 工具，共享 canonical +parser/profile/compiler/Word adapter。此模块仅在 +AGENT_SYSTEM_LEGACY_WORD_COMPARISON=1 时用于迁移对照，永不作为 renderer +失败后的回退。xlsx/pptx 等其他类型仍走 run_python + 对应 kit。 Markdown 约定： # 标题 文档标题（Title，只取第一个） @@ -20,6 +20,7 @@ Markdown 约定： from __future__ import annotations import json +import os import sys from pathlib import Path @@ -28,6 +29,13 @@ from housestyle import lint def build(source: str, output: str | None = None) -> int: + if os.environ.get("AGENT_SYSTEM_LEGACY_WORD_COMPARISON") != "1": + print( + "build: legacy Word path is disabled; use the render_document tool " + "(set AGENT_SYSTEM_LEGACY_WORD_COMPARISON=1 only for migration comparison)", + file=sys.stderr, + ) + return 2 src = Path(source) if not src.is_file(): print(f"build: 源文件不存在: {source}", file=sys.stderr) diff --git a/internal/skills/recipes/house-style/tests/test_housestyle.py b/internal/skills/recipes/house-style/tests/test_housestyle.py index 0afba31..5f8b292 100644 --- a/internal/skills/recipes/house-style/tests/test_housestyle.py +++ b/internal/skills/recipes/house-style/tests/test_housestyle.py @@ -1,5 +1,6 @@ import tempfile import unittest +from unittest import mock from pathlib import Path from docx import Document @@ -171,20 +172,34 @@ if __name__ == "__main__": class BuildTests(unittest.TestCase): + def test_legacy_word_build_is_disabled_by_default(self): + import os + from housestyle import build as B + with tempfile.TemporaryDirectory() as d: + src = os.path.join(d, "plan.md") + out = os.path.join(d, "plan.docx") + Path(src).write_text("# 方案\n\n正文。\n", encoding="utf-8") + with mock.patch.dict(os.environ, {}, clear=False): + os.environ.pop("AGENT_SYSTEM_LEGACY_WORD_COMPARISON", None) + self.assertEqual(B.build(src, out), 2) + self.assertFalse(os.path.exists(out)) + def test_build_renders_markdown_and_passes_lint(self): import tempfile, os, subprocess, sys, json from housestyle import build as B with tempfile.TemporaryDirectory() as d: src = os.path.join(d, "plan.md") out = os.path.join(d, "plan.docx") - open(src, "w", encoding="utf-8").write( + Path(src).write_text( "# 测试方案：先写需求再开发\n\n" "## 一、结论\n结论：先写需求文档。\n\n" "- 第一步：停代码\n- 第二步：写需求\n\n" "## 二、行动项\n\n| 事项 | 负责人 |\n|---|---|\n| 需求文档 | 陈威 |\n\n" - "1. 确认设计输入\n" + "1. 确认设计输入\n", + encoding="utf-8", ) - self.assertEqual(B.build(src, out), 0) + with mock.patch.dict(os.environ, {"AGENT_SYSTEM_LEGACY_WORD_COMPARISON": "1"}): + self.assertEqual(B.build(src, out), 0) self.assertTrue(os.path.exists(out)) from housestyle.outline import summarize o = summarize(out) @@ -199,16 +214,20 @@ class BuildTests(unittest.TestCase): # 标题跳级（## 后直接 ####）触发 heading-skip error —— 诊断导向改源。 src = os.path.join(d, "bad.md") out = os.path.join(d, "bad.docx") - open(src, "w", encoding="utf-8").write("# 标题\n\n## 一、章节\n\n#### 跳级\n内容\n") - self.assertEqual(B.build(src, out), 1) + Path(src).write_text("# 标题\n\n## 一、章节\n\n#### 跳级\n内容\n", encoding="utf-8") + with mock.patch.dict(os.environ, {"AGENT_SYSTEM_LEGACY_WORD_COMPARISON": "1"}): + self.assertEqual(B.build(src, out), 1) def test_build_cli_entry(self): import subprocess, sys, tempfile, os with tempfile.TemporaryDirectory() as d: src = os.path.join(d, "s.md") - open(src, "w", encoding="utf-8").write("# T\n\n## 一、A\n内容\n") + Path(src).write_text("# T\n\n## 一、A\n内容\n", encoding="utf-8") + env = os.environ.copy() + env["AGENT_SYSTEM_LEGACY_WORD_COMPARISON"] = "1" r = subprocess.run([sys.executable, "-m", "housestyle.build", src, "-o", os.path.join(d, "s.docx")], - capture_output=True, text=True, cwd=os.path.dirname(os.path.dirname(os.path.abspath(__file__)))) + capture_output=True, text=True, env=env, + cwd=os.path.dirname(os.path.dirname(os.path.abspath(__file__)))) # PYTHONPATH 由调用方保证；这里直接在 house-style 根目录下跑模块。 if r.returncode not in (0, 1): self.fail(r.stderr[:200]) diff --git a/internal/skills/skills_test.go b/internal/skills/skills_test.go index 4123696..7daacc2 100644 --- a/internal/skills/skills_test.go +++ b/internal/skills/skills_test.go @@ -177,6 +177,22 @@ func TestEmbedIncludesPackageInit(t *testing.T) { } } +func TestHouseStyleRoutesProductionWordThroughUnifiedRenderer(t *testing.T) { + raw, err := recipes.ReadFile("recipes/house-style/SKILL.md") + if err != nil { + t.Fatal(err) + } + body := string(raw) + for _, required := range []string{"render_document", "pending-human-visual-review", "RDM", "AGENT_SYSTEM_LEGACY_WORD_COMPARISON"} { + if !strings.Contains(body, required) { + t.Errorf("house-style skill missing %q", required) + } + } + if strings.Contains(body, "python3 -m housestyle.build 方案.md") { + t.Fatal("house-style still advertises the legacy Word builder as a production command") + } +} + func TestHouseStylePython(t *testing.T) { if _, err := exec.LookPath("python3"); err != nil { t.Skip("python3 not available") diff --git a/internal/tools/docx_e2e_test.go b/internal/tools/docx_e2e_test.go index 62eed2b..f8942a4 100644 --- a/internal/tools/docx_e2e_test.go +++ b/internal/tools/docx_e2e_test.go @@ -7,7 +7,7 @@ import ( "testing" ) -func TestHousestyleBuildPassesOOXMLGate(t *testing.T) { +func TestLegacyComparisonHousestyleBuildPassesOOXMLGate(t *testing.T) { py, err := exec.LookPath("python3") if err != nil { t.Skip("python3 not available") @@ -32,7 +32,7 @@ func TestHousestyleBuildPassesOOXMLGate(t *testing.T) { } cmd := exec.Command(py, "-m", "housestyle.build", src) cmd.Dir = dir - cmd.Env = append(os.Environ(), "PYTHONPATH="+skill) + cmd.Env = append(os.Environ(), "PYTHONPATH="+skill, "AGENT_SYSTEM_LEGACY_WORD_COMPARISON=1") if out, err := cmd.CombinedOutput(); err != nil { t.Fatalf("housestyle.build: %v\n%s", err, out) } diff --git a/internal/tools/exec_interpreter.go b/internal/tools/exec_interpreter.go index d44aa9f..35130e5 100644 --- a/internal/tools/exec_interpreter.go +++ b/internal/tools/exec_interpreter.go @@ -31,7 +31,7 @@ import ( func RegisterInterpreterTools(r *Registry) error { if err := r.Register(core.ToolDesc{ Name: "run_shell", Source: core.SourceBuiltin, Risk: "medium", - Description: "在会话工作区目录内执行 bash 脚本：检查环境、处理文件、调用 python3 -m housestyle.build。脚本原样落盘执行；返回退出码与合并输出（stdout+stderr，超限头尾截断）。沙箱断网且不继承宿主家目录，不要用 pip/apt 安装；缺的 Python 包用 python_env 向系统申请。", + Description: "在会话工作区目录内执行 bash 脚本：检查环境、处理文件、运行 Excel/PPT 的 housestyle lint。普通 Word 使用 render_document。脚本原样落盘执行；返回退出码与合并输出（stdout+stderr，超限头尾截断）。沙箱断网且不继承宿主家目录，不要用 pip/apt 安装；缺的 Python 包用 python_env 向系统申请。", Parameters: json.RawMessage(`{"type":"object","properties":{` + `"script":{"type":"string","description":"bash 脚本（可多行）"},` + `"timeout_sec":{"type":"integer","description":"超时秒数（默认 600，可自行设更长）"}}` + -- 2.54.0 From 35bd87cad83a97e31c3d105866c6941d6d07013c Mon Sep 17 00:00:00 2001 From: weichen Date: Thu, 15 Oct 2026 21:13:48 +0000 Subject: [PATCH 33/41] Update renderer for semantic and cancellation repair Why: The Task 10 corrective pass requires the shared Renderer semantic Markdown model and synchronous cooperative cancellation APIs. Evidence: Renderer go test ./... and Backend go test ./internal/docgen -count=1 passed at d5cd8c126045a27d5a5cc5da23f64d3c737e116a. Impact: Advances only the immutable agent-document-renderer gitlink; Backend repair behavior is committed separately. Refs: Unified Document Renderer Task 10 review repair; /tmp/task10-backend-review-last.md --- deps/agent-document-renderer | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/deps/agent-document-renderer b/deps/agent-document-renderer index d449b9f..d5cd8c1 160000 --- a/deps/agent-document-renderer +++ b/deps/agent-document-renderer @@ -1 +1 @@ -Subproject commit d449b9f779f2f968f8ac556b89940a6c9aaf3fdc +Subproject commit d5cd8c126045a27d5a5cc5da23f64d3c737e116a -- 2.54.0 From fec2d16cc6d91c095c515279326667c1fe3aeddb Mon Sep 17 00:00:00 2001 From: weichen Date: Thu, 15 Oct 2026 21:44:03 +0000 Subject: [PATCH 34/41] Close Task 10 renderer delivery gaps Why: - Independent review found trusted-boundary, semantic parity, replay-budget, comparison, persistence, cancellation, provenance, and routing gaps. - Storage migration must include the new durable delivery table. Evidence: - go test -count=1 ./... - go test -race ./internal/docgen ./internal/tools ./internal/runmgr - go test ./... (deps/agent-document-renderer) - go vet ./... - go build ./... - CGO_ENABLED=0 go build -trimpath ./cmd/agent-system - Python house-style unittest suite and git diff --check Impact: - Word delivery now uses host-owned freezes, Markdown-first resumable persistence, closed registration boundaries, semantic shared rendering, and real comparison. - Controlled/project documents still fail closed to RDM and non-Word flows remain unchanged. Refs: - Unified Document Renderer implementation plan Task 10 - /tmp/task10-backend-review-last.md - Renderer d5cd8c126045a27d5a5cc5da23f64d3c737e116a --- cmd/storage-migrate/main.go | 1 + internal/docgen/comparison.go | 337 +++++++++++++ .../internal/genrendereridentity/main.go | 39 ++ internal/docgen/operation.go | 40 ++ internal/docgen/renderer.go | 298 +++++++---- internal/docgen/renderer_identity.go | 3 + .../docgen/renderer_identity_generated.go | 7 + internal/docgen/renderer_integration_test.go | 265 ++++++++-- internal/prompts/library/base-deliverables.md | 2 +- .../prompts/library/tool-render-document.md | 2 +- internal/runmgr/document_delivery.go | 174 +++++++ internal/runmgr/document_delivery_test.go | 170 +++++++ internal/runmgr/exec_tool_artifact_test.go | 50 +- internal/runmgr/runmgr.go | 3 + internal/runtime/mock.go | 39 +- internal/skills/recipes/docx-author/SKILL.md | 22 +- internal/skills/recipes/house-style/SKILL.md | 33 +- .../recipes/house-style/housestyle/build.py | 173 +------ .../house-style/tests/test_housestyle.py | 42 +- internal/skills/skills_test.go | 8 +- internal/store/document_delivery.go | 475 ++++++++++++++++++ internal/store/document_delivery_test.go | 229 +++++++++ internal/store/migrate.go | 23 + internal/store/migrate_compat.go | 1 + internal/store/migrate_compat_test.go | 1 + internal/store/store.go | 4 + internal/tools/document_renderer.go | 70 +-- internal/tools/document_renderer_test.go | 113 ++++- internal/tools/docx_e2e_test.go | 19 +- internal/tools/exec.go | 4 + internal/tools/exec_interpreter.go | 2 +- internal/tools/fs.go | 11 +- 32 files changed, 2159 insertions(+), 501 deletions(-) create mode 100644 internal/docgen/comparison.go create mode 100644 internal/docgen/internal/genrendereridentity/main.go create mode 100644 internal/docgen/operation.go create mode 100644 internal/docgen/renderer_identity.go create mode 100644 internal/docgen/renderer_identity_generated.go create mode 100644 internal/runmgr/document_delivery.go create mode 100644 internal/runmgr/document_delivery_test.go create mode 100644 internal/store/document_delivery.go create mode 100644 internal/store/document_delivery_test.go diff --git a/cmd/storage-migrate/main.go b/cmd/storage-migrate/main.go index df15d94..5c696b1 100644 --- a/cmd/storage-migrate/main.go +++ b/cmd/storage-migrate/main.go @@ -286,6 +286,7 @@ func cmdBackup(args []string) error { var copyOrder = []string{ "projects", "users", "account_directory_revision", "profiles", "settings", "plugins", "conversations", "runs", "messages", "project_work_outbox", "events", "artifacts", + "document_render_deliveries", "hitl_cards", "human_decisions", "plans", "todos", "knowledge", "knowledge_vectors", "activity_cards", "project_event_shares", "command_audit", "project_audit_links", "prompt_modules", "sessions", "api_keys", diff --git a/internal/docgen/comparison.go b/internal/docgen/comparison.go new file mode 100644 index 0000000..8aca2d2 --- /dev/null +++ b/internal/docgen/comparison.go @@ -0,0 +1,337 @@ +package docgen + +import ( + "archive/zip" + "bytes" + "crypto/sha256" + "encoding/hex" + "encoding/json" + "encoding/xml" + "errors" + "fmt" + "io" + "strings" + + "agent-document-renderer/model" +) + +const ( + comparisonExceptionTitle = "RDR-T10-CMP-001" + comparisonExceptionCorporate = "RDR-T10-CMP-002" + comparisonExceptionAnchors = "RDR-T10-CMP-003" + comparisonExceptionSafeLinks = "RDR-T10-CMP-004" +) + +type comparisonBlock struct { + Kind string `json:"kind"` + Level int `json:"level,omitempty"` + Text []string `json:"text,omitempty"` + Rows [][]string `json:"rows,omitempty"` +} + +type docxComparison struct { + Paragraphs []string `json:"paragraphs"` + PageSize map[string]string `json:"pageSize"` + Margins map[string]string `json:"margins"` + Headers int `json:"headers"` + Footers int `json:"footers"` + Bookmarks int `json:"bookmarks"` + ExternalLinks int `json:"externalLinks"` + ForbiddenObject bool `json:"forbiddenObject"` + Semantics map[string]bool `json:"semantics"` +} + +func compareLegacyAndShared(title string, source []byte, canonical model.CanonicalDocument, legacy, shared []byte) ComparisonReceipt { + receipt := ComparisonReceipt{Enabled: true, LegacySHA256: digestBytes(legacy), SharedSHA256: digestBytes(shared)} + legacyStructure := legacyComparisonStructure(string(source)) + sharedStructure := canonicalComparisonStructure(canonical) + receipt.Dimensions = append(receipt.Dimensions, compareExactDimension("canonical-structure", legacyStructure, sharedStructure, "")) + + legacyDOCX, legacyErr := inspectComparisonDOCX(legacy) + sharedDOCX, sharedErr := inspectComparisonDOCX(shared) + if legacyErr != nil || sharedErr != nil { + detail := fmt.Sprintf("legacy=%v shared=%v", legacyErr, sharedErr) + for _, name := range []string{"visible-text", "page-layout", "header-footer", "node-bookmarks", "safe-links", "security-objects", "word-semantics"} { + receipt.Dimensions = append(receipt.Dimensions, ComparisonDimension{Name: name, Status: "unassessed", Detail: detail}) + } + return finishComparison(receipt) + } + + legacyParagraphs := append([]string(nil), legacyDOCX.Paragraphs...) + if len(legacyParagraphs) >= 2 && legacyParagraphs[0] == normalizeComparisonText(title) && legacyParagraphs[1] == normalizeComparisonText(title) { + withoutDuplicate := append([]string(nil), legacyParagraphs[1:]...) + if equalJSON(withoutDuplicate, sharedDOCX.Paragraphs) { + receipt.Dimensions = append(receipt.Dimensions, intentionalDimension("visible-text", legacyParagraphs, sharedDOCX.Paragraphs, + comparisonExceptionTitle, "legacy synthetic Title duplicated the first canonical heading")) + } else { + receipt.Dimensions = append(receipt.Dimensions, compareExactDimension("visible-text", legacyParagraphs, sharedDOCX.Paragraphs, "")) + } + } else { + receipt.Dimensions = append(receipt.Dimensions, compareExactDimension("visible-text", legacyParagraphs, sharedDOCX.Paragraphs, "")) + } + + if equalJSON(legacyDOCX.PageSize, sharedDOCX.PageSize) { + receipt.Dimensions = append(receipt.Dimensions, compareExactDimension("page-size", legacyDOCX.PageSize, sharedDOCX.PageSize, "")) + } else { + receipt.Dimensions = append(receipt.Dimensions, ComparisonDimension{Name: "page-size", Status: "accidental", LegacyHash: digestJSON(legacyDOCX.PageSize), SharedHash: digestJSON(sharedDOCX.PageSize), Detail: "page size changed"}) + } + if equalJSON(legacyDOCX.Margins, sharedDOCX.Margins) { + receipt.Dimensions = append(receipt.Dimensions, compareExactDimension("page-margins", legacyDOCX.Margins, sharedDOCX.Margins, "")) + } else { + receipt.Dimensions = append(receipt.Dimensions, intentionalDimension("page-margins", legacyDOCX.Margins, sharedDOCX.Margins, + comparisonExceptionCorporate, "organization-default candidate owns page margins")) + } + if legacyDOCX.Headers == sharedDOCX.Headers && legacyDOCX.Footers == sharedDOCX.Footers { + receipt.Dimensions = append(receipt.Dimensions, compareExactDimension("header-footer", []int{legacyDOCX.Headers, legacyDOCX.Footers}, []int{sharedDOCX.Headers, sharedDOCX.Footers}, "")) + } else { + receipt.Dimensions = append(receipt.Dimensions, intentionalDimension("header-footer", []int{legacyDOCX.Headers, legacyDOCX.Footers}, []int{sharedDOCX.Headers, sharedDOCX.Footers}, + comparisonExceptionCorporate, "organization-default candidate adds reviewed header/footer rules")) + } + if legacyDOCX.Bookmarks == sharedDOCX.Bookmarks { + receipt.Dimensions = append(receipt.Dimensions, compareExactDimension("node-bookmarks", legacyDOCX.Bookmarks, sharedDOCX.Bookmarks, "")) + } else if legacyDOCX.Bookmarks == 0 && sharedDOCX.Bookmarks > 0 { + receipt.Dimensions = append(receipt.Dimensions, intentionalDimension("node-bookmarks", legacyDOCX.Bookmarks, sharedDOCX.Bookmarks, + comparisonExceptionAnchors, "shared output anchors canonical node IDs")) + } else { + receipt.Dimensions = append(receipt.Dimensions, compareExactDimension("node-bookmarks", legacyDOCX.Bookmarks, sharedDOCX.Bookmarks, "")) + } + if legacyDOCX.ExternalLinks == sharedDOCX.ExternalLinks { + receipt.Dimensions = append(receipt.Dimensions, compareExactDimension("safe-links", legacyDOCX.ExternalLinks, sharedDOCX.ExternalLinks, "")) + } else if legacyDOCX.ExternalLinks > 0 && sharedDOCX.ExternalLinks == 0 { + receipt.Dimensions = append(receipt.Dimensions, intentionalDimension("safe-links", legacyDOCX.ExternalLinks, sharedDOCX.ExternalLinks, + comparisonExceptionSafeLinks, "shared links are inert labels with no external relationship or target leakage")) + } else { + receipt.Dimensions = append(receipt.Dimensions, compareExactDimension("safe-links", legacyDOCX.ExternalLinks, sharedDOCX.ExternalLinks, "")) + } + receipt.Dimensions = append(receipt.Dimensions, + compareExactDimension("security-objects", legacyDOCX.ForbiddenObject, sharedDOCX.ForbiddenObject, ""), + compareExactDimension("word-semantics", legacyDOCX.Semantics, sharedDOCX.Semantics, ""), + ) + return finishComparison(receipt) +} + +func finishComparison(receipt ComparisonReceipt) ComparisonReceipt { + for _, dimension := range receipt.Dimensions { + switch dimension.Status { + case "intentional": + receipt.IntentionalDifferences = append(receipt.IntentionalDifferences, dimension.Name+": "+dimension.Detail) + case "accidental": + receipt.AccidentalDifferences = append(receipt.AccidentalDifferences, dimension.Name+": "+dimension.Detail) + case "unassessed": + receipt.Unassessed = append(receipt.Unassessed, dimension.Name+": "+dimension.Detail) + } + } + switch { + case len(receipt.Unassessed) > 0: + receipt.Assessment = "unassessed" + case len(receipt.AccidentalDifferences) > 0: + receipt.Assessment = "differences" + default: + receipt.Assessment = "assessed" + } + return receipt +} + +func compareExactDimension(name string, legacy, shared any, detail string) ComparisonDimension { + status := "match" + if !equalJSON(legacy, shared) { + status = "accidental" + if detail == "" { + detail = "normalized values differ" + } + } + return ComparisonDimension{Name: name, Status: status, LegacyHash: digestJSON(legacy), SharedHash: digestJSON(shared), Detail: detail} +} + +func intentionalDimension(name string, legacy, shared any, exceptionID, detail string) ComparisonDimension { + return ComparisonDimension{Name: name, Status: "intentional", LegacyHash: digestJSON(legacy), SharedHash: digestJSON(shared), ExceptionID: exceptionID, Detail: detail} +} + +func legacyComparisonStructure(source string) []comparisonBlock { + document := parseMarkdown(source) + blocks := make([]comparisonBlock, 0, len(document.blocks)) + for _, block := range document.blocks { + entry := comparisonBlock{Level: block.level} + switch block.kind { + case bHeading: + entry.Kind, entry.Text = "heading", []string{visibleLegacyRuns(document.parseInline(strings.Join(block.lines, "\n")))} + case bPara: + entry.Kind, entry.Text = "paragraph", []string{visibleLegacyRuns(document.parseInline(strings.Join(block.lines, "\n")))} + case bQuote: + entry.Kind, entry.Text = "quote", []string{normalizeComparisonText(strings.Join(block.lines, "\n"))} + case bCode: + entry.Kind, entry.Text = "code-block", []string{strings.Join(block.lines, "\n") + "\n"} + case bList: + entry.Kind = "list" + for _, item := range block.items { + entry.Text = append(entry.Text, visibleLegacyRuns(document.parseInline(item.text))) + } + case bTable: + entry.Kind = "table" + for _, row := range block.rows { + visible := make([]string, len(row)) + for index := range row { + visible[index] = visibleLegacyRuns(document.parseInline(row[index])) + } + entry.Rows = append(entry.Rows, visible) + } + case bHR: + entry.Kind = "thematic-break" + } + blocks = append(blocks, entry) + } + return blocks +} + +func canonicalComparisonStructure(document model.CanonicalDocument) []comparisonBlock { + blocks := make([]comparisonBlock, 0, len(document.Root.Children)) + for _, node := range document.Root.Children { + entry := comparisonBlock{Kind: string(node.Kind)} + if node.Kind == model.NodeHeading { + fmt.Sscanf(node.Semantic, "heading%d", &entry.Level) + } + switch node.Kind { + case model.NodeHeading, model.NodeParagraph, model.NodeQuote, model.NodeCodeBlock, model.NodeCallout: + entry.Text = []string{normalizeComparisonNodeText(node)} + case model.NodeList: + for _, item := range node.Children { + entry.Text = append(entry.Text, normalizeComparisonNodeText(item)) + } + case model.NodeTable: + for _, row := range node.Children { + values := make([]string, len(row.Children)) + for index := range row.Children { + values[index] = normalizeComparisonNodeText(row.Children[index]) + } + entry.Rows = append(entry.Rows, values) + } + default: + continue + } + blocks = append(blocks, entry) + } + return blocks +} + +func normalizeComparisonNodeText(node model.Node) string { + if node.Kind == model.NodeCodeBlock { + return node.Text + } + return normalizeComparisonText(node.Text) +} + +func visibleLegacyRuns(runs []run) string { + var value strings.Builder + for _, run := range runs { + value.WriteString(run.text) + } + return normalizeComparisonText(value.String()) +} + +func normalizeComparisonText(value string) string { return strings.Join(strings.Fields(value), " ") } + +func inspectComparisonDOCX(raw []byte) (docxComparison, error) { + reader, err := zip.NewReader(bytes.NewReader(raw), int64(len(raw))) + if err != nil { + return docxComparison{}, err + } + parts := make(map[string][]byte, len(reader.File)) + for _, file := range reader.File { + stream, err := file.Open() + if err != nil { + return docxComparison{}, err + } + content, err := io.ReadAll(stream) + stream.Close() + if err != nil { + return docxComparison{}, err + } + parts[file.Name] = content + } + document, found := parts["word/document.xml"] + if !found { + return docxComparison{}, errors.New("word/document.xml missing") + } + result := docxComparison{PageSize: map[string]string{}, Margins: map[string]string{}, Semantics: map[string]bool{}} + decoder := xml.NewDecoder(bytes.NewReader(document)) + var paragraph strings.Builder + for { + token, err := decoder.Token() + if errors.Is(err, io.EOF) { + break + } + if err != nil { + return docxComparison{}, err + } + switch value := token.(type) { + case xml.StartElement: + switch value.Name.Local { + case "pgSz": + copyAttributes(result.PageSize, value.Attr, "w", "h", "orient") + case "pgMar": + copyAttributes(result.Margins, value.Attr, "top", "right", "bottom", "left", "header", "footer", "gutter") + case "bookmarkStart": + result.Bookmarks++ + } + case xml.CharData: + paragraph.Write(value) + case xml.EndElement: + if value.Name.Local == "p" { + if text := normalizeComparisonText(paragraph.String()); text != "" { + result.Paragraphs = append(result.Paragraphs, text) + } + paragraph.Reset() + } + } + } + for name, content := range parts { + lower := strings.ToLower(name) + if strings.HasPrefix(lower, "word/header") && strings.HasSuffix(lower, ".xml") { + result.Headers++ + } + if strings.HasPrefix(lower, "word/footer") && strings.HasSuffix(lower, ".xml") { + result.Footers++ + } + if strings.HasSuffix(lower, ".rels") { + result.ExternalLinks += strings.Count(strings.ToLower(string(content)), `targetmode="external"`) + } + if strings.Contains(lower, "vba") || strings.Contains(lower, "activex") || strings.Contains(lower, "embeddings") { + result.ForbiddenObject = true + } + } + xmlText := string(document) + result.Semantics = map[string]bool{ + "bold": strings.Contains(xmlText, ""), "table": strings.Contains(xmlText, ""), + } + return result, nil +} + +func copyAttributes(target map[string]string, attributes []xml.Attr, names ...string) { + wanted := make(map[string]bool, len(names)) + for _, name := range names { + wanted[name] = true + } + for _, attribute := range attributes { + if wanted[attribute.Name.Local] { + target[attribute.Name.Local] = attribute.Value + } + } +} + +func equalJSON(left, right any) bool { return bytes.Equal(canonicalJSON(left), canonicalJSON(right)) } + +func digestJSON(value any) string { return digestBytes(canonicalJSON(value)) } + +func canonicalJSON(value any) []byte { + raw, _ := json.Marshal(value) + return raw +} + +func digestBytes(value []byte) string { + sum := sha256.Sum256(value) + return hex.EncodeToString(sum[:]) +} diff --git a/internal/docgen/internal/genrendereridentity/main.go b/internal/docgen/internal/genrendereridentity/main.go new file mode 100644 index 0000000..adb60ea --- /dev/null +++ b/internal/docgen/internal/genrendereridentity/main.go @@ -0,0 +1,39 @@ +package main + +import ( + "bytes" + "flag" + "fmt" + "os" + "os/exec" + "path/filepath" + "strings" +) + +func main() { + check := flag.Bool("check", false, "fail when the generated identity differs from the checked-out renderer") + flag.Parse() + repository := gitOutput("rev-parse", "--show-toplevel") + revision := gitOutput("-C", filepath.Join(repository, "deps", "agent-document-renderer"), "rev-parse", "HEAD") + content := []byte(fmt.Sprintf("// Code generated from deps/agent-document-renderer; DO NOT EDIT.\n\npackage docgen\n\nconst rendererRevision = %q\n\nconst RendererIdentity = \"agent-document-renderer@\" + rendererRevision\n", revision)) + target := filepath.Join(repository, "internal", "docgen", "renderer_identity_generated.go") + if *check { + current, err := os.ReadFile(target) + if err != nil || !bytes.Equal(current, content) { + fmt.Fprintf(os.Stderr, "renderer identity is stale for %s\n", revision) + os.Exit(1) + } + return + } + if err := os.WriteFile(target, content, 0o644); err != nil { + panic(err) + } +} + +func gitOutput(arguments ...string) string { + output, err := exec.Command("git", arguments...).Output() + if err != nil { + panic(err) + } + return strings.TrimSpace(string(output)) +} diff --git a/internal/docgen/operation.go b/internal/docgen/operation.go new file mode 100644 index 0000000..d14ec71 --- /dev/null +++ b/internal/docgen/operation.go @@ -0,0 +1,40 @@ +package docgen + +import ( + "time" + + "agent-document-renderer/render" +) + +type OperationRequest struct { + OperationID string `json:"operationId"` + DocumentID string `json:"documentId"` + Title string `json:"name"` + DocumentType string `json:"documentType,omitempty"` + Language string `json:"language,omitempty"` + Markdown []byte `json:"-"` + Mode render.Mode `json:"mode"` + Controlled bool `json:"controlled"` + ProjectDocument bool `json:"projectDocument"` +} + +type ReceiptArtifact struct { + Role string `json:"role"` + ID string `json:"id"` + Name string `json:"name"` + MIME string `json:"mime"` + Size int64 `json:"size"` + SHA256 string `json:"sha256"` +} + +type OperationReceipt struct { + OperationID string `json:"operationId"` + Outcome string `json:"outcome"` + State string `json:"state"` + FrozenAt time.Time `json:"frozenAt"` + DeliveryKey string `json:"deliveryKey,omitempty"` + Renderer string `json:"rendererIdentity"` + CacheHit bool `json:"cacheHit,omitempty"` + Artifacts []ReceiptArtifact `json:"artifacts,omitempty"` + Error string `json:"error,omitempty"` +} diff --git a/internal/docgen/renderer.go b/internal/docgen/renderer.go index 2304040..457d768 100644 --- a/internal/docgen/renderer.go +++ b/internal/docgen/renderer.go @@ -24,10 +24,14 @@ import ( const ( WorkspaceProjectID = "workspace" ManifestSchemaVersion = "backend-document-delivery/v1" - RendererIdentity = "agent-document-renderer@d449b9f779f2f968f8ac556b89940a6c9aaf3fdc" AdapterIdentity = RendererIdentity + "/word-adapter-v1" + defaultProfileID = "company.default" + defaultProfileVersion = "1.0.0" + defaultRenderCapacity = 4 ) +var renderCapacity = make(chan struct{}, defaultRenderCapacity) + var ( ErrRDMRequired = errors.New("docgen: controlled or project document requires RDM") ErrProfileMismatch = errors.New("docgen: organization-default profile mismatch") @@ -42,20 +46,20 @@ type Artifact struct { } type Request struct { - DocumentID string - Title string - DocumentType string - Language string - Markdown []byte - Mode render.Mode - FrozenAt time.Time - RequestedBy string - ProfileID string - ProfileVersion string - Controlled bool - ProjectDocument bool - LegacyComparison bool - Limits Limits + DocumentID string + Title string + DocumentType string + Language string + Markdown []byte + Mode render.Mode + FrozenAt time.Time + RequestedBy string + ProfileID string + ProfileVersion string + Controlled bool + ProjectDocument bool + LegacySource []byte + Limits Limits } type Limits struct { @@ -85,12 +89,28 @@ func (failure *DiagnosticError) Unwrap() error { return failure.Err } +type ComparisonDimension struct { + Name string `json:"name"` + Status string `json:"status"` + LegacyHash string `json:"legacyHash,omitempty"` + SharedHash string `json:"sharedHash,omitempty"` + ExceptionID string `json:"exceptionId,omitempty"` + Detail string `json:"detail,omitempty"` +} + type ComparisonReceipt struct { - Enabled bool `json:"enabled"` - LegacySHA256 string `json:"legacySha256,omitempty"` - SharedSHA256 string `json:"sharedSha256,omitempty"` - IntentionalDifferences []string `json:"intentionalDifferences,omitempty"` - AccidentalDifferences []string `json:"accidentalDifferences,omitempty"` + Enabled bool `json:"enabled"` + Assessment string `json:"assessment,omitempty"` + LegacySHA256 string `json:"legacySha256,omitempty"` + SharedSHA256 string `json:"sharedSha256,omitempty"` + Dimensions []ComparisonDimension `json:"dimensions,omitempty"` + IntentionalDifferences []string `json:"intentionalDifferences,omitempty"` + AccidentalDifferences []string `json:"accidentalDifferences,omitempty"` + Unassessed []string `json:"unassessed,omitempty"` +} + +type RenderOptions struct { + MigrationComparison bool } type ManifestArtifact struct { @@ -130,6 +150,7 @@ type Manifest struct { type Delivery struct { Document model.CanonicalDocument Profile ProfileReceipt + Renderer render.Manifest Markdown Artifact DOCX Artifact Manifest Artifact @@ -137,15 +158,87 @@ type Delivery struct { Comparison ComparisonReceipt } +type PreparedDocument struct { + Document model.CanonicalDocument + Markdown Artifact + CanonicalHash string +} + +// Prepare canonicalizes and validates authoritative Markdown without loading a +// profile or invoking the Word adapter. Durable callers persist its Markdown +// artifact before any rendering work. +func Prepare(ctx context.Context, request Request) (PreparedDocument, error) { + if err := contextErr(ctx); err != nil { + return PreparedDocument{}, err + } + if request.Controlled || request.ProjectDocument || request.Mode == render.ModeReview || request.Mode == render.ModeApproved { + return PreparedDocument{}, ErrRDMRequired + } + if request.Mode != render.ModeWorking && request.Mode != render.ModePreview { + return PreparedDocument{}, fmt.Errorf("docgen: unsupported ordinary workspace mode %q", request.Mode) + } + limits, err := normalizeLimits(request.Limits) + if err != nil { + return PreparedDocument{}, err + } + if len(request.Markdown) > limits.MaxMarkdownBytes { + return PreparedDocument{}, fmt.Errorf("%w: Markdown is %d bytes, limit is %d", ErrResourceLimit, len(request.Markdown), limits.MaxMarkdownBytes) + } + materialized := bytes.HasPrefix(bytes.TrimSpace(request.Markdown), []byte("---")) + var parsed markdownrenderer.Result + if materialized { + parsed, err = parseMarkdownContext(ctx, request.Markdown, false, limits) + if err != nil { + return PreparedDocument{}, classifyParseError(err) + } + if err := validateWorkspaceRoute(request, parsed.Metadata); err != nil { + return PreparedDocument{}, err + } + if parsed.Metadata.ProfileID != defaultProfileID || parsed.Metadata.ProfileVersion != defaultProfileVersion { + return PreparedDocument{}, fmt.Errorf("%w: Markdown binds %s@%s, expected %s@%s", ErrProfileMismatch, + parsed.Metadata.ProfileID, parsed.Metadata.ProfileVersion, defaultProfileID, defaultProfileVersion) + } + } else { + if request.ProfileID != "" || request.ProfileVersion != "" { + if request.ProfileID != defaultProfileID || request.ProfileVersion != defaultProfileVersion { + return PreparedDocument{}, fmt.Errorf("%w: requested %s@%s, expected %s@%s", ErrProfileMismatch, + request.ProfileID, request.ProfileVersion, defaultProfileID, defaultProfileVersion) + } + } + source, err := workspaceMarkdown(request, defaultProfileID, defaultProfileVersion) + if err != nil { + return PreparedDocument{}, err + } + if len(source) > limits.MaxMarkdownBytes { + return PreparedDocument{}, fmt.Errorf("%w: normalized Markdown source is %d bytes, limit is %d", ErrResourceLimit, len(source), limits.MaxMarkdownBytes) + } + parsed, err = parseMarkdownContext(ctx, source, true, limits) + if err != nil { + return PreparedDocument{}, classifyParseError(err) + } + } + if len(parsed.Markdown) > limits.MaxMarkdownBytes { + return PreparedDocument{}, fmt.Errorf("%w: materialized Markdown is %d bytes, limit is %d", ErrResourceLimit, len(parsed.Markdown), limits.MaxMarkdownBytes) + } + canonicalHash, err := parsed.Document.HashContext(ctx) + if err != nil { + return PreparedDocument{}, err + } + return PreparedDocument{ + Document: parsed.Document, CanonicalHash: canonicalHash, + Markdown: artifact(safeBaseName(request.Title)+".md", "text/markdown; charset=utf-8", parsed.Markdown), + }, nil +} + type generatorDependencies struct { - loadDefault func() (profiles.Bundle, error) + loadDefault func(context.Context) (profiles.Bundle, error) newRenderer func(*profile.AssetReader) render.Renderer legacyBuild func(string, string) ([]byte, error) } func defaultGeneratorDependencies() generatorDependencies { return generatorDependencies{ - loadDefault: profiles.LoadCompanyDefault, + loadDefault: profiles.LoadCompanyDefaultContext, newRenderer: func(assets *profile.AssetReader) render.Renderer { return word.NewAdapter(assets) }, legacyBuild: legacyBuild, } @@ -156,6 +249,14 @@ func Generate(ctx context.Context, request Request) (Delivery, error) { } func generate(ctx context.Context, request Request, dependencies generatorDependencies) (Delivery, error) { + return generateWithOptions(ctx, request, RenderOptions{}, dependencies) +} + +func GenerateWithOptions(ctx context.Context, request Request, options RenderOptions) (Delivery, error) { + return generateWithOptions(ctx, request, options, defaultGeneratorDependencies()) +} + +func generateWithOptions(ctx context.Context, request Request, options RenderOptions, dependencies generatorDependencies) (Delivery, error) { if err := contextErr(ctx); err != nil { return Delivery{}, err } @@ -172,7 +273,18 @@ func generate(ctx context.Context, request Request, dependencies generatorDepend if len(request.Markdown) > limits.MaxMarkdownBytes { return Delivery{}, fmt.Errorf("%w: Markdown is %d bytes, limit is %d", ErrResourceLimit, len(request.Markdown), limits.MaxMarkdownBytes) } - bundle, err := dependencies.loadDefault() + var parsed markdownrenderer.Result + materialized := bytes.HasPrefix(bytes.TrimSpace(request.Markdown), []byte("---")) + if materialized { + parsed, err = parseMarkdownContext(ctx, request.Markdown, false, limits) + if err != nil { + return Delivery{}, classifyParseError(err) + } + if err := validateWorkspaceRoute(request, parsed.Metadata); err != nil { + return Delivery{}, err + } + } + bundle, err := dependencies.loadDefault(ctx) if err != nil { return Delivery{}, fmt.Errorf("docgen: load company default: %w", err) } @@ -183,30 +295,21 @@ func generate(ctx context.Context, request Request, dependencies generatorDepend request.ProfileID, request.ProfileVersion, profileID, profileVersion) } } - source, firstImport, err := workspaceMarkdown(request, profileID, profileVersion) - if err != nil { - return Delivery{}, err + if !materialized { + source, sourceErr := workspaceMarkdown(request, profileID, profileVersion) + if sourceErr != nil { + return Delivery{}, sourceErr + } + if len(source) > limits.MaxMarkdownBytes { + return Delivery{}, fmt.Errorf("%w: normalized Markdown source is %d bytes, limit is %d", ErrResourceLimit, len(source), limits.MaxMarkdownBytes) + } + parsed, err = parseMarkdownContext(ctx, source, true, limits) + if err != nil { + return Delivery{}, classifyParseError(err) + } } - parsed, err := markdownrenderer.Parse(source, markdownrenderer.Options{ - Controlled: true, FirstImport: firstImport, MaxBytes: limits.MaxMarkdownBytes + 64<<10, - MaxNodes: limits.MaxNodes, MaxDepth: limits.MaxDepth, - }) - if err != nil { - if errors.Is(err, markdownrenderer.ErrDocumentLimit) { - return Delivery{}, fmt.Errorf("%w: %v", ErrResourceLimit, err) - } - code := "markdown_invalid" - switch { - case errors.Is(err, markdownrenderer.ErrUnknownMetadata): - code = "unknown_metadata" - case errors.Is(err, markdownrenderer.ErrHiddenHTML): - code = "unsafe_markdown" - case errors.Is(err, markdownrenderer.ErrUnsafeDirective) && strings.Contains(err.Error(), "unknown directive"): - code = "unknown_directive" - case errors.Is(err, markdownrenderer.ErrUnsafeDirective): - code = "unsafe_markdown" - } - return Delivery{}, diagnosticFailure("parse", code, err, nil) + if len(parsed.Markdown) > limits.MaxMarkdownBytes { + return Delivery{}, fmt.Errorf("%w: materialized Markdown is %d bytes, limit is %d", ErrResourceLimit, len(parsed.Markdown), limits.MaxMarkdownBytes) } if err := validateWorkspaceMetadata(request, parsed.Metadata, profileID, profileVersion); err != nil { return Delivery{}, err @@ -214,13 +317,17 @@ func generate(ctx context.Context, request Request, dependencies generatorDepend if err := contextErr(ctx); err != nil { return Delivery{}, err } - result, err := renderWithContext(ctx, dependencies.newRenderer(bundle.Assets), render.Request{ + if err := acquireRenderCapacity(ctx); err != nil { + return Delivery{}, err + } + result, err := dependencies.newRenderer(bundle.Assets).Render(ctx, render.Request{ Document: parsed.Document, Profile: bundle.Snapshot, Mode: request.Mode, FrozenAt: request.FrozenAt, RequestedBy: request.RequestedBy, }) + releaseRenderCapacity() if err != nil { code := "renderer_failed" if strings.Contains(err.Error(), "asset") || strings.Contains(err.Error(), "hash") { @@ -230,7 +337,7 @@ func generate(ctx context.Context, request Request, dependencies generatorDepend } base := safeBaseName(request.Title) delivery := Delivery{ - Document: parsed.Document, + Document: parsed.Document, Renderer: result.Manifest, Profile: ProfileReceipt{ ProfileID: profileID, Version: profileVersion, SnapshotHash: bundle.Snapshot.SnapshotHash(), Candidate: true, ReviewStatus: bundle.Review.Status, PublicationAllowed: bundle.Review.PublicationAllowed, @@ -240,26 +347,22 @@ func generate(ctx context.Context, request Request, dependencies generatorDepend Markdown: artifact(base+".md", "text/markdown; charset=utf-8", parsed.Markdown), DOCX: artifact(base+".docx", result.MIME, result.Artifact), } - if request.LegacyComparison { - legacy, err := dependencies.legacyBuild(request.Title, string(request.Markdown)) + if options.MigrationComparison { + comparisonSource := request.LegacySource + if len(comparisonSource) == 0 { + comparisonSource = request.Markdown + } + legacy, err := dependencies.legacyBuild(request.Title, string(comparisonSource)) if err != nil { return Delivery{}, fmt.Errorf("docgen: legacy migration comparison: %w", err) } - legacySum := sha256.Sum256(legacy) - delivery.Comparison = ComparisonReceipt{ - Enabled: true, LegacySHA256: hex.EncodeToString(legacySum[:]), SharedSHA256: delivery.DOCX.SHA256, - IntentionalDifferences: []string{ - "shared output removes the legacy duplicate title paragraph", - "shared output adds stable node bookmarks and deterministic package metadata", - "shared output uses the pending organization-default candidate page and footer rules", - }, - } + delivery.Comparison = compareLegacyAndShared(request.Title, comparisonSource, parsed.Document, legacy, delivery.DOCX.Bytes) } manifest := Manifest{ SchemaVersion: ManifestSchemaVersion, RendererIdentity: RendererIdentity, AdapterIdentity: AdapterIdentity, SelectionSource: "organization-default", - Profile: delivery.Profile, - DocumentRootID: parsed.Document.Root.ID, + Profile: delivery.Profile, + DocumentRootID: parsed.Document.Root.ID, Artifacts: []ManifestArtifact{ manifestArtifact(delivery.Markdown), manifestArtifact(delivery.DOCX), }, @@ -280,25 +383,42 @@ func generate(ctx context.Context, request Request, dependencies generatorDepend return delivery, nil } -type renderOutcome struct { - result render.Result - err error -} - -func renderWithContext(ctx context.Context, renderer render.Renderer, request render.Request) (render.Result, error) { - outcomes := make(chan renderOutcome, 1) - go func() { - result, err := renderer.Render(ctx, request) - outcomes <- renderOutcome{result: result, err: err} - }() +func acquireRenderCapacity(ctx context.Context) error { select { case <-ctx.Done(): - return render.Result{}, ctx.Err() - case outcome := <-outcomes: - return outcome.result, outcome.err + return ctx.Err() + case renderCapacity <- struct{}{}: + return nil } } +func releaseRenderCapacity() { <-renderCapacity } + +func parseMarkdownContext(ctx context.Context, source []byte, firstImport bool, limits Limits) (markdownrenderer.Result, error) { + return markdownrenderer.ParseContext(ctx, source, markdownrenderer.Options{ + Controlled: true, FirstImport: firstImport, MaxBytes: limits.MaxMarkdownBytes, + MaxNodes: limits.MaxNodes, MaxDepth: limits.MaxDepth, + }) +} + +func classifyParseError(err error) error { + if errors.Is(err, markdownrenderer.ErrDocumentLimit) { + return fmt.Errorf("%w: %v", ErrResourceLimit, err) + } + code := "markdown_invalid" + switch { + case errors.Is(err, markdownrenderer.ErrUnknownMetadata): + code = "unknown_metadata" + case errors.Is(err, markdownrenderer.ErrHiddenHTML): + code = "unsafe_markdown" + case errors.Is(err, markdownrenderer.ErrUnsafeDirective) && strings.Contains(err.Error(), "unknown directive"): + code = "unknown_directive" + case errors.Is(err, markdownrenderer.ErrUnsafeDirective): + code = "unsafe_markdown" + } + return diagnosticFailure("parse", code, err, nil) +} + func diagnosticFailure(stage, code string, err error, diagnostics []render.Diagnostic) error { cloned := append([]render.Diagnostic(nil), diagnostics...) if len(cloned) == 0 { @@ -323,16 +443,13 @@ func normalizeLimits(input Limits) (Limits, error) { return input, nil } -func workspaceMarkdown(request Request, profileID, profileVersion string) ([]byte, bool, error) { +func workspaceMarkdown(request Request, profileID, profileVersion string) ([]byte, error) { if strings.TrimSpace(request.DocumentID) == "" || strings.TrimSpace(request.Title) == "" || strings.TrimSpace(request.DocumentType) == "" || strings.TrimSpace(request.Language) == "" { - return nil, false, errors.New("docgen: document ID, title, document type, and language are required") + return nil, errors.New("docgen: document ID, title, document type, and language are required") } if request.Mode == "" || request.FrozenAt.IsZero() || strings.TrimSpace(request.RequestedBy) == "" { - return nil, false, errors.New("docgen: mode, frozen time, and requester are required") - } - if bytes.HasPrefix(bytes.TrimSpace(request.Markdown), []byte("---")) { - return bytes.Clone(request.Markdown), false, nil + return nil, errors.New("docgen: mode, frozen time, and requester are required") } quote := func(value string) string { raw, _ := json.Marshal(value) @@ -350,17 +467,13 @@ func workspaceMarkdown(request Request, profileID, profileVersion string) ([]byt header.WriteString("controlled: false\n---\n\n") header.Write(bytes.TrimSpace(request.Markdown)) header.WriteByte('\n') - return []byte(header.String()), true, nil + return []byte(header.String()), nil } -func validateWorkspaceMetadata(request Request, metadata markdownrenderer.Metadata, profileID, profileVersion string) error { +func validateWorkspaceRoute(request Request, metadata markdownrenderer.Metadata) error { if metadata.Controlled || metadata.ProjectID != WorkspaceProjectID { return ErrRDMRequired } - if metadata.ProfileID != profileID || metadata.ProfileVersion != profileVersion { - return fmt.Errorf("%w: Markdown binds %s@%s, available %s@%s", ErrProfileMismatch, - metadata.ProfileID, metadata.ProfileVersion, profileID, profileVersion) - } if metadata.DocumentID != request.DocumentID || metadata.DocumentType != request.DocumentType || metadata.Title != request.Title || metadata.Language != request.Language { return errors.New("docgen: persisted Markdown metadata does not match the frozen request") @@ -368,6 +481,17 @@ func validateWorkspaceMetadata(request Request, metadata markdownrenderer.Metada return nil } +func validateWorkspaceMetadata(request Request, metadata markdownrenderer.Metadata, profileID, profileVersion string) error { + if err := validateWorkspaceRoute(request, metadata); err != nil { + return err + } + if metadata.ProfileID != profileID || metadata.ProfileVersion != profileVersion { + return fmt.Errorf("%w: Markdown binds %s@%s, available %s@%s", ErrProfileMismatch, + metadata.ProfileID, metadata.ProfileVersion, profileID, profileVersion) + } + return nil +} + func artifact(name, mime string, raw []byte) Artifact { sum := sha256.Sum256(raw) // Callers transfer ownership of freshly produced buffers to the delivery. diff --git a/internal/docgen/renderer_identity.go b/internal/docgen/renderer_identity.go new file mode 100644 index 0000000..ef9c483 --- /dev/null +++ b/internal/docgen/renderer_identity.go @@ -0,0 +1,3 @@ +package docgen + +//go:generate go run ./internal/genrendereridentity diff --git a/internal/docgen/renderer_identity_generated.go b/internal/docgen/renderer_identity_generated.go new file mode 100644 index 0000000..f997072 --- /dev/null +++ b/internal/docgen/renderer_identity_generated.go @@ -0,0 +1,7 @@ +// Code generated from deps/agent-document-renderer; DO NOT EDIT. + +package docgen + +const rendererRevision = "d5cd8c126045a27d5a5cc5da23f64d3c737e116a" + +const RendererIdentity = "agent-document-renderer@" + rendererRevision diff --git a/internal/docgen/renderer_integration_test.go b/internal/docgen/renderer_integration_test.go index c3cacdc..ca670cb 100644 --- a/internal/docgen/renderer_integration_test.go +++ b/internal/docgen/renderer_integration_test.go @@ -8,14 +8,18 @@ import ( "encoding/xml" "errors" "io" + "os/exec" + "path/filepath" "reflect" "strings" + "sync/atomic" "testing" "time" markdownrenderer "agent-document-renderer/markdown" "agent-document-renderer/model" "agent-document-renderer/profile" + "agent-document-renderer/profiles" "agent-document-renderer/render" ) @@ -56,6 +60,23 @@ func workspaceRequest(markdown []byte) Request { } } +const semanticMarkdown = `# **Semantic** report + +Paragraph with **bold**, *italic*, ~~strike~~, ` + "`inline code`" + `, and [safe **label**](https://example.com/private-target). + +> Quoted **evidence** with *emphasis*. + +` + "```go" + ` +fmt.Println("safe") +` + "```" + ` + +- **bold item** + +| Item | Meaning | +|---|---| +| ` + "`code cell`" + ` | [table label](#semantic) | +` + func TestGenerateProducesDeterministicHashedDeliveryPackage(t *testing.T) { request := workspaceRequest([]byte(representativeMarkdown)) first, err := Generate(context.Background(), request) @@ -186,6 +207,125 @@ func TestGeneratePersistsCanonicalMarkdownWithStableNodeParity(t *testing.T) { } } +func TestGeneratePreservesAllSharedSemanticMarkdownWithoutLinkTargetLeak(t *testing.T) { + request := workspaceRequest([]byte(semanticMarkdown)) + request.Title = "Semantic report" + delivery, err := Generate(context.Background(), request) + if err != nil { + t.Fatal(err) + } + var quote, code *model.Node + var hasStrong, hasEmphasis, hasStrike, hasInlineCode, hasLink bool + var walkInline func([]model.Inline) + walkInline = func(inlines []model.Inline) { + for index := range inlines { + switch inlines[index].Kind { + case model.InlineStrong: + hasStrong = true + case model.InlineEmphasis: + hasEmphasis = true + case model.InlineStrike: + hasStrike = true + case model.InlineCode: + hasInlineCode = true + case model.InlineLink: + hasLink = true + } + walkInline(inlines[index].Children) + } + } + var walk func(*model.Node) + walk = func(node *model.Node) { + if node.Kind == model.NodeQuote { + quote = node + } + if node.Kind == model.NodeCodeBlock { + code = node + } + walkInline(node.Inlines) + for index := range node.Children { + walk(&node.Children[index]) + } + } + walk(&delivery.Document.Root) + if quote == nil || code == nil || !hasStrong || !hasEmphasis || !hasStrike || !hasInlineCode || !hasLink { + t.Fatalf("semantic canonical document incomplete: quote=%v code=%v strong=%v emphasis=%v strike=%v inlineCode=%v link=%v", quote != nil, code != nil, hasStrong, hasEmphasis, hasStrike, hasInlineCode, hasLink) + } + documentXML := docxPart(t, delivery.DOCX.Bytes, "word/document.xml") + for _, fragment := range []string{``, ``, ``, `w:val="inlineCode"`, `w:val="link"`, `w:val="quote"`, `w:val="code"`, ``, ``} { + if !strings.Contains(documentXML, fragment) { + t.Errorf("Word output missing %s", fragment) + } + } + if bytes.Contains(delivery.DOCX.Bytes, []byte("https://example.com/private-target")) || strings.Contains(documentXML, "TargetMode=\"External\"") { + t.Fatal("safe link target leaked into DOCX package") + } + replayed := request + replayed.Markdown = delivery.Markdown.Bytes + second, err := Generate(context.Background(), replayed) + if err != nil || !reflect.DeepEqual(delivery.Document, second.Document) { + t.Fatalf("semantic Markdown did not replay canonically: err=%v", err) + } +} + +func TestMaterializedMarkdownMustFitAndReplayAtOneBudget(t *testing.T) { + request := workspaceRequest([]byte("# T\n\nsmall body\n")) + request.Title = "T" + request.Limits.MaxMarkdownBytes = 256 + if delivery, err := Generate(context.Background(), request); !errors.Is(err, ErrResourceLimit) { + t.Fatalf("materialized overflow returned delivery=%d bytes err=%v, want ErrResourceLimit", len(delivery.Markdown.Bytes), err) + } + + request.Limits.MaxMarkdownBytes = 0 + first, err := Generate(context.Background(), request) + if err != nil { + t.Fatal(err) + } + request.Markdown = first.Markdown.Bytes + request.Limits.MaxMarkdownBytes = len(first.Markdown.Bytes) + second, err := Generate(context.Background(), request) + if err != nil || !bytes.Equal(first.Markdown.Bytes, second.Markdown.Bytes) { + t.Fatalf("exact-budget replay failed: err=%v first=%d second=%d", err, len(first.Markdown.Bytes), len(second.Markdown.Bytes)) + } +} + +func TestPersistedControlledMetadataRoutesBeforeDefaultProfileLoad(t *testing.T) { + source := []byte("---\ndocumentId: controlled\nprojectId: workspace\ndocumentType: general\ntitle: Controlled\nlanguage: zh-CN\nprofileId: company.default\nprofileVersion: 1.0.0\ncontrolled: true\n---\n\n\n# Controlled\n") + request := workspaceRequest(source) + request.DocumentID = "controlled" + request.Title = "Controlled" + loads := 0 + deps := defaultGeneratorDependencies() + baseLoad := deps.loadDefault + deps.loadDefault = func(ctx context.Context) (profiles.Bundle, error) { + loads++ + return baseLoad(ctx) + } + _, err := generate(context.Background(), request, deps) + if !errors.Is(err, ErrRDMRequired) || loads != 0 { + t.Fatalf("persisted controlled route err=%v profileLoads=%d, want ErrRDMRequired before load", err, loads) + } +} + +func TestRendererIdentityMatchesPublishedPin(t *testing.T) { + const want = "agent-document-renderer@d5cd8c126045a27d5a5cc5da23f64d3c737e116a" + if RendererIdentity != want { + t.Fatalf("RendererIdentity = %q, want %q", RendererIdentity, want) + } +} + +func TestRendererIdentityIsGeneratedFromCheckedOutComponent(t *testing.T) { + repository, err := filepath.Abs(filepath.Join("..", "..")) + if err != nil { + t.Fatal(err) + } + command := exec.Command("go", "run", "./internal/docgen/internal/genrendereridentity", "-check") + command.Dir = repository + if output, err := command.CombinedOutput(); err != nil { + t.Fatalf("renderer identity generation check: %v\n%s", err, output) + } +} + func TestGenerateReusesPersistedMarkdownWithoutChangingNodeIdentity(t *testing.T) { request := workspaceRequest([]byte(representativeMarkdown)) first, err := Generate(context.Background(), request) @@ -313,28 +453,35 @@ func (renderer failingRenderer) Render(context.Context, render.Request) (render. return render.Result{Diagnostics: []render.Diagnostic{{Code: "forced_failure", Severity: render.SeverityError, Message: renderer.err.Error()}}}, renderer.err } -type blockingRenderer struct { - started chan struct{} - release chan struct{} +type cleanupRenderer struct { + active *atomic.Int32 + started chan struct{} + canceled chan struct{} + release chan struct{} } -func (renderer blockingRenderer) Validate(context.Context, render.Request) ([]render.Diagnostic, error) { +func (renderer cleanupRenderer) Validate(context.Context, render.Request) ([]render.Diagnostic, error) { return nil, nil } -func (renderer blockingRenderer) Render(context.Context, render.Request) (render.Result, error) { +func (renderer cleanupRenderer) Render(ctx context.Context, _ render.Request) (render.Result, error) { + renderer.active.Add(1) + defer renderer.active.Add(-1) close(renderer.started) + <-ctx.Done() + close(renderer.canceled) <-renderer.release - return render.Result{}, nil + return render.Result{}, ctx.Err() } -func TestCancellationDuringRendererReturnsPromptly(t *testing.T) { +func TestCancellationWaitsForRendererUnwindAndRecoversCapacity(t *testing.T) { + var active atomic.Int32 started := make(chan struct{}) + canceled := make(chan struct{}) release := make(chan struct{}) - defer close(release) deps := defaultGeneratorDependencies() deps.newRenderer = func(*profile.AssetReader) render.Renderer { - return blockingRenderer{started: started, release: release} + return cleanupRenderer{active: &active, started: started, canceled: canceled, release: release} } ctx, cancel := context.WithCancel(context.Background()) result := make(chan error, 1) @@ -344,13 +491,20 @@ func TestCancellationDuringRendererReturnsPromptly(t *testing.T) { }() <-started cancel() + <-canceled select { case err := <-result: - if !errors.Is(err, context.Canceled) { - t.Fatalf("cancellation error = %v, want context.Canceled", err) + t.Fatalf("Generate returned before renderer cleanup: %v", err) + default: + } + close(release) + select { + case err := <-result: + if !errors.Is(err, context.Canceled) || active.Load() != 0 { + t.Fatalf("cancellation err=%v active=%d, want canceled and zero capacity", err, active.Load()) } case <-time.After(time.Second): - t.Fatal("Generate did not return after cancellation") + t.Fatal("Generate did not return after renderer cleanup") } } @@ -364,8 +518,7 @@ func TestRendererFailureNeverFallsBackToLegacy(t *testing.T) { return []byte("legacy"), nil } request := workspaceRequest([]byte(representativeMarkdown)) - request.LegacyComparison = true - if _, err := generate(context.Background(), request, deps); !errors.Is(err, forced) { + if _, err := generateWithOptions(context.Background(), request, RenderOptions{MigrationComparison: true}, deps); !errors.Is(err, forced) { t.Fatalf("generate error = %v, want forced renderer failure", err) } if legacyCalls != 0 { @@ -389,12 +542,11 @@ func TestLegacyComparisonIsExplicitAndDoesNotReplaceSharedOutput(t *testing.T) { t.Fatalf("disabled comparison called legacy renderer: calls=%d receipt=%#v", legacyCalls, withoutFlag.Comparison) } - request.LegacyComparison = true - withFlag, err := generate(context.Background(), request, deps) + withFlag, err := generateWithOptions(context.Background(), request, RenderOptions{MigrationComparison: true}, deps) if err != nil { t.Fatal(err) } - if legacyCalls != 1 || !withFlag.Comparison.Enabled || withFlag.Comparison.LegacySHA256 == "" { + if legacyCalls != 1 || !withFlag.Comparison.Enabled || withFlag.Comparison.LegacySHA256 == "" || withFlag.Comparison.Assessment != "unassessed" || len(withFlag.Comparison.Unassessed) == 0 { t.Fatalf("enabled comparison receipt=%#v calls=%d", withFlag.Comparison, legacyCalls) } if !bytes.Equal(withoutFlag.DOCX.Bytes, withFlag.DOCX.Bytes) { @@ -403,35 +555,47 @@ func TestLegacyComparisonIsExplicitAndDoesNotReplaceSharedOutput(t *testing.T) { } func TestRepresentativeLegacyComparisonRecordsOnlyIntentionalDifferences(t *testing.T) { - const common = "# 研发周会纪要\n\n正文结论。\n\n## 要点\n\n- 统一解析入口\n- 保留 Markdown\n\n| 项目 | 状态 |\n|---|---|\n| 解析器 | 统一 |\n" + const common = "# 研发周会纪要\n\n正文有 **粗体**、*斜体*、~~删除~~、`代码` 和 [链接](https://example.com/private)。\n\n> 引用内容。\n\n```go\nfmt.Println(1)\n```\n\n## 要点\n\n- 统一解析入口\n- 保留 Markdown\n\n| 项目 | 状态 |\n|---|---|\n| 解析器 | 统一 |\n" request := workspaceRequest([]byte(common)) - request.LegacyComparison = true - delivery, err := Generate(context.Background(), request) + delivery, err := generateWithOptions(context.Background(), request, RenderOptions{MigrationComparison: true}, defaultGeneratorDependencies()) if err != nil { t.Fatal(err) } - legacy, err := legacyBuild(request.Title, common) - if err != nil { - t.Fatal(err) - } - legacyText := docxVisibleText(t, legacy) - sharedText := docxVisibleText(t, delivery.DOCX.Bytes) - for _, value := range []string{"研发周会纪要", "正文结论。", "要点", "统一解析入口", "保留 Markdown", "项目", "状态", "解析器", "统一"} { - if !strings.Contains(legacyText, value) || !strings.Contains(sharedText, value) { - t.Errorf("representative content %q missing: legacy=%q shared=%q", value, legacyText, sharedText) - } - } - if len(delivery.Comparison.AccidentalDifferences) != 0 { + if delivery.Comparison.Assessment != "assessed" || len(delivery.Comparison.AccidentalDifferences) != 0 || len(delivery.Comparison.Unassessed) != 0 { t.Fatalf("accidental differences remain: %#v", delivery.Comparison.AccidentalDifferences) } - foundTitleDifference := false - for _, difference := range delivery.Comparison.IntentionalDifferences { - if strings.Contains(difference, "duplicate title") { - foundTitleDifference = true + exceptions := map[string]bool{} + for _, dimension := range delivery.Comparison.Dimensions { + if dimension.Status == "intentional" { + exceptions[dimension.ExceptionID] = true } } - if !foundTitleDifference { - t.Fatalf("comparison did not record the legacy duplicate-title correction: %#v", delivery.Comparison.IntentionalDifferences) + for _, id := range []string{"RDR-T10-CMP-001", "RDR-T10-CMP-002", "RDR-T10-CMP-003", "RDR-T10-CMP-004"} { + if !exceptions[id] { + t.Errorf("comparison omitted reviewed exception %s: %#v", id, delivery.Comparison.Dimensions) + } + } +} + +func TestLegacyComparisonReportsAccidentalAndUnassessedDimensions(t *testing.T) { + request := workspaceRequest([]byte("# Expected\n\nExpected body.\n")) + deps := defaultGeneratorDependencies() + deps.legacyBuild = func(title, _ string) ([]byte, error) { return legacyBuild(title, "# Wrong\n\nLost body.\n") } + accidental, err := generateWithOptions(context.Background(), request, RenderOptions{MigrationComparison: true}, deps) + if err != nil { + t.Fatal(err) + } + if accidental.Comparison.Assessment != "differences" || len(accidental.Comparison.AccidentalDifferences) == 0 { + t.Fatalf("content loss was not accidental: %#v", accidental.Comparison) + } + + deps.legacyBuild = func(string, string) ([]byte, error) { return []byte("not a DOCX"), nil } + unassessed, err := generateWithOptions(context.Background(), request, RenderOptions{MigrationComparison: true}, deps) + if err != nil { + t.Fatal(err) + } + if unassessed.Comparison.Assessment != "unassessed" || len(unassessed.Comparison.Unassessed) == 0 { + t.Fatalf("invalid legacy sample was reported as assessed: %#v", unassessed.Comparison) } } @@ -471,3 +635,28 @@ func docxVisibleText(t *testing.T, raw []byte) string { t.Fatal("word/document.xml missing") return "" } + +func docxPart(t *testing.T, raw []byte, name string) string { + t.Helper() + zr, err := zip.NewReader(bytes.NewReader(raw), int64(len(raw))) + if err != nil { + t.Fatal(err) + } + for _, file := range zr.File { + if file.Name != name { + continue + } + stream, err := file.Open() + if err != nil { + t.Fatal(err) + } + content, err := io.ReadAll(stream) + stream.Close() + if err != nil { + t.Fatal(err) + } + return string(content) + } + t.Fatalf("DOCX part %s missing", name) + return "" +} diff --git a/internal/prompts/library/base-deliverables.md b/internal/prompts/library/base-deliverables.md index 2e8356d..25803e3 100644 --- a/internal/prompts/library/base-deliverables.md +++ b/internal/prompts/library/base-deliverables.md @@ -11,7 +11,7 @@ description: 生成文档、表格、演示稿的工作流、样式决策与技 1. **先判路由**：普通、非受控的工作区 Word 可用组织默认候选；项目文档、受控文档、专用模板或审签输出必须交给 RDM，禁止调用 Backend 默认规则回退。组织默认候选的 manifest 状态固定显示 `pending-human-visual-review`，不能描述成已发布或已视觉批准。Excel / PPT / 图片再按用户指令、模板、参考文档、会话样式和默认主题的顺序定样式。 2. **规划版面**：先定读者、结构和每一节的内容，再写脚本。不要边生成边补空节。 -3. **生成 Word**：先用 `time_now` 冻结 `frozenAt`，再调用 `render_document`，传稳定 `documentId`、标题 `name`、Markdown、语言和 `working|preview` 模式，并显式传 `controlled=false`、`projectDocument=false`；任何一项不是 false 就停止并交给 RDM。Markdown 用 `#`-`######` 标题、段落、`-`/`1.` 列表、GFM 表格、`asset:` 图片、`:::callout warning`/`:::` 提示块和 `:::page-break`。工具先保存带稳定 node ID 的 Markdown，再生成确定性 DOCX、manifest 和完整 zip；返回值逐项列出 SHA-256。失败时按诊断修 Markdown，绝不调用 legacy Word 路径回退。 +3. **生成 Word**：调用 `render_document`，传本次交付稳定且重试复用的 `operationId`、稳定 `documentId`、标题 `name`、Markdown、语言和 `working|preview` 模式，并显式传 `controlled=false`、`projectDocument=false`；任何一项不是 false 就停止并交给 RDM。时间与 requester 由宿主冻结，禁止传入或声称自定 `frozenAt`。Markdown 用 `#`-`######` 标题、段落、引用、围栏/行内代码、粗体、斜体、删除线、安全链接标签、`-`/`1.` 列表、GFM 表格、`asset:` 图片、`:::callout warning`/`:::` 提示块和 `:::page-break`。工具先保存带稳定 node ID 的 Markdown，再生成确定性 DOCX、manifest 和完整 zip；返回值逐项列出稳定 ID 与 SHA-256。失败时按回执状态重试同一 operationId，绝不调用 legacy Word 路径回退。 4. **生成其他格式并自检**：Excel/PPT/图片用 `run_python` + house-style 对应 kit；用 lint/outline 回读。Word 的 OPC、安全、锚点与回读校验已经由统一 renderer 执行，复核 manifest 中的诊断、组织默认候选状态和 Markdown/DOCX 哈希。 5. **登记**：`render_document` 已登记 Markdown、DOCX、manifest 和 zip，不要重复登记。其他格式继续用 `register_artifact`。 6. **收尾**：回复只写结论摘要，并说明这次用的样式（主题、是否模板、是否仿制）以及用户还能怎么调。不要在回复里复述全文，也不要只口头说文件名。 diff --git a/internal/prompts/library/tool-render-document.md b/internal/prompts/library/tool-render-document.md index b9e5068..a121dd0 100644 --- a/internal/prompts/library/tool-render-document.md +++ b/internal/prompts/library/tool-render-document.md @@ -5,6 +5,6 @@ version: 1 title: render_document 工具描述 description: 普通工作区 Markdown 到统一 Word 交付包的安全渲染入口 --- -把普通、非受控的工作区 Markdown 交给共享 canonical parser、组织默认候选 profile 和 Word adapter。先用 time_now 取得 frozenAt；必须显式传 `controlled=false` 和 `projectDocument=false`，缺任一字段即拒绝；requester 由系统可信身份填写，不要作为参数伪造。成功会按顺序保存 Markdown、DOCX、manifest 和 zip，并返回每项 SHA-256。 +把普通、非受控的工作区 Markdown 交给共享 canonical parser、组织默认候选 profile 和 Word adapter。必须传稳定且重试复用的 operationId，并显式传 `controlled=false` 和 `projectDocument=false`；缺任一字段即拒绝。frozenAt 与 requester 由宿主首次操作时创建并持久化，调用方不能提交。成功回执包含 Markdown、DOCX、manifest、zip 的稳定 ID 与 SHA-256；失败回执明确 partial 或 unknown，重试必须沿用同一 operationId。 只允许 working 或 preview。项目文档、受控文档、专用模板、审阅稿或批准稿必须交给 RDM；失败不得改走 legacy Word builder。当前公司默认规则状态是 pending-human-visual-review，只可用于普通工作/预览交付，不能称为已发布或已视觉批准。 diff --git a/internal/runmgr/document_delivery.go b/internal/runmgr/document_delivery.go new file mode 100644 index 0000000..1478dec --- /dev/null +++ b/internal/runmgr/document_delivery.go @@ -0,0 +1,174 @@ +package runmgr + +import ( + "context" + "crypto/sha256" + "encoding/hex" + "encoding/json" + "errors" + "strings" + + "agent-system-backend/internal/docgen" + "agent-system-backend/internal/store" + core "agent-system-core" +) + +func (t *toolCtx) ExecuteDocumentDelivery(ctx context.Context, request docgen.OperationRequest) (docgen.OperationReceipt, error) { + receipt, err := t.rc.executeDocumentDelivery(ctx, request) + if receipt.Outcome == "complete" || receipt.Outcome == "unknown" { + for _, artifact := range receipt.Artifacts { + if artifact.Role != string(store.DocumentArtifactArchive) { + continue + } + t.arts = append(t.arts, core.Artifact{ + ID: core.ID(artifact.ID), ProjectID: t.rc.run.ProjectID, Owner: t.rc.run.Owner, + Name: artifact.Name, Kind: "document", MIME: artifact.MIME, Size: artifact.Size, + }) + break + } + } + return receipt, err +} + +func (c *runCtx) executeDocumentDelivery(ctx context.Context, operation docgen.OperationRequest) (docgen.OperationReceipt, error) { + if ctx == nil { + return docgen.OperationReceipt{}, errors.New("document delivery: nil context") + } + if err := c.mgr.authorizeRunWork(ctx, c.run.Owner, c.run.ProjectID); err != nil { + return docgen.OperationReceipt{}, err + } + requestHash, err := documentOperationHash(operation) + if err != nil { + return docgen.OperationReceipt{}, err + } + record, err := c.mgr.st.BeginDocumentDeliveryAccountChecked(c.run.Owner, store.DocumentDeliveryBeginInput{ + OperationID: operation.OperationID, RequestSHA256: requestHash, + ProjectID: string(c.run.ProjectID), ConversationID: string(c.run.ConversationID), SourceRun: string(c.run.ID), + DocumentID: operation.DocumentID, Mode: string(operation.Mode), RendererIdentity: docgen.RendererIdentity, + }, c.mgr.accountAllowImplicitLocal) + if err != nil { + return receiptFromDelivery(record, "partial", false, err), err + } + if record.State == store.DocumentDeliveryComplete { + return receiptFromDelivery(record, "complete", true, nil), nil + } + + request := docgen.Request{ + DocumentID: operation.DocumentID, Title: operation.Title, DocumentType: operation.DocumentType, Language: operation.Language, + Markdown: operation.Markdown, Mode: operation.Mode, FrozenAt: record.FrozenAt, RequestedBy: c.run.Owner, + Controlled: operation.Controlled, ProjectDocument: operation.ProjectDocument, + } + if record.MarkdownArtifactID != "" { + persisted, readErr := c.mgr.st.DocumentDeliveryMarkdown(c.run.Owner, operation.OperationID) + if readErr != nil { + return receiptFromDelivery(record, "unknown", false, readErr), readErr + } + request.Markdown = persisted + } + prepared, err := docgen.Prepare(ctx, request) + if err != nil { + return receiptFromDelivery(record, "partial", false, err), err + } + if record.MarkdownArtifactID == "" { + record, err = c.mgr.st.PersistDocumentDeliveryMarkdownAccountChecked(c.run.Owner, operation.OperationID, + deliveryArtifactInput(store.DocumentArtifactMarkdown, prepared.Markdown), prepared.CanonicalHash, + c.mgr.accountAllowImplicitLocal) + if err != nil { + outcome := "partial" + if errors.Is(err, store.ErrDocumentDeliveryOutcomeUnknown) { + outcome = "unknown" + } + return receiptFromDelivery(record, outcome, false, err), err + } + } + request.LegacySource = append([]byte(nil), operation.Markdown...) + request.Markdown = prepared.Markdown.Bytes + if err := c.mgr.authorizeRunWork(ctx, c.run.Owner, c.run.ProjectID); err != nil { + return receiptFromDelivery(record, "partial", false, err), err + } + delivery, err := docgen.GenerateWithOptions(ctx, request, docgen.RenderOptions{MigrationComparison: c.mgr.documentMigrationComparison}) + if err != nil { + record, markErr := c.mgr.st.MarkDocumentDeliveryFailedAccountChecked(c.run.Owner, operation.OperationID, err.Error(), c.mgr.accountAllowImplicitLocal) + if markErr != nil { + return receiptFromDelivery(record, "unknown", false, markErr), errors.Join(err, markErr) + } + return receiptFromDelivery(record, "partial", false, err), err + } + if err := c.mgr.authorizeRunWork(ctx, c.run.Owner, c.run.ProjectID); err != nil { + return receiptFromDelivery(record, "partial", false, err), err + } + deliveryKey := documentDeliveryKey(delivery) + record, err = c.mgr.st.CommitDocumentDeliveryDerivedAccountChecked(c.run.Owner, operation.OperationID, + deliveryKey, delivery.Profile.SnapshotHash, delivery.Renderer.ReviewHash, + []store.DocumentDeliveryArtifactInput{ + deliveryArtifactInput(store.DocumentArtifactDOCX, delivery.DOCX), + deliveryArtifactInput(store.DocumentArtifactManifest, delivery.Manifest), + deliveryArtifactInput(store.DocumentArtifactArchive, delivery.Archive), + }, c.mgr.accountAllowImplicitLocal) + if err != nil { + outcome := "partial" + if errors.Is(err, store.ErrDocumentDeliveryOutcomeUnknown) { + outcome = "unknown" + } + return receiptFromDelivery(record, outcome, false, err), err + } + return receiptFromDelivery(record, "complete", false, nil), nil +} + +func documentOperationHash(operation docgen.OperationRequest) (string, error) { + payload := struct { + DocumentID string `json:"documentId"` + Title string `json:"title"` + DocumentType string `json:"documentType"` + Language string `json:"language"` + Markdown string `json:"markdown"` + Mode string `json:"mode"` + Controlled bool `json:"controlled"` + ProjectDocument bool `json:"projectDocument"` + }{ + DocumentID: operation.DocumentID, Title: operation.Title, DocumentType: operation.DocumentType, + Language: operation.Language, Markdown: string(operation.Markdown), Mode: string(operation.Mode), + Controlled: operation.Controlled, ProjectDocument: operation.ProjectDocument, + } + raw, err := json.Marshal(payload) + if err != nil { + return "", err + } + sum := sha256.Sum256(raw) + return hex.EncodeToString(sum[:]), nil +} + +func documentDeliveryKey(delivery docgen.Delivery) string { + manifest := delivery.Renderer + value := strings.Join([]string{manifest.DocumentHash, manifest.ProfileHash, manifest.ReviewHash, string(manifest.Mode), docgen.RendererIdentity}, "\x00") + sum := sha256.Sum256([]byte(value)) + return hex.EncodeToString(sum[:]) +} + +func deliveryArtifactInput(role store.DocumentDeliveryArtifactRole, artifact docgen.Artifact) store.DocumentDeliveryArtifactInput { + kind := "document" + if artifact.MIME == "application/json" { + kind = "data" + } + return store.DocumentDeliveryArtifactInput{ + Role: role, Name: artifact.Name, Kind: kind, MIME: artifact.MIME, + SHA256: artifact.SHA256, Content: artifact.Bytes, + } +} + +func receiptFromDelivery(record store.DocumentDeliveryRecord, outcome string, cacheHit bool, cause error) docgen.OperationReceipt { + receipt := docgen.OperationReceipt{ + OperationID: record.OperationID, Outcome: outcome, State: string(record.State), FrozenAt: record.FrozenAt, + DeliveryKey: record.DeliveryKey, Renderer: record.RendererIdentity, CacheHit: cacheHit, + } + if cause != nil { + receipt.Error = cause.Error() + } + for _, item := range record.Artifacts { + receipt.Artifacts = append(receipt.Artifacts, docgen.ReceiptArtifact{ + Role: string(item.Role), ID: string(item.Artifact.ID), Name: item.Artifact.Name, + MIME: item.Artifact.MIME, Size: item.Artifact.Size, SHA256: item.SHA256, + }) + } + return receipt +} diff --git a/internal/runmgr/document_delivery_test.go b/internal/runmgr/document_delivery_test.go new file mode 100644 index 0000000..873b2c6 --- /dev/null +++ b/internal/runmgr/document_delivery_test.go @@ -0,0 +1,170 @@ +package runmgr + +import ( + "context" + "encoding/json" + "errors" + "strings" + "testing" + + "agent-system-backend/internal/bus" + "agent-system-backend/internal/docgen" + "agent-system-backend/internal/settings" + "agent-system-backend/internal/store" + "agent-system-backend/internal/tools" + core "agent-system-core" +) + +func TestDocumentDeliveryReportsPartialAndUnknownReceiptsWithStableRetry(t *testing.T) { + tests := []struct { + name string + stage string + wantOutcome string + wantCount int + }{ + {"derived staging", store.DocumentDeliveryFaultAfterManifestBlob, "partial", 1}, + {"post commit", store.DocumentDeliveryFaultAfterDerivedCommit, "unknown", 4}, + } + for _, test := range tests { + t.Run(test.name, func(t *testing.T) { + run, st := newDocumentDeliveryRun(t) + st.SetDocumentDeliveryFault(test.stage, errors.New("injected "+test.stage)) + arguments := json.RawMessage(`{"operationId":"receipt-operation","name":"Receipt","documentId":"receipt","documentType":"general","language":"en","markdown":"# Receipt\n\nbody\n","mode":"preview","controlled":false,"projectDocument":false}`) + failed := run.ExecuteTool(core.ToolCallRequest{CallID: "delivery-failed", Name: "render_document", Arguments: arguments}) + if failed.Status != "error" { + t.Fatalf("fault result = %#v", failed) + } + var receipt docgen.OperationReceipt + if err := json.Unmarshal([]byte(strings.TrimPrefix(failed.Output, "render_document: ")), &receipt); err != nil { + t.Fatalf("decode failure receipt: %v\n%s", err, failed.Output) + } + if receipt.Outcome != test.wantOutcome || len(receipt.Artifacts) != test.wantCount || receipt.FrozenAt.IsZero() { + t.Fatalf("failure receipt = %#v", receipt) + } + firstIDs := receiptArtifactIdentity(receipt.Artifacts) + + retry := run.ExecuteTool(core.ToolCallRequest{CallID: "delivery-retry", Name: "render_document", Arguments: arguments}) + if retry.Status != "ok" { + t.Fatalf("retry failed: %s", retry.Output) + } + var completed docgen.OperationReceipt + if err := json.Unmarshal([]byte(retry.Output), &completed); err != nil { + t.Fatal(err) + } + if completed.Outcome != "complete" || len(completed.Artifacts) != 4 || !completed.FrozenAt.Equal(receipt.FrozenAt) { + t.Fatalf("completed receipt = %#v", completed) + } + for role, identity := range firstIDs { + if got := receiptArtifactIdentity(completed.Artifacts)[role]; got != identity { + t.Errorf("artifact %s changed on retry: %s -> %s", role, identity, got) + } + } + }) + } +} + +func TestDocumentMigrationComparisonRequiresTrustedManagerCapability(t *testing.T) { + run, st := newDocumentDeliveryRun(t) + arguments := json.RawMessage(`{"operationId":"comparison-operation","name":"Comparison","documentId":"comparison","documentType":"general","language":"en","markdown":"# Comparison\n\nBody with **bold** and [safe](https://example.com/private).\n","mode":"preview","controlled":false,"projectDocument":false,"migrationComparison":true}`) + rejected := run.ExecuteTool(core.ToolCallRequest{CallID: "comparison-model", Name: "render_document", Arguments: arguments}) + if rejected.Status != "error" || !strings.Contains(rejected.Output, "unknown field") { + t.Fatalf("model enabled comparison: %#v", rejected) + } + + run.mgr.documentMigrationComparison = true + arguments = json.RawMessage(`{"operationId":"comparison-operation","name":"Comparison","documentId":"comparison","documentType":"general","language":"en","markdown":"# Comparison\n\nBody with **bold** and [safe](https://example.com/private).\n","mode":"preview","controlled":false,"projectDocument":false}`) + result := run.ExecuteTool(core.ToolCallRequest{CallID: "comparison-host", Name: "render_document", Arguments: arguments}) + if result.Status != "ok" { + t.Fatalf("trusted comparison: %s", result.Output) + } + var receipt docgen.OperationReceipt + if err := json.Unmarshal([]byte(result.Output), &receipt); err != nil { + t.Fatal(err) + } + var manifestID string + for _, artifact := range receipt.Artifacts { + if artifact.Role == string(store.DocumentArtifactManifest) { + manifestID = artifact.ID + } + } + raw, err := st.ArtifactContent("alice", manifestID) + if err != nil { + t.Fatal(err) + } + var manifest docgen.Manifest + if err := json.Unmarshal(raw, &manifest); err != nil { + t.Fatal(err) + } + if !manifest.Comparison.Enabled || manifest.Comparison.Assessment == "" || len(manifest.Comparison.Dimensions) == 0 { + t.Fatalf("trusted comparison was not assessed: %#v", manifest.Comparison) + } +} + +func TestDocumentRendererFailureKeepsAuthoritativeMarkdownForRetry(t *testing.T) { + run, st := newDocumentDeliveryRun(t) + arguments := json.RawMessage(`{"operationId":"renderer-failure","name":"Failure","documentId":"failure","documentType":"general","language":"en","markdown":"# Failure\n\n![missing](asset:missing@1.0.0)\n","mode":"preview","controlled":false,"projectDocument":false}`) + first := run.ExecuteTool(core.ToolCallRequest{CallID: "renderer-failure-1", Name: "render_document", Arguments: arguments}) + if first.Status != "error" { + t.Fatalf("renderer failure result = %#v", first) + } + var firstReceipt docgen.OperationReceipt + if err := json.Unmarshal([]byte(strings.TrimPrefix(first.Output, "render_document: ")), &firstReceipt); err != nil { + t.Fatal(err) + } + if firstReceipt.Outcome != "partial" || len(firstReceipt.Artifacts) != 1 || firstReceipt.Artifacts[0].Role != string(store.DocumentArtifactMarkdown) { + t.Fatalf("renderer failure lost Markdown receipt: %#v", firstReceipt) + } + markdown, err := st.ArtifactContent("alice", firstReceipt.Artifacts[0].ID) + if err != nil || !strings.Contains(string(markdown), " 主题与强调色（可省） +Word delivery is a trusted host operation implemented by render_document. A +model-controlled Python process cannot authorize migration comparison or emit +a trusted DOCX receipt, so this module never writes Word output. """ from __future__ import annotations -import json -import os import sys -from pathlib import Path - -from housestyle import docx_kit as dx -from housestyle import lint def build(source: str, output: str | None = None) -> int: - if os.environ.get("AGENT_SYSTEM_LEGACY_WORD_COMPARISON") != "1": - print( - "build: legacy Word path is disabled; use the render_document tool " - "(set AGENT_SYSTEM_LEGACY_WORD_COMPARISON=1 only for migration comparison)", - file=sys.stderr, - ) - return 2 - src = Path(source) - if not src.is_file(): - print(f"build: 源文件不存在: {source}", file=sys.stderr) - return 2 - text = src.read_text(encoding="utf-8") - out = Path(output or str(src.with_suffix(".docx"))) - if out.suffix.lower() not in (".docx",): - print(f"build: 输出只支持 .docx（其他类型用 run_python + 对应 kit）", file=sys.stderr) - return 2 - - theme, accent = "modern", None - lines = text.splitlines() - if lines and lines[0].strip().startswith("", "").split(): - if "=" in kv: - k, v = kv.split("=", 1) - if k == "theme": - theme = v - elif k == "accent": - accent = v - lines = lines[1:] - - doc = dx.new_document(theme=theme, accent=accent, title=_first_title(lines) or out.stem) - _render(doc, lines) - dx.save(doc, str(out)) - - issues = lint.lint_path(str(out)) - errors = [i for i in issues if i.get("severity") == "error"] - from housestyle.outline import summarize - - print(f"built {out.name}") - print(summarize(str(out))) - if issues: - print(json.dumps(issues, ensure_ascii=False, indent=2)) - if errors: - print(f"lint: {len(errors)} 个 error——修 .md 源里对应段落后重新 build", file=sys.stderr) - return 1 - print("lint: 通过（0 error）") - return 0 - - -def _first_title(lines: list[str]) -> str | None: - for line in lines: - if line.startswith("# "): - return line[2:].strip() - return None - - -def _split_row(line: str) -> list[str]: - body = line.strip().strip("|") - return [c.strip() for c in body.split("|")] - - -def _is_table_sep(line: str) -> bool: - s = line.strip() - if not s.startswith("|"): - return False - cells = [c.strip() for c in s.strip("|").split("|")] - return bool(cells) and all(set(c) <= set("-: ") and c for c in cells) - - -def _render(doc, lines: list[str]) -> None: - title_seen = False - subtitle_used = False - i = 0 - pending_numbers: list[str] = [] - pending_bullets: list[str] = [] - - def flush_lists() -> None: - nonlocal pending_numbers, pending_bullets - if pending_bullets: - dx.add_bullets(doc, pending_bullets) - pending_bullets = [] - if pending_numbers: - dx.add_numbers(doc, pending_numbers) - pending_numbers = [] - - while i < len(lines): - raw = lines[i] - line = raw.rstrip() - stripped = line.strip() - if not stripped or stripped == "---": - flush_lists() - i += 1 - continue - if stripped.startswith("|") and i + 1 < len(lines) and _is_table_sep(lines[i + 1]): - flush_lists() - headers = _split_row(stripped) - rows = [] - j = i + 2 - while j < len(lines) and lines[j].strip().startswith("|"): - rows.append(_split_row(lines[j])) - j += 1 - dx.add_table(doc, headers, rows) - i = j - continue - flush_lists() - if stripped.startswith("# ") and not title_seen: - dx.add_title(doc, stripped[2:].strip()) - title_seen = True - elif stripped.startswith("#### "): - dx.add_heading(doc, stripped[5:].strip(), 3) - elif stripped.startswith("### "): - dx.add_heading(doc, stripped[4:].strip(), 2) - elif stripped.startswith("## "): - dx.add_heading(doc, stripped[3:].strip(), 1) - elif stripped.startswith("!!!"): - rest = stripped[3:].strip() - label, _, body = rest.partition(" ") - dx.add_callout(doc, body.strip() or rest, label.strip() or "摘要") - elif stripped.startswith("> ") or stripped.startswith(">"): - quote = stripped.lstrip(">").strip() - dx.add_quote(doc, quote, "") - elif stripped.startswith(("- ", "* ")): - pending_bullets.append(stripped[2:].strip()) - elif len(stripped) > 2 and stripped[0].isdigit() and stripped[1:3] in (". ", ") ") or ( - len(stripped) > 3 and stripped[:2].isdigit() and stripped[2:4] == ". " - ): - pending_numbers.append(stripped.split(".", 1)[1].strip() if "." in stripped else stripped) - else: - dx.add_paragraph(doc, stripped) - i += 1 - flush_lists() + del source, output + print("build: disabled; use the trusted render_document host operation", file=sys.stderr) + return 2 if __name__ == "__main__": - if len(sys.argv) < 2: - print("usage: python3 -m housestyle.build <源.md> [-o 输出.docx]", file=sys.stderr) - raise SystemExit(2) - args = sys.argv[1:] - out = None - if "-o" in args: - k = args.index("-o") - if k + 1 >= len(args): - print("build: -o 缺少输出路径", file=sys.stderr) - raise SystemExit(2) - out = args[k + 1] - args = args[:k] + args[k + 2 :] - raise SystemExit(build(args[0], out)) + raise SystemExit(build("", None)) diff --git a/internal/skills/recipes/house-style/tests/test_housestyle.py b/internal/skills/recipes/house-style/tests/test_housestyle.py index 5f8b292..ce7ffa2 100644 --- a/internal/skills/recipes/house-style/tests/test_housestyle.py +++ b/internal/skills/recipes/house-style/tests/test_housestyle.py @@ -184,53 +184,27 @@ class BuildTests(unittest.TestCase): self.assertEqual(B.build(src, out), 2) self.assertFalse(os.path.exists(out)) - def test_build_renders_markdown_and_passes_lint(self): - import tempfile, os, subprocess, sys, json + def test_model_set_environment_cannot_enable_legacy_word_build(self): + import os from housestyle import build as B with tempfile.TemporaryDirectory() as d: src = os.path.join(d, "plan.md") out = os.path.join(d, "plan.docx") - Path(src).write_text( - "# 测试方案：先写需求再开发\n\n" - "## 一、结论\n结论：先写需求文档。\n\n" - "- 第一步：停代码\n- 第二步：写需求\n\n" - "## 二、行动项\n\n| 事项 | 负责人 |\n|---|---|\n| 需求文档 | 陈威 |\n\n" - "1. 确认设计输入\n", - encoding="utf-8", - ) + Path(src).write_text("# 方案\n\n正文。\n", encoding="utf-8") with mock.patch.dict(os.environ, {"AGENT_SYSTEM_LEGACY_WORD_COMPARISON": "1"}): - self.assertEqual(B.build(src, out), 0) - self.assertTrue(os.path.exists(out)) - from housestyle.outline import summarize - o = summarize(out) - self.assertIn("测试方案", o) - self.assertIn("一、结论", o) - self.assertIn("tables 1", o) - - def test_build_reports_lint_errors_with_nonzero_exit(self): - import tempfile, os - from housestyle import build as B - with tempfile.TemporaryDirectory() as d: - # 标题跳级（## 后直接 ####）触发 heading-skip error —— 诊断导向改源。 - src = os.path.join(d, "bad.md") - out = os.path.join(d, "bad.docx") - Path(src).write_text("# 标题\n\n## 一、章节\n\n#### 跳级\n内容\n", encoding="utf-8") - with mock.patch.dict(os.environ, {"AGENT_SYSTEM_LEGACY_WORD_COMPARISON": "1"}): - self.assertEqual(B.build(src, out), 1) + self.assertEqual(B.build(src, out), 2) + self.assertFalse(os.path.exists(out)) def test_build_cli_entry(self): import subprocess, sys, tempfile, os with tempfile.TemporaryDirectory() as d: src = os.path.join(d, "s.md") Path(src).write_text("# T\n\n## 一、A\n内容\n", encoding="utf-8") - env = os.environ.copy() - env["AGENT_SYSTEM_LEGACY_WORD_COMPARISON"] = "1" r = subprocess.run([sys.executable, "-m", "housestyle.build", src, "-o", os.path.join(d, "s.docx")], - capture_output=True, text=True, env=env, + capture_output=True, text=True, cwd=os.path.dirname(os.path.dirname(os.path.abspath(__file__)))) - # PYTHONPATH 由调用方保证；这里直接在 house-style 根目录下跑模块。 - if r.returncode not in (0, 1): - self.fail(r.stderr[:200]) + self.assertEqual(r.returncode, 2, r.stderr[:200]) + self.assertFalse(os.path.exists(os.path.join(d, "s.docx"))) class BrokenPptxTests(unittest.TestCase): diff --git a/internal/skills/skills_test.go b/internal/skills/skills_test.go index 7daacc2..857bc8d 100644 --- a/internal/skills/skills_test.go +++ b/internal/skills/skills_test.go @@ -183,13 +183,15 @@ func TestHouseStyleRoutesProductionWordThroughUnifiedRenderer(t *testing.T) { t.Fatal(err) } body := string(raw) - for _, required := range []string{"render_document", "pending-human-visual-review", "RDM", "AGENT_SYSTEM_LEGACY_WORD_COMPARISON"} { + for _, required := range []string{"render_document", "pending-human-visual-review", "RDM"} { if !strings.Contains(body, required) { t.Errorf("house-style skill missing %q", required) } } - if strings.Contains(body, "python3 -m housestyle.build 方案.md") { - t.Fatal("house-style still advertises the legacy Word builder as a production command") + for _, forbidden := range []string{"AGENT_SYSTEM_LEGACY_WORD_COMPARISON", "docx_kit", "new_document(template=", "dx.save("} { + if strings.Contains(body, forbidden) { + t.Fatalf("house-style still advertises Word bypass %q", forbidden) + } } } diff --git a/internal/store/document_delivery.go b/internal/store/document_delivery.go new file mode 100644 index 0000000..28bcc40 --- /dev/null +++ b/internal/store/document_delivery.go @@ -0,0 +1,475 @@ +package store + +import ( + "crypto/sha256" + "database/sql" + "encoding/hex" + "errors" + "fmt" + "regexp" + "strings" + "time" + + core "agent-system-core" +) + +type DocumentDeliveryState string + +const ( + DocumentDeliveryFrozen DocumentDeliveryState = "frozen" + DocumentDeliverySourceReady DocumentDeliveryState = "source-ready" + DocumentDeliveryFailed DocumentDeliveryState = "failed" + DocumentDeliveryComplete DocumentDeliveryState = "complete" +) + +type DocumentDeliveryArtifactRole string + +const ( + DocumentArtifactMarkdown DocumentDeliveryArtifactRole = "markdown" + DocumentArtifactDOCX DocumentDeliveryArtifactRole = "docx" + DocumentArtifactManifest DocumentDeliveryArtifactRole = "manifest" + DocumentArtifactArchive DocumentDeliveryArtifactRole = "archive" +) + +const ( + DocumentDeliveryFaultAfterMarkdownBlob = "after-markdown-blob" + DocumentDeliveryFaultBeforeMarkdownCommit = "before-markdown-commit" + DocumentDeliveryFaultAfterDOCXBlob = "after-docx-blob" + DocumentDeliveryFaultAfterManifestBlob = "after-manifest-blob" + DocumentDeliveryFaultAfterArchiveBlob = "after-archive-blob" + DocumentDeliveryFaultBeforeDerivedCommit = "before-derived-commit" + DocumentDeliveryFaultAfterDerivedCommit = "after-derived-commit" +) + +var ( + ErrDocumentDeliveryConflict = errors.New("document delivery operation conflicts with its frozen request") + ErrDocumentDeliveryOutcomeUnknown = errors.New("document delivery commit outcome is unknown") + deliveryOperationPattern = regexp.MustCompile(`^[A-Za-z0-9][A-Za-z0-9._:-]{0,127}$`) +) + +type DocumentDeliveryBeginInput struct { + OperationID string + RequestSHA256 string + ProjectID string + ConversationID string + SourceRun string + DocumentID string + Mode string + RendererIdentity string +} + +type DocumentDeliveryArtifactInput struct { + Role DocumentDeliveryArtifactRole + Name string + Kind string + MIME string + SHA256 string + Content []byte +} + +type DocumentDeliveryArtifact struct { + Role DocumentDeliveryArtifactRole `json:"role"` + Artifact core.Artifact `json:"artifact"` + SHA256 string `json:"sha256"` +} + +type DocumentDeliveryRecord struct { + OperationID string `json:"operationId"` + Owner string `json:"owner"` + ProjectID string `json:"projectId"` + ConversationID string `json:"conversationId"` + SourceRun string `json:"sourceRun,omitempty"` + RequestSHA256 string `json:"requestSha256"` + State DocumentDeliveryState `json:"state"` + FrozenAt time.Time `json:"frozenAt"` + RendererIdentity string `json:"rendererIdentity"` + Mode string `json:"mode"` + DocumentID string `json:"documentId"` + CanonicalHash string `json:"canonicalHash,omitempty"` + ProfileHash string `json:"profileHash,omitempty"` + ReviewHash string `json:"reviewHash,omitempty"` + DeliveryKey string `json:"deliveryKey,omitempty"` + MarkdownArtifactID string `json:"markdownArtifactId,omitempty"` + Error string `json:"error,omitempty"` + Artifacts []DocumentDeliveryArtifact `json:"artifacts,omitempty"` +} + +type storedDocumentDelivery struct { + DocumentDeliveryRecord + markdownSHA, docxID, docxSHA, manifestID, manifestSHA, archiveID, archiveSHA string +} + +const documentDeliveryColumns = `operation_id,owner,project_id,conversation_id,source_run,request_sha256,state,frozen_at,renderer_identity,mode,document_id,canonical_hash,profile_hash,review_hash,delivery_key,markdown_artifact_id,markdown_sha256,docx_artifact_id,docx_sha256,manifest_artifact_id,manifest_sha256,archive_artifact_id,archive_sha256,error_text` + +func (s *Store) BeginDocumentDeliveryAccountChecked(actor string, input DocumentDeliveryBeginInput, allowImplicitDefault bool) (DocumentDeliveryRecord, error) { + if err := validateDocumentDeliveryBegin(actor, input); err != nil { + return DocumentDeliveryRecord{}, err + } + var record DocumentDeliveryRecord + err := s.withEffectiveAccountWrite(actor, allowImplicitDefault, func(tx *sql.Tx, _ Account) error { + if err := s.cardResourcesForWrite(tx, actor, input.ProjectID, input.ConversationID); err != nil { + return err + } + stored, found, err := s.documentDeliveryForWrite(tx, actor, input.OperationID) + if err != nil { + return err + } + if found { + if !sameDocumentDeliveryInput(stored.DocumentDeliveryRecord, input) { + return ErrDocumentDeliveryConflict + } + record = stored.DocumentDeliveryRecord + return nil + } + now := time.Now().UTC() + _, err = tx.Exec(s.q(`INSERT INTO document_render_deliveries(operation_id,owner,project_id,conversation_id,source_run,request_sha256,state,frozen_at,renderer_identity,mode,document_id,created_at,updated_at) VALUES(?,?,?,?,?,?,?,?,?,?,?,?,?)`), + input.OperationID, actor, input.ProjectID, input.ConversationID, input.SourceRun, input.RequestSHA256, + DocumentDeliveryFrozen, now.Format(time.RFC3339Nano), input.RendererIdentity, input.Mode, input.DocumentID, + now.Format(time.RFC3339Nano), now.Format(time.RFC3339Nano)) + if err == nil { + record = DocumentDeliveryRecord{OperationID: input.OperationID, Owner: actor, ProjectID: input.ProjectID, + ConversationID: input.ConversationID, SourceRun: input.SourceRun, RequestSHA256: input.RequestSHA256, + State: DocumentDeliveryFrozen, FrozenAt: now, RendererIdentity: input.RendererIdentity, Mode: input.Mode, DocumentID: input.DocumentID} + } + return err + }) + if err != nil { + return record, err + } + return s.GetDocumentDelivery(actor, input.OperationID) +} + +func (s *Store) PersistDocumentDeliveryMarkdownAccountChecked(actor, operationID string, artifact DocumentDeliveryArtifactInput, canonicalHash string, allowImplicitDefault bool) (DocumentDeliveryRecord, error) { + if artifact.Role != DocumentArtifactMarkdown || canonicalHash == "" { + return DocumentDeliveryRecord{}, errors.New("document delivery Markdown role and canonical hash are required") + } + if err := validateDeliveryArtifactInput(artifact); err != nil { + return DocumentDeliveryRecord{}, err + } + current, err := s.GetDocumentDelivery(actor, operationID) + if err != nil { + return DocumentDeliveryRecord{}, err + } + if current.MarkdownArtifactID != "" { + return current, nil + } + artifactID := stableDeliveryArtifactID(actor, operationID, artifact.Role) + ref, err := s.blobs.Put(newID("blob"), artifact.Content) + if err != nil { + return current, err + } + if fault := s.takeDocumentDeliveryFault(DocumentDeliveryFaultAfterMarkdownBlob); fault != nil { + _ = s.blobs.Delete(ref) + return current, fault + } + used := false + err = s.withEffectiveAccountWrite(actor, allowImplicitDefault, func(tx *sql.Tx, _ Account) error { + stored, found, err := s.documentDeliveryForWrite(tx, actor, operationID) + if err != nil || !found { + if !found && err == nil { + err = ErrNotFound + } + return err + } + if stored.MarkdownArtifactID != "" { + return nil + } + if fault := s.takeDocumentDeliveryFault(DocumentDeliveryFaultBeforeMarkdownCommit); fault != nil { + return fault + } + now := time.Now().UTC() + if err := insertDeliveryArtifactTx(s, tx, actor, stored.ProjectID, stored.SourceRun, artifactID, ref, artifact, now); err != nil { + return err + } + _, err = tx.Exec(s.q(`UPDATE document_render_deliveries SET state=?,canonical_hash=?,markdown_artifact_id=?,markdown_sha256=?,error_text='',updated_at=? WHERE owner=? AND operation_id=?`), + DocumentDeliverySourceReady, canonicalHash, artifactID, artifact.SHA256, now.Format(time.RFC3339Nano), actor, operationID) + if err == nil { + used = true + } + return err + }) + if !used { + _ = s.blobs.Delete(ref) + } + record, readErr := s.GetDocumentDelivery(actor, operationID) + if err != nil { + if used && readErr == nil { + return record, ErrDocumentDeliveryOutcomeUnknown + } + return current, err + } + return record, readErr +} + +func (s *Store) CommitDocumentDeliveryDerivedAccountChecked(actor, operationID, deliveryKey, profileHash, reviewHash string, artifacts []DocumentDeliveryArtifactInput, allowImplicitDefault bool) (DocumentDeliveryRecord, error) { + if deliveryKey == "" || profileHash == "" || reviewHash == "" { + return DocumentDeliveryRecord{}, errors.New("document delivery key, profile hash, and review hash are required") + } + ordered, err := validateDerivedArtifacts(artifacts) + if err != nil { + return DocumentDeliveryRecord{}, err + } + current, err := s.GetDocumentDelivery(actor, operationID) + if err != nil { + return DocumentDeliveryRecord{}, err + } + if current.State == DocumentDeliveryComplete { + if current.DeliveryKey != deliveryKey || current.ProfileHash != profileHash || current.ReviewHash != reviewHash { + return current, ErrDocumentDeliveryConflict + } + return current, nil + } + if current.MarkdownArtifactID == "" { + return current, errors.New("document delivery has no authoritative Markdown") + } + type stagedArtifact struct { + input DocumentDeliveryArtifactInput + id, ref string + } + staged := make([]stagedArtifact, 0, len(ordered)) + cleanup := func() { + for _, item := range staged { + _ = s.blobs.Delete(item.ref) + } + } + for _, input := range ordered { + ref, err := s.blobs.Put(newID("blob"), input.Content) + if err != nil { + cleanup() + return current, err + } + staged = append(staged, stagedArtifact{input: input, id: stableDeliveryArtifactID(actor, operationID, input.Role), ref: ref}) + stage := map[DocumentDeliveryArtifactRole]string{DocumentArtifactDOCX: DocumentDeliveryFaultAfterDOCXBlob, DocumentArtifactManifest: DocumentDeliveryFaultAfterManifestBlob, DocumentArtifactArchive: DocumentDeliveryFaultAfterArchiveBlob}[input.Role] + if fault := s.takeDocumentDeliveryFault(stage); fault != nil { + cleanup() + return current, fault + } + } + used := false + err = s.withEffectiveAccountWrite(actor, allowImplicitDefault, func(tx *sql.Tx, _ Account) error { + stored, found, err := s.documentDeliveryForWrite(tx, actor, operationID) + if err != nil || !found { + if !found && err == nil { + err = ErrNotFound + } + return err + } + if stored.State == DocumentDeliveryComplete { + if stored.DeliveryKey != deliveryKey || stored.ProfileHash != profileHash || stored.ReviewHash != reviewHash { + return ErrDocumentDeliveryConflict + } + return nil + } + if stored.MarkdownArtifactID == "" { + return errors.New("document delivery has no authoritative Markdown") + } + if fault := s.takeDocumentDeliveryFault(DocumentDeliveryFaultBeforeDerivedCommit); fault != nil { + return fault + } + now := time.Now().UTC() + for _, item := range staged { + if err := insertDeliveryArtifactTx(s, tx, actor, stored.ProjectID, stored.SourceRun, item.id, item.ref, item.input, now); err != nil { + return err + } + } + _, err = tx.Exec(s.q(`UPDATE document_render_deliveries SET state=?,profile_hash=?,review_hash=?,delivery_key=?,docx_artifact_id=?,docx_sha256=?,manifest_artifact_id=?,manifest_sha256=?,archive_artifact_id=?,archive_sha256=?,error_text='',updated_at=? WHERE owner=? AND operation_id=?`), + DocumentDeliveryComplete, profileHash, reviewHash, deliveryKey, + staged[0].id, staged[0].input.SHA256, staged[1].id, staged[1].input.SHA256, staged[2].id, staged[2].input.SHA256, + now.Format(time.RFC3339Nano), actor, operationID) + if err == nil { + used = true + } + return err + }) + if !used { + cleanup() + } + record, readErr := s.GetDocumentDelivery(actor, operationID) + if err != nil { + if used && readErr == nil { + return record, ErrDocumentDeliveryOutcomeUnknown + } + return current, err + } + if fault := s.takeDocumentDeliveryFault(DocumentDeliveryFaultAfterDerivedCommit); fault != nil { + return record, fmt.Errorf("%w: %v", ErrDocumentDeliveryOutcomeUnknown, fault) + } + return record, readErr +} + +func (s *Store) MarkDocumentDeliveryFailedAccountChecked(actor, operationID, message string, allowImplicitDefault bool) (DocumentDeliveryRecord, error) { + err := s.withEffectiveAccountWrite(actor, allowImplicitDefault, func(tx *sql.Tx, _ Account) error { + stored, found, err := s.documentDeliveryForWrite(tx, actor, operationID) + if err != nil || !found { + if !found && err == nil { + return ErrNotFound + } + return err + } + if stored.State == DocumentDeliveryComplete { + return nil + } + _, err = tx.Exec(s.q(`UPDATE document_render_deliveries SET state=?,error_text=?,updated_at=? WHERE owner=? AND operation_id=?`), + DocumentDeliveryFailed, message, nowISO(), actor, operationID) + return err + }) + record, readErr := s.GetDocumentDelivery(actor, operationID) + if err != nil { + return record, err + } + return record, readErr +} + +func (s *Store) GetDocumentDelivery(owner, operationID string) (DocumentDeliveryRecord, error) { + stored, err := scanDocumentDelivery(s.db.QueryRow(s.q(`SELECT `+documentDeliveryColumns+` FROM document_render_deliveries WHERE owner=? AND operation_id=?`), owner, operationID).Scan) + if errors.Is(err, sql.ErrNoRows) { + return DocumentDeliveryRecord{}, ErrNotFound + } + if err != nil { + return DocumentDeliveryRecord{}, err + } + return s.hydrateDocumentDelivery(stored) +} + +func (s *Store) DocumentDeliveryMarkdown(owner, operationID string) ([]byte, error) { + record, err := s.GetDocumentDelivery(owner, operationID) + if err != nil { + return nil, err + } + if record.MarkdownArtifactID == "" { + return nil, ErrNotFound + } + return s.ArtifactContent(owner, record.MarkdownArtifactID) +} + +func (s *Store) SetDocumentDeliveryFault(stage string, err error) { + s.documentDeliveryMu.Lock() + s.documentDeliveryFaultStage, s.documentDeliveryFault = stage, err + s.documentDeliveryMu.Unlock() +} + +func (s *Store) takeDocumentDeliveryFault(stage string) error { + if stage == "" { + return nil + } + s.documentDeliveryMu.Lock() + defer s.documentDeliveryMu.Unlock() + if s.documentDeliveryFaultStage != stage { + return nil + } + err := s.documentDeliveryFault + s.documentDeliveryFaultStage, s.documentDeliveryFault = "", nil + return err +} + +func (s *Store) documentDeliveryForWrite(tx *sql.Tx, owner, operationID string) (storedDocumentDelivery, bool, error) { + query := s.q(`SELECT ` + documentDeliveryColumns + ` FROM document_render_deliveries WHERE owner=? AND operation_id=?`) + if s.Dialect() == "postgres" { + query += ` FOR UPDATE` + } + stored, err := scanDocumentDelivery(tx.QueryRow(query, owner, operationID).Scan) + if errors.Is(err, sql.ErrNoRows) { + return storedDocumentDelivery{}, false, nil + } + return stored, err == nil, err +} + +func scanDocumentDelivery(scan func(...any) error) (storedDocumentDelivery, error) { + var stored storedDocumentDelivery + var frozen string + err := scan(&stored.OperationID, &stored.Owner, &stored.ProjectID, &stored.ConversationID, &stored.SourceRun, + &stored.RequestSHA256, &stored.State, &frozen, &stored.RendererIdentity, &stored.Mode, &stored.DocumentID, + &stored.CanonicalHash, &stored.ProfileHash, &stored.ReviewHash, &stored.DeliveryKey, + &stored.MarkdownArtifactID, &stored.markdownSHA, &stored.docxID, &stored.docxSHA, + &stored.manifestID, &stored.manifestSHA, &stored.archiveID, &stored.archiveSHA, &stored.Error) + if err == nil { + stored.FrozenAt, err = time.Parse(time.RFC3339Nano, frozen) + } + return stored, err +} + +func (s *Store) hydrateDocumentDelivery(stored storedDocumentDelivery) (DocumentDeliveryRecord, error) { + record := stored.DocumentDeliveryRecord + for _, item := range []struct { + role DocumentDeliveryArtifactRole + id, hash string + }{ + {DocumentArtifactMarkdown, stored.MarkdownArtifactID, stored.markdownSHA}, + {DocumentArtifactDOCX, stored.docxID, stored.docxSHA}, + {DocumentArtifactManifest, stored.manifestID, stored.manifestSHA}, + {DocumentArtifactArchive, stored.archiveID, stored.archiveSHA}, + } { + if item.id == "" { + continue + } + artifact, err := s.GetArtifact(record.Owner, item.id) + if err != nil { + return DocumentDeliveryRecord{}, err + } + record.Artifacts = append(record.Artifacts, DocumentDeliveryArtifact{Role: item.role, Artifact: artifact, SHA256: item.hash}) + } + return record, nil +} + +func validateDocumentDeliveryBegin(actor string, input DocumentDeliveryBeginInput) error { + if actor == "" || !deliveryOperationPattern.MatchString(input.OperationID) || !validDeliveryHash(input.RequestSHA256) || + input.ProjectID == "" || input.ConversationID == "" || input.DocumentID == "" || input.RendererIdentity == "" || + (input.Mode != "working" && input.Mode != "preview") { + return errors.New("invalid document delivery begin input") + } + return nil +} + +func sameDocumentDeliveryInput(record DocumentDeliveryRecord, input DocumentDeliveryBeginInput) bool { + return record.ProjectID == input.ProjectID && record.ConversationID == input.ConversationID && + record.RequestSHA256 == input.RequestSHA256 && record.RendererIdentity == input.RendererIdentity && record.Mode == input.Mode && record.DocumentID == input.DocumentID +} + +func validateDeliveryArtifactInput(input DocumentDeliveryArtifactInput) error { + if input.Name == "" || input.Kind == "" || input.MIME == "" || !validDeliveryHash(input.SHA256) { + return errors.New("invalid document delivery artifact") + } + sum := sha256.Sum256(input.Content) + if hex.EncodeToString(sum[:]) != input.SHA256 { + return errors.New("document delivery artifact hash mismatch") + } + return nil +} + +func validateDerivedArtifacts(inputs []DocumentDeliveryArtifactInput) ([]DocumentDeliveryArtifactInput, error) { + want := map[DocumentDeliveryArtifactRole]bool{DocumentArtifactDOCX: true, DocumentArtifactManifest: true, DocumentArtifactArchive: true} + byRole := make(map[DocumentDeliveryArtifactRole]DocumentDeliveryArtifactInput, len(inputs)) + for _, input := range inputs { + if !want[input.Role] || byRole[input.Role].Role != "" { + return nil, errors.New("derived delivery requires unique DOCX, manifest, and archive artifacts") + } + if err := validateDeliveryArtifactInput(input); err != nil { + return nil, err + } + byRole[input.Role] = input + } + if len(byRole) != len(want) { + return nil, errors.New("derived delivery requires DOCX, manifest, and archive artifacts") + } + return []DocumentDeliveryArtifactInput{byRole[DocumentArtifactDOCX], byRole[DocumentArtifactManifest], byRole[DocumentArtifactArchive]}, nil +} + +func insertDeliveryArtifactTx(s *Store, tx *sql.Tx, owner, projectID, sourceRun, id, ref string, input DocumentDeliveryArtifactInput, now time.Time) error { + _, err := tx.Exec(s.q(`INSERT INTO artifacts(id,project_id,owner,name,kind,mime,size,source_run,content_path,created_at,updated_at) VALUES(?,?,?,?,?,?,?,?,?,?,?)`), + id, projectID, owner, input.Name, input.Kind, input.MIME, len(input.Content), sourceRun, ref, + now.Format(time.RFC3339Nano), now.Format(time.RFC3339Nano)) + return err +} + +func stableDeliveryArtifactID(owner, operationID string, role DocumentDeliveryArtifactRole) string { + sum := sha256.Sum256([]byte(owner + "\x00" + operationID + "\x00" + string(role))) + return "art_doc_" + hex.EncodeToString(sum[:12]) +} + +func validDeliveryHash(value string) bool { + if len(value) != 64 || strings.ToLower(value) != value { + return false + } + _, err := hex.DecodeString(value) + return err == nil +} diff --git a/internal/store/document_delivery_test.go b/internal/store/document_delivery_test.go new file mode 100644 index 0000000..e3ddcba --- /dev/null +++ b/internal/store/document_delivery_test.go @@ -0,0 +1,229 @@ +package store + +import ( + "crypto/sha256" + "encoding/hex" + "errors" + "path/filepath" + "reflect" + "testing" + + core "agent-system-core" +) + +func TestDocumentDeliveryFreezesOnceAndRejectsOperationConflict(t *testing.T) { + st := openTestStore(t) + conversation := seedConversation(t, st) + input := deliveryBeginFixture(conversation, "operation-freeze") + + first, err := st.BeginDocumentDeliveryAccountChecked(OwnerDefault, input, true) + if err != nil { + t.Fatal(err) + } + second, err := st.BeginDocumentDeliveryAccountChecked(OwnerDefault, input, true) + if err != nil { + t.Fatal(err) + } + if first.FrozenAt.IsZero() || !first.FrozenAt.Equal(second.FrozenAt) || first.State != DocumentDeliveryFrozen { + t.Fatalf("freeze records differ: first=%#v second=%#v", first, second) + } + + conflict := input + conflict.RequestSHA256 = hashText("different request") + if _, err := st.BeginDocumentDeliveryAccountChecked(OwnerDefault, conflict, true); !errors.Is(err, ErrDocumentDeliveryConflict) { + t.Fatalf("conflicting operation error = %v, want ErrDocumentDeliveryConflict", err) + } +} + +func TestDocumentDeliveryPersistsMarkdownFirstAndCommitsDerivedSetAtomically(t *testing.T) { + st := openTestStore(t) + conversation := seedConversation(t, st) + input := deliveryBeginFixture(conversation, "operation-complete") + record, err := st.BeginDocumentDeliveryAccountChecked(OwnerDefault, input, true) + if err != nil { + t.Fatal(err) + } + markdown := deliveryArtifactFixture(DocumentArtifactMarkdown, "report.md", "text/markdown; charset=utf-8", []byte("# report\n")) + record, err = st.PersistDocumentDeliveryMarkdownAccountChecked(OwnerDefault, input.OperationID, markdown, hashText("canonical"), true) + if err != nil { + t.Fatal(err) + } + if record.State != DocumentDeliverySourceReady || len(record.Artifacts) != 1 || record.Artifacts[0].Role != DocumentArtifactMarkdown { + t.Fatalf("source receipt = %#v", record) + } + if raw, err := st.ArtifactContent(OwnerDefault, record.Artifacts[0].Artifact.ID); err != nil || string(raw) != "# report\n" { + t.Fatalf("persisted Markdown = %q err=%v", raw, err) + } + + derived := []DocumentDeliveryArtifactInput{ + deliveryArtifactFixture(DocumentArtifactDOCX, "report.docx", "application/vnd.openxmlformats-officedocument.wordprocessingml.document", []byte("docx")), + deliveryArtifactFixture(DocumentArtifactManifest, "report.manifest.json", "application/json", []byte("manifest")), + deliveryArtifactFixture(DocumentArtifactArchive, "report.zip", "application/zip", []byte("archive")), + } + record, err = st.CommitDocumentDeliveryDerivedAccountChecked(OwnerDefault, input.OperationID, "delivery-key", "profile-hash", "review-hash", derived, true) + if err != nil { + t.Fatal(err) + } + if record.State != DocumentDeliveryComplete || len(record.Artifacts) != 4 || record.DeliveryKey != "delivery-key" { + t.Fatalf("complete receipt = %#v", record) + } + firstIDs := deliveryArtifactIDs(record.Artifacts) + retry, err := st.CommitDocumentDeliveryDerivedAccountChecked(OwnerDefault, input.OperationID, "delivery-key", "profile-hash", "review-hash", derived, true) + if err != nil || !reflect.DeepEqual(firstIDs, deliveryArtifactIDs(retry.Artifacts)) { + t.Fatalf("idempotent derived retry = %#v err=%v", retry, err) + } + artifacts, err := st.ListArtifacts(OwnerDefault, string(conversation.ProjectID)) + if err != nil || len(artifacts) != 4 { + t.Fatalf("visible artifact set = %d err=%v", len(artifacts), err) + } +} + +func TestDocumentDeliveryFailureAfterEveryWriteIsDurableAndRetryable(t *testing.T) { + stages := []string{ + DocumentDeliveryFaultAfterMarkdownBlob, + DocumentDeliveryFaultBeforeMarkdownCommit, + DocumentDeliveryFaultAfterDOCXBlob, + DocumentDeliveryFaultAfterManifestBlob, + DocumentDeliveryFaultAfterArchiveBlob, + DocumentDeliveryFaultBeforeDerivedCommit, + DocumentDeliveryFaultAfterDerivedCommit, + } + for _, stage := range stages { + t.Run(stage, func(t *testing.T) { + st := openTestStore(t) + conversation := seedConversation(t, st) + operationID := "fault-" + stage + input := deliveryBeginFixture(conversation, operationID) + if _, err := st.BeginDocumentDeliveryAccountChecked(OwnerDefault, input, true); err != nil { + t.Fatal(err) + } + markdown := deliveryArtifactFixture(DocumentArtifactMarkdown, "fault.md", "text/markdown", []byte("source")) + derived := []DocumentDeliveryArtifactInput{ + deliveryArtifactFixture(DocumentArtifactDOCX, "fault.docx", "application/vnd.openxmlformats-officedocument.wordprocessingml.document", []byte("docx")), + deliveryArtifactFixture(DocumentArtifactManifest, "fault.manifest.json", "application/json", []byte("manifest")), + deliveryArtifactFixture(DocumentArtifactArchive, "fault.zip", "application/zip", []byte("archive")), + } + st.SetDocumentDeliveryFault(stage, errors.New("injected "+stage)) + var receipt DocumentDeliveryRecord + var err error + if stage == DocumentDeliveryFaultAfterMarkdownBlob || stage == DocumentDeliveryFaultBeforeMarkdownCommit { + receipt, err = st.PersistDocumentDeliveryMarkdownAccountChecked(OwnerDefault, operationID, markdown, hashText("canonical"), true) + } else { + if _, err = st.PersistDocumentDeliveryMarkdownAccountChecked(OwnerDefault, operationID, markdown, hashText("canonical"), true); err != nil { + t.Fatal(err) + } + receipt, err = st.CommitDocumentDeliveryDerivedAccountChecked(OwnerDefault, operationID, "delivery-key", "profile-hash", "review-hash", derived, true) + } + if err == nil || receipt.OperationID != operationID { + t.Fatalf("fault receipt=%#v err=%v", receipt, err) + } + if stage == DocumentDeliveryFaultAfterDerivedCommit { + if !errors.Is(err, ErrDocumentDeliveryOutcomeUnknown) || receipt.State != DocumentDeliveryComplete { + t.Fatalf("post-commit outcome=%#v err=%v", receipt, err) + } + } else if stage != DocumentDeliveryFaultAfterMarkdownBlob && stage != DocumentDeliveryFaultBeforeMarkdownCommit && receipt.MarkdownArtifactID == "" { + t.Fatalf("derived failure lost authoritative Markdown: %#v", receipt) + } + visible, listErr := st.ListArtifacts(OwnerDefault, string(conversation.ProjectID)) + wantVisible := 1 + if stage == DocumentDeliveryFaultAfterMarkdownBlob || stage == DocumentDeliveryFaultBeforeMarkdownCommit { + wantVisible = 0 + } + if stage == DocumentDeliveryFaultAfterDerivedCommit { + wantVisible = 4 + } + if listErr != nil || len(visible) != wantVisible { + t.Fatalf("failure exposed %d artifacts, want %d: %v", len(visible), wantVisible, listErr) + } + + st.SetDocumentDeliveryFault("", nil) + if receipt.MarkdownArtifactID == "" { + if _, err := st.PersistDocumentDeliveryMarkdownAccountChecked(OwnerDefault, operationID, markdown, hashText("canonical"), true); err != nil { + t.Fatal(err) + } + } + complete, err := st.CommitDocumentDeliveryDerivedAccountChecked(OwnerDefault, operationID, "delivery-key", "profile-hash", "review-hash", derived, true) + if err != nil || complete.State != DocumentDeliveryComplete || len(complete.Artifacts) != 4 { + t.Fatalf("retry did not complete: %#v err=%v", complete, err) + } + }) + } +} + +func TestDocumentDeliveryRetryAfterRestartReturnsSameIDsAndHashes(t *testing.T) { + directory := t.TempDir() + database := filepath.Join(directory, "delivery.db") + st, err := OpenSQLite(database) + if err != nil { + t.Fatal(err) + } + project, err := st.CreateProject(OwnerDefault, "delivery") + if err != nil { + t.Fatal(err) + } + conversation, err := st.CreateConversation(OwnerDefault, project.ID, "delivery", "") + if err != nil { + t.Fatal(err) + } + input := deliveryBeginFixture(conversation, "restart-operation") + if _, err := st.BeginDocumentDeliveryAccountChecked(OwnerDefault, input, true); err != nil { + t.Fatal(err) + } + markdown := deliveryArtifactFixture(DocumentArtifactMarkdown, "restart.md", "text/markdown", []byte("source")) + if _, err := st.PersistDocumentDeliveryMarkdownAccountChecked(OwnerDefault, input.OperationID, markdown, hashText("canonical"), true); err != nil { + t.Fatal(err) + } + derived := []DocumentDeliveryArtifactInput{ + deliveryArtifactFixture(DocumentArtifactDOCX, "restart.docx", "application/vnd.openxmlformats-officedocument.wordprocessingml.document", []byte("docx")), + deliveryArtifactFixture(DocumentArtifactManifest, "restart.manifest.json", "application/json", []byte("manifest")), + deliveryArtifactFixture(DocumentArtifactArchive, "restart.zip", "application/zip", []byte("archive")), + } + first, err := st.CommitDocumentDeliveryDerivedAccountChecked(OwnerDefault, input.OperationID, "restart-key", "profile", "review", derived, true) + if err != nil { + t.Fatal(err) + } + if err := st.Close(); err != nil { + t.Fatal(err) + } + + reopened, err := OpenSQLite(database) + if err != nil { + t.Fatal(err) + } + defer reopened.Close() + begin, err := reopened.BeginDocumentDeliveryAccountChecked(OwnerDefault, input, true) + if err != nil { + t.Fatal(err) + } + retry, err := reopened.CommitDocumentDeliveryDerivedAccountChecked(OwnerDefault, input.OperationID, "restart-key", "profile", "review", derived, true) + if err != nil || !begin.FrozenAt.Equal(first.FrozenAt) || !reflect.DeepEqual(deliveryArtifactIDs(first.Artifacts), deliveryArtifactIDs(retry.Artifacts)) { + t.Fatalf("restart retry changed identity: first=%#v begin=%#v retry=%#v err=%v", first, begin, retry, err) + } +} + +func deliveryBeginFixture(conversation core.Conversation, operationID string) DocumentDeliveryBeginInput { + return DocumentDeliveryBeginInput{ + OperationID: operationID, RequestSHA256: hashText("request-" + operationID), + ProjectID: string(conversation.ProjectID), ConversationID: string(conversation.ID), + SourceRun: "run-1", DocumentID: "document-1", Mode: "preview", RendererIdentity: "renderer@revision", + } +} + +func deliveryArtifactFixture(role DocumentDeliveryArtifactRole, name, mime string, content []byte) DocumentDeliveryArtifactInput { + return DocumentDeliveryArtifactInput{Role: role, Name: name, Kind: "document", MIME: mime, SHA256: hashBytesForTest(content), Content: content} +} + +func deliveryArtifactIDs(artifacts []DocumentDeliveryArtifact) map[DocumentDeliveryArtifactRole]string { + ids := make(map[DocumentDeliveryArtifactRole]string, len(artifacts)) + for _, artifact := range artifacts { + ids[artifact.Role] = string(artifact.Artifact.ID) + ":" + artifact.SHA256 + } + return ids +} + +func hashText(value string) string { return hashBytesForTest([]byte(value)) } + +func hashBytesForTest(value []byte) string { + sum := sha256.Sum256(value) + return hex.EncodeToString(sum[:]) +} diff --git a/internal/store/migrate.go b/internal/store/migrate.go index c5e0c92..9e6ab70 100644 --- a/internal/store/migrate.go +++ b/internal/store/migrate.go @@ -1145,6 +1145,29 @@ func init() { "sqlite": {`DROP INDEX IF EXISTS idx_human_decisions_pending`, `DROP TABLE IF EXISTS human_decisions`}, "postgres": {`DROP INDEX IF EXISTS idx_human_decisions_pending`, `DROP TABLE IF EXISTS human_decisions`}, }}, + migration{version: 47, name: "document_render_deliveries", + up: map[string][]string{ + "sqlite": {`CREATE TABLE document_render_deliveries ( + operation_id TEXT NOT NULL,owner TEXT NOT NULL,project_id TEXT NOT NULL,conversation_id TEXT NOT NULL,source_run TEXT NOT NULL DEFAULT '', + request_sha256 TEXT NOT NULL,state TEXT NOT NULL,frozen_at TEXT NOT NULL,renderer_identity TEXT NOT NULL,mode TEXT NOT NULL,document_id TEXT NOT NULL, + canonical_hash TEXT NOT NULL DEFAULT '',profile_hash TEXT NOT NULL DEFAULT '',review_hash TEXT NOT NULL DEFAULT '',delivery_key TEXT NOT NULL DEFAULT '', + markdown_artifact_id TEXT NOT NULL DEFAULT '',markdown_sha256 TEXT NOT NULL DEFAULT '',docx_artifact_id TEXT NOT NULL DEFAULT '',docx_sha256 TEXT NOT NULL DEFAULT '', + manifest_artifact_id TEXT NOT NULL DEFAULT '',manifest_sha256 TEXT NOT NULL DEFAULT '',archive_artifact_id TEXT NOT NULL DEFAULT '',archive_sha256 TEXT NOT NULL DEFAULT '', + error_text TEXT NOT NULL DEFAULT '',created_at TEXT NOT NULL,updated_at TEXT NOT NULL,PRIMARY KEY(owner,operation_id))`, + `CREATE INDEX idx_document_render_delivery_key ON document_render_deliveries(owner,project_id,delivery_key)`}, + "postgres": {`CREATE TABLE document_render_deliveries ( + operation_id TEXT NOT NULL,owner TEXT NOT NULL,project_id TEXT NOT NULL,conversation_id TEXT NOT NULL,source_run TEXT NOT NULL DEFAULT '', + request_sha256 TEXT NOT NULL,state TEXT NOT NULL,frozen_at TEXT NOT NULL,renderer_identity TEXT NOT NULL,mode TEXT NOT NULL,document_id TEXT NOT NULL, + canonical_hash TEXT NOT NULL DEFAULT '',profile_hash TEXT NOT NULL DEFAULT '',review_hash TEXT NOT NULL DEFAULT '',delivery_key TEXT NOT NULL DEFAULT '', + markdown_artifact_id TEXT NOT NULL DEFAULT '',markdown_sha256 TEXT NOT NULL DEFAULT '',docx_artifact_id TEXT NOT NULL DEFAULT '',docx_sha256 TEXT NOT NULL DEFAULT '', + manifest_artifact_id TEXT NOT NULL DEFAULT '',manifest_sha256 TEXT NOT NULL DEFAULT '',archive_artifact_id TEXT NOT NULL DEFAULT '',archive_sha256 TEXT NOT NULL DEFAULT '', + error_text TEXT NOT NULL DEFAULT '',created_at TEXT NOT NULL,updated_at TEXT NOT NULL,PRIMARY KEY(owner,operation_id))`, + `CREATE INDEX idx_document_render_delivery_key ON document_render_deliveries(owner,project_id,delivery_key)`}, + }, + down: map[string][]string{ + "sqlite": {`DROP INDEX IF EXISTS idx_document_render_delivery_key`, `DROP TABLE IF EXISTS document_render_deliveries`}, + "postgres": {`DROP INDEX IF EXISTS idx_document_render_delivery_key`, `DROP TABLE IF EXISTS document_render_deliveries`}, + }}, ) } diff --git a/internal/store/migrate_compat.go b/internal/store/migrate_compat.go index da387c2..e56782c 100644 --- a/internal/store/migrate_compat.go +++ b/internal/store/migrate_compat.go @@ -53,6 +53,7 @@ var migrationBreaksOldReaders = map[int]bool{ 44: false, // project_audit_all_writers_guard：PG 在线审计写入门禁，旧读者兼容 45: false, // project_work_observation_outbox：独立私域投递表，旧读者不读取 46: false, // human_decision_proofs：独立真人确认表，旧读者不读取 + 47: false, // document_render_deliveries：新增普通工作区文档交付回执表 } // SchemaTarget 是本二进制会迁移到的 schema 版本。 diff --git a/internal/store/migrate_compat_test.go b/internal/store/migrate_compat_test.go index ebfcb17..b41aa8a 100644 --- a/internal/store/migrate_compat_test.go +++ b/internal/store/migrate_compat_test.go @@ -39,6 +39,7 @@ func TestMigrationTailKeepsAdoptedExecEnvBeforeFeatureHistory(t *testing.T) { {44, "project_audit_all_writers_guard"}, {45, "project_work_observation_outbox"}, {46, "human_decision_proofs"}, + {47, "document_render_deliveries"}, } for _, item := range want { if got, ok := MigrationName(item.version); !ok || got != item.name { diff --git a/internal/store/store.go b/internal/store/store.go index 5d30b74..c5f46bf 100644 --- a/internal/store/store.go +++ b/internal/store/store.go @@ -79,6 +79,10 @@ type Store struct { migrateFault error // 非空时 migratePass 在「DDL 已执行、版本未登记」处失败（原子性测试） accountFault error // 非空时账户事务在提交前失败（半态测试） + documentDeliveryMu sync.Mutex + documentDeliveryFaultStage string + documentDeliveryFault error + vecPGOnce sync.Once // pgvector 列探测（U6-3：一次性缓存） vecPG bool } diff --git a/internal/tools/document_renderer.go b/internal/tools/document_renderer.go index a80e305..c3c7a83 100644 --- a/internal/tools/document_renderer.go +++ b/internal/tools/document_renderer.go @@ -2,12 +2,12 @@ package tools import ( "bytes" + "context" "encoding/json" "errors" "fmt" "io" "strings" - "time" "agent-document-renderer/render" "agent-system-backend/internal/docgen" @@ -18,27 +18,31 @@ func registerDocumentRenderer(r *Registry) error { return r.Register(core.ToolDesc{ Name: "render_document", Source: core.SourceBuiltin, Edits: true, Risk: "medium", Description: "把普通工作区 Markdown 通过统一文档渲染器生成 Markdown、DOCX、manifest 和可下载归档。只允许非受控工作区交付；项目受控文档必须交给 RDM。公司默认规则仍是待视觉评审候选，状态会写入 manifest。", - Parameters: json.RawMessage(`{"type":"object","properties":{` + - `"name":{"type":"string"},"documentId":{"type":"string"},"documentType":{"type":"string"},` + + Parameters: json.RawMessage(`{"type":"object","additionalProperties":false,"properties":{` + + `"operationId":{"type":"string"},"name":{"type":"string"},"documentId":{"type":"string"},"documentType":{"type":"string"},` + `"language":{"type":"string"},"markdown":{"type":"string"},` + - `"mode":{"type":"string","enum":["working","preview"]},"frozenAt":{"type":"string"},` + + `"mode":{"type":"string","enum":["working","preview"]},` + `"controlled":{"type":"boolean"},"projectDocument":{"type":"boolean"}` + - `},"required":["name","documentId","markdown","frozenAt","controlled","projectDocument"]}`), + `},"required":["operationId","name","documentId","markdown","controlled","projectDocument"]}`), }, executeDocumentRenderer) } type documentRendererArgs struct { + OperationID string `json:"operationId"` Name string `json:"name"` DocumentID string `json:"documentId"` DocumentType string `json:"documentType"` Language string `json:"language"` Markdown string `json:"markdown"` Mode string `json:"mode"` - FrozenAt string `json:"frozenAt"` Controlled *bool `json:"controlled"` ProjectDocument *bool `json:"projectDocument"` } +type documentDeliveryHost interface { + ExecuteDocumentDelivery(context.Context, docgen.OperationRequest) (docgen.OperationReceipt, error) +} + func executeDocumentRenderer(rc ToolExecCtx, raw json.RawMessage) (string, error) { var args documentRendererArgs decoder := json.NewDecoder(bytes.NewReader(raw)) @@ -50,19 +54,18 @@ func executeDocumentRenderer(rc ToolExecCtx, raw json.RawMessage) (string, error if err := decoder.Decode(&extra); !errors.Is(err, io.EOF) { return "", errors.New("render_document: arguments must contain one JSON object") } - if strings.TrimSpace(args.Name) == "" || strings.TrimSpace(args.DocumentID) == "" || strings.TrimSpace(args.Markdown) == "" { - return "", errors.New("render_document: name, documentId, and markdown are required") + if strings.TrimSpace(args.OperationID) == "" || strings.TrimSpace(args.Name) == "" || strings.TrimSpace(args.DocumentID) == "" || strings.TrimSpace(args.Markdown) == "" { + return "", errors.New("render_document: operationId, name, documentId, and markdown are required") } if args.Controlled == nil || args.ProjectDocument == nil { return "", errors.New("render_document: controlled and projectDocument must be explicit") } + if *args.Controlled || *args.ProjectDocument { + return "", docgen.ErrRDMRequired + } if strings.TrimSpace(rc.OwnerID()) == "" { return "", errors.New("render_document: trusted requester identity is required") } - frozenAt, err := time.Parse(time.RFC3339Nano, args.FrozenAt) - if err != nil { - return "", fmt.Errorf("render_document: frozenAt must be RFC3339: %w", err) - } mode := render.Mode(args.Mode) if mode == "" { mode = render.ModePreview @@ -78,40 +81,21 @@ func executeDocumentRenderer(rc ToolExecCtx, raw json.RawMessage) (string, error if language == "" { language = "zh-CN" } - delivery, err := docgen.Generate(execParentCtx(rc), docgen.Request{ - DocumentID: args.DocumentID, Title: args.Name, DocumentType: documentType, Language: language, - Markdown: []byte(args.Markdown), Mode: mode, FrozenAt: frozenAt.UTC(), RequestedBy: rc.OwnerID(), + host, ok := rc.(documentDeliveryHost) + if !ok { + return "", errors.New("render_document: trusted delivery host is unavailable") + } + receipt, err := host.ExecuteDocumentDelivery(execParentCtx(rc), docgen.OperationRequest{ + OperationID: args.OperationID, DocumentID: args.DocumentID, Title: args.Name, + DocumentType: documentType, Language: language, Markdown: []byte(args.Markdown), Mode: mode, Controlled: *args.Controlled, ProjectDocument: *args.ProjectDocument, }) + encoded, marshalErr := json.Marshal(receipt) + if marshalErr != nil { + return "", marshalErr + } if err != nil { - return "", fmt.Errorf("render_document: %w", err) - } - - artifacts := []docgen.Artifact{delivery.Markdown, delivery.DOCX, delivery.Manifest, delivery.Archive} - for _, item := range artifacts { - if err := checkToolExternalEffect(rc); err != nil { - return "", fmt.Errorf("render_document: permission recheck before %s: %w", item.Name, err) - } - if _, err := rc.WriteArtifact(item.Name, artifactKindOf(item.Name, item.MIME), item.MIME, item.Bytes); err != nil { - return "", fmt.Errorf("render_document: persist %s: %w", item.Name, err) - } - } - type outputArtifact struct { - Name string `json:"name"` - SHA256 string `json:"sha256"` - Size int `json:"size"` - } - output := struct { - ProfileStatus string `json:"profileStatus"` - PublicationAllowed bool `json:"publicationAllowed"` - Artifacts []outputArtifact `json:"artifacts"` - }{ProfileStatus: delivery.Profile.ReviewStatus, PublicationAllowed: delivery.Profile.PublicationAllowed} - for _, item := range artifacts { - output.Artifacts = append(output.Artifacts, outputArtifact{Name: item.Name, SHA256: item.SHA256, Size: len(item.Bytes)}) - } - encoded, err := json.Marshal(output) - if err != nil { - return "", err + return "", fmt.Errorf("render_document: %s", encoded) } return string(encoded), nil } diff --git a/internal/tools/document_renderer_test.go b/internal/tools/document_renderer_test.go index e9fe212..653bc3b 100644 --- a/internal/tools/document_renderer_test.go +++ b/internal/tools/document_renderer_test.go @@ -2,11 +2,10 @@ package tools import ( "context" - "crypto/sha256" - "encoding/hex" "encoding/json" "strings" "testing" + "time" "agent-system-backend/internal/docgen" core "agent-system-core" @@ -20,6 +19,8 @@ type capturedArtifact struct { type documentRendererCtx struct { ctx context.Context artifacts []capturedArtifact + receipt docgen.OperationReceipt + err error } func (c *documentRendererCtx) ProjectID() string { return "conversation-project" } @@ -47,6 +48,9 @@ func (c *documentRendererCtx) WriteArtifact(name, kind, mime string, content []b c.artifacts = append(c.artifacts, capturedArtifact{metadata: artifact, content: append([]byte(nil), content...)}) return artifact, nil } +func (c *documentRendererCtx) ExecuteDocumentDelivery(context.Context, docgen.OperationRequest) (docgen.OperationReceipt, error) { + return c.receipt, c.err +} func TestRenderDocumentToolWritesMarkdownFirstAndReportsPackageHashes(t *testing.T) { registry := NewRegistry() @@ -54,34 +58,91 @@ func TestRenderDocumentToolWritesMarkdownFirstAndReportsPackageHashes(t *testing t.Fatal(err) } arguments, _ := json.Marshal(map[string]any{ - "name": "研发纪要", "documentId": "workspace-minutes", "documentType": "general", "language": "zh-CN", - "markdown": "# 研发纪要\n\n正文。\n", "mode": "preview", "frozenAt": "2026-10-15T12:00:00Z", + "operationId": "operation-1", "name": "研发纪要", "documentId": "workspace-minutes", "documentType": "general", "language": "zh-CN", + "markdown": "# 研发纪要\n\n正文。\n", "mode": "preview", "controlled": false, "projectDocument": false, }) - ctx := &documentRendererCtx{} + ctx := &documentRendererCtx{receipt: docgen.OperationReceipt{ + OperationID: "operation-1", Outcome: "complete", State: "complete", Renderer: docgen.RendererIdentity, + FrozenAt: time.Date(2026, 10, 15, 12, 0, 0, 0, time.UTC), + Artifacts: []docgen.ReceiptArtifact{ + {Role: "markdown", ID: "md", Name: "研发纪要.md", SHA256: strings.Repeat("a", 64)}, + {Role: "docx", ID: "docx", Name: "研发纪要.docx", SHA256: strings.Repeat("b", 64)}, + {Role: "manifest", ID: "manifest", Name: "研发纪要.manifest.json", SHA256: strings.Repeat("c", 64)}, + {Role: "archive", ID: "archive", Name: "研发纪要.zip", SHA256: strings.Repeat("d", 64)}, + }, + }} result := registry.Execute(ctx, core.ToolCallRequest{CallID: "render-1", Name: "render_document", Arguments: arguments}) if result.Status != "ok" { t.Fatalf("render_document: %s", result.Output) } - if len(ctx.artifacts) != 4 { - t.Fatalf("artifacts = %d, want Markdown, DOCX, manifest, archive", len(ctx.artifacts)) - } - wantSuffixes := []string{".md", ".docx", ".manifest.json", ".zip"} - for index, suffix := range wantSuffixes { - if !strings.HasSuffix(ctx.artifacts[index].metadata.Name, suffix) { - t.Errorf("artifact %d name = %q, want suffix %s", index, ctx.artifacts[index].metadata.Name, suffix) - } - sum := sha256.Sum256(ctx.artifacts[index].content) - if hash := hex.EncodeToString(sum[:]); !strings.Contains(result.Output, hash) { - t.Errorf("tool output omitted %s hash %s", suffix, hash) - } - } - var manifest docgen.Manifest - if err := json.Unmarshal(ctx.artifacts[2].content, &manifest); err != nil { + var receipt docgen.OperationReceipt + if err := json.Unmarshal([]byte(result.Output), &receipt); err != nil { t.Fatal(err) } - if manifest.Renderer.RequestedBy != "alice" || manifest.Renderer.FrozenAt.Format("2006-01-02T15:04:05Z07:00") != "2026-10-15T12:00:00Z" { - t.Fatalf("untrusted or unfrozen render identity: %#v", manifest.Renderer) + if receipt.OperationID != "operation-1" || receipt.Outcome != "complete" || len(receipt.Artifacts) != 4 || receipt.FrozenAt.IsZero() { + t.Fatalf("durable receipt = %#v", receipt) + } + for _, artifact := range receipt.Artifacts { + if !strings.Contains(result.Output, artifact.SHA256) { + t.Errorf("tool output omitted %s hash %s", artifact.Role, artifact.SHA256) + } + } +} + +func TestRenderDocumentToolSchemaIsClosedAndUsesOnlyOperationIdentity(t *testing.T) { + registry := NewRegistry() + if err := registry.RegisterBuiltin(); err != nil { + t.Fatal(err) + } + description, _, found := registry.Get("render_document") + if !found { + t.Fatal("render_document is not registered") + } + var schema struct { + AdditionalProperties *bool `json:"additionalProperties"` + Properties map[string]json.RawMessage `json:"properties"` + Required []string `json:"required"` + } + if err := json.Unmarshal(description.Parameters, &schema); err != nil { + t.Fatal(err) + } + if schema.AdditionalProperties == nil || *schema.AdditionalProperties { + t.Fatal("render_document schema is not closed") + } + if _, found := schema.Properties["operationId"]; !found { + t.Fatal("render_document schema omitted operationId") + } + if _, found := schema.Properties["frozenAt"]; found { + t.Fatal("render_document still accepts model-supplied frozenAt") + } + wantRequired := map[string]bool{"operationId": true, "name": true, "documentId": true, "markdown": true, "controlled": true, "projectDocument": true} + for _, name := range schema.Required { + delete(wantRequired, name) + } + if len(wantRequired) != 0 { + t.Fatalf("render_document required fields missing: %#v", wantRequired) + } + arguments := json.RawMessage(`{"operationId":"closed-schema","name":"Report","documentId":"report","markdown":"# Report\n","controlled":false,"projectDocument":false,"frozenAt":"2000-01-01T00:00:00Z"}`) + result := registry.Execute(&documentRendererCtx{}, core.ToolCallRequest{CallID: "closed-schema", Name: "render_document", Arguments: arguments}) + if result.Status != "error" || !strings.Contains(result.Output, `unknown field "frozenAt"`) { + t.Fatalf("model-supplied frozenAt was accepted: %#v", result) + } +} + +func TestPythonToolDescriptionDoesNotAdvertiseWordBypass(t *testing.T) { + registry := NewRegistry() + if err := RegisterInterpreterTools(registry); err != nil { + t.Fatal(err) + } + description, _, found := registry.Get("run_python") + if !found { + t.Fatal("run_python is not registered") + } + for _, forbidden := range []string{"python-docx", "生成文档", "docx_kit"} { + if strings.Contains(description.Description, forbidden) { + t.Fatalf("run_python description advertises Word bypass %q: %s", forbidden, description.Description) + } } } @@ -91,8 +152,8 @@ func TestRenderDocumentToolRequiresExplicitRouteDeclaration(t *testing.T) { t.Fatal(err) } arguments, _ := json.Marshal(map[string]any{ - "name": "未声明路由", "documentId": "ambiguous", "markdown": "# 文档\n", - "mode": "preview", "frozenAt": "2026-10-15T12:00:00Z", + "operationId": "operation-ambiguous", "name": "未声明路由", "documentId": "ambiguous", "markdown": "# 文档\n", + "mode": "preview", }) ctx := &documentRendererCtx{} result := registry.Execute(ctx, core.ToolCallRequest{CallID: "render-3", Name: "render_document", Arguments: arguments}) @@ -110,8 +171,8 @@ func TestRenderDocumentToolRejectsControlledRouteWithoutArtifacts(t *testing.T) t.Fatal(err) } arguments, _ := json.Marshal(map[string]any{ - "name": "受控文档", "documentId": "controlled", "documentType": "dhf", "language": "zh-CN", - "markdown": "# 受控文档\n", "mode": "preview", "frozenAt": "2026-10-15T12:00:00Z", + "operationId": "operation-controlled", "name": "受控文档", "documentId": "controlled", "documentType": "dhf", "language": "zh-CN", + "markdown": "# 受控文档\n", "mode": "preview", "controlled": true, "projectDocument": false, }) ctx := &documentRendererCtx{} diff --git a/internal/tools/docx_e2e_test.go b/internal/tools/docx_e2e_test.go index f8942a4..354a7fe 100644 --- a/internal/tools/docx_e2e_test.go +++ b/internal/tools/docx_e2e_test.go @@ -4,10 +4,11 @@ import ( "os" "os/exec" "path/filepath" + "strings" "testing" ) -func TestLegacyComparisonHousestyleBuildPassesOOXMLGate(t *testing.T) { +func TestLegacyHousestyleBuildCannotBeEnabledByEnvironment(t *testing.T) { py, err := exec.LookPath("python3") if err != nil { t.Skip("python3 not available") @@ -20,10 +21,6 @@ func TestLegacyComparisonHousestyleBuildPassesOOXMLGate(t *testing.T) { if _, err := os.Stat(filepath.Join(skill, "housestyle", "build.py")); err != nil { t.Skip("house-style skill is not in this checkout") } - probe := exec.Command(py, "-c", "import docx") - if out, err := probe.CombinedOutput(); err != nil { - t.Skipf("python-docx is not installed: %s", out) - } dir := t.TempDir() src := filepath.Join(dir, "summary.md") body := "# 摘要\n\n## 结论\n\n- 沙箱里可以直接生成 docx\n" @@ -33,15 +30,11 @@ func TestLegacyComparisonHousestyleBuildPassesOOXMLGate(t *testing.T) { cmd := exec.Command(py, "-m", "housestyle.build", src) cmd.Dir = dir cmd.Env = append(os.Environ(), "PYTHONPATH="+skill, "AGENT_SYSTEM_LEGACY_WORD_COMPARISON=1") - if out, err := cmd.CombinedOutput(); err != nil { - t.Fatalf("housestyle.build: %v\n%s", err, out) + if out, err := cmd.CombinedOutput(); err == nil || !strings.Contains(string(out), "disabled") { + t.Fatalf("housestyle.build environment bypass: %v\n%s", err, out) } docx := filepath.Join(dir, "summary.docx") - content, err := os.ReadFile(docx) - if err != nil { - t.Fatal(err) - } - if err := ooxmlStructuralCheck("summary.docx", content); err != nil { - t.Fatal(err) + if _, err := os.Stat(docx); !os.IsNotExist(err) { + t.Fatalf("disabled builder wrote %s: %v", docx, err) } } diff --git a/internal/tools/exec.go b/internal/tools/exec.go index 87363f7..a582435 100644 --- a/internal/tools/exec.go +++ b/internal/tools/exec.go @@ -10,6 +10,7 @@ package tools import ( "encoding/json" + "errors" "fmt" "os" "path/filepath" @@ -120,6 +121,9 @@ func execRegisterArtifact(rc ToolExecCtx, args json.RawMessage) (string, error) if err != nil { return "", fmt.Errorf("register_artifact: %w", err) } + if isWordBinaryName(abs) { + return "", errors.New("register_artifact: direct Word registration is forbidden; use render_document so Markdown, renderer provenance, manifest, and delivery receipt are preserved") + } st, err := os.Stat(abs) if err != nil { return "", fmt.Errorf("register_artifact: %s: %v", a.Path, err) diff --git a/internal/tools/exec_interpreter.go b/internal/tools/exec_interpreter.go index 35130e5..6064bfc 100644 --- a/internal/tools/exec_interpreter.go +++ b/internal/tools/exec_interpreter.go @@ -44,7 +44,7 @@ func RegisterInterpreterTools(r *Registry) error { } return r.Register(core.ToolDesc{ Name: "run_python", Source: core.SourceBuiltin, Risk: "medium", - Description: "执行 Python 脚本（python3，工作目录为会话工作区）：生成文档/表格/演示稿/数据处理的首选路径。脚本原样落盘执行；stdout/stderr 合并返回，超限头尾截断。基础层已提供 python-docx、openpyxl、python-pptx 等，可直接 import。缺的包用 python_env 申请，不要 pip install。交付物用 import housestyle（技能目录在环境变量 AGENT_SKILLS_DIR，house-style 已在 PYTHONPATH）。", + Description: "执行 Python 脚本（python3，工作目录为会话工作区）：用于数据处理以及 Excel、PowerPoint、图片生成。普通 Word 必须使用 render_document；register_artifact 会拒绝 Python 或其他任意来源生成的 DOC/DOCX。脚本原样落盘执行；stdout/stderr 合并返回，超限头尾截断。基础层提供 openpyxl、python-pptx 等；缺的包用 python_env 申请，不要 pip install。", Parameters: json.RawMessage(`{"type":"object","properties":{` + `"script":{"type":"string","description":"完整 Python 脚本（utf-8）"},` + `"timeout_sec":{"type":"integer","description":"超时秒数（默认 600，可自行设更长）"}}` + diff --git a/internal/tools/fs.go b/internal/tools/fs.go index 8171d76..8f84d7d 100644 --- a/internal/tools/fs.go +++ b/internal/tools/fs.go @@ -270,7 +270,7 @@ func mimeOfExt(name string) string { // 普通 Word 由 render_document 生成；其他带排版二进制由受控生成器产出后登记。 func rejectBinaryOfficeWrite(name string) error { switch strings.ToLower(filepath.Ext(name)) { - case ".doc", ".docx": + case ".doc", ".docx", ".docm", ".dotx", ".dotm": return fmt.Errorf("%s 是 Word 二进制扩展名，不能写入字符串；普通 Word 请用 render_document，项目或受控 Word 交给 RDM", filepath.Ext(name)) case ".xls", ".xlsx", ".xlsm", ".ppt", ".pptx", ".pdf": return fmt.Errorf("%s 是二进制文档扩展名，不能把字符串直接写成该文件；请用受控生成器产出后再登记", filepath.Ext(name)) @@ -278,3 +278,12 @@ func rejectBinaryOfficeWrite(name string) error { return nil } } + +func isWordBinaryName(name string) bool { + switch strings.ToLower(filepath.Ext(name)) { + case ".doc", ".docx", ".docm", ".dotx", ".dotm": + return true + default: + return false + } +} -- 2.54.0 From 6c01d00a3f0dd1b6a808f1b005f7427b94b6fe27 Mon Sep 17 00:00:00 2001 From: weichen Date: Thu, 15 Oct 2026 22:33:29 +0000 Subject: [PATCH 35/41] Close remaining Task 10 renderer review findings Why: Direct artifact registration trusted filename extensions, the shared renderer parity test used a reduced fixture, and migration comparison omitted canonical list/task/rule/alignment properties plus their Word presentation. Evidence: go test -count=1 ./...; go test -race ./internal/docgen ./internal/tools ./internal/runmgr; go vet ./...; go build ./...; PYTHONPATH=. python3 -m unittest tests.test_housestyle; git diff --check. Impact: Reject renamed WordprocessingML packages while preserving non-Word artifacts, pin the reviewed renderer semantics, and report canonical and DOCX presentation regressions as accidental differences. Refs: Task 10; /tmp/task10-backend-final-review-last.md --- deps/agent-document-renderer | 2 +- internal/docgen/comparison.go | 437 +++++++++++++++++- internal/docgen/docgen_test.go | 35 +- .../docgen/renderer_identity_generated.go | 2 +- internal/docgen/renderer_integration_test.go | 210 +++++++-- internal/tools/exec.go | 7 +- internal/tools/ooxmlgate.go | 16 + internal/tools/ooxmlgate_test.go | 63 +++ 8 files changed, 717 insertions(+), 55 deletions(-) diff --git a/deps/agent-document-renderer b/deps/agent-document-renderer index d5cd8c1..0d1c512 160000 --- a/deps/agent-document-renderer +++ b/deps/agent-document-renderer @@ -1 +1 @@ -Subproject commit d5cd8c126045a27d5a5cc5da23f64d3c737e116a +Subproject commit 0d1c5121d137be817db5f98d3c13320dfa919c8a diff --git a/internal/docgen/comparison.go b/internal/docgen/comparison.go index 8aca2d2..ad48558 100644 --- a/internal/docgen/comparison.go +++ b/internal/docgen/comparison.go @@ -10,6 +10,7 @@ import ( "errors" "fmt" "io" + "strconv" "strings" "agent-document-renderer/model" @@ -29,6 +30,36 @@ type comparisonBlock struct { Rows [][]string `json:"rows,omitempty"` } +type comparisonList struct { + Depth int `json:"depth"` + Ordered bool `json:"ordered"` + Start int `json:"start,omitempty"` + Items []comparisonListItem `json:"items"` +} + +type comparisonListItem struct { + Text string `json:"text"` + Checked string `json:"checked,omitempty"` +} + +type comparisonTask struct { + Text string `json:"text"` + Checked string `json:"checked"` +} + +type comparisonSemantics struct { + Lists []comparisonList `json:"lists"` + Tasks []comparisonTask `json:"tasks"` + ThematicBreaks int `json:"thematicBreaks"` + TableAlignments [][][]string `json:"tableAlignments"` +} + +type docxNumbering struct { + Level int `json:"level"` + Format string `json:"format"` + Start int `json:"start"` +} + type docxComparison struct { Paragraphs []string `json:"paragraphs"` PageSize map[string]string `json:"pageSize"` @@ -39,6 +70,10 @@ type docxComparison struct { ExternalLinks int `json:"externalLinks"` ForbiddenObject bool `json:"forbiddenObject"` Semantics map[string]bool `json:"semantics"` + Numbering []docxNumbering `json:"numbering"` + Tasks []comparisonTask `json:"tasks"` + ThematicRules int `json:"thematicRules"` + TableAlignments [][][]string `json:"tableAlignments"` } func compareLegacyAndShared(title string, source []byte, canonical model.CanonicalDocument, legacy, shared []byte) ComparisonReceipt { @@ -46,12 +81,23 @@ func compareLegacyAndShared(title string, source []byte, canonical model.Canonic legacyStructure := legacyComparisonStructure(string(source)) sharedStructure := canonicalComparisonStructure(canonical) receipt.Dimensions = append(receipt.Dimensions, compareExactDimension("canonical-structure", legacyStructure, sharedStructure, "")) + legacySemantics := sourceComparisonSemantics(string(source)) + sharedSemantics := canonicalComparisonSemantics(canonical) + receipt.Dimensions = append(receipt.Dimensions, + compareExactDimension("list-structure", legacySemantics.Lists, sharedSemantics.Lists, ""), + compareExactDimension("task-state", legacySemantics.Tasks, sharedSemantics.Tasks, ""), + compareExactDimension("thematic-break", legacySemantics.ThematicBreaks, sharedSemantics.ThematicBreaks, ""), + compareExactDimension("table-alignment", legacySemantics.TableAlignments, sharedSemantics.TableAlignments, ""), + ) legacyDOCX, legacyErr := inspectComparisonDOCX(legacy) sharedDOCX, sharedErr := inspectComparisonDOCX(shared) if legacyErr != nil || sharedErr != nil { detail := fmt.Sprintf("legacy=%v shared=%v", legacyErr, sharedErr) - for _, name := range []string{"visible-text", "page-layout", "header-footer", "node-bookmarks", "safe-links", "security-objects", "word-semantics"} { + for _, name := range []string{ + "visible-text", "page-layout", "header-footer", "node-bookmarks", "safe-links", "security-objects", "word-semantics", + "word-numbering", "word-task-state", "word-thematic-rule", "word-table-alignment", + } { receipt.Dimensions = append(receipt.Dimensions, ComparisonDimension{Name: name, Status: "unassessed", Detail: detail}) } return finishComparison(receipt) @@ -106,6 +152,10 @@ func compareLegacyAndShared(title string, source []byte, canonical model.Canonic receipt.Dimensions = append(receipt.Dimensions, compareExactDimension("security-objects", legacyDOCX.ForbiddenObject, sharedDOCX.ForbiddenObject, ""), compareExactDimension("word-semantics", legacyDOCX.Semantics, sharedDOCX.Semantics, ""), + compareExactDimension("word-numbering", legacyDOCX.Numbering, sharedDOCX.Numbering, ""), + compareExactDimension("word-task-state", legacyDOCX.Tasks, sharedDOCX.Tasks, ""), + compareExactDimension("word-thematic-rule", legacyDOCX.ThematicRules, sharedDOCX.ThematicRules, ""), + compareExactDimension("word-table-alignment", legacyDOCX.TableAlignments, sharedDOCX.TableAlignments, ""), ) return finishComparison(receipt) } @@ -205,6 +255,7 @@ func canonicalComparisonStructure(document model.CanonicalDocument) []comparison } entry.Rows = append(entry.Rows, values) } + case model.NodeThematicBreak: default: continue } @@ -230,6 +281,192 @@ func visibleLegacyRuns(runs []run) string { func normalizeComparisonText(value string) string { return strings.Join(strings.Fields(value), " ") } +func sourceComparisonSemantics(source string) comparisonSemantics { + document := parseMarkdown(source) + result := comparisonSemantics{} + for _, block := range document.blocks { + switch block.kind { + case bHR: + result.ThematicBreaks++ + case bTable: + rows := make([][]string, len(block.rows)) + for rowIndex, row := range block.rows { + rows[rowIndex] = make([]string, len(row)) + for cellIndex := range row { + alignment := "left" + if cellIndex < len(block.align) && block.align[cellIndex] != "" { + alignment = block.align[cellIndex] + } + rows[rowIndex][cellIndex] = alignment + } + } + result.TableAlignments = append(result.TableAlignments, rows) + } + } + + type openList struct { + indent int + ordered bool + index int + } + var stack []openList + inFence := false + fence := "" + for _, rawLine := range strings.Split(strings.ReplaceAll(source, "\r\n", "\n"), "\n") { + trimmed := strings.TrimSpace(rawLine) + if strings.HasPrefix(trimmed, "```") || strings.HasPrefix(trimmed, "~~~") { + marker := trimmed[:3] + if !inFence { + inFence, fence = true, marker + } else if marker == fence { + inFence, fence = false, "" + } + stack = nil + continue + } + if inFence { + continue + } + line, found := parseComparisonListLine(rawLine) + if !found { + stack = nil + continue + } + for len(stack) > 0 && stack[len(stack)-1].indent > line.indent { + stack = stack[:len(stack)-1] + } + if len(stack) > 0 && stack[len(stack)-1].indent == line.indent && stack[len(stack)-1].ordered != line.ordered { + stack = stack[:len(stack)-1] + } + if len(stack) == 0 || stack[len(stack)-1].indent != line.indent { + start := 0 + if line.ordered { + start = line.start + } + result.Lists = append(result.Lists, comparisonList{Depth: len(stack), Ordered: line.ordered, Start: start}) + stack = append(stack, openList{indent: line.indent, ordered: line.ordered, index: len(result.Lists) - 1}) + } + list := &result.Lists[stack[len(stack)-1].index] + text := normalizeComparisonText(visibleLegacyRuns(document.parseInline(line.text))) + list.Items = append(list.Items, comparisonListItem{Text: text, Checked: line.checked}) + if line.checked != "" { + result.Tasks = append(result.Tasks, comparisonTask{Text: text, Checked: line.checked}) + } + } + return result +} + +type comparisonListLine struct { + indent int + ordered bool + start int + checked string + text string +} + +func parseComparisonListLine(raw string) (comparisonListLine, bool) { + line := strings.TrimRight(raw, " \t") + indent := 0 + for indent < len(line) && line[indent] == ' ' { + indent++ + } + if indent < len(line) && line[indent] == '\t' { + return comparisonListLine{}, false + } + rest := line[indent:] + parsed := comparisonListLine{indent: indent, start: 1} + for _, marker := range []string{"- ", "* ", "+ "} { + if strings.HasPrefix(rest, marker) { + parsed.text = strings.TrimSpace(strings.TrimPrefix(rest, marker)) + if len(parsed.text) >= 3 && parsed.text[0] == '[' && parsed.text[2] == ']' && (parsed.text[1] == ' ' || parsed.text[1] == 'x' || parsed.text[1] == 'X') { + parsed.checked = strconv.FormatBool(parsed.text[1] == 'x' || parsed.text[1] == 'X') + parsed.text = strings.TrimSpace(parsed.text[3:]) + } + return parsed, true + } + } + digits := 0 + for digits < len(rest) && rest[digits] >= '0' && rest[digits] <= '9' { + digits++ + } + if digits == 0 || digits > 9 || digits+1 >= len(rest) || (rest[digits] != '.' && rest[digits] != ')') || rest[digits+1] != ' ' { + return comparisonListLine{}, false + } + value, err := strconv.Atoi(rest[:digits]) + if err != nil { + return comparisonListLine{}, false + } + parsed.start = value + parsed.ordered = true + parsed.text = strings.TrimSpace(rest[digits+2:]) + return parsed, true +} + +func canonicalComparisonSemantics(document model.CanonicalDocument) comparisonSemantics { + result := comparisonSemantics{} + var addList func(model.Node, int) + addList = func(list model.Node, depth int) { + ordered := nodePropertyValue(list, "ordered") == "true" + start := 0 + if ordered { + start = 1 + if value := nodePropertyValue(list, "start"); value != "" { + if parsed, err := strconv.Atoi(value); err == nil { + start = parsed + } + } + } + summary := comparisonList{Depth: depth, Ordered: ordered, Start: start} + for _, item := range list.Children { + checked := nodePropertyValue(item, "checked") + text := normalizeComparisonNodeText(item) + summary.Items = append(summary.Items, comparisonListItem{Text: text, Checked: checked}) + if checked != "" { + result.Tasks = append(result.Tasks, comparisonTask{Text: text, Checked: checked}) + } + } + result.Lists = append(result.Lists, summary) + for _, item := range list.Children { + for _, child := range item.Children { + if child.Kind == model.NodeList { + addList(child, depth+1) + } + } + } + } + for _, node := range document.Root.Children { + switch node.Kind { + case model.NodeList: + addList(node, 0) + case model.NodeThematicBreak: + result.ThematicBreaks++ + case model.NodeTable: + rows := make([][]string, len(node.Children)) + for rowIndex, row := range node.Children { + rows[rowIndex] = make([]string, len(row.Children)) + for cellIndex, cell := range row.Children { + alignment := nodePropertyValue(cell, "alignment") + if alignment == "" { + alignment = "left" + } + rows[rowIndex][cellIndex] = alignment + } + } + result.TableAlignments = append(result.TableAlignments, rows) + } + } + return result +} + +func nodePropertyValue(node model.Node, name string) string { + for _, property := range node.Properties { + if property.Name == name { + return property.Value + } + } + return "" +} + func inspectComparisonDOCX(raw []byte) (docxComparison, error) { reader, err := zip.NewReader(bytes.NewReader(raw), int64(len(raw))) if err != nil { @@ -255,6 +492,17 @@ func inspectComparisonDOCX(raw []byte) (docxComparison, error) { result := docxComparison{PageSize: map[string]string{}, Margins: map[string]string{}, Semantics: map[string]bool{}} decoder := xml.NewDecoder(bytes.NewReader(document)) var paragraph strings.Builder + type rawNumberedParagraph struct { + Level int + NumID string + Text string + } + var numbered []rawNumberedParagraph + inParagraph, inText, inCell, inParagraphBorder := false, false, false, false + paragraphLevel, paragraphNumID, cellAlignment := 0, "", "" + paragraphRule := false + var table [][]string + var row []string for { token, err := decoder.Token() if errors.Is(err, io.EOF) { @@ -266,6 +514,40 @@ func inspectComparisonDOCX(raw []byte) (docxComparison, error) { switch value := token.(type) { case xml.StartElement: switch value.Name.Local { + case "p": + inParagraph = true + paragraph.Reset() + paragraphLevel, paragraphNumID, paragraphRule = 0, "", false + case "t": + if inParagraph { + inText = true + } + case "numId": + if inParagraph { + paragraphNumID = xmlAttributeValue(value.Attr, "val") + } + case "ilvl": + if inParagraph { + paragraphLevel, _ = strconv.Atoi(xmlAttributeValue(value.Attr, "val")) + } + case "pBdr": + if inParagraph { + inParagraphBorder = true + } + case "bottom": + if inParagraphBorder { + paragraphRule = true + } + case "tbl": + table = nil + case "tr": + row = nil + case "tc": + inCell, cellAlignment = true, "" + case "jc": + if inCell { + cellAlignment = xmlAttributeValue(value.Attr, "val") + } case "pgSz": copyAttributes(result.PageSize, value.Attr, "w", "h", "orient") case "pgMar": @@ -274,16 +556,71 @@ func inspectComparisonDOCX(raw []byte) (docxComparison, error) { result.Bookmarks++ } case xml.CharData: - paragraph.Write(value) + if inText { + paragraph.Write(value) + } case xml.EndElement: - if value.Name.Local == "p" { - if text := normalizeComparisonText(paragraph.String()); text != "" { + switch value.Name.Local { + case "t": + inText = false + case "pBdr": + inParagraphBorder = false + case "p": + text := normalizeComparisonText(paragraph.String()) + if text != "" { result.Paragraphs = append(result.Paragraphs, text) } - paragraph.Reset() + if paragraphNumID != "" { + numbered = append(numbered, rawNumberedParagraph{Level: paragraphLevel, NumID: paragraphNumID, Text: text}) + switch { + case strings.HasPrefix(text, "☑"): + result.Tasks = append(result.Tasks, comparisonTask{Text: normalizeComparisonText(strings.TrimSpace(strings.TrimPrefix(text, "☑"))), Checked: "true"}) + case strings.HasPrefix(text, "☐"): + result.Tasks = append(result.Tasks, comparisonTask{Text: normalizeComparisonText(strings.TrimSpace(strings.TrimPrefix(text, "☐"))), Checked: "false"}) + } + } + if paragraphRule { + result.ThematicRules++ + } + inParagraph = false + case "tc": + if cellAlignment == "" { + cellAlignment = "left" + } + row = append(row, cellAlignment) + inCell = false + case "tr": + table = append(table, row) + case "tbl": + result.TableAlignments = append(result.TableAlignments, table) } } } + if len(numbered) > 0 { + numbering, found := parts["word/numbering.xml"] + if !found { + return docxComparison{}, errors.New("word/numbering.xml missing") + } + definitions, instances, err := inspectDOCXNumbering(numbering) + if err != nil { + return docxComparison{}, err + } + for _, paragraph := range numbered { + instance, found := instances[paragraph.NumID] + if !found { + return docxComparison{}, fmt.Errorf("numbering instance %s missing", paragraph.NumID) + } + level := definitions[instance.AbstractID][paragraph.Level] + start := level.Start + if start == 0 { + start = 1 + } + if override, found := instance.Overrides[paragraph.Level]; found { + start = override + } + result.Numbering = append(result.Numbering, docxNumbering{Level: paragraph.Level, Format: level.Format, Start: start}) + } + } for name, content := range parts { lower := strings.ToLower(name) if strings.HasPrefix(lower, "word/header") && strings.HasSuffix(lower, ".xml") { @@ -310,6 +647,96 @@ func inspectComparisonDOCX(raw []byte) (docxComparison, error) { return result, nil } +type docxNumberingLevel struct { + Format string + Start int +} + +type docxNumberingInstance struct { + AbstractID string + Overrides map[int]int +} + +func inspectDOCXNumbering(raw []byte) (map[string]map[int]docxNumberingLevel, map[string]docxNumberingInstance, error) { + definitions := map[string]map[int]docxNumberingLevel{} + instances := map[string]docxNumberingInstance{} + decoder := xml.NewDecoder(bytes.NewReader(raw)) + currentAbstract, currentInstance := "", "" + currentLevel, currentOverride := -1, -1 + for { + token, err := decoder.Token() + if errors.Is(err, io.EOF) { + return definitions, instances, nil + } + if err != nil { + return nil, nil, err + } + switch value := token.(type) { + case xml.StartElement: + switch value.Name.Local { + case "abstractNum": + currentAbstract = xmlAttributeValue(value.Attr, "abstractNumId") + definitions[currentAbstract] = map[int]docxNumberingLevel{} + case "lvl": + if currentAbstract != "" { + currentLevel, _ = strconv.Atoi(xmlAttributeValue(value.Attr, "ilvl")) + } + case "start": + if currentAbstract != "" && currentLevel >= 0 { + level := definitions[currentAbstract][currentLevel] + level.Start, _ = strconv.Atoi(xmlAttributeValue(value.Attr, "val")) + definitions[currentAbstract][currentLevel] = level + } + case "numFmt": + if currentAbstract != "" && currentLevel >= 0 { + level := definitions[currentAbstract][currentLevel] + level.Format = xmlAttributeValue(value.Attr, "val") + definitions[currentAbstract][currentLevel] = level + } + case "num": + currentInstance = xmlAttributeValue(value.Attr, "numId") + instances[currentInstance] = docxNumberingInstance{Overrides: map[int]int{}} + case "abstractNumId": + if currentInstance != "" { + instance := instances[currentInstance] + instance.AbstractID = xmlAttributeValue(value.Attr, "val") + instances[currentInstance] = instance + } + case "lvlOverride": + if currentInstance != "" { + currentOverride, _ = strconv.Atoi(xmlAttributeValue(value.Attr, "ilvl")) + } + case "startOverride": + if currentInstance != "" && currentOverride >= 0 { + instance := instances[currentInstance] + instance.Overrides[currentOverride], _ = strconv.Atoi(xmlAttributeValue(value.Attr, "val")) + instances[currentInstance] = instance + } + } + case xml.EndElement: + switch value.Name.Local { + case "lvl": + currentLevel = -1 + case "abstractNum": + currentAbstract = "" + case "lvlOverride": + currentOverride = -1 + case "num": + currentInstance = "" + } + } + } +} + +func xmlAttributeValue(attributes []xml.Attr, name string) string { + for _, attribute := range attributes { + if attribute.Name.Local == name { + return attribute.Value + } + } + return "" +} + func copyAttributes(target map[string]string, attributes []xml.Attr, names ...string) { wanted := make(map[string]bool, len(names)) for _, name := range names { diff --git a/internal/docgen/docgen_test.go b/internal/docgen/docgen_test.go index 1cd5228..67dae8d 100644 --- a/internal/docgen/docgen_test.go +++ b/internal/docgen/docgen_test.go @@ -9,37 +9,42 @@ import ( "testing" ) -// 样例正文：会议纪要形态（标题/表格/列表/任务项/引用/链接/删除线/分隔线）。 +// 样例正文：会议纪要形态，也是 legacy/shared 唯一完整语义奇偶性夹具。 // 行内代码用 \x60（反引号）拼接——raw string 里不能直接写字面反引号。 const sampleMinutes = "# 研发周会纪要\n" + ` ## 一、基本信息 -| 项目 | 内容 | -|---|---| -| 时间 | 2026-09-30 14:00 | -| 地点 | 3F 会议室 | -| 主持人 | 陈威 | +正文含 **粗体**、*强调*、~~删除~~、` + "\x60inline\x60" + ` 和 [安全标签](https://example.com/private-target)。 ## 二、讨论要点 -- **架构**：docx 生成走后端转换，见 [方案](https://example.com/plan) -- 排版要求：标题层级、表格、列表 - - 二级要点：交付物卡片 +- **架构**：共享渲染器 +- 排版要求 + 1. 有序子项 + - 深层无序子项 - [x] 已完成：预览装配 - [ ] 待办：样式打磨 > 会议结论：按周五节点交付。 +` + "\x60\x60\x60go" + ` +fmt.Println("backtick") +` + "\x60\x60\x60" + ` + +~~~go +fmt.Println("tilde") +~~~~ + ## 三、决议 -1. 采用 write_docx 工具 -2. 对话内出交付物卡片 - -` + "\x60write_docx\x60 与 ~~write_artifact~~ 的分工见上文。" + ` +3. 第三项 +4. 第四项 --- -后续：周报合并。 +| 左 | 中 | 右 | 默认 | +| :--- | :---: | ---: | --- | +| L | C | R | D | ` func buildSample(t *testing.T) []byte { @@ -166,7 +171,7 @@ func TestBuildHyperlinkRels(t *testing.T) { rc.Close() } } - if !strings.Contains(rels, `Id="rIdH1"`) || !strings.Contains(rels, "https://example.com/plan") { + if !strings.Contains(rels, `Id="rIdH1"`) || !strings.Contains(rels, "https://example.com/private-target") { t.Errorf("超链接 relationship 缺失: %s", rels) } } diff --git a/internal/docgen/renderer_identity_generated.go b/internal/docgen/renderer_identity_generated.go index f997072..cae3eec 100644 --- a/internal/docgen/renderer_identity_generated.go +++ b/internal/docgen/renderer_identity_generated.go @@ -2,6 +2,6 @@ package docgen -const rendererRevision = "d5cd8c126045a27d5a5cc5da23f64d3c737e116a" +const rendererRevision = "0d1c5121d137be817db5f98d3c13320dfa919c8a" const RendererIdentity = "agent-document-renderer@" + rendererRevision diff --git a/internal/docgen/renderer_integration_test.go b/internal/docgen/renderer_integration_test.go index ca670cb..d7d4074 100644 --- a/internal/docgen/renderer_integration_test.go +++ b/internal/docgen/renderer_integration_test.go @@ -60,23 +60,6 @@ func workspaceRequest(markdown []byte) Request { } } -const semanticMarkdown = `# **Semantic** report - -Paragraph with **bold**, *italic*, ~~strike~~, ` + "`inline code`" + `, and [safe **label**](https://example.com/private-target). - -> Quoted **evidence** with *emphasis*. - -` + "```go" + ` -fmt.Println("safe") -` + "```" + ` - -- **bold item** - -| Item | Meaning | -|---|---| -| ` + "`code cell`" + ` | [table label](#semantic) | -` - func TestGenerateProducesDeterministicHashedDeliveryPackage(t *testing.T) { request := workspaceRequest([]byte(representativeMarkdown)) first, err := Generate(context.Background(), request) @@ -207,14 +190,35 @@ func TestGeneratePersistsCanonicalMarkdownWithStableNodeParity(t *testing.T) { } } -func TestGeneratePreservesAllSharedSemanticMarkdownWithoutLinkTargetLeak(t *testing.T) { - request := workspaceRequest([]byte(semanticMarkdown)) - request.Title = "Semantic report" +func TestGeneratePreservesCompleteLegacyMarkdownContract(t *testing.T) { + request := workspaceRequest([]byte(sampleMinutes)) delivery, err := Generate(context.Background(), request) if err != nil { t.Fatal(err) } - var quote, code *model.Node + replayed, err := markdownrenderer.Parse(delivery.Markdown.Bytes, markdownrenderer.Options{ + MaxBytes: 2 << 20, MaxNodes: 10_000, MaxDepth: 64, + }) + if err != nil || !reflect.DeepEqual(delivery.Document, replayed.Document) { + t.Fatalf("complete legacy fixture did not replay canonically: err=%v", err) + } + + wantKinds := []model.NodeKind{ + model.NodeHeading, model.NodeHeading, model.NodeParagraph, + model.NodeHeading, model.NodeList, model.NodeQuote, + model.NodeCodeBlock, model.NodeCodeBlock, model.NodeHeading, + model.NodeList, model.NodeThematicBreak, model.NodeTable, + } + gotKinds := make([]model.NodeKind, len(delivery.Document.Root.Children)) + for index := range delivery.Document.Root.Children { + gotKinds[index] = delivery.Document.Root.Children[index].Kind + } + if !reflect.DeepEqual(gotKinds, wantKinds) { + t.Fatalf("canonical block kinds = %#v, want %#v", gotKinds, wantKinds) + } + + var quote *model.Node + var codes []*model.Node var hasStrong, hasEmphasis, hasStrike, hasInlineCode, hasLink bool var walkInline func([]model.Inline) walkInline = func(inlines []model.Inline) { @@ -240,7 +244,7 @@ func TestGeneratePreservesAllSharedSemanticMarkdownWithoutLinkTargetLeak(t *test quote = node } if node.Kind == model.NodeCodeBlock { - code = node + codes = append(codes, node) } walkInline(node.Inlines) for index := range node.Children { @@ -248,23 +252,71 @@ func TestGeneratePreservesAllSharedSemanticMarkdownWithoutLinkTargetLeak(t *test } } walk(&delivery.Document.Root) - if quote == nil || code == nil || !hasStrong || !hasEmphasis || !hasStrike || !hasInlineCode || !hasLink { - t.Fatalf("semantic canonical document incomplete: quote=%v code=%v strong=%v emphasis=%v strike=%v inlineCode=%v link=%v", quote != nil, code != nil, hasStrong, hasEmphasis, hasStrike, hasInlineCode, hasLink) + if quote == nil || len(codes) != 2 || !hasStrong || !hasEmphasis || !hasStrike || !hasInlineCode || !hasLink { + t.Fatalf("semantic canonical document incomplete: quote=%v codes=%d strong=%v emphasis=%v strike=%v inlineCode=%v link=%v", quote != nil, len(codes), hasStrong, hasEmphasis, hasStrike, hasInlineCode, hasLink) } + if codes[0].Text != "fmt.Println(\"backtick\")\n" || codes[1].Text != "fmt.Println(\"tilde\")\n" { + t.Fatalf("fenced code text = %q / %q", codes[0].Text, codes[1].Text) + } + + unordered := delivery.Document.Root.Children[4] + orderedChild := unordered.Children[1].Children[0] + deepBullet := orderedChild.Children[0].Children[0] + if nodePropertyValue(unordered, "ordered") != "false" || + nodePropertyValue(orderedChild, "ordered") != "true" || + nodePropertyValue(deepBullet, "ordered") != "false" { + t.Fatalf("nested list semantics = %#v / %#v / %#v", unordered.Properties, orderedChild.Properties, deepBullet.Properties) + } + if nodePropertyValue(unordered.Children[2], "checked") != "true" || nodePropertyValue(unordered.Children[3], "checked") != "false" { + t.Fatalf("task states = %#v / %#v", unordered.Children[2].Properties, unordered.Children[3].Properties) + } + ordered := delivery.Document.Root.Children[9] + if nodePropertyValue(ordered, "ordered") != "true" || nodePropertyValue(ordered, "start") != "3" { + t.Fatalf("ordered-list start = %#v, want 3", ordered.Properties) + } + table := delivery.Document.Root.Children[11] + wantAlignments := []string{"left", "center", "right", ""} + for rowIndex, row := range table.Children { + for cellIndex, cell := range row.Children { + if got := nodePropertyValue(cell, "alignment"); got != wantAlignments[cellIndex] { + t.Fatalf("row %d cell %d alignment = %q, want %q", rowIndex, cellIndex, got, wantAlignments[cellIndex]) + } + } + } + documentXML := docxPart(t, delivery.DOCX.Bytes, "word/document.xml") - for _, fragment := range []string{``, ``, ``, `w:val="inlineCode"`, `w:val="link"`, `w:val="quote"`, `w:val="code"`, ``, ``} { + for _, fragment := range []string{ + ``, ``, ``, `w:val="inlineCode"`, `w:val="link"`, + `w:val="quote"`, `w:val="code"`, ``, ``, + `☑ `, `☐ `, + ``, + ``, ``, + } { if !strings.Contains(documentXML, fragment) { t.Errorf("Word output missing %s", fragment) } } + numberingXML := docxPart(t, delivery.DOCX.Bytes, "word/numbering.xml") + for _, fragment := range []string{ + ``, ``, ``, + ``, + } { + if !strings.Contains(documentXML+numberingXML, fragment) { + t.Errorf("Word numbering missing %s", fragment) + } + } if bytes.Contains(delivery.DOCX.Bytes, []byte("https://example.com/private-target")) || strings.Contains(documentXML, "TargetMode=\"External\"") { t.Fatal("safe link target leaked into DOCX package") } - replayed := request - replayed.Markdown = delivery.Markdown.Bytes - second, err := Generate(context.Background(), replayed) - if err != nil || !reflect.DeepEqual(delivery.Document, second.Document) { - t.Fatalf("semantic Markdown did not replay canonically: err=%v", err) + legacy, err := legacyBuild(request.Title, sampleMinutes) + if err != nil { + t.Fatal(err) + } + receipt := compareLegacyAndShared(request.Title, []byte(sampleMinutes), delivery.Document, legacy, delivery.DOCX.Bytes) + for _, name := range []string{"list-structure", "task-state", "thematic-break", "table-alignment"} { + if dimension := comparisonDimension(t, receipt, name); dimension.Status != "match" { + t.Errorf("complete fixture comparison dimension %s = %#v, want match", name, dimension) + } } } @@ -308,7 +360,7 @@ func TestPersistedControlledMetadataRoutesBeforeDefaultProfileLoad(t *testing.T) } func TestRendererIdentityMatchesPublishedPin(t *testing.T) { - const want = "agent-document-renderer@d5cd8c126045a27d5a5cc5da23f64d3c737e116a" + const want = "agent-document-renderer@0d1c5121d137be817db5f98d3c13320dfa919c8a" if RendererIdentity != want { t.Fatalf("RendererIdentity = %q, want %q", RendererIdentity, want) } @@ -555,7 +607,7 @@ func TestLegacyComparisonIsExplicitAndDoesNotReplaceSharedOutput(t *testing.T) { } func TestRepresentativeLegacyComparisonRecordsOnlyIntentionalDifferences(t *testing.T) { - const common = "# 研发周会纪要\n\n正文有 **粗体**、*斜体*、~~删除~~、`代码` 和 [链接](https://example.com/private)。\n\n> 引用内容。\n\n```go\nfmt.Println(1)\n```\n\n## 要点\n\n- 统一解析入口\n- 保留 Markdown\n\n| 项目 | 状态 |\n|---|---|\n| 解析器 | 统一 |\n" + const common = "# 研发周会纪要\n\n正文有 **粗体**、*斜体*、~~删除~~、`代码` 和 [链接](https://example.com/private)。\n\n> 引用内容。\n\n```go\nfmt.Println(1)\n```\n\n## 要点\n\n- [x] 已完成\n- [ ] 待办\n\n1. 第一项\n2. 第二项\n\n---\n\n| 左 | 中 | 右 |\n| :--- | :---: | ---: |\n| L | C | R |\n" request := workspaceRequest([]byte(common)) delivery, err := generateWithOptions(context.Background(), request, RenderOptions{MigrationComparison: true}, defaultGeneratorDependencies()) if err != nil { @@ -575,6 +627,54 @@ func TestRepresentativeLegacyComparisonRecordsOnlyIntentionalDifferences(t *test t.Errorf("comparison omitted reviewed exception %s: %#v", id, delivery.Comparison.Dimensions) } } + for _, name := range []string{ + "list-structure", "task-state", "thematic-break", "table-alignment", + "word-numbering", "word-task-state", "word-thematic-rule", "word-table-alignment", + } { + dimension := comparisonDimension(t, delivery.Comparison, name) + if dimension.Status != "match" { + t.Errorf("comparison dimension %s = %#v, want match", name, dimension) + } + } +} + +func TestComparisonDetectsCanonicalAndDOCXTableAlignmentLoss(t *testing.T) { + const aligned = "# Alignment\n\n| Left | Center | Right | Default |\n| :--- | :---: | ---: | --- |\n| L | C | R | D |\n" + request := workspaceRequest([]byte(aligned)) + request.Title = "Alignment" + delivery, err := Generate(context.Background(), request) + if err != nil { + t.Fatal(err) + } + legacy, err := legacyBuild(request.Title, aligned) + if err != nil { + t.Fatal(err) + } + + canonicalWithoutAlignment := delivery.Document.Clone() + for rowIndex := range canonicalWithoutAlignment.Root.Children[1].Children { + for cellIndex := range canonicalWithoutAlignment.Root.Children[1].Children[rowIndex].Children { + canonicalWithoutAlignment.Root.Children[1].Children[rowIndex].Children[cellIndex].Properties = nil + } + } + canonicalLoss := compareLegacyAndShared(request.Title, []byte(aligned), canonicalWithoutAlignment, legacy, delivery.DOCX.Bytes) + if dimension := comparisonDimension(t, canonicalLoss, "table-alignment"); dimension.Status != "accidental" { + t.Fatalf("canonical table-alignment loss = %#v, want accidental", dimension) + } + + docxWithoutAlignment := rewriteDOCXPart(t, delivery.DOCX.Bytes, "word/document.xml", func(content []byte) []byte { + for _, value := range []string{"left", "center", "right"} { + content = bytes.ReplaceAll(content, []byte(``), nil) + } + return content + }) + docxLoss := compareLegacyAndShared(request.Title, []byte(aligned), delivery.Document, legacy, docxWithoutAlignment) + if docxLoss.Assessment != "differences" { + t.Fatalf("DOCX alignment loss assessment = %q, want differences", docxLoss.Assessment) + } + if dimension := comparisonDimension(t, docxLoss, "word-table-alignment"); dimension.Status != "accidental" { + t.Fatalf("DOCX table-alignment loss = %#v, want accidental", dimension) + } } func TestLegacyComparisonReportsAccidentalAndUnassessedDimensions(t *testing.T) { @@ -660,3 +760,49 @@ func docxPart(t *testing.T, raw []byte, name string) string { t.Fatalf("DOCX part %s missing", name) return "" } + +func comparisonDimension(t *testing.T, receipt ComparisonReceipt, name string) ComparisonDimension { + t.Helper() + for _, dimension := range receipt.Dimensions { + if dimension.Name == name { + return dimension + } + } + t.Fatalf("comparison dimension %s missing: %#v", name, receipt.Dimensions) + return ComparisonDimension{} +} + +func rewriteDOCXPart(t *testing.T, raw []byte, name string, rewrite func([]byte) []byte) []byte { + t.Helper() + reader, err := zip.NewReader(bytes.NewReader(raw), int64(len(raw))) + if err != nil { + t.Fatal(err) + } + var output bytes.Buffer + writer := zip.NewWriter(&output) + for _, file := range reader.File { + stream, err := file.Open() + if err != nil { + t.Fatal(err) + } + content, err := io.ReadAll(stream) + stream.Close() + if err != nil { + t.Fatal(err) + } + if file.Name == name { + content = rewrite(content) + } + target, err := writer.Create(file.Name) + if err != nil { + t.Fatal(err) + } + if _, err := target.Write(content); err != nil { + t.Fatal(err) + } + } + if err := writer.Close(); err != nil { + t.Fatal(err) + } + return output.Bytes() +} diff --git a/internal/tools/exec.go b/internal/tools/exec.go index a582435..3784bb2 100644 --- a/internal/tools/exec.go +++ b/internal/tools/exec.go @@ -28,6 +28,8 @@ const ( execSetting = "runtime.exec" ) +var errDirectWordRegistration = errors.New("register_artifact: direct Word registration is forbidden; use render_document so Markdown, renderer provenance, manifest, and delivery receipt are preserved") + // execHardOff 启动级硬关闭（组合根依启动参数设置）。runtime.exec 是用户可写的 // 业务设置，多用户部署时任何人都能把它改回 true；硬关闭不读设置，设置无法覆盖。 var execHardOff atomic.Bool @@ -122,7 +124,7 @@ func execRegisterArtifact(rc ToolExecCtx, args json.RawMessage) (string, error) return "", fmt.Errorf("register_artifact: %w", err) } if isWordBinaryName(abs) { - return "", errors.New("register_artifact: direct Word registration is forbidden; use render_document so Markdown, renderer provenance, manifest, and delivery receipt are preserved") + return "", errDirectWordRegistration } st, err := os.Stat(abs) if err != nil { @@ -138,6 +140,9 @@ func execRegisterArtifact(rc ToolExecCtx, args json.RawMessage) (string, error) if err != nil { return "", err } + if isWordprocessingMLPackage(b) { + return "", errDirectWordRegistration + } if err := ooxmlStructuralCheck(filepath.Base(abs), b); err != nil { return "", fmt.Errorf("register_artifact: %s 结构自检未通过：%v。请用 housestyle kit 重建（见 $AGENT_SKILLS_DIR/house-style/SKILL.md），不要用 zipfile 手工拼 OOXML", a.Path, err) } diff --git a/internal/tools/ooxmlgate.go b/internal/tools/ooxmlgate.go index e0cf467..292e995 100644 --- a/internal/tools/ooxmlgate.go +++ b/internal/tools/ooxmlgate.go @@ -44,6 +44,22 @@ func ooxmlStructuralCheck(name string, content []byte) error { } } +// isWordprocessingMLPackage identifies Word OPC packages from their mandatory +// main document part instead of trusting the caller-controlled filename. The +// part is shared by document/template and macro-enabled variants. +func isWordprocessingMLPackage(content []byte) bool { + zr, err := zip.NewReader(bytes.NewReader(content), int64(len(content))) + if err != nil { + return false + } + for _, file := range zr.File { + if strings.EqualFold(strings.TrimPrefix(file.Name, "/"), "word/document.xml") { + return true + } + } + return false +} + // ooxmlCheckParts 校验容器与必备正文部件存在、XML 合法、命名空间前缀齐备 // （docx/xlsx 底线）。 func ooxmlCheckParts(content []byte, parts ...string) error { diff --git a/internal/tools/ooxmlgate_test.go b/internal/tools/ooxmlgate_test.go index b6da748..b858435 100644 --- a/internal/tools/ooxmlgate_test.go +++ b/internal/tools/ooxmlgate_test.go @@ -3,6 +3,7 @@ package tools import ( "archive/zip" "bytes" + "encoding/json" "os" "path/filepath" "strings" @@ -349,3 +350,65 @@ func TestRegisterArtifactStructuralGate(t *testing.T) { t.Fatalf("valid pptx must register: %s %s", res.Status, res.Output) } } + +func TestRegisterArtifactRejectsRenamedWordprocessingMLPackages(t *testing.T) { + r := NewRegistry() + if err := RegisterExecTools(r); err != nil { + t.Fatal(err) + } + root := t.TempDir() + rc := &execFake{root: root, owner: "o1", conv: "c1", execOn: true} + sandbox := filepath.Join(root, "o1", "c1") + if err := os.MkdirAll(sandbox, 0o755); err != nil { + t.Fatal(err) + } + + wordTypes := []struct { + name string + contentType string + }{ + {"report.zip", "application/vnd.openxmlformats-officedocument.wordprocessingml.document.main+xml"}, + {"macro.bin", "application/vnd.ms-word.document.macroEnabled.main+xml"}, + {"template.data", "application/vnd.openxmlformats-officedocument.wordprocessingml.template.main+xml"}, + {"template.docx ", "application/vnd.ms-word.template.macroEnabledTemplate.main+xml"}, + } + for _, test := range wordTypes { + t.Run(test.name, func(t *testing.T) { + contentTypes := `` + pkg := zipOf(t, map[string]string{ + "[Content_Types].xml": contentTypes, + "word/document.xml": ``, + }) + if err := os.WriteFile(filepath.Join(sandbox, test.name), pkg, 0o644); err != nil { + t.Fatal(err) + } + res := interpCall(t, r, rc, "register_artifact", `{"path":`+mustJSON(t, test.name)+`}`) + if res.Status != "error" || !strings.Contains(res.Output, "direct Word registration is forbidden") { + t.Fatalf("renamed WordprocessingML package must be refused: %s %s", res.Status, res.Output) + } + }) + } + + allowed := map[string][]byte{ + "dataset.zip": zipOf(t, map[string]string{"data/payload.json": `{"ok":true}`}), + "payload.bin": {0x00, 0x01, 0x02, 0xff}, + } + for name, content := range allowed { + if err := os.WriteFile(filepath.Join(sandbox, name), content, 0o644); err != nil { + t.Fatal(err) + } + res := interpCall(t, r, rc, "register_artifact", `{"path":`+mustJSON(t, name)+`}`) + if res.Status != "ok" || !strings.Contains(res.Output, "已登记交付物") { + t.Fatalf("non-Word artifact %s must register: %s %s", name, res.Status, res.Output) + } + } +} + +func mustJSON(t *testing.T, value string) string { + t.Helper() + raw, err := json.Marshal(value) + if err != nil { + t.Fatal(err) + } + return string(raw) +} -- 2.54.0 From a2f4978be83514ae0e474039fb42b76bfc2a05d4 Mon Sep 17 00:00:00 2001 From: weichen Date: Thu, 15 Oct 2026 22:46:21 +0000 Subject: [PATCH 36/41] Detect Word packages from OPC metadata Why: The registration gate classified Word packages from a hard-coded ZIP member path, allowing alternate main-part paths to bypass the gate and rejecting unrelated ZIP archives. Evidence: Focused OPC registration tests; go test -count=1 ./internal/tools; go test -count=1 ./...; go test -race -count=1 ./internal/tools ./internal/runmgr; go vet ./...; go build ./...; git diff --check. Impact: Resolve package-level officeDocument targets safely, classify all conventional Word main content types through OPC defaults or overrides, and fail closed on malformed, ambiguous, external, or traversing metadata while preserving non-Word artifacts. Refs: Task 10; /tmp/task10-backend-final-closure-last.md --- internal/tools/ooxmlgate.go | 334 ++++++++++++++++++++++++++++++- internal/tools/ooxmlgate_test.go | 172 ++++++++++++++-- 2 files changed, 479 insertions(+), 27 deletions(-) diff --git a/internal/tools/ooxmlgate.go b/internal/tools/ooxmlgate.go index 292e995..5e647b5 100644 --- a/internal/tools/ooxmlgate.go +++ b/internal/tools/ooxmlgate.go @@ -14,14 +14,23 @@ import ( "encoding/xml" "fmt" "io" + "net/url" "path" "path/filepath" "strings" ) const ( + nsPackageRel = "http://schemas.openxmlformats.org/package/2006/relationships" + nsContentTypes = "http://schemas.openxmlformats.org/package/2006/content-types" nsPresentationML = "http://schemas.openxmlformats.org/presentationml/2006/main" nsOfficeDocRel = "http://schemas.openxmlformats.org/officeDocument/2006/relationships" + relOfficeDoc = nsOfficeDocRel + "/officeDocument" + relStrictOffice = "http://purl.oclc.org/ooxml/officeDocument/relationships/officeDocument" + ctWordDocument = "application/vnd.openxmlformats-officedocument.wordprocessingml.document.main+xml" + ctWordTemplate = "application/vnd.openxmlformats-officedocument.wordprocessingml.template.main+xml" + ctWordMacroDoc = "application/vnd.ms-word.document.macroEnabled.main+xml" + ctWordMacroTpl = "application/vnd.ms-word.template.macroEnabledTemplate.main+xml" ctPresentation = "application/vnd.openxmlformats-officedocument.presentationml.presentation.main+xml" ctSlide = "application/vnd.openxmlformats-officedocument.presentationml.slide+xml" ctSlideLayout = "application/vnd.openxmlformats-officedocument.presentationml.slideLayout+xml" @@ -44,20 +53,324 @@ func ooxmlStructuralCheck(name string, content []byte) error { } } -// isWordprocessingMLPackage identifies Word OPC packages from their mandatory -// main document part instead of trusting the caller-controlled filename. The -// part is shared by document/template and macro-enabled variants. +// isWordprocessingMLPackage identifies Word OPC packages from the package-level +// officeDocument relationship and the resolved main part's content type. A +// purported officeDocument package with malformed, ambiguous, or unsafe +// metadata is treated as Word so the registration boundary fails closed. func isWordprocessingMLPackage(content []byte) bool { zr, err := zip.NewReader(bytes.NewReader(content), int64(len(content))) if err != nil { return false } - for _, file := range zr.File { - if strings.EqualFold(strings.TrimPrefix(file.Name, "/"), "word/document.xml") { - return true + isWord, purportsOfficeDocument, err := ooxmlClassifyWordPackage(zr) + if err != nil { + return purportsOfficeDocument + } + return isWord +} + +func ooxmlClassifyWordPackage(zr *zip.Reader) (isWord, purportsOfficeDocument bool, err error) { + relsFile, found, err := ooxmlUniquePart(zr, "_rels/.rels") + if err != nil { + return false, true, err + } + if !found { + return false, false, nil + } + rels, purportsOfficeDocument, err := ooxmlPackageRelationships(relsFile) + if err != nil { + return false, purportsOfficeDocument, err + } + + var officeRels []ooxmlRel + for _, rel := range rels { + if rel.typ == relOfficeDoc || rel.typ == relStrictOffice { + officeRels = append(officeRels, rel) } } - return false + if len(officeRels) == 0 { + return false, false, nil + } + if len(officeRels) != 1 { + return false, true, fmt.Errorf("package relationships contain %d officeDocument relationships", len(officeRels)) + } + + mainPart, err := ooxmlSafePackageTarget(officeRels[0].target, officeRels[0].targetMode) + if err != nil { + return false, true, err + } + if _, found, err := ooxmlUniquePartFold(zr, mainPart); err != nil || !found { + if err != nil { + return false, true, err + } + return false, true, fmt.Errorf("officeDocument target %q is missing", mainPart) + } + + contentTypesFile, found, err := ooxmlUniquePart(zr, "[Content_Types].xml") + if err != nil { + return false, true, err + } + if !found { + return false, true, fmt.Errorf("officeDocument package is missing [Content_Types].xml") + } + contentTypes, err := ooxmlParseContentTypes(contentTypesFile) + if err != nil { + return false, true, err + } + contentType, found := contentTypes.contentType(mainPart) + if !found { + return false, true, fmt.Errorf("officeDocument target %q has no content type", mainPart) + } + return ooxmlIsWordMainContentType(contentType), true, nil +} + +type ooxmlContentTypeTable struct { + defaults map[string]string + overrides map[string]string +} + +func (t ooxmlContentTypeTable) contentType(part string) (string, bool) { + if contentType, ok := t.overrides[strings.ToLower(part)]; ok { + return contentType, true + } + extension := strings.TrimPrefix(path.Ext(part), ".") + contentType, ok := t.defaults[strings.ToLower(extension)] + return contentType, ok +} + +func ooxmlIsWordMainContentType(contentType string) bool { + switch contentType { + case ctWordDocument, ctWordTemplate, ctWordMacroDoc, ctWordMacroTpl: + return true + default: + return false + } +} + +func ooxmlPackageRelationships(file *zip.File) ([]ooxmlRel, bool, error) { + rc, err := file.Open() + if err != nil { + return nil, false, fmt.Errorf("_rels/.rels cannot be read: %w", err) + } + defer rc.Close() + + dec := xml.NewDecoder(rc) + var rels []ooxmlRel + seenIDs := map[string]bool{} + rootSeen := false + rootValid := false + depth := 0 + purportsOfficeDocument := false + var metadataErr error + for { + tok, err := dec.Token() + if err == io.EOF { + break + } + if err != nil { + return nil, purportsOfficeDocument, fmt.Errorf("_rels/.rels is not valid XML: %w", err) + } + switch node := tok.(type) { + case xml.EndElement: + depth-- + continue + case xml.StartElement: + depth++ + if !rootSeen { + rootSeen = true + rootValid = node.Name.Space == nsPackageRel && node.Name.Local == "Relationships" + if !rootValid { + metadataErr = fmt.Errorf("_rels/.rels has an invalid Relationships root") + } + continue + } + + var rel ooxmlRel + seenAttrs := map[string]bool{} + for _, attr := range node.Attr { + if attr.Name.Space != "" { + continue + } + if seenAttrs[attr.Name.Local] { + metadataErr = fmt.Errorf("_rels/.rels contains duplicate %s attributes", attr.Name.Local) + } + seenAttrs[attr.Name.Local] = true + switch attr.Name.Local { + case "Id": + rel.id = attr.Value + case "Type": + rel.typ = attr.Value + case "Target": + rel.target = attr.Value + case "TargetMode": + rel.targetMode = attr.Value + } + } + if rel.typ == relOfficeDoc || rel.typ == relStrictOffice { + purportsOfficeDocument = true + } + if depth != 2 || node.Name.Space != nsPackageRel || node.Name.Local != "Relationship" { + metadataErr = fmt.Errorf("_rels/.rels contains an invalid relationship element") + continue + } + if rel.id == "" || rel.typ == "" || rel.target == "" { + metadataErr = fmt.Errorf("_rels/.rels contains an incomplete Relationship") + continue + } + if seenIDs[rel.id] { + metadataErr = fmt.Errorf("_rels/.rels contains duplicate relationship Id %q", rel.id) + continue + } + seenIDs[rel.id] = true + rels = append(rels, rel) + } + } + if !rootSeen { + return nil, false, fmt.Errorf("_rels/.rels is empty") + } + if !rootValid || metadataErr != nil { + return nil, purportsOfficeDocument, metadataErr + } + return rels, purportsOfficeDocument, nil +} + +func ooxmlParseContentTypes(file *zip.File) (ooxmlContentTypeTable, error) { + table := ooxmlContentTypeTable{ + defaults: map[string]string{}, + overrides: map[string]string{}, + } + rc, err := file.Open() + if err != nil { + return table, fmt.Errorf("[Content_Types].xml cannot be read: %w", err) + } + defer rc.Close() + + dec := xml.NewDecoder(rc) + rootSeen := false + for { + tok, err := dec.Token() + if err == io.EOF { + break + } + if err != nil { + return table, fmt.Errorf("[Content_Types].xml is not valid XML: %w", err) + } + se, ok := tok.(xml.StartElement) + if !ok { + continue + } + if !rootSeen { + rootSeen = true + if se.Name.Space != nsContentTypes || se.Name.Local != "Types" { + return table, fmt.Errorf("[Content_Types].xml has an invalid Types root") + } + continue + } + if se.Name.Space != nsContentTypes { + continue + } + attrs := map[string]string{} + for _, attr := range se.Attr { + if attr.Name.Space == "" { + attrs[attr.Name.Local] = attr.Value + } + } + switch se.Name.Local { + case "Default": + extension := strings.ToLower(attrs["Extension"]) + contentType := attrs["ContentType"] + if extension == "" || strings.ContainsAny(extension, ".\\/ \t\r\n") || contentType == "" { + return table, fmt.Errorf("[Content_Types].xml contains an invalid Default") + } + if _, exists := table.defaults[extension]; exists { + return table, fmt.Errorf("[Content_Types].xml contains duplicate Default for %q", extension) + } + table.defaults[extension] = contentType + case "Override": + partName, err := ooxmlSafePartName(attrs["PartName"]) + if err != nil || attrs["ContentType"] == "" { + return table, fmt.Errorf("[Content_Types].xml contains an invalid Override") + } + key := strings.ToLower(partName) + if _, exists := table.overrides[key]; exists { + return table, fmt.Errorf("[Content_Types].xml contains duplicate Override for %q", partName) + } + table.overrides[key] = attrs["ContentType"] + } + } + if !rootSeen { + return table, fmt.Errorf("[Content_Types].xml is empty") + } + return table, nil +} + +func ooxmlSafePackageTarget(target, targetMode string) (string, error) { + if targetMode != "" && !strings.EqualFold(targetMode, "Internal") { + return "", fmt.Errorf("officeDocument target must be internal") + } + return ooxmlSafePartPath(target, strings.HasPrefix(target, "/")) +} + +func ooxmlSafePartName(partName string) (string, error) { + if !strings.HasPrefix(partName, "/") { + return "", fmt.Errorf("OPC part name must be absolute") + } + return ooxmlSafePartPath(partName, true) +} + +func ooxmlSafePartPath(raw string, absolute bool) (string, error) { + if raw == "" || strings.ContainsAny(raw, "\\\x00") { + return "", fmt.Errorf("unsafe OPC part path %q", raw) + } + parsed, err := url.Parse(raw) + if err != nil || parsed.IsAbs() || parsed.Host != "" || parsed.Opaque != "" || parsed.RawQuery != "" || parsed.Fragment != "" { + return "", fmt.Errorf("unsafe OPC part path %q", raw) + } + decoded, err := url.PathUnescape(parsed.EscapedPath()) + if err != nil || strings.ContainsAny(decoded, "\\\x00") { + return "", fmt.Errorf("unsafe OPC part path %q", raw) + } + if absolute != strings.HasPrefix(decoded, "/") { + return "", fmt.Errorf("unsafe OPC part path %q", raw) + } + decoded = strings.TrimPrefix(decoded, "/") + if decoded == "" || strings.HasSuffix(decoded, "/") { + return "", fmt.Errorf("unsafe OPC part path %q", raw) + } + for _, segment := range strings.Split(decoded, "/") { + if segment == "" || segment == "." || segment == ".." { + return "", fmt.Errorf("unsafe OPC part path %q", raw) + } + } + return decoded, nil +} + +func ooxmlUniquePart(zr *zip.Reader, name string) (*zip.File, bool, error) { + var found *zip.File + for _, file := range zr.File { + if file.Name != name { + continue + } + if found != nil { + return nil, false, fmt.Errorf("duplicate OPC metadata part %s", name) + } + found = file + } + return found, found != nil, nil +} + +func ooxmlUniquePartFold(zr *zip.Reader, name string) (*zip.File, bool, error) { + var found *zip.File + for _, file := range zr.File { + if !strings.EqualFold(file.Name, name) { + continue + } + if found != nil { + return nil, false, fmt.Errorf("duplicate OPC part %s", name) + } + found = file + } + return found, found != nil, nil } // ooxmlCheckParts 校验容器与必备正文部件存在、XML 合法、命名空间前缀齐备 @@ -538,9 +851,10 @@ func ooxmlPart(zr *zip.Reader, name string) (*zip.File, error) { // ooxmlRel 是 rels 部件里的一条关系：Id、类型 URI 与目标（原样保留相对形式）。 type ooxmlRel struct { - id string - typ string - target string + id string + typ string + target string + targetMode string } // ooxmlRels 解析 part 的关系表（/_rels/.rels）。 diff --git a/internal/tools/ooxmlgate_test.go b/internal/tools/ooxmlgate_test.go index b858435..227775b 100644 --- a/internal/tools/ooxmlgate_test.go +++ b/internal/tools/ooxmlgate_test.go @@ -31,18 +31,47 @@ func zipOf(t *testing.T, files map[string]string) []byte { } const ( - gateCTXML = `` - gateSlide = `` - gateLayout = `` - gateMaster = `` - gateTheme = `` + gatePackageRelNS = "http://schemas.openxmlformats.org/package/2006/relationships" + gateOfficeRel = "http://schemas.openxmlformats.org/officeDocument/2006/relationships/officeDocument" + gateStrictOffice = "http://purl.oclc.org/ooxml/officeDocument/relationships/officeDocument" + gateContentNS = "http://schemas.openxmlformats.org/package/2006/content-types" + gateCTXML = `` + gateSlide = `` + gateLayout = `` + gateMaster = `` + gateTheme = `` ) func relXML(rels ...string) string { - return `` + + return `` + strings.Join(rels, "") + `` } +func gateOfficePackage(t *testing.T, rels, contentTypes, mainPart string) []byte { + t.Helper() + files := map[string]string{ + "_rels/.rels": rels, + "[Content_Types].xml": contentTypes, + } + if mainPart != "" { + files[strings.TrimPrefix(mainPart, "/")] = `` + } + return zipOf(t, files) +} + +func gateOfficeRelXML(relType, target, targetMode string) string { + mode := "" + if targetMode != "" { + mode = ` TargetMode="` + targetMode + `"` + } + return relXML(``) +} + +func gateOverrideCT(part, contentType string) string { + return `` +} + const ( relSlide = `` relMaster = `` @@ -365,20 +394,22 @@ func TestRegisterArtifactRejectsRenamedWordprocessingMLPackages(t *testing.T) { wordTypes := []struct { name string + mainPart string + relType string contentType string }{ - {"report.zip", "application/vnd.openxmlformats-officedocument.wordprocessingml.document.main+xml"}, - {"macro.bin", "application/vnd.ms-word.document.macroEnabled.main+xml"}, - {"template.data", "application/vnd.openxmlformats-officedocument.wordprocessingml.template.main+xml"}, - {"template.docx ", "application/vnd.ms-word.template.macroEnabledTemplate.main+xml"}, + {"report.zip", "custom/main.xml", gateOfficeRel, "application/vnd.openxmlformats-officedocument.wordprocessingml.document.main+xml"}, + {"macro.bin", "word/document.xml", gateOfficeRel, "application/vnd.ms-word.document.macroEnabled.main+xml"}, + {"template.data", "templates/body.xml", gateStrictOffice, "application/vnd.openxmlformats-officedocument.wordprocessingml.template.main+xml"}, + {"macro-template.payload", "package/document.xml", gateOfficeRel, "application/vnd.ms-word.template.macroEnabledTemplate.main+xml"}, } for _, test := range wordTypes { t.Run(test.name, func(t *testing.T) { - contentTypes := `` - pkg := zipOf(t, map[string]string{ - "[Content_Types].xml": contentTypes, - "word/document.xml": ``, - }) + pkg := gateOfficePackage(t, + gateOfficeRelXML(test.relType, test.mainPart, ""), + gateOverrideCT(test.mainPart, test.contentType), + test.mainPart, + ) if err := os.WriteFile(filepath.Join(sandbox, test.name), pkg, 0o644); err != nil { t.Fatal(err) } @@ -389,9 +420,41 @@ func TestRegisterArtifactRejectsRenamedWordprocessingMLPackages(t *testing.T) { }) } + defaultTyped := gateOfficePackage(t, + gateOfficeRelXML(gateOfficeRel, "alternate/main.wml", ""), + ``, + "alternate/main.wml", + ) + if err := os.WriteFile(filepath.Join(sandbox, "default-typed.pkg"), defaultTyped, 0o644); err != nil { + t.Fatal(err) + } + res := interpCall(t, r, rc, "register_artifact", `{"path":"default-typed.pkg"}`) + if res.Status != "error" || !strings.Contains(res.Output, "direct Word registration is forbidden") { + t.Fatalf("default-typed WordprocessingML package must be refused: %s %s", res.Status, res.Output) + } + + fakeWordPart := zipOf(t, map[string]string{ + "word/document.xml": ``, + "data/payload.json": `{"ok":true}`, + }) + if err := os.WriteFile(filepath.Join(sandbox, "same-name.zip"), fakeWordPart, 0o644); err != nil { + t.Fatal(err) + } + res = interpCall(t, r, rc, "register_artifact", `{"path":"same-name.zip"}`) + if res.Status != "ok" || !strings.Contains(res.Output, "已登记交付物") { + t.Fatalf("ordinary ZIP with a same-name part must register: %s %s", res.Status, res.Output) + } + + spreadsheet := gateOfficePackage(t, + gateOfficeRelXML(gateOfficeRel, "xl/workbook.xml", ""), + gateOverrideCT("xl/workbook.xml", "application/vnd.openxmlformats-officedocument.spreadsheetml.sheet.main+xml"), + "xl/workbook.xml", + ) + allowed := map[string][]byte{ - "dataset.zip": zipOf(t, map[string]string{"data/payload.json": `{"ok":true}`}), - "payload.bin": {0x00, 0x01, 0x02, 0xff}, + "dataset.zip": zipOf(t, map[string]string{"data/payload.json": `{"ok":true}`}), + "spreadsheet.pkg": spreadsheet, + "payload.bin": {0x00, 0x01, 0x02, 0xff}, } for name, content := range allowed { if err := os.WriteFile(filepath.Join(sandbox, name), content, 0o644); err != nil { @@ -404,6 +467,81 @@ func TestRegisterArtifactRejectsRenamedWordprocessingMLPackages(t *testing.T) { } } +func TestRegisterArtifactRejectsMalformedAmbiguousOrUnsafeOfficeDocumentMetadata(t *testing.T) { + r := NewRegistry() + if err := RegisterExecTools(r); err != nil { + t.Fatal(err) + } + root := t.TempDir() + rc := &execFake{root: root, owner: "o1", conv: "c1", execOn: true} + sandbox := filepath.Join(root, "o1", "c1") + if err := os.MkdirAll(sandbox, 0o755); err != nil { + t.Fatal(err) + } + + const wordType = "application/vnd.openxmlformats-officedocument.wordprocessingml.document.main+xml" + validCT := gateOverrideCT("custom/main.xml", wordType) + validRel := gateOfficeRelXML(gateOfficeRel, "custom/main.xml", "") + tests := []struct { + name string + rels string + contentTypes string + }{ + { + name: "malformed-relationships.pkg", + rels: ``, + contentTypes: validCT, + }, + { + name: "duplicate-office-relationships.pkg", + rels: relXML( + ``, + ``, + ), + contentTypes: validCT, + }, + { + name: "malformed-content-types.pkg", + rels: validRel, + contentTypes: ``, + }, + { + name: "duplicate-content-type.pkg", + rels: validRel, + contentTypes: `` + + `` + + ``, + }, + { + name: "missing-main-content-type.pkg", + rels: validRel, + contentTypes: ``, + }, + { + name: "traversal-target.pkg", + rels: gateOfficeRelXML(gateOfficeRel, "../custom/main.xml", ""), + contentTypes: validCT, + }, + { + name: "external-target.pkg", + rels: gateOfficeRelXML(gateOfficeRel, "https://example.invalid/main.xml", "External"), + contentTypes: validCT, + }, + } + for _, test := range tests { + t.Run(test.name, func(t *testing.T) { + pkg := gateOfficePackage(t, test.rels, test.contentTypes, "custom/main.xml") + if err := os.WriteFile(filepath.Join(sandbox, test.name), pkg, 0o644); err != nil { + t.Fatal(err) + } + res := interpCall(t, r, rc, "register_artifact", `{"path":`+mustJSON(t, test.name)+`}`) + if res.Status != "error" || !strings.Contains(res.Output, "direct Word registration is forbidden") { + t.Fatalf("unsafe officeDocument metadata must fail closed: %s %s", res.Status, res.Output) + } + }) + } +} + func mustJSON(t *testing.T, value string) string { t.Helper() raw, err := json.Marshal(value) -- 2.54.0 From 1afe1647981e1f331c379757b100e10a9b47ed90 Mon Sep 17 00:00:00 2001 From: weichen Date: Fri, 16 Oct 2026 05:07:19 +0000 Subject: [PATCH 37/41] Pin published company default renderer and drop candidate wording Why: agent-document-renderer 31fbe54 publishes company.default@1.0.0 with review status approved and publicationAllowed true (owner decision 2026-10-16: A4, ~2.5cm margins, SimSun + Times New Roman 12pt body, SimHei headings, no logo). Backend still hard-coded Candidate=true and every prompt, skill and tool text called the default a pending-human-visual-review candidate. Evidence: go vet ./... exit 0; gofmt -l on changed packages empty; go test -count=1 ./internal/docgen/... ./internal/prompts/... ./internal/skills/... ./internal/tools/... ok; go test -count=1 ./... exit 0 (42 packages ok); go build ./... and CGO_ENABLED=0 go build ./cmd/agent-system ok; git diff --cached --check clean. New tests failed before the change. Impact: bump deps/agent-document-renderer 0d1c512 -> 31fbe54 and regenerate the renderer identity. The manifest profile receipt now reports the renderer's own review status and derives Candidate from the snapshot state (false for the published default). Prompts (base.deliverables v12, tool.render_document v2, task.report v4, task.doc-minutes v4), docx-author and house-style skills, the render_document tool description and comparison exception details describe the default as published (approved by owner 2026-10-16) while still limiting it to ordinary uncontrolled workspace working/preview Word. Routing is unchanged: project, controlled, special-template, review and approved outputs still go to RDM, with no Backend default fallback and no legacy Word builder fallback. Refs: unified renderer plan Tasks 7/10 Co-authored-by: Cursor --- deps/agent-document-renderer | 2 +- internal/docgen/comparison.go | 4 +- internal/docgen/renderer.go | 2 +- .../docgen/renderer_identity_generated.go | 2 +- internal/docgen/renderer_integration_test.go | 22 ++++++++--- internal/prompts/library/base-deliverables.md | 6 +-- internal/prompts/library/task-doc-minutes.md | 4 +- internal/prompts/library/task-report.md | 4 +- .../prompts/library/tool-render-document.md | 6 +-- internal/prompts/prompts_test.go | 39 ++++++++++++++++++- internal/skills/recipes/docx-author/SKILL.md | 2 +- internal/skills/recipes/house-style/SKILL.md | 2 +- internal/skills/skills_test.go | 25 +++++++++++- internal/tools/document_renderer.go | 2 +- internal/tools/document_renderer_test.go | 19 +++++++++ 15 files changed, 116 insertions(+), 25 deletions(-) diff --git a/deps/agent-document-renderer b/deps/agent-document-renderer index 0d1c512..31fbe54 160000 --- a/deps/agent-document-renderer +++ b/deps/agent-document-renderer @@ -1 +1 @@ -Subproject commit 0d1c5121d137be817db5f98d3c13320dfa919c8a +Subproject commit 31fbe54fae8bf11be664919ce173da0d68ebfdc9 diff --git a/internal/docgen/comparison.go b/internal/docgen/comparison.go index ad48558..3996cdb 100644 --- a/internal/docgen/comparison.go +++ b/internal/docgen/comparison.go @@ -125,13 +125,13 @@ func compareLegacyAndShared(title string, source []byte, canonical model.Canonic receipt.Dimensions = append(receipt.Dimensions, compareExactDimension("page-margins", legacyDOCX.Margins, sharedDOCX.Margins, "")) } else { receipt.Dimensions = append(receipt.Dimensions, intentionalDimension("page-margins", legacyDOCX.Margins, sharedDOCX.Margins, - comparisonExceptionCorporate, "organization-default candidate owns page margins")) + comparisonExceptionCorporate, "published organization default owns page margins")) } if legacyDOCX.Headers == sharedDOCX.Headers && legacyDOCX.Footers == sharedDOCX.Footers { receipt.Dimensions = append(receipt.Dimensions, compareExactDimension("header-footer", []int{legacyDOCX.Headers, legacyDOCX.Footers}, []int{sharedDOCX.Headers, sharedDOCX.Footers}, "")) } else { receipt.Dimensions = append(receipt.Dimensions, intentionalDimension("header-footer", []int{legacyDOCX.Headers, legacyDOCX.Footers}, []int{sharedDOCX.Headers, sharedDOCX.Footers}, - comparisonExceptionCorporate, "organization-default candidate adds reviewed header/footer rules")) + comparisonExceptionCorporate, "published organization default adds approved header/footer rules")) } if legacyDOCX.Bookmarks == sharedDOCX.Bookmarks { receipt.Dimensions = append(receipt.Dimensions, compareExactDimension("node-bookmarks", legacyDOCX.Bookmarks, sharedDOCX.Bookmarks, "")) diff --git a/internal/docgen/renderer.go b/internal/docgen/renderer.go index 457d768..5ba8fb4 100644 --- a/internal/docgen/renderer.go +++ b/internal/docgen/renderer.go @@ -340,7 +340,7 @@ func generateWithOptions(ctx context.Context, request Request, options RenderOpt Document: parsed.Document, Renderer: result.Manifest, Profile: ProfileReceipt{ ProfileID: profileID, Version: profileVersion, SnapshotHash: bundle.Snapshot.SnapshotHash(), - Candidate: true, ReviewStatus: bundle.Review.Status, PublicationAllowed: bundle.Review.PublicationAllowed, + Candidate: bundle.Snapshot.State() != profile.StatePublished, ReviewStatus: bundle.Review.Status, PublicationAllowed: bundle.Review.PublicationAllowed, Unverified: append([]string(nil), bundle.Review.Unverified...), ProfileSHA256: bundle.Review.ProfileSHA256, AssetManifestSHA256: bundle.Review.AssetManifestSHA256, ReviewSHA256: bundle.Review.ReviewSHA256, }, diff --git a/internal/docgen/renderer_identity_generated.go b/internal/docgen/renderer_identity_generated.go index cae3eec..ec759b3 100644 --- a/internal/docgen/renderer_identity_generated.go +++ b/internal/docgen/renderer_identity_generated.go @@ -2,6 +2,6 @@ package docgen -const rendererRevision = "0d1c5121d137be817db5f98d3c13320dfa919c8a" +const rendererRevision = "31fbe54fae8bf11be664919ce173da0d68ebfdc9" const RendererIdentity = "agent-document-renderer@" + rendererRevision diff --git a/internal/docgen/renderer_integration_test.go b/internal/docgen/renderer_integration_test.go index d7d4074..d8b989d 100644 --- a/internal/docgen/renderer_integration_test.go +++ b/internal/docgen/renderer_integration_test.go @@ -39,7 +39,7 @@ const representativeMarkdown = `# 研发周会纪要 ![公司默认样图](asset:company.default.sample-image@1.0.0) :::callout warning -公司默认规则仍待人工视觉评审。 +公司默认规则只用于普通工作区交付。 ::: :::page-break @@ -89,10 +89,17 @@ func TestGenerateProducesDeterministicHashedDeliveryPackage(t *testing.T) { if err := json.Unmarshal(first.Manifest.Bytes, &manifest); err != nil { t.Fatalf("decode manifest: %v", err) } + bundle, err := profiles.LoadCompanyDefault() + if err != nil { + t.Fatalf("load renderer company default: %v", err) + } if manifest.SchemaVersion != ManifestSchemaVersion || manifest.RendererIdentity != RendererIdentity || - manifest.SelectionSource != "organization-default" || !manifest.Profile.Candidate || - manifest.Profile.ReviewStatus != "pending-human-visual-review" || manifest.Profile.PublicationAllowed { - t.Fatalf("manifest profile provenance = %#v", manifest) + manifest.SelectionSource != "organization-default" || manifest.Profile.Candidate || + manifest.Profile.ReviewStatus != bundle.Review.Status || manifest.Profile.PublicationAllowed != bundle.Review.PublicationAllowed { + t.Fatalf("manifest profile provenance = %#v, renderer review = %#v", manifest, bundle.Review) + } + if manifest.Profile.ReviewStatus != "approved" || !manifest.Profile.PublicationAllowed { + t.Fatalf("published organization default reported review=%q publicationAllowed=%v", manifest.Profile.ReviewStatus, manifest.Profile.PublicationAllowed) } if manifest.Profile.ProfileSHA256 == "" || manifest.Profile.AssetManifestSHA256 == "" || manifest.Profile.ReviewSHA256 == "" { t.Fatalf("manifest omitted source hashes: %#v", manifest.Profile) @@ -360,7 +367,7 @@ func TestPersistedControlledMetadataRoutesBeforeDefaultProfileLoad(t *testing.T) } func TestRendererIdentityMatchesPublishedPin(t *testing.T) { - const want = "agent-document-renderer@0d1c5121d137be817db5f98d3c13320dfa919c8a" + const want = "agent-document-renderer@31fbe54fae8bf11be664919ce173da0d68ebfdc9" if RendererIdentity != want { t.Fatalf("RendererIdentity = %q, want %q", RendererIdentity, want) } @@ -636,6 +643,11 @@ func TestRepresentativeLegacyComparisonRecordsOnlyIntentionalDifferences(t *test t.Errorf("comparison dimension %s = %#v, want match", name, dimension) } } + for _, dimension := range delivery.Comparison.Dimensions { + if dimension.ExceptionID == comparisonExceptionCorporate && !strings.Contains(dimension.Detail, "published organization default") { + t.Errorf("corporate layout exception %s detail = %q, want published organization default", dimension.Name, dimension.Detail) + } + } } func TestComparisonDetectsCanonicalAndDOCXTableAlignmentLoss(t *testing.T) { diff --git a/internal/prompts/library/base-deliverables.md b/internal/prompts/library/base-deliverables.md index 25803e3..d934a69 100644 --- a/internal/prompts/library/base-deliverables.md +++ b/internal/prompts/library/base-deliverables.md @@ -1,7 +1,7 @@ --- id: base.deliverables layer: base -version: 11 +version: 12 title: 交付物工作流 description: 生成文档、表格、演示稿的工作流、样式决策与技能入口（常驻基座） --- @@ -9,10 +9,10 @@ description: 生成文档、表格、演示稿的工作流、样式决策与技 工作流： -1. **先判路由**：普通、非受控的工作区 Word 可用组织默认候选；项目文档、受控文档、专用模板或审签输出必须交给 RDM，禁止调用 Backend 默认规则回退。组织默认候选的 manifest 状态固定显示 `pending-human-visual-review`，不能描述成已发布或已视觉批准。Excel / PPT / 图片再按用户指令、模板、参考文档、会话样式和默认主题的顺序定样式。 +1. **先判路由**：组织默认规则已发布（负责人 2026-10-16 批准，manifest 评审状态 `approved`），但只用于普通、非受控的工作区 Word；项目文档、受控文档、专用模板或审签输出必须交给 RDM，禁止调用 Backend 默认规则回退。Excel / PPT / 图片再按用户指令、模板、参考文档、会话样式和默认主题的顺序定样式。 2. **规划版面**：先定读者、结构和每一节的内容，再写脚本。不要边生成边补空节。 3. **生成 Word**：调用 `render_document`，传本次交付稳定且重试复用的 `operationId`、稳定 `documentId`、标题 `name`、Markdown、语言和 `working|preview` 模式，并显式传 `controlled=false`、`projectDocument=false`；任何一项不是 false 就停止并交给 RDM。时间与 requester 由宿主冻结，禁止传入或声称自定 `frozenAt`。Markdown 用 `#`-`######` 标题、段落、引用、围栏/行内代码、粗体、斜体、删除线、安全链接标签、`-`/`1.` 列表、GFM 表格、`asset:` 图片、`:::callout warning`/`:::` 提示块和 `:::page-break`。工具先保存带稳定 node ID 的 Markdown，再生成确定性 DOCX、manifest 和完整 zip；返回值逐项列出稳定 ID 与 SHA-256。失败时按回执状态重试同一 operationId，绝不调用 legacy Word 路径回退。 -4. **生成其他格式并自检**：Excel/PPT/图片用 `run_python` + house-style 对应 kit；用 lint/outline 回读。Word 的 OPC、安全、锚点与回读校验已经由统一 renderer 执行，复核 manifest 中的诊断、组织默认候选状态和 Markdown/DOCX 哈希。 +4. **生成其他格式并自检**：Excel/PPT/图片用 `run_python` + house-style 对应 kit；用 lint/outline 回读。Word 的 OPC、安全、锚点与回读校验已经由统一 renderer 执行，复核 manifest 中的诊断、组织默认规则评审状态和 Markdown/DOCX 哈希。 5. **登记**：`render_document` 已登记 Markdown、DOCX、manifest 和 zip，不要重复登记。其他格式继续用 `register_artifact`。 6. **收尾**：回复只写结论摘要，并说明这次用的样式（主题、是否模板、是否仿制）以及用户还能怎么调。不要在回复里复述全文，也不要只口头说文件名。 diff --git a/internal/prompts/library/task-doc-minutes.md b/internal/prompts/library/task-doc-minutes.md index 3483fd2..f53af31 100644 --- a/internal/prompts/library/task-doc-minutes.md +++ b/internal/prompts/library/task-doc-minutes.md @@ -1,7 +1,7 @@ --- id: task.doc-minutes layer: task -version: 3 +version: 4 title: 会议纪要生成 description: 依据上传的会议记录/录音稿生成结构完整的会议纪要 priority: 70 @@ -28,4 +28,4 @@ triggers: - 待办事项若原文未指明负责人或期限，写"未指明"，不要编造。 - 版面：标题下用键值表写会议信息（时间、地点、主持人、参会人、缺席）。讨论按议题分节，每节含要点、分歧和结论。决议用真编号列表，不要再手写“1.”。待办用表格，列：序号、事项、负责人、期限、状态；原文没有的写“未指明”。发言人用统一称谓（职务或姓名）；原文只有“说话人X”时保留并在文末说明。引语只留关键句，并标注是谁说的。 - 日期和数字全文一种格式。不要空节、空段落和手打项目符号。 -- 交付形态：普通工作区纪要按「交付物工作流」调用 `render_document`，生成「<主题>会议纪要.md/.docx/.manifest.json/.zip」；项目或受控纪要交给 RDM。对话里只简述结论、规则候选状态和可调项，不要复述全文。 +- 交付形态：普通工作区纪要按「交付物工作流」调用 `render_document`，生成「<主题>会议纪要.md/.docx/.manifest.json/.zip」；项目或受控纪要交给 RDM。对话里只简述结论、所用组织默认规则和可调项，不要复述全文。 diff --git a/internal/prompts/library/task-report.md b/internal/prompts/library/task-report.md index f17f3df..106291b 100644 --- a/internal/prompts/library/task-report.md +++ b/internal/prompts/library/task-report.md @@ -1,7 +1,7 @@ --- id: task.report layer: task -version: 3 +version: 4 title: 报告撰写 description: 把材料组织成正式报告/公文（含执行摘要与附录建议） priority: 55 @@ -25,4 +25,4 @@ triggers: - 结构服务于阅读动线：先结论后论证；每章开头一句话说清本章要点。 - 篇幅完整不注水：覆盖必要内容，删掉不改变结论的空话。 - 版面：封面（标题、受众、日期）、正文从执行摘要开始。执行摘要用强调块，控制在契约规定的篇幅内。章标题用标题样式，章首一句点明本章要点。数据进表格或附录，不埋在段落里。需要时在正文前放由标题生成的目录说明（页码以文件为准）。 -- 交付普通工作区 Word 时走交付物工作流的 `render_document`，同时保留 Markdown、manifest 和归档；项目或受控报告交给 RDM。回复说明规则候选状态，不复述全文。 +- 交付普通工作区 Word 时走交付物工作流的 `render_document`，同时保留 Markdown、manifest 和归档；项目或受控报告交给 RDM。回复说明所用组织默认规则，不复述全文。 diff --git a/internal/prompts/library/tool-render-document.md b/internal/prompts/library/tool-render-document.md index a121dd0..ceed6a1 100644 --- a/internal/prompts/library/tool-render-document.md +++ b/internal/prompts/library/tool-render-document.md @@ -1,10 +1,10 @@ --- id: tool.render_document layer: tool -version: 1 +version: 2 title: render_document 工具描述 description: 普通工作区 Markdown 到统一 Word 交付包的安全渲染入口 --- -把普通、非受控的工作区 Markdown 交给共享 canonical parser、组织默认候选 profile 和 Word adapter。必须传稳定且重试复用的 operationId，并显式传 `controlled=false` 和 `projectDocument=false`；缺任一字段即拒绝。frozenAt 与 requester 由宿主首次操作时创建并持久化，调用方不能提交。成功回执包含 Markdown、DOCX、manifest、zip 的稳定 ID 与 SHA-256；失败回执明确 partial 或 unknown，重试必须沿用同一 operationId。 +把普通、非受控的工作区 Markdown 交给共享 canonical parser、已发布的组织默认 profile 和 Word adapter。必须传稳定且重试复用的 operationId，并显式传 `controlled=false` 和 `projectDocument=false`；缺任一字段即拒绝。frozenAt 与 requester 由宿主首次操作时创建并持久化，调用方不能提交。成功回执包含 Markdown、DOCX、manifest、zip 的稳定 ID 与 SHA-256；失败回执明确 partial 或 unknown，重试必须沿用同一 operationId。 -只允许 working 或 preview。项目文档、受控文档、专用模板、审阅稿或批准稿必须交给 RDM；失败不得改走 legacy Word builder。当前公司默认规则状态是 pending-human-visual-review，只可用于普通工作/预览交付，不能称为已发布或已视觉批准。 +只允许 working 或 preview。项目文档、受控文档、专用模板、审阅稿或批准稿必须交给 RDM；失败不得改走 legacy Word builder。公司默认规则已发布（负责人 2026-10-16 批准，manifest 评审状态 `approved`），但仍只用于普通、非受控的工作/预览交付，不能代替 RDM 的项目或受控规则。 diff --git a/internal/prompts/prompts_test.go b/internal/prompts/prompts_test.go index 8cda4ce..9a4c8d8 100644 --- a/internal/prompts/prompts_test.go +++ b/internal/prompts/prompts_test.go @@ -101,16 +101,53 @@ func TestBaseDeliverablesRoutesWordThroughUnifiedRenderer(t *testing.T) { if err != nil || !found { t.Fatalf("base.deliverables: found=%v err=%v", found, err) } - for _, required := range []string{"render_document", "Markdown", "manifest", "SHA-256", "pending-human-visual-review", "RDM"} { + for _, required := range []string{"render_document", "Markdown", "manifest", "SHA-256", "已发布", "2026-10-16", "approved", "RDM", "禁止调用 Backend 默认规则回退"} { if !strings.Contains(body, required) { t.Errorf("base.deliverables missing %q", required) } } + for _, stale := range []string{"pending-human-visual-review", "组织默认候选", "不能描述成已发布"} { + if strings.Contains(body, stale) { + t.Errorf("base.deliverables still describes the organization default as unpublished: %q", stale) + } + } if strings.Contains(body, "python3 -m housestyle.build") { t.Fatal("base.deliverables still routes production Word through legacy housestyle.build") } } +func TestRenderDocumentToolDescribesPublishedDefaultWithoutWideningRoute(t *testing.T) { + body, found, err := mustService(t).ModuleBody("", "tool.render_document") + if err != nil || !found { + t.Fatalf("tool.render_document: found=%v err=%v", found, err) + } + for _, required := range []string{"已发布", "2026-10-16", "approved", "working 或 preview", "RDM", "不得改走 legacy Word builder"} { + if !strings.Contains(body, required) { + t.Errorf("tool.render_document missing %q", required) + } + } + for _, stale := range []string{"pending-human-visual-review", "默认候选", "不能称为已发布"} { + if strings.Contains(body, stale) { + t.Errorf("tool.render_document still describes the organization default as unpublished: %q", stale) + } + } +} + +func TestWordTaskPromptsDoNotReportOrganizationDefaultAsCandidate(t *testing.T) { + for _, id := range []string{"task.report", "task.doc-minutes"} { + body, found, err := mustService(t).ModuleBody("", id) + if err != nil || !found { + t.Fatalf("%s: found=%v err=%v", id, found, err) + } + if strings.Contains(body, "规则候选状态") { + t.Errorf("%s still asks the reply to report a candidate rule status", id) + } + if !strings.Contains(body, "RDM") { + t.Errorf("%s no longer routes project or controlled Word to RDM", id) + } + } +} + func TestEnvDeliverablePlaceholders(t *testing.T) { svc := mustService(t) blocks, _, err := svc.ResolveSystem(core.AgentProfile{}, TriggerCtx{Text: "你好"}, EnvData{ diff --git a/internal/skills/recipes/docx-author/SKILL.md b/internal/skills/recipes/docx-author/SKILL.md index 8e24e92..1c1091b 100644 --- a/internal/skills/recipes/docx-author/SKILL.md +++ b/internal/skills/recipes/docx-author/SKILL.md @@ -7,7 +7,7 @@ description: 用统一 renderer 生成 Markdown、DOCX、manifest 和归档 先读 `$AGENT_SKILLS_DIR/house-style/SKILL.md`。普通、非受控工作区 Word 调用 `render_document`；传本次交付稳定且重试复用的 operationId、稳定 documentId、标题和 Markdown，时间由宿主持久冻结。项目或受控 Word、专用模板、审阅与批准输出必须交给 RDM，禁止默认回退。 -成功结果包括 Markdown、DOCX、manifest 和 zip，逐项核对 SHA-256；当前组织默认候选仍是 `pending-human-visual-review`。Python、shell、`docx_kit` 和 `register_artifact` 都不是 Word 交付入口。迁移对照只能由 Backend 内部受信能力启动。生产 Word 的 OPC、安全、锚点与回读结果以共享 renderer manifest 为准；修订以返回的 Markdown 为权威源。 +成功结果包括 Markdown、DOCX、manifest 和 zip，逐项核对 SHA-256；组织默认规则已发布（负责人 2026-10-16 批准，manifest 评审状态 `approved`），但只用于普通、非受控的 working/preview 交付。Python、shell、`docx_kit` 和 `register_artifact` 都不是 Word 交付入口。迁移对照只能由 Backend 内部受信能力启动。生产 Word 的 OPC、安全、锚点与回读结果以共享 renderer manifest 为准；修订以返回的 Markdown 为权威源。 版面范式： diff --git a/internal/skills/recipes/house-style/SKILL.md b/internal/skills/recipes/house-style/SKILL.md index 05fcd36..c7627a1 100644 --- a/internal/skills/recipes/house-style/SKILL.md +++ b/internal/skills/recipes/house-style/SKILL.md @@ -5,7 +5,7 @@ description: 交付物设计系统。普通 Word 使用统一 renderer；housest # house-style -普通、非受控工作区 Word 的生产入口是 `render_document`：它保存 Markdown、确定性 DOCX、manifest 和 zip，并在 manifest 标注组织默认候选 `pending-human-visual-review`。项目或受控 Word、专用模板、审阅和批准输出必须交给 RDM，禁止 Backend 默认回退。 +普通、非受控工作区 Word 的生产入口是 `render_document`：它保存 Markdown、确定性 DOCX、manifest 和 zip，并在 manifest 记录已发布组织默认规则的评审状态 `approved`（负责人 2026-10-16 批准）；该规则只用于普通、非受控的 working/preview 交付。项目或受控 Word、专用模板、审阅和批准输出必须交给 RDM，禁止 Backend 默认回退。 housestyle 的 Excel、PowerPoint、图片构件继续用于生产。Python Word 构件不是生产或迁移入口；`housestyle.build` 永久禁用，DOC/DOCX 也不能通过 `register_artifact` 登记。 diff --git a/internal/skills/skills_test.go b/internal/skills/skills_test.go index 857bc8d..ccbaf6a 100644 --- a/internal/skills/skills_test.go +++ b/internal/skills/skills_test.go @@ -183,11 +183,16 @@ func TestHouseStyleRoutesProductionWordThroughUnifiedRenderer(t *testing.T) { t.Fatal(err) } body := string(raw) - for _, required := range []string{"render_document", "pending-human-visual-review", "RDM"} { + for _, required := range []string{"render_document", "已发布", "2026-10-16", "approved", "RDM", "禁止 Backend 默认回退"} { if !strings.Contains(body, required) { t.Errorf("house-style skill missing %q", required) } } + for _, stale := range []string{"pending-human-visual-review", "默认候选"} { + if strings.Contains(body, stale) { + t.Errorf("house-style still describes the organization default as unpublished: %q", stale) + } + } for _, forbidden := range []string{"AGENT_SYSTEM_LEGACY_WORD_COMPARISON", "docx_kit", "new_document(template=", "dx.save("} { if strings.Contains(body, forbidden) { t.Fatalf("house-style still advertises Word bypass %q", forbidden) @@ -195,6 +200,24 @@ func TestHouseStyleRoutesProductionWordThroughUnifiedRenderer(t *testing.T) { } } +func TestDocxAuthorDescribesPublishedDefaultOnlyForWorkspaceWord(t *testing.T) { + raw, err := recipes.ReadFile("recipes/docx-author/SKILL.md") + if err != nil { + t.Fatal(err) + } + body := string(raw) + for _, required := range []string{"render_document", "已发布", "2026-10-16", "approved", "RDM", "禁止默认回退"} { + if !strings.Contains(body, required) { + t.Errorf("docx-author skill missing %q", required) + } + } + for _, stale := range []string{"pending-human-visual-review", "默认候选"} { + if strings.Contains(body, stale) { + t.Errorf("docx-author still describes the organization default as unpublished: %q", stale) + } + } +} + func TestHouseStylePython(t *testing.T) { if _, err := exec.LookPath("python3"); err != nil { t.Skip("python3 not available") diff --git a/internal/tools/document_renderer.go b/internal/tools/document_renderer.go index c3c7a83..6f747a7 100644 --- a/internal/tools/document_renderer.go +++ b/internal/tools/document_renderer.go @@ -17,7 +17,7 @@ import ( func registerDocumentRenderer(r *Registry) error { return r.Register(core.ToolDesc{ Name: "render_document", Source: core.SourceBuiltin, Edits: true, Risk: "medium", - Description: "把普通工作区 Markdown 通过统一文档渲染器生成 Markdown、DOCX、manifest 和可下载归档。只允许非受控工作区交付；项目受控文档必须交给 RDM。公司默认规则仍是待视觉评审候选，状态会写入 manifest。", + Description: "把普通工作区 Markdown 通过统一文档渲染器生成 Markdown、DOCX、manifest 和可下载归档。只允许非受控工作区交付；项目受控文档必须交给 RDM。公司默认规则已发布（负责人 2026-10-16 批准），但只用于普通工作区的 working/preview 交付，评审状态会写入 manifest。", Parameters: json.RawMessage(`{"type":"object","additionalProperties":false,"properties":{` + `"operationId":{"type":"string"},"name":{"type":"string"},"documentId":{"type":"string"},"documentType":{"type":"string"},` + `"language":{"type":"string"},"markdown":{"type":"string"},` + diff --git a/internal/tools/document_renderer_test.go b/internal/tools/document_renderer_test.go index 653bc3b..4e63ea5 100644 --- a/internal/tools/document_renderer_test.go +++ b/internal/tools/document_renderer_test.go @@ -90,6 +90,25 @@ func TestRenderDocumentToolWritesMarkdownFirstAndReportsPackageHashes(t *testing } } +func TestRenderDocumentToolDescriptionReportsPublishedWorkspaceDefault(t *testing.T) { + registry := NewRegistry() + if err := registry.RegisterBuiltin(); err != nil { + t.Fatal(err) + } + description, _, found := registry.Get("render_document") + if !found { + t.Fatal("render_document is not registered") + } + for _, required := range []string{"已发布", "RDM", "非受控工作区"} { + if !strings.Contains(description.Description, required) { + t.Errorf("render_document description missing %q: %s", required, description.Description) + } + } + if strings.Contains(description.Description, "候选") { + t.Errorf("render_document description still calls the organization default a candidate: %s", description.Description) + } +} + func TestRenderDocumentToolSchemaIsClosedAndUsesOnlyOperationIdentity(t *testing.T) { registry := NewRegistry() if err := registry.RegisterBuiltin(); err != nil { -- 2.54.0 From 935c82276d231419a25b66decf0e1b8d83836621 Mon Sep 17 00:00:00 2001 From: weichen Date: Sat, 17 Oct 2026 05:24:24 +0000 Subject: [PATCH 38/41] Bump agent-document-renderer to 1095077 for node-located content diagnostics Why: agent-document-renderer 1095077 (origin/main 10950774) adds node-located content diagnostics (required_content_missing, intentionally_empty, template_placeholder_left, mapping_fallback, signature_data_missing, mapping_unresolved, mapping_ambiguous), a mapping Required flag, the intentionally-empty model property, refusal of approved output with missing required content or trusted signature data, expansion of empty w:sdtContent so content lands inside content controls, and nested mapped content controls rendered inside parent slots. Backend pinned 31fbe54. Evidence: go generate ./internal/docgen and go run ./internal/docgen/internal/genrendereridentity -check ok; go vet ./... exit 0; gofmt -l on changed Go files empty; go test -count=1 ./... exit 0 (42 packages ok, including renderer integration tests in internal/docgen); renderer submodule go test -count=1 ./... ok at 10950774. New TestRendererNodeDiagnosticsPassThroughUnchanged asserts renderer codes, severities, NodeID and RulePath pass unchanged through the manifest and DiagnosticError. git diff --cached --check clean. Impact: Renderer identity and the published pin move to 10950774736b64b5d8e544ce03d45ae5a6ceca7c. Backend only renders ordinary workspace working/preview documents; approved and review modes still route to RDM before the renderer runs, so the approved refusal paths are not reachable from Backend. Typical Backend documents produce no new diagnostics and their DOCX output is unchanged in the test suite. Node diagnostics on the failure path are still returned only as DiagnosticError values and are not added to the operation receipt, which carries error text only; that contract is unchanged. Refs: unified renderer plan Tasks 10/13 Co-authored-by: Cursor --- deps/agent-document-renderer | 2 +- .../docgen/renderer_identity_generated.go | 2 +- internal/docgen/renderer_integration_test.go | 67 ++++++++++++++++++- 3 files changed, 68 insertions(+), 3 deletions(-) diff --git a/deps/agent-document-renderer b/deps/agent-document-renderer index 31fbe54..1095077 160000 --- a/deps/agent-document-renderer +++ b/deps/agent-document-renderer @@ -1 +1 @@ -Subproject commit 31fbe54fae8bf11be664919ce173da0d68ebfdc9 +Subproject commit 10950774736b64b5d8e544ce03d45ae5a6ceca7c diff --git a/internal/docgen/renderer_identity_generated.go b/internal/docgen/renderer_identity_generated.go index ec759b3..7dd2f37 100644 --- a/internal/docgen/renderer_identity_generated.go +++ b/internal/docgen/renderer_identity_generated.go @@ -2,6 +2,6 @@ package docgen -const rendererRevision = "31fbe54fae8bf11be664919ce173da0d68ebfdc9" +const rendererRevision = "10950774736b64b5d8e544ce03d45ae5a6ceca7c" const RendererIdentity = "agent-document-renderer@" + rendererRevision diff --git a/internal/docgen/renderer_integration_test.go b/internal/docgen/renderer_integration_test.go index d8b989d..55db1fe 100644 --- a/internal/docgen/renderer_integration_test.go +++ b/internal/docgen/renderer_integration_test.go @@ -367,7 +367,7 @@ func TestPersistedControlledMetadataRoutesBeforeDefaultProfileLoad(t *testing.T) } func TestRendererIdentityMatchesPublishedPin(t *testing.T) { - const want = "agent-document-renderer@31fbe54fae8bf11be664919ce173da0d68ebfdc9" + const want = "agent-document-renderer@10950774736b64b5d8e544ce03d45ae5a6ceca7c" if RendererIdentity != want { t.Fatalf("RendererIdentity = %q, want %q", RendererIdentity, want) } @@ -502,6 +502,71 @@ func TestGenerateReturnsTypedDiagnosticsForUnsafeMarkdownAndAssets(t *testing.T) } } +// TestRendererNodeDiagnosticsPassThroughUnchanged pins the wire contract for +// node-located content diagnostics: the renderer's codes, severities, NodeID +// and RulePath reach the manifest and the typed failure without rewriting. +func TestRendererNodeDiagnosticsPassThroughUnchanged(t *testing.T) { + warnings := []render.Diagnostic{ + {Code: "required_content_missing", Severity: render.SeverityWarning, NodeID: "node-7", RulePath: "mappings[2]", Message: "required node node-7 is empty", Suggestion: "add content"}, + {Code: "intentionally_empty", Severity: render.SeverityInfo, NodeID: "node-8", RulePath: "mappings[2]", Message: "node node-8 is intentionally empty"}, + {Code: "mapping_fallback", Severity: render.SeverityWarning, NodeID: "node-9", Message: "style not defined", Suggestion: "define the style"}, + } + deps := defaultGeneratorDependencies() + deps.newRenderer = func(*profile.AssetReader) render.Renderer { + return diagnosticsRenderer{diagnostics: warnings} + } + delivery, err := generate(context.Background(), workspaceRequest([]byte(representativeMarkdown)), deps) + if err != nil { + t.Fatalf("generate with warnings: %v", err) + } + var manifest Manifest + if err := json.Unmarshal(delivery.Manifest.Bytes, &manifest); err != nil { + t.Fatal(err) + } + if !reflect.DeepEqual(manifest.Diagnostics, warnings) { + t.Fatalf("manifest diagnostics = %#v, want renderer diagnostics %#v", manifest.Diagnostics, warnings) + } + for _, fragment := range []string{`"nodeId": "node-7"`, `"rulePath": "mappings[2]"`, `"code": "required_content_missing"`} { + if !strings.Contains(string(delivery.Manifest.Bytes), fragment) { + t.Errorf("manifest JSON omits %s", fragment) + } + } + + refusal := []render.Diagnostic{{Code: "mapping_unresolved", Severity: render.SeverityError, NodeID: "node-3", Message: "node node-3 cannot be mapped"}} + deps.newRenderer = func(*profile.AssetReader) render.Renderer { + return diagnosticsRenderer{diagnostics: refusal, err: errors.New("word: mapping unresolved for node node-3")} + } + _, err = generate(context.Background(), workspaceRequest([]byte(representativeMarkdown)), deps) + var diagnostic *DiagnosticError + if !errors.As(err, &diagnostic) { + t.Fatalf("refusal error %T %v is not a DiagnosticError", err, err) + } + if !reflect.DeepEqual(diagnostic.Diagnostics, refusal) { + t.Fatalf("refusal diagnostics = %#v, want %#v", diagnostic.Diagnostics, refusal) + } +} + +// diagnosticsRenderer returns fixed renderer diagnostics without a template, so +// the Backend's carriage of the renderer's diagnostics is tested on its own. +type diagnosticsRenderer struct { + diagnostics []render.Diagnostic + err error +} + +func (renderer diagnosticsRenderer) Validate(context.Context, render.Request) ([]render.Diagnostic, error) { + return renderer.diagnostics, renderer.err +} + +func (renderer diagnosticsRenderer) Render(context.Context, render.Request) (render.Result, error) { + if renderer.err != nil { + return render.Result{Diagnostics: renderer.diagnostics}, renderer.err + } + return render.Result{ + Artifact: []byte("docx"), MIME: "application/vnd.openxmlformats-officedocument.wordprocessingml.document", + Diagnostics: renderer.diagnostics, + }, nil +} + type failingRenderer struct{ err error } func (renderer failingRenderer) Validate(context.Context, render.Request) ([]render.Diagnostic, error) { -- 2.54.0 From c34279ad5510ac9b73e587438c8b4b36cf73b977 Mon Sep 17 00:00:00 2001 From: weichen Date: Sun, 18 Oct 2026 06:24:36 +0000 Subject: [PATCH 39/41] Bump the renderer to 3f25999 and bind documents to published profile versions MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Why: Agent-Document-Renderer main publishes company.default@1.1.0 with a declarative TOC (spec 04, acceptance 10 §4 §7) and keeps 1.0.0 loadable by version. The fixed defaultProfileVersion "1.0.0" no longer matched LoadCompanyDefaultContext (1.1.0), so every delivery failed with a profile mismatch. New documents must take the latest published version, while documents that already bind a published version keep rendering with exactly that version, because published rules are immutable and old versions remain retrievable (spec 08). Evidence: go vet ./... ok; go test -count=1 ./... ok (all packages); go run ./internal/docgen/internal/genrendereridentity -check ok; scripts/agent-exec validate --repo . ok; scripts/dm governance check --repo . ok; gofmt -l clean; git diff --cached --check clean. New tests cover the default binding (1.1.0, TOC present), pinned 1.0.0 (no TOC) and 1.1.0 for both a request pin and a persisted-Markdown replay, and refusal of unknown versions and other profile IDs before any profile load. Impact: docgen resolves the profile version from the persisted Markdown binding or the request, defaults new documents to profiles.LatestCompanyDefaultVersion, and loads it through LoadCompanyDefaultVersionContext. The legacy migration comparison records the declared TOC as an intentional corporate-layout difference (RDR-T10-CMP-002) and keeps it out of the body visible-text dimension. RendererIdentity is regenerated for 3f259990b5d4. Refs: unified renderer plan Task 13; renderer PR #7 Co-authored-by: Cursor --- deps/agent-document-renderer | 2 +- internal/docgen/comparison.go | 54 ++++- internal/docgen/renderer.go | 70 ++++-- .../docgen/renderer_identity_generated.go | 2 +- internal/docgen/renderer_integration_test.go | 200 +++++++++++++++++- 5 files changed, 300 insertions(+), 28 deletions(-) diff --git a/deps/agent-document-renderer b/deps/agent-document-renderer index 1095077..3f25999 160000 --- a/deps/agent-document-renderer +++ b/deps/agent-document-renderer @@ -1 +1 @@ -Subproject commit 10950774736b64b5d8e544ce03d45ae5a6ceca7c +Subproject commit 3f259990b5d43ec0d318f39d496816140ab559b5 diff --git a/internal/docgen/comparison.go b/internal/docgen/comparison.go index 3996cdb..512b0b6 100644 --- a/internal/docgen/comparison.go +++ b/internal/docgen/comparison.go @@ -62,6 +62,7 @@ type docxNumbering struct { type docxComparison struct { Paragraphs []string `json:"paragraphs"` + TOC []string `json:"toc"` PageSize map[string]string `json:"pageSize"` Margins map[string]string `json:"margins"` Headers int `json:"headers"` @@ -95,7 +96,7 @@ func compareLegacyAndShared(title string, source []byte, canonical model.Canonic if legacyErr != nil || sharedErr != nil { detail := fmt.Sprintf("legacy=%v shared=%v", legacyErr, sharedErr) for _, name := range []string{ - "visible-text", "page-layout", "header-footer", "node-bookmarks", "safe-links", "security-objects", "word-semantics", + "visible-text", "table-of-contents", "page-layout", "header-footer", "node-bookmarks", "safe-links", "security-objects", "word-semantics", "word-numbering", "word-task-state", "word-thematic-rule", "word-table-alignment", } { receipt.Dimensions = append(receipt.Dimensions, ComparisonDimension{Name: name, Status: "unassessed", Detail: detail}) @@ -115,6 +116,12 @@ func compareLegacyAndShared(title string, source []byte, canonical model.Canonic } else { receipt.Dimensions = append(receipt.Dimensions, compareExactDimension("visible-text", legacyParagraphs, sharedDOCX.Paragraphs, "")) } + if len(legacyDOCX.TOC) == 0 && len(sharedDOCX.TOC) > 0 { + receipt.Dimensions = append(receipt.Dimensions, intentionalDimension("table-of-contents", legacyDOCX.TOC, sharedDOCX.TOC, + comparisonExceptionCorporate, "published organization default declares a table of contents")) + } else { + receipt.Dimensions = append(receipt.Dimensions, compareExactDimension("table-of-contents", legacyDOCX.TOC, sharedDOCX.TOC, "")) + } if equalJSON(legacyDOCX.PageSize, sharedDOCX.PageSize) { receipt.Dimensions = append(receipt.Dimensions, compareExactDimension("page-size", legacyDOCX.PageSize, sharedDOCX.PageSize, "")) @@ -501,6 +508,11 @@ func inspectComparisonDOCX(raw []byte) (docxComparison, error) { inParagraph, inText, inCell, inParagraphBorder := false, false, false, false paragraphLevel, paragraphNumID, cellAlignment := 0, "", "" paragraphRule := false + // A TOC is its field's paragraphs plus an immediately preceding caption + // paragraph excluded from the outline (outlineLvl 9). + inInstruction, paragraphTOC, paragraphCaption := false, false, false + fieldDepth, tocFieldDepth := 0, 0 + var pendingCaption []string var table [][]string var row []string for { @@ -518,10 +530,27 @@ func inspectComparisonDOCX(raw []byte) (docxComparison, error) { inParagraph = true paragraph.Reset() paragraphLevel, paragraphNumID, paragraphRule = 0, "", false + paragraphTOC, paragraphCaption = tocFieldDepth > 0, false case "t": if inParagraph { inText = true } + case "outlineLvl": + if inParagraph && xmlAttributeValue(value.Attr, "val") == "9" { + paragraphCaption = true + } + case "fldChar": + switch xmlAttributeValue(value.Attr, "fldCharType") { + case "begin": + fieldDepth++ + case "end": + if fieldDepth == tocFieldDepth { + tocFieldDepth = 0 + } + fieldDepth = max(fieldDepth-1, 0) + } + case "instrText": + inInstruction = true case "numId": if inParagraph { paragraphNumID = xmlAttributeValue(value.Attr, "val") @@ -559,15 +588,35 @@ func inspectComparisonDOCX(raw []byte) (docxComparison, error) { if inText { paragraph.Write(value) } + if inInstruction && tocFieldDepth == 0 && fieldDepth > 0 { + if fields := strings.Fields(string(value)); len(fields) > 0 && strings.EqualFold(fields[0], "TOC") { + tocFieldDepth, paragraphTOC = fieldDepth, inParagraph + } + } case xml.EndElement: switch value.Name.Local { case "t": inText = false + case "instrText": + inInstruction = false case "pBdr": inParagraphBorder = false case "p": text := normalizeComparisonText(paragraph.String()) - if text != "" { + if paragraphTOC { + result.TOC = append(result.TOC, pendingCaption...) + pendingCaption = nil + if text != "" { + result.TOC = append(result.TOC, text) + } + inParagraph = false + break + } + result.Paragraphs = append(result.Paragraphs, pendingCaption...) + pendingCaption = nil + if text != "" && paragraphCaption { + pendingCaption = []string{text} + } else if text != "" { result.Paragraphs = append(result.Paragraphs, text) } if paragraphNumID != "" { @@ -596,6 +645,7 @@ func inspectComparisonDOCX(raw []byte) (docxComparison, error) { } } } + result.Paragraphs = append(result.Paragraphs, pendingCaption...) if len(numbered) > 0 { numbering, found := parts["word/numbering.xml"] if !found { diff --git a/internal/docgen/renderer.go b/internal/docgen/renderer.go index 5ba8fb4..f60a435 100644 --- a/internal/docgen/renderer.go +++ b/internal/docgen/renderer.go @@ -9,6 +9,7 @@ import ( "encoding/json" "errors" "fmt" + "slices" "sort" "strings" "time" @@ -26,7 +27,6 @@ const ( ManifestSchemaVersion = "backend-document-delivery/v1" AdapterIdentity = RendererIdentity + "/word-adapter-v1" defaultProfileID = "company.default" - defaultProfileVersion = "1.0.0" defaultRenderCapacity = 4 ) @@ -194,18 +194,15 @@ func Prepare(ctx context.Context, request Request) (PreparedDocument, error) { if err := validateWorkspaceRoute(request, parsed.Metadata); err != nil { return PreparedDocument{}, err } - if parsed.Metadata.ProfileID != defaultProfileID || parsed.Metadata.ProfileVersion != defaultProfileVersion { - return PreparedDocument{}, fmt.Errorf("%w: Markdown binds %s@%s, expected %s@%s", ErrProfileMismatch, - parsed.Metadata.ProfileID, parsed.Metadata.ProfileVersion, defaultProfileID, defaultProfileVersion) + if _, err := profileVersionFor(request, &parsed.Metadata); err != nil { + return PreparedDocument{}, err } } else { - if request.ProfileID != "" || request.ProfileVersion != "" { - if request.ProfileID != defaultProfileID || request.ProfileVersion != defaultProfileVersion { - return PreparedDocument{}, fmt.Errorf("%w: requested %s@%s, expected %s@%s", ErrProfileMismatch, - request.ProfileID, request.ProfileVersion, defaultProfileID, defaultProfileVersion) - } + profileVersion, err := profileVersionFor(request, nil) + if err != nil { + return PreparedDocument{}, err } - source, err := workspaceMarkdown(request, defaultProfileID, defaultProfileVersion) + source, err := workspaceMarkdown(request, defaultProfileID, profileVersion) if err != nil { return PreparedDocument{}, err } @@ -231,14 +228,14 @@ func Prepare(ctx context.Context, request Request) (PreparedDocument, error) { } type generatorDependencies struct { - loadDefault func(context.Context) (profiles.Bundle, error) + loadProfile func(context.Context, string) (profiles.Bundle, error) newRenderer func(*profile.AssetReader) render.Renderer legacyBuild func(string, string) ([]byte, error) } func defaultGeneratorDependencies() generatorDependencies { return generatorDependencies{ - loadDefault: profiles.LoadCompanyDefaultContext, + loadProfile: profiles.LoadCompanyDefaultVersionContext, newRenderer: func(assets *profile.AssetReader) render.Renderer { return word.NewAdapter(assets) }, legacyBuild: legacyBuild, } @@ -274,6 +271,7 @@ func generateWithOptions(ctx context.Context, request Request, options RenderOpt return Delivery{}, fmt.Errorf("%w: Markdown is %d bytes, limit is %d", ErrResourceLimit, len(request.Markdown), limits.MaxMarkdownBytes) } var parsed markdownrenderer.Result + var boundMetadata *markdownrenderer.Metadata materialized := bytes.HasPrefix(bytes.TrimSpace(request.Markdown), []byte("---")) if materialized { parsed, err = parseMarkdownContext(ctx, request.Markdown, false, limits) @@ -283,17 +281,20 @@ func generateWithOptions(ctx context.Context, request Request, options RenderOpt if err := validateWorkspaceRoute(request, parsed.Metadata); err != nil { return Delivery{}, err } + boundMetadata = &parsed.Metadata } - bundle, err := dependencies.loadDefault(ctx) + boundVersion, err := profileVersionFor(request, boundMetadata) if err != nil { - return Delivery{}, fmt.Errorf("docgen: load company default: %w", err) + return Delivery{}, err + } + bundle, err := dependencies.loadProfile(ctx, boundVersion) + if err != nil { + return Delivery{}, fmt.Errorf("docgen: load company default %s: %w", boundVersion, err) } profileID, profileVersion := bundle.Snapshot.ProfileIdentity() - if request.ProfileID != "" || request.ProfileVersion != "" { - if request.ProfileID != profileID || request.ProfileVersion != profileVersion { - return Delivery{}, fmt.Errorf("%w: requested %s@%s, available %s@%s", ErrProfileMismatch, - request.ProfileID, request.ProfileVersion, profileID, profileVersion) - } + if profileID != defaultProfileID || profileVersion != boundVersion { + return Delivery{}, fmt.Errorf("%w: loaded %s@%s, bound %s@%s", ErrProfileMismatch, + profileID, profileVersion, defaultProfileID, boundVersion) } if !materialized { source, sourceErr := workspaceMarkdown(request, profileID, profileVersion) @@ -481,6 +482,37 @@ func validateWorkspaceRoute(request Request, metadata markdownrenderer.Metadata) return nil } +// profileVersionFor returns the company-default version a document renders +// with. Published versions are immutable, so a version the persisted Markdown +// or the request already binds is kept; only a new, unbound document takes the +// latest published version. metadata is nil until Markdown is materialized. +func profileVersionFor(request Request, metadata *markdownrenderer.Metadata) (string, error) { + requested := request.ProfileID != "" || request.ProfileVersion != "" + if requested && !publishedProfileVersion(request.ProfileID, request.ProfileVersion) { + return "", fmt.Errorf("%w: requested %s@%s is not a published %s version", ErrProfileMismatch, + request.ProfileID, request.ProfileVersion, defaultProfileID) + } + if metadata == nil { + if requested { + return request.ProfileVersion, nil + } + return profiles.LatestCompanyDefaultVersion, nil + } + if !publishedProfileVersion(metadata.ProfileID, metadata.ProfileVersion) { + return "", fmt.Errorf("%w: Markdown binds %s@%s, which is not a published %s version", ErrProfileMismatch, + metadata.ProfileID, metadata.ProfileVersion, defaultProfileID) + } + if requested && request.ProfileVersion != metadata.ProfileVersion { + return "", fmt.Errorf("%w: requested %s@%s, Markdown binds %s@%s", ErrProfileMismatch, + request.ProfileID, request.ProfileVersion, metadata.ProfileID, metadata.ProfileVersion) + } + return metadata.ProfileVersion, nil +} + +func publishedProfileVersion(profileID, profileVersion string) bool { + return profileID == defaultProfileID && slices.Contains(profiles.CompanyDefaultVersions(), profileVersion) +} + func validateWorkspaceMetadata(request Request, metadata markdownrenderer.Metadata, profileID, profileVersion string) error { if err := validateWorkspaceRoute(request, metadata); err != nil { return err diff --git a/internal/docgen/renderer_identity_generated.go b/internal/docgen/renderer_identity_generated.go index 7dd2f37..14aad20 100644 --- a/internal/docgen/renderer_identity_generated.go +++ b/internal/docgen/renderer_identity_generated.go @@ -2,6 +2,6 @@ package docgen -const rendererRevision = "10950774736b64b5d8e544ce03d45ae5a6ceca7c" +const rendererRevision = "3f259990b5d43ec0d318f39d496816140ab559b5" const RendererIdentity = "agent-document-renderer@" + rendererRevision diff --git a/internal/docgen/renderer_integration_test.go b/internal/docgen/renderer_integration_test.go index 55db1fe..ca919b4 100644 --- a/internal/docgen/renderer_integration_test.go +++ b/internal/docgen/renderer_integration_test.go @@ -160,7 +160,7 @@ func TestGeneratePersistsCanonicalMarkdownWithStableNodeParity(t *testing.T) { if reparsed.Metadata.DocumentID != "workspace-minutes" || reparsed.Metadata.ProjectID != WorkspaceProjectID || reparsed.Metadata.DocumentType != "general" || reparsed.Metadata.Title != "研发周会纪要" || reparsed.Metadata.Language != "zh-CN" || reparsed.Metadata.ProfileID != "company.default" || - reparsed.Metadata.ProfileVersion != "1.0.0" || reparsed.Metadata.Controlled { + reparsed.Metadata.ProfileVersion != profiles.LatestCompanyDefaultVersion || reparsed.Metadata.Controlled { t.Fatalf("controlled metadata changed: %#v", reparsed.Metadata) } @@ -355,10 +355,10 @@ func TestPersistedControlledMetadataRoutesBeforeDefaultProfileLoad(t *testing.T) request.Title = "Controlled" loads := 0 deps := defaultGeneratorDependencies() - baseLoad := deps.loadDefault - deps.loadDefault = func(ctx context.Context) (profiles.Bundle, error) { + baseLoad := deps.loadProfile + deps.loadProfile = func(ctx context.Context, version string) (profiles.Bundle, error) { loads++ - return baseLoad(ctx) + return baseLoad(ctx, version) } _, err := generate(context.Background(), request, deps) if !errors.Is(err, ErrRDMRequired) || loads != 0 { @@ -367,7 +367,7 @@ func TestPersistedControlledMetadataRoutesBeforeDefaultProfileLoad(t *testing.T) } func TestRendererIdentityMatchesPublishedPin(t *testing.T) { - const want = "agent-document-renderer@10950774736b64b5d8e544ce03d45ae5a6ceca7c" + const want = "agent-document-renderer@3f259990b5d43ec0d318f39d496816140ab559b5" if RendererIdentity != want { t.Fatalf("RendererIdentity = %q, want %q", RendererIdentity, want) } @@ -456,6 +456,157 @@ func TestGenerateRejectsProfileAndAssetMismatch(t *testing.T) { } } +const tocFieldInstruction = `TOC \o "1-` + +func TestGenerateBindsNewDocumentsToLatestPublishedProfile(t *testing.T) { + request := workspaceRequest([]byte(representativeMarkdown)) + prepared, err := Prepare(context.Background(), request) + if err != nil { + t.Fatalf("Prepare: %v", err) + } + delivery, err := Generate(context.Background(), request) + if err != nil { + t.Fatalf("Generate: %v", err) + } + latest, err := profiles.LoadCompanyDefault() + if err != nil { + t.Fatal(err) + } + if _, version := latest.Snapshot.ProfileIdentity(); version != profiles.LatestCompanyDefaultVersion { + t.Fatalf("renderer latest company default = %s, want %s", version, profiles.LatestCompanyDefaultVersion) + } + for name, markdown := range map[string][]byte{"Prepare": prepared.Markdown.Bytes, "Generate": delivery.Markdown.Bytes} { + metadata := persistedMetadata(t, markdown) + if metadata.ProfileID != "company.default" || metadata.ProfileVersion != profiles.LatestCompanyDefaultVersion { + t.Fatalf("%s bound new document to %s@%s, want company.default@%s", name, metadata.ProfileID, metadata.ProfileVersion, profiles.LatestCompanyDefaultVersion) + } + } + if delivery.Profile.Version != profiles.LatestCompanyDefaultVersion || delivery.Profile.SnapshotHash != latest.Snapshot.SnapshotHash() { + t.Fatalf("delivery profile receipt = %#v, want latest snapshot %s", delivery.Profile, latest.Snapshot.SnapshotHash()) + } + documentXML := docxPart(t, delivery.DOCX.Bytes, "word/document.xml") + if !strings.Contains(documentXML, tocFieldInstruction) || !strings.Contains(docxVisibleText(t, delivery.DOCX.Bytes), "目录") { + t.Fatal("new document rendered with the latest company default omitted its declared TOC") + } +} + +func TestGenerateKeepsPinnedPublishedProfileVersion(t *testing.T) { + for _, test := range []struct { + version string + toc bool + }{ + {version: "1.0.0", toc: false}, + {version: "1.1.0", toc: true}, + } { + t.Run(test.version, func(t *testing.T) { + pinned, err := profiles.LoadCompanyDefaultVersion(test.version) + if err != nil { + t.Fatal(err) + } + request := workspaceRequest([]byte(representativeMarkdown)) + request.ProfileID, request.ProfileVersion = "company.default", test.version + prepared, err := Prepare(context.Background(), request) + if err != nil { + t.Fatalf("Prepare pinned %s: %v", test.version, err) + } + if metadata := persistedMetadata(t, prepared.Markdown.Bytes); metadata.ProfileVersion != test.version { + t.Fatalf("Prepare bound pinned request to %s, want %s", metadata.ProfileVersion, test.version) + } + first, err := Generate(context.Background(), request) + if err != nil { + t.Fatalf("Generate pinned %s: %v", test.version, err) + } + + replay := workspaceRequest(first.Markdown.Bytes) + second, err := Generate(context.Background(), replay) + if err != nil { + t.Fatalf("Generate persisted %s Markdown: %v", test.version, err) + } + for name, delivery := range map[string]Delivery{"pinned request": first, "persisted replay": second} { + if delivery.Profile.ProfileID != "company.default" || delivery.Profile.Version != test.version || + delivery.Profile.SnapshotHash != pinned.Snapshot.SnapshotHash() || delivery.Profile.ProfileSHA256 != pinned.Review.ProfileSHA256 { + t.Fatalf("%s profile receipt = %#v, want company.default@%s snapshot %s", name, delivery.Profile, test.version, pinned.Snapshot.SnapshotHash()) + } + if metadata := persistedMetadata(t, delivery.Markdown.Bytes); metadata.ProfileVersion != test.version { + t.Fatalf("%s Markdown binds %s, want %s", name, metadata.ProfileVersion, test.version) + } + if got := strings.Contains(docxPart(t, delivery.DOCX.Bytes, "word/document.xml"), tocFieldInstruction); got != test.toc { + t.Fatalf("%s TOC present = %v, want %v for company.default@%s", name, got, test.toc, test.version) + } + } + if !bytes.Equal(first.DOCX.Bytes, second.DOCX.Bytes) { + t.Fatal("replaying persisted Markdown changed the pinned delivery bytes") + } + }) + } +} + +func TestProfileBindingRefusesUnpublishedVersionsBeforeLoad(t *testing.T) { + persisted, err := Generate(context.Background(), workspaceRequest([]byte(representativeMarkdown))) + if err != nil { + t.Fatal(err) + } + latestBinding := []byte("profileVersion: \"" + profiles.LatestCompanyDefaultVersion + "\"\n") + if !bytes.Contains(persisted.Markdown.Bytes, latestBinding) { + t.Fatalf("persisted Markdown does not carry %q", latestBinding) + } + pinnedOld := workspaceRequest(bytes.Replace(persisted.Markdown.Bytes, latestBinding, []byte("profileVersion: \"1.0.0\"\n"), 1)) + pinnedOld.ProfileID, pinnedOld.ProfileVersion = "company.default", profiles.LatestCompanyDefaultVersion + + tests := map[string]Request{} + for name, identity := range map[string][2]string{ + "unknown version": {"company.default", "9.9.9"}, + "other profile": {"company.other", "1.0.0"}, + "missing version": {"company.default", ""}, + "missing profile id": {"", "1.0.0"}, + } { + request := workspaceRequest([]byte(representativeMarkdown)) + request.ProfileID, request.ProfileVersion = identity[0], identity[1] + tests["requested "+name] = request + } + tests["persisted unknown version"] = workspaceRequest(bytes.Replace(persisted.Markdown.Bytes, latestBinding, []byte("profileVersion: \"9.9.9\"\n"), 1)) + tests["persisted other profile"] = workspaceRequest(bytes.Replace(persisted.Markdown.Bytes, + []byte("profileId: \"company.default\"\n"), []byte("profileId: \"company.other\"\n"), 1)) + tests["request disagrees with persisted binding"] = pinnedOld + + for name, request := range tests { + t.Run(name, func(t *testing.T) { + if _, err := Prepare(context.Background(), request); !errors.Is(err, ErrProfileMismatch) { + t.Fatalf("Prepare error = %v, want ErrProfileMismatch", err) + } + loads := 0 + deps := defaultGeneratorDependencies() + baseLoad := deps.loadProfile + deps.loadProfile = func(ctx context.Context, version string) (profiles.Bundle, error) { + loads++ + return baseLoad(ctx, version) + } + if _, err := generate(context.Background(), request, deps); !errors.Is(err, ErrProfileMismatch) || loads != 0 { + t.Fatalf("Generate error = %v profileLoads=%d, want ErrProfileMismatch before load", err, loads) + } + }) + } +} + +func TestGenerateRefusesLoadedProfileWithUnexpectedIdentity(t *testing.T) { + deps := defaultGeneratorDependencies() + deps.loadProfile = func(ctx context.Context, _ string) (profiles.Bundle, error) { + return profiles.LoadCompanyDefaultVersionContext(ctx, "1.0.0") + } + if _, err := generate(context.Background(), workspaceRequest([]byte(representativeMarkdown)), deps); !errors.Is(err, ErrProfileMismatch) { + t.Fatalf("Generate with a loader returning the wrong version error = %v, want ErrProfileMismatch", err) + } +} + +func persistedMetadata(t *testing.T, markdown []byte) markdownrenderer.Metadata { + t.Helper() + parsed, err := markdownrenderer.Parse(markdown, markdownrenderer.Options{MaxBytes: 2 << 20, MaxNodes: 10_000, MaxDepth: 64}) + if err != nil { + t.Fatalf("persisted Markdown is not parseable: %v", err) + } + return parsed.Metadata +} + func TestGenerateEnforcesLimitsAndCancellation(t *testing.T) { request := workspaceRequest([]byte(representativeMarkdown)) request.Limits.MaxMarkdownBytes = 32 @@ -713,6 +864,45 @@ func TestRepresentativeLegacyComparisonRecordsOnlyIntentionalDifferences(t *test t.Errorf("corporate layout exception %s detail = %q, want published organization default", dimension.Name, dimension.Detail) } } + if dimension := comparisonDimension(t, delivery.Comparison, "table-of-contents"); dimension.Status != "intentional" || dimension.ExceptionID != comparisonExceptionCorporate { + t.Errorf("declared TOC comparison = %#v, want intentional %s", dimension, comparisonExceptionCorporate) + } + if dimension := comparisonDimension(t, delivery.Comparison, "visible-text"); dimension.Status == "accidental" { + t.Errorf("declared TOC leaked into the body visible-text comparison: %#v", dimension) + } + + request.ProfileID, request.ProfileVersion = "company.default", "1.0.0" + pinned, err := generateWithOptions(context.Background(), request, RenderOptions{MigrationComparison: true}, defaultGeneratorDependencies()) + if err != nil { + t.Fatal(err) + } + if pinned.Comparison.Assessment != "assessed" || len(pinned.Comparison.AccidentalDifferences) != 0 { + t.Fatalf("pinned 1.0.0 comparison has accidental differences: %#v", pinned.Comparison.AccidentalDifferences) + } + if dimension := comparisonDimension(t, pinned.Comparison, "table-of-contents"); dimension.Status != "match" { + t.Errorf("pinned 1.0.0 TOC comparison = %#v, want match without a TOC", dimension) + } +} + +func TestComparisonKeepsBodyTextLossAccidentalBesideDeclaredTOC(t *testing.T) { + const source = "# Report\n\n## Scope\n\nScope body.\n\n## Result\n\nResult body.\n" + request := workspaceRequest([]byte(source)) + request.Title = "Report" + delivery, err := Generate(context.Background(), request) + if err != nil { + t.Fatal(err) + } + legacy, err := legacyBuild(request.Title, "# Report\n\n## Scope\n\nScope body.\n\n## Result\n\nDifferent body.\n") + if err != nil { + t.Fatal(err) + } + receipt := compareLegacyAndShared(request.Title, []byte(source), delivery.Document, legacy, delivery.DOCX.Bytes) + if dimension := comparisonDimension(t, receipt, "table-of-contents"); dimension.Status != "intentional" { + t.Fatalf("declared TOC comparison = %#v, want intentional", dimension) + } + if dimension := comparisonDimension(t, receipt, "visible-text"); dimension.Status != "accidental" { + t.Fatalf("body text loss beside a TOC = %#v, want accidental", dimension) + } } func TestComparisonDetectsCanonicalAndDOCXTableAlignmentLoss(t *testing.T) { -- 2.54.0 From 7b4e2791b587cbb73217e2d6d5936279fa7d297b Mon Sep 17 00:00:00 2001 From: weichen Date: Sun, 18 Oct 2026 12:39:44 +0000 Subject: [PATCH 40/41] Close the W9 project audit task card before merge Why: PR #209 delivers this W9 increment; the card must not stay open on main. Evidence: Backend HEAD 84a6f6f CI vet-and-test and governance succeeded (GATE). Impact: card archived; records the 37-48 migration renumbering and the user-owned v0.6.0 tag. Refs: PR #209 Co-authored-by: Cursor --- .task/{ => archive}/feature-rdm-two-trees-project-audit.md | 0 1 file changed, 0 insertions(+), 0 deletions(-) rename .task/{ => archive}/feature-rdm-two-trees-project-audit.md (100%) diff --git a/.task/feature-rdm-two-trees-project-audit.md b/.task/archive/feature-rdm-two-trees-project-audit.md similarity index 100% rename from .task/feature-rdm-two-trees-project-audit.md rename to .task/archive/feature-rdm-two-trees-project-audit.md -- 2.54.0 From 414747ce43d06b791fbf1dbe288d2e976525b652 Mon Sep 17 00:00:00 2001 From: weichen Date: Sun, 18 Oct 2026 12:39:49 +0000 Subject: [PATCH 41/41] Record the W9 card closure status Why: the previous commit archived the card without its closure line. Evidence: card text only. Impact: none outside .task. Refs: PR #209 Co-authored-by: Cursor --- .task/archive/feature-rdm-two-trees-project-audit.md | 1 + 1 file changed, 1 insertion(+) diff --git a/.task/archive/feature-rdm-two-trees-project-audit.md b/.task/archive/feature-rdm-two-trees-project-audit.md index 04598fb..f26b848 100644 --- a/.task/archive/feature-rdm-two-trees-project-audit.md +++ b/.task/archive/feature-rdm-two-trees-project-audit.md @@ -1,5 +1,6 @@ # W9 Backend project audit candidate +- 状态：已完成（合入前闭合，2026-10-18）。本 W9 增量随统一渲染器 Backend 分支经 PR #209 合入 main；合入前已同步 Backend main `56a7f9f`（合并提交 `84a6f6f`，当前 HEAD CI vet-and-test/governance 成功）。同步时 main 的迁移 36 `instance_guard` 保持不变，本分支迁移整体顺延为 37–48（文中 v33/v34 等编号为同步前历史编号），跑过旧编号未合入构建的数据库须重建。用户 2026-10-18 授权按计划完成并收尾、业务验收在部署上自行进行；受信 tag `v0.6.0` 由用户亲手发布。 - Scope: TT-A01/A02/A04/U04, approved stage 5 W9. Stage 6 local implementation; human review, formal acceptance, PR, CI, tag, and deployment are pending. - Branch/worktree: `feature/rdm-two-trees-project-audit` at `/home/weichen/projects/Agent-System-Backend-wt-feature-rdm-two-trees-project-audit`. - R0: Backend authoritative `origin/main` `5d5fc9891c0eb8994545ccb8b740535d9b99fb0e`; main was clean and equal to the fetched remote before this worktree was created. Core gitlink in this worktree is `5773e74086791731059730bd3726dc8c9cd1381f`. -- 2.54.0