Warn when a seeded model key does not become active #569

Merged
weichen merged 7 commits from fix/model-key-secret-overlay into main 2026-10-15 11:52:25 +00:00
Owner

Summary

Seeding now checks that the embedded database's active system secret matches the env key, and the backend gitlink carries the adoption fix.

Test plan

  • seed fingerprint unit tests in tests/test_svc.py (SELF)
  • CI on this HEAD

Why: replacing the env key did not change the key a conversation sent.
Evidence: three svc seed tests, exit 0, recorded in .task/fix-model-key-secret-overlay.md.
Impact: mismatch warns with fingerprints only. Backend pointer is 24bbb7b.
Refs: fix/model-key-secret-overlay

## Summary Seeding now checks that the embedded database's active system secret matches the env key, and the backend gitlink carries the adoption fix. ## Test plan - [x] seed fingerprint unit tests in tests/test_svc.py (SELF) - [ ] CI on this HEAD Why: replacing the env key did not change the key a conversation sent. Evidence: three svc seed tests, exit 0, recorded in .task/fix-model-key-secret-overlay.md. Impact: mismatch warns with fingerprints only. Backend pointer is 24bbb7b. Refs: fix/model-key-secret-overlay
weichen added 5 commits 2026-10-15 10:35:54 +00:00
Why: establish the authorized task workspace and its initial baseline.

Evidence: preserved precheck receipt in .task/fix-model-key-secret-overlay.md; R0=919f75cf7b39ca357e212a08a0ba5ba3d9a79b51.

Impact: task metadata only; the feature workspace starts at 919f75cf7b.

Refs: .task/fix-model-key-secret-overlay.md
Why: Settings plaintext loses to secret_keys, so replacing the env key did not change the key a conversation actually sent.
Evidence: python3 -m unittest tests.test_svc.SvcDbRecoveryTests.test_seed_replaces_old_system_secret tests.test_svc.SvcDbRecoveryTests.test_seed_warns_when_old_secret_stays_active tests.test_svc.SvcDbRecoveryTests.test_seed_puts_without_credentials_when_auth_off (SELF).
Impact: Embedded databases now compare the active system secret fingerprint after seeding, and the backend gitlink carries the adoption fix.
Refs: fix/model-key-secret-overlay
Co-authored-by: Cursor <cursoragent@cursor.com>
Why: include the current integration baseline before verification.

Evidence: fetched origin/main=dc86a023605d00fccca1b9679b4cdad96373bdee.

Impact: integrate upstream changes without rewriting task history.

Refs: task-sync
Why: bind the task validation checkpoint to the integration baseline.

Evidence: SELF recursive component checks; sync_base=dc86a023605d00fccca1b9679b4cdad96373bdee; before_record=6b2173b9dc33fb8ad4fe72bac1838266ef8f8371.

Impact: task metadata only.

Refs: .task/fix-model-key-secret-overlay.md
Record the secret-key regression evidence
ci / svc-realcombo (pull_request) Successful in 1m49s
ci / test (pull_request) Successful in 5m35s
ci / test-pg (pull_request) Successful in 7m29s
e895c4b64a
Why: The sync checkpoint landed after the first local tests, so the card needs a rerun against the merged head.
Evidence: make evidence for the settings/runtime tests and the seed fingerprint tests, both exit 0 (SELF).
Impact: Task card only.
Refs: fix/model-key-secret-overlay
Co-authored-by: Cursor <cursoragent@cursor.com>
weichen added 1 commit 2026-10-15 11:07:04 +00:00
Record the pull requests and review
ci / svc-realcombo (pull_request) Successful in 1m40s
ci / test (pull_request) Successful in 5m30s
ci / test-pg (pull_request) Successful in 8m44s
fc2920686a
Why: The card is the main record, and the review has to name the objects it read.
Evidence: Backend PR 205 and Dev PR 569 exist; review 68215ca8 found no blocking defect.
Impact: Task card only.
Refs: fix/model-key-secret-overlay
Co-authored-by: Cursor <cursoragent@cursor.com>
weichen added 1 commit 2026-10-15 11:29:43 +00:00
Record the local suite result
ci / svc-realcombo (pull_request) Successful in 1m49s
ci / test (pull_request) Successful in 5m37s
ci / test-pg (pull_request) Successful in 7m26s
34152f740f
Why: The full local suite exited 2, and the card has to keep that receipt instead of implying a pass.
Evidence: make evidence for make test, exit 2, receipt 11513cd3. The two errors are agent-exec redaction of a 3-digit TOKEN, and CI on fc29206 is the gate.
Impact: Task card only.
Refs: fix/model-key-secret-overlay
Co-authored-by: Cursor <cursoragent@cursor.com>
weichen merged commit 64a50cf532 into main 2026-10-15 11:52:25 +00:00
Sign in to join this conversation.
No Reviewers
No labels
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: weichen/Agent-System-Dev#569