weichen
c1fdf0141c
Why: main advanced with merged-task-name and legacy evidence guards during this task. Evidence: SELF 44 lifecycle regressions pass after resolving both hunks; independent review repairs are recorded in the task card. Impact: retains both task-start protections and the stronger JSON/legacy receipt reader, without rewriting either branch history. Refs: Dev PR #211 and #212; .task/feature-governance-reliability.md
105 lines
5.3 KiB
JSON
105 lines
5.3 KiB
JSON
{
|
|
"status": "complete",
|
|
"verdict": "All four specified repair findings resolved at fixed source SHA",
|
|
"evidence_source": "REPLAY",
|
|
"reviewer": "/root/verify_review_repairs",
|
|
"scope": "Bounded verification of original findings 1-4; not a whole-repository review or release gate",
|
|
"source_sha": "b84667a697ab88e7eb09b78ba6b00175729937b2",
|
|
"diff_base_sha": "976d2e84434f6a089cb8ccd1da33e151a6cc375d",
|
|
"original_review_source_sha": "c0abfb0250980af7f1b18c785eb4b55240a8d855",
|
|
"original_review_artifact_commit": "b84667a697ab88e7eb09b78ba6b00175729937b2",
|
|
"original_review_artifact_path": ".task/reviews/governance-reliability.json",
|
|
"snapshot": "/tmp/governance-repair-replay-urtmaen7",
|
|
"snapshot_file_count_verified_against_commit": 22,
|
|
"commands": [
|
|
{
|
|
"command": "PYTHONDONTWRITEBYTECODE=1 GIT_CONFIG_NOSYSTEM=1 GIT_CONFIG_GLOBAL=/dev/null GIT_ALLOW_PROTOCOL=file GIT_TERMINAL_PROMPT=0 python3 -m unittest discover -s tests -p test_task.py -v",
|
|
"cwd": "/tmp/governance-repair-replay-urtmaen7",
|
|
"exit_code": 0,
|
|
"tests_run": 42,
|
|
"failures": 0,
|
|
"errors": 0,
|
|
"result": "OK",
|
|
"elapsed_seconds": 9.509,
|
|
"output_path": "/tmp/governance-review-repair-task.log",
|
|
"output_sha256": "eeb1bba7e4eae6369c5931a4c4756c8cdef78da49f97b7d4af2aa0c80de642fb"
|
|
},
|
|
{
|
|
"command": "PYTHONDONTWRITEBYTECODE=1 GIT_CONFIG_NOSYSTEM=1 GIT_CONFIG_GLOBAL=/dev/null GIT_ALLOW_PROTOCOL=file GIT_TERMINAL_PROMPT=0 python3 -m unittest discover -s tests -p test_evidence.py -v",
|
|
"cwd": "/tmp/governance-repair-replay-urtmaen7",
|
|
"exit_code": 0,
|
|
"tests_run": 31,
|
|
"failures": 0,
|
|
"errors": 0,
|
|
"result": "OK",
|
|
"elapsed_seconds": 3.981,
|
|
"output_path": "/tmp/governance-review-repair-evidence.log",
|
|
"output_sha256": "3824093772141bb2fbe7e2f72bfa8ba8113dadc5dbe20ecb2d242e3a8088bd44"
|
|
}
|
|
],
|
|
"total_tests": 73,
|
|
"findings": [
|
|
{
|
|
"id": 1,
|
|
"severity": "P1",
|
|
"resolution": "RESOLVED",
|
|
"evidence_source": "REPLAY",
|
|
"summary": "Finish refuses parent removal when recursively inspected component common metadata belongs to the removal roots and serves another registered worktree. Clean, staged, unstaged, and nested linked component cases preserve Git usability and content; normal clean component cleanup passes.",
|
|
"tests": [
|
|
"test_finish_preserves_linked_component_worktrees_at_the_pinned_head",
|
|
"test_finish_preserves_linked_nested_component_worktree",
|
|
"test_finish_recycles_clean_submodule_without_shared_config_changes"
|
|
],
|
|
"historical_provenance_used_to_dismiss": false
|
|
},
|
|
{
|
|
"id": 2,
|
|
"severity": "P2",
|
|
"resolution": "RESOLVED",
|
|
"evidence_source": "REPLAY",
|
|
"summary": "Sync detects stale JSON and legacy receipts, warns for malformed or missing fields and unresolved recorded commits, and treats non-card before/after dirt as unverified. Card-only changes remain fresh. Recorded command is not executed.",
|
|
"tests": [
|
|
"test_sync_warns_when_json_evidence_predates_noncard_changes",
|
|
"test_sync_still_warns_for_stale_legacy_table_evidence",
|
|
"test_sync_warns_for_malformed_json_evidence",
|
|
"test_sync_warns_for_missing_json_receipt_fields_even_with_valid_checksum",
|
|
"test_sync_warns_for_unresolved_json_evidence_head",
|
|
"test_sync_warns_for_unresolved_legacy_evidence_head",
|
|
"test_sync_warns_when_json_before_state_contains_uncommitted_code",
|
|
"test_sync_warns_when_json_after_state_contains_uncommitted_code",
|
|
"test_sync_keeps_json_evidence_fresh_after_metadata_only_changes",
|
|
"test_sync_does_not_execute_json_receipt_command"
|
|
]
|
|
},
|
|
{
|
|
"id": 3,
|
|
"severity": "P2",
|
|
"resolution": "RESOLVED",
|
|
"evidence_source": "REPLAY",
|
|
"summary": "Thirty Authorization syntax/scheme combinations cover JSON, dictionary, plain, assignment, case, and whitespace forms. Capture command/output/receipt/card/console and import contain no synthetic credential. Imported unredacted receipts are rejected even with valid checksums.",
|
|
"tests": [
|
|
"test_authorization_forms_are_redacted_in_capture_console_and_import",
|
|
"test_authorization_forms_are_redacted_on_direct_card_capture",
|
|
"test_import_rejects_unredacted_authorization_with_valid_checksums"
|
|
]
|
|
},
|
|
{
|
|
"id": 4,
|
|
"severity": "P2",
|
|
"resolution": "RESOLVED",
|
|
"evidence_source": "REPLAY",
|
|
"summary": "Explicit abandon removes the clean worktree while keeping local and file-remote branch tips and the abandonment reason note; missing reason refuses removal and preserves checkout and refs without writing a note.",
|
|
"tests": [
|
|
"test_finish_abandon_retains_local_remote_tips_and_reason",
|
|
"test_finish_abandon_without_reason_preserves_checkout_and_refs"
|
|
]
|
|
}
|
|
],
|
|
"remaining_scope_blockers": [],
|
|
"limitations": [
|
|
"Canonical working directory had scripts/task.sh merge conflict at initial inspection; the tested exported snapshot is byte-equal to b84667a. This verdict does not validate subsequent source changes or merge resolutions.",
|
|
"No real remote or service used; Git allowed protocol file only. No canonical source or task-state mutations performed.",
|
|
"No full make test/build, CI, broad review, or cross-model pipeline executed."
|
|
]
|
|
}
|