weichenandCursor 50d12ce974 Anchor review annotations on the selected node text range ...

Why: RDM now anchors annotations on nodeId + textStart + textEnd + textHash
(spec 06 §2) and acceptance 10 §5 requires accurate comment ranges. The
workspace only sent whole-node annotations and ignored quote/needsReanchor.

- Selecting text inside one node's title in the reader view records a
  code-point range (Array.from indices; surrogate pairs and ZWJ emoji are
  counted as runes, half-pair endpoints widen) and sends textStart/textEnd
  plus quote, so RDM rejects rather than misplaces a drifted range.
- No selection keeps whole-node behavior; replies never carry range params;
  textHash/range are never sent; a range is dropped if it belongs to another
  node.
- Selections spanning several nodes or containing no node text record no
  range and show a notice that the whole node will be annotated; the composer
  always shows the scope with a "whole node" escape.
- Annotation items show the server quote and a visible needs-reanchor state;
  review_anchor_invalid: errors map to readable Chinese text.
- Reader titles become role=button spans because browsers do not allow text
  selection inside <button>.

Evidence: npm test 40 files / 486 tests pass (30 new in
test/review-annotation-anchor.test.ts); npm run build exit 0;
node scripts/check-knip.mjs "50 <= 51"; design-guard 7/7; playwright
--list compiles 13 tests; headless Chromium check of the selection reader
(single, multi-node, triple-click clamp, emoji offsets).

Impact: document review UI only; base-gate decision source anchoring is
unchanged. Offsets are computed on the displayed node title (no frozen-text
read endpoint exists), guarded by quote equality on the server.

Refs: unified renderer plan Task 13; phase1 F2; spec 06 §2
Co-authored-by: Cursor <cursoragent@cursor.com>

2026-10-18 06:27:22 +00:00

..

auth.test.ts

Clear stale API-key credentials when a password session begins

2026-10-11 13:53:27 +00:00

contracts.test.ts

Implement the three-column workbench frontend: resizable/collapsible nav with overshorthand collapse

2026-09-29 18:00:10 +00:00

conversation-work.test.ts

Keep conversations ordered while background work updates independently

2026-10-15 07:05:57 +00:00

design-guard.test.ts

Enforce tokenized workbench visuals across themes

2026-10-14 16:50:17 +00:00

document-decision.test.ts

Anchor render workspace decisions to a committed source message

2026-10-17 03:41:10 +00:00

document-render-actions.test.ts

Add review decisions, rule binding and package download to the render workspace

2026-10-17 02:32:45 +00:00

document-render-workspace.test.ts

Locate review items and render trace by tree node id and mask audit-only trace

2026-10-18 00:34:04 +00:00

duty-draft.test.ts

Adopt the server duty draft when a save result is unknown

2026-10-15 09:06:24 +00:00

html-sinks.test.ts

Keep empty HTML clears out of the sink ratchet

2026-10-04 18:25:01 +00:00

live.test.ts

Keep conversations ordered while background work updates independently

2026-10-15 07:05:57 +00:00

loginpage.test.ts

Wire login recovery flow: redeem key entry and restricted set-password gate

2026-10-13 03:42:23 +00:00

messageparts.test.ts

Keep collaboration events distinct from partial text

2026-10-14 14:27:28 +00:00

notice.test.ts

Show background notices without blocking the composer

2026-10-01 15:30:50 +00:00

outbox.test.ts

Send the same request id when an outbox message is retried

2026-10-03 14:37:50 +00:00

preview-empty-state.test.ts

Open previews from the empty state and restore the last conversation on reload

2026-10-10 08:02:21 +00:00

previewfit.test.ts

Make the preview pane the only scrolling preview

2026-10-05 04:41:20 +00:00

previewtabs.test.ts

Show assistant work as a timeline and preview files in tabs

2026-10-01 06:15:44 +00:00

project-access.test.ts

Show document duties in three shared views

2026-10-15 07:20:48 +00:00

rdm-errors.test.ts

Gate the audit workspace entry on rdm.inspect command availability

2026-10-12 02:58:46 +00:00

rdm-management.test.ts

Show document duties in three shared views

2026-10-15 07:20:48 +00:00

rdmroles-reject.test.ts

Show an honest rejected state on the RDM roles panel

2026-10-13 01:29:01 +00:00

review-annotation-anchor.test.ts

Anchor review annotations on the selected node text range

2026-10-18 06:27:22 +00:00

run-events.test.ts

Verify complete saved records beyond one event page

2026-10-15 07:45:31 +00:00

send.test.ts

Show a run as active as soon as the send returns

2026-10-03 15:21:28 +00:00

settings-input.test.ts

Fix password form semantics and per-type setting inputs

2026-10-12 03:48:13 +00:00

surfaceKey.test.ts

Hydrate surface list into snapshots before render

2026-10-12 08:33:23 +00:00

tasklist.test.ts

Rebuild the left nav as a task-centric sidebar (option A, R1)

2026-09-30 10:41:12 +00:00

theme.test.ts

Rebuild the workbench shell around projects and card flow

2026-10-01 23:33:06 +00:00

toolkind.test.ts

Show the final reply apart from the work timeline

2026-10-02 13:41:36 +00:00

work-api.test.ts

Keep conversations ordered while background work updates independently

2026-10-15 07:05:57 +00:00

work-state.test.ts

Keep late background progress out of a newer conversation turn

2026-10-15 07:51:41 +00:00

workbench-layout.test.ts

Deliver a conversation-first progressive workbench with safe live state

2026-10-12 16:05:13 +00:00

workbench-progress.test.ts

Prefer progress cards over duplicate CurrentTaskCard

2026-10-12 07:45:08 +00:00

workspaces.test.ts

Add an audit overview export that stays outside the readiness gate

2026-10-12 15:38:00 +00:00