agent-bot
ee1e53b510
Root causes of the remaining 5 CI PG failures (and the hidden flaky set):
1. All PG-integration packages shared ONE database under parallel package
execution - migrations/seeds/truncates raced (nondeterministic failure
sets, locally and in CI).
Fix: RequireTestDatabaseURL/SkipIfNoTestDatabaseURL now derive a
per-package database (<base>_<pkgHash>, advisory-lock-guarded
CREATE); 9 raw-env straggler tests funnelled through the helpers;
db-package tests call it unqualified (no import cycle).
2. Approval-chain fixtures were not production-shaped: freezeReviewSnapshot
only honors head_snapshot_id, fake content hashes never froze a
snapshot, so ApproverApprove rejected with 'approved requires frozen
review_snapshot_id'. Errors were swallowed (_, _ =) hiding this.
Fix (ownership-respecting, arch-enforced):
- docrevision.SeedContentSnapshotForTest seeds the ledger tables it owns
- docgov GovernanceEngine.FreezeHeadSnapshotForTest freezes head/review
pointers on document_records (docgov-owned) and clears engine cache
- all four integration fixtures use the pair; swallowed errors checked
3. Fixed-name fixtures collide once a package shares one DB (projects
uq_projects_name_global): uniquified in projectinstance + server tests.
4. CAS/ctxmgr tests never bootstrapped migrations (relied on other packages
having migrated the shared DB): explicit RunMigrationsOnceForTest.
Verified: full parallel short suite = 75 packages, 0 failures against an
isolated throwaway PG. CI skip list removed - short tests fully required.
114 lines
3.3 KiB
Go
114 lines
3.3 KiB
Go
package projectinstance
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
)
|
|
|
|
// TerminateInput 受控终止输入。
|
|
type TerminateInput struct {
|
|
Reason string `json:"reason"`
|
|
Confirm bool `json:"confirm"`
|
|
ExpectedConfigRevision int `json:"expected_config_revision"`
|
|
}
|
|
|
|
// TerminateResult 终止结果。
|
|
type TerminateResult struct {
|
|
Instance WorkflowInstance `json:"instance"`
|
|
Reason string `json:"reason"`
|
|
}
|
|
|
|
// PendingDocSummary 终止预览中的待处理文档摘要。
|
|
type PendingDocSummary struct {
|
|
TaskKey string `json:"task_key"`
|
|
Status string `json:"status"`
|
|
StageKey string `json:"stage_key,omitempty"`
|
|
}
|
|
|
|
// TerminationPreview 受控终止影响预览。
|
|
type TerminationPreview struct {
|
|
InstanceID int64 `json:"instance_id"`
|
|
PendingDocuments []PendingDocSummary `json:"pending_documents"`
|
|
InProgressTaskRuns int `json:"in_progress_task_runs"`
|
|
CanTerminate bool `json:"can_terminate"`
|
|
Impact string `json:"impact,omitempty"`
|
|
}
|
|
|
|
func (s *Service) GetTerminationPreview(ctx context.Context, instanceID int64, projectID int64, userID int64, isCreator bool) (*TerminationPreview, error) {
|
|
if !isCreator {
|
|
return nil, ErrForbiddenNotCreator
|
|
}
|
|
if !s.Available() {
|
|
return nil, ErrNotAvailable
|
|
}
|
|
live, err := s.store.GetLiveInstance(ctx, projectID)
|
|
if err != nil || live == nil || live.ID != instanceID {
|
|
return nil, ErrInstanceNotFound
|
|
}
|
|
if live.Status == InstanceCompleted || live.Status == "terminated" {
|
|
return nil, ErrTerminationNotAllowed
|
|
}
|
|
|
|
detail, err := s.store.GetInstanceByID(ctx, instanceID)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
|
|
pending := make([]PendingDocSummary, 0)
|
|
for _, st := range detail.Stages {
|
|
if st.StageKey != detail.ActiveStageKey {
|
|
continue
|
|
}
|
|
for _, dt := range st.DocTasks {
|
|
if !dt.Enabled || dt.Status == "skipped_disabled" {
|
|
continue
|
|
}
|
|
if dt.Status != "approved" {
|
|
pending = append(pending, PendingDocSummary{
|
|
TaskKey: dt.TaskKey, Status: dt.Status, StageKey: st.StageKey,
|
|
})
|
|
}
|
|
}
|
|
}
|
|
|
|
taskRuns, _ := s.store.CountActiveTaskRuns(ctx, projectID)
|
|
preview := &TerminationPreview{
|
|
InstanceID: instanceID,
|
|
PendingDocuments: pending,
|
|
InProgressTaskRuns: taskRuns,
|
|
CanTerminate: true,
|
|
Impact: fmt.Sprintf(
|
|
"%d pending documents, %d in-progress task runs will be cancelled",
|
|
len(pending), taskRuns,
|
|
),
|
|
}
|
|
return preview, nil
|
|
}
|
|
|
|
func (s *Service) TerminateInstance(ctx context.Context, instanceID int64, projectID int64, userID int64, isCreator bool, in TerminateInput) (*TerminateResult, error) {
|
|
if !isCreator {
|
|
return nil, ErrForbiddenNotCreator
|
|
}
|
|
if !in.Confirm {
|
|
return nil, ErrTerminationNotAllowed
|
|
}
|
|
if in.Reason == "" {
|
|
return nil, ErrValidationFailed
|
|
}
|
|
if !s.Available() {
|
|
return nil, ErrNotAvailable
|
|
}
|
|
live, err := s.store.GetLiveInstance(ctx, projectID)
|
|
if err != nil || live == nil || live.ID != instanceID {
|
|
return nil, ErrInstanceNotFound
|
|
}
|
|
if in.ExpectedConfigRevision > 0 && live.ConfigRevision != in.ExpectedConfigRevision {
|
|
return nil, ErrInstanceRevisionConflict
|
|
}
|
|
inst, err := s.store.TerminateInstance(ctx, instanceID, projectID, userID, in.Reason)
|
|
if err != nil {
|
|
return nil, err
|
|
}
|
|
return &TerminateResult{Instance: *inst, Reason: in.Reason}, nil
|
|
}
|