agent-bot
ee1e53b510
Root causes of the remaining 5 CI PG failures (and the hidden flaky set):
1. All PG-integration packages shared ONE database under parallel package
execution - migrations/seeds/truncates raced (nondeterministic failure
sets, locally and in CI).
Fix: RequireTestDatabaseURL/SkipIfNoTestDatabaseURL now derive a
per-package database (<base>_<pkgHash>, advisory-lock-guarded
CREATE); 9 raw-env straggler tests funnelled through the helpers;
db-package tests call it unqualified (no import cycle).
2. Approval-chain fixtures were not production-shaped: freezeReviewSnapshot
only honors head_snapshot_id, fake content hashes never froze a
snapshot, so ApproverApprove rejected with 'approved requires frozen
review_snapshot_id'. Errors were swallowed (_, _ =) hiding this.
Fix (ownership-respecting, arch-enforced):
- docrevision.SeedContentSnapshotForTest seeds the ledger tables it owns
- docgov GovernanceEngine.FreezeHeadSnapshotForTest freezes head/review
pointers on document_records (docgov-owned) and clears engine cache
- all four integration fixtures use the pair; swallowed errors checked
3. Fixed-name fixtures collide once a package shares one DB (projects
uq_projects_name_global): uniquified in projectinstance + server tests.
4. CAS/ctxmgr tests never bootstrapped migrations (relied on other packages
having migrated the shared DB): explicit RunMigrationsOnceForTest.
Verified: full parallel short suite = 75 packages, 0 failures against an
isolated throwaway PG. CI skip list removed - short tests fully required.
48 lines
1.4 KiB
Go
48 lines
1.4 KiB
Go
package projectinstance
|
|
|
|
import (
|
|
"context"
|
|
"testing"
|
|
|
|
"chat-agent-system/internal/workflowdef"
|
|
)
|
|
|
|
func TestHandleDocumentApproved_StageReady(t *testing.T) {
|
|
ctx := context.Background()
|
|
store := newMemStore()
|
|
_ = SeedProjectMeta(store, 1, LifecycleActive, workflowdef.OfficialKeyMain, 1, 1)
|
|
|
|
svc := NewService(store, testResolver(), nil, &stubDocChecker{states: map[string]string{"intake": "approved"}})
|
|
plan := WorkflowPlan{
|
|
WorkflowDefinitionKey: workflowdef.OfficialKeyMain,
|
|
WorkflowVersion: 1,
|
|
Stages: []StagePlan{{
|
|
StageKey: "V0.1_triage", Enabled: true,
|
|
DocTasks: []DocTaskPlan{{
|
|
TaskKey: "intake", Enabled: true,
|
|
Duties: DocDuty{AuthorUserID: 2, ReviewerUserID: 3, ApproverUserID: 4},
|
|
}},
|
|
}},
|
|
}
|
|
inst := &WorkflowInstance{
|
|
ID: 1, ProjectID: 1, WorkflowVersionID: 10, Status: InstanceActive,
|
|
ConfigRevision: 1, PlanHash: "h", ConfigSnapshot: plan, InstanceNo: 1,
|
|
}
|
|
version := &workflowdef.Version{WorkflowKey: workflowdef.OfficialKeyMain, Version: 1}
|
|
activated, err := store.ActivateInstance(ctx, 1, inst, version, 1, 2)
|
|
if err != nil {
|
|
t.Fatalf("activate: %v", err)
|
|
}
|
|
|
|
result, err := svc.HandleDocumentApproved(ctx, 1, "intake")
|
|
if err != nil {
|
|
t.Fatalf("handle approved: %v", err)
|
|
}
|
|
if result == nil || !result.StageReady {
|
|
t.Fatalf("expected stage ready, got %+v", result)
|
|
}
|
|
if result.InstanceID != activated.ID || result.StageKey != "V0.1_triage" {
|
|
t.Fatalf("unexpected result: %+v", result)
|
|
}
|
|
}
|