Decouple runmgr from cmdbus via view types in CommandSource (EXT-14 lint fix) #116

Merged
weichen merged 1 commits from feature/ext14-cmdsource-view into main 2026-10-09 16:33:23 +00:00
Owner

Why: EXT-14 (#114) let runmgr import cmdbus for the CommandSource signatures, adding edge backend/runmgr -> backend/cmdbus outside the architecture baseline ratchet; the Dev umbrella make test (lint-architecture) rejects the gitlink bump. The port now lives in runmgr with local view types (CommandTool/CommandRequest/CommandResponse); app.busAdapter converts cmdbus types at the boundary. Entrance stays fixed to agent by runmgr; no behavior change.

Evidence: go build/go vet clean; go test ./... 32/32 packages green; no internal/cmdbus import remains in non-test runmgr files. Dev-side lint re-verified on the follow-up gitlink PR.

Impact: internal/runmgr (interface + dispatch site), internal/app (adapter conversion), runmgr test stubs switched to view types.

Refs: Dev umbrella lint failure architecture: new dependency edges backend/runmgr backend/cmdbus; proposal 2026-10-09-ext-g1-b1-b3-exec-backend.md (EXT-14); Backend #114.

Why: EXT-14 (#114) let runmgr import cmdbus for the CommandSource signatures, adding edge backend/runmgr -> backend/cmdbus outside the architecture baseline ratchet; the Dev umbrella `make test` (lint-architecture) rejects the gitlink bump. The port now lives in runmgr with local view types (CommandTool/CommandRequest/CommandResponse); app.busAdapter converts cmdbus types at the boundary. Entrance stays fixed to agent by runmgr; no behavior change. Evidence: `go build`/`go vet` clean; `go test ./...` 32/32 packages green; no internal/cmdbus import remains in non-test runmgr files. Dev-side lint re-verified on the follow-up gitlink PR. Impact: internal/runmgr (interface + dispatch site), internal/app (adapter conversion), runmgr test stubs switched to view types. Refs: Dev umbrella lint failure `architecture: new dependency edges backend/runmgr backend/cmdbus`; proposal 2026-10-09-ext-g1-b1-b3-exec-backend.md (EXT-14); Backend #114.
weichen added 1 commit 2026-10-09 16:31:50 +00:00
Decouple runmgr from cmdbus via view types in CommandSource
ci / vet-and-test (pull_request) Successful in 40s
6337cd87f8
Why: the EXT-14 wiring made runmgr import cmdbus for the CommandSource
interface signatures, which adds a new edge backend/runmgr ->
backend/cmdbus outside the architecture baseline ratchet; the Dev
umbrella lint (lint-architecture) rejects the gitlink bump because of
it. The dependency direction was always meant to be inverted: runmgr
defines the port, the composition root adapts the bus.

Evidence: go build/vet clean; go test ./... 32/32 packages green;
grep confirms no internal/cmdbus import left in non-test runmgr files;
Dev-side lint re-run scheduled on the gitlink bump PR.

Impact: runmgr.CommandTool/CommandRequest/CommandResponse are local
view types; app.busAdapter now converts cmdbus types at the boundary
(Entrance still fixed to agent by runmgr). No behavior change; the
runmgr tests speak the view types instead of cmdbus ones.

Refs: Dev umbrella make test failure 'architecture: new dependency
edges backend/runmgr backend/cmdbus'; proposal 2026-10-09-ext-g1-b1-b3
(EXT-14); Backend #114.
weichen merged commit 8157e68cf1 into main 2026-10-09 16:33:23 +00:00
Sign in to join this conversation.
No Reviewers
No labels
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: weichen/Agent-System-Backend#116