Harden cross-instance HITL/cancel command paths and add disk-full rejection tests (U7) #164

Merged

weichen merged 2 commits from feature/u7-load-fault-release into main

2026-10-12 03:09:03 +00:00

Author	SHA1	Message	Date
weichen	58598df095	Merge remote-tracking branch 'origin/main' into feature/u7-load-fault-release ci / vet-and-test (pull_request) Successful in 51s Details	2026-10-12 03:07:33 +00:00
weichen	0a7413903d	Harden cross-instance HITL/cancel command paths and add disk-full rejection tests (U7) ci / vet-and-test (pull_request) Successful in 48s Details Why: two-process HTTP acceptance (Dev tests/integration/multi-instance, added in the matching Dev-side change) exposed three real cross-instance defects that the U5 library-level tests bypassed via direct Manager calls, plus the U7 fault matrix needs explicit disk-full rejection evidence. Evidence: go test ./... green on SQLite and real PG (AGENT_PG_TEST_DSN); new regressions TestCrossInstanceResolveDoesNotSettleCard (runmgr, PG-gated), TestUploadRejectsCleanlyWhenObjectDirUnwritable and TestArtifactOverwriteRejectsCleanlyWhenObjectDirUnwritable (server). Impact: ResolveHITL no longer settles the card when the run executes on another instance (command-bus fallback stays available); cancelRun enqueues the command with the real conversation id and no longer reports a false local success; object-store failures now provably leave zero DB/object residue. Refs: collaboration storage proposal U7 (sections 3/5/7); task card feature/u7-load-fault-release.	2026-10-12 02:28:48 +00:00

Author

SHA1

Message

Date

weichen

58598df095

Merge remote-tracking branch 'origin/main' into feature/u7-load-fault-release

ci / vet-and-test (pull_request) Successful in 51s

Details

2026-10-12 03:07:33 +00:00

weichen

0a7413903d

Harden cross-instance HITL/cancel command paths and add disk-full rejection tests (U7)

ci / vet-and-test (pull_request) Successful in 48s

Details

Why: two-process HTTP acceptance (Dev tests/integration/multi-instance, added in
the matching Dev-side change) exposed three real cross-instance defects that the
U5 library-level tests bypassed via direct Manager calls, plus the U7 fault
matrix needs explicit disk-full rejection evidence.
Evidence: go test ./... green on SQLite and real PG (AGENT_PG_TEST_DSN);
new regressions TestCrossInstanceResolveDoesNotSettleCard (runmgr, PG-gated),
TestUploadRejectsCleanlyWhenObjectDirUnwritable and
TestArtifactOverwriteRejectsCleanlyWhenObjectDirUnwritable (server).
Impact: ResolveHITL no longer settles the card when the run executes on another
instance (command-bus fallback stays available); cancelRun enqueues the command
with the real conversation id and no longer reports a false local success;
object-store failures now provably leave zero DB/object residue.
Refs: collaboration storage proposal U7 (sections 3/5/7); task card
feature/u7-load-fault-release.

2026-10-12 02:28:48 +00:00