Fall back to local artifacts when the blob store is a typed nil #186

Merged

weichen merged 1 commits from fix/u7-k4-artifact-upload into main

2026-10-13 01:53:03 +00:00

Author	SHA1	Message	Date
weichenandCursor	46073d30a5	Fall back to local artifacts when the blob store is a typed nil ci / vet-and-test (pull_request) Successful in 46s Details Why: an unset S3 client passed through the Store interface is not a nil interface, so uploads panic instead of using the local artifact directory. Evidence: TestIsNil and TestFinishOpenTypedNilS3UsesLocalArtifacts failed before this change and pass after it. The PostgreSQL case skips unless AGENT_PG_TEST_DSN is set. Impact: only an unset blob store falls back; a constructed S3 or local store is unchanged. Refs: internal/blobstore/blobstore.go internal/store/store.go Co-authored-by: Cursor <cursoragent@cursor.com>	2026-10-13 01:22:57 +00:00

Author

SHA1

Message

Date

weichenandCursor

46073d30a5

Fall back to local artifacts when the blob store is a typed nil

ci / vet-and-test (pull_request) Successful in 46s

Details

Why: an unset S3 client passed through the Store interface is not a nil interface, so uploads panic instead of using the local artifact directory.
Evidence: TestIsNil and TestFinishOpenTypedNilS3UsesLocalArtifacts failed before this change and pass after it. The PostgreSQL case skips unless AGENT_PG_TEST_DSN is set.
Impact: only an unset blob store falls back; a constructed S3 or local store is unchanged.
Refs: internal/blobstore/blobstore.go internal/store/store.go
Co-authored-by: Cursor <cursoragent@cursor.com>

2026-10-13 01:22:57 +00:00