weichen/Agent-System-Backend
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Store secrets apart from settings and guard open listeners #63

Merged
weichen merged 4 commits from feature/sillytavern-review into main 2026-10-04 19:42:36 +00:00
Conversation 0 Commits 4 Files Changed 29
+1926 -74
4 Commits
Author SHA1 Message Date
weichenandCursor c05832dd6a Pin agent-system-core after the contract type cleanup
ci / vet-and-test (pull_request) Successful in 43s
Details 
Why: Dev and the backend checkout must name the same core commit, and the section type is no longer a separate export.
Evidence: modules/core is 0b5c774. The nested checkout is detached at that commit.
Impact: Backend still compiles the same Go observation type. Only the TypeScript export changed.
Refs: .task/feature-sillytavern-review.md
Co-authored-by: Cursor <cursoragent@cursor.com>
 2026-10-04 18:36:58 +00:00
weichen 8c7f3d9a7e Pin agent-squad to the shared agent-native commit 
Why: The pin check requires Backend's squad gitlink to match Dev, and that squad commit must itself pin the message-shaping agent-native.
Evidence: Squad commit 5a57636 points agent-native at 3a110a7.
Impact: Backend and Dev resolve the same squad and native trees.
Refs: docs/records/2026-10-04-sillytavern-review.md
 2026-10-04 18:28:30 +00:00
weichen 42cca8fade Store secrets apart from settings and assemble context at the end 
Why: Masks must not be the only copy of a key, and personal instructions, lore hits, and candidate replies have to reach the model without rewriting the system prefix or deleting history.
Evidence: go test ./internal/store ./internal/ctxasm ./internal/settings ./internal/runtime ./internal/server. Migration v16 upgrades and rolls back. Startup snapshots settings before moving raw keys.
Impact: One labeled key is active per service. Excluding a message hides its whole run from the model. Regenerating appends another candidate and rewinds files to the user turn. User slash commands expand to prompt text and do not fire on their own.
Refs: docs/records/2026-10-04-sillytavern-review.md
 2026-10-04 18:20:10 +00:00
weichenandCursor 8eda35f365 Refuse open listeners and cross-site writes without auth 
Why: The embedded tier starts without auth, and nothing checked Origin or Host, so a public bind or a foreign page could call write APIs.
Evidence: go test ./internal/config ./internal/server covering listen policy, origin rejection, and response headers.
Impact: Non-loopback without auth exits before opening the database. HTML artifacts get a sandbox CSP. Reverse proxies must list their public host in allowedHosts.
Refs: feature/sillytavern-review
Co-authored-by: Cursor <cursoragent@cursor.com>
 2026-10-04 17:28:46 +00:00