Pin frontend main after the expanded preview layout fix #203

Merged
weichen merged 6 commits from fix/preview-expanded-hidden into main 2026-10-05 05:40:36 +00:00
Owner

Summary

  • Pin modules/frontend to 50c7244, the merge of Frontend PR #47.
  • That change restores hidden on the conversation column when the preview expands, and centers a docx page only when the column is wider than the page.

Test plan

  • make test in the task worktree (boundaries, pins, libs, core, backend, frontend 82 tests, ui 103 tests, agentcmd)
  • Headless Chromium 1512x900: expanded .main is display: none, preview slot 1184px, page center delta 0
  • At 420px and 640px the wrapper matches the column and the page stays left-aligned
## Summary - Pin `modules/frontend` to `50c7244`, the merge of Frontend PR #47. - That change restores `hidden` on the conversation column when the preview expands, and centers a docx page only when the column is wider than the page. ## Test plan - [x] `make test` in the task worktree (boundaries, pins, libs, core, backend, frontend 82 tests, ui 103 tests, agentcmd) - [x] Headless Chromium 1512x900: expanded `.main` is `display: none`, preview slot 1184px, page center delta 0 - [x] At 420px and 640px the wrapper matches the column and the page stays left-aligned
weichen added 5 commits 2026-10-05 05:40:25 +00:00
Why: Expanding the preview left the conversation column in the row because .main { display: flex } overrode the UA [hidden] rule. Frontend PR #47 restores that hide and centers a wide docx page.
Evidence: Frontend vitest previewfit + design-guard 10 passed. Headless Chromium 1512x900 shows expanded .main display:none, preview slot 1184px, page center delta 0; at 420px and 640px the wrapper stays column-width and the page stays left-aligned.
Impact: modules/frontend 0a0b556 -> 50c7244. Narrow-column fit scaling is unchanged. previewfit still returns 1 when available width is <= 0.
Refs: .task/fix-preview-expanded-hidden.md; https://git-home.u1680832.nyat.app:30319/weichen/Agent-System-Frontend/pulls/47
Co-authored-by: Cursor <cursoragent@cursor.com>
Why: task-sync appends the checkpoint row at end of file, and the results section sat after the table, so the row rendered outside it.
Evidence: the row values are unchanged from the sync commit ce46543.
Impact: task card markdown only.
Refs: .task/fix-preview-expanded-hidden.md
Co-authored-by: Cursor <cursoragent@cursor.com>
Record combined test acceptance for the preview layout pin
ci / test (pull_request) Successful in 1m54s
5609e8702e
Why: task-sync asks for the formal acceptance evidence on the task card before the Dev PR is reviewed.
Evidence: make test passed in the task worktree, including frontend vitest 17 files / 82 tests and ui 103 tests.
Impact: task card only.
Refs: .task/fix-preview-expanded-hidden.md
Co-authored-by: Cursor <cursoragent@cursor.com>
weichen added 1 commit 2026-10-05 05:40:32 +00:00
Record the Dev pull request on the preview layout task card
ci / test (pull_request) Successful in 1m57s
1cb93aad2e
Why: the task card is the primary record and needs the PR that carries this gitlink.
Evidence: Dev PR #203 is open against main.
Impact: task card only.
Refs: https://git-home.u1680832.nyat.app:30319/weichen/Agent-System-Dev/pulls/203
Co-authored-by: Cursor <cursoragent@cursor.com>
weichen merged commit 64f2bff856 into main 2026-10-05 05:40:36 +00:00
Sign in to join this conversation.
No Reviewers
No labels
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: weichen/Agent-System-Dev#203