Empty-state preview fix: unified key, conversation restore (pin frontend 339a9eb) #305

2026-10-10T08:27:39Z

weichen commented

2026-10-10 08:27:39 +00:00

Why: headless Chromium 实测复现——空态（未选会话）点击工件行后仅工件弹层关闭、无任何反应（requestPreview 写 currentConvId ?? '_' 键而渲染判空键）；且 currentConvId 不持久化、刷新必回空态，构成高频触发（2026-10-10 用户实测问题 2）。

改动（Dev 侧 pin frontend 84b73ab→339a9eb + 任务卡）：

Frontend #49：previewTabsKey 统一读写键；进入会话收编空态孤儿标签；上次会话持久化并在首载恢复一次；交付卡片工件缺失 toast。

Evidence（任务卡全量）：vitest 85/85（新增 3 测）；干净 profile 浏览器回放：真空态点击→预览区挂载+docx 渲染（原缺陷全 false）、刷新→会话恢复；make test EXIT=0（95 ok，含 #303 后 main）。

Refs: 任务卡 .task/feature-empty-state-preview-fix.md；Frontend PR #49。

Why: headless Chromium 实测复现——空态（未选会话）点击工件行后仅工件弹层关闭、无任何反应（requestPreview 写 currentConvId ?? '_' 键而渲染判空键）；且 currentConvId 不持久化、刷新必回空态，构成高频触发（2026-10-10 用户实测问题 2）。改动（Dev 侧 pin frontend 84b73ab→339a9eb + 任务卡）： - Frontend #49：previewTabsKey 统一读写键；进入会话收编空态孤儿标签；上次会话持久化并在首载恢复一次；交付卡片工件缺失 toast。 Evidence（任务卡全量）：vitest 85/85（新增 3 测）；干净 profile 浏览器回放：真空态点击→预览区挂载+docx 渲染（原缺陷全 false）、刷新→会话恢复；make test EXIT=0（95 ok，含 #303 后 main）。 Refs: 任务卡 .task/feature-empty-state-preview-fix.md；Frontend PR #49。

weichen added 14 commits 2026-10-10 08:27:39 +00:00

Record the task card for feature-empty-state-preview-fix eaac3515c0

Why: establish the authorized task workspace and its initial baseline.

Evidence: preserved precheck receipt in .task/feature-empty-state-preview-fix.md; R0=d53efd5f14bb339dfe908c5d8850ed0eedec024e.

Impact: task metadata only; the feature workspace starts at d53efd5f14.

Refs: .task/feature-empty-state-preview-fix.md

Record problem-2 task scope and authorization 4816f65836

Record problem-2 browser replay evidence ec23df31df

Record decisive empty-state replay evidence (fresh profile) 1800939148

Record decisive fresh-profile empty-state evidence 976ce4bef8

Pin frontend to 475fd3a for the empty-state preview fix branch head 615ed80f54

Why: the frontend fix branch carries the preview key unification, orphan-tab
adoption, conversation restore, and missing-artifact toast; the Dev gitlink
records the tested head ahead of the Frontend PR merge.
Evidence: vitest 85/85; fresh-profile browser replay in the task card.
Impact: modules/frontend gitlink 84b73ab -> 475fd3a only.
Refs: Frontend PR #49; task card feature/empty-state-preview-fix.

Merge authoritative main into the task branch b907c1e466

Why: include the current integration baseline before verification.

Evidence: fetched origin/main=bf2a8f073079eb6b49910142151345e87da03ae1.

Impact: integrate upstream changes without rewriting task history.

Refs: task-sync

Record the sync checkpoint 963dd0be4f

Why: bind the task validation checkpoint to the latest integration baseline.

Evidence: SELF recursive component checks; sync_base=bf2a8f073079eb6b49910142151345e87da03ae1; candidate=b907c1e46699859f940f853e066cadf85b1087be.

Impact: task metadata only.

Refs: .task/feature-empty-state-preview-fix.md

Record combined test evidence for the frontend pin acbf1ee6c7

Pin frontend to merged main 339a9eb for the empty-state preview fix a6675709fa

Why: Frontend PR #49 merged; the pin must point at component main so the
merged content is actually contained (branch-head pins drop unmerged diff).
Evidence: vitest 85/85 and browser replay recorded earlier cover the branch
head; make test rerun on this pin before the Dev PR.
Impact: modules/frontend gitlink 84b73ab -> 339a9eb.
Refs: Frontend PR #49; task card feature/empty-state-preview-fix.

Merge authoritative main into the task branch d2d8fc0e09

Why: include the current integration baseline before verification.

Evidence: fetched origin/main=5fa6cfbd8c8995c4267d0a76390f652b62d953dc.

Impact: integrate upstream changes without rewriting task history.

Refs: task-sync

Record the sync checkpoint b9b53f8f4e

Why: bind the task validation checkpoint to the latest integration baseline.

Evidence: SELF recursive component checks; sync_base=5fa6cfbd8c8995c4267d0a76390f652b62d953dc; candidate=d2d8fc0e09d3414ddf456507c0659937e60ff26c.

Impact: task metadata only.

Refs: .task/feature-empty-state-preview-fix.md

Record combined test evidence on the merged-main pin ab6ef7bd9c

Fill problem-2 results and review records

ci / test (pull_request) Successful in 2m20s

Details

75d43bdeea

weichen merged commit 0fcb8ed9c7 into main

2026-10-10 08:32:00 +00:00

Sign in to join this conversation.

1 Participants

Notifications

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: weichen/Agent-System-Dev#305