Report the real identity marker in svc adopt and the deploy gate #681

Merged
weichen merged 8 commits from fix/genui-prod-upgrade-followups into main 2026-10-21 14:00:56 +00:00
Owner

Two scripts/svc.sh identity messages misled the 2026-10-21 GenUI prod upgrade; this fixes them and pins Documents to the acceptance record.

  • svc.sh <env> adopt --confirm reads the identity marker back. If the installed artifact cannot establish identity, it warns db_marker=pending instead of claiming established.
  • The deploy identity gate now explains a pre-v27 database (identity table missing): back up, stop, run the candidate migrate --data (DSN only via AGENT_SYSTEM_DSN), then redeploy. It still refuses before stopping the old service and never migrates on its own.
  • Two regression tests in tests/test_svc_identity.py.
  • modules/documents → 75e43e1 (Documents #120): the GenUI prod API acceptance rerun passed (11/11), and admin cannot create projects until a role is assigned.

Why: both svc messages were wrong during the upgrade, and the GenUI acceptance was still NOT_RUN.
Evidence: task card .task/fix-genui-prod-upgrade-followups.md (same document as this description); tests.test_svc_identity 31 OK.
Impact: svc.sh operator messages only; success paths unchanged; documentation pin.
Refs: Documents #120.

Two `scripts/svc.sh` identity messages misled the 2026-10-21 GenUI prod upgrade; this fixes them and pins Documents to the acceptance record. - `svc.sh <env> adopt --confirm` reads the identity marker back. If the installed artifact cannot establish identity, it warns `db_marker=pending` instead of claiming `established`. - The deploy identity gate now explains a pre-v27 database (`identity table missing`): back up, stop, run the candidate `migrate --data` (DSN only via `AGENT_SYSTEM_DSN`), then redeploy. It still refuses before stopping the old service and never migrates on its own. - Two regression tests in `tests/test_svc_identity.py`. - `modules/documents` → 75e43e1 (Documents #120): the GenUI prod API acceptance rerun passed (11/11), and `admin` cannot create projects until a role is assigned. Why: both svc messages were wrong during the upgrade, and the GenUI acceptance was still NOT_RUN. Evidence: task card `.task/fix-genui-prod-upgrade-followups.md` (same document as this description); `tests.test_svc_identity` 31 OK. Impact: svc.sh operator messages only; success paths unchanged; documentation pin. Refs: Documents #120.
weichen added 5 commits 2026-10-21 13:39:37 +00:00
Why: establish the authorized task workspace and its initial baseline.

Evidence: preserved precheck receipt in .task/fix-genui-prod-upgrade-followups.md; R0=ccb6dfaa9cdf7e69eb15d7df024dee55f37b8df1.

Impact: task metadata only; the feature workspace starts at ccb6dfaa9c.

Refs: .task/fix-genui-prod-upgrade-followups.md
svc.sh adopt always printed db_marker=established, even when the installed
artifact lacked identity capability and the marker stayed pending. It now
reads the marker back and warns when identity was not established.

The deploy identity gate reported a pre-v27 database (identity table
missing) as a foreign row or mismatch. It now explains that the schema
predates the identity table and gives the backup, stop, migrate and
redeploy steps. It still refuses before stopping the old service and never
migrates on its own.

Why: both messages misled the 2026-10-21 GenUI prod upgrade.
Evidence: agent-exec unit dev-svc-identity-adopt-gate-messages (cursor, attempt 1, terminal=success); python3 -m unittest tests.test_svc_identity: 31 tests OK (1 skipped).
Impact: svc.sh operator messages for adopt and the deploy identity gate; no change to success paths.
Refs: Dev task fix/genui-prod-upgrade-followups.
Co-authored-by: Cursor <cursoragent@cursor.com>
Why: the card must state authorization, goals and unit receipts.
Evidence: agent-exec receipts under /tmp/genui-followups-20261021.
Impact: task card only.
Refs: fix/genui-prod-upgrade-followups.
Co-authored-by: Cursor <cursoragent@cursor.com>
Move modules/documents to 75e43e1 (Documents #120), which replaces the
NOT_RUN GenUI acceptance note with the 2026-10-21 prod rerun result and
records that admin cannot create projects until a role is assigned.

Why: the Dev pin should carry the updated GenUI prod record.
Evidence: Documents #120 CI success at f5417fb; agent-exec unit dev-genui-prod-followups-repin (cursor, attempt 1, terminal=success).
Impact: documentation pin only.
Refs: Dev task fix/genui-prod-upgrade-followups.
Co-authored-by: Cursor <cursoragent@cursor.com>
Record results and review on the followups task card
ci / svc-realcombo (pull_request) Successful in 3m31s
ci / test (pull_request) Successful in 10m28s
ci / test-pg (pull_request) Successful in 14m0s
f18d17e3b6
Why: the card must carry results, evidence and review before closing.
Evidence: make evidence entry for tests.test_svc_identity (31 OK, 1 skipped).
Impact: task card only.
Refs: fix/genui-prod-upgrade-followups.
Co-authored-by: Cursor <cursoragent@cursor.com>
weichen added 1 commit 2026-10-21 13:39:43 +00:00
Fold-close the task card before merge
ci / svc-realcombo (pull_request) Successful in 4m7s
ci / test (pull_request) Successful in 11m55s
ci / test-pg (pull_request) Successful in 14m29s
e9ea882ffe
Why: close the task card inside its own PR so landing it needs no post-merge backfill or separate close PR.
Evidence: .task/fix-genui-prod-upgrade-followups.md -> .task/archive/fix-genui-prod-upgrade-followups.md; status 已完成(合入前闭合); PR #681 https://git-home.u1680832.nyat.app:30319/weichen/Agent-System-Dev/pulls/681.
Impact: task metadata only; the card is archived within PR #681 and lands with its merge commit.
Refs: task.sh close --self
weichen added 2 commits 2026-10-21 13:40:42 +00:00
Why: include the current integration baseline before verification.

Evidence: fetched origin/main=a736d5a420370cff052bd946f6d6397d4c354547.

Impact: integrate upstream changes without rewriting task history.

Refs: task-sync
Record the sync checkpoint
ci / svc-realcombo (pull_request) Successful in 4m13s
ci / test (pull_request) Successful in 10m58s
ci / test-pg (pull_request) Successful in 12m34s
dcbf953c16
Why: bind the task validation checkpoint to the integration baseline.

Evidence: SELF recursive component checks; sync_base=a736d5a420370cff052bd946f6d6397d4c354547; before_record=62ba1a225fcf1938ee97af2e08e1dbeca142fe97.

Impact: task metadata only.

Refs: .task/archive/fix-genui-prod-upgrade-followups.md
weichen merged commit d9e9c0560a into main 2026-10-21 14:00:56 +00:00
Sign in to join this conversation.
No Reviewers
No labels
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: weichen/Agent-System-Dev#681