Advance the RDM artifact pin so the delivered lifecycle work actually ships #682

Merged
weichen merged 18 commits from fix/pal-component-delivery-pins into main 2026-10-22 01:06:15 +00:00
Owner

Why: the project access and lifecycle work (U1-U6) is now on Backend and RDM main, but Dev still pins an RDM artifact from 2026-10-13 — 918-plus commits behind, and predating the point where role authority moved to Backend. Until this pin advances, none of U2/U3a/U4/U5 ships in the composed product. This PR closes that gap and brings the shared executor along so admission can recognise baseline content.

Evidence:

  • RDM pin c6304224 → bc8db88 (RDM main, PR #460). Verified that the target contains the delivered work: managementCeilingDenial and managementLifecycleDenial in internal/rdmapp/projects_api.go, txProjectManaged in internal/rdmapp/render_profile.go, MemberAddResolveFailure in internal/rdmapp/project_failure.go.
  • prev_sha becomes the previously pinned c6304224, keeping the real lifecycle suite's round-trip identity check meaningful; legacy_sha is untouched because it carries the "no identity" semantics that suite depends on. The pin file's comment now states plainly that schema compatibility between sha and prev_sha is not guaranteed by the pin and is what the real lifecycle suite verifies.
  • deps/development-manager 1e5ee55 → 2c2e372 (Development-Manager PR #32), which lets admit accept staged content byte-identical to the authoritative baseline. Without it a task branch cannot merge a mainline that carries real source changes — see the RDM case, where 65 upstream paths were refused until this landed.
  • modules/backend is not touched here: its pin f084d10 already contains the Backend merge 7158bea from this delivery, verified by ancestry.
  • Full combination verification green on 98d794e (make test, no failures). The real combination gates that actually exercise the new RDM pin — test-pg and svc-realcombo — run only in CI; local evidence cannot substitute for them.

What the pin advance exposed:

Landing the RDM half required fixing six authorization defects that Dev's gates could never have caught, because those gates only ever exercised the pinned components, never the delivery branches. Three were silent security regressions: the archived-project read-only guard had been lost, the administrator platform cap no longer bounded the creator, and render-profile still let a non-creators exercise project.settings through a role-owner label or an explicit override. Independent review found them one at a time across five rounds; the structural cause was that the R3 refactor moved management paths off evalPerm onto requireProjectManagement and dropped its gates one by one.

A note on the record: an earlier commit in this branch described the delivery branches as "red at tip" as though it were an established finding, with figures that matched no natural measurement. That has been corrected in the task card, which now separates a checkable claim from a SELF observation and voids the imprecise numbers.

Refs: Backend PR #234, RDM PR #460, Development-Manager PR #32, Dev PR #634.

Why: the project access and lifecycle work (U1-U6) is now on Backend and RDM main, but Dev still pins an RDM artifact from 2026-10-13 — 918-plus commits behind, and predating the point where role authority moved to Backend. Until this pin advances, none of U2/U3a/U4/U5 ships in the composed product. This PR closes that gap and brings the shared executor along so admission can recognise baseline content. Evidence: - RDM pin `c6304224` → `bc8db88` (RDM main, PR #460). Verified that the target contains the delivered work: `managementCeilingDenial` and `managementLifecycleDenial` in `internal/rdmapp/projects_api.go`, `txProjectManaged` in `internal/rdmapp/render_profile.go`, `MemberAddResolveFailure` in `internal/rdmapp/project_failure.go`. - `prev_sha` becomes the previously pinned `c6304224`, keeping the real lifecycle suite's round-trip identity check meaningful; `legacy_sha` is untouched because it carries the "no identity" semantics that suite depends on. The pin file's comment now states plainly that schema compatibility between `sha` and `prev_sha` is **not** guaranteed by the pin and is what the real lifecycle suite verifies. - `deps/development-manager` `1e5ee55` → `2c2e372` (Development-Manager PR #32), which lets `admit` accept staged content byte-identical to the authoritative baseline. Without it a task branch cannot merge a mainline that carries real source changes — see the RDM case, where 65 upstream paths were refused until this landed. - `modules/backend` is not touched here: its pin `f084d10` already contains the Backend merge `7158bea` from this delivery, verified by ancestry. - Full combination verification green on `98d794e` (`make test`, no failures). The real combination gates that actually exercise the new RDM pin — `test-pg` and `svc-realcombo` — run only in CI; local evidence cannot substitute for them. What the pin advance exposed: Landing the RDM half required fixing six authorization defects that Dev's gates could never have caught, because those gates only ever exercised the *pinned* components, never the delivery branches. Three were silent security regressions: the archived-project read-only guard had been lost, the administrator platform cap no longer bounded the creator, and render-profile still let a non-creators exercise `project.settings` through a role-owner label or an explicit override. Independent review found them one at a time across five rounds; the structural cause was that the R3 refactor moved management paths off `evalPerm` onto `requireProjectManagement` and dropped its gates one by one. A note on the record: an earlier commit in this branch described the delivery branches as "red at tip" as though it were an established finding, with figures that matched no natural measurement. That has been corrected in the task card, which now separates a checkable claim from a SELF observation and voids the imprecise numbers. Refs: Backend PR #234, RDM PR #460, Development-Manager PR #32, Dev PR #634.
weichen added 10 commits 2026-10-21 14:04:27 +00:00
Why: establish the authorized task workspace and its initial baseline.

Evidence: preserved precheck receipt in .task/fix-pal-component-delivery-pins.md; R0=a496ea0f0249b2b412354677ef97612ccd692d25.

Impact: task metadata only; the feature workspace starts at a496ea0f02.

Refs: .task/fix-pal-component-delivery-pins.md
Why: the task card still carried the placeholder goal while the Backend half
of the delivery had already landed, and the verified pre-merge pin state is
the justification for the whole task.

Evidence: Backend main 7158bea contains 284d3ac; Dev pins measured at
dfb31da / 113103f / RDM c6304224.

Impact: task card only.

Refs: Backend PR #234
Why: decision D1 (user ruling A1 on whether the role-cap layer is covered by
R3's carve-out) was written into an RDM test comment as "Decision A1" without
ever being recorded anywhere in the repo, so a later review round found it
cited but unverifiable. D2-D4 are not new choices either: they follow directly
from the plan's U2 archive clause, R6, and the standing platform-cap domain
rule, and now have a written home.

Evidence: RDM review rounds 1-4 in this branch's worktree.

Impact: task card only.

Refs: RDM feature/project-access-lifecycle-u4-work-states-merge
Why: both components have landed, the delivery branch red-at-tip finding and
the six authorization defects it exposed are the substantive result, and the
admit baseline-recognition change is what unblocked the merge at all. None of
that was recorded.

Evidence: Backend 7158bea (Dev pin f084d10 already contains it); RDM bc8db88
via PR #460, five review rounds ending PASS, CI green; Development-Manager
2c2e372 via PR #32.

Impact: task card only.

Refs: Backend PR #234, RDM PR #460, Development-Manager PR #32, Dev PR #634
Why: include the current integration baseline before verification.

Evidence: fetched origin/main=ccb6dfaa9cdf7e69eb15d7df024dee55f37b8df1.

Impact: integrate upstream changes without rewriting task history.

Refs: task-sync
Why: bind the task validation checkpoint to the integration baseline.

Evidence: SELF recursive component checks; sync_base=ccb6dfaa9cdf7e69eb15d7df024dee55f37b8df1; before_record=2af80d6a24bcde0a6da1f091acdb25c7e1e9a1f4.

Impact: task metadata only.

Refs: .task/fix-pal-component-delivery-pins.md
Why: an independent review caught that the card asserted the two delivery
branches were red at their tips as a verified conclusion, and that the figures
I quoted matched no natural measurement. Both are session-local observations,
not evidence this repo can reproduce.

Evidence: the card now separates a checkable claim (Dev's gates never exercise
the delivery branches) from a SELF observation with the exact commits and
method, marks it as not admissible as GATE evidence, and voids the imprecise
numbers from commit 537bf66.

Impact: task card only.

Refs: RDM PR #460, Development-Manager PR #32
Why: include the current integration baseline before verification.

Evidence: fetched origin/main=a736d5a420370cff052bd946f6d6397d4c354547.

Impact: integrate upstream changes without rewriting task history.

Refs: task-sync
Record the sync checkpoint
ci / svc-realcombo (pull_request) Successful in 4m7s
ci / test-pg (pull_request) Failing after 5m27s
ci / test (pull_request) Successful in 9m49s
98d794ee7f
Why: bind the task validation checkpoint to the integration baseline.

Evidence: SELF recursive component checks; sync_base=a736d5a420370cff052bd946f6d6397d4c354547; before_record=e8dbbe001ae12048217c0a763ab7699d183f5b1f.

Impact: task metadata only.

Refs: .task/fix-pal-component-delivery-pins.md
weichen added 1 commit 2026-10-21 14:10:48 +00:00
Record the test-pg composition failure blocking the pin advance
ci / svc-realcombo (pull_request) Successful in 4m16s
ci / test-pg (pull_request) Failing after 6m30s
ci / test (pull_request) Successful in 8m41s
1e4ac44439
Why: advancing the RDM pin red-lights test-pg on a real composition problem
that make test cannot see, and the card must say so plainly instead of showing
a green combination run.

Evidence: run 4707 job 7812 — the combination build reports missing go.sum
entries for agent-document-renderer packages. RDM bc8db88 replaces that module
with a local path and therefore carries no go.sum entries for it, while the
Dev-side build redirects the backend replace to modules/backend (f084d10),
which imports those packages directly.

Impact: task card only.

Refs: PR #682
weichen added 1 commit 2026-10-21 14:32:24 +00:00
agent-exec transport e9755166998b94fb719fea1398ca34ce/77546c2723bb
ci / svc-realcombo (pull_request) Successful in 2m52s
ci / test-pg (pull_request) Failing after 3m33s
ci / test (pull_request) Successful in 8m13s
50d3632bc7
weichen added 1 commit 2026-10-21 14:36:51 +00:00
Record the pins-layout change behind the test-pg failure
ci / svc-realcombo (pull_request) Successful in 3m54s
ci / test-pg (pull_request) Failing after 5m12s
ci / test (pull_request) Successful in 9m27s
64baa87633
Why: the fail-loud assertion worked as intended and named the real cause -
RDM's pins set grew from four to six, so the CI step that checks out and builds
all three pins no longer sees a consistent layout. My prev_sha choice was
wrong and I did not check layout consistency when writing the unit.

Evidence: run 4711 job 7821 - 'rdm pin c6304224 的 pins/agent-system-frontend
未落地:缺少 go.mod'; pin layouts verified across all five commits; local
build-product.sh on the delivered head succeeds.

Impact: task card only.

Refs: PR #682
weichen added 1 commit 2026-10-21 14:46:36 +00:00
agent-exec transport 0795c3cbd28b688d3c32abcb7f85d3de/57311a8d7d0a
ci / test-pg (pull_request) Failing after 3m27s
ci / svc-realcombo (pull_request) Successful in 3m37s
ci / test (pull_request) Successful in 8m39s
301c37cb3f
weichen added 1 commit 2026-10-21 14:52:04 +00:00
agent-exec transport 62f937e2b36ba8a042082602fc93d1cb/7c9a5c05b51c
ci / svc-realcombo (pull_request) Successful in 3m46s
ci / test (pull_request) Successful in 8m45s
ci / test-pg (pull_request) Failing after 13m7s
0aae8ed99f
weichen added 1 commit 2026-10-21 15:06:07 +00:00
Record that the CI materialization fix worked and the failure moved
ci / svc-realcombo (pull_request) Successful in 2m40s
ci / test (pull_request) Successful in 8m40s
ci / test-pg (pull_request) Failing after 12m6s
053b1719f1
Why: the pin materialization fix did its job - all three pins now build and the
missing-go.sum error is gone - so the failure relocated to the real combination
lifecycle gate, where svc.sh cannot git fetch from CI's shallow RDM clone.
That is a different component's concern and outside this pin advance.

Evidence: run 4714 job 7830 - svc-realcombo and test green; three lifecycle
cases fail on svc.sh's git fetch against the shallow RDM source clone.

Impact: task card only.

Refs: PR #682
weichen added 1 commit 2026-10-22 00:43:49 +00:00
agent-exec transport 66144e4dc1b682e328502a65bb37b911/11b7729d1914
ci / svc-realcombo (pull_request) Successful in 2m11s
ci / test (pull_request) Successful in 7m30s
ci / test-pg (pull_request) Successful in 10m9s
ed4ca46585
weichen added 1 commit 2026-10-22 00:55:13 +00:00
Merge authoritative main into the pin advance
ci / svc-realcombo (pull_request) Successful in 2m13s
ci / test (pull_request) Successful in 7m44s
ci / test-pg (pull_request) Successful in 10m8s
04d70629d6
Why: the RDM materialization fix landed separately as PR #684, so this branch
now takes main's version of the workflow and carries only the pin change. The
conflict resolution keeps the fix (submodule update per pin, language-agnostic
fail-loud assertion) and drops the pin-specific comment that described a
first-parent distance belonging to the other pull request.

Impact: workflow resolves to main's already-merged content; this commit's own
contribution is the rdm.pin prev_sha correction.

Refs: PR #682, PR #684
weichen merged commit f23f5bb01a into main 2026-10-22 01:06:15 +00:00
Sign in to join this conversation.
No Reviewers
No labels
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: weichen/Agent-System-Dev#682