Audit review minors cleanup across the five components #721

Merged
weichen merged 10 commits from feature/audit-review-minors-cleanup into main 2026-10-23 13:37:45 +00:00
Owner

Close the non-blocking review follow-ups from the four audit-review reports (batch-1 M1-M4; batch-2 B-1/B-2/B-3/B-5 notes; A1 m1-m4; A2 MI1-MI3; A3 items 1-2).

Why: each item is a reviewed, small hygiene fix: native session-scope identity collision-free encoding; squad direct field copy replacing the JSON probe, stale comment fix, save-failure memory-state consistency; command trusted-marker JSON roundtrip; intent baseline-drift caveat and element-wise slice assertion; backend intent-session comment/reason/expiry-fail-closed/slot-ownership, diagnostics terminal-state suppression and truncation notes, precedence combination tests.

Evidence: six implementation/repair units via agent-per-unit (cursor, pi with one three-failure routing change to codex, pi-glm), per-unit SELF verifications all exit=0; full make test green (verify-minors-combo4.json). Independent review lands in the task card before merge.

Impact: five component pins advance (native 4183ea7, squad 2d27389, intent 7831228, command d5bb425, backend 6710290) with matching nested-pin cascade; hygiene-only changes, no behavior semantics beyond the reviewed fixes. Routing note: squad's config temporarily disables cursor (quota), antigravity (region) and pi (terminal-record truncation x4) with recorded reasons, and adds codex to implementation while removing the emergency_profile entry.

Refs: .task/reviews/ reports (batch-1, batch-2, A1, A2, A3)

Close the non-blocking review follow-ups from the four audit-review reports (batch-1 M1-M4; batch-2 B-1/B-2/B-3/B-5 notes; A1 m1-m4; A2 MI1-MI3; A3 items 1-2). Why: each item is a reviewed, small hygiene fix: native session-scope identity collision-free encoding; squad direct field copy replacing the JSON probe, stale comment fix, save-failure memory-state consistency; command trusted-marker JSON roundtrip; intent baseline-drift caveat and element-wise slice assertion; backend intent-session comment/reason/expiry-fail-closed/slot-ownership, diagnostics terminal-state suppression and truncation notes, precedence combination tests. Evidence: six implementation/repair units via agent-per-unit (cursor, pi with one three-failure routing change to codex, pi-glm), per-unit SELF verifications all exit=0; full `make test` green (verify-minors-combo4.json). Independent review lands in the task card before merge. Impact: five component pins advance (native 4183ea7, squad 2d27389, intent 7831228, command d5bb425, backend 6710290) with matching nested-pin cascade; hygiene-only changes, no behavior semantics beyond the reviewed fixes. Routing note: squad's config temporarily disables cursor (quota), antigravity (region) and pi (terminal-record truncation x4) with recorded reasons, and adds codex to implementation while removing the emergency_profile entry. Refs: .task/reviews/ reports (batch-1, batch-2, A1, A2, A3)
weichen added 6 commits 2026-10-23 12:06:39 +00:00
Why: establish the authorized task workspace and its initial baseline.

Evidence: preserved precheck receipt in .task/feature-audit-review-minors-cleanup.md; R0=0650e81133b853f27e8e53f516de8f6c1e73e4a4.

Impact: task metadata only; the feature workspace starts at 0650e81133.

Refs: .task/feature-audit-review-minors-cleanup.md
Why: consolidate the 18 review minors into six per-repo units with
fixed scope.
Evidence: consolidated from the four review reports.
Impact: task metadata only.
Refs: .task/reviews/ reports
Why: land the review-minors fixes across native (session identity
encoding), squad (direct copy, comment, save-failure consistency),
intent (baseline caveat, slice assertion), command (trusted-marker
roundtrip) and backend (diagnostics minors, session minors).
Evidence: per-unit receipts (min-native/min-squad*/min-cmd/min-int/
min-sess2/min-diag-run.json); pins checks and full make test re-run
below.
Impact: five component gitlinks.
Refs: feature/audit-review-minors-cleanup
Why: complete the minors composition closure: native nested intent,
squad nested intent/native, backend nested intent/native/squad/command
all consistent with the Dev-level pins.
Evidence: integration transports (minorg6/minorgb-run.json); pins
checks and full make test re-run below.
Impact: three component gitlinks.
Refs: feature/audit-review-minors-cleanup
Record the minors-cleanup unit receipts and combination results
ci / svc-realcombo (pull_request) Failing after 2m38s
ci / test (pull_request) Successful in 9m37s
ci / test-pg (pull_request) Successful in 13m59s
f8377960cc
Why: audit trail for the six units, the pi disable/codex routing change
and the green combination run.
Evidence: verify-min-native/minm2c4/min-cmd/min-int3/min-sess2/min-diag/
minors-combo4 all exit=0.
Impact: task metadata only.
Refs: feature/audit-review-minors-cleanup
weichen added 3 commits 2026-10-23 12:53:53 +00:00
Why: the backend branch tip advances with the reapplied A1 m1-m4 fixes
that the independent review flagged as absent.
Evidence: repair transport (minorgb3-run.json) reusing the preserved
min-sess diff; per-package tests green (verify-a1m.json exit=0).
Impact: one component gitlink.
Refs: PR #721
Record the review BLOCK and the m1-m4 reapplication
ci / test-pg (pull_request) Successful in 20m23s
ci / svc-realcombo (pull_request) Failing after 4m14s
ci / test (pull_request) Successful in 10m39s
4dcf8a0d9a
Why: the reviewer correctly flagged the missing m1-m4 fixes; the repair
replayed the preserved transport diff onto the current tip and the pin
follows.
Evidence: a1m-run.json repair receipt; verify-a1m.json exit=0.
Impact: task metadata + backend pin note.
Refs: PR #721
weichen added 1 commit 2026-10-23 13:09:26 +00:00
Merge authoritative main into the task branch
ci / test-pg (pull_request) Successful in 24m34s
ci / svc-realcombo (pull_request) Successful in 5m8s
ci / test (pull_request) Successful in 13m19s
7ce5c1eebc
Why: include the current integration baseline before merge (carries the RDM submodule URL fix).

Evidence: fetched origin/main=f0221f75.

Impact: integrate upstream changes without rewriting task history.

Refs: task-sync
weichen merged commit d1ea338fe9 into main 2026-10-23 13:37:45 +00:00
Sign in to join this conversation.
No Reviewers
No labels
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: weichen/Agent-System-Dev#721