Add per-service database binding and fix single-dash flag detection in svc.sh #182

Merged

weichen merged 6 commits from feature/svc-db-bind into main 2026-10-04 13:44:02 +00:00

Conversation 0 Commits 6 Files Changed 3

+522 -21

6 Commits

Author	SHA1	Message	Date
weichen	83fd6f5f35	Record the sync checkpoint	2026-10-04 13:43:45 +00:00
weichen	dc7a255f31	Record the config-switching acceptance evidence in the svc-db-bind task card ... Why: completion statement carries precheck/task-sync/test evidence. Evidence: make test exit 0 at head ecfed7b; functional evidence in the card. Impact: card-only; PR description mirrors this card. Refs: .task/feature-svc-db-bind.md	2026-10-04 13:43:44 +00:00
weichen	ecfed7be31	Add service config-file switching with schema validation to svc.sh ... Why: beyond database binding, services needed a way to switch the JSON config file they run with and have the new config take effect promptly; hand-editing exec= risks restarting a service into an invalid config. Evidence: in the task worktree with a real agent binary -- a config with an unknown key is rejected by the binary's strict schema check before any state change; a valid file binds via --config in exec= + conffile= (survives record_state rewrites), restarts the running service, and the config's dsn verifiably drives the process (wrong-password variant failed PG auth in the log; correct variant connected and created 21 tables); editing the file and re-running 'config <same file>' re-validates and restarts (pid changes); '--clear' removes both the flag and conffile; db and config coexist in exec=; view mode shows masked JSON content plus 'config explain' effective values with masked dsn; list DB column also resolves dsns that live only inside the config file. Full log in the task card. Impact: new service-level action 'svc.sh <name> config [file | --clear] [--no-restart]' for agent services; config-file content snapshots (masked, --reveal to show) in info; a config-file line in status; conffile persisted in svc.env. No agent binary changes. Refs: task card .task/feature-svc-db-bind.md (same doc as PR #182); docs/svc.md sections 2/4.5/4.6/6/10.1	2026-10-04 13:42:51 +00:00
weichen	73bca5e749	Record the sync checkpoint	2026-10-04 13:30:59 +00:00
weichen	843495e0d0	Add per-service database binding and fix single-dash flag detection in svc.sh ... Why: info showed services and postgres instances but no service-to-database correspondence, and switching an agent service to another database required redeploying with a hand-built DSN. While wiring this up, adjust_args_for_bin was found matching Go flag help with '--dsn' although Go prints '-dsn', so deploy-built --dsn/--auth args were silently dropped on current binaries. Evidence: full E2E in the task worktree with a real agent binary and a real PostgreSQL 18 instance -- 't-app db bpg' persisted exec=/dbref, auto-restarted (dbref survives record_state rewrites), and the agent created 21 tables in the bound database; 'db bpg --db t2' auto-created and switched databases (21 tables in t2); '--clear' returned the service to embedded SQLite; --no-restart and error paths behave; list gains a DB column, status a database line, info a reverse bound-services line; legacy deployments without dbref resolve by DSN host:port; single-dash detection proven with positive and negative cases; regressions list/db dsn/db ls/info/history/--help pass; make test exit 0. Full log in the task card. Impact: new service-level action 'svc.sh <name> db [pg [--db X] | --clear] [--no-restart]' for agent services (bind/switch/unbind/view), DB column in list, binding lines in status/info, dbref persisted in svc.env, auto database creation when the instance runs, and the adjust_args_for_bin fix restoring deploy --dsn/--auth on current binaries. No agent binary changes. Refs: task card .task/feature-svc-db-bind.md (same doc as the PR); docs/svc.md sections 4.5/6.1/6.2/10.1	2026-10-04 13:30:50 +00:00
weichen	d1aebd9919	Record the task card for feature-svc-db-bind	2026-10-04 13:23:33 +00:00