weichen/Agent-System-Dev
1
0
Fork 0
Code Issues 1 Pull Requests 2 Actions 2 Packages Projects Releases Wiki Activity

Stop task-finish from uninitializing shared submodule config #75

Merged
weichen merged 6 commits from fix/task-finish-close-followups into main 2026-09-30 16:03:49 +00:00
Conversation 0 Commits 6 Files Changed 5
+38 -6
6 Commits
Author SHA1 Message Date
weichen 9bb0af593c Record the sync checkpoint
ci / test (pull_request) Failing after 1m35s
Details
2026-09-30 16:03:44 +00:00
weichen a552939497 Merge remote-tracking branch 'origin/main' into fix/task-finish-close-followups 2026-09-30 16:03:44 +00:00
weichen e6cee503a2 Record the sync checkpoint
ci / test (pull_request) Failing after 11m5s
Details
2026-09-30 16:01:38 +00:00
weichen b46d890529 Merge remote-tracking branch 'origin/main' into fix/task-finish-close-followups 2026-09-30 16:01:38 +00:00
weichen c61920a8dc Stop task-finish from uninitializing shared submodule config 
Why: cmd_finish ran git submodule deinit --all, but submodule.<name>.url entries live in the shared .git/config — finishing any task silently marked every other checkout and worktree uninitialized (observed twice on 2026-09-30: main checkout uninit=12 after each finish; a parallel session hit it minutes before this fix landed). The deinit serves no purpose: worktree removal with gitlinks is refused regardless, so cleanup already goes through rm -rf + prune. Also aligns AGENTS.md with observed hook behavior (post-merge fires on ff-only pulls too, and its inline close cannot see cards merged remotely until they are pulled), and ignores the ZCode-generated .zcodeignore that tripped the BUSY gate in every session.
Evidence: bash -n clean; abandon-path smoke of the patched script — start + FORCE_ABANDON=1 finish of a throwaway branch left shared submodule url config at 12 entries (pre-fix: 0), main checkout submodule status uninit=0, smoke worktree and branch fully recycled; the smoke close also backfilled a parallel session card left open (gitea-access-facts) via a card-close branch, proving the fallback path.
Impact: scripts/task.sh cmd_finish only (removes one line, updates comment), AGENTS.md card-close paragraph, .gitignore one entry. No product or gitlink change; make test not applicable (repo-level tooling/docs only). web_base default fix intentionally withdrawn from this PR — landed via parallel PR #73.
Refs: .task/fix-task-finish-close-followups.md
 2026-09-30 16:00:31 +00:00
weichen 7dbb5f97a6 Record the task card for fix-task-finish-close-followups 2026-09-30 15:46:04 +00:00