Skip role options for non-managers and guard zero run time #117

Merged
weichen merged 2 commits from fix/multiuser-project-collab-r2 into main 2026-10-20 07:05:50 +00:00
Owner

Why: after IAM U4 (#115) gated member management via rdm.perm.check, ordinary project members still trigger a 403 because the members section requests rdm.role.options (authorized by member.manage) on every visit; and the live status bar shows an enormous elapsed time when a run arrives with the zero start time 0001-01-01T00:00:00Z.

Changes:

  • RdmMembersSection requests rdm.role.options only once manage.canManage is true (re-requested on project change; late responses dropped).
  • eventTime falls back to now for non-positive parsed timestamps.
  • Tests: test/event-time.test.ts, test/rdm-members-options-gate.test.tsx.

Evidence: CI on PR HEAD is authoritative; worker ran tsc/vitest in its isolated workspace (SELF).
Impact: Frontend members section and store helper only. Supersedes #116.
Refs: Dev task fix/multiuser-project-collab; agent-exec transport d997d4a (PI).

Why: after IAM U4 (#115) gated member management via rdm.perm.check, ordinary project members still trigger a 403 because the members section requests `rdm.role.options` (authorized by member.manage) on every visit; and the live status bar shows an enormous elapsed time when a run arrives with the zero start time `0001-01-01T00:00:00Z`. Changes: - RdmMembersSection requests `rdm.role.options` only once `manage.canManage` is true (re-requested on project change; late responses dropped). - `eventTime` falls back to now for non-positive parsed timestamps. - Tests: `test/event-time.test.ts`, `test/rdm-members-options-gate.test.tsx`. Evidence: CI on PR HEAD is authoritative; worker ran tsc/vitest in its isolated workspace (SELF). Impact: Frontend members section and store helper only. Supersedes #116. Refs: Dev task fix/multiuser-project-collab; agent-exec transport d997d4a (PI).
weichen added 1 commit 2026-10-20 06:26:39 +00:00
agent-exec transport 85c00f1e2274be1a84b73a421987fc69/ba12fd06dc72
governance / governance (pull_request) Successful in 16s
ci / test-and-build (pull_request) Successful in 34m20s
d997d4a4d0
weichen closed this pull request 2026-10-20 06:55:55 +00:00
weichen reopened this pull request 2026-10-20 06:55:58 +00:00
weichen added 1 commit 2026-10-20 07:01:36 +00:00
Merge branch 'main' into fix/multiuser-project-collab-r2
ci / test-and-build (pull_request) Successful in 1m13s
governance / governance (pull_request) Successful in 16s
97b947a8e3
weichen merged commit c6df2dc180 into main 2026-10-20 07:05:50 +00:00
Sign in to join this conversation.
No Reviewers
No labels
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: weichen/Agent-System-Frontend#117