Make the preview pane the only scrolling preview #46

Merged

weichen merged 2 commits from feature/preview-scroll-consolidate into main

2026-10-05 04:42:25 +00:00

Author	SHA1	Message	Date
weichen	62aa5f8a56	Merge remote-tracking branch 'origin/main' into feature/preview-scroll-consolidate Co-authored-by: Cursor <cursoragent@cursor.com> # Conflicts: # src/styles.css	2026-10-05 04:42:19 +00:00
weichenandCursor	d384a3d778	Make the preview pane the only scrolling preview Why: The pane pinned .ui-fp to the column height, and the docx fit host then clipped overflow, so the right-hand preview could not scroll. The fullscreen DocViewer was a second shell around the same FilePreview. Evidence: npx vitest run (17 files, 82 tests) and npx tsc --noEmit passed. Headless Chromium laid out a 1400px docx host inside a 764px pane (body scrollHeight 1400) and a pdf iframe that filled that pane. Impact: .preview-pane-body is the scroll owner. Docx refit also watches page height. The overlay viewer is gone; expand/restore and text edit/save live on the pane. Refs: Agent-System-Dev#196, Agent-System-Frontend#44 Co-authored-by: Cursor <cursoragent@cursor.com>	2026-10-05 04:41:20 +00:00

Author

SHA1

Message

Date

weichen

62aa5f8a56

Merge remote-tracking branch 'origin/main' into feature/preview-scroll-consolidate

Co-authored-by: Cursor <cursoragent@cursor.com>

# Conflicts:
#	src/styles.css

2026-10-05 04:42:19 +00:00

weichenandCursor

d384a3d778

Make the preview pane the only scrolling preview

Why: The pane pinned .ui-fp to the column height, and the docx fit host then clipped overflow, so the right-hand preview could not scroll. The fullscreen DocViewer was a second shell around the same FilePreview.
Evidence: npx vitest run (17 files, 82 tests) and npx tsc --noEmit passed. Headless Chromium laid out a 1400px docx host inside a 764px pane (body scrollHeight 1400) and a pdf iframe that filled that pane.
Impact: .preview-pane-body is the scroll owner. Docx refit also watches page height. The overlay viewer is gone; expand/restore and text edit/save live on the pane.
Refs: Agent-System-Dev#196, Agent-System-Frontend#44
Co-authored-by: Cursor <cursoragent@cursor.com>

2026-10-05 04:41:20 +00:00