weichen/Agent-System
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

issue#2 收官：按包测试库 + 生产同构审批夹具；短测全量必需门禁 #18

Merged
weichen merged 2 commits from feature/issue2-pg-tests-perpackage-db-2026-09-29 into dev 2026-09-29 10:11:43 +00:00
Conversation 1 Commits 2 Files Changed 45
+335 -153
2 Commits
Author SHA1 Message Date
agent-bot cbef2157d8 fix(web): restore dist/.gitkeep dropped by local build + git add -A
CI / go-vet (pull_request) Successful in 45s
Details
CI / backup-restore-drill (pull_request) Successful in 40s
Details
CI / web (pull_request) Successful in 34s
Details 
vite build empties web/dist (including the tracked .gitkeep that keeps
go:embed all:dist satisfiable on fresh checkouts); restore it.
 2026-09-29 10:03:30 +00:00
agent-bot ee1e53b510 fix(tests): per-package test databases + legitimate approval fixtures (issue #2 close)
CI / go-vet (pull_request) Failing after 10s
Details
CI / backup-restore-drill (pull_request) Failing after 25s
Details
CI / web (pull_request) Successful in 33s
Details 
Root causes of the remaining 5 CI PG failures (and the hidden flaky set):
1. All PG-integration packages shared ONE database under parallel package
   execution - migrations/seeds/truncates raced (nondeterministic failure
   sets, locally and in CI).
   Fix: RequireTestDatabaseURL/SkipIfNoTestDatabaseURL now derive a
   per-package database (<base>_<pkgHash>, advisory-lock-guarded
   CREATE); 9 raw-env straggler tests funnelled through the helpers;
   db-package tests call it unqualified (no import cycle).
2. Approval-chain fixtures were not production-shaped: freezeReviewSnapshot
   only honors head_snapshot_id, fake content hashes never froze a
   snapshot, so ApproverApprove rejected with 'approved requires frozen
   review_snapshot_id'. Errors were swallowed (_, _ =) hiding this.
   Fix (ownership-respecting, arch-enforced):
   - docrevision.SeedContentSnapshotForTest seeds the ledger tables it owns
   - docgov GovernanceEngine.FreezeHeadSnapshotForTest freezes head/review
     pointers on document_records (docgov-owned) and clears engine cache
   - all four integration fixtures use the pair; swallowed errors checked
3. Fixed-name fixtures collide once a package shares one DB (projects
   uq_projects_name_global): uniquified in projectinstance + server tests.
4. CAS/ctxmgr tests never bootstrapped migrations (relied on other packages
   having migrated the shared DB): explicit RunMigrationsOnceForTest.

Verified: full parallel short suite = 75 packages, 0 failures against an
isolated throwaway PG. CI skip list removed - short tests fully required.
 2026-09-29 09:54:43 +00:00