Files
agent-bot ee1e53b510
CI / go-vet (pull_request) Failing after 10s
CI / backup-restore-drill (pull_request) Failing after 25s
CI / web (pull_request) Successful in 33s
fix(tests): per-package test databases + legitimate approval fixtures (issue #2 close)
Root causes of the remaining 5 CI PG failures (and the hidden flaky set):
1. All PG-integration packages shared ONE database under parallel package
   execution - migrations/seeds/truncates raced (nondeterministic failure
   sets, locally and in CI).
   Fix: RequireTestDatabaseURL/SkipIfNoTestDatabaseURL now derive a
   per-package database (<base>_<pkgHash>, advisory-lock-guarded
   CREATE); 9 raw-env straggler tests funnelled through the helpers;
   db-package tests call it unqualified (no import cycle).
2. Approval-chain fixtures were not production-shaped: freezeReviewSnapshot
   only honors head_snapshot_id, fake content hashes never froze a
   snapshot, so ApproverApprove rejected with 'approved requires frozen
   review_snapshot_id'. Errors were swallowed (_, _ =) hiding this.
   Fix (ownership-respecting, arch-enforced):
   - docrevision.SeedContentSnapshotForTest seeds the ledger tables it owns
   - docgov GovernanceEngine.FreezeHeadSnapshotForTest freezes head/review
     pointers on document_records (docgov-owned) and clears engine cache
   - all four integration fixtures use the pair; swallowed errors checked
3. Fixed-name fixtures collide once a package shares one DB (projects
   uq_projects_name_global): uniquified in projectinstance + server tests.
4. CAS/ctxmgr tests never bootstrapped migrations (relied on other packages
   having migrated the shared DB): explicit RunMigrationsOnceForTest.

Verified: full parallel short suite = 75 packages, 0 failures against an
isolated throwaway PG. CI skip list removed - short tests fully required.
2026-09-29 09:54:43 +00:00

130 lines
3.4 KiB
Go

package taskrun_test
import (
"context"
"testing"
"time"
"github.com/jackc/pgx/v5/pgxpool"
"chat-agent-system/internal/db"
"chat-agent-system/internal/taskrun"
)
func openLeaseTestPool(t *testing.T) *pgxpool.Pool {
t.Helper()
dsn := db.SkipIfNoTestDatabaseURL(t)
ctx, cancel := context.WithTimeout(context.Background(), 15*time.Second)
defer cancel()
pool, err := pgxpool.New(ctx, dsn)
if err != nil {
t.Skipf("postgres unavailable: %v", err)
return nil
}
if err := pool.Ping(ctx); err != nil {
pool.Close()
t.Skipf("postgres ping failed: %v", err)
return nil
}
migCtx, migCancel := context.WithTimeout(context.Background(), 60*time.Second)
defer migCancel()
if err := db.RunMigrations(migCtx, pool, db.ResolveMigrationsDir()); err != nil {
pool.Close()
t.Skipf("migration failed: %v", err)
return nil
}
if !taskrun.LeaseColumnsReady(ctx, pool) {
pool.Close()
t.Skip("task run lease columns not ready")
}
return pool
}
func TestPGStore_StaleLeaseMarkedInterrupted(t *testing.T) {
pool := openLeaseTestPool(t)
if pool == nil {
return
}
defer pool.Close()
ctx := context.Background()
store := taskrun.NewPGStore(pool)
runID := "run_stale_lease_" + time.Now().Format("150405.000000")
var userID int64
err := pool.QueryRow(ctx, `SELECT id FROM users ORDER BY id LIMIT 1`).Scan(&userID)
if err != nil {
t.Fatalf("fetch user: %v", err)
}
expired := time.Now().Add(-1 * time.Minute)
_, err = pool.Exec(ctx, `
INSERT INTO task_runs (
run_id, session_id, user_id, status, worker_id, lease_expires_at, lease_heartbeat_at, created_at, updated_at
) VALUES ($1, 'sess', $2, 'running', 'dead-worker', $3, $3, now(), now())
`, runID, userID, expired)
if err != nil {
t.Fatalf("insert stale run: %v", err)
}
t.Cleanup(func() {
_, _ = pool.Exec(context.Background(), `DELETE FROM task_runs WHERE run_id = $1`, runID)
})
n, err := store.MarkOrphanedRunning(ctx)
if err != nil {
t.Fatalf("MarkOrphanedRunning: %v", err)
}
if n < 1 {
t.Fatalf("expected at least 1 interrupted, got %d", n)
}
rec, err := store.GetRun(ctx, runID)
if err != nil {
t.Fatalf("GetRun: %v", err)
}
if rec.Status != "interrupted" {
t.Fatalf("status=%s want interrupted", rec.Status)
}
}
func TestPGStore_FreshLeaseSurvivesOrphanScan(t *testing.T) {
pool := openLeaseTestPool(t)
if pool == nil {
return
}
defer pool.Close()
ctx := context.Background()
store := taskrun.NewPGStore(pool)
runID := "run_fresh_lease_" + time.Now().Format("150405.000000")
workerID := "worker-alive"
var userID int64
_ = pool.QueryRow(ctx, `SELECT id FROM users ORDER BY id LIMIT 1`).Scan(&userID)
fresh := time.Now().Add(30 * time.Second)
_, err := pool.Exec(ctx, `
INSERT INTO task_runs (
run_id, session_id, user_id, status, worker_id, lease_expires_at, lease_heartbeat_at, created_at, updated_at
) VALUES ($1, 'sess', $2, 'running', $3, $4, now(), now(), now())
`, runID, userID, workerID, fresh)
if err != nil {
t.Fatalf("insert fresh run: %v", err)
}
t.Cleanup(func() {
_, _ = pool.Exec(context.Background(), `DELETE FROM task_runs WHERE run_id = $1`, runID)
})
if _, err := store.MarkOrphanedRunning(ctx); err != nil {
t.Fatalf("MarkOrphanedRunning: %v", err)
}
rec, err := store.GetRun(ctx, runID)
if err != nil {
t.Fatalf("GetRun: %v", err)
}
if rec.Status != "running" {
t.Fatalf("fresh lease run should stay running, got %s", rec.Status)
}
}