agent-bot
ee1e53b510
CI / go-vet (pull_request) Failing after 10s
CI / backup-restore-drill (pull_request) Failing after 25s
CI / web (pull_request) Successful in 33s
fix(tests): per-package test databases + legitimate approval fixtures (issue #2 close)
...
Root causes of the remaining 5 CI PG failures (and the hidden flaky set):
1. All PG-integration packages shared ONE database under parallel package
execution - migrations/seeds/truncates raced (nondeterministic failure
sets, locally and in CI).
Fix: RequireTestDatabaseURL/SkipIfNoTestDatabaseURL now derive a
per-package database (<base>_<pkgHash>, advisory-lock-guarded
CREATE); 9 raw-env straggler tests funnelled through the helpers;
db-package tests call it unqualified (no import cycle).
2. Approval-chain fixtures were not production-shaped: freezeReviewSnapshot
only honors head_snapshot_id, fake content hashes never froze a
snapshot, so ApproverApprove rejected with 'approved requires frozen
review_snapshot_id'. Errors were swallowed (_, _ =) hiding this.
Fix (ownership-respecting, arch-enforced):
- docrevision.SeedContentSnapshotForTest seeds the ledger tables it owns
- docgov GovernanceEngine.FreezeHeadSnapshotForTest freezes head/review
pointers on document_records (docgov-owned) and clears engine cache
- all four integration fixtures use the pair; swallowed errors checked
3. Fixed-name fixtures collide once a package shares one DB (projects
uq_projects_name_global): uniquified in projectinstance + server tests.
4. CAS/ctxmgr tests never bootstrapped migrations (relied on other packages
having migrated the shared DB): explicit RunMigrationsOnceForTest.
Verified: full parallel short suite = 75 packages, 0 failures against an
isolated throwaway PG. CI skip list removed - short tests fully required.
2026-09-29 09:54:43 +00:00
..
2026-09-28 02:27:16 +00:00
2026-09-28 02:27:16 +00:00
2026-09-28 02:27:16 +00:00
2026-09-15 14:40:56 +00:00
2026-09-28 02:27:16 +00:00
2026-09-25 13:17:22 +00:00
2026-09-28 02:27:16 +00:00
2026-09-28 02:27:16 +00:00
2026-09-28 02:27:16 +00:00
2026-09-21 09:47:06 +00:00
2026-09-28 02:27:16 +00:00
2026-09-16 09:42:07 +00:00
2026-09-28 02:27:16 +00:00
2026-09-28 02:27:16 +00:00
2026-09-28 02:27:16 +00:00
2026-09-25 16:33:58 +00:00
2026-09-16 09:42:07 +00:00
2026-09-25 13:17:22 +00:00
2026-09-24 11:49:43 +00:00
2026-09-13 02:50:23 +00:00
2026-09-13 02:50:23 +00:00
2026-09-28 02:00:24 +00:00
2026-09-28 02:27:16 +00:00
2026-09-25 13:17:22 +00:00
2026-09-29 09:54:43 +00:00
2026-09-15 14:40:56 +00:00
2026-09-15 13:00:33 +00:00
2026-09-25 13:17:22 +00:00
2026-09-23 12:45:30 +00:00
2026-09-13 12:25:22 +00:00
2026-09-20 10:42:58 +00:00
2026-09-25 13:17:22 +00:00
2026-09-20 10:42:58 +00:00
2026-09-15 13:00:33 +00:00
2026-09-15 14:40:56 +00:00
2026-09-18 03:39:08 +00:00
2026-09-19 09:28:11 +00:00
2026-09-25 20:08:56 +00:00
2026-09-28 02:27:16 +00:00
2026-09-28 02:00:24 +00:00
2026-09-25 13:17:22 +00:00
2026-09-15 13:00:33 +00:00
2026-09-28 02:27:16 +00:00
2026-09-17 17:03:08 +00:00
2026-09-28 02:27:16 +00:00
2026-09-25 14:37:11 +00:00
2026-09-28 02:27:16 +00:00
2026-09-20 07:04:57 +00:00
2026-09-25 13:17:22 +00:00
2026-09-25 13:17:22 +00:00
2026-09-25 13:17:22 +00:00
2026-09-26 02:00:14 +00:00
2026-09-28 02:27:16 +00:00
2026-09-25 13:17:22 +00:00
2026-09-13 11:12:03 +00:00
2026-09-28 02:27:16 +00:00
2026-09-28 02:27:16 +00:00
2026-09-25 13:17:22 +00:00
2026-09-28 12:34:32 +00:00
2026-09-29 09:54:43 +00:00
2026-09-24 11:49:43 +00:00
2026-09-25 13:17:22 +00:00
2026-09-25 13:17:22 +00:00
2026-09-25 13:17:22 +00:00
2026-09-15 14:40:56 +00:00
2026-09-25 13:17:22 +00:00
2026-09-28 02:27:16 +00:00
2026-09-28 02:37:48 +00:00
2026-09-29 09:54:43 +00:00
2026-09-28 02:27:16 +00:00
2026-09-28 02:27:16 +00:00
2026-09-25 13:17:22 +00:00
2026-09-28 02:27:16 +00:00
2026-09-28 02:00:24 +00:00
2026-09-26 02:00:14 +00:00
2026-09-26 02:00:14 +00:00
2026-09-26 02:00:14 +00:00
2026-09-15 13:00:33 +00:00
2026-09-25 13:17:22 +00:00
2026-09-20 03:45:16 +00:00
2026-09-25 13:17:22 +00:00
2026-09-19 06:00:30 +00:00
2026-09-25 04:45:49 +00:00
2026-09-25 04:45:49 +00:00
2026-09-28 02:27:16 +00:00
2026-09-25 16:33:58 +00:00
2026-09-28 02:27:16 +00:00
2026-09-16 10:42:20 +00:00
2026-09-24 11:49:43 +00:00
2026-09-28 02:27:16 +00:00
2026-09-24 11:49:43 +00:00
2026-09-28 02:27:16 +00:00
2026-09-29 09:54:43 +00:00
2026-09-29 09:54:43 +00:00
2026-09-22 18:15:29 +08:00
2026-09-13 02:50:23 +00:00
2026-09-22 19:40:28 +08:00
2026-09-17 02:04:51 +00:00
2026-09-25 13:17:22 +00:00
2026-09-29 09:04:16 +00:00
2026-09-29 09:54:43 +00:00
2026-09-14 14:07:05 +00:00
2026-09-28 02:27:16 +00:00
2026-09-26 02:00:14 +00:00
2026-09-28 02:27:16 +00:00
2026-09-29 09:54:43 +00:00
2026-09-28 02:27:16 +00:00
2026-09-13 22:37:24 +00:00
2026-09-17 09:39:59 +00:00
2026-09-28 02:27:16 +00:00
2026-09-20 03:45:16 +00:00
2026-09-28 02:27:16 +00:00
2026-09-23 13:57:08 +00:00
2026-09-25 13:17:22 +00:00
2026-09-25 20:08:56 +00:00
2026-09-20 07:04:57 +00:00
2026-09-16 09:42:07 +00:00
2026-09-25 13:17:22 +00:00
2026-09-28 10:36:26 +00:00
2026-09-19 09:19:36 +00:00
2026-09-28 02:27:16 +00:00
2026-09-28 06:09:42 +00:00
2026-09-28 10:30:52 +00:00
2026-09-14 08:39:44 +00:00
2026-09-28 12:34:32 +00:00
2026-09-17 08:18:11 +00:00
2026-09-24 16:13:47 +00:00
2026-09-25 20:08:56 +00:00
2026-09-25 20:08:56 +00:00
2026-09-28 02:27:16 +00:00
2026-09-25 21:01:37 +00:00
2026-09-25 21:01:37 +00:00
2026-09-23 13:57:08 +00:00
2026-09-25 13:17:22 +00:00
2026-09-25 21:01:37 +00:00
2026-09-25 13:17:22 +00:00
2026-09-29 09:54:43 +00:00
2026-09-26 02:00:14 +00:00
2026-09-28 10:36:26 +00:00
2026-09-26 02:00:14 +00:00
2026-09-25 13:17:22 +00:00
2026-09-28 12:34:32 +00:00
2026-09-23 12:45:30 +00:00
2026-09-17 09:46:09 +00:00
2026-09-23 12:45:30 +00:00
2026-09-28 12:34:32 +00:00
2026-09-13 02:50:22 +00:00
2026-09-13 02:50:22 +00:00
2026-09-23 12:45:30 +00:00
2026-09-28 02:27:16 +00:00
2026-09-28 02:27:16 +00:00
2026-09-23 13:57:08 +00:00
2026-09-14 12:52:28 +00:00
2026-09-23 13:57:08 +00:00
2026-09-25 13:17:22 +00:00
2026-09-16 09:42:07 +00:00
2026-09-25 13:17:22 +00:00
2026-09-28 02:27:16 +00:00
2026-09-22 19:20:11 +08:00
2026-09-29 09:54:43 +00:00
2026-09-24 03:24:13 +00:00
2026-09-25 13:17:22 +00:00
2026-09-28 02:27:16 +00:00
2026-09-21 14:58:21 +00:00
2026-09-28 02:27:16 +00:00