Make delivery goal-first and route execution through project CLIs #567

Merged
weichen merged 27 commits from feature/goal-first-delivery into main 2026-10-15 09:19:33 +00:00
Owner

Why: Make the approved task goal and system usability the first delivery priority, prevent unauthorized scope expansion, and route expensive implementation/testing through project-configured CLIs.

Evidence: Task card .task/feature-goal-first-delivery.md; local make test && make build passed for implementation HEAD fec42e0320c458a8aa060ce9295f332a3ec6d58d; independent fresh PI/MiniMax review reported NO_FINDINGS; final metadata-only HEAD is 8184275cd20d7899c02b9441dce86c759ff0b92d.

Impact: Adds AGENT-EXECUTION.md, Cursor/agy/PI adapters and controller/history support, fresh-session review rules, and goal-first delivery governance. No business code, dependency pins, deployment, or platform protection changes.

Refs: feature/goal-first-delivery; merge-queue issue #518 window mq-dev-20261015-goal-first-delivery-02.

Why: Make the approved task goal and system usability the first delivery priority, prevent unauthorized scope expansion, and route expensive implementation/testing through project-configured CLIs. Evidence: Task card `.task/feature-goal-first-delivery.md`; local `make test && make build` passed for implementation HEAD `fec42e0320c458a8aa060ce9295f332a3ec6d58d`; independent fresh PI/MiniMax review reported NO_FINDINGS; final metadata-only HEAD is `8184275cd20d7899c02b9441dce86c759ff0b92d`. Impact: Adds `AGENT-EXECUTION.md`, Cursor/agy/PI adapters and controller/history support, fresh-session review rules, and goal-first delivery governance. No business code, dependency pins, deployment, or platform protection changes. Refs: feature/goal-first-delivery; merge-queue issue #518 window `mq-dev-20261015-goal-first-delivery-02`.
weichen added 24 commits 2026-10-15 08:43:07 +00:00
Why: establish the authorized task workspace and its initial baseline.

Evidence: preserved precheck receipt in .task/feature-goal-first-delivery.md; R0=33261925a10c4eee40d1b6175b3895e78a47ef02.

Impact: task metadata only; the feature workspace starts at 33261925a1.

Refs: .task/feature-goal-first-delivery.md
Why: Keep authorized work focused on its stated outcome, prevent private scope expansion, and remove mechanical human stage gates.

Evidence: make test-governance passed 344 tests with 18 environment-dependent skips; receipt is recorded in the task card.

Impact: New tasks use goal-first execution while retaining real decision points, independent review, evidence, platform admission, and high-consequence dual keys.

Refs: .task/feature-goal-first-delivery.md
Why: Ensure implementation authorship is delegated per unit while the primary model remains responsible for planning and delivery management.

Evidence: The focused task-card generation regression went red then green, and git diff --check passed.

Impact: Every repository-writing implementation unit gets a fresh Cursor CLI run; unavailable or failed Cursor work is recorded as a blocker instead of being silently implemented by the primary model.

Refs: .task/feature-goal-first-delivery.md
Why: Keep the task authority, execution attempts, and stage-six candidate state recoverable.

Evidence: make evidence captured the controller status for P2 at canonical commit d79d6c17 and the run-wide governance verification receipt.

Impact: Records one failed no-change attempt, one successful Cursor attempt, host integration, and all remaining NOT_RUN stages without changing implementation behavior.

Refs: .task/feature-goal-first-delivery.md
Why: Synchronize the approved policy candidate with the active simplified merge-window rules now on origin/main.

Evidence: Resolved the two semantic conflicts by preserving upstream queue simplification and this task's goal-first/cursor-per-unit contract; focused task-card regression and cached diff checks passed.

Impact: Retains the active single-window delivery process while replacing mechanical stage approvals with necessary decisions and preserving Cursor-per-unit execution.

Refs: .task/feature-goal-first-delivery.md
Why: Preserve the stage-six approval, resolved synchronization result, and exclusive final-window claim before fixing the tested candidate.

Evidence: make task-sync incorporated origin/main at cc40e10 with changed=0 after the conflict-resolution merge; queue claim is issue #518 comment 6478.

Impact: Advances this task to formal verification without changing implementation behavior or expanding its scope.

Refs: .task/feature-goal-first-delivery.md
Why: Let each project route expensive implementation work across available Agent CLIs while the host model retains planning and delivery control.

Evidence: The specification passed placeholder, consistency, scope, path, and whitespace self-checks; implementation and runtime validation remain NOT_RUN.

Impact: Defines a review-only R1-R10 design for Markdown configuration, adapters, run-everything execution, receipts, recovery, and host fallback without enabling the new route.

Refs: .task/feature-goal-first-delivery.md
Why: Turn the approved multi-CLI routing design into independently testable Cursor implementation units without another manual plan gate.

Evidence: The plan self-review found R1-R10 coverage, stable interfaces, five review-focus tests, and no placeholders or whitespace errors.

Impact: Authorizes U1-U5 execution through fresh Cursor Agent runs while the host retains scope, verification, integration, and delivery control.

Refs: docs/superpowers/specs/2026-10-15-project-agent-execution-design.md
Why: Establish one validated project-local routing document before any real Agent execution is enabled.

Evidence: Cursor observed red then 12 green configuration tests; the host replays those tests, the temporary validation target, and whitespace checks during integration.

Impact: Adds the U1 configuration contract and parser only; real routing, adapters, controller execution, and governance adoption remain disabled.

Refs: docs/superpowers/plans/2026-10-15-project-agent-execution.md
Why: Hide provider-specific noninteractive, model, permission, workspace, prompt, and output differences behind one adapter seam.

Evidence: Cursor observed red then 22 green config/adapter tests; the host replays them and whitespace checks during integration.

Impact: Adds deterministic direct-argv adapters and probes without launching providers or enabling project routing.

Refs: docs/superpowers/plans/2026-10-15-project-agent-execution.md
Why: provide isolated, recoverable per-unit CLI execution and safe host fallback
Evidence: 43 focused tests, configuration validation, governance regression, and diff check
Impact: adds agent-exec validate/run controller, receipts, transports, and Make entrypoint
Refs: U3; docs/superpowers/plans/2026-10-15-project-agent-execution.md
Why: replace fixed Cursor execution authority with project-configured agent routing
Evidence: focused task-card contract, agent-exec validation, governance regression, and diff check
Impact: updates project policy, task templates, capability records, and current task metadata
Refs: U4; docs/superpowers/plans/2026-10-15-project-agent-execution.md
Why: verify configured Agent CLIs one profile at a time before declaring them usable

Evidence: 53 focused tests, agent-exec validation, 397-test governance regression, and diff check

Impact: adds opt-in source-external probes, acceptance checks, and current task records

Refs: U5; docs/superpowers/plans/2026-10-15-project-agent-execution.md
Why: prevent silent provider stalls from consuming the full execution timeout

Evidence: 57 focused tests, configuration validation, 401-test governance regression, and diff check

Impact: adds backward-compatible idle_timeout_seconds and fail-stop process supervision

Refs: U5 runtime acceptance; docs/superpowers/plans/2026-10-15-project-agent-execution.md
Why: prevent unrelated sibling worktree delivery from invalidating otherwise safe agent attempts
Evidence: 58 focused tests, configuration validation, governance regression, and diff check
Impact: uses private shared clones and copies only host-owned transport refs back to canonical Git
Refs: U5 runtime acceptance; docs/superpowers/plans/2026-10-15-project-agent-execution.md
Why: prevent unrequested platform work and repeated validation from delaying simple user goals

Evidence: git diff --check

Impact: makes scope discipline, proportional testing, and usable-first stop rules immediately effective

Refs: feature/goal-first-delivery
Why: make the three approved CLIs the only active implementation and test routes

Evidence: adapter unit tests, configuration validation, diff check, and real marker probes for all three profiles

Impact: narrows project routing and fixes agy prompt binding for noninteractive execution

Refs: feature/goal-first-delivery
Why: prevent implementation context from contaminating independent design test and review judgments

Evidence: git diff --check

Impact: requires fresh CLI sessions per stage and forbids implementation-session reuse for Review

Refs: feature/goal-first-delivery
Why: retain which CLI handled each task so routing can improve from real outcomes over time

Evidence: AgentExecHistoryTests and git diff --check

Impact: appends sanitized source-external JSONL records without changing run outcomes

Refs: feature/goal-first-delivery
Why: align the task card with the completed three-CLI routing and execution-history scope

Evidence: source-external probe receipts and git diff --check

Impact: marks implementation complete and final delivery gates pending

Refs: #518
Why: include the current integration baseline before verification.

Evidence: fetched origin/main=919f75cf7b39ca357e212a08a0ba5ba3d9a79b51.

Impact: integrate upstream changes without rewriting task history.

Refs: task-sync
Why: bind the task validation checkpoint to the integration baseline.

Evidence: SELF recursive component checks; sync_base=919f75cf7b39ca357e212a08a0ba5ba3d9a79b51; before_record=5d7f6c79af9594562390430e09b595dd55da7a6e.

Impact: task metadata only.

Refs: .task/feature-goal-first-delivery.md
Why: execution history intentionally adds one source-external Git metadata path after every run

Evidence: focused fallback and history tests

Impact: preserves the no-canonical-implementation assertion while accepting the history record

Refs: feature/goal-first-delivery
Record independent delivery review
ci / svc-realcombo (pull_request) Successful in 2m13s
ci / test (pull_request) Failing after 3m58s
ci / test-pg (pull_request) Successful in 8m16s
8184275cd2
Why: Record the fixed-candidate validation and independent fresh-session review before opening the delivery PR.

Evidence: PI MiniMax-M3 session 01a13eb4-5e25-70e9-95ae-2342ec525fac reported NO_FINDINGS for fec42e0320c458a8aa060ce9295f332a3ec6d58d; make test and make build passed.

Impact: Updates only delivery metadata; implementation behavior is unchanged.

Refs: feature/goal-first-delivery
weichen added 1 commit 2026-10-15 08:43:24 +00:00
Link the delivery pull request
ci / svc-realcombo (pull_request) Successful in 2m14s
ci / test (pull_request) Failing after 4m0s
ci / test-pg (pull_request) Successful in 8m4s
b4139a56d2
Why: Make PR #567 the task card primary delivery record before CI and merge.

Evidence: https://git-home.u1680832.nyat.app:30319/weichen/Agent-System-Dev/pulls/567

Impact: Updates only task metadata; implementation behavior is unchanged.

Refs: #567
weichen added 1 commit 2026-10-15 08:59:18 +00:00
Make transport commits independent of Git identity
ci / svc-realcombo (pull_request) Successful in 2m1s
ci / test (pull_request) Failing after 3m50s
ci / test-pg (pull_request) Successful in 7m56s
29e7cf185e
Why: PR #567 CI runs without a global Git user identity, causing every successful agent transport commit to fail with exit 128.

Evidence: The focused no-identity regression plus AgentExecControllerTests and AgentExecHistoryTests pass (30 executions total); git diff --check passes.

Impact: Supplies a deterministic non-secret identity only to git commit-tree; routing, receipts, and transport validation are unchanged.

Refs: #567
weichen added 1 commit 2026-10-15 09:10:25 +00:00
Treat zombie workers as terminated in tests
ci / svc-realcombo (pull_request) Successful in 1m51s
ci / test (pull_request) Successful in 6m4s
ci / test-pg (pull_request) Successful in 8m12s
3ffd641755
Why: Gitea containers may leave SIGKILLed children as zombies until PID 1 reaps them, while kill -0 still reports success.

Evidence: Both timeout tests and the full AgentExecControllerTests suite pass; git diff --check passes.

Impact: Changes test liveness detection only; genuinely running child processes still fail the assertions.

Refs: #567
weichen merged commit d51828a73a into main 2026-10-15 09:19:33 +00:00
Sign in to join this conversation.
No Reviewers
No labels
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: weichen/Agent-System-Dev#567