Make delivery goal-first and route execution through project CLIs #567

Merged
weichen merged 27 commits from feature/goal-first-delivery into main 2026-10-15 09:19:33 +00:00
27 Commits
Author SHA1 Message Date
weichen 3ffd641755 Treat zombie workers as terminated in tests
ci / svc-realcombo (pull_request) Successful in 1m51s
ci / test (pull_request) Successful in 6m4s
ci / test-pg (pull_request) Successful in 8m12s
Why: Gitea containers may leave SIGKILLed children as zombies until PID 1 reaps them, while kill -0 still reports success.

Evidence: Both timeout tests and the full AgentExecControllerTests suite pass; git diff --check passes.

Impact: Changes test liveness detection only; genuinely running child processes still fail the assertions.

Refs: #567
2026-10-15 09:10:24 +00:00
weichen 29e7cf185e Make transport commits independent of Git identity
ci / svc-realcombo (pull_request) Successful in 2m1s
ci / test (pull_request) Failing after 3m50s
ci / test-pg (pull_request) Successful in 7m56s
Why: PR #567 CI runs without a global Git user identity, causing every successful agent transport commit to fail with exit 128.

Evidence: The focused no-identity regression plus AgentExecControllerTests and AgentExecHistoryTests pass (30 executions total); git diff --check passes.

Impact: Supplies a deterministic non-secret identity only to git commit-tree; routing, receipts, and transport validation are unchanged.

Refs: #567
2026-10-15 08:59:17 +00:00
weichen b4139a56d2 Link the delivery pull request
ci / svc-realcombo (pull_request) Successful in 2m14s
ci / test (pull_request) Failing after 4m0s
ci / test-pg (pull_request) Successful in 8m4s
Why: Make PR #567 the task card primary delivery record before CI and merge.

Evidence: https://git-home.u1680832.nyat.app:30319/weichen/Agent-System-Dev/pulls/567

Impact: Updates only task metadata; implementation behavior is unchanged.

Refs: #567
2026-10-15 08:43:23 +00:00
weichen 8184275cd2 Record independent delivery review
ci / svc-realcombo (pull_request) Successful in 2m13s
ci / test (pull_request) Failing after 3m58s
ci / test-pg (pull_request) Successful in 8m16s
Why: Record the fixed-candidate validation and independent fresh-session review before opening the delivery PR.

Evidence: PI MiniMax-M3 session 01a13eb4-5e25-70e9-95ae-2342ec525fac reported NO_FINDINGS for fec42e0320c458a8aa060ce9295f332a3ec6d58d; make test and make build passed.

Impact: Updates only delivery metadata; implementation behavior is unchanged.

Refs: feature/goal-first-delivery
2026-10-15 08:41:57 +00:00
weichen fec42e0320 Allow execution history in fallback isolation test
Why: execution history intentionally adds one source-external Git metadata path after every run

Evidence: focused fallback and history tests

Impact: preserves the no-canonical-implementation assertion while accepting the history record

Refs: feature/goal-first-delivery
2026-10-15 08:27:28 +00:00
weichen 36daf3322e Record the sync checkpoint
Why: bind the task validation checkpoint to the integration baseline.

Evidence: SELF recursive component checks; sync_base=919f75cf7b39ca357e212a08a0ba5ba3d9a79b51; before_record=5d7f6c79af9594562390430e09b595dd55da7a6e.

Impact: task metadata only.

Refs: .task/feature-goal-first-delivery.md
2026-10-15 08:22:14 +00:00
weichen 5d7f6c79af Merge authoritative main into the task branch
Why: include the current integration baseline before verification.

Evidence: fetched origin/main=919f75cf7b39ca357e212a08a0ba5ba3d9a79b51.

Impact: integrate upstream changes without rewriting task history.

Refs: task-sync
2026-10-15 08:21:50 +00:00
weichen 5bc8aea983 Record goal-first delivery readiness
Why: align the task card with the completed three-CLI routing and execution-history scope

Evidence: source-external probe receipts and git diff --check

Impact: marks implementation complete and final delivery gates pending

Refs: #518
2026-10-15 07:48:17 +00:00
weichen b45c6abaa7 Record execution agent history
Why: retain which CLI handled each task so routing can improve from real outcomes over time

Evidence: AgentExecHistoryTests and git diff --check

Impact: appends sanitized source-external JSONL records without changing run outcomes

Refs: feature/goal-first-delivery
2026-10-15 07:41:51 +00:00
weichen 252686e075 Require fresh sessions across delivery stages
Why: prevent implementation context from contaminating independent design test and review judgments

Evidence: git diff --check

Impact: requires fresh CLI sessions per stage and forbids implementation-session reuse for Review

Refs: feature/goal-first-delivery
2026-10-15 07:11:11 +00:00
weichen 8c98635dfd Route project work through Cursor agy and PI
Why: make the three approved CLIs the only active implementation and test routes

Evidence: adapter unit tests, configuration validation, diff check, and real marker probes for all three profiles

Impact: narrows project routing and fixes agy prompt binding for noninteractive execution

Refs: feature/goal-first-delivery
2026-10-15 06:48:06 +00:00
weichen 60e3b705c2 Prioritize minimal goal delivery
Why: prevent unrequested platform work and repeated validation from delaying simple user goals

Evidence: git diff --check

Impact: makes scope discipline, proportional testing, and usable-first stop rules immediately effective

Refs: feature/goal-first-delivery
2026-10-15 06:35:14 +00:00
weichen f93ef567c7 Isolate execution agents from shared Git refs
Why: prevent unrelated sibling worktree delivery from invalidating otherwise safe agent attempts
Evidence: 58 focused tests, configuration validation, governance regression, and diff check
Impact: uses private shared clones and copies only host-owned transport refs back to canonical Git
Refs: U5 runtime acceptance; docs/superpowers/plans/2026-10-15-project-agent-execution.md
2026-10-15 06:19:10 +00:00
weichen 8c1649b232 Stop stalled execution agents on idle timeout
Why: prevent silent provider stalls from consuming the full execution timeout

Evidence: 57 focused tests, configuration validation, 401-test governance regression, and diff check

Impact: adds backward-compatible idle_timeout_seconds and fail-stop process supervision

Refs: U5 runtime acceptance; docs/superpowers/plans/2026-10-15-project-agent-execution.md
2026-10-15 05:41:37 +00:00
weichen dee06368ea Add real execution agent probe harness
Why: verify configured Agent CLIs one profile at a time before declaring them usable

Evidence: 53 focused tests, agent-exec validation, 397-test governance regression, and diff check

Impact: adds opt-in source-external probes, acceptance checks, and current task records

Refs: U5; docs/superpowers/plans/2026-10-15-project-agent-execution.md
2026-10-15 05:22:00 +00:00
weichen 0f4c5c017d Route project work through configured agents
Why: replace fixed Cursor execution authority with project-configured agent routing
Evidence: focused task-card contract, agent-exec validation, governance regression, and diff check
Impact: updates project policy, task templates, capability records, and current task metadata
Refs: U4; docs/superpowers/plans/2026-10-15-project-agent-execution.md
2026-10-15 05:03:14 +00:00
weichen 8f11d002ae Add recoverable execution agent controller
Why: provide isolated, recoverable per-unit CLI execution and safe host fallback
Evidence: 43 focused tests, configuration validation, governance regression, and diff check
Impact: adds agent-exec validate/run controller, receipts, transports, and Make entrypoint
Refs: U3; docs/superpowers/plans/2026-10-15-project-agent-execution.md
2026-10-15 04:46:25 +00:00
weichen 92330a225f Add execution CLI adapter registry
Why: Hide provider-specific noninteractive, model, permission, workspace, prompt, and output differences behind one adapter seam.

Evidence: Cursor observed red then 22 green config/adapter tests; the host replays them and whitespace checks during integration.

Impact: Adds deterministic direct-argv adapters and probes without launching providers or enabling project routing.

Refs: docs/superpowers/plans/2026-10-15-project-agent-execution.md
2026-10-15 02:55:14 +00:00
weichen bdad8ffc91 Add project execution agent configuration
Why: Establish one validated project-local routing document before any real Agent execution is enabled.

Evidence: Cursor observed red then 12 green configuration tests; the host replays those tests, the temporary validation target, and whitespace checks during integration.

Impact: Adds the U1 configuration contract and parser only; real routing, adapters, controller execution, and governance adoption remain disabled.

Refs: docs/superpowers/plans/2026-10-15-project-agent-execution.md
2026-10-15 02:17:29 +00:00
weichen 05e45a9044 Plan project execution agent routing
Why: Turn the approved multi-CLI routing design into independently testable Cursor implementation units without another manual plan gate.

Evidence: The plan self-review found R1-R10 coverage, stable interfaces, five review-focus tests, and no placeholders or whitespace errors.

Impact: Authorizes U1-U5 execution through fresh Cursor Agent runs while the host retains scope, verification, integration, and delivery control.

Refs: docs/superpowers/specs/2026-10-15-project-agent-execution-design.md
2026-10-15 01:51:04 +00:00
weichen 5ff0a4d510 Design project-level execution agent routing
Why: Let each project route expensive implementation work across available Agent CLIs while the host model retains planning and delivery control.

Evidence: The specification passed placeholder, consistency, scope, path, and whitespace self-checks; implementation and runtime validation remain NOT_RUN.

Impact: Defines a review-only R1-R10 design for Markdown configuration, adapters, run-everything execution, receipts, recovery, and host fallback without enabling the new route.

Refs: .task/feature-goal-first-delivery.md
2026-10-15 01:45:15 +00:00
weichen cc03710240 Record approved candidate and delivery window
Why: Preserve the stage-six approval, resolved synchronization result, and exclusive final-window claim before fixing the tested candidate.

Evidence: make task-sync incorporated origin/main at cc40e10 with changed=0 after the conflict-resolution merge; queue claim is issue #518 comment 6478.

Impact: Advances this task to formal verification without changing implementation behavior or expanding its scope.

Refs: .task/feature-goal-first-delivery.md
2026-10-15 01:03:33 +00:00
weichen 86c8d715af Merge current main into goal-first delivery
Why: Synchronize the approved policy candidate with the active simplified merge-window rules now on origin/main.

Evidence: Resolved the two semantic conflicts by preserving upstream queue simplification and this task's goal-first/cursor-per-unit contract; focused task-card regression and cached diff checks passed.

Impact: Retains the active single-window delivery process while replacing mechanical stage approvals with necessary decisions and preserving Cursor-per-unit execution.

Refs: .task/feature-goal-first-delivery.md
2026-10-15 01:01:46 +00:00
weichen 8b7e8ca1d1 Record Cursor implementation receipts
Why: Keep the task authority, execution attempts, and stage-six candidate state recoverable.

Evidence: make evidence captured the controller status for P2 at canonical commit d79d6c17 and the run-wide governance verification receipt.

Impact: Records one failed no-change attempt, one successful Cursor attempt, host integration, and all remaining NOT_RUN stages without changing implementation behavior.

Refs: .task/feature-goal-first-delivery.md
2026-10-14 17:17:19 +00:00
weichen d79d6c17e9 Require Cursor for every implementation unit
Why: Ensure implementation authorship is delegated per unit while the primary model remains responsible for planning and delivery management.

Evidence: The focused task-card generation regression went red then green, and git diff --check passed.

Impact: Every repository-writing implementation unit gets a fresh Cursor CLI run; unavailable or failed Cursor work is recorded as a blocker instead of being silently implemented by the primary model.

Refs: .task/feature-goal-first-delivery.md
2026-10-14 17:10:20 +00:00
weichen 90265ac670 Prioritize task goals and usable delivery
Why: Keep authorized work focused on its stated outcome, prevent private scope expansion, and remove mechanical human stage gates.

Evidence: make test-governance passed 344 tests with 18 environment-dependent skips; receipt is recorded in the task card.

Impact: New tasks use goal-first execution while retaining real decision points, independent review, evidence, platform admission, and high-consequence dual keys.

Refs: .task/feature-goal-first-delivery.md
2026-10-14 16:55:04 +00:00
weichen e049225cda Record the task card for feature-goal-first-delivery
Why: establish the authorized task workspace and its initial baseline.

Evidence: preserved precheck receipt in .task/feature-goal-first-delivery.md; R0=33261925a10c4eee40d1b6175b3895e78a47ef02.

Impact: task metadata only; the feature workspace starts at 33261925a1.

Refs: .task/feature-goal-first-delivery.md
2026-10-14 16:42:47 +00:00