Normalize the rebuild args comparison to stop spurious drop warnings #189

2026-10-05T02:24:30Z

weichen commented

2026-10-05 02:24:30 +00:00

Why

adjust_args_for_bin 返回值去首空格而重建 args 保留首空格，导致每次带 --dsn/--auth 的重建都误报「旧版本二进制已自动省略」——参数实际全保留，该警告在排障时会误导（正是 #188 事故类问题的排障噪音）。

What

比较前对 args 做同样的首空格归一（${args# }），警告仅在 flag 真被过滤时触发。

Evidence

bash -n 通过；真实 dev 二进制下归一化比较无误报、参数完整保留。
make test 全绿（exit 0）。task-sync synced（R0 73041b49fd → head 421ee87）。

Impact

仅告警触发条件修正；start/deploy 行为不变。

Refs

PR #188（前置修复）

## Why adjust_args_for_bin 返回值去首空格而重建 args 保留首空格，导致每次带 --dsn/--auth 的重建都误报「旧版本二进制已自动省略」——参数实际全保留，该警告在排障时会误导（正是 #188 事故类问题的排障噪音）。 ## What 比较前对 args 做同样的首空格归一（${args# }），警告仅在 flag 真被过滤时触发。 ## Evidence - bash -n 通过；真实 dev 二进制下归一化比较无误报、参数完整保留。 - make test 全绿（exit 0）。task-sync synced（R0 73041b49fd → head 421ee87）。 ## Impact 仅告警触发条件修正；start/deploy 行为不变。 ## Refs - PR #188（前置修复）

weichen added 3 commits 2026-10-05 02:24:30 +00:00

Record the task card for feature-svc-adjust-warn-fix 42e32f1596

Normalize the rebuild args comparison to stop spurious drop warnings 421ee87d04

Why: adjust_args_for_bin strips the leading space of its return while the
rebuilt args keep it, so every rebuild carrying --dsn/--auth compared
unequal and warned that the legacy binary had the flags dropped even when
nothing was dropped — misleading during incident triage.

Evidence: bash -n clean; against the real dev binary the normalized
comparison reports no drop and the flags survive intact; make test green.

Impact: warning now fires only when flags are actually filtered; no
behavioral change to start/deploy.

Refs: PR #188

Record the sync checkpoint

ci / test (pull_request) Successful in 1m53s

Details

5bd22e4ccd

weichen merged commit 40ee4a1112 into main

2026-10-05 02:24:35 +00:00

weichen referenced this pull request

2026-10-13 04:38:24 +00:00

Wire login recovery follow-up: SSE close, browser e2e, proposal r3 #508

weichen referenced this issue from a commit

2026-10-13 04:38:25 +00:00

Wire login recovery follow-up: SSE close, browser e2e, proposal r3