Normalize the rebuild args comparison to stop spurious drop warnings #189

Merged

weichen merged 3 commits from feature/svc-adjust-warn-fix into main

2026-10-05 02:24:35 +00:00

Author	SHA1	Message	Date
weichen	5bd22e4ccd	Record the sync checkpoint ci / test (pull_request) Successful in 1m53s Details	2026-10-05 02:23:33 +00:00
weichen	421ee87d04	Normalize the rebuild args comparison to stop spurious drop warnings Why: adjust_args_for_bin strips the leading space of its return while the rebuilt args keep it, so every rebuild carrying --dsn/--auth compared unequal and warned that the legacy binary had the flags dropped even when nothing was dropped — misleading during incident triage. Evidence: bash -n clean; against the real dev binary the normalized comparison reports no drop and the flags survive intact; make test green. Impact: warning now fires only when flags are actually filtered; no behavioral change to start/deploy. Refs: PR #188	2026-10-05 02:23:32 +00:00
weichen	42e32f1596	Record the task card for feature-svc-adjust-warn-fix	2026-10-05 02:22:29 +00:00

Author

SHA1

Message

Date

weichen

5bd22e4ccd

Record the sync checkpoint

ci / test (pull_request) Successful in 1m53s

Details

2026-10-05 02:23:33 +00:00

weichen

421ee87d04

Normalize the rebuild args comparison to stop spurious drop warnings

Why: adjust_args_for_bin strips the leading space of its return while the
rebuilt args keep it, so every rebuild carrying --dsn/--auth compared
unequal and warned that the legacy binary had the flags dropped even when
nothing was dropped — misleading during incident triage.

Evidence: bash -n clean; against the real dev binary the normalized
comparison reports no drop and the flags survive intact; make test green.

Impact: warning now fires only when flags are actually filtered; no
behavioral change to start/deploy.

Refs: PR #188

2026-10-05 02:23:32 +00:00

weichen

42e32f1596

Record the task card for feature-svc-adjust-warn-fix

2026-10-05 02:22:29 +00:00