Advance UI and frontend pins for the single preview pane #200

Merged
weichen merged 5 commits from feature/preview-scroll-consolidate into main 2026-10-05 04:45:38 +00:00
Owner

Summary

  • Pin modules/ui and modules/frontend to the mains that make the preview pane the only scrolling preview.
  • The pane no longer pins .ui-fp to the column height, docx refit follows page height, and the DocViewer overlay is gone.

Test plan

  • make test after make task-sync (frontend 82 tests, ui 103 tests, backend and library tests)
  • Headless Chromium layout: a 1400px docx host scrolls inside a 764px pane; the pdf iframe fills that pane
  • Logged-in manual pass across docx / xlsx / pptx / pdf / md / code, normal and expanded

Refs: Agent-System-UI#36, Agent-System-Frontend#46, Agent-System-Dev#196

## Summary - Pin modules/ui and modules/frontend to the mains that make the preview pane the only scrolling preview. - The pane no longer pins `.ui-fp` to the column height, docx refit follows page height, and the DocViewer overlay is gone. ## Test plan - [x] `make test` after `make task-sync` (frontend 82 tests, ui 103 tests, backend and library tests) - [x] Headless Chromium layout: a 1400px docx host scrolls inside a 764px pane; the pdf iframe fills that pane - [ ] Logged-in manual pass across docx / xlsx / pptx / pdf / md / code, normal and expanded Refs: Agent-System-UI#36, Agent-System-Frontend#46, Agent-System-Dev#196
weichen added 5 commits 2026-10-05 04:45:33 +00:00
Why: The right-hand preview clipped docx instead of scrolling, and a second overlay viewer duplicated FilePreview. Both fixes are already on the module mains.
Evidence: make test passed in the task worktree (boundaries, pins, libs, core, backend, frontend 82 tests, ui 103 tests, agent-command).
Impact: modules/ui moves to 27d5adb (icons #36 and contrast #37). modules/frontend moves to 0a0b556 (preview scroll #46, including contrast #45).
Refs: Agent-System-UI#36, Agent-System-Frontend#46, Agent-System-Dev#196
Co-authored-by: Cursor <cursoragent@cursor.com>
Record the post-sync preview acceptance on the task card
ci / test (pull_request) Successful in 2m49s
7e6f4bd596
Why: task-sync appended the checkpoint outside the sync table, and the card still described the pre-sync test run.
Evidence: make test passed after the origin/main merge (frontend 82 tests, ui 103 tests, backend and library tests).
Impact: task card only. No code or gitlink change.
Refs: feature/preview-scroll-consolidate
Co-authored-by: Cursor <cursoragent@cursor.com>
weichen merged commit 795bff20f3 into main 2026-10-05 04:45:38 +00:00
Sign in to join this conversation.
No Reviewers
No labels
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: weichen/Agent-System-Dev#200