weichen/Agent-System-Frontend
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Hide member management controls without canManage and guard zero run time #116

Closed
weichen wants to merge 1 commits from fix/multiuser-project-collab into main
pull from: fix/multiuser-project-collab
merge into: :main
Conversation 1 Commits 1 Files Changed 5
+343 -58
weichen commented 2026-10-20 03:55:02 +00:00
Owner
Copy Link
Copy Source

Why: 8788 multi-user verification showed ordinary project members see member-management controls (and trigger 403s), and the live status bar shows an enormous elapsed time when the run start time is the zero timestamp.

Changes:

  • Project settings > 成员: reads canManage from rdm.project.member.list; when false hides the add-member block and per-row role/remove buttons, shows a read-only hint, and skips rdm.role.options.
  • eventTime falls back to now for non-positive parsed timestamps (e.g. 0001-01-01T00:00:00Z).
  • Tests: test/rdm-members-gating.test.tsx, eventTime cases in test/send.test.ts.

Evidence: CI on PR HEAD is authoritative; worker ran tsc/vitest in its isolated workspace (SELF).
Impact: Frontend member section and store helper only. Depends on RDM returning canManage (Agent-System-RDM fix/multiuser-project-collab); without it the section is read-only.
Refs: Dev task fix/multiuser-project-collab; agent-exec transport b496c44 (agy).

Why: 8788 multi-user verification showed ordinary project members see member-management controls (and trigger 403s), and the live status bar shows an enormous elapsed time when the run start time is the zero timestamp. Changes: - Project settings > 成员: reads `canManage` from `rdm.project.member.list`; when false hides the add-member block and per-row role/remove buttons, shows a read-only hint, and skips `rdm.role.options`. - `eventTime` falls back to now for non-positive parsed timestamps (e.g. `0001-01-01T00:00:00Z`). - Tests: `test/rdm-members-gating.test.tsx`, eventTime cases in `test/send.test.ts`. Evidence: CI on PR HEAD is authoritative; worker ran tsc/vitest in its isolated workspace (SELF). Impact: Frontend member section and store helper only. Depends on RDM returning `canManage` (Agent-System-RDM fix/multiuser-project-collab); without it the section is read-only. Refs: Dev task fix/multiuser-project-collab; agent-exec transport b496c44 (agy).
weichen added 1 commit 2026-10-20 03:55:02 +00:00
agent-exec transport 5cc70be566de95cb35d2d8bdfb05b392/b0fcba7575e5
governance / governance (pull_request) Successful in 22s
Details
ci / test-and-build (pull_request) Successful in 43s
Details
b496c4476d
weichen commented 2026-10-20 04:18:15 +00:00
Author
Owner
Copy Link
Copy Source

Superseded: Frontend main merged IAM U4 (#115), which already gates member management via rdm.perm.check. Remaining fixes (eventTime zero-time guard; skip rdm.role.options for non-managers) move to fix/multiuser-project-collab-r2 based on the new main.

Superseded: Frontend main merged IAM U4 (#115), which already gates member management via rdm.perm.check. Remaining fixes (eventTime zero-time guard; skip rdm.role.options for non-managers) move to fix/multiuser-project-collab-r2 based on the new main.
weichen closed this pull request 2026-10-20 04:18:15 +00:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
weichen
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: weichen/Agent-System-Frontend#116