Use a kernel-assigned port in the static deploy test instead of a hardcoded one #668

Merged
weichen merged 13 commits from fix/svc-static-deploy-test-port-flake into main 2026-10-21 10:14:53 +00:00
13 Commits
Author SHA1 Message Date
weichen ee54b3577a Fold-close the task card before merge
ci / svc-realcombo (pull_request) Successful in 2m58s
ci / test (pull_request) Successful in 9m28s
ci / test-pg (pull_request) Successful in 11m22s
Why: close the task card inside its own PR so landing it needs no post-merge backfill or separate close PR.
Evidence: .task/fix-svc-static-deploy-test-port-flake.md -> .task/archive/fix-svc-static-deploy-test-port-flake.md; status 已完成(合入前闭合); PR #668 https://git-home.u1680832.nyat.app:30319/weichen/Agent-System-Dev/pulls/668.
Impact: task metadata only; the card is archived within PR #668 and lands with its merge commit.
Refs: task.sh close --self
2026-10-21 10:02:58 +00:00
weichen e0a8773a85 Unblock and refresh card: status, review re-attest, CI resolution
ci / svc-realcombo (pull_request) Successful in 3m3s
ci / test (pull_request) Successful in 9m31s
ci / test-pg (pull_request) Successful in 11m37s
Why: the previous "blocked" reason (CI infrastructure failures) was
externally resolved by the Backend ResolveHITL fix (PR #237) and its
Dev gitlink repin (PR #674 -> 2fd11eff). Re-review against the
post-Repin baseline PASSes; the card needed to reflect that.

Evidence:
  /tmp/svc-flake-sync-20261021.json: sync to 2fd11eff
  /tmp/svc-flake-finish-test-20261021.json: target test green
  /tmp/svc-flake-svc-tests-20261021.json: 213 svc tests OK (18 skipped)
  /tmp/svc-flake-review-r1-20261021.json: pi-glm, success (review PASS)
  /tmp/multi-instance-with-be-fix-20261021.json: root-cause fix
  /tmp/repin-maketest5-20261021.json: Dev make test green post-Repin

Impact: card metadata only; no behaviour change.
Refs: PR #668; fix/svc-static-deploy-test-port-flake
2026-10-21 10:02:53 +00:00
agent-exec-transport c4528653b1 agent-exec transport 4e08f829778afd338d088a98dfacc2a2/66ad6eb0e6ce
ci / svc-realcombo (pull_request) Successful in 2m54s
ci / test (pull_request) Successful in 9m6s
ci / test-pg (pull_request) Successful in 11m1s
2026-10-21 10:01:59 +00:00
weichen 2841cb4a43 Record the sync checkpoint
Why: bind the task validation checkpoint to the integration baseline.

Evidence: SELF recursive component checks; sync_base=2fd11effd9ccb0ae35ae5a47caccefccbbb05a8e; before_record=c766a81277112907333ac7f1810436aed51cff21.

Impact: task metadata only.

Refs: .task/fix-svc-static-deploy-test-port-flake.md
2026-10-21 09:48:46 +00:00
weichen c766a81277 Merge authoritative main into the task branch
Why: include the current integration baseline before verification.

Evidence: fetched origin/main=2fd11effd9ccb0ae35ae5a47caccefccbbb05a8e.

Impact: integrate upstream changes without rewriting task history.

Refs: task-sync
2026-10-21 09:48:06 +00:00
weichen b1af81d5af Mark the port-flake fix blocked on CI infrastructure failures
ci / svc-realcombo (pull_request) Successful in 4m57s
ci / test (pull_request) Successful in 8m38s
ci / test-pg (pull_request) Successful in 10m17s
Why: three consecutive CI attempts on this branch failed for reasons outside
the diff (two npm registry ECONNRESETs, one real-RDM fixture startup exit),
and the run-level rerun endpoint is now exhausted. Merging needs all three
required jobs green on the exact head, so the task stops here rather than
looping on retries.

Evidence: runs 4592 (job 7579), 4594 (jobs 7586, 7590) at head 01b6745; the
`test` job, which is the one that runs tests/test_svc.py, passed on 01b6745.

Impact: task card only. Code stays as reviewed.

Refs: PR #668
2026-10-21 03:41:49 +00:00
weichen 01b6745def Record the npm registry ECONNRESET CI failure for PR #668
ci / svc-realcombo (pull_request) Failing after 2m22s
ci / test (pull_request) Successful in 8m36s
ci / test-pg (pull_request) Successful in 12m31s
Why: the first CI wait on 996cbf0 failed in the test job, but the failure
is `npm ci` losing its TLS connection to registry.npmjs.org while fetching
zrender, not anything in this change. The card must say so plainly instead
of leaving CI as NOT_RUN.

Evidence: run 4592, job 7579. Same log shows the Python governance suite
at 518 tests OK (skipped=35), so the target case passed in CI.

Impact: task card only.

Refs: PR #668
2026-10-21 03:27:49 +00:00
weichen 996cbf07e1 Replace the hardcoded static-deploy test port with a kernel-assigned one
ci / svc-realcombo (pull_request) Successful in 2m34s
ci / test (pull_request) Failing after 9m13s
ci / test-pg (pull_request) Successful in 12m42s
Why: test_static_fresh_deploy_registers_pidcheck_and_starts hardcoded
port 18951, so any process already holding that port made svc.sh refuse
to bind (correct behaviour) and the test failed for a reason unrelated to
what it guards. Host reproduced this deterministically: with 18951
occupied the case failed, on a clean host it passed 10/10.

Evidence: fix/svc-static-deploy-test-port-flake @ 4ebf9e1, SELF receipts
7dfe7b09 (target case clean, target case while 18951 is held, whole
tests.test_svc module 23 tests) and the earlier 518-test test-affected
run; independent review session (pi/glm-5.3-flash, fresh process)
concluded PASS.

Impact: tests/test_svc.py only. All eight assertions kept verbatim;
svc.sh is untouched, and the tests/test_svc.py:753-754 register_pg
fixture is deliberately left alone.

Refs: tests/test_svc.py:989
2026-10-21 03:17:12 +00:00
weichen 4ebf9e1b47 Record the sync checkpoint
Why: bind the task validation checkpoint to the integration baseline.

Evidence: SELF recursive component checks; sync_base=a496ea0f0249b2b412354677ef97612ccd692d25; before_record=bbb9024e9718497adf0d6385f6795cb5c7d9255f.

Impact: task metadata only.

Refs: .task/fix-svc-static-deploy-test-port-flake.md
2026-10-21 03:16:00 +00:00
weichen bbb9024e97 Merge authoritative main into the task branch
Why: include the current integration baseline before verification.

Evidence: fetched origin/main=a496ea0f0249b2b412354677ef97612ccd692d25.

Impact: integrate upstream changes without rewriting task history.

Refs: task-sync
2026-10-21 03:15:17 +00:00
weichen 0bd5a4b0c9 Record the port-flake verification evidence for the svc static deploy test
Why: the task card needs the host-captured run that shows the fixed test passes
both on a clean host and while the legacy hard-coded port is held by a foreign
process, so the review and merge gate can re-check the claim instead of trusting
the worker's self-report.

Evidence: receipt 314db6279eec9bfc (SELF), tested head d0b217d3, exit 0.

Impact: task card only.

Refs: fix/svc-static-deploy-test-port-flake
2026-10-21 03:05:34 +00:00
agent-exec-transport d0b217d3a4 agent-exec transport 850b1455fe23d71cb5cd28eb43df9069/5ca3ade8a790 2026-10-21 02:49:58 +00:00
weichen 409f4749dd Record the task card for fix-svc-static-deploy-test-port-flake
Why: establish the authorized task workspace and its initial baseline.

Evidence: preserved precheck receipt in .task/fix-svc-static-deploy-test-port-flake.md; R0=a9566a68505ac97dead15ed3b5672954f15cea1c.

Impact: task metadata only; the feature workspace starts at a9566a6850.

Refs: .task/fix-svc-static-deploy-test-port-flake.md
2026-10-21 02:38:22 +00:00