Agent stack audit remediation batch 1 (U1-U7, U10) #685

Merged
weichen merged 20 commits from feature/agent-stack-audit-remediation-b1 into main 2026-10-21 19:52:33 +00:00
Owner

Close the correctness/safety half of the agent stack audit: execution isolation, result honesty and recovery safety across agent-native, agent-squad, agent-intent, agent-command and modules/backend.

Why: the approved remediation plan (docs/superpowers/plans/2026-10-21-agent-stack-audit-remediation-plan.md) found ten P1/P2 defects with concrete triggers; batch 1 fixes F01-F10 and F13 via units U1-U7 and U10.

Evidence: per-unit agent-per-unit receipts recorded in the task card with SELF verification (all exit=0); full combination make test green on the final merged candidate d55e57dd (verify-combo-final.json). Independent review receipt follows in the task card before merge.

Impact: five component pins advanced; batch-1 semantics only — no deploy, no migration, no release. Batch 2 (U8/U9/U11) and functional follow-ups A1-A4 are explicitly out of scope.

Refs: docs/superpowers/plans/2026-10-21-agent-stack-audit-remediation-plan.md

Close the correctness/safety half of the agent stack audit: execution isolation, result honesty and recovery safety across agent-native, agent-squad, agent-intent, agent-command and modules/backend. Why: the approved remediation plan (docs/superpowers/plans/2026-10-21-agent-stack-audit-remediation-plan.md) found ten P1/P2 defects with concrete triggers; batch 1 fixes F01-F10 and F13 via units U1-U7 and U10. Evidence: per-unit agent-per-unit receipts recorded in the task card with SELF verification (all exit=0); full combination `make test` green on the final merged candidate d55e57dd (verify-combo-final.json). Independent review receipt follows in the task card before merge. Impact: five component pins advanced; batch-1 semantics only — no deploy, no migration, no release. Batch 2 (U8/U9/U11) and functional follow-ups A1-A4 are explicitly out of scope. Refs: docs/superpowers/plans/2026-10-21-agent-stack-audit-remediation-plan.md
weichen added 16 commits 2026-10-21 18:38:19 +00:00
Why: establish the authorized task workspace and its initial baseline.

Evidence: preserved precheck receipt in .task/feature-agent-stack-audit-remediation-b1.md; R0=d9e9c0560a2767539f4415b579adbeff86a22ba6.

Impact: task metadata only; the feature workspace starts at d9e9c0560a.

Refs: .task/feature-agent-stack-audit-remediation-b1.md
Why: record the audited findings and the batched remediation contract
(U1-U11) that subsequent implementation units must satisfy.
Evidence: document-only change; no code paths touched.
Impact: docs only; plan is the scope authority for the remediation task.
Refs: feature/agent-stack-audit-remediation-b1
Why: carry authorization, scope, wave plan and receipt tables for the
agent-per-unit implementation of U1-U7 and U10.
Evidence: card + receipts under /tmp; no code change.
Impact: task metadata only (exempt path).
Refs: docs/superpowers/plans/2026-10-21-agent-stack-audit-remediation-plan.md
Why: track per-unit agent-per-unit receipts and verification for U1/U5/U7a.
Evidence: receipts under /tmp/agent-stack-b1; SELF verification exit=0.
Impact: task metadata only.
Refs: feature/agent-stack-audit-remediation-b1
Why: keep the per-unit audit trail; U10 first run failed-unknown
(pi attempt exited 0 without a decodable terminal record), workspace
preserved for reconciliation and the unit re-dispatched with a corrected
packet (nested deps gitlinks materialized).
Evidence: verify-u2/u4/u4b exit=0; no code change.
Impact: task metadata only.
Refs: feature/agent-stack-audit-remediation-b1
Why: keep the per-unit audit trail current.
Evidence: verify-u10b/verify-u3a exit=0.
Impact: task metadata only.
Refs: feature/agent-stack-audit-remediation-b1
Why: keep the per-unit audit trail current.
Evidence: verify-u6 exit=0; U3B first run failed-unknown on a
pre-session cursor TLS failure (553B log, zero changes, workspace
preserved), reconciled as environmental and re-dispatched.
Impact: task metadata only.
Refs: feature/agent-stack-audit-remediation-b1
Why: keep the per-unit audit trail current; cursor and antigravity
prove broken (quota/model-rejection, 400 location block), routing
adjusted with recorded reasons.
Evidence: verify-u7b exit=0.
Impact: task metadata only.
Refs: feature/agent-stack-audit-remediation-b1
Why: all ten batch-1 units implemented and individually verified.
Evidence: verify-u3b exit=0 (race).
Impact: task metadata only.
Refs: feature/agent-stack-audit-remediation-b1
Why: land U1-U7 and U10 across agent-native (5c0d2d8), agent-squad
(23f161b), agent-intent (765a7e7), agent-command (fe7987d) and
modules/backend (4030449) per the approved remediation plan.
Evidence: per-unit SELF receipts under /tmp/agent-stack-b1 all exit=0;
combination verification (make test) recorded next on this branch.
Impact: five component gitlinks; no other Dev paths.
Refs: docs/superpowers/plans/2026-10-21-agent-stack-audit-remediation-plan.md
Why: the backend branch advanced to 49c1259 with the U6 boundary
repair (admission test reworked behind intentgate helpers).
Evidence: repair receipt success; verify-u6r2 exit=0; combination
make test re-run follows on this branch.
Impact: one component gitlink.
Refs: feature/agent-stack-audit-remediation-b1
Why: check-pins requires each container's nested gitlinks to equal the
Dev top-level pins; the batch-1 bumps left native/squad/backend
containers pinned at pre-batch sibling versions.
Evidence: integration transport success (gitlink3-run.json); full
make test re-run follows on this branch.
Impact: three component gitlinks.
Refs: feature/agent-stack-audit-remediation-b1
Why: the U3B sqlite repair advanced the squad container to 0f1daa8 and
backend's nested-squad pin follow-up moved backend to 1f61131.
Evidence: integration transport success (gitlink4-run.json); full
make test re-run follows on this branch.
Impact: two component gitlinks.
Refs: feature/agent-stack-audit-remediation-b1
Why: close out the batch-1 audit trail before review and PR.
Evidence: make test exit=0 on the fully repinned combination
(verify-combo-make-test4.json).
Impact: task metadata only.
Refs: feature/agent-stack-audit-remediation-b1
Why: backend main advanced to 528e3a4 (surface conversation required,
card backfills); the backend task branch merges it into the batch-1
line and the Dev pin follows.
Evidence: integration transport success (gitlink5-run.json); backend
build green on the merge; full make test re-run follows.
Impact: one component gitlink.
Refs: feature/agent-stack-audit-remediation-b1
Merge authoritative main into the task branch
ci / test (pull_request) Failing after 3s
ci / svc-realcombo (pull_request) Failing after 3s
ci / test-pg (pull_request) Failing after 3s
d55e57dded
Why: include the current integration baseline before verification.

Evidence: fetched origin/main=b25846d2.

Impact: integrate upstream changes without rewriting task history.

Refs: task-sync
weichen added 2 commits 2026-10-21 19:32:29 +00:00
Record the independent review approval in the task card
ci / svc-realcombo (pull_request) Failing after 3s
ci / test (pull_request) Failing after 3s
ci / test-pg (pull_request) Failing after 3s
f23d1df72a
Why: batch-1 review verdict APPROVE (0 blockers, 0 majors, 5 minor
follow-up notes) from an independent CLI session; report committed.
Evidence: review receipt /tmp/agent-stack-b1/review4-run.json
(pi-glm, success).
Impact: task metadata + review report.
Refs: PR #685
weichen added 1 commit 2026-10-21 19:33:28 +00:00
Record the review verdict and the CI checkout fix in the card
ci / svc-realcombo (pull_request) Successful in 2m4s
ci / test (pull_request) Successful in 7m37s
ci / test-pg (pull_request) Successful in 8m44s
e08c497f39
Why: the independent review approved batch 1 (APPROVE, 0 blockers);
the first CI run failed at checkout because the five pinned component
commits were local-only and are now pushed.
Evidence: review4-run.json (pi-glm success); component remote refs
created; this commit retriggers CI.
Impact: task metadata only.
Refs: PR #685
weichen added 1 commit 2026-10-21 19:42:47 +00:00
Fold-close the task card before merge
ci / svc-realcombo (pull_request) Successful in 2m3s
ci / test (pull_request) Successful in 7m38s
ci / test-pg (pull_request) Successful in 9m19s
18425f350a
Why: close the task card inside its own PR so landing it needs no post-merge backfill or separate close PR.
Evidence: .task/feature-agent-stack-audit-remediation-b1.md -> .task/archive/feature-agent-stack-audit-remediation-b1.md; status 已完成(合入前闭合); PR #685 https://git-home.u1680832.nyat.app:30319/weichen/Agent-System-Dev/pulls/685.
Impact: task metadata only; the card is archived within PR #685 and lands with its merge commit.
Refs: task.sh close --self
weichen merged commit 485ebd792b into main 2026-10-21 19:52:33 +00:00
Sign in to join this conversation.
No Reviewers
No labels
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: weichen/Agent-System-Dev#685